Re: [PATCH net-next 1/2] mpls: packet stats

2016-07-28 Thread Roopa Prabhu
On 2/5/16, 11:27 AM, Robert Shearman wrote: > Having MPLS packet stats is useful for observing network operation and > for diagnosing network problems. In the absence of anything better, > use RFCs for MIBs defining MPLS stats for guidance on the semantics of > the stats to expose. RFC3813 details

Re: [PATCH v2 4/4] ARM: OMAP2+: omap_device: fix crash on omap_device removal

2016-07-28 Thread Peter Ujfalusi
On 07/28/16 20:50, Grygorii Strashko wrote: > Below call chain causes system crash when OMAP device is > removed by calling of_platform_depopulate()/device_del(): Should you swap 3 <-> 4 in the series? Currently patch 3 will introduce the crash you are fixing in patch 4... > > device_del() > -

[PATCH net] tcp: consider recv buf for the initial window scale

2016-07-28 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh tcp_select_initial_window() intends to advertise a window scaling for the maximum possible window size. To do so, it considers the maximum of net.ipv4.tcp_rmem[2] and net.core.rmem_max as the only possible upper-bounds. However, users with

[PATCH] bpf: fix size of copy_to_user in percpu map.

2016-07-28 Thread William Tu
The total size of value copy_to_user() writes to userspace should be the (current number of cpu) * (value size), instead of num_possible_cpus() * (value size). Found by samples/bpf/test_maps.c, which always copies 512 byte to userspace, crashing the userspace program stack. Signed-off-by:

Re: [Intel-wired-lan] [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-28 Thread Francois Romieu
Eric Dumazet : [...] > I would prefer having a definitive advice from Thomas Gleixner and/or > others if disable_irq() is forbidden from IRQ path. > > As I said, about all netpoll() methods in net drivers use disable_irq() > so a lot of patches would be needed. s/about

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Saeed Mahameed
On Thu, Jul 28, 2016 at 12:37 PM, Leon Romanovsky wrote: > On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote: >> A dedicated workqueue has been used since the work items are being used >> on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Saeed Mahameed
On Thu, Jul 28, 2016 at 11:19 AM, Bhaktipriya Shridhar wrote: > A dedicated workqueue has been used since the work items are being used > on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward > progress under memory pressure. > > The workqueue has a

Re: [RFC] net/mlx5_core/en_main: Remove deprecated create_workqueue

2016-07-28 Thread Saeed Mahameed
On Wed, Jul 27, 2016 at 9:12 AM, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. > > A dedicated workqueue has been used since mlx5e workqueue was

Greetings Dear.

2016-07-28 Thread Eminado Justin Yak
Hello Dear It is really a pleasure to meet you, I'm eminado by name, please write me on my e-mail through eminadojustin_...@yahoo.com so that i can send you my details with my pictures and also learn more about you, hope to hear from you soonest, Eminado Justin Yak.

Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

2016-07-28 Thread Francois Romieu
Hau : [...] > > Either the driver resumes the device so that it can perform requested > > operation or it signals .set_wol failure when the device is suspended. > > > > If the driver does something else, "spam removal" translates to "silent > > failure". > > Because

㊣Hi

2016-07-28 Thread hi
hi this is an electronics shop bike,brand guitar,camera,tv,samsung product free shipping www .slooone .com

Re: [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe()

2016-07-28 Thread Iyappan Subramanian
On Wed, Jul 27, 2016 at 7:12 PM, Wei Yongjun wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun > --- > drivers/net/phy/mdio-xgene.c | 4

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

2016-07-28 Thread Timur Tabi
Lino Sanfilippo wrote: + skb = dev_alloc_skb(adpt->rxbuf_size + NET_IP_ALIGN); + if (!skb) + break; + + /* Make buffer alignment 2 beyond a 16 byte boundary +* this will result in a 16 byte aligned IP header after +

Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-07-28 Thread Maxime Ripard
On Thu, Jul 28, 2016 at 03:40:31PM +0200, LABBE Corentin wrote: > On Thu, Jul 21, 2016 at 09:55:19AM +0200, Maxime Ripard wrote: > > Hi, > > > > On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote: > > > This patch adds documentation for Device-Tree bindings for the > > > Allwinner

[PATCH v2 0/4] drivers: net: cpsw: fix driver loading/unloading

2016-07-28 Thread Grygorii Strashko
This series fixes set of isssues observed when CPSW driver module is unloaded/loaded: 1) rmmod: deadlock in cpdma_ctlr_destroy 2) rmmod: L3 back-trace and crash if all net interfaces are down, because CPSW can be powerred down by PM runtime in this case. 3) insmod: mdio device is not recreated on

[PATCH v2 4/4] ARM: OMAP2+: omap_device: fix crash on omap_device removal

2016-07-28 Thread Grygorii Strashko
Below call chain causes system crash when OMAP device is removed by calling of_platform_depopulate()/device_del(): device_del() - blocking_notifier_call_chain(>bus->p->bus_notifier, BUS_NOTIFY_DEL_DEVICE, dev); - _omap_device_notifier_call() -

[PATCH v2 1/4] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

2016-07-28 Thread Grygorii Strashko
Fix deadlock in cpdma_ctlr_destroy() which is triggered now on cpsw module removal: cpsw_remove() - cpdma_ctlr_destroy() - spin_lock_irqsave(>lock, flags) - cpdma_ctlr_stop() - spin_lock_irqsave(>lock, flags); - cpdma_chan_destroy() - spin_lock_irqsave(>lock, flags); The

[PATCH v2 2/4] drivers: net: cpsw: fix wrong regs access in cpsw_remove

2016-07-28 Thread Grygorii Strashko
The L3 error will be generated and system will crash during unloading of CPSW driver if CPSW is used as module and ethX devices are down. This happens because CPSW can be power off by PM runtime now when ethX devices are down. Hence, ensure that CPSW powered up by PM runtime before performing any

[PATCH v2 3/4] drivers: net: cpsw: use of_platform_depopulate()

2016-07-28 Thread Grygorii Strashko
Use of_platform_depopulate() in cpsw_remove() instead of of_device_unregister(), because CSPW child devices will not be recreated otherwise on next insmod. of_platform_depopulate() is correct way now as it will ensure that all steps done in of_platform_populate() are reverted, including cleaning

Re: Microsemi VSC 8531/41 PHY Driver

2016-07-28 Thread Florian Fainelli
On 07/27/2016 11:44 PM, Raju Lakkaraju wrote: > Hello Andrew, > > Thank you for given valuable comments. > Please see the my responses inline. > > Thanks, > Raju > > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Tuesday, July 26, 2016 6:14 PM > To: Raju

Re: [PATCH v4] net: sched: convert qdisc linked list to hashtable

2016-07-28 Thread Cong Wang
On Thu, Jul 28, 2016 at 5:53 AM, Fengguang Wu wrote: > On Thu, Jul 28, 2016 at 01:18:27PM +0200, Jiri Kosina wrote: >> This issue is be there even without my patch (but with qdisc_list_add >> instead), isn't it? > > > Yes it looks so, this number happens in a number of places: > >

Re: [PATCH v4] net: sched: convert qdisc linked list to hashtable

2016-07-28 Thread Cong Wang
On Thu, Jul 28, 2016 at 2:56 AM, Jiri Kosina wrote: > From: Jiri Kosina > > Convert the per-device linked list into a hashtable. The primary > motivation for this change is that currently, we're not tracking all the > qdiscs in hierarchy (e.g. excluding default

[PATCH -next] net: ipv6: use list_move instead of list_del/list_add

2016-07-28 Thread Wei Yongjun
Using list_move() instead of list_del() + list_add(). Signed-off-by: Wei Yongjun --- net/ipv6/addrconf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 6287a8b..ab3e796 100644 --- a/net/ipv6/addrconf.c

RE: [PATCH 14/15] ethernet: stmicro: stmmac: stmmac_platform: add missing of_node_put after calling of_parse_phandle

2016-07-28 Thread Peter Chen
>Hi, > >On 07/27/2016 04:20 AM, Peter Chen wrote: >> of_node_put needs to be called when the device node which is got from >> of_parse_phandle has finished using. >> >> Signed-off-by: Peter Chen >> --- >> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 - >>

Re: PROBLEM: TPROXY and DNAT broken (bisected to 079096f103fa)

2016-07-28 Thread Florian Westphal
Brandon Cazander wrote: > Hopefully that's enough detail to replicate this issue. I have the full > environment set up for both working and non-working kernel versions, so > please let me know if there's anything else I can provide. No need, this reproduces

Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver

2016-07-28 Thread LABBE Corentin
On Mon, Jul 25, 2016 at 09:54:55PM +0200, Maxime Ripard wrote: > On Wed, Jul 20, 2016 at 10:03:16AM +0200, LABBE Corentin wrote: > > This patch add support for sun8i-emac ethernet MAC hardware. > > It could be found in Allwinner H3/A83T/A64 SoCs. > > > > It supports 10/100/1000 Mbit/s speed with

[RFC v6 6/6] VSOCK: Add Makefile and Kconfig

2016-07-28 Thread Stefan Hajnoczi
From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v6: * Rename to virtio-vsock kernel modules to vmw_vsock_virtio_transport* instead of just virtio_transport to make the

[RFC v6 5/6] VSOCK: Introduce vhost_vsock.ko

2016-07-28 Thread Stefan Hajnoczi
From: Asias He VM sockets vhost transport implementation. This driver runs on the host. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v6: * Fall back to non-contiguous pages if vsock struct is too large (idea stolen

[RFC v6 4/6] VSOCK: Introduce virtio_transport.ko

2016-07-28 Thread Stefan Hajnoczi
From: Asias He VM sockets virtio transport implementation. This driver runs in the guest. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v6: * Start/stop rx depending on reply packet accounting to bound memory

[RFC v6 3/6] VSOCK: Introduce virtio_vsock_common.ko

2016-07-28 Thread Stefan Hajnoczi
From: Asias He This module contains the common code and header files for the following virtio_transporto and vhost_vsock kernel modules. Signed-off-by: Asias He Signed-off-by: Claudio Imbrenda Signed-off-by: Stefan Hajnoczi

[RFC v6 2/6] VSOCK: defer sock removal to transports

2016-07-28 Thread Stefan Hajnoczi
The virtio transport will implement graceful shutdown and the related SO_LINGER socket option. This requires orphaning the sock but keeping it in the table of connections after .release(). This patch adds the vsock_remove_sock() function and leaves it up to the transport when to remove the sock.

[RFC v6 1/6] VSOCK: transport-specific vsock_transport functions

2016-07-28 Thread Stefan Hajnoczi
struct vsock_transport contains function pointers called by AF_VSOCK core code. The transport may want its own transport-specific function pointers and they can be added after struct vsock_transport. Allow the transport to fetch vsock_transport. It can downcast it to access transport-specific

[RFC v6 0/6] Add virtio transport for AF_VSOCK

2016-07-28 Thread Stefan Hajnoczi
This series is based on v4.7. This RFC is the implementation for the new VIRTIO Socket device. It is developed in parallel with the VIRTIO device specification and proves the design. Once the specification has been accepted I will send a non-RFC version of this patch series. v6: * Add

Re: [PATCH 1/1] ixgbevf: replace integer number with bool value

2016-07-28 Thread Greg
On Wed, 2016-07-27 at 21:28 +0800, Zhu Yanjun wrote: > The variable get_mac_status is a bool variable. So a bool value is > better than an integer number. > > Signed-off-by: Zhu Yanjun Looks good to me. Reviewed-by: Greg Rose > --- >

[PATCH 1/1] ixgbevf: replace integer number with bool value

2016-07-28 Thread Zhu Yanjun
The variable get_mac_status is a bool variable. So a bool value is better than an integer number. Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 2 +- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- 2 files changed, 3

Re: [PATCH 1/2] SUNRPC: accept() may return sockets that are still in SYN_RECV

2016-07-28 Thread Fields Bruce James
On Wed, Jul 27, 2016 at 07:11:23PM +, Trond Myklebust wrote: > Hi Eric, > > > On Jul 27, 2016, at 14:59, Eric Dumazet wrote: > > > > On Wed, 2016-07-27 at 14:48 -0400, Fields Bruce James wrote: > >> On Tue, Jul 26, 2016 at 04:08:29PM +, Trond Myklebust wrote: >

Re: [PATCH net-next 1/3] strparser: Stream parser for messages

2016-07-28 Thread David Ahern
On 7/27/16 3:03 PM, Tom Herbert wrote: diff --git a/net/strparser/strparser.c b/net/strparser/strparser.c new file mode 100644 index 000..d7aec13 --- /dev/null +++ b/net/strparser/strparser.c @@ -0,0 +1,492 @@ missing copyright header? +#include +#include +#include +#include

Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-07-28 Thread LABBE Corentin
On Thu, Jul 21, 2016 at 09:55:19AM +0200, Maxime Ripard wrote: > Hi, > > On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off-by: LABBE Corentin

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-28 Thread Fengguang Wu
Hi Sabrina, The idea when this first came up was to skip the sleeping part of disable_irq(): http://marc.info/?l=linux-netdev=142314159626052 This fell off my todolist and I didn't send the conversion patches, which would basically look like this: Yes it works in the several machines that

[PATCH 1/1] ixgbevf: replace integer number with bool value

2016-07-28 Thread zyjzyj2000
From: Zhu Yanjun The variable get_mac_status is a bool variable. So a bool value is better than an integer number. Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 2 +-

Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-07-28 Thread LABBE Corentin
On Wed, Jul 20, 2016 at 02:15:33PM -0500, Rob Herring wrote: > On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off-by: LABBE Corentin > >

Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver

2016-07-28 Thread LABBE Corentin
On Wed, Jul 20, 2016 at 11:56:12AM +0200, Arnd Bergmann wrote: > On Wednesday, July 20, 2016 10:03:16 AM CEST LABBE Corentin wrote: > > + > > + /* Benched on OPIPC with 100M, setting more than 256 does not give > > any > > +* perf boost > > +*/ > > + priv->nbdesc_rx =

RE: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

2016-07-28 Thread Hau
[...] > Nit: you may directly use "struct device *d = >pci_dev->dev;" > I will do that on my next version patch. Thanks. --Please consider the environment before printing this e-mail.

RE: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

2016-07-28 Thread Hau
[...] > > @@ -1852,12 +1863,17 @@ static int rtl8169_set_wol(struct net_device > *dev, struct ethtool_wolinfo *wol) > > tp->features |= RTL_FEATURE_WOL; > > else > > tp->features &= ~RTL_FEATURE_WOL; > > - __rtl8169_set_wol(tp, wol->wolopts); > > + if

Re: [PATCH v4] net: sched: convert qdisc linked list to hashtable

2016-07-28 Thread Fengguang Wu
On Thu, Jul 28, 2016 at 01:18:27PM +0200, Jiri Kosina wrote: On Thu, 28 Jul 2016, kbuild test robot wrote: [auto build test ERROR on v4.7-rc7] [also build test ERROR on next-20160728] [cannot apply to net/master net-next/master ipsec-next/master] [if your patch is applied to the wrong git tree

Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable

2016-07-28 Thread Fengguang Wu
Hi Jiri, On Thu, Jul 14, 2016 at 04:14:58PM +0200, Jiri Kosina wrote: [ added CCs ] On Tue, 12 Jul 2016, kbuild test robot wrote: Hi, [auto build test ERROR on net/master] [also build test ERROR on v4.7-rc7 next-20160711] [if your patch is applied to the wrong git tree, please drop us a

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-28 Thread Thomas Gleixner
On Thu, 28 Jul 2016, Sabrina Dubroca wrote: > 2016-07-28, 07:43:55 +0200, Eric Dumazet wrote: > > I would prefer having a definitive advice from Thomas Gleixner and/or > > others if disable_irq() is forbidden from IRQ path. Yes it is. Before we added threaded interrupt handlers it was not an

Re: [PATCH 0/2] net: davinci_cpdma: reduce latency on -rt

2016-07-28 Thread Uwe Kleine-König
Hello Grygorii, On Thu, Jul 28, 2016 at 12:34:19PM +0300, Grygorii Strashko wrote: > Thanks. I've just wanted to have clear understanding of the [possible] issue. > And I'd be appreciated if you could share and measurement results if you have. I didn't measure anything (yet), just considered

Re: [PATCH v4] net: sched: convert qdisc linked list to hashtable

2016-07-28 Thread kbuild test robot
Hi, [auto build test ERROR on v4.7-rc7] [also build test ERROR on next-20160728] [cannot apply to net/master net-next/master ipsec-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH v5 5/8] thunderbolt: Networking state machine

2016-07-28 Thread Lukas Wunner
On Thu, Jul 28, 2016 at 11:15:18AM +0300, Amir Levy wrote: > +static void nhi_handle_notification_msg(struct tbt_nhi_ctxt *nhi_ctxt, > + const u8 *msg) > +{ > + struct port_net_dev *port; > + u8 port_num; > + > +#define INTER_DOMAIN_LINK_SHIFT 0 >

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-07-28 Thread Denys Fedoryshchenko
On 2016-07-28 14:09, Guillaume Nault wrote: On Tue, Jul 12, 2016 at 10:31:18AM -0700, Cong Wang wrote: On Mon, Jul 11, 2016 at 12:45 PM, wrote: > Hi > > On latest kernel i noticed kernel panic happening 1-2 times per day. It is > also happening on older kernel (at

ip=dhcp woes

2016-07-28 Thread Uwe Kleine-König
Hello, I have a machine with four network interfaces and I'm using ip=dhcp during development on it. in ic_dynamic the procedure is the following (assuming no successful reply is received in time): timeout = 2s + random([0, 1]) s loop: send bootp on 1st dev wait 1s send bootp on 2nd dev

Re: [PATCH v4] net: sched: convert qdisc linked list to hashtable

2016-07-28 Thread kbuild test robot
Hi, [auto build test ERROR on v4.7-rc7] [also build test ERROR on next-20160728] [cannot apply to net/master net-next/master ipsec-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH v4] net: sched: convert qdisc linked list to hashtable

2016-07-28 Thread Jiri Kosina
On Thu, 28 Jul 2016, kbuild test robot wrote: > [auto build test ERROR on v4.7-rc7] > [also build test ERROR on next-20160728] > [cannot apply to net/master net-next/master ipsec-next/master] > [if your patch is applied to the wrong git tree, please drop us a note to > help imp

Re: [PATCH v4] net: sched: convert qdisc linked list to hashtable

2016-07-28 Thread kbuild test robot
Hi, [auto build test ERROR on v4.7-rc7] [also build test ERROR on next-20160728] [cannot apply to net/master net-next/master ipsec-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-07-28 Thread Guillaume Nault
On Tue, Jul 12, 2016 at 10:31:18AM -0700, Cong Wang wrote: > On Mon, Jul 11, 2016 at 12:45 PM, wrote: > > Hi > > > > On latest kernel i noticed kernel panic happening 1-2 times per day. It is > > also happening on older kernel (at least 4.5.3). > > > ... > >

skb_release_data causes "BUG: Bad page state"

2016-07-28 Thread Alex Lyakas
Greetings, We had this warning[1] on long-term mainline kernel 3.18.19. Can anybody please advise on what might be causing it. Thanks, Alex. [1] Jul 21 22:57:27 vsa-01cc-vc-1 kernel: [96804.538709] BUG: Bad page state in process kworker/0:1H pfn:4b317 Jul 21 22:57:27 vsa-01cc-vc-1

Re: [Patch net] ppp: defer netns reference release for ppp channel

2016-07-28 Thread Guillaume Nault
On Wed, Jul 06, 2016 at 03:25:15PM +0300, Cyrill Gorcunov wrote: > On Wed, Jul 06, 2016 at 11:26:02AM +0300, Cyrill Gorcunov wrote: > > On Tue, Jul 05, 2016 at 10:12:36PM -0700, Cong Wang wrote: > > > Matt reported that we have a NULL pointer dereference > > > in ppp_pernet() from

RE: [PATCH 05/15] ethernet: cavium: octeon: add missing of_node_put after calling of_parse_phandle

2016-07-28 Thread Peter Chen
> >> --- >> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c >> b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c >> index e8bc15b..5eb9d8c 100644 >> ---

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-28 Thread Sabrina Dubroca
2016-07-28, 07:43:55 +0200, Eric Dumazet wrote: > On Wed, 2016-07-27 at 14:38 -0700, Jeff Kirsher wrote: > > On Tue, 2016-07-26 at 11:14 +0200, Eric Dumazet wrote: > > > Could you try this ? > > > > > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > > >

[PATCH v4] net: sched: convert qdisc linked list to hashtable

2016-07-28 Thread Jiri Kosina
From: Jiri Kosina Convert the per-device linked list into a hashtable. The primary motivation for this change is that currently, we're not tracking all the qdiscs in hierarchy (e.g. excluding default qdiscs), as the lookup performed over the linked list by

Re: [PATCH -next] tipc: fix imbalance read_unlock_bh in __tipc_nl_add_monitor()

2016-07-28 Thread Ying Xue
On 07/28/2016 10:07 AM, Wei Yongjun wrote: > In the error handling case of nla_nest_start() failed read_unlock_bh() > is called to unlock a lock that had not been taken yet. sparse warns > about the context imbalance as the following: > > net/tipc/monitor.c:799:23: warning: > context imbalance

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-28 Thread Valdis . Kletnieks
On Thu, 28 Jul 2016 09:45:12 +0200, Thomas Gleixner said: > On Tue, 26 Jul 2016, nick wrote: > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > > b/drivers/net/ethernet/intel/e1000/e1000_main.c > > index f42129d..e1830af 100644 > > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c

Re: [PATCH 1/3] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

2016-07-28 Thread Grygorii Strashko
On 07/26/2016 11:54 PM, ivan.khoronzhuk wrote: > > > On 26.07.16 19:02, Grygorii Strashko wrote: >> On 07/23/2016 09:24 AM, Ivan Khoronzhuk wrote: >>> >>> >>> On 22.07.16 16:58, Grygorii Strashko wrote: Fix deadlock in cpdma_ctlr_destroy() which is triggered now on cpsw module removal:

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Leon Romanovsky
On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote: > A dedicated workqueue has been used since the work items are being used > on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward > progress under memory pressure. > > The workqueue has a single work item.

Re: [PATCH 0/2] net: davinci_cpdma: reduce latency on -rt

2016-07-28 Thread Grygorii Strashko
On 07/27/2016 05:38 PM, Uwe Kleine-König wrote: > Hello, > > On Wed, Jul 27, 2016 at 05:11:54PM +0300, Grygorii Strashko wrote: >> On 07/27/2016 10:03 AM, Uwe Kleine-König wrote: >>> On Tue, Jul 26, 2016 at 05:36:49PM +0300, Grygorii Strashko wrote: On 07/26/2016 03:02 PM, Uwe Kleine-König

[PATCH v5 3/8] thunderbolt: Kconfig for Thunderbolt(TM) networking

2016-07-28 Thread Amir Levy
Updating the Kconfig Thunderbolt(TM) description. Signed-off-by: Amir Levy --- drivers/thunderbolt/Kconfig | 25 + drivers/thunderbolt/Makefile | 2 +- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/thunderbolt/Kconfig

[PATCH v5 5/8] thunderbolt: Networking state machine

2016-07-28 Thread Amir Levy
Negotiation states that a peer goes through in order to establish the communication with the second peer. This includes communication with upper layer and additional infrastructure support to communicate with the second peer through ICM. Signed-off-by: Amir Levy ---

[PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Bhaktipriya Shridhar
A dedicated workqueue has been used since the work items are being used on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward progress under memory pressure. The workqueue has a single work item. Hence, alloc_workqueue() is used instead of alloc_ordered_workqueue() since

[PATCH v5 8/8] thunderbolt: Adding maintainer entry

2016-07-28 Thread Amir Levy
Add Amir Levy as maintainer for Thunderbolt(TM) ICM driver Signed-off-by: Amir Levy --- MAINTAINERS | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 771c31c..5f24eb2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

2016-07-28 Thread Amir Levy
Firmware-based (a.k.a ICM - Intel Connection Manager) controller is used for establishing and maintaining the Thunderbolt Networking connection. We need to be able to communicate with it. Signed-off-by: Amir Levy --- drivers/thunderbolt/Makefile |1 +

[PATCH v5 7/8] thunderbolt: Networking doc

2016-07-28 Thread Amir Levy
Adding Thunderbolt(TM) networking documentation. Signed-off-by: Amir Levy --- Documentation/00-INDEX | 2 + Documentation/thunderbolt-networking.txt | 135 +++ 2 files changed, 137 insertions(+) create mode 100644

[PATCH v5 2/8] thunderbolt: Updating the register definitions

2016-07-28 Thread Amir Levy
Adding more Thunderbolt(TM) register definitions and some helper macros. Signed-off-by: Amir Levy --- drivers/thunderbolt/nhi_regs.h | 109 + 1 file changed, 109 insertions(+) diff --git a/drivers/thunderbolt/nhi_regs.h

[PATCH v5 6/8] thunderbolt: Networking transmit and receive

2016-07-28 Thread Amir Levy
Handling the transmission to second peer and receiving from it. This includes communication with upper layer, the network stack and configuration of Thunderbolt(TM) HW. Signed-off-by: Amir Levy --- drivers/thunderbolt/icm/icm_nhi.c | 15 +

[PATCH v5 1/8] thunderbolt: Macro rename

2016-07-28 Thread Amir Levy
This first patch updates the registers file to reflect that it isn't only for Cactus Ridge. No functional change intended. Signed-off-by: Amir Levy --- drivers/thunderbolt/nhi_regs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v5 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

2016-07-28 Thread Amir Levy
This is version 5 of Thunderbolt(TM) driver for non-Apple hardware. Changes since v4: - Added Amir Levy as maintainer of thunderbolt/icm - Replaced private uuid definitions with uuid_be These patches were pushed to GitHub where they can be reviewed more comfortably with green/red highlighting:

Uncreachable default lo route in table 0

2016-07-28 Thread ashwanth
On an Android device(using 3.18 kernel version) we see multiple entries as the following added to the route table 0(unspec) by kernel. We noticed that this typically happens when we toggle WIFI repeatedly. The problem we see is that under such stress test, the table 0 gets filled with these

[PATCH net] cxgb4/cxgb4vf: Fixes regression in perf when tx vlan offload is disabled

2016-07-28 Thread Hariprasad Shenai
The commit 637d3e997351 ("cxgb4: Discard the packet if the length is greater than mtu") introduced a regression in the VLAN interface performance when Tx VLAN offload is disabled. Check if skb is tagged, regardless of whether it is hardware accelerated or not. Presently we were checking only for

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-28 Thread Thomas Gleixner
On Tue, 26 Jul 2016, nick wrote: > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > b/drivers/net/ethernet/intel/e1000/e1000_main.c > index f42129d..e1830af 100644 > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c > +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c > @@ -3797,7

Re: [PATCH 14/15] ethernet: stmicro: stmmac: stmmac_platform: add missing of_node_put after calling of_parse_phandle

2016-07-28 Thread Alexandre Torgue
Hi, On 07/27/2016 04:20 AM, Peter Chen wrote: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 - 1 file changed, 4

[PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-07-28 Thread fgao
From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS does not work for PPTP traffic. In my test environment, there are four MIPS cores, and all traffic are passed

RE: Microsemi VSC 8531/41 PHY Driver

2016-07-28 Thread Raju Lakkaraju
Hello Andrew, Thank you for given valuable comments. Please see the my responses inline. Thanks, Raju -Original Message- From: Andrew Lunn [mailto:and...@lunn.ch] Sent: Tuesday, July 26, 2016 6:14 PM To: Raju Lakkaraju Cc: netdev@vger.kernel.org; f.faine...@gmail.com; Allan Nielsen

RE: [PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_parse_phandle

2016-07-28 Thread Peter Chen
>在 2016/7/27 10:20, Peter Chen 写道: >> of_node_put needs to be called when the device node which is got from >> of_parse_phandle has finished using. >> >> Signed-off-by: Peter Chen >> --- >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 9 ++--- >> 1 file changed,