[PATCH net 1/2] tg3: Fix for diasllow rx coalescing time to be 0

From: Satish Baddipadige When the rx coalescing time is 0, interrupts are not generated from the controller and rx path hangs. To avoid this rx hang, updating the driver to not allow rx coalescing time to be 0. Signed-off-by: Satish Baddipadige

[PATCH net 2/2] tg3: Report the correct number of RSS queues through tg3_get_rxnfc

From: Siva Reddy Kallam This patch remove the wrong substraction from info->data in tg3_get_rxnfc function. Without this patch, the number of RSS queues reported is less by one. Reported-by: Michal Soltys Signed-off-by: Siva Reddy Kallam

[GIT] Networking

1) Fix several cases of missing of_node_put() calls in various networking drivers. From Peter Chen. 2) Don't try to remove unconfigured VLANs in qed driver, from Yuval Mintz. 3) Unbalanced locking in TIPC error handling, from Wei Yongjun. 4) Fix lockups in CPDMA driver, from Grygorii

Re: [PATCH] phy: fix the bug when remove the phy driver

On August 2, 2016 9:22:53 PM MST, Ding Tianhong wrote: >On 2016/8/3 10:41, Florian Fainelli wrote: >> On August 2, 2016 6:21:52 PM MST, Ding Tianhong > wrote: >>> On 2016/8/3 0:42, Florian Fainelli wrote: Le 02/08/2016 à 06:00, Ding Tianhong

Re: [PATCH] phy: fix the bug when remove the phy driver

On 2016/8/3 10:41, Florian Fainelli wrote: > On August 2, 2016 6:21:52 PM MST, Ding Tianhong > wrote: >> On 2016/8/3 0:42, Florian Fainelli wrote: >>> Le 02/08/2016 à 06:00, Ding Tianhong a écrit : The nic in my board use the phy dev from marvell, and the

[PATCH net 0/2] tg3: Disallow 0 rx coalesce time and correctly report RSS queues in tg3_get_rxnfc

From: Siva Reddy Kallam First patch: Diasllow rx coalescing time to be 0 Second patch: Report the correct number of RSS queues through tg3_get_rxnfc Satish Baddipadige (1): tg3: Fix for diasllow rx coalescing time to be 0 Siva Reddy Kallam (1):

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

On 7/29/16 12:21 PM, subas...@codeaurora.org wrote: Please don't try to workaround a bug with a sysctl. If we have a bug here, we should fix it. Choosing between bug A and bug B with a sysctl is not what we are doing ;) Sure, this was just a quick hack. Can you give an example of your use

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

On Tue, Aug 2, 2016 at 7:17 PM, Feng Gao wrote: > Thanks Tom's detail explanation. > It is my misinterpret because my mother language is not English. > No, the RFC is somewhat poorly worded with respect to setting the version number. The fact that flag bit must be set to

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

Al Viro wrote: > > Which just might mean that we have *three* issues here - > (1) buggered __copy_to_user_inatomic() (and friends) on some sparcs > (2) your ssl-only corruption > (3) Alan's x86_64 corruption on plain TCP read - no ssl *or* sparc > anywhere, and no multi-segment

hello

Our Company Yokohama Rubber Company is interested in your services as collection representative in your country, you will be on 10% commission for all payment received on behalf of our company, if interested get back to me for details Email: chen.kumik...@outlook.com Thank you. Chen Kumiko

Re: [PATCH] phy: fix the bug when remove the phy driver

On August 2, 2016 6:21:52 PM MST, Ding Tianhong wrote: >On 2016/8/3 0:42, Florian Fainelli wrote: >> Le 02/08/2016 à 06:00, Ding Tianhong a écrit : >>> The nic in my board use the phy dev from marvell, and >>> the system will load the marvell phy driver automatically, >>>

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年08月02日 16:27, Johannes Berg wrote: This explicitly configures *HT capability* though - that's even the name of the parameter. If you enable HT40 in the capability, the resulting BSS might still not actually *use* 40 MHz bandwidth, as required by overlapping BSS detection. OK, I see.

Re: PROBLEM: TPROXY and DNAT broken (bisected to 079096f103fa)

> Please try this patch, it makes it work for me again. > I decided to extend the existing snat support in xt_socket.c instead > of changing TPROXY target: This fixes my example (with the DIVERT chain), but does not fix the two-line example you gave below. Another setup I have is

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Thanks Tom's detail explanation. It is my misinterpret because my mother language is not English. Thanks again:)) On Wed, Aug 3, 2016 at 9:59 AM, Tom Herbert wrote: > On Tue, Aug 2, 2016 at 5:28 PM, Feng Gao wrote: >> Hi Tom. >> >> I quote some

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

On Tue, Aug 2, 2016 at 5:28 PM, Feng Gao wrote: > Hi Tom. > > I quote some description in RFC 2637. > > /*/ >C > (Bit 0) Checksum Present. Set to zero (0). > Note that the requirement is "*Set* to

Re: [PATCH] phy: fix the bug when remove the phy driver

On 2016/8/3 0:42, Florian Fainelli wrote: > Le 02/08/2016 à 06:00, Ding Tianhong a écrit : >> The nic in my board use the phy dev from marvell, and >> the system will load the marvell phy driver automatically, >> but when I remove the phy drivers, the system immediately panic: >> >> localhost

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

In this case they both mean the same thing. > On Aug 2, 2016, at 6:28 PM, Feng Gao wrote: > > Just a reminder, the version description is "contain 1", not "set 1". > > Best Regards > Feng signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Hi Tom. I quote some description in RFC 2637. /*/ C (Bit 0) Checksum Present. Set to zero (0). R (Bit 1) Routing Present. Set to zero (0). K (Bit 2) Key Present. Set to one (1). S (Bit 3)

Re: [PATCH/RFC iproute2 2/3] iptunnel: add support for mpls/ip to sit tunnels

On 7/6/16 12:23 PM, Simon Horman wrote: Signed-off-by: Simon Horman --- ip/link_iptnl.c | 12 +++- ip/tunnel.c | 10 ++ man/man8/ip-link.8.in | 9 + 3 files changed, 26 insertions(+), 5 deletions(-) diff --git

Re: [PATCH net] OVS: Ignore negative headroom value

On 08/03/2016 10:10 AM, kbuild test robot wrote: [auto build test ERROR on net/master] Sorry, typo. Thank you test robot === net_device->ndo_set_rx_headroom (introduced in 871b642adebe300be2e50aa5f65a418510f636ec) says "Setting a negative value reset the rx headroom to the default

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Thanks Philp. I get it, then i will send another update v3 patch soon. On Wed, Aug 3, 2016 at 1:33 AM, Philp Prindeville wrote: > Inline... > > > On 08/02/2016 12:10 AM, Feng Gao wrote: >> >> Thanks. >> Because the original GRE uses the literal number directly, so

Re: [PATCH net] OVS: Ignore negative headroom value

Hi Ian, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Ian-Wienand/OVS-Ignore-negative-headroom-value/20160803-075826 config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget

[PATCH net] OVS: Ignore negative headroom value

Hi, net_device->ndo_set_rx_headroom (introduced in 871b642adebe300be2e50aa5f65a418510f636ec) says "Setting a negative value reset the rx headroom to the default value". It seems that the OVS implementation in 3a927bc7cf9d0fbe8f4a8189dd5f8440228f64e7 overlooked this and sets

[PATCH] net: make net namespace sysctls belong to container's owner

If net namespace is attached to a user namespace let's make container's root owner of sysctls affecting said network namespace instead of global root. This also allows us to clean up net_ctl_permissions() because we do not need to fudge permissions anymore for the container's owner since it now

[PATCH net-next v2 1/2] net/sched/sch_hfsc.c: keep fsc and virtual times in sync; fix an old bug

This patch simplifies how we update fsc and calculate vt from it - while keeping the expected functionality identical with how hfsc behaves curently. It also fixes a certain issue introduced with a very old patch. The idea is, that instead of correcting cl_vt before fsc curve update (rtsc_min)

[PATCH net-next v2 2/2] net/sched/sch_hfsc.c: remove unused cl_myfadj

The code using this variable has been commented out in the past as it was causing issues in upperlimited link-sharing scenarios. Signed-off-by: Michal Soltys --- net/sched/sch_hfsc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/sched/sch_hfsc.c

[PATCH net-next v2 0/2] HFSC patches

Changes since v1: - in the first patch's commit message, reference old patch using kernel.org's historical tree (instead of using gmane) - in the second patch we just remove variable Notes regarding patch #1/2: This patch syncs virtual times with fair service curve and fixes a very old subtle

Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

Are these revised patches still on their way? John On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote: > Yuval, > I will try to resubmit the patches this week with updated comments > > Thanks > Vidya Sagar > > On Sat, Jul 23, 2016 at 10:57 PM, Yuval Mintz

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

On Thu, Jul 28, 2016 at 12:14 AM, wrote: > From: Gao Feng > > The PPTP is encapsulated by GRE header with that GRE_VERSION bits > must contain one. But current GRE RPS needs the GRE_VERSION must be > zero. So RPS does not work for PPTP traffic. > > In my test

Re: [PATCH net] openvswitch: Remove incorrect WARN_ONCE().

On 1 August 2016 at 19:36, Jarno Rajahalme wrote: > ovs_ct_find_existing() issues a warning if an existing conntrack entry > classified as IP_CT_NEW is found, with the premise that this should > not happen. However, a newly confirmed, non-expected conntrack entry > remains

Re: [PATCH net] bpf: fix method of PTR_TO_PACKET reg id generation

On 08/02/2016 05:12 PM, Jakub Kicinski wrote: Using per-register incrementing ID can lead to find_good_pkt_pointers() confusing registers which have completely different values. Consider example: 0: (bf) r6 = r1 1: (61) r8 = *(u32 *)(r6 +76) 2: (61) r0 = *(u32 *)(r6 +80) 3: (bf) r7 = r8 4:

Re: [v4] Fix to avoid IS_ERR_VALUE and IS_ERR abuses on 64bit systems.

On 08/02/2016 10:34 AM, arvind Yadav wrote: > > > On Tuesday 02 August 2016 01:15 PM, Arnd Bergmann wrote: >> On Monday, August 1, 2016 4:55:43 PM CEST Scott Wood wrote: >>> On 08/01/2016 02:02 AM, Arnd Bergmann wrote: > diff --git a/include/linux/err.h b/include/linux/err.h > index

[PATCH v3 1/1] Add timer to handle OOM situations

From: Gerard Garcia v3: * Avoid race condition when freeing timer. v2: * Use of ERR_PTR/PTR_ERR/IS_ERR * Timer cleaned on device release. * Do not process more packets on error. Signed-off-by: Gerard Garcia --- drivers/vhost/vsock.c | 52

[PATCH 2/5] net: ethernet: stmmac: change dma descriptors to __le32

The stmmac driver does not take into account the processor may be big endian when writing the DMA descriptors. This causes the ethernet interface not to be initialised correctly when running a big-endian kernel. Change the descriptors for DMA to use __le32 and ensure they are suitably swapped

[PATCH 3/5] net: ethernet: sun4i-emac: Allow to enable netif messages

sun4i-emac has the ability to print a number of diagnostic messages using dev_dbg depending on message level settings implemented using netif_msg_* macros. But there's no way to actually enable them. Add the ability to switch diagnostic messages on using either a module parameter debug or ethtool

[PATCH 4/5] net: ethernet: sun4i-emac: Read rxhdr in CPU byte-order

The EMAC EMAC_RX_IO_DATA_REG data register is dual-purpose: On one hand it is used to move actual packet data off the wire. This will be in wire-format and accepted as such by higher layers such as IP. Therefore it is correctly read as-is (i.e. raw) using readsl. On the other hand it provides

[Patch net-next] net_sched: remove an unnecessary list_del()

This list_del() for tc action is not needed actually, because we only use this list to chain bulk operations, therefore should not be carried for latter operations. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/act_api.c | 1 - 1 file

[PATCH 1/1 v2] rtlwifi: remove superfluous condition

If sta == NULL, the changed line will not be reached. So no need to check that sta != NULL here. v2: fix typo Signed-off-by: Heinrich Schuchardt Acked-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- 1 file

Re: [PATCH 1116/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 08:07:11PM +0200, Jan Engelhardt wrote: > > On Tuesday 2016-08-02 14:17, Baole Ni wrote: > > >I find that the developers often just specified the numeric value > >when calling a macro which is defined with a parameter for access permission. > >As we know, these numeric

Re: [PATCH net] bpf: fix method of PTR_TO_PACKET reg id generation

On Tue, Aug 02, 2016 at 04:12:14PM +0100, Jakub Kicinski wrote: > Using per-register incrementing ID can lead to > find_good_pkt_pointers() confusing registers which > have completely different values. Consider example: > > 0: (bf) r6 = r1 > 1: (61) r8 = *(u32 *)(r6 +76) > 2: (61) r0 = *(u32

Re: [PATCH v5 09/11] dtb: xgene: Add MDIO node

On Mon, Aug 1, 2016 at 2:13 PM, Olof Johansson wrote: > > Hi, > > I came across this now when looking at merge conflicts when preparing > this. I wish I had seen it sooner. > > On Thu, Jul 7, 2016 at 4:02 PM, Iyappan Subramanian > wrote: > > Added mdio node

Re: [PATCH 1116/1285] Replace numeric parameter like 0444 with macro

On Tuesday 2016-08-02 14:17, Baole Ni wrote: >I find that the developers often just specified the numeric value >when calling a macro which is defined with a parameter for access permission. >As we know, these numeric value for access permission have had the >corresponding macro, >and that

Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

From: Pavel Machek Date: Tue, 2 Aug 2016 19:47:33 +0200 > But that does not make me like the series. And yes, hiding backdoor > in one of those would be way too easy... This is one of the worst patch series submissions in history. At vger.kernel.org postmaster I just spent 45

[PATCH 1/1 v2] net: i10e: use matching format indentifiers

i is defined as int but output as %u several times. Adjust the format identifiers. v2: Keep definition of i as int. David indicated that this is the preferable way to define loop variables. Signed-off-by: Heinrich Schuchardt ---

[Patch net-next] net_sched: remove the leftover cleanup_a()

After refactoring tc_action into tcf_common, we no longer need to cleanup temporary "actions" in list, they are permanently stored in the hashtable. Reported-by: Jamal Hadi Salim Cc: Jamal Hadi Salim Signed-off-by: Cong Wang ---

[PATCH 0067/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0070/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Inline... On 08/02/2016 12:10 AM, Feng Gao wrote: Thanks. Because the original GRE uses the literal number directly, so I follow this style. Then I have two questions. 1. pptp_gre_header is defined in "drivers/net/ppp/pptp.c"; If we want to use it, need to create one new header file, is it ok

CAN I TRUST YOU

Dear Beneficiary I am Peter Douglas Director Inspection Unit United Nations Inspection Agent in Hartsfield–Jackson Atlanta International Airport Atlanta GA. We are rounding up for the last Quater of the auditing, all abandom Consignment in US Airports are being transfer to our facilities here

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

Lino Sanfilippo wrote: By looking closer to the code, the lock seems to serve the protection of a list of skbs that are queued to be timestamped. However there is nothing that ever enqueues those skbs, is it? I assume that this is a leftover of a previous version of that driver. Code to be

Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

On Tue 2016-08-02 09:29:27, Eric W. Biederman wrote: > Baole Ni writes: > > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access > > permission. > > As we know, these numeric value for

[PATCH v3 0/1] virtio-vsock: Add timer to handle OOM situations

From: Gerard Garcia This patch applies over VSOCK RFC v6. Once the guest puts a packet in the virtqueue it is guaranteed that it will be delivered. This patch addresses the problem of packets being discarded when there is not available memory in the host. Gerard Garcia

Re: [PATCH] net: thunderx: correct bound check in nic_config_loopback

Yes, it's incorrect at other places as well. That went in the very early stages of development and didn't change it because that out of bounds issue will never happen as no of logical interfaces will never be morethan MAX_LMAC i.e 8, so max vf_id will be 7. But with addition of support for newer

Re: [PATCH] phy: fix the bug when remove the phy driver

Le 02/08/2016 à 06:00, Ding Tianhong a écrit : > The nic in my board use the phy dev from marvell, and > the system will load the marvell phy driver automatically, > but when I remove the phy drivers, the system immediately panic: > > localhost login: [ 2582.052465] Unable to handle kernel NULL

Aw: [PATCH 0068/1285] Replace numeric parameter like 0444 with macro

Hi, > Gesendet: Dienstag, 02. August 2016 um 12:38 Uhr > Von: "Baole Ni" > An: 3ch...@gmail.com, t...@kernel.org, l...@kernel.org, x...@kernel.org, > h...@zytor.com > Cc: linux-atm-gene...@lists.sourceforge.net, netdev@vger.kernel.org, > linux-ker...@vger.kernel.org,

[PATCH 0709/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0712/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0716/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0713/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0714/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0715/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0721/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0707/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0708/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 1103/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0719/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0711/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0717/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using

[PATCH 0710/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0718/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0723/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0749/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0741/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0767/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0739/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0789/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0758/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0748/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0759/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0724/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0726/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0720/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0722/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0725/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0728/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0727/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0743/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0753/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH 0786/1285] Replace numeric parameter like 0444 with macro

I don’t think macros is clearer, and the meaning of those so called “magic numbers” like 0644 is clear enough. People are used to that. As a result, it is not meaningful to replace them with macro. > 在 2016年8月2日，19:46，Baole Ni 写道： > > I find that the developers often just

[PATCH 0731/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0734/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [v4] Fix to avoid IS_ERR_VALUE and IS_ERR abuses on 64bit systems.

On Tuesday 02 August 2016 01:15 PM, Arnd Bergmann wrote: On Monday, August 1, 2016 4:55:43 PM CEST Scott Wood wrote: On 08/01/2016 02:02 AM, Arnd Bergmann wrote: diff --git a/include/linux/err.h b/include/linux/err.h index 1e35588..c2a2789 100644 --- a/include/linux/err.h +++

[PATCH 0738/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0744/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0757/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0746/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0729/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0751/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0765/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

  1   2   3   >