Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

On 8/19/16, 6:17 AM, Jiri Pirko wrote: > From: Nogah Frankel > > Add a nested attribute of SW stats to if_stats_msg > under IFLA_STATS_LINK_SW_64. > > Signed-off-by: Nogah Frankel > Reviewed-by: Ido Schimmel > Signed-off-by: Jiri

Re: [PATCH net-next] net: strparser: fix strparser sk_user_data check

From: Dave Watson Date: Mon, 22 Aug 2016 12:27:04 -0700 > sk_user_data mismatch between what kcm expects (psock) and what strparser > expects (strparser). > > Queued rx_work, for example calling strp_check_rcv after socket buffer > changes, will never complete. > >

Re: [PATCH net-next] qed: Fix address macros

From: Yuval Mintz Date: Tue, 23 Aug 2016 07:19:50 +0300 > Last FW submission reverted various macros into an older form, > where they generate compilation warnings on some architectures. > > Bring back the newer macros instead. > > Fixes: 05fafbfb3d77 ("qed: utilize FW

Re: [PATCH v4 1/5] net: ethernet: ti: davinci_cpdma: split descs num between all channels

On Monday 22 August 2016 11:48 PM, Ivan Khoronzhuk wrote: > Tx channels share same pool of descriptors. Thus one channel can > block another if pool is emptied by one. But, the shaper should > decide which channel is allowed to send packets. To avoid such > impact of one channel on another, let

Re: [PATCH v4 5/5] net: ethernet: ti: cpsw: add ethtool channels support

On Monday 22 August 2016 11:48 PM, Ivan Khoronzhuk wrote: > These ops allow to control number of channels driver is allowed to > work with at cpdma level. The maximum number of channels is 8 for > rx and 8 for tx. In dual_emac mode the h/w channels are shared > between two interfaces and changing

Re: [PATCH v4 3/5] net: ethernet: ti: cpsw: add multi queue support

On Monday 22 August 2016 11:48 PM, Ivan Khoronzhuk wrote: > The cpsw h/w supports up to 8 tx and 8 rx channels. This patch adds > multi-queue support to the driver only, shaper configuration will > be added with separate patch series. Default shaper mode, as > before, priority mode, but with

Re: [PATCH 0/1] HW checksum offload problem on Xilinx Zynq GEM

On 08/19/2016 10:00 PM, Tom Herbert wrote: On Fri, Aug 19, 2016 at 12:28 PM, David Miller wrote: From: Helmut Buchsbaum Date: Fri, 19 Aug 2016 15:04:57 +0200 When working on upgrading the v3.x kernels of our embedded devices to more recent

[PATCH net-next v1] gso: Support partial splitting at the frag_list pointer

Since commit 8a29111c7 ("net: gro: allow to build full sized skb") gro may build buffers with a frag_list. This can hurt forwarding because most NICs can't offload such packets, they need to be segmented in software. This patch splits buffers with a frag_list at the frag_list pointer into buffers

[PATCH net-next] qed: Fix address macros

Last FW submission reverted various macros into an older form, where they generate compilation warnings on some architectures. Bring back the newer macros instead. Fixes: 05fafbfb3d77 ("qed: utilize FW 8.10.10.0") Reported-by: kbuild test robot Signed-off-by: Yuval Mintz

Re: [PATCH v2 net-next] net: diag: support SOCK_DESTROY for UDP sockets

On 8/22/16 8:15 PM, Eric Dumazet wrote: > Hi David > > It seems you forgot the sock_diag_check_cookie() call, but other than > that this patch looks fine. > > Thanks. indeed. will fix tomorrow and re-send. Thanks for the review.

Re: [PATCH 0/4] Fix MV88E6131 tagging

From: Andrew Lunn Date: Mon, 22 Aug 2016 16:01:00 +0200 > Marvell has two different tagging protocols for frames passed to a > swicth. There is the older DSA and the newer EDSA. Somewhere along the > way, we broke support for switches which only support DSA, by trying > to

Re: [PATCH] net: ipconfig: Fix NULL pointer dereference on RARP/BOOTP/DHCP timeout

From: Geert Uytterhoeven Date: Mon, 22 Aug 2016 15:01:03 +0200 > If no RARP, BOOTP, or DHCP response is received, ic_dev is never set, > causing a NULL pointer dereference in ic_close_devs(): > > Sending DHCP requests .. timed out! > Unable to handle kernel

Re: [PATCH v2 net 1/1] net sched: fix encoding to use real length

From: Jamal Hadi Salim Date: Mon, 22 Aug 2016 07:10:20 -0400 > From: Jamal Hadi Salim > > Encoding of the metadata was using the padded length as opposed to > the real length of the data which is a bug per specification. > This has not been an issue todate

RE: [PATCH ethtool 0/3] ethtool: Add support for new high speed adv.

> It looks like Vidya wasn't completely in-sync with you on this! But, I like > that you > included the later bits for ethtool-copy.h and that you added man page > updates. > > Could you and Vidya get together and post a unified patchset, please? Or if > Vidya posts the updates I requested, I

Re: [PATCH 00/20] pull request for net-next: batman-adv 2016-08-16*

From: Simon Wunderlich Date: Mon, 22 Aug 2016 15:56:00 +0200 > this is our third (and final, for now) pull request for batman-adv in this > round, > with mostly maintainability stuff. > > Please pull or let me know of any problem! Pulled, thanks Simon.

[PATCH v2 1/2 net-next] netfilter: gre: Use consistent GRE_* macros instead of ones defined by netfilter.

From: Gao Feng There are already some GRE_* macros in kernel, so it is unnecessary to define these macros. And remove some useless macros Signed-off-by: Gao Feng --- v2: Split the original patch to review easily v1: Intial patch

Re: [PATCH v2 1/2 net-next] netfilter: gre: Use consistent GRE_* macros instead of ones defined by netfilter.

Sorry to bother you if receive duplicate email whose subject is " [patch v2 1/2 net-next] netfilter: gre: Use consistent GRE_* macros instead of ones defined by netfilter.". Because my mail server told it failed to send at the first time. Regards Feng On Tue, Aug 23, 2016 at 10:20 AM,

[PATCH v2 2/2 net-next] netfilter: gre: Use consistent GRE and PTTP header structure instead of the ones defined by netfilter

From: Gao Feng There are two existing strutures which defines the GRE and PPTP header. So use these two structures instead of the ones defined by netfilter to keep consitent with other codes. Signed-off-by: Gao Feng --- v2: Split the original patch to review

[PATCH v2 1/2 net-next] netfilter: gre: Use consistent GRE_* macros instead of ones defined by netfilter.

From: Gao Feng There are already some GRE_* macros in kernel, so it is unnecessary to define these macros. And remove some useless macros Signed-off-by: Gao Feng --- v2: Split the original patch to review easily v1: Intial patch

Re: [PATCH v2 net-next] net: diag: support SOCK_DESTROY for UDP sockets

On Mon, 2016-08-22 at 18:03 -0700, David Ahern wrote: > This implements SOCK_DESTROY for UDP sockets similar to what was done > for TCP with commit c1e64e298b8ca ("net: diag: Support destroying TCP > sockets.") A process with a UDP socket targeted for destroy is awakened > and recvmsg fails with

[PATCH] net: lpc_eth: Check clk_prepare_enable() error

From: Fabio Estevam clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of failure. Signed-off-by: Fabio Estevam --- drivers/net/ethernet/nxp/lpc_eth.c | 29 ++--- 1 file

Re: [PATCH net-next 0/3] TX max rate limiting for Chelsio T4/T5 adapters

From: Rahul Lakkireddy Date: Mon, 22 Aug 2016 16:29:05 +0530 > This series of patches implement tx max rate limiting per queue on > Chelsio T4/T5 hardware. This is achieved by first creating a tx > scheduling class with the specified max rate. The queue is then >

Re: [PATCH net-next 0/4] qed*: IOV patch series

From: Yuval Mintz Date: Mon, 22 Aug 2016 13:25:08 +0300 > Recent FW [8.10.10.0] enabled us to support sriov interaction > with legacy VF/PF. This patch series adds the necessary driver changes > to utilize this additional compatibility. > In addition, utilize the new FW

Re: [PATCH net] qed: FLR of active VFs might lead to FW assert

From: Yuval Mintz Date: Mon, 22 Aug 2016 12:03:29 +0300 > Driver never bothered marking the VF's vport with the VF's sw_fid. > As a result, FLR flows are not going to clean those vports. > > If the vport was active when FLRed, re-activating it would lead > to a FW

Re: [PATCH] net: ip_finish_output_gso: Allow fragmenting segments of tunneled skbs if their DF is unset

From: Shmulik Ladkani Date: Sun, 21 Aug 2016 11:22:32 +0300 > In b8247f095e, > >"net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, allow > segmentation for local udp tunneled skbs" > > gso skbs arriving from an ingress interface that go through

Re: [PATCH -next v2] net: phy: Add missing of_node_put() in xgmiitorgmii_probe()

From: Wei Yongjun Date: Sun, 21 Aug 2016 22:46:15 + > This node pointer is returned by of_parse_phandle() with > refcount incremented in this function. of_node_put() on it > before exitting this function. > > This is detected by Coccinelle semantic patch. > >

[PATCH v2 net-next] net: diag: support SOCK_DESTROY for UDP sockets

This implements SOCK_DESTROY for UDP sockets similar to what was done for TCP with commit c1e64e298b8ca ("net: diag: Support destroying TCP sockets.") A process with a UDP socket targeted for destroy is awakened and recvmsg fails with ECONNABORTED. Signed-off-by: David Ahern

[PATCH v2 net-next] net-tcp: retire TFO_SERVER_WO_SOCKOPT2 config

TFO_SERVER_WO_SOCKOPT2 was intended for debugging purposes during Fast Open development. Remove this config option and also update/clean-up the documentation of the Fast Open sysctl. Reported-by: Piotr Jurkiewicz Signed-off-by: Yuchung Cheng

Re: [PATCH] mlx5/core: Use memdup_user() rather than duplicating its implementation

From: SF Markus Elfring Date: Sat, 20 Aug 2016 08:01:22 +0200 > From: Markus Elfring > Date: Sat, 20 Aug 2016 07:50:09 +0200 > > * Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > >

Re: [Patch net-next] net_sched: properly handle failure case of tcf_exts_init()

From: Cong Wang Date: Fri, 19 Aug 2016 12:36:54 -0700 > After commit 22dc13c837c3 ("net_sched: convert tcf_exts from list to pointer > array") > we do dynamic allocation in tcf_exts_init(), therefore we need > to handle the ENOMEM case properly. > > Cc: Jamal Hadi

Re: [PATCH v2] net: ipv6: Remove addresses for failures with strict DAD

From: Mike Manning Date: Thu, 18 Aug 2016 14:39:40 +0100 > If DAD fails with accept_dad set to 2, global addresses and host routes > are incorrectly left in place. Even though disable_ipv6 is set, > contrary to documentation, the addresses are not dynamically deleted > from

Re: [PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:32:38 +0200 > Fixes userspace compilation error: > > error: ‘IFNAMSIZ’ undeclared here (not in a function) > > Signed-off-by: Mikko Rapeli Applied.

Re: [PATCH v05 64/72] include/uapi/linux/ipx.h: fix conflicting defitions with glibc netipx/ipx.h

From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:33:21 +0200 > Fixes these compiler warnings via libc-compat.h when glibc netipx/ipx.h is > included before linux/ipx.h: > > ./linux/ipx.h:9:8: error: redefinition of ‘struct sockaddr_ipx’ > ./linux/ipx.h:26:8: error: redefinition

Re: [PATCH] phy: micrel: Reenable interrupts during resume for ksz9031

On 08/22/2016 01:57 PM, Xander Huff wrote: > Like the ksz8081, the ksz9031 has the behavior where it will clear the > interrupt enable bits when leaving power down. This takes advantage of the > solution provided by f5aba91. > > Signed-off-by: Xander Huff > Signed-off-by:

Re: [patch net-next v6_repost 0/3] return offloaded stats as default and expose original sw stats

Roopa, please review this patch series. Thank you.

Re: [PATCH v05 41/72] include/uapi/linux/atm_zatm.h: include linux/time.h

From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:32:58 +0200 > Fixes userspace compile error: > > error: field ‘real’ has incomplete type > struct timeval real; /* real (wall-clock) time */ > > Signed-off-by: Mikko Rapeli Applied.

Re: [PATCH v05 62/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:33:19 +0200 > Kernel uapi header are supposed to use them. Fixes userspace compile error: > > linux/openvswitch.h:583:2: error: unknown type name ‘uint32_t’ > > Signed-off-by: Mikko Rapeli Applied.

Re: [PATCH v05 25/72] include/uapi/linux/if_pppol2tp.h: include linux/in.h and linux/in6.h

From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:32:42 +0200 > Fixes userspace compilation errors like: > > error: field ‘addr’ has incomplete type > struct sockaddr_in addr; /* IP address and port to send to */ > ^ > error: field ‘addr’ has incomplete type

Re: [PATCH v05 26/72] include/uapi/linux/if_pppox.h: include linux/in.h and linux/in6.h

From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:32:43 +0200 > Fixes userspace compilation errors: > > error: field ‘addr’ has incomplete type > struct sockaddr_in addr; /* IP address and port to send to */ > > error: field ‘addr’ has incomplete type > struct sockaddr_in6

Re: [PATCH v05 38/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:32:55 +0200 > Fixes userspace compiler error: > > error: unknown type name ‘uint32_t’ > > Signed-off-by: Mikko Rapeli Applied.

[PATCH net-next] net-tcp: retire TFO_SERVER_WO_SOCKOPT2 config

TFO_SERVER_WO_SOCKOPT2 was intended for debugging purposes during Fast Open development. Remove this config option and also update/clean-up the documentation of the Fast Open sysctl. Reported-by: Piotr Jurkiewicz --- Documentation/networking/ip-sysctl.txt | 45

Re: [PATCH v05 22/72] include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and linux/in6.h

From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:32:39 +0200 > Fixes userspace compilation errors like: > > error: field ‘iph’ has incomplete type > error: field ‘prefix’ has incomplete type > > Signed-off-by: Mikko Rapeli Applied.

Re: [PATCH v05 38/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

From: Stephen Hemminger Date: Mon, 22 Aug 2016 12:39:38 -0700 > This is a a real issue, but being buried in a huge patch series of include > file stuff I don't think anyone would see it. It hit netdev and thus patchwork, therefore anyone watching networking patches

Re: [PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

From: Stephen Hemminger Date: Mon, 22 Aug 2016 12:37:45 -0700 > It seems your goal is that every include file should be standalone, > i.e it must include every definition it uses. I think this is absolutely mandatory Stephen. If you include x.h it should just work

Re: [PATCH] net: mv88e6xxx: Fix ingress rate removal for mv6131 chips

On Mon, Aug 22, 2016 at 10:47:08PM +0100, Jamie Lentin wrote: > The PORT_RATE_CONTROL register works differently on 88e6095/6095f/6131 > in comparison to 6123/61/65, and 0x0 disables. The distinction was lost > Linux 4.1 --> 4.2 > > Signed-off-by: Jamie Lentin Hi Jamie

[PATCH -next] xen-netback: using kfree_rcu() to simplify the code

From: Wei Yongjun The callback function of call_rcu() just calls a kfree(), so we can use kfree_rcu() instead of call_rcu() + callback function. Signed-off-by: Wei Yongjun --- drivers/net/xen-netback/hash.c | 13 ++--- 1 file changed, 2

Re: [PATCH net-next 0/3] net/sched: iptunnel encap/decap/classify using TC

On Mon, Aug 22, 2016 at 7:38 AM, Amir Vadai wrote: > Hi, > > This patchset introduces iptunnel support using the TC subsystem. > > In the decap flow, it enables the user to redirect packets from a shared > tunnel > device and classify by outer and inner headers. The outer headers

Your Urgent Response

Dear Friend, I am Mr Hassan Umra, the director in charge of auditing and accounting section of Bank of Africa (BOA) West-Africa. I would like you to indicate your interest to receive the transfer of $12.5 Million Dollars. I will like you to stand as the next of kin to our late customer whose

Re: [PATCH] phy: micrel: Reenable interrupts during on resume for ksz9031

On 8/22/2016 3:43 PM, Xander Huff wrote: Like the ksz8081, the ksz9031 has the behavior where it will clear the interrupt enable bits when leaving power down. This takes advantage of the solution provided by f5aba91. Signed-off-by: Xander Huff Signed-off-by: Nathan Sullivan

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On 22 August 2016 at 04:04, Simon Horman wrote: > On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote: >> On 10 August 2016 at 03:20, Simon Horman wrote: >> > On Tue, Aug 09, 2016 at 08:47:40AM -0700, pravin shelar wrote: >> >> On

[PATCH] net: mv88e6xxx: Fix ingress rate removal for mv6131 chips

The PORT_RATE_CONTROL register works differently on 88e6095/6095f/6131 in comparison to 6123/61/65, and 0x0 disables. The distinction was lost Linux 4.1 --> 4.2 Signed-off-by: Jamie Lentin --- Tested on a Netgear WNR854T With a mv88e6131 switch chip, on top of Andrew Lunn's

[PATCH] phy: micrel: Reenable interrupts during on resume for ksz9031

Like the ksz8081, the ksz9031 has the behavior where it will clear the interrupt enable bits when leaving power down. This takes advantage of the solution provided by f5aba91. Signed-off-by: Xander Huff Signed-off-by: Nathan Sullivan

[PATCH] phy: micrel: Reenable interrupts during resume for ksz9031

Like the ksz8081, the ksz9031 has the behavior where it will clear the interrupt enable bits when leaving power down. This takes advantage of the solution provided by f5aba91. Signed-off-by: Xander Huff Signed-off-by: Nathan Sullivan ---

Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

On Mon, 2016-08-22 at 22:50 +0200, SF Markus Elfring wrote: > > @@ -2289,6 +2299,10 @@ sub process { > >   } > >   > >   if ($found_file) { > > + if (is_maintained_obsolete($realfile)) { > > + WARN("OBSOLETE", > > +

Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

> @@ -2289,6 +2299,10 @@ sub process { > } > > if ($found_file) { > + if (is_maintained_obsolete($realfile)) { > + WARN("OBSOLETE", > + "$realfile is marked as 'obsolete' in the >

Re: [ethtool PATCH v3 1/4] ethtool-copy.h:sync with net

John, I will re-submit v4 patchset with these updated bits. Thanks Vidya On Mon, Aug 22, 2016 at 12:26 PM, John W. Linville wrote: > On Sun, Aug 21, 2016 at 04:44:01PM -0700, Vidya Sagar Ravipati wrote: >> From: Vidya Sagar Ravipati >> >>

Re: [PATCH ethtool 0/3] ethtool: Add support for new high speed adv.

On Mon, Aug 22, 2016 at 08:50:36AM +0300, Yuval Mintz wrote: > This allows ethtool to utilize the link capabilities/adv./lp bitmasks > to show and set the additional 25g, 50g and 100g link speeds. > > Patches #1 & #2 are based on Vidya Sagar Ravipati's patches > [with the only addition being the

[PATCH v05 22/72] include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and linux/in6.h

Fixes userspace compilation errors like: error: field ‘iph’ has incomplete type error: field ‘prefix’ has incomplete type Signed-off-by: Mikko Rapeli --- include/uapi/linux/if_tunnel.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/if_tunnel.h

Re: [PATCH v05 38/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

On Mon, 22 Aug 2016 20:32:55 +0200 Mikko Rapeli wrote: > Fixes userspace compiler error: > > error: unknown type name ‘uint32_t’ > > Signed-off-by: Mikko Rapeli > --- > include/uapi/linux/openvswitch.h | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

On 22-8-2016 15:03, Nicolas Iooss wrote: > Hello, > > After I sent the following patch a few weeks ago, I have not received > any feedback. Could you please review it and tell me what I may have > done wrong? Nothing. People went on vacation :-) > Thanks, > Nicolas > > On 05/08/16 22:34,

Re: [PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

On Mon, 22 Aug 2016 20:32:38 +0200 Mikko Rapeli wrote: > Fixes userspace compilation error: > > error: ‘IFNAMSIZ’ undeclared here (not in a function) > > Signed-off-by: Mikko Rapeli > --- > include/uapi/linux/if_pppox.h | 1 + > 1 file changed, 1

Re: [PATCH net-next] net: strparser: fix strparser sk_user_data check

On Mon, Aug 22, 2016 at 12:27 PM, Dave Watson wrote: > sk_user_data mismatch between what kcm expects (psock) and what strparser > expects (strparser). > > Queued rx_work, for example calling strp_check_rcv after socket buffer > changes, will never complete. > > sk_user_data

Re: [ethtool PATCH v3 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

On Sun, Aug 21, 2016 at 04:44:04PM -0700, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > Enhancing link mode bits to support 25G/50G/100G > for supported and advertised speed mode bits > > Signed-off-by: Vidya Sagar Ravipati >

Re: [ethtool PATCH v3 1/4] ethtool-copy.h:sync with net

On Sun, Aug 21, 2016 at 04:44:01PM -0700, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > This covers kernel changes upto: > > commit 3851112e4737cd52aaeda0ce8d084be9ee128106 > Author: Vidya Sagar Ravipati > Date: Sun May 22

[PATCH net-next] net: strparser: fix strparser sk_user_data check

sk_user_data mismatch between what kcm expects (psock) and what strparser expects (strparser). Queued rx_work, for example calling strp_check_rcv after socket buffer changes, will never complete. sk_user_data is unused in strparser, so just remove the check. Signed-off-by: Dave Watson

[PATCH v05 64/72] include/uapi/linux/ipx.h: fix conflicting defitions with glibc netipx/ipx.h

Fixes these compiler warnings via libc-compat.h when glibc netipx/ipx.h is included before linux/ipx.h: ./linux/ipx.h:9:8: error: redefinition of ‘struct sockaddr_ipx’ ./linux/ipx.h:26:8: error: redefinition of ‘struct ipx_route_definition’ ./linux/ipx.h:32:8: error: redefinition of ‘struct

[PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

Fixes userspace compilation error: error: ‘IFNAMSIZ’ undeclared here (not in a function) Signed-off-by: Mikko Rapeli --- include/uapi/linux/if_pppox.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_pppox.h b/include/uapi/linux/if_pppox.h index

Re: [PATCH net] tcp: properly scale window in tcp_v[46]_reqsk_send_ack()

On Mon, Aug 22, 2016 at 2:31 PM, Eric Dumazet wrote: > From: Eric Dumazet > > When sending an ack in SYN_RECV state, we must scale the offered > window if wscale option was negotiated and accepted. > > Tested: > Following packetdrill test

[PATCH v05 62/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

Kernel uapi header are supposed to use them. Fixes userspace compile error: linux/openvswitch.h:583:2: error: unknown type name ‘uint32_t’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/openvswitch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

On Mon, 22 Aug 2016 21:15:41 +0300, Or Gerlitz wrote: > Jiri B > I understand the motivation for the decap action. However, what would > Jiri B > happen if someone does not include it? > > The MD set by the (say) vxlan device will not be "consumed" (cleared) > and would be keep travelling with

Re: [PATCH net] tcp: properly scale window in tcp_v[46]_reqsk_send_ack()

On Mon, Aug 22, 2016 at 11:31 AM, Eric Dumazet wrote: > From: Eric Dumazet > > When sending an ack in SYN_RECV state, we must scale the offered > window if wscale option was negotiated and accepted. > > Tested: > Following packetdrill test

Re: [for-next V2 00/17][PULL request] Mellanox mlx5 core driver updates 2016-08-20

From: Saeed Mahameed Date: Mon, 22 Aug 2016 20:56:43 +0300 > Technical question though. Do i need to create a new tag for the new > pull request? I mean, should the tag always point to the "up to" patch > in the pull request? or can I just use the same tag for the new

[PATCH v05 25/72] include/uapi/linux/if_pppol2tp.h: include linux/in.h and linux/in6.h

Fixes userspace compilation errors like: error: field ‘addr’ has incomplete type struct sockaddr_in addr; /* IP address and port to send to */ ^ error: field ‘addr’ has incomplete type struct sockaddr_in6 addr; /* IP address and port to send to */ Signed-off-by: Mikko

[PATCH v05 26/72] include/uapi/linux/if_pppox.h: include linux/in.h and linux/in6.h

Fixes userspace compilation errors: error: field ‘addr’ has incomplete type struct sockaddr_in addr; /* IP address and port to send to */ error: field ‘addr’ has incomplete type struct sockaddr_in6 addr; /* IP address and port to send to */ Signed-off-by: Mikko Rapeli

[PATCH] zd1211rw: fix spelling mistake "firmeware" -> "firmware"

From: Colin Ian King Trivial fix to spelling mistake in dev_err message. Signed-off-by: Colin Ian King --- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v05 38/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

Fixes userspace compiler error: error: unknown type name ‘uint32_t’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/openvswitch.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h

[PATCH v05 41/72] include/uapi/linux/atm_zatm.h: include linux/time.h

Fixes userspace compile error: error: field ‘real’ has incomplete type struct timeval real; /* real (wall-clock) time */ Signed-off-by: Mikko Rapeli --- include/uapi/linux/atm_zatm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/atm_zatm.h

[PATCH net] tcp: properly scale window in tcp_v[46]_reqsk_send_ack()

From: Eric Dumazet When sending an ack in SYN_RECV state, we must scale the offered window if wscale option was negotiated and accepted. Tested: Following packetdrill test demonstrates the issue : 0.000 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3 +0 setsockopt(3,

[PATCH v4 1/5] net: ethernet: ti: davinci_cpdma: split descs num between all channels

Tx channels share same pool of descriptors. Thus one channel can block another if pool is emptied by one. But, the shaper should decide which channel is allowed to send packets. To avoid such impact of one channel on another, let every channel to have its own piece of pool. Signed-off-by: Ivan

[PATCH v4 3/5] net: ethernet: ti: cpsw: add multi queue support

The cpsw h/w supports up to 8 tx and 8 rx channels. This patch adds multi-queue support to the driver only, shaper configuration will be added with separate patch series. Default shaper mode, as before, priority mode, but with corrected priority order, 0 - is highest priority, 7 - lowest. The

[PATCH v4 4/5] net: ethernet: ti: davinci_cpdma: move cpdma channel struct macroses to internals

Keep the driver internals in C file. Currently it's not required for drivers to know rx or tx a channel is, except create function. So correct "channel create" function, and use all channel struct macroses only for internal use. Reviewed-by: Mugunthan V N Signed-off-by: Ivan

[PATCH v4 0/5] net: ethernet: ti: cpsw: add cpdma multi-queue support

This series is intended to allow cpsw driver to use cpdma ability of h/w shaper to send/receive data with up to 8 tx and 8 rx queues. This series doesn't contain interface to configure h/w shaper itself, it contains only multi-queue support part and ability to configure number of tx/rx queues with

[PATCH v4 5/5] net: ethernet: ti: cpsw: add ethtool channels support

These ops allow to control number of channels driver is allowed to work with at cpdma level. The maximum number of channels is 8 for rx and 8 for tx. In dual_emac mode the h/w channels are shared between two interfaces and changing number on one interface changes number of channels on another.

[PATCH v4 2/5] net: ethernet: ti: davinci_cpdma: fix locking while ctrl_stop

The interrupts shouldn't be disabled while receiving skb, but while ctrl_stop, the channels are stopped and all remaining packets are handled with netif_receive_skb(), it can cause WARN_ONCE when ctrl is stopping while not all packets were handled with NAPIs: lock_irq_save cpdma_ctlr_stop

[PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

Use get_maintainer to check the status of individual files. If "obsolete", suggest leaving the files alone. Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 14 ++ 1 file changed, 14 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

On Mon, Aug 22, 2016 at 5:38 PM, Amir Vadai wrote: > This action could be used before redirecting packets to a shared tunnel > device, or when redirecting packets arriving from a such a device nit, add period > The action will release the metadata created by the tunnel device >

Re: [Patch net-next] net_sched: properly handle failure case of tcf_exts_init()

On 16-08-22 01:40 PM, Cong Wang wrote: On Mon, Aug 22, 2016 at 5:11 AM, Jamal Hadi Salim wrote: Answered my own question by looking at implementation of kfree(); ignores NULL (unlike free()) Seriously? Here is what C standard says about free(): I may be confusing it

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

Hi, On Mon, 22 Aug 2016 17:38:34 +0300 Amir Vadai wrote: > +static struct metadata_dst *iptunnel_alloc(struct tcf_iptunnel *t, > +__be32 saddr, __be32 daddr, > +__be64 key_id) > +{ > + struct

Re: [for-next V2 00/17][PULL request] Mellanox mlx5 core driver updates 2016-08-20

On Mon, Aug 22, 2016 at 8:11 PM, David Miller wrote: > > Sorry, too many patches. > > Please keep your series to 10 to 15 patches maximum. > > Please do not push back on this, I made several other submitters do > the same exact thing over the past few days. Sure. Rules are

Re: [Patch net-next] net_sched: properly handle failure case of tcf_exts_init()

On Mon, Aug 22, 2016 at 5:11 AM, Jamal Hadi Salim wrote: > > > Answered my own question by looking at implementation of kfree(); > ignores NULL (unlike free()) Seriously? Here is what C standard says about free(): The free function causes the space pointed to by ptr to be

RE: [PATCH net-next V3 09/18] liquidio: MSIX support for CN23XX

> + u64 time_threshold; > + u64 cnt_threshold; ... > + octeon_write_csr64( > + oct, CN23XX_SLI_OQ_PKT_INT_LEVELS(oq_no), > + ((u64)(time_threshold << 32 | cnt_threshold))); No need for the cast. > + if (!droq) { > +

Re: [PATCH net-next 2/3] net/sched: cls_flower: Classify packet in ip tunnels

On Mon, Aug 22, 2016 at 07:05:23PM +0200, Jiri Benc wrote: > On Mon, 22 Aug 2016 17:38:33 +0300, Amir Vadai wrote: > > + if (tb[TCA_FLOWER_KEY_ENC_IPV6_SRC] || > > + tb[TCA_FLOWER_KEY_ENC_IPV6_DST]) > > + return -ENOTSUPP; > > Please add also support for IPv6. We've had enough

Re: [RFC PATCH 0/5] Add eBPF hooks for cgroups

On Mon, Aug 22, 2016 at 06:22:20PM +0200, Daniel Mack wrote: > On 08/22/2016 06:06 PM, Pablo Neira Ayuso wrote: > > On Fri, Aug 19, 2016 at 07:07:39PM +0200, Thomas Graf wrote: > > >> You brought up multiple tables which reflect the cumulative approach. > >> This sometimes works but has its

Re: [for-next V2 00/17][PULL request] Mellanox mlx5 core driver updates 2016-08-20

Sorry, too many patches. Please keep your series to 10 to 15 patches maximum. Please do not push back on this, I made several other submitters do the same exact thing over the past few days.

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

On Mon, 22 Aug 2016 17:38:34 +0300, Amir Vadai wrote: > This action could be used before redirecting packets to a shared tunnel > device, or when redirecting packets arriving from a such a device > > The action will release the metadata created by the tunnel device > (decap), or set the metadata

Re: [PATCH v2 iproute2 1/1] tc classifiers: Modernize tcindex classifier

On Mon, 22 Aug 2016 07:17:33 -0400 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim Applied

Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

On Thu, 18 Aug 2016 15:14:38 -0700 Eric Dumazet wrote: > On Thu, 2016-08-18 at 14:52 -0700, Stephen Hemminger wrote: > > On Wed, 17 Aug 2016 14:39:21 -0700 > > Eric Dumazet wrote: > > > > > From: Eric Dumazet > > > > > >

Re: [PATCH net-next 2/3] net/sched: cls_flower: Classify packet in ip tunnels

On Mon, 22 Aug 2016 17:38:33 +0300, Amir Vadai wrote: > + if (tb[TCA_FLOWER_KEY_ENC_IPV6_SRC] || > + tb[TCA_FLOWER_KEY_ENC_IPV6_DST]) > + return -ENOTSUPP; Please add also support for IPv6. We've had enough of half-implemented stuff in tunneling and we need to really treat

Re: [PATCH iproute2] ss: fix build with musl libc

On Sat, 20 Aug 2016 00:11:10 -0300 Gustavo Zacarias wrote: > UINT_MAX usage requires limits.h, so include it. > > Signed-off-by: Gustavo Zacarias Applied

Re: [PATCH net-next 1/3] net/ip_tunnels: Introduce tunnel_id_to_key32() and key32_to_tunnel_id()

While cleaning this up, you may as well take the best of both implementations. On Mon, 22 Aug 2016 17:38:32 +0300, Amir Vadai wrote: > +static inline __be64 key32_to_tunnel_id(__be32 key) > +{ > +#ifdef __BIG_ENDIAN > + return (__force __be64)((__force u32)key); The inner cast seems to be

  1   2   3   >