Re: [PATCH net 2/2] sctp: not copying duplicate addrs to the assoc's bind address list

>> > Ah, I see what you're doing. Ok, this makes some sense, at least on the >> > receive >> > side, when you get a cookie unpacked and modify the remote peers address >> > list, >> > it makes sense to check for duplicates. On the local side however, I >> > would, >> > instead of checking it

RE: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

> This patch series provides following support > a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ >Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) >and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files. > b) Support for diagnostics

[PATCH v4 net-next] net: diag: support SOCK_DESTROY for UDP sockets

This implements SOCK_DESTROY for UDP sockets similar to what was done for TCP with commit c1e64e298b8ca ("net: diag: Support destroying TCP sockets.") A process with a UDP socket targeted for destroy is awakened and recvmsg fails with ECONNABORTED. Signed-off-by: David Ahern

[PATCH] net: diag: Fix refcnt leak in error path destroying socket

inet_diag_find_one_icsk takes a reference to a socket that is not released if sock_diag_destroy returns an error. Fix by changing tcp_diag_destroy to manage the refcnt for all cases and remove the sock_put calls from tcp_abort. Fixes: c1e64e298b8ca ("net: diag: Support destroying TCP sockets")

RE: [PATCH -next] tipc: use kfree_skb() instead of kfree()

Acked-by: Ying Xue -Original Message- From: Wei Yongjun [mailto:weiyj...@gmail.com] Sent: Wednesday, August 24, 2016 7:01 AM To: Jon Maloy; Xue, Ying; David S. Miller Cc: Wei Yongjun; netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net Subject: [PATCH

Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

On 8/23/16, 7:52 AM, Jiri Pirko wrote: > Tue, Aug 23, 2016 at 04:46:37PM CEST, ro...@cumulusnetworks.com wrote: >> On 8/23/16, 12:26 AM, Jiri Pirko wrote: >>> Tue, Aug 23, 2016 at 09:04:15AM CEST, da...@davemloft.net wrote: From: Jiri Pirko Date: Tue, 23 Aug 2016

Re: [PATCH net] udp: get rid of SLAB_DESTROY_BY_RCU allocations

From: Eric Dumazet Date: Tue, 23 Aug 2016 09:57:51 -0700 > From: Eric Dumazet > > After commit ca065d0cf80f ("udp: no longer use SLAB_DESTROY_BY_RCU") > we do not need this special allocation mode anymore, even if it is > harmless. > >

Re: [PATCH] net: ena: change the return type of ena_set_push_mode() to be void.

From: Rami Rosen Date: Tue, 23 Aug 2016 20:20:17 +0300 > This patch changes the return type of ena_set_push_mode() to be void, > as it always returns 0. > > Signed-off-by: Rami Rosen Applied, thanks.

Re: [PATCH net-next 0/3] rxrpc: Miscellaneous improvements

ls/linux-fs.git > rxrpc-rewrite-20160823-2 Also pulled, thanks David.

Re: [PATCH net] sctp: fix overrun in sctp_diag_dump_one()

From: Lance Richardson Date: Tue, 23 Aug 2016 11:40:52 -0400 > The function sctp_diag_dump_one() currently performs a memcpy() > of 64 bytes from a 16 byte field into another 16 byte field. Fix > by using correct size, use sizeof to obtain correct size instead > of using a

Re: [PATCH net-next 0/5] rxrpc: Cleanups

From: David Howells <dhowe...@redhat.com> Date: Tue, 23 Aug 2016 16:26:18 +0100 > Here are some cleanups for the AF_RXRPC rewrite: ... > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160823-1 Pulled.

Re: [PATCH net] dwc_eth_qos: fix interrupt enable race

From: Lars Persson Date: Tue, 23 Aug 2016 16:31:28 +0200 > From: Rabin Vincent > > We currently enable interrupts before we enable NAPI. If an RX interrupt > hits before we enabled NAPI then the NAPI callback is never called and > we leave the hardware

Re: [PATCH -next] cxgb4: Remove unused including

From: Wei Yongjun Date: Tue, 23 Aug 2016 15:09:49 + > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

From: Wei Yongjun Date: Tue, 23 Aug 2016 15:06:05 + > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning: > symbol 'xgmiitorgmii_probe' was not declared. Should it be static? > >

Re: [PATCH -next] net: hns: remove redundant dev_err call in hns_dsaf_get_cfg()

From: Wei Yongjun Date: Tue, 23 Aug 2016 15:11:03 + > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun

Re: [PATCH net-next 1/1] qede: Add support for Tx/Rx-only queues.

From: Sudarsana Reddy Kalluru Date: Tue, 23 Aug 2016 10:56:55 -0400 > Add provision for configuring the fastpath queues with Tx (or Rx) only > functionality. > > Signed-off-by: Sudarsana Reddy Kalluru > Signed-off-by: Yuval Mintz

Re: [PATCH v3] net: lpc_eth: Check clk_prepare_enable() error

From: Fabio Estevam Date: Tue, 23 Aug 2016 09:48:20 -0300 > clk_prepare_enable() may fail, so we should better check its return > value and propagate it in the case of failure > > While at it, replace __lpc_eth_clock_enable() with a plain >

Re: [PATCH net-next] cxgb4: Fix issue while re-registering VF mgmt netdev

From: Hariprasad Shenai Date: Tue, 23 Aug 2016 11:35:32 +0530 > When we disable SRIOV, we used to unregister the netdev but wasn't > freed. But next time when the same netdev is registered, since the state > was in 'NETREG_UNREGISTERED', we used to hit BUG_ON in

Re: [net-next PATCH] net: rtnetlink: Don't export empty RTAX_FEATURES

From: Phil Sutter Date: Tue, 23 Aug 2016 13:14:31 +0200 > Since the features bit field has bits for internal only use as well, it > may happen that the kernel exports RTAX_FEATURES attribute with zero > value which is pointless. > > Fix this by making sure the attribute is added

Re: [net-next PATCH 04/15] net: sched: provide per cpu qstat helpers

On 16-08-23 04:25 PM, Eric Dumazet wrote: > On Tue, 2016-08-23 at 13:24 -0700, John Fastabend wrote: >> The per cpu qstats support was added with per cpu bstat support which >> is currently used by the ingress qdisc. This patch adds a set of >> helpers needed to make other qdiscs that use qstats

Re: [PATCH v2 net-next] net-tcp: retire TFO_SERVER_WO_SOCKOPT2 config

From: Yuchung Cheng Date: Mon, 22 Aug 2016 17:17:54 -0700 > TFO_SERVER_WO_SOCKOPT2 was intended for debugging purposes during > Fast Open development. Remove this config option and also > update/clean-up the documentation of the Fast Open sysctl. > > Reported-by: Piotr

Re: [PATCH -next] xen-netback: using kfree_rcu() to simplify the code

From: Wei Yongjun Date: Mon, 22 Aug 2016 23:01:29 + > From: Wei Yongjun > > The callback function of call_rcu() just calls a kfree(), so we > can use kfree_rcu() instead of call_rcu() + callback function. > > Signed-off-by: Wei Yongjun

Re: [PATCH] net: mv88e6xxx: Fix ingress rate removal for mv6131 chips

From: Jamie Lentin Date: Mon, 22 Aug 2016 22:47:08 +0100 > The PORT_RATE_CONTROL register works differently on 88e6095/6095f/6131 > in comparison to 6123/61/65, and 0x0 disables. The distinction was lost > Linux 4.1 --> 4.2 > > Signed-off-by: Jamie Lentin

Re: [PATCH] phy: micrel: Reenable interrupts during resume for ksz9031

From: Xander Huff Date: Mon, 22 Aug 2016 15:57:16 -0500 > Like the ksz8081, the ksz9031 has the behavior where it will clear the > interrupt enable bits when leaving power down. This takes advantage of the > solution provided by f5aba91. > > Signed-off-by: Xander Huff

Re: [PATCH net] tcp: properly scale window in tcp_v[46]_reqsk_send_ack()

From: Eric Dumazet Date: Mon, 22 Aug 2016 11:31:10 -0700 > From: Eric Dumazet > > When sending an ack in SYN_RECV state, we must scale the offered > window if wscale option was negotiated and accepted. > > Tested: > Following packetdrill test

Re: [PATCH V2] liquidio: declare liquidio_set_rxcsum_command static

From: Nicholas Mc Guire Date: Mon, 22 Aug 2016 17:52:00 +0200 > liquidio_set_rxcsum_command is a local function only, no need to expose > it outside of lio_main.c so declare it static and make sparse happy. > > Signed-off-by: Nicholas Mc Guire Applied.

Re: [PATCH v5 net-next] l2tp: Refactor the codes with existing macros instead of literal number

From: f...@ikuai8.com Date: Mon, 22 Aug 2016 22:50:02 +0800 > From: Gao Feng > > Use PPP_ALLSTATIONS, PPP_UI, and SEND_SHUTDOWN instead of 0xff, > 0x03, and 2 separately. > > Signed-off-by: Gao Feng Applied.

Re: [PATCH v2] gianfar: fix size of scatter-gathered frames

From: Zefir Kurtisi Date: Mon, 22 Aug 2016 15:58:12 +0200 > The current scatter-gather logic in gianfar is flawed, since > it does not consider the eTSEC's RxBD 'Data Length' field is > context depening: for the last fragment it contains the full > frame size, while

Re: [PATCH v05 66/72] uapi icmp.h: glibc netinet/ip_icmp.h header file compatibility fixes

From: Mikko Rapeli Date: Wed, 24 Aug 2016 00:21:45 +0300 > I could propose patches but they are bound to be incomplete so > networking devs could do this faster and with fewer review > iterations. If I did it I'm seriously not going to go any further than taking the

Re: [PATCH v2] gianfar: prevent fragmentation in DSA environments

From: Zefir Kurtisi Date: Mon, 22 Aug 2016 15:56:38 +0200 > The eTSEC register MRBLR defines the maximum space in > the RX buffers and is set to 1536 by gianfar. This > reasonably covers the common use case where the MTU > is kept at default 1500. In that case, the

Re: [PATCH v2 net] udp: fix poll() issue with zero sized packets

From: Eric Dumazet Date: Tue, 23 Aug 2016 13:59:33 -0700 > From: Eric Dumazet > > Laura tracked poll() [and friends] regression caused by commit > e6afc8ace6dd ("udp: remove headers from UDP packets before queueing") > > udp_poll() needs to know if

Re: [net-next PATCH 04/15] net: sched: provide per cpu qstat helpers

On Tue, 2016-08-23 at 13:24 -0700, John Fastabend wrote: > The per cpu qstats support was added with per cpu bstat support which > is currently used by the ingress qdisc. This patch adds a set of > helpers needed to make other qdiscs that use qstats per cpu as well. > > Signed-off-by: John

Re: [PATCH net-next 0/2] strp: Minor fixes to strparser and kcm

From: Tom Herbert Date: Tue, 23 Aug 2016 11:55:29 -0700 > Fix locking issue in kcm and losing events when paused. Series applied, thanks Tom.

Re: [PATCH net-next] alx: add tso support

From: Tobias Regnery Date: Tue, 23 Aug 2016 22:21:21 +0200 > @@ -993,6 +993,18 @@ static void alx_reset(struct work_struct *work) > rtnl_unlock(); > } > > +static inline int alx_tpd_req(struct sk_buff *skb) > +{ Please don't use inline for functions in foo.c

Re: [PATCH net] tun: fix transmit timestamp support

On Tue, 2016-08-23 at 18:22 -0400, Soheil Hassas Yeganeh wrote: > From: Soheil Hassas Yeganeh > > Instead of using sock_tx_timestamp, use skb_tx_timestamp to record > software transmit timestamp of a packet. > > sock_tx_timestamp resets and overrides the tx_flags of the skb.

[PATCH -next] tipc: use kfree_skb() instead of kfree()

From: Wei Yongjun Use kfree_skb() instead of kfree() to free sk_buff. Fixes: 0d051bf93c06 ("tipc: make bearer packet filtering generic") Signed-off-by: Wei Yongjun --- net/tipc/bearer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [net-next PATCH 02/15] net: sched: allow qdiscs to handle locking

On 16-08-23 02:08 PM, Eric Dumazet wrote: > On Tue, 2016-08-23 at 13:23 -0700, John Fastabend wrote: >> This patch adds a flag for queueing disciplines to indicate the >> stack does not need to use the qdisc lock to protect operations. >> This can be used to build lockless scheduling algorithms

[PATCH net] tun: fix transmit timestamp support

From: Soheil Hassas Yeganeh Instead of using sock_tx_timestamp, use skb_tx_timestamp to record software transmit timestamp of a packet. sock_tx_timestamp resets and overrides the tx_flags of the skb. The function is intended to be called from within the protocol layer when

Re: [PATCH] net: phy: micrel: remove suspend/resume

On 8/23/2016 2:03 PM, Florian Fainelli wrote: +others, On 08/23/2016 04:13 AM, Christophe Leroy wrote: In ERRATA DS8700A dated 05 May 2016, Microship recommends to not use software power down mode on KSZ8041 family. s/Microship/Microchip/ They say they have no plan to fix this ERRATA

Re: CVE-2014-9900 fix is not upstream

On Tue, Aug 23, 2016 at 04:49:33PM -0400, Lennart Sorensen wrote: > That would be padding after the structure elements. > > I think what was meant is that it won't add padding in the middle of the > structure due to alignment, ie it isn't doing: > > struct ethtool_wolinfo { > __u32 

Re: [net-next PATCH 02/15] net: sched: allow qdiscs to handle locking

On Tue, 2016-08-23 at 13:23 -0700, John Fastabend wrote: > This patch adds a flag for queueing disciplines to indicate the stack > does not need to use the qdisc lock to protect operations. This can > be used to build lockless scheduling algorithms and improving > performance. > > The flag is

Re: [net-next PATCH 03/15] net: sched: remove remaining uses for qdisc_qlen in xmit path

On Tue, 2016-08-23 at 13:23 -0700, John Fastabend wrote: > sch_direct_xmit() uses qdisc_qlen as a return value but all call sites > of the routine only check if it is zero or not. Simplify the logic so > that we don't need to return an actual queue length value. > > This introduces a case now

Re: [PATCH v05 66/72] uapi icmp.h: glibc netinet/ip_icmp.h header file compatibility fixes

On Mon, Aug 22, 2016 at 04:32:51PM -0700, David Miller wrote: > You have to post this properly to the netdev list. > > If netdev is not CC:'d it doesn't get properly logged in patchwork, > and won't be applied. Sorry, get_maintainers.pl did not find netdev list for these patches. Could you

Re: CVE-2014-9900 fix is not upstream

On Tue, Aug 23, 2016 at 01:34:05PM -0700, Joe Perches wrote: > On Tue, 2016-08-23 at 21:09 +0100, Al Viro wrote: > > On Tue, Aug 23, 2016 at 11:24:06AM -0700, David Miller wrote: > > ... and then we can file a bug report against the sodding compiler.  Note > > that > > struct ethtool_wolinfo { > >

[PATCH v2 net] udp: fix poll() issue with zero sized packets

From: Eric Dumazet Laura tracked poll() [and friends] regression caused by commit e6afc8ace6dd ("udp: remove headers from UDP packets before queueing") udp_poll() needs to know if there is a valid packet in receive queue, even if its payload length is 0. Change

Re: [PATCH net] udp: fix poll() issue with zero sized packets

On Tue, 2016-08-23 at 13:53 -0700, Eric Dumazet wrote: > From: Eric Dumazet > ... > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c > index e61f7cd65d08..2a2ac9e0c985 100644 > --- a/net/ipv4/udp.c > +++ b/net/ipv4/udp.c > @@ -1184,11 +1184,11 @@ out: > * Drops all bad

[PATCH v05 69/72] uapi rose.h: glibc netrose/rose.h header file compatibility fixes

Fixes these userspace compile errors and warnings when glibc netrose/rose.h is included before linux/rose.h: linux/rose.h:25:0: warning: "SIOCRSGCAUSE" redefined linux/rose.h:26:0: warning: "SIOCRSSCAUSE" redefined linux/rose.h:27:0: warning: "SIOCRSL2CALL" redefined linux/rose.h:28:0: warning:

[PATCH v05 68/72] uapi ax25.h: glibc netax25/ax25.h header file compatibility fixes

Fixes these userspace compile error when glibc netax25/ax25.h is included before linux/ax25.h: linux/ax25.h:28:0: warning: "SIOCAX25GETUID" redefined linux/ax25.h:38:0: warning: "SIOCAX25GETINFO" redefined linux/ax25.h:47:3: error: conflicting types for ‘ax25_address’ linux/ax25.h:49:8: error:

[PATCH v05 66/72] uapi icmp.h: glibc netinet/ip_icmp.h header file compatibility fixes

Fixes this userspace compile error when glibc netinet/ip_icmp.h is included before linux/icmp.h: linux/icmp.h:68:8: error: redefinition of ‘struct icmphdr’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/icmp.h| 4 +++- include/uapi/linux/libc-compat.h | 10

[PATCH v05 72/72] uapi route.h: glibc net/route.h compat fix

Fixes this userspace compile error when net/route.h is included before linux/route.h: linux/route.h:30:8: error: redefinition of ‘struct rtentry’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/libc-compat.h | 10 ++ include/uapi/linux/route.h | 4 +++- 2

[PATCH net] udp: fix poll() issue with zero sized packets

From: Eric Dumazet Laura tracked poll() [and friends] regression caused by commit e6afc8ace6dd ("udp: remove headers from UDP packets before queueing") udp_poll() needs to know if there is a valid packet in receive queue, even if its payload length is 0. Change

[PATCH] dt: net: enhance DWC EQoS binding to support Tegra186

From: Stephen Warren The Synopsys DWC EQoS is a configurable IP block which supports multiple options for bus type, clocking and reset structure, and feature list. Extend the DT binding to define a "compatible value" for the configuration contained in NVIDIA's Tegra186 SoC,

Re: [REGRESSION] Select hang with zero sized UDP packets

On Tue, 2016-08-23 at 13:06 -0700, Laura Abbott wrote: > > Fixes the test for me. You're welcome to take this as a Tested-by. Thanks Laura, I will submit an official patch immediately.

[net-next PATCH 15/15] net: sched: pfifo_fast use skb_array

This converts the pfifo_fast qdisc to use the skb_array data structure and set the lockless qdisc bit. This also removes the logic used to pick the next band to dequeue from and instead just checks a per priority array for packets from top priority to lowest. This might need to be a bit more

[net-next PATCH 14/15] net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mqprio

The sch_mqprio qdisc creates a sub-qdisc per tx queue which are then called independently for enqueue and dequeue operations. However statistics are aggregated and pushed up to the "master" qdisc. This patch adds support for any of the sub-qdiscs to be per cpu statistic qdiscs. To handle this

Re: [net-next PATCH 01/15] net: sched: cleanup qdisc_run and __qdisc_run semantics

On Tue, 2016-08-23 at 13:22 -0700, John Fastabend wrote: > Currently __qdisc_run calls qdisc_run_end() but does not call > qdisc_run_begin(). This makes it hard to track pairs of > qdisc_run_{begin,end} across function calls. > > To simplify reading these code paths and simpler code this > patch

Re: CVE-2014-9900 fix is not upstream

On Tue, 2016-08-23 at 21:09 +0100, Al Viro wrote: > On Tue, Aug 23, 2016 at 11:24:06AM -0700, David Miller wrote: > > > On some versions and architectures.  Can you guarantee that you will > > > notice when an exception appears? > > Again, show me the assembler output exhibiting the lack of > >

[net-next PATCH 13/15] net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mq

The sch_mq qdisc creates a sub-qdisc per tx queue which are then called independently for enqueue and dequeue operations. However statistics are aggregated and pushed up to the "master" qdisc. This patch adds support for any of the sub-qdiscs to be per cpu statistic qdiscs. To handle this case

Linux router kernel configuration

Hello everyone. I'm working in a small ISP company, and we're using x86 servers under debian as core and border routers. The pair of core routers (active-backup redundancy scheme) are the dual-socket servers with Xeon E5-2637 v2 CPUs and one 82599EB dual-port 10G NIC. Tasks of these routers:

[net-next PATCH 11/15] net: sched: helper to sum qlen

Reporting qlen when qlen is per cpu requires aggregating the per cpu counters. This adds a helper routine for this. Signed-off-by: John Fastabend --- include/net/sch_generic.h | 15 +++ net/sched/sch_api.c |3 ++- 2 files changed, 17

[net-next PATCH 12/15] net: sched: lockless support for netif_schedule

netif_schedule uses a bit QDISC_STATE_SCHED to tell the qdisc layer if a run of the qdisc has been scheduler. This is important when tearing down qdisc instances. We can not rcu_free an instance for example if its possible that we might have outstanding references to it. Perhaps more importantly

[PATCH for-next 1/2] net: hns: Add support of ACPI to HNS driver RoCE Reset function

In the Hip06 SoC, the RoCE Engine is part of the Hisilicon Network Subsystem and is dependent upon DSAF module. Therefore, certain functions like RESET are exposed through the common registers of HNS DSAF module which are memory-mapped by the HNS driver and currently can only be accessed through

[net-next PATCH 10/15] net: sched: qdisc_qlen for per cpu logic

Add qdisc qlen helper routines for lockless qdiscs to use. The qdisc qlen is no longer used in the hotpath but it is reported via stats query on the qdisc so it still needs to be tracked. This adds the per cpu operations needed. Signed-off-by: John Fastabend ---

[PATCH for-next 2/2] IB/hns: Add support of ACPI to the Hisilicon RoCE driver

This patch is meant to add support of ACPI to the Hisilicon RoCE driver. Changes done are primarily meant to detect the type and then either use DT specific or ACPI spcific functions. Where ever possible, this patch tries to make use of Unified Device Property Interface APIs to support both DT

[PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to the Hisilicon RoCE Driver

This patch is meant to add support of ACPI to the Hisilicon RoCE driver. Following changes have been made in the driver(s): Patch 1/2: HNS Ethernet Driver: changes to support ACPI have been done in the RoCE reset function part of the HNS ethernet driver. Earlier it only supported DT/syscon.

[net-next PATCH 09/15] net: sched: support skb_bad_tx with lockless qdisc

Similar to how gso is handled skb_bad_tx needs to be per cpu to handle lockless qdisc with multiple writer/producers. Signed-off-by: John Fastabend --- include/net/sch_generic.h |7 +++ net/sched/sch_api.c |6 +++ net/sched/sch_generic.c | 95

[net-next PATCH 08/15] net: sched: support qdisc_reset on NOLOCK qdisc

The qdisc_reset operation depends on the qdisc lock at the moment to halt any additions to gso_skb and statistics while the list is free'd and the stats zeroed. Without the qdisc lock we can not guarantee another cpu is not in the process of adding a skb to one of the "cells". To resolve the

[net-next PATCH 07/15] net: sched: drop qdisc_reset from dev_graft_qdisc

In qdisc_graft_qdisc a "new" qdisc is attached and the 'qdisc_destroy' operation is called on the old qdisc. The destroy operation will wait a rcu grace period and call qdisc_rcu_free(). At which point gso_cpu_skb is free'd along with all stats so no need to zero stats and gso_cpu_skb from the

[net-next PATCH 04/15] net: sched: provide per cpu qstat helpers

The per cpu qstats support was added with per cpu bstat support which is currently used by the ingress qdisc. This patch adds a set of helpers needed to make other qdiscs that use qstats per cpu as well. Signed-off-by: John Fastabend --- include/net/sch_generic.h |

[net-next PATCH 06/15] net: sched: per cpu gso handlers

The net sched infrastructure has a gso ptr that points to skb structs that have failed to be enqueued by the device driver. This can happen when multiple cores try to push a skb onto the same underlying hardware queue resulting in lock contention. This case is handled by a cpu collision handler

[net-next PATCH 05/15] net: sched: a dflt qdisc may be used with per cpu stats

Enable dflt qdisc support for per cpu stats before this patch a dflt qdisc was required to use the global statistics qstats and bstats. Signed-off-by: John Fastabend --- net/sched/sch_generic.c | 24 1 file changed, 20 insertions(+), 4

[net-next PATCH 03/15] net: sched: remove remaining uses for qdisc_qlen in xmit path

sch_direct_xmit() uses qdisc_qlen as a return value but all call sites of the routine only check if it is zero or not. Simplify the logic so that we don't need to return an actual queue length value. This introduces a case now where sch_direct_xmit would have returned a qlen of zero but now it

[net-next PATCH 00/15] support lockless qdisc

Latest round of lockless qdisc patch set with performance metric primarily using pktgen to inject pkts into the qdisc layer This series introduces a flag to allow qdiscs to indicate they can run without holding the qdisc lock. In order to set this bit most qdiscs will need to be modified to use

[net-next PATCH 02/15] net: sched: allow qdiscs to handle locking

This patch adds a flag for queueing disciplines to indicate the stack does not need to use the qdisc lock to protect operations. This can be used to build lockless scheduling algorithms and improving performance. The flag is checked in the tx path and the qdisc lock is only taken if it is not

[net-next PATCH 01/15] net: sched: cleanup qdisc_run and __qdisc_run semantics

Currently __qdisc_run calls qdisc_run_end() but does not call qdisc_run_begin(). This makes it hard to track pairs of qdisc_run_{begin,end} across function calls. To simplify reading these code paths and simpler code this patch moves begin/end calls into qdisc_run(). Signed-off-by: John

[PATCH net-next] alx: add tso support

Add tso/tso6 support to the alx driver. Based on information from the downstream driver at github.com/qca/alx Signed-off-by: Tobias Regnery --- drivers/net/ethernet/atheros/alx/main.c | 75 +++-- 1 file changed, 71 insertions(+), 4

Re: CVE-2014-9900 fix is not upstream

On Tue, Aug 23, 2016 at 11:24:06AM -0700, David Miller wrote: > > On some versions and architectures.  Can you guarantee that you will > > notice when an exception appears? > > Again, show me the assembler output exhibiting the lack of > initialization, for this specific structure and situation.

Re: [RFC PATCH 08/13] net: sched: support skb_bad_tx with lockless qdisc

On 16-08-17 04:00 PM, John Fastabend wrote: > On 16-08-17 03:58 PM, Eric Dumazet wrote: >> On Wed, 2016-08-17 at 12:36 -0700, John Fastabend wrote: >>> Similar to how gso is handled skb_bad_tx needs to be per cpu to handle >>> lockless qdisc with multiple writer/producers. >> \ >>> @@ -1021,6

Re: [REGRESSION] Select hang with zero sized UDP packets

On 08/23/2016 12:03 PM, Eric Dumazet wrote: On Tue, 2016-08-23 at 11:25 -0700, David Miller wrote: From: Laura Abbott Date: Tue, 23 Aug 2016 10:53:26 -0700 Fedora received a report[1] of a unit test failing on Ruby when using the 4.7 kernel. This was a test to send a zero

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

On 8/22/16 8:51 AM, Simon Horman wrote: > > The scheme that OvS uses so far is that mac_len denotes the number of bytes > from the start of the MAC header until its end. In the absence of MPLS that > will be the beginning of the network header. And in the presence of MPLS it > will be the

[PATCH net-next 2/2] kcm: Fix locking issue

Lock the lower socket in kcm_unattach. Release during call to strp_done since that function cancels the RX timers and work queue with sync. Also added some status information in psock reporting. Signed-off-by: Tom Herbert --- net/kcm/kcmproc.c | 20 +++-

[PATCH net-next 0/2] strp: Minor fixes to strparser and kcm

Fix locking issue in kcm and losing events when paused. Tom Herbert (2): strparser: Queue work when being unpaused kcm: Fix locking issue include/net/strparser.h | 5 + net/kcm/kcmproc.c | 20 +++- net/kcm/kcmsock.c | 13 -

[PATCH net-next 1/2] strparser: Queue work when being unpaused

When the upper layer unpauses a stream parser connection we need to queue rx_work to make sure no events are missed. Signed-off-by: Tom Herbert --- include/net/strparser.h | 5 + net/strparser/strparser.c | 11 +++ 2 files changed, 12 insertions(+), 4

Re: [PATCH net-next 00/14] hv_netvsc: cleanups

From: sthem...@exchange.microsoft.com Date: Tue, 23 Aug 2016 12:29:32 -0700 > Hyper-V network driver cleanups. > > The only new functionality is minor extensions to ethtool. Series applied.

Re: [PATCH] net: phy: micrel: remove suspend/resume

+others, On 08/23/2016 04:13 AM, Christophe Leroy wrote: > In ERRATA DS8700A dated 05 May 2016, Microship recommends to > not use software power down mode on KSZ8041 family. s/Microship/Microchip/ > They say they have no plan to fix this ERRATA in future releases. The errata applies to

Re: [REGRESSION] Select hang with zero sized UDP packets

On Tue, 2016-08-23 at 11:25 -0700, David Miller wrote: > From: Laura Abbott > Date: Tue, 23 Aug 2016 10:53:26 -0700 > > > Fedora received a report[1] of a unit test failing on Ruby when using > > the > > 4.7 kernel. This was a test to send a zero sized UDP packet. With the >

Re: [Xen-devel] [PATCH net-next] xen-netfront: avoid packet loss when ethernet header crosses page boundary

David Vrabel writes: > On 22/08/16 16:42, Vitaly Kuznetsov wrote: >> >> I see two ways to fix the issue: >> - Change the 'wire' protocol between netfront and netback to start keeping >> the original SKB structure. We'll have to add a flag indicating the fact >> that

Re: [PATCH net-next 2/2] net: diag: allow socket bytecode filters to match socket marks

On 8/23/16 12:06 PM, Lorenzo Colitti wrote: > @@ -713,10 +728,11 @@ static bool valid_markcond(const struct inet_diag_bc_op > *op, int len, > return len >= *min_len; > } > > -static int inet_diag_bc_audit(struct nlattr *attr) > +static int inet_diag_bc_audit(struct nlattr *attr, const

Re: [for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20

On 8/23/2016 2:39 PM, Leon Romanovsky wrote: > On Tue, Aug 23, 2016 at 07:10:53PM +0300, Saeed Mahameed wrote: >> On Tue, Aug 23, 2016 at 6:57 PM, Doug Ledford wrote: >>> On 8/23/2016 4:49 AM, Saeed Mahameed wrote: From Hadar and Ilya, added the needed hardware bits and

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

Hi, On Tue, 23 Aug 2016 19:21:41 +0300 Amir Vadai wrote: > On Tue, Aug 23, 2016 at 08:37:07AM -0400, Jamal Hadi Salim wrote: > > > > The noun "ip tunnel" is a little misleading. Unless you can use > > this for other types of tunnels (ipip, etc). If this is specific > > for just

Re: [PATCH net-next 1/2] net: diag: slightly refactor the inet_diag_bc_audit error checks.

Hi Lorenzo, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lorenzo-Colitti/net-diag-slightly-refactor-the-inet_diag_bc_audit-error-checks/20160824-020848 config: x86_64-randconfig-x015-201634 (attached as .config) compiler: gcc-6 (Debian 6.1.1-9)

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On Tue, 2016-08-23 at 14:41 +0100, Luis Henriques wrote: > From: Avijit Kanti Das > > memset() the structure ethtool_wolinfo that has padded bytes > but the padded bytes have not been zeroed out. > > Change-Id: If3fd2d872a1b1ab9521d937b86a29fc468a8bbfe >

Re: [for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20

On Tue, Aug 23, 2016 at 07:10:53PM +0300, Saeed Mahameed wrote: > On Tue, Aug 23, 2016 at 6:57 PM, Doug Ledford wrote: > > On 8/23/2016 4:49 AM, Saeed Mahameed wrote: > >> Hi Dave and Doug, > >> > >> This series contains several low level and API updates for mlx5 core > >>

[PATCH net-next 0/4] net: remove clear_sk() method

Since IPv6 socket lookups no longer dereference pinet6 pointer and UDP lost SLAB_DESTROY_BY_RCU special rules, we no longer need special clear_sk() methods. Eric Dumazet (4): ipv6: udp: remove udp_v6_clear_sk() udp: get rid of sk_prot_clear_portaddr_nulls() ipv6: tcp: get rid of

[PATCH net-next 4/4] net: remove clear_sk() method

We no longer use this handler, we can delete it. Signed-off-by: Eric Dumazet --- include/net/sock.h | 1 - net/core/sock.c| 8 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index

[PATCH net-next 3/4] ipv6: tcp: get rid of tcp_v6_clear_sk()

Now RCU lookups of IPv6 TCP sockets no longer dereference pinet6, we do not need tcp_v6_clear_sk() anymore. Signed-off-by: Eric Dumazet --- net/ipv6/tcp_ipv6.c | 12 1 file changed, 12 deletions(-) diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index

[PATCH net-next 2/4] udp: get rid of sk_prot_clear_portaddr_nulls()

Since we no longer use SLAB_DESTROY_BY_RCU for UDP, we do not need sk_prot_clear_portaddr_nulls() helper. Signed-off-by: Eric Dumazet --- include/net/sock.h | 2 -- net/core/sock.c| 18 -- net/ipv4/udp.c | 1 - net/ipv4/udplite.c | 1 -

[PATCH net-next 1/4] ipv6: udp: remove udp_v6_clear_sk()

Now RCU lookups of ipv6 udp sockets no longer dereference pinet6 field, we can get rid of udp_v6_clear_sk() helper. Signed-off-by: Eric Dumazet --- net/ipv6/udp.c | 13 + net/ipv6/udp_impl.h | 2 -- net/ipv6/udplite.c | 2 +- 3 files changed, 2

Re: [PATCH net-next 1/2] net: diag: slightly refactor the inet_diag_bc_audit error checks.

On Wed, 2016-08-24 at 03:06 +0900, Lorenzo Colitti wrote: > This simplifies the code a bit and also allows inet_diag_bc_audit > to send to userspace an error that isn't EINVAL. > > Signed-off-by: Lorenzo Colitti > --- > net/ipv4/inet_diag.c | 35

Re: [REGRESSION] Select hang with zero sized UDP packets

From: Laura Abbott Date: Tue, 23 Aug 2016 10:53:26 -0700 > Fedora received a report[1] of a unit test failing on Ruby when using > the > 4.7 kernel. This was a test to send a zero sized UDP packet. With the > 4.7 kernel, the test now timing out on a select instead of

  1   2   3   >