[PATCH net-next 5/6] net: dsa: bcm_sf2: Utilize core B53 driver when possible

2016-08-24 Thread Florian Fainelli
The Broadcom Starfighter2 is almost entirely register compatible with B53, yet for historical reasons came up first in the tree and is now being updated to utilize b53_common.c to the fullest extent possible. A few things need to be adjusted to allow that: - the switch "core" registers currently

[PATCH net-next 3/6] net: dsa: b53: Define SF2 MIB layout

2016-08-24 Thread Florian Fainelli
The 58xx and 7445 chips use the Starfighter2 code, define its MIB layout and introduce a helper function: is58xx() which checks for both of these IDs for now. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 63

[PATCH net-next 1/6] net: dsa: b53: Initialize ds->drv in b53_switch_alloc

2016-08-24 Thread Florian Fainelli
In order to alloc drivers to override specific dsa_switch_driver callbacks, initialize ds->drv to b53_switch_ops earlier, which avoids having to expose this structure to glue drivers. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 3 +-- 1 file

Re: [net] i40e: Change some init flow for the client

2016-08-24 Thread Jeff Kirsher
On Wed, 2016-08-24 at 17:51 -0700, Jeff Kirsher wrote: > From: Anjali Singhai Jain > > This change makes a common flow for Client instance open during init > and reset path. The Client subtask can handle both the cases instead of > making a separate

Improving OCTEON II 10G Ethernet performance

2016-08-24 Thread Ed Swierk
I'm trying to migrate from the Octeon SDK to a vanilla Linux 4.4 kernel for a Cavium OCTEON II (CN6880) board running in 64-bit little-endian mode. So far I've gotten most of the hardware features I need working, including XAUI/RXAUI, USB, boot bus and I2C, with a fairly small set of patches.

[PATCH net] veth: sctp: add NETIF_F_SCTP_CRC to device features

2016-08-24 Thread Xin Long
Commit b17c706987fa ("loopback: sctp: add NETIF_F_SCTP_CSUM to device features") added NETIF_F_SCTP_CRC to device features for lo device to improve the performance of sctp over lo. This patch is to add NETIF_F_SCTP_CRC to device features for veth to improve the performance of sctp over veth.

[PATCH net-next 0/6] net: dsa: Make bcm_sf2 utilize b53_common

2016-08-24 Thread Florian Fainelli
Hi all, This patch series makes the bcm_sf2 driver utilize a large number of the core functions offered by the b53_common driver since the SWITCH_CORE registers are mostly register compatible with the switches driven by b53_common. In order to accomplish that, we just override the dsa_driver_ops

[PATCH net-next 2/6] net: dsa: b53: Prepare to support 7445 switch

2016-08-24 Thread Florian Fainelli
Allocate a device entry for the Broadcom BCM7445 integrated switch currently backed by bcm_sf2.c. Since this is the latest generation, it has 4 ARL entries, 4K VLANs and uses Port 8 for the CPU/IMP port. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c

Re: [PATCH net 2/2] sctp: not copying duplicate addrs to the assoc's bind address list

2016-08-24 Thread Xin Long
> Or add a refcnt to its members. > NETDEV_UP, it gets a ++ if it's already there > NETDEV_DOWN, it gets a -- and cleans it up if it reaches 0 > And the rest probably could stay the same. > Yes, it could also avoid the issue of amounts of duplicate addrs. or add a nic index variable to its

[PATCH net-next v4 2/3] net: mpls: Fixups for GSO

2016-08-24 Thread David Ahern
As reported by Lennert the MPLS GSO code is failing to properly segment large packets. There are a couple of problems: 1. the inner protocol is not set so the gso segment functions for inner protocol layers are not getting run, and 2 MPLS labels for packets that use the "native" (non-OVS)

RE: [RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums

2016-08-24 Thread Yuval Mintz
> >> This patch assumes that the bnx2x hardware will ignore existing > >> IPv4/v6 header fields for length and checksum as well as the length > >> and checksum fields for outer UDP and GRE headers. > >> > >> I have no means of testing this as I do not have any bnx2x hardware > >> but thought I

[PATCH net-next v4 0/3] net: mpls: fragmentation and gso fixes for locally originated traffic

2016-08-24 Thread David Ahern
This series fixes mtu and fragmentation for tunnels using lwtunnel output redirect, and fixes GSO for MPLS for locally originated traffic reported by Lennert Buytenhek. A follow on series will address fragmentation and GSO for forwarded MPLS traffic. Hardware offload of GSO with MPLS also needs

[PATCH net-next v4 1/3] net: lwtunnel: Handle fragmentation

2016-08-24 Thread David Ahern
From: Roopa Prabhu Today mpls iptunnel lwtunnel_output redirect expects the tunnel output function to handle fragmentation. This is ok but can be avoided if we did not do the mpls output redirect too early. ie we could wait until ip fragmentation is done and then call

Re: A second case of XPS considerably reducing single-stream performance

2016-08-24 Thread Rick Jones
Also, while it doesn't seem to have the same massive effect on throughput, I can also see out of order behaviour happening when the sending VM is on a node with a ConnectX-3 Pro NIC. Its driver is also enabling XPS it would seem. I'm not *certain* but looking at the traces it appears that

Re: [PATCH net-next v2 1/2] net: diag: slightly refactor the inet_diag_bc_audit error checks.

2016-08-24 Thread David Miller
From: Lorenzo Colitti Date: Wed, 24 Aug 2016 15:46:25 +0900 > This simplifies the code a bit and also allows inet_diag_bc_audit > to send to userspace an error that isn't EINVAL. > > Signed-off-by: Lorenzo Colitti Applied.

Re: [PATCH net-next v2 2/2] net: diag: allow socket bytecode filters to match socket marks

2016-08-24 Thread David Miller
From: Lorenzo Colitti Date: Wed, 24 Aug 2016 15:46:26 +0900 > This allows a privileged process to filter by socket mark when > dumping sockets via INET_DIAG_BY_FAMILY. This is useful on > systems that use mark-based routing such as Android. > > The ability to filter socket

Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to the Hisilicon RoCE Driver

2016-08-24 Thread David Miller
From: Salil Mehta Date: Wed, 24 Aug 2016 04:44:48 +0800 > This patch is meant to add support of ACPI to the Hisilicon RoCE driver. > Following changes have been made in the driver(s): > > Patch 1/2: HNS Ethernet Driver: changes to support ACPI have been done in >the

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-24 Thread David Ahern
On 8/24/16 12:53 PM, David Ahern wrote: > What change is needed in pop_mpls? It already resets the mac_header and if > MPLS labels are removed there is no need to set network_header. I take it you > mean if the protocol is still MPLS and there are still labels then the > network header needs to

[PATCH net-next v4 3/3] net: veth: Set features for MPLS

2016-08-24 Thread David Ahern
veth does not really transmit packets only moves the skb from one netdev to another so gso and checksum is not really needed. Add the features to mpls_features to get the same benefit and performance with MPLS as without it. Reported-by: Lennert Buytenhek Signed-off-by:

[PATCH v1 1/1 net-next] 8139cp: Fix one possible deadloop in cp_rx_poll

2016-08-24 Thread fgao
From: Gao Feng When cp_rx_poll does not get enough packet, it will check the rx interrupt status again. If so, it will jumpt to rx_status_loop again. But the goto jump resets the rx variable as zero too. As a result, it causes one possible deadloop. Assume this case,

Re: [PATCH net-next] net: dsa: rename switch operations structure

2016-08-24 Thread David Miller
From: Vivien Didelot Date: Tue, 23 Aug 2016 12:38:56 -0400 > Now that the dsa_switch_driver structure contains only function pointers > as it is supposed to, rename it to the more appropriate dsa_switch_ops, > uniformly to any other operations structure in

[PATCH net-next v3 1/2] net: ethernet: mediatek: modify to use the PDMA instead of the QDMA for Ethernet RX

2016-08-24 Thread Nelson Chang
Because the PDMA has richer features than the QDMA for Ethernet RX (such as multiple RX rings, HW LRO, etc.), the patch modifies to use the PDMA to handle Ethernet RX. Signed-off-by: Nelson Chang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 76

[PATCH net-next v3 0/2] net: ethernet: mediatek: modify to use the PDMA for Ethernet RX

2016-08-24 Thread Nelson Chang
This patch set fixes the following issues v1 -> v2: Fix the bugs of PDMA cpu index and interrupt settings in mtk_poll_rx() v2 -> v3: Add GDM hardware settings to send packets to PDMA for RX Nelson Chang (2): net: ethernet: mediatek: modify to use the PDMA instead of the QDMA for Ethernet

[net] i40e: Change some init flow for the client

2016-08-24 Thread Jeff Kirsher
From: Anjali Singhai Jain This change makes a common flow for Client instance open during init and reset path. The Client subtask can handle both the cases instead of making a separate notify_client_of_open call. Also it may fix a bug during reset where the service task

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-24 Thread pravin shelar
On Wed, Aug 24, 2016 at 11:53 AM, David Ahern wrote: > On 8/24/16 11:41 AM, pravin shelar wrote: >> You also need to change pop_mpls(). > > What change is needed in pop_mpls? It already resets the mac_header and if > MPLS labels are removed there is no need to set

Re: [PATCH net-next 1/6] net: dsa: b53: Initialize ds->drv in b53_switch_alloc

2016-08-24 Thread Florian Fainelli
Le 24/08/2016 à 18:33, Florian Fainelli a écrit : > In order to alloc drivers to override specific dsa_switch_driver > callbacks, initialize ds->drv to b53_switch_ops earlier, which avoids > having to expose this structure to glue drivers. > > Signed-off-by: Florian Fainelli

Re: kernel BUG at net/unix/garbage.c:149!"

2016-08-24 Thread Nikolay Borisov
On Thu, Aug 25, 2016 at 12:40 AM, Hannes Frederic Sowa wrote: > On 24.08.2016 16:24, Nikolay Borisov wrote: [SNIP] > > One commit which could have to do with that is > > commit fc64869c48494a401b1fb627c9ecc4e6c1d74b0d > Author: Andrey Ryabinin

[PATCH v2] net: macb: Increase DMA TX buffer size

2016-08-24 Thread Xander Huff
From: Nathan Sullivan In recent testing with the RT patchset, we have seen cases where the transmit ring can fill even with up to 200 txbds in the ring. Increase the size of the DMA TX ring to avoid overruns. Signed-off-by: Xander Huff Signed-off-by:

Continue a discussion about the netlink interface

2016-08-24 Thread Andrei Vagin
Hello, I want to return to a discussion about the netlink interface and how to use it out of the network subsystem. I'm developing a new interface to get information about processes (task_diag). task_diag is like socket_diag but for processes. [0] In the first two versions [1] [2], I used the

Re: [PATCH v2 3/6] bpf: add BPF_PROG_ATTACH and BPF_PROG_DETACH commands

2016-08-24 Thread Tejun Heo
Hello, On Wed, Aug 24, 2016 at 10:24:20PM +0200, Daniel Mack wrote: > SYSCALL_DEFINE3(bpf, int, cmd, union bpf_attr __user *, uattr, unsigned int, > size) > { > union bpf_attr attr = {}; > @@ -888,6 +957,16 @@ SYSCALL_DEFINE3(bpf, int, cmd, union bpf_attr __user *, > uattr, unsigned

[PATCH v2] Revert "phy: IRQ cannot be shared"

2016-08-24 Thread Xander Huff
This reverts: commit 33c133cc7598 ("phy: IRQ cannot be shared") On hardware with multiple PHY devices hooked up to the same IRQ line, allow them to share it. Sergei Shtylyov says: "I'm not sure now what was the reason I concluded that the IRQ sharing was impossible... most probably I

Re: [PATCH] phy: request shared IRQ

2016-08-24 Thread Xander Huff
On 8/24/2016 1:41 PM, Sergei Shtylyov wrote: Hello. On 08/24/2016 08:53 PM, Xander Huff wrote: From: Nathan Sullivan On hardware with multiple PHY devices hooked up to the same IRQ line, allow them to share it. Note that it had been allowed until my

Re: [PATCH v2 2/6] cgroup: add support for eBPF programs

2016-08-24 Thread Tejun Heo
Hello, Daniel. On Wed, Aug 24, 2016 at 10:24:19PM +0200, Daniel Mack wrote: > +void cgroup_bpf_free(struct cgroup *cgrp) > +{ > + unsigned int type; > + > + rcu_read_lock(); > + > + for (type = 0; type < __MAX_BPF_ATTACH_TYPE; type++) { > + if (!cgrp->bpf.prog[type]) > +

Re: kernel BUG at net/unix/garbage.c:149!"

2016-08-24 Thread Hannes Frederic Sowa
On 24.08.2016 16:24, Nikolay Borisov wrote: > Hello, > > I hit the following BUG: > > [1851513.239831] [ cut here ] > [1851513.240079] kernel BUG at net/unix/garbage.c:149! > [1851513.240313] invalid opcode: [#1] SMP > [1851513.248320] CPU: 37 PID: 11683 Comm:

[PATCH] net: systemport: Fix ordering in intrl2_*_mask_clear macro

2016-08-24 Thread Florian Fainelli
Since we keep shadow copies of which interrupt sources are enabled through the intrl2_*_mask_{set,clear} macros, make sure that the ordering in which we do these two operations: update the copy, then unmask the register is correct. This is not currently a problem because we actually do not use

[PATCH V2] dt: net: enhance DWC EQoS binding to support Tegra186

2016-08-24 Thread Stephen Warren
From: Stephen Warren The Synopsys DWC EQoS is a configurable IP block which supports multiple options for bus type, clocking and reset structure, and feature list. Extend the DT binding to define a "compatible value" for the configuration contained in NVIDIA's Tegra186 SoC,

Re: [PATCH net-next] net: dsa: rename switch operations structure

2016-08-24 Thread Florian Fainelli
On 08/23/2016 09:38 AM, Vivien Didelot wrote: > Now that the dsa_switch_driver structure contains only function pointers > as it is supposed to, rename it to the more appropriate dsa_switch_ops, > uniformly to any other operations structure in the kernel. > > No functional changes here, basically

Re: [PATCH 0/5] Networking cgroup controller

2016-08-24 Thread Tejun Heo
Hello, Anoop. On Wed, Aug 10, 2016 at 05:53:13PM -0700, Anoop Naravaram wrote: > This patchset introduces a cgroup controller for the networking subsystem as a > whole. As of now, this controller will be used for: > > * Limiting the specific ports that a process in a cgroup is allowed to bind >

Re: [net] openvswitch: Allow deferred action fifo to expand during run time

2016-08-24 Thread Lance Richardson
> From: "David Miller" > To: az...@ovn.org > Cc: d...@openvswitch.com, netdev@vger.kernel.org > Sent: Friday, March 18, 2016 5:19:09 PM > Subject: Re: [net] openvswitch: Allow deferred action fifo to expand during > run time > > From: Andy Zhou > Date: Thu,

Re: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

2016-08-24 Thread John W. Linville
On Wed, Aug 24, 2016 at 10:33:04AM -0400, John W. Linville wrote: > On Wed, Aug 24, 2016 at 04:29:22AM +, Yuval Mintz wrote: > > > This patch series provides following support > > > a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ > > >Encoding/Connector types which are

Re: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

2016-08-24 Thread John W. Linville
I have pushed this series. I did modify patches 3 and 4 a bit, to properly update Makefile.am in order to keep "make distcheck" from failing -- please be more careful in the future. John P.S. I have not yet tagged this as an official release, so please test! On Tue, Aug 23, 2016 at 06:30:29AM

Re: [PATCH] dt: net: enhance DWC EQoS binding to support Tegra186

2016-08-24 Thread Stephen Warren
On 08/24/2016 02:10 AM, Lars Persson wrote: On 08/23/2016 10:47 PM, Stephen Warren wrote: The Synopsys DWC EQoS is a configurable IP block which supports multiple options for bus type, clocking and reset structure, and feature list. Extend the DT binding to define a "compatible value" for the

[PATCH] iproute: disallow ip rule del without parameters

2016-08-24 Thread Andrey Jr. Melnikov
Disallow run `ip rule del` without any parameter to avoid delete any first rule from table. Signed-off-by: Andrey Jr. Melnikov --- diff --git a/ip/iprule.c b/ip/iprule.c index 8f24206..70562c5 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -346,6 +346,11 @@ static int

Re: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

2016-08-24 Thread Vidya Sagar Ravipati
On Wed, Aug 24, 2016 at 1:01 PM, John W. Linville wrote: > I have pushed this series. I did modify patches 3 and 4 a bit, > to properly update Makefile.am in order to keep "make distcheck" > from failing -- please be more careful in the future. > Thanks for pushing the

Re: CVE-2014-9900 fix is not upstream

2016-08-24 Thread Hannes Frederic Sowa
On 24.08.2016 16:03, Lennart Sorensen wrote: > On Tue, Aug 23, 2016 at 10:25:45PM +0100, Al Viro wrote: >> Sadly, sizeof is what we use when copying that sucker to userland. So these >> padding bits in the end would've leaked, true enough, and the case is >> somewhat >> weaker. And any normal

[PATCH v2 1/6] bpf: add new prog type for cgroup socket filtering

2016-08-24 Thread Daniel Mack
For now, this program type is equivalent to BPF_PROG_TYPE_SOCKET_FILTER in terms of checks during the verification process. It may access the skb as well. Programs of this type will be attached to cgroups for network filtering and accounting. Signed-off-by: Daniel Mack ---

[PATCH v2 4/6] net: filter: run cgroup eBPF ingress programs

2016-08-24 Thread Daniel Mack
If the cgroup associated with the receiving socket has an eBPF programs installed, run them from sk_filter_trim_cap(). eBPF programs used in this context are expected to either return 1 to let the packet pass, or != 1 to drop them. The programs have access to the full skb, including the MAC

[PATCH v2 5/6] net: core: run cgroup eBPF egress programs

2016-08-24 Thread Daniel Mack
If the cgroup associated with the receiving socket has an eBPF programs installed, run them from __dev_queue_xmit(). eBPF programs used in this context are expected to either return 1 to let the packet pass, or != 1 to drop them. The programs have access to the full skb, including the MAC

[PATCH v2 0/6] Add eBPF hooks for cgroups

2016-08-24 Thread Daniel Mack
This is v2 of the patch set to allow eBPF programs for network filtering and accounting to be attached to cgroups, so that they apply to all sockets of all tasks placed in that cgroup. The logic also allows to be extendeded for other cgroup based eBPF logic. Changes from v1: * Moved all bpf

[PATCH v2 6/6] samples: bpf: add userspace example for attaching eBPF programs to cgroups

2016-08-24 Thread Daniel Mack
Add a simple userpace program to demonstrate the new API to attach eBPF programs to cgroups. This is what it does: * Create arraymap in kernel with 4 byte keys and 8 byte values * Load eBPF program The eBPF program accesses the map passed in to store two pieces of information. The

[PATCH v2 2/6] cgroup: add support for eBPF programs

2016-08-24 Thread Daniel Mack
This patch adds two sets of eBPF program pointers to struct cgroup. One for such that are directly pinned to a cgroup, and one for such that are effective for it. To illustrate the logic behind that, assume the following example cgroup hierarchy. A - B - C \ D - E If only B has a

[PATCH v2 3/6] bpf: add BPF_PROG_ATTACH and BPF_PROG_DETACH commands

2016-08-24 Thread Daniel Mack
Extend the bpf(2) syscall by two new commands, BPF_PROG_ATTACH and BPF_PROG_DETACH which allow attaching and detaching eBPF programs to a target. On the API level, the target could be anything that has an fd in userspace, hence the name of the field in union bpf_attr is called 'target_fd'. When

Re: [PATCH net-next V2 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb

2016-08-24 Thread Shmulik Ladkani
Hi, On Wed, 24 Aug 2016 15:27:08 +0300 Amir Vadai wrote: > Extract _ip_tun_rx_dst() and _ipv6_tun_rx_dst() out of ip_tun_rx_dst() > and ipv6_tun_rx_dst(), to be used without supplying an skb. Additional thing. In subsequent patches the newly introduced '_ip_tun_rx_dst' and

Re: [PATCH net-next V2 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb

2016-08-24 Thread Shmulik Ladkani
Hi, On Wed, 24 Aug 2016 15:27:08 +0300 Amir Vadai wrote: > +static inline struct metadata_dst * > +_ipv6_tun_rx_dst(struct in6_addr saddr, struct in6_addr daddr, > + __u8 tos, __u8 ttl, __be32 label, > + __be16 flags, __be64 tunnel_id, int md_size) > +{

Re: [PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

2016-08-24 Thread Eric Dumazet
On Wed, 2016-08-24 at 11:04 -0700, Rick Jones wrote: > On 08/24/2016 10:23 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > per_cpu_inc() is faster (at least on x86) than per_cpu_ptr(xxx)++; > > Is it possible it is non-trivially slower on other architectures? No, in

Re: [PATCH] net: macb: Increase DMA buffer size

2016-08-24 Thread Nicolas Ferre
Le 24/08/2016 à 20:25, Xander Huff a écrit : > From: Nathan Sullivan > > In recent testing with the RT patchset, we have seen cases where the > transmit ring can fill even with up to 200 txbds in the ring. Increase > the size of the DMA rings to avoid overruns. > >

Re: [PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

2016-08-24 Thread Eric Dumazet
On Wed, 2016-08-24 at 11:00 -0700, John Fastabend wrote: > Looks good to me. I guess we can also do the same for overlimit qstats. > > Acked-by: John Fastabend Not sure about overlimit, although I could probably change these : net/sched/act_bpf.c:85:

Re: [net-next PATCH 05/15] net: sched: a dflt qdisc may be used with per cpu stats

2016-08-24 Thread Eric Dumazet
On Wed, 2016-08-24 at 10:50 -0700, John Fastabend wrote: > On 16-08-24 10:26 AM, Eric Dumazet wrote: > > On Wed, 2016-08-24 at 10:13 -0700, John Fastabend wrote: > > > >>> > >> > >> I could fully allocate it in qdisc_alloc() but we don't know if the > >> qdisc needs per cpu data structures until

Re: [PATCH net-next V2 4/4] net/sched: Introduce act_tunnel_key

2016-08-24 Thread Shmulik Ladkani
Hi, On Wed, 24 Aug 2016 15:27:10 +0300 Amir Vadai wrote: > +config NET_ACT_TUNNEL_KEY > +tristate "IP tunnel metadata manipulation" > +depends on NET_CLS_ACT > +---help--- > + Say Y here to set/release ip tunnel metadata. > + > + If unsure, say

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-24 Thread David Ahern
On 8/24/16 11:41 AM, pravin shelar wrote: > You also need to change pop_mpls(). What change is needed in pop_mpls? It already resets the mac_header and if MPLS labels are removed there is no need to set network_header. I take it you mean if the protocol is still MPLS and there are still labels

[PATCH] net: macb: Increase DMA buffer size

2016-08-24 Thread Xander Huff
From: Nathan Sullivan In recent testing with the RT patchset, we have seen cases where the transmit ring can fill even with up to 200 txbds in the ring. Increase the size of the DMA rings to avoid overruns. Signed-off-by: Nathan Sullivan

Re: [PATCH] phy: request shared IRQ

2016-08-24 Thread Sergei Shtylyov
Hello. On 08/24/2016 08:53 PM, Xander Huff wrote: From: Nathan Sullivan On hardware with multiple PHY devices hooked up to the same IRQ line, allow them to share it. Note that it had been allowed until my (erroneous?) commit

[PATCH iproute] iptuntap: show processes using tuntap interface

2016-08-24 Thread Hannes Frederic Sowa
Show which processes are using which tun/tap devices, e.g.: $ ip -d tuntap tun0: tun Attached to processes: vpnc(9531) vnet0: tap vnet_hdr Attached to processes: qemu-system-x86(10442) virbr0-nic: tap UNKNOWN_FLAGS:800 Attached to processes: Signed-off-by: Hannes Frederic

Re: [PATCH net-next V2 1/4] net/ip_tunnels: Introduce tunnel_id_to_key32() and key32_to_tunnel_id()

2016-08-24 Thread Shmulik Ladkani
On Wed, 24 Aug 2016 15:27:07 +0300 Amir Vadai wrote: > Add utility functions to convert a 32 bits key into a 64 bits tunnel and > vice versa. > These functions will be used instead of cloning code in GRE and VXLAN, > and in tc act_iptunnel which will be introduced in a following

Re: [net-next PATCH 05/15] net: sched: a dflt qdisc may be used with per cpu stats

2016-08-24 Thread John Fastabend
On 16-08-24 09:41 AM, Eric Dumazet wrote: > On Tue, 2016-08-23 at 13:24 -0700, John Fastabend wrote: >> Enable dflt qdisc support for per cpu stats before this patch a >> dflt qdisc was required to use the global statistics qstats and >> bstats. >> >> Signed-off-by: John Fastabend

Re: [PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

2016-08-24 Thread Rick Jones
On 08/24/2016 10:23 AM, Eric Dumazet wrote: From: Eric Dumazet per_cpu_inc() is faster (at least on x86) than per_cpu_ptr(xxx)++; Is it possible it is non-trivially slower on other architectures? rick jones Signed-off-by: Eric Dumazet ---

[PATCH net] net: dsa: bcm_sf2: Fix race condition while unmasking interrupts

2016-08-24 Thread Florian Fainelli
We kept shadow copies of which interrupt sources we have enabled and disabled, but due to an order bug in how intrl2_mask_clear was defined, we could run into the following scenario: CPU0CPU1 intrl2_1_mask_clear(..) sets INTRL2_CPU_MASK_CLEAR

Re: [PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter

2016-08-24 Thread Stephen Hemminger
On Wed, 24 Aug 2016 09:01:23 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > Adds SNMP counter for drops caused by MD5 mismatches. > > The current syslog might help, but a counter is more precise and helps > monitoring. > > Signed-off-by: Eric

Re: [PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

2016-08-24 Thread John Fastabend
On 16-08-24 10:23 AM, Eric Dumazet wrote: > From: Eric Dumazet > > per_cpu_inc() is faster (at least on x86) than per_cpu_ptr(xxx)++; > > Signed-off-by: Eric Dumazet > --- > include/net/sch_generic.h |2 +- > 1 file changed, 1 insertion(+), 1

[PATCH] phy: request shared IRQ

2016-08-24 Thread Xander Huff
From: Nathan Sullivan On hardware with multiple PHY devices hooked up to the same IRQ line, allow them to share it. Signed-off-by: Nathan Sullivan Signed-off-by: Xander Huff Acked-by: Ben Shelton

Re: [PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter

2016-08-24 Thread Eric Dumazet
On Wed, 2016-08-24 at 10:35 -0700, Stephen Hemminger wrote: > You can't add value in middle of user API enum without breaking > binary compatibility. There is no binary compatibility here. /proc/net/netstat is a text file with a defined format. First line contains the headers. If 'binary

Re: [net-next PATCH 05/15] net: sched: a dflt qdisc may be used with per cpu stats

2016-08-24 Thread John Fastabend
On 16-08-24 10:26 AM, Eric Dumazet wrote: > On Wed, 2016-08-24 at 10:13 -0700, John Fastabend wrote: > >>> >> >> I could fully allocate it in qdisc_alloc() but we don't know if the >> qdisc needs per cpu data structures until after the init call > > Should not we have a flag to advertise the

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-24 Thread pravin shelar
On Wed, Aug 24, 2016 at 9:37 AM, David Ahern wrote: > On 8/24/16 10:28 AM, pravin shelar wrote: >>> How do you feel about implementing the do_output() idea I suggested above? >>> I'm happy to provide testing and review. >> >> I am not sure about changing do_output(). why

Re: [PATCH net-next v1] gso: Support partial splitting at the frag_list pointer

2016-08-24 Thread Marcelo Ricardo Leitner
Em 24-08-2016 13:27, Alexander Duyck escreveu: On Wed, Aug 24, 2016 at 2:32 AM, Steffen Klassert wrote: On Tue, Aug 23, 2016 at 07:47:32AM -0700, Alexander Duyck wrote: On Mon, Aug 22, 2016 at 10:20 PM, Steffen Klassert wrote:

[PATCH -next] ibmvnic: convert to use simple_open()

2016-08-24 Thread Wei Yongjun
From: Wei Yongjun Remove an open coded simple_open() function and replace file operations references to the function with simple_open() instead. Generated by: scripts/coccinelle/api/simple_open.cocci Signed-off-by: Wei Yongjun ---

Re: [net-next PATCH 05/15] net: sched: a dflt qdisc may be used with per cpu stats

2016-08-24 Thread Eric Dumazet
On Wed, 2016-08-24 at 10:13 -0700, John Fastabend wrote: > > > > I could fully allocate it in qdisc_alloc() but we don't know if the > qdisc needs per cpu data structures until after the init call Should not we have a flag to advertise the need of per spu stats on qdisc ? This is not clear

Re: [PATCH net] qdisc: fix a module refcount leak in qdisc_create_dflt()

2016-08-24 Thread John Fastabend
On 16-08-24 09:39 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Should qdisc_alloc() fail, we must release the module refcount > we got right before. > > Fixes: 6da7c8fcbcbd ("qdisc: allow setting default queuing discipline") > Signed-off-by: Eric Dumazet

[PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

2016-08-24 Thread Eric Dumazet
From: Eric Dumazet per_cpu_inc() is faster (at least on x86) than per_cpu_ptr(xxx)++; Signed-off-by: Eric Dumazet --- include/net/sch_generic.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/sch_generic.h

Re: [PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-08-24 Thread Florian Fainelli
On 08/24/2016 04:58 AM, Raju Lakkaraju wrote: > From: Nagaraju Lakkaraju > > This is Microsemi's VSC 85xx PHY register definitions header file. Please keep these register definitions local to the code using them unless they are shared between multiple drivers. --

Re: [PATCH 3/3] net: fs_enet: make rx_copybreak value configurable

2016-08-24 Thread Florian Fainelli
On 08/24/2016 03:36 AM, Christophe Leroy wrote: > Measurement shows that on a MPC8xx running at 132MHz, the optimal > limit is 112: > * 114 bytes packets are processed in 147 TB ticks with higher copybreak > * 114 bytes packets are processed in 148 TB ticks with lower copybreak > * 128 bytes

Re: [PATCH net] qdisc: fix a module refcount leak in qdisc_create_dflt()

2016-08-24 Thread John Fastabend
On 16-08-24 09:39 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Should qdisc_alloc() fail, we must release the module refcount > we got right before. > > Fixes: 6da7c8fcbcbd ("qdisc: allow setting default queuing discipline") > Signed-off-by: Eric Dumazet

Re: [PATCH net-next 0/2] rxrpc: More fixes

2016-08-24 Thread David Miller
From: David Howells <dhowe...@redhat.com> Date: Wed, 24 Aug 2016 15:59:46 +0100 > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160824-1 Both -1 and -2 pulled, thanks David!

[PATCH net] qdisc: fix a module refcount leak in qdisc_create_dflt()

2016-08-24 Thread Eric Dumazet
From: Eric Dumazet Should qdisc_alloc() fail, we must release the module refcount we got right before. Fixes: 6da7c8fcbcbd ("qdisc: allow setting default queuing discipline") Signed-off-by: Eric Dumazet --- net/sched/sch_generic.c |9 + 1

Re: [for-next 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-24

2016-08-24 Thread David Miller
From: Saeed Mahameed Date: Wed, 24 Aug 2016 13:38:59 +0300 > This series contains some low level and API updates for mlx5 core > driver interface and mlx5_ifc.h, plus mlx5 LAG core driver support, > to be shared as base code for net-next and rdma mlx5 4.9 submissions.

Re: [patch net 0/2] mlxsw: couple of fixes

2016-08-24 Thread David Miller
From: Jiri Pirko Date: Wed, 24 Aug 2016 11:18:50 +0200 > Ido Schimmel (1): > mlxsw: spectrum: Add missing flood to router port > > Yotam Gigi (1): > mlxsw: router: Enable neighbors to be created on stacked devices Both applied, thanks Jiri.

Re: [PATCH net-next] bnx2x: Don't flush multicast MACs

2016-08-24 Thread David Miller
From: Yuval Mintz Date: Wed, 24 Aug 2016 13:27:19 +0300 > When ndo_set_rx_mode() is called for bnx2x, as part of process of > configuring the new MAC address filters [both unicast & multicast] > driver begins by flushing the existing configuration and then iterating >

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-24 Thread David Ahern
On 8/24/16 10:28 AM, pravin shelar wrote: >> How do you feel about implementing the do_output() idea I suggested above? >> I'm happy to provide testing and review. > > I am not sure about changing do_output(). why not just use same scheme > to track mpls header in OVS datapath as done in mpls

Re: [net-next PATCH 05/15] net: sched: a dflt qdisc may be used with per cpu stats

2016-08-24 Thread Eric Dumazet
On Tue, 2016-08-23 at 13:24 -0700, John Fastabend wrote: > Enable dflt qdisc support for per cpu stats before this patch a > dflt qdisc was required to use the global statistics qstats and > bstats. > > Signed-off-by: John Fastabend > --- > net/sched/sch_generic.c |

Re: [patch net-next 0/7] mlxsw: Offload FDB learning configuration

2016-08-24 Thread David Miller
From: Jiri Pirko Date: Wed, 24 Aug 2016 12:00:22 +0200 > From: Jiri Pirko > > Ido says: > This patchset addresses two long standing issues in the mlxsw driver > concerning FDB learning. > > Patch 1 limits the number of FDB records processed by the driver

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-24 Thread pravin shelar
On Wed, Aug 24, 2016 at 12:20 AM, Simon Horman wrote: > Hi David, > > On Tue, Aug 23, 2016 at 01:24:51PM -0600, David Ahern wrote: >> On 8/22/16 8:51 AM, Simon Horman wrote: >> > >> > The scheme that OvS uses so far is that mac_len denotes the number of bytes >> > from

Re: [net-next PATCH 05/15] net: sched: a dflt qdisc may be used with per cpu stats

2016-08-24 Thread Eric Dumazet
On Tue, 2016-08-23 at 13:24 -0700, John Fastabend wrote: > Enable dflt qdisc support for per cpu stats before this patch a > dflt qdisc was required to use the global statistics qstats and > bstats. > > Signed-off-by: John Fastabend > --- > net/sched/sch_generic.c |

Re: [PATCH net-next v1] gso: Support partial splitting at the frag_list pointer

2016-08-24 Thread Alexander Duyck
On Wed, Aug 24, 2016 at 2:32 AM, Steffen Klassert wrote: > On Tue, Aug 23, 2016 at 07:47:32AM -0700, Alexander Duyck wrote: >> On Mon, Aug 22, 2016 at 10:20 PM, Steffen Klassert >> wrote: >> > Since commit 8a29111c7 ("net: gro: allow to

[PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter

2016-08-24 Thread Eric Dumazet
From: Eric Dumazet Adds SNMP counter for drops caused by MD5 mismatches. The current syslog might help, but a counter is more precise and helps monitoring. Signed-off-by: Eric Dumazet --- include/uapi/linux/snmp.h |1 + net/ipv4/proc.c

Re: wan-cosa: Use memdup_user() rather than duplicating its implementation

2016-08-24 Thread SF Markus Elfring
> What about the GFP_DMA attribute, which your patch deletes? > The buffer in question has to be ISA DMA-able. Thanks for your constructive feedback. Would you be interested in using a variant of the function "memdup_…" with which the corresponding memory allocation option can be

Re: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

2016-08-24 Thread John W. Linville
On Wed, Aug 24, 2016 at 04:29:22AM +, Yuval Mintz wrote: > > This patch series provides following support > > a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ > >Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) > >and QSFP+/QSFP28

Re: [PATCH 1/3 v2] net: smsc911x: augment device tree bindings

2016-08-24 Thread Arnd Bergmann
On Wednesday, August 24, 2016 2:59:40 PM CEST Linus Walleij wrote: > +- interrupts : Should contain the SMSC LAN > + interrupt line as cell 0, cell 1 is an OPTIONAL PME (power > + management event) interrupt that is able to wake up the host > + system with a 50ms pulse on network activity > +

Re: [PATCH net-next] tcp: md5: increment sk_drops on syn_recv state

2016-08-24 Thread Neal Cardwell
On Wed, Aug 24, 2016 at 11:50 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > TCP MD5 mismatches do increment sk_drops counter in all states but > SYN_RECV. > > This is very unlikely to happen in the real world, but worth adding > to help

A second case of XPS considerably reducing single-stream performance

2016-08-24 Thread Rick Jones
Back in February of this year, I reported some performance issues with the ixgbe driver enabling XPS by default and instance network performance in OpenStack: http://www.spinics.net/lists/netdev/msg362915.html I've now seen the same thing with be2net and Skyhawk. In this case, the magnitude

[PATCH net-next] tcp: md5: increment sk_drops on syn_recv state

2016-08-24 Thread Eric Dumazet
From: Eric Dumazet TCP MD5 mismatches do increment sk_drops counter in all states but SYN_RECV. This is very unlikely to happen in the real world, but worth adding to help diagnostics. We increase the parent (listener) sk_drops. Signed-off-by: Eric Dumazet

Re: [PATCH] wan-cosa: Use memdup_user() rather than duplicating its implementation

2016-08-24 Thread Jan Kasprzak
Hello, SF Markus Elfring wrote: : From: Markus Elfring : Date: Sat, 20 Aug 2016 10:10:12 +0200 : : Reuse existing functionality from memdup_user() instead of keeping : duplicate source code. : : This issue was detected by using the Coccinelle software.

  1   2   3   >