Re: [PATCH v3 0/5] net/usb: asix driver improvements

2016-08-31 Thread David Miller
From: robert.f...@collabora.com Date: Mon, 29 Aug 2016 09:32:14 -0400 > This is a resubmission of v3, since the netdev > mailinlist was not sent the previous submission. > > This series improves power management of the asix driver. ... Series applied, thanks.

Re: [PATCH net 0/3] qed*: dcbx fix series.

2016-08-31 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Mon, 29 Aug 2016 08:29:51 -0400 > The series contains several small fixes for qed* dcbx module. Series applied, thanks.

Re: [PATCH] mISDN: mark symbols static where possible

2016-08-31 Thread David Miller
Three different patches all with the same Subject line, so I can't apply this stuff. You must make the subject lines unique so that someone reading the "git shortlog" can tell what is different in each change.

Re: [Patch net] kcm: fix a socket double free

2016-08-31 Thread David Miller
From: Cong Wang Date: Sun, 28 Aug 2016 21:28:26 -0700 > Dmitry reported a double free on kcm socket, which could > be easily reproduced by: > > #include > #include > > int main() > { > int fd = syscall(SYS_socket, 0x29ul, 0x5ul,

Re: [PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors

2016-08-31 Thread David Miller
From: Eli Cooper Date: Sun, 28 Aug 2016 11:34:06 +0800 > According to RFC 1885 2.2(c), the source address of ICMPv6 > errors in response to forwarded packets should be set to the > unicast address of the forwarding interface in order to be helpful > in diagnosis. Currently the

Re: [PATCH net v4 0/9] net: ethernet: mediatek: a couple of fixes

2016-08-31 Thread David Miller
From: Date: Thu, 1 Sep 2016 10:47:26 +0800 > a couple of fixes come out from integrating with linux-4.8 rc1 > they all are verified and workable on linux-4.8 rc1 Series applied.

Re: [PATCH 4/5] r8152: constify ethtool_ops structures

2016-08-31 Thread David Miller
From: Julia Lawall Date: Thu, 1 Sep 2016 00:21:22 +0200 > Check for ethtool_ops structures that are only stored in the ethtool_ops > field of a net_device structure or passed as the second argument to > netdev_set_default_ethtool_ops. These contexts are declared const, so

Re: [PATCH 5/5] net: axienet: constify ethtool_ops structures

2016-08-31 Thread David Miller
From: Julia Lawall Date: Thu, 1 Sep 2016 00:21:23 +0200 > Check for ethtool_ops structures that are only stored in the ethtool_ops > field of a net_device structure or passed as the second argument to > netdev_set_default_ethtool_ops. These contexts are declared const, so

Re: [PATCH 1/5] net: mediatek: constify ethtool_ops structures

2016-08-31 Thread David Miller
From: Julia Lawall Date: Thu, 1 Sep 2016 00:21:19 +0200 > Check for ethtool_ops structures that are only stored in the ethtool_ops > field of a net_device structure or passed as the second argument to > netdev_set_default_ethtool_ops. These contexts are declared const, so

Re: [PATCH net-next 00/12] net: Convert vrf from dst to tx hook

2016-08-31 Thread David Miller
From: David Ahern Date: Wed, 31 Aug 2016 17:14:13 -0600 > please drop this series. BGP smoke tests triggered a couple of > problems I need to resolve. Ok.

Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops

2016-08-31 Thread Tom Lendacky
On 08/31/2016 04:17 PM, David Miller wrote: > From: Stephen Hemminger > Date: Wed, 31 Aug 2016 08:57:36 -0700 > >> Casting away const is bad practice. Since this is ARM specific driver >> don't have hardware actually test this. >> >> Having getter functions for ops is

[PATCH net v4 5/9] net: ethernet: mediatek: fix logic unbalance between probe and remove

2016-08-31 Thread sean.wang
From: Sean Wang original mdio_cleanup is not in the symmetric place against where mdio_init is, so relocate mdio_cleanup to the right one. Signed-off-by: Sean Wang Acked-by: John Crispin ---

[PATCH net v4 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

2016-08-31 Thread sean.wang
From: Sean Wang Return -ENODEV if the MDIO bus is disabled in the device tree. Signed-off-by: Sean Wang Acked-by: John Crispin Reviewed-by: Andrew Lunn --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1

[PATCH net v4 3/9] net: ethernet: mediatek: fix API usage with skb_free_frag

2016-08-31 Thread sean.wang
From: Sean Wang use skb_free_frag() instead of legacy put_page() Signed-off-by: Sean Wang Acked-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net v4 1/9] net: ethernet: mediatek: fix fails from TX housekeeping due to incorrect port setup

2016-08-31 Thread sean.wang
From: Sean Wang which net device the SKB is complete for depends on the forward port on txd4 on the corresponding TX descriptor, but the information isn't set up well in case of SKB fragments that would lead to watchdog timeout from the upper layer, so fix it up.

[PATCH net v4 6/9] net: ethernet: mediatek: fix issue of driver removal with interface is up

2016-08-31 Thread sean.wang
From: Sean Wang mtk_stop() must be called to stop for freeing DMA resources acquired and restoring state changed by mtk_open() firstly when module removal. Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 8 1

[PATCH net v4 7/9] net: ethernet: mediatek: fix the missing of_node_put() after node is used done inside mtk_mdio_init

2016-08-31 Thread sean.wang
From: Sean Wang This patch adds the missing of_node_put() after finishing the usage of of_get_child_by_name. Signed-off-by: Sean Wang Acked-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 + 1 file

[PATCH net v4 8/9] net: ethernet: mediatek: use devm_mdiobus_alloc instead of mdiobus_alloc inside mtk_mdio_init

2016-08-31 Thread sean.wang
From: Sean Wang a lot of parts in the driver uses devm_* APIs to gain benefits from the device resource management, so devm_mdiobus_alloc is also used instead of mdiobus_alloc to have more elegant code flow. Using common code provided by the devm_* helps to 1) have

[PATCH net v4 4/9] net: ethernet: mediatek: remove redundant free_irq for devm_request_irq allocated irq

2016-08-31 Thread sean.wang
From: Sean Wang these irqs are not used for shared irq and disabled during ethernet stops. irq requested by devm_request_irq is safe to be freed automatically on driver detach. Signed-off-by: Sean Wang Acked-by: John Crispin

[PATCH net v4 2/9] net: ethernet: mediatek: fix incorrect return value of devm_clk_get with EPROBE_DEFER

2016-08-31 Thread sean.wang
From: Sean Wang 1) If the return value of devm_clk_get is EPROBE_DEFER, we should defer probing the driver. The change is verified and works based on 4.8-rc1 staying with the latest clk-next code for MT7623. 2) Changing with the usage of loops to work out if all clocks

[PATCH net v4 0/9] net: ethernet: mediatek: a couple of fixes

2016-08-31 Thread sean.wang
From: Sean Wang a couple of fixes come out from integrating with linux-4.8 rc1 they all are verified and workable on linux-4.8 rc1 Changes since v1: - usage of loops to work out if all required clock are ready instead of tedious coding - remove redundant pinctrl setup

Re: [PATCH] ipv6: Don't unset flowi6_proto in ipxip6_tnl_xmit()

2016-08-31 Thread Eli Cooper
Hello, On 2016/9/1 4:56, David Miller wrote: > From: Eli Cooper > Date: Fri, 26 Aug 2016 23:52:29 +0800 > >> @@ -1174,6 +1174,7 @@ ip4ip6_tnl_xmit(struct sk_buff *skb, struct net_device >> *dev) >> encap_limit = t->parms.encap_limit; >> >> memcpy(,

Re: [PATCH net-next 0/4] xps_flows: XPS flow steering when there is no socket

2016-08-31 Thread Eric Dumazet
On Wed, 2016-08-31 at 17:10 -0700, Tom Herbert wrote: > Tested: > Manually forced all packets to go through the xps_flows path. > Observed that some flows were deferred to change queues because > packets were in flight witht the flow bucket. I did not realize you were ready to submit this

Re: [PATCH v2 net-next 0/6] perf, bpf: add support for bpf in sw/hw perf_events

2016-08-31 Thread Brendan Gregg
On Wed, Aug 31, 2016 at 2:50 PM, Alexei Starovoitov wrote: > Hi Peter, Dave, > > this patch set is a follow up to the discussion: > https://lkml.kernel.org/r/20160804142853.GO6862%20()%20twins%20!%20programming%20!%20kicks-ass%20!%20net > It turned out to be simpler than what we

[PATCH net-next 3/4] net: Add xps_dev_flow_table_cnt

2016-08-31 Thread Tom Herbert
Add infrastructure and definitions to create XFS flow tables. This creates the new sys entry /sys/class/net/eth*/xps_dev_flow_table_cnt Signed-off-by: Tom Herbert --- include/linux/netdevice.h | 24 + net/core/net-sysfs.c | 89

[PATCH net-next 2/4] dql: Add counters for number of queuing and completion operations

2016-08-31 Thread Tom Herbert
Add two new counters to struct dql that are num_enqueue_ops and num_completed_ops. num_enqueue_ops is incremented by one in each call to dql_queued. num_enqueue_ops is incremented in dql_completed which takes an argument indicating number of operations completed. These counters are only intended

[PATCH net-next 4/4] xps_flows: XPS for packets that don't have a socket

2016-08-31 Thread Tom Herbert
xps_flows maintains a per device flow table that is indexed by the skbuff hash. The table is only consulted when there is no queue saved in a transmit socket for an skbuff. Each entry in the flow table contains a queue index and a queue pointer. The queue pointer is set when a queue is chosen

[PATCH net-next 0/4] xps_flows: XPS flow steering when there is no socket

2016-08-31 Thread Tom Herbert
This patch set introduces transmit flow steering for socketless packets. The idea is that we record the transmit queues in a flow table that is indexed by skbuff hash. The flow table entries have two values: the queue_index and the head cnt of packets from the TX queue. We only allow a queue to

[PATCH net-next 1/4] net: Set SW hash in skb_set_hash_from_sk

2016-08-31 Thread Tom Herbert
Use the __skb_set_sw_hash to set the hash in an skbuff from the socket txhash. Signed-off-by: Tom Herbert --- include/net/sock.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index c797c57..12e585c 100644

[PATCH v3 4/5] arm64: dts: rockchip: add the gmac needed node for rk3399

2016-08-31 Thread Caesar Wang
The RK3399 GMAC Ethernet Controller provides a complete Ethernet interface from processor to a Reduced Media Independent Interface (RMII) and Reduced Gigabit Media Independent Interface (RGMII) compliant Ethernet PHY. This patch adds the related needed device information. e.g.: interrupts, grf,

[PATCH v3 5/5] arm64: dts: rockchip: enable the gmac for rk3399 evb board

2016-08-31 Thread Caesar Wang
We add the required and optional properties for evb board. See the [0] to get the detail information. [0]: Documentation/devicetree/bindings/net/rockchip-dwmac.txt Signed-off-by: Roger Chen Signed-off-by: Caesar Wang --- Changes in v3: None

[PATCH v3 0/5] Support the rk3399 gmac pd function

2016-08-31 Thread Caesar Wang
This patch add to handle the gmac pd, and support the rk3399 gmac for devicetree. The History version: v1: https://lkml.org/lkml/2016/8/30/668 v2: https://lkml.org/lkml/2016/8/31/27 Changes in v3: - leave into two patches based on patchv2, and fix nits and commit, as comment on

[PATCH v3 3/5] arm64: dts: rockchip: add the gmac power domain on rk3399

2016-08-31 Thread Caesar Wang
This patch supports the gmac pd to save power consumption. Even though some boards not need Ethernet support, the driver core can also take care of powering up the pd before probe. Signed-off-by: Roger Chen Signed-off-by: Caesar Wang --- Changes

[PATCH v3 2/5] net: stmmac: dwmac-rk: add pd_gmac support for rk3399

2016-08-31 Thread Caesar Wang
From: David Wu Add the gmac power domain support for rk3399, in order to save more power consumption. Signed-off-by: David Wu Signed-off-by: Caesar Wang --- Changes in v3: None Changes in v2: - fixes the build error on

Re: [PATCH] softirq: let ksoftirqd do its job

2016-08-31 Thread Rick Jones
On 08/31/2016 04:11 PM, Eric Dumazet wrote: On Wed, 2016-08-31 at 15:47 -0700, Rick Jones wrote: With regard to drops, are both of you sure you're using the same socket buffer sizes? Does it really matter ? At least at points in the past I have seen different drop counts at the SO_RCVBUF

[PATCH v3 1/5] net: stmmac: dwmac-rk: fixes the gmac resume after PD on/off

2016-08-31 Thread Caesar Wang
From: Roger Chen GMAC Power Domain(PD) will be disabled during suspend. That will causes GRF registers reset. So corresponding GRF registers for GMAC must be setup again. Signed-off-by: Roger Chen Signed-off-by: Caesar Wang

[PATCH] [v10] net: emac: emac gigabit ethernet controller driver

2016-08-31 Thread Timur Tabi
Add support for the Qualcomm Technologies, Inc. EMAC gigabit Ethernet controller. This driver supports the following features: 1) Checksum offload. 2) Interrupt coalescing support. 3) SGMII phy. 4) phylib interface for external phy Based on original work by Niranjana Vishwanathapura

Re: [PATCH] softirq: let ksoftirqd do its job

2016-08-31 Thread Eric Dumazet
On Wed, 2016-08-31 at 15:47 -0700, Rick Jones wrote: > With regard to drops, are both of you sure you're using the same socket > buffer sizes? Does it really matter ? I used the standard /proc/sys/net/core/rmem_default, but under flood receive queue is almost always full, even if you make it

Re: [PATCH net-next 00/12] net: Convert vrf from dst to tx hook

2016-08-31 Thread David Ahern
On 8/30/16 11:34 AM, David Ahern wrote: > This series fixes this problem by removing the output dst that points > to the VRF and always doing the actual FIB lookup. This allows the real > dst to be cached on sockets and used for MSS. Packets are diverted to > the VRF device on Tx using an l3mdev

Re: [PATCH] softirq: let ksoftirqd do its job

2016-08-31 Thread Rick Jones
With regard to drops, are both of you sure you're using the same socket buffer sizes? In the meantime, is anything interesting happening with TCP_RR or TCP_STREAM? happy benchmarking, rick jones

[PATCH 0/5] constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
Constify ethtool_ops structures. --- drivers/net/ethernet/mediatek/mtk_eth_soc.c |2 +- drivers/net/ethernet/synopsys/dwc_eth_qos.c |2 +- drivers/net/ethernet/xilinx/xilinx_axienet_main.c |2 +- drivers/net/usb/r8152.c |2 +-

[PATCH 5/5] net: axienet: constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The

[PATCH 3/5] dwc_eth_qos: constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The

[PATCH 4/5] r8152: constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The

[PATCH 1/5] net: mediatek: constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The

Re: [PATCH] softirq: let ksoftirqd do its job

2016-08-31 Thread Eric Dumazet
On Wed, 2016-08-31 at 23:51 +0200, Jesper Dangaard Brouer wrote: > > The result from this run were handling 1,517,248 pps, without any > drops, all processes pinned to the same CPU. > > $ nstat > /dev/null && sleep 1 && nstat > #kernel > IpInReceives15172250.0

[PATCH net-next] net: dsa: remove ds_to_priv

2016-08-31 Thread Vivien Didelot
Access the priv member of the dsa_switch structure directly, instead of having an unnecessary helper. Signed-off-by: Vivien Didelot --- drivers/net/dsa/b53/b53_common.c | 42 +++ drivers/net/dsa/bcm_sf2.h| 2 +-

RE: [PATCH net-next V4 00/10] liquidio CN23XX support

2016-08-31 Thread Vatsavayi, Raghu
Thanks Much. > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, August 31, 2016 2:13 PM > To: Vatsavayi, Raghu > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH net-next V4 00/10] liquidio CN23XX support > > From: Raghu Vatsavayi

[PATCH v2 net-next 4/6] perf, bpf: add perf events core support for BPF_PROG_TYPE_PERF_EVENT programs

2016-08-31 Thread Alexei Starovoitov
Allow attaching BPF_PROG_TYPE_PERF_EVENT programs to sw and hw perf events via overflow_handler mechanism. When program is attached the overflow_handlers become stacked. The program acts as a filter. Returning zero from the program means that the normal perf_event_output handler will not be called

[PATCH v2 net-next 0/6] perf, bpf: add support for bpf in sw/hw perf_events

2016-08-31 Thread Alexei Starovoitov
Hi Peter, Dave, this patch set is a follow up to the discussion: https://lkml.kernel.org/r/20160804142853.GO6862%20()%20twins%20!%20programming%20!%20kicks-ass%20!%20net It turned out to be simpler than what we discussed. Patches 1-3 is bpf-side prep for the main patch 4 that adds bpf program as

[PATCH v2 net-next 2/6] bpf: introduce BPF_PROG_TYPE_PERF_EVENT program type

2016-08-31 Thread Alexei Starovoitov
Introduce BPF_PROG_TYPE_PERF_EVENT programs that can be attached to HW and SW perf events (PERF_TYPE_HARDWARE and PERF_TYPE_SOFTWARE correspondingly in uapi/linux/perf_event.h) The program visible context meta structure is struct bpf_perf_event_data { struct pt_regs regs; __u64

[PATCH v2 net-next 3/6] bpf: perf_event progs should only use preallocated maps

2016-08-31 Thread Alexei Starovoitov
Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use preallocated hash maps, since doing memory allocation in overflow_handler can crash depending on where nmi got triggered. Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann ---

[PATCH v2 net-next 1/6] bpf: support 8-byte metafield access

2016-08-31 Thread Alexei Starovoitov
The verifier supported only 4-byte metafields in struct __sk_buff and struct xdp_md. The metafields in upcoming struct bpf_perf_event are 8-byte to match register width in struct pt_regs. Teach verifier to recognize 8-byte metafield access. The patch doesn't affect safety of sockets and xdp

[PATCH v2 net-next 5/6] samples/bpf: add perf_event+bpf example

2016-08-31 Thread Alexei Starovoitov
The bpf program is called 50 times a second and does hashmap[kern_stackid]++ It's primary purpose to check that key bpf helpers like map lookup, update, get_stackid, trace_printk and ctx access are all working. It checks: - PERF_COUNT_HW_CPU_CYCLES on all cpus - PERF_COUNT_HW_CPU_CYCLES for

Re: [PATCH] softirq: let ksoftirqd do its job

2016-08-31 Thread Jesper Dangaard Brouer
On Wed, 31 Aug 2016 13:42:30 -0700 Eric Dumazet wrote: > On Wed, 2016-08-31 at 21:40 +0200, Jesper Dangaard Brouer wrote: > > > I can confirm the improvement of approx 900Kpps (no wonder people have > > been complaining about DoS against UDP/DNS servers). > > > > BUT

Re: [PATCH] irda: Fix likely typo in output format string

2016-08-31 Thread David Miller
From: Oleg Drokin Date: Wed, 31 Aug 2016 17:36:44 -0400 > > On Aug 31, 2016, at 5:31 PM, David Miller wrote: > >> From: Oleg Drokin >> Date: Fri, 26 Aug 2016 23:14:06 -0400 >> >>> %ul would print an unsigned with a letter l at the end which does

[PATCH v2 net-next 6/6] samples/bpf: add sampleip example

2016-08-31 Thread Alexei Starovoitov
From: Brendan Gregg sample instruction pointer and frequency count in a BPF map Signed-off-by: Brendan Gregg Signed-off-by: Alexei Starovoitov --- samples/bpf/Makefile| 4 + samples/bpf/sampleip_kern.c | 38 +

Re: [PATCH V2] dt: net: enhance DWC EQoS binding to support Tegra186

2016-08-31 Thread Stephen Warren
On 08/31/2016 03:15 AM, Lars Persson wrote: On 08/30/2016 10:50 PM, Stephen Warren wrote: On 08/30/2016 01:01 PM, Rob Herring wrote: On Wed, Aug 24, 2016 at 03:20:46PM -0600, Stephen Warren wrote: The Synopsys DWC EQoS is a configurable IP block which supports multiple options for bus type,

Re: [RESEND PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399

2016-08-31 Thread Doug Anderson
Hi, On Wed, Aug 31, 2016 at 2:29 PM, Heiko Stübner wrote: >> IMHO it would be nice if this were broken into two patches. >> >> 1. First patch would be the power domain patch and that could land any >> time. You wouldn't actually be able to use the gmac but at least >> you'd be

Re: [PATCH] irda: Fix likely typo in output format string

2016-08-31 Thread Oleg Drokin
On Aug 31, 2016, at 5:31 PM, David Miller wrote: > From: Oleg Drokin > Date: Fri, 26 Aug 2016 23:14:06 -0400 > >> %ul would print an unsigned with a letter l at the end which does >> not seem to be desired here, on the other hand the value being printed >> is u32 so just

Re: [PATCH] irda: Fix likely typo in output format string

2016-08-31 Thread David Miller
From: Oleg Drokin Date: Fri, 26 Aug 2016 23:14:06 -0400 > %ul would print an unsigned with a letter l at the end which does > not seem to be desired here, on the other hand the value being printed > is u32 so just drop the l instead of converting to %lu > > Signed-off-by:

Re: [RESEND PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399

2016-08-31 Thread Heiko Stübner
Am Mittwoch, 31. August 2016, 13:42:17 schrieb Doug Anderson: > Caesar, > > On Tue, Aug 30, 2016 at 11:13 PM, Caesar Wang wrote: > > This patch adds needed gamc information for rk3399, > > also support the gmac pd. > > > > Signed-off-by: Roger Chen

Re: [PATCH net v3 0/9] net: ethernet: mediatek: a couple of fixes

2016-08-31 Thread David Miller
From: Date: Tue, 30 Aug 2016 10:59:16 +0800 > a couple of fixes come out from integrating with linux-4.8 rc1 > they all are verified and workable on linux-4.8 rc1 I get rejects when I try to apply this to the current tree.

Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops

2016-08-31 Thread David Miller
From: Stephen Hemminger Date: Wed, 31 Aug 2016 08:57:36 -0700 > Casting away const is bad practice. Since this is ARM specific driver > don't have hardware actually test this. > > Having getter functions for ops is really unnecessary code bloat, but > not going to

Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

2016-08-31 Thread Andrew Lunn
> >You can just as easily find the child node called ethernet-phy. > > As Andrew pointed out, using phy-handle allows me to place the phy > node anywhere. > > I've already made changes to this design, and every change has > raised objections. I don't see anything wrong with phy-handle. A > lot

Re: [PATCH net-next v2 0/3] net: dsa: add MDB support

2016-08-31 Thread David Miller
From: Andrew Lunn Date: Wed, 31 Aug 2016 18:04:05 +0200 > On Wed, Aug 31, 2016 at 11:50:02AM -0400, Vivien Didelot wrote: >> This patchset adds the switchdev MDB object support to the DSA layer. >> >> The MDB support for the mv88e6xxx driver is very similar to the FDB >>

Re: [PATCH net-next V4 00/10] liquidio CN23XX support

2016-08-31 Thread David Miller
From: Raghu Vatsavayi Date: Wed, 31 Aug 2016 11:03:19 -0700 > Following patchset adds support for new device "CN23XX" in > liquidio family of adapters. As adviced by you I have split > the previous V3 patch of 18 patches into two halves. This > first patchset has

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread David Howells
Arnd Bergmann wrote: > Right, sorry about that. Do you want me to resend the fixed version, > or do you apply and fix it yourself? I can fix it up myself. I'll pull it into my tree when I've finished doing the fixing up I'm currently working on. David

Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

2016-08-31 Thread Timur Tabi
Rob Herring wrote: It's not a generic phy. It's a funky "internal phy" that differs among >SOCs. I call it the internal phy, but I could use another name. Internally, >some people call it the "sgmii phy", but I don't think that's accurate. Funky internal PHYs are precisely the types of PHYs

Re: [PATCH 3/5] rxrpc: fix last_call processing

2016-08-31 Thread David Howells
Arnd Bergmann wrote: > I'll follow up with the fixes, both of which are rather > straightforward. Are they both in? [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released David

Re: [PATCH] ipv6: Don't unset flowi6_proto in ipxip6_tnl_xmit()

2016-08-31 Thread David Miller
From: Eli Cooper Date: Fri, 26 Aug 2016 23:52:29 +0800 > @@ -1174,6 +1174,7 @@ ip4ip6_tnl_xmit(struct sk_buff *skb, struct net_device > *dev) > encap_limit = t->parms.encap_limit; > > memcpy(, >fl.u.ip6, sizeof(fl6)); > + fl6.flowi6_proto =

Re: possible circular locking dependency detected (bisected)

2016-08-31 Thread Rainer Weikusat
CAI Qian writes: > Reverted the patch below fixes this problem. > > c845acb324aa85a39650a14e7696982ceea75dc1 > af_unix: Fix splice-bind deadlock Reverting a patch fixing one deadlock in order to avoid another deadlock leaves the 'net situation' unchanged. The idea of the

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread David Miller
From: David Howells Date: Wed, 31 Aug 2016 21:25:46 +0100 > Is there a 1/2 somewhere? I don't see it. It was an NFSv4 patch.

Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

2016-08-31 Thread Rob Herring
On Wed, Aug 31, 2016 at 10:11 AM, Timur Tabi wrote: > Rob Herring wrote: > >>> + internal-phy = <_sgmii>; >> >> >> Can't this use the standard generic phy binding (i.e. 'phys'). It's a >> bit confusing as there's the ethernet phy binding (phy-handle) and the >>

Re: [PATCH] softirq: let ksoftirqd do its job

2016-08-31 Thread Eric Dumazet
On Wed, 2016-08-31 at 21:40 +0200, Jesper Dangaard Brouer wrote: > I can confirm the improvement of approx 900Kpps (no wonder people have > been complaining about DoS against UDP/DNS servers). > > BUT during my extensive testing, of this patch, I also think that we > have not gotten to the

Re: [RESEND PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399

2016-08-31 Thread Doug Anderson
Caesar, On Tue, Aug 30, 2016 at 11:13 PM, Caesar Wang wrote: > This patch adds needed gamc information for rk3399, > also support the gmac pd. > > Signed-off-by: Roger Chen > Signed-off-by: Caesar Wang > --- > >

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread Arnd Bergmann
On Wednesday, August 31, 2016 9:26:21 PM CEST David Howells wrote: > Arnd Bergmann wrote: > > > + } else { > > + sched = 0; > > That should be false, not 0, btw. > Right, sorry about that. Do you want me to resend the fixed version, or do you apply and fix it

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread Arnd Bergmann
On Wednesday, August 31, 2016 9:25:46 PM CEST David Howells wrote: > Is there a 1/2 somewhere? I don't see it. > > David Sorry, mixed up the Cc list. It only went to netdev and lkml and isn't really related. That one was a workaround for a false-positive -Wmaybe-uninitialized warning in NFS,

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread David Howells
Is there a 1/2 somewhere? I don't see it. David

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread David Howells
Arnd Bergmann wrote: > + } else { > + sched = 0; That should be false, not 0, btw. David

Re: [PATCH 0/6] constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
On Wed, 31 Aug 2016, Stephen Hemminger wrote: > On Wed, 31 Aug 2016 09:30:42 +0200 > Julia Lawall wrote: > > > Constify ethtool_ops structures. > > > > --- > > > > drivers/net/ethernet/agere/et131x.c |2 +- > > drivers/net/ethernet/broadcom/bcmsysport.c

Re: [PATCH] softirq: let ksoftirqd do its job

2016-08-31 Thread Jesper Dangaard Brouer
On Wed, 31 Aug 2016 10:42:29 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > A while back, Paolo and Hannes sent an RFC patch adding threaded-able > napi poll loop support : (https://patchwork.ozlabs.org/patch/620657/) > > The problem seems to

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread Arnd Bergmann
On Wednesday, August 31, 2016 6:39:04 PM CEST David Howells wrote: > Arnd Bergmann wrote: > > > gcc -Wmaybe-initialized correctly points out a newly introduced bug > > through which we can end up calling rxrpc_queue_call() for a dead > > connection: > > How do you turn that on

Re: possible circular locking dependency detected (bisected)

2016-08-31 Thread CAI Qian
Reverted the patch below fixes this problem. c845acb324aa85a39650a14e7696982ceea75dc1 af_unix: Fix splice-bind deadlock CAI Qian - Original Message - > From: "CAI Qian" > To: secur...@kernel.org > Cc: "Miklos Szeredi" , "Eric Sandeen" >

Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

2016-08-31 Thread Timur Tabi
Florian Fainelli wrote: if these are truly 64-bits stats, how come you are using a single readl_* to access them? Or is the u64 rx_err_addr just used as temporary storage and aligned to the largest size you need to deal with? "*stats_itr += val;" takes the 32-bit val, zero-extends it to 64

Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

2016-08-31 Thread Florian Fainelli
On 08/31/2016 11:57 AM, Timur Tabi wrote: > Timur Tabi wrote: >> >>> Seems that there are several unused members in the emac_stats struct: >>> +struct emac_stats { >>> ... >>> ... >>> Both rx_bcast_byte_cnt and rx_mcast_byte_cnt are not used anywhere/ + u64 rx_bcast_byte_cnt; /*

Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

2016-08-31 Thread Timur Tabi
Timur Tabi wrote: Seems that there are several unused members in the emac_stats struct: +struct emac_stats { ... ... Both rx_bcast_byte_cnt and rx_mcast_byte_cnt are not used anywhere/ + u64 rx_bcast_byte_cnt; /* broadcast packets byte count (without FCS) */ + u64

Re: [PATCH net-next V4 4/4] net/sched: Introduce act_tunnel_key

2016-08-31 Thread Eric Dumazet
On Wed, Aug 31, 2016 at 5:46 AM, Hadar Hen Zion wrote: > > From: Amir Vadai > > This action could be used before redirecting packets to a shared tunnel > device, or when redirecting packets arriving from a such a device. > > > + > +struct tcf_tunnel_key_params

Re: [PATCH RFC 4/4] xfs: Transmit flow steering

2016-08-31 Thread Chris Mason
On 08/30/2016 08:00 PM, Tom Herbert wrote: XFS maintains a per device flow table that is indexed by the skbuff hash. The XFS table is only consulted when there is no queue saved in a transmit socket for an skbuff. Each entry in the flow table contains a queue index and a queue pointer. The

Re: [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy

2016-08-31 Thread Greg
On Wed, 2016-08-31 at 11:32 -0700, Eric Dumazet wrote: > On Wed, 2016-08-31 at 09:32 -0700, Greg Rose wrote: > > I'm not sure why this hasn't been done before because it seems obvious, > > so maybe there is some reason that memcpy is used instead of > > ether_addr_copy in this code. But let's try

Re: [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy

2016-08-31 Thread Eric Dumazet
On Wed, 2016-08-31 at 09:32 -0700, Greg Rose wrote: > I'm not sure why this hasn't been done before because it seems obvious, > so maybe there is some reason that memcpy is used instead of > ether_addr_copy in this code. But let's try this anyway. > > Change memcpy to ether_addr_copy. ... >

[PATCH net-next V4 10/10] liquidio: CN23XX firmware download

2016-08-31 Thread Raghu Vatsavayi
Add firmware download support for cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next V4 01/10] liquidio: Consolidate common functionality

2016-08-31 Thread Raghu Vatsavayi
Consolidate common functionality of various devices from different files into lio_core.c/octeon_console.c. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V4 09/10] liquidio: MSIX support for CN23XX

2016-08-31 Thread Raghu Vatsavayi
This patch adds support msix interrupt for cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next V4 04/10] liquidio: CN23XX register definitions

2016-08-31 Thread Raghu Vatsavayi
This patch adds register definitions and structures for new device cn23xx. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

[PATCH net-next V4 06/10] liquidio: CN23XX device init and sriov config

2016-08-31 Thread Raghu Vatsavayi
Add support for cn23xx device init and sriov queue config. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next V4 02/10] liquidio: Firmware version management

2016-08-31 Thread Raghu Vatsavayi
This patch contains changes for firmware version management. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next V4 00/10] liquidio CN23XX support

2016-08-31 Thread Raghu Vatsavayi
Dave, Following patchset adds support for new device "CN23XX" in liquidio family of adapters. As adviced by you I have split the previous V3 patch of 18 patches into two halves. This first patchset has first 10 patches, which are tested against net-next. I will post the second half after this

[PATCH net-next V4 03/10] liquidio: Common enable irq function

2016-08-31 Thread Raghu Vatsavayi
Add support of common irq enable functionality for both iq(instruction queue) and oq(output queue). Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V4 08/10] liquidio: CN23XX queue manipulation

2016-08-31 Thread Raghu Vatsavayi
This patch adds support for cn23xx queue manipulation. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

  1   2   3   >