Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On Wed, 7 Sep 2016 20:21:24 -0700 Tom Herbert wrote: > On Wed, Sep 7, 2016 at 7:58 PM, John Fastabend > wrote: > > On 16-09-07 11:22 AM, Jesper Dangaard Brouer wrote: > >> > >> On Wed, 7 Sep 2016 19:57:19 +0300 Saeed Mahameed > >>

Re: [RFC PATCH 1/2] macb: Add 1588 support in Cadence GEM.

Hi, On Tue, Sep 6, 2016 at 9:18 PM, Richard Cochran wrote: > >> +#define GEM_TISUBN 0x01bc /* 1588 Timer Increment Sub-ns */ > > This regsiter does not exist. Looking at > >Zynq-7000 AP SoC Technical Reference Manual >UG585 (v1.10) February 23, 2015

[PATCH net-next] ipv4: accept u8 in IP_TOS ancillary data

From: Eric Dumazet In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as ancillary data") Francesco added IP_TOS values specified as integer. However, kernel sends to userspace (at recvmsg() time) an IP_TOS value in a single byte, when IP_RECVTOS is set on

[PATCH] Bluetooth: fix kzalloc-simple.cocci warnings

net/bluetooth/mgmt.c:905:6-13: WARNING: kzalloc should be used for rp, instead of kmalloc/memset Use kzalloc rather than kmalloc followed by memset with 0 This considers some simple cases that are common and easy to validate Note in particular that there are no ...s in the rule, so all of

Re: [PATCH 2/2 v3] net: smsc911x: request and deassert optional RESET GPIO

From: Linus Walleij Date: Wed, 7 Sep 2016 15:53:42 +0200 > On some systems (such as the Qualcomm APQ8060 Dragonboard) the > RESET signal of the SMSC911x is not pulled up by a resistor (or > the internal pull-up that will pull it up if the pin is not > even connected)

Re: [PATCH 1/2 v3] net: smsc911x: augment device tree bindings

From: Linus Walleij Date: Wed, 7 Sep 2016 15:53:31 +0200 > This adds device tree bindings for: > > - An optional GPIO line for releasing the RESET signal to the > SMSC911x devices > > - An optional PME (power management event) interrupt line that > can be

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On Wed, Sep 7, 2016 at 7:58 PM, John Fastabend wrote: > On 16-09-07 11:22 AM, Jesper Dangaard Brouer wrote: >> >> On Wed, 7 Sep 2016 19:57:19 +0300 Saeed Mahameed >> wrote: >>> On Wed, Sep 7, 2016 at 6:32 PM, Eric Dumazet

RE: [PATCH net-next 0/3] r8152: configuration setting

David Miller [mailto:da...@davemloft.net] > Sent: Thursday, September 08, 2016 8:38 AM [...] > By forcing a certain mode via a Kconfig value, you are basically making it > impossible for distributions to do something reasonable here. The request is always from some manufacturers, not end users.

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On 16-09-07 11:22 AM, Jesper Dangaard Brouer wrote: > > On Wed, 7 Sep 2016 19:57:19 +0300 Saeed Mahameed > wrote: >> On Wed, Sep 7, 2016 at 6:32 PM, Eric Dumazet wrote: >>> On Wed, 2016-09-07 at 18:08 +0300, Saeed Mahameed wrote: On

RE: [PATCH net-next 0/3] r8152: configuration setting

Bjørn Mork [mailto:bj...@mork.no] > Sent: Wednesday, September 07, 2016 9:51 PM [...] > So this adds a lot of code to work around the issues you introduced by > unnecessarily blacklisting the CDC ECM configuration earlier, and still > makes the r8152 driver handle the device even in ECM mode. I

[PATCHv2 iproute2] ip route: check ftell, fseek return value

ftell() may return -1 in error case, which is not handled and therefore pass a negative offset to fseek(). The return code of fseek() is also not checked. Reported-by: Phil Sutter Signed-off-by: Hangbin Liu --- ip/iproute.c | 10 +- 1 file changed, 9

Re: vlan aware bridge doesn't propagate mac changes to vlans on top of it

On 2016/09/08 3:22, Michal Soltys wrote: ... > 4.7.2 > git describe on that commit suggests it's been available since 4.6.x > > What I did in details: > > ip li add name port1b type veth peer name port1e > ip li add br0 type bridge > ip li set dev br0 type bridge vlan_default_pvid 0 > ip li set

[PATCH] net_namespace: fixed net_device reference leak

During namespace cleanup, if ‘dst’ subsystem is holding a reference to the loopback interface in the namespace, it does not get released. This is because in the case where the net_device held by 'dst' is same as the namespace's loopback net_device, current code first does a ’dev_hold’ on the same

Re: Minimum MTU Mess

> This is definitely going to require a few passes... (Working my way > through every driver with an ndo_change_mtu wired up right now to > see just how crazy this might get). It might be something Coccinelle can help you with. Try describing the transformation you want to do, to their mailing

Re: [PATCH net-next v22 3/3] openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes

On Wed, Sep 7, 2016 at 9:56 AM, Eric Garver wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner

Re: [ovs-dev] [PATCH net-next v22 1/3] openvswitch: 802.1ad uapi changes.

On Wed, Sep 7, 2016 at 9:56 AM, Eric Garver wrote: > From: Thomas F Herbert > > openvswitch: Add support for 8021.AD > > Change the description of the VLAN tpid field. > > Signed-off-by: Thomas F Herbert Acked-by: Pravin B

Re: [ovs-dev] [PATCH net-next v22 2/3] vlan: Check for vlan ethernet types for 8021.q or 802.1ad

On Wed, Sep 7, 2016 at 9:56 AM, Eric Garver wrote: > This is to simplify using double tagged vlans. This function allows all > valid vlan ethertypes to be checked in a single function call. > Also replace some instances that check for both ETH_P_8021Q and > ETH_P_8021AD. > > Patch

Re: [PATCH v2 net-next 0/2] qed*: Debug data collection

From: Tomer Tayar Date: Wed, 7 Sep 2016 16:36:23 +0300 > This patch series adds the support of debug data collection in the qed driver, > and the means to extract it in the qede driver via the get_regs operation. ... > Please consider applying this to 'net-next'. Series

Re: [PATCH] kaweth: remove obsolete debugging statements

From: Oliver Neukum Date: Wed, 7 Sep 2016 15:27:09 +0200 > SOme statements in the driver only served to inform > which functions were entered. Ftrace can do that just as good without > needing memory. Remove the statements. > > Signed-off-by: Oliver Neukum

Re: [PATCH] qed: mark symbols static where possible

From: Yuval Mintz Date: Wed, 7 Sep 2016 11:55:34 + >> We get a few warnings when building kernel with W=1: >> drivers/net/ethernet/qlogic/qed/qed_l2.c:112:5: warning: no previous >> prototype for 'qed_sp_vport_start' [-Wmissing-prototypes] >> >> >> In fact,

Re: [PATCH] qed: add missing header dependencies

From: Baoyou Xie Date: Wed, 7 Sep 2016 19:07:00 +0800 > We get 4 warnings when building kernel with W=1: > drivers/net/ethernet/qlogic/qed/qed_selftest.c:6:5: warning: no previous > prototype for 'qed_selftest_memory' [-Wmissing-prototypes] >

Re: [PATCH net-next 0/3] r8152: configuration setting

From: Hayes Wang Date: Wed, 7 Sep 2016 16:12:19 +0800 > Some people prefer to use ECM mode rather than vendor mode. Therefore, I add > CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB > configuration value which they want. The default is to

Re: [PATCH net-next V6 0/4] net/sched: ip tunnel metadata set/release/classify by using TC

From: Hadar Hen Zion Date: Wed, 7 Sep 2016 11:08:02 +0300 > This patchset introduces ip tunnel manipulation support using the TC > subsystem. Please address the feedback given by Eric Dumazet for patch #4, thank you.

Re: [PATCH net-next v2] netlink: don't forget to release a rhashtable_iter structure

From: Andrei Vagin Date: Tue, 6 Sep 2016 21:31:17 -0700 > This bug was detected by kmemleak: > unreferenced object 0x8804269cc3c0 (size 64): > comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) > hex dump (first 32 bytes): > a0 32 cc 2c 04 88 ff ff 00 00 00

Re: [PATCH net-next] MAINTAINERS: Update CPMAC email address

From: Florian Fainelli Date: Tue, 6 Sep 2016 20:22:21 -0700 > Signed-off-by: Florian Fainelli Since MAINTAINERS entry accuracy is very important for bug reporting and patch CC:'ing, I tend to apply these kind of patches always to 'net'. And I have

Re: [PATCH net-next 1/2] tcp: measure rwnd-limited time

From: "Francis Y. Yan" Date: Tue, 6 Sep 2016 18:32:40 -0700 > diff --git a/include/linux/tcp.h b/include/linux/tcp.h > index 7be9b12..f5b588e 100644 > --- a/include/linux/tcp.h > +++ b/include/linux/tcp.h > @@ -176,6 +176,7 @@ struct tcp_sock { >

Re: [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

From: Subash Abhinov Kasiviswanathan Date: Tue, 6 Sep 2016 18:09:31 -0600 > proc_dointvec limits the values to INT_MAX in u32 sysctl entries. > proc_douintvec allows to write upto UINT_MAX. > > Signed-off-by: Subash Abhinov Kasiviswanathan I

Re: [PATCH net-next 0/1] rxrpc: Local abort tracepoint

From: David Howells Date: Wed, 07 Sep 2016 16:25:50 +0100 > > Here's a patch that adds a tracepoint that allows local aborts to be > debugged. This needs to be applied on top of the just-posted call refcount > overhaul patch. > > The patches can be found here also: > >

Re: [PATCH net-next 0/8] rxrpc: Overhaul call refcounting

ewrite > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160907-1 Pulled.

Re: XPS configuration question (on tg3)

On Thu, 2016-09-08 at 01:45 +0200, Michal Soltys wrote: > > Keep in mind that TCP stack can send packets, responding to incoming > > ACK. > > > > So you might check that incoming ACK are handled by the 'right' cpu. > > > > Without RFS, there is no such guarantee. > Did some more testing today,

Re: XPS configuration question (on tg3)

On 2016-09-07 02:19, Eric Dumazet wrote: > On Tue, 2016-09-06 at 23:00 +0200, Michal Soltys wrote: >> On 2016-09-06 22:21, Alexander Duyck wrote: >> > On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote: >> >> Hi, >> >> >> >> I've been testing different configurations and I

Re: Minimum MTU Mess

On Wed, Sep 07, 2016 at 01:35:35PM -0700, Stephen Hemminger wrote: > On Wed, 7 Sep 2016 15:53:56 -0400 > Jarod Wilson wrote: > > > --- a/net/core/dev.c > > +++ b/net/core/dev.c > > @@ -6466,9 +6466,17 @@ int dev_set_mtu(struct net_device *dev, int new_mtu) > > if (new_mtu

Re: Minimum MTU Mess

On Wed, Sep 07, 2016 at 10:31:12PM +0200, Andrew Lunn wrote: > Hi Jarod > > > - /* MTU must be positive.*/ > > - if (new_mtu < 0) > > + if (new_mtu < dev->min_mtu) { > > + netdev_err(dev, "Invalid MTU %d requested, hw min %d\n", > > + new_mtu,

Re: [PATCH 2/2 v3] net: smsc911x: request and deassert optional RESET GPIO

Hi, On 09/07/2016 08:53 AM, Linus Walleij wrote: On some systems (such as the Qualcomm APQ8060 Dragonboard) the RESET signal of the SMSC911x is not pulled up by a resistor (or the internal pull-up that will pull it up if the pin is not even connected) but instead connected to a GPIO line, so

Re: [Patch v6] net: ethernet: xilinx: Enable emaclite for MIPS

From: Zubair Lutfullah Kakakhel Date: Mon, 5 Sep 2016 13:07:54 +0100 > The MIPS based xilfpga platform uses this driver. > Enable it for MIPS > > Signed-off-by: Zubair Lutfullah Kakakhel > > --- > V1 -> V6 are from a series that has

[PATCH net-next] bpf: fix range propagation on direct packet access

LLVM can generate code that tests for direct packet access via skb->data/data_end in a way that currently gets rejected by the verifier, example: [...] 7: (61) r3 = *(u32 *)(r6 +80) 8: (61) r9 = *(u32 *)(r6 +76) 9: (bf) r2 = r9 10: (07) r2 += 54 11: (3d) if r3 >= r2 goto pc+12

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

From: Or Gerlitz Date: Wed, 7 Sep 2016 23:51:56 +0300 > On Wed, Sep 7, 2016 at 11:27 PM, David Miller wrote: >> From: Saeed Mahameed >> Date: Wed, 7 Sep 2016 23:16:13 +0300 >> >>> Hi Dave, Sorry to bother, but i would like

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

On Wed, 2016-09-07 at 15:26 -0700, Stephen Hemminger wrote: > How much does this grow the size of tcp socket structure? This actually shrinks it by 8 bytes, or more on debug kernels where sizeof(spinlock_t) > 4 Before : struct sk_buff_head out_of_order_queue; // At least 24 bytes on 64bit

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

On Wed, 07 Sep 2016 14:49:28 -0700 Eric Dumazet wrote: > From: Yaogong Wang > > Over the years, TCP BDP has increased by several orders of magnitude, > and some people are considering to reach the 2 Gbytes limit. > > Even with current window scale

Re: [iovisor-dev] [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

On Wed, Sep 7, 2016 at 11:55 PM, Or Gerlitz via iovisor-dev wrote: > On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: >> From: Rana Shahout >> >> Add support for the BPF_PROG_TYPE_PHYS_DEV hook in mlx5e driver. >> >>

[PATCH net-next] tcp: use an RB tree for ooo receive queue

From: Yaogong Wang Over the years, TCP BDP has increased by several orders of magnitude, and some people are considering to reach the 2 Gbytes limit. Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 MSS. In presence of packet losses (or reorders),

Re: [PATCH v5 2/6] clk: gxbb: expose MPLL2 clock for use by DT

On 09/06, Martin Blumenstingl wrote: > This exposes the MPLL2 clock as this is one of the input clocks of the > ethernet controller's internal mux. > > Signed-off-by: Martin Blumenstingl > --- Acked-by: Stephen Boyd -- Qualcomm

Re: ptp

On Wed, Sep 07, 2016 at 01:55:19PM -0700, Daniel Walker wrote: > So the code only allows second granularity negative updates, No. > or the seconds > component is the only part which needs to actually be negative ? Yes. See the function, clockadj_step, in linuxptp/clockadj.c for a working user

[PATCH net-next] macsec: set network devtype

The netdevice type structure for macsec was being defined but never used. To set the network device type the macro SET_NETDEV_DEVTYPE must be called. Compile tested only, I don't use macsec. Signed-off-by: Stephen Hemminger --- a/drivers/net/macsec.c 2016-08-25

Re: ptp

On 09/07/2016 01:48 PM, Richard Cochran wrote: On Wed, Sep 07, 2016 at 01:40:59PM -0700, Daniel Walker wrote: There is a test (below) , which prevents negative nanosecond updates. The code below would force a negative update to always return more than NSEC_PER_SEC. It should be using abs()

[PATCH net-next] rtnetlink: remove unused ifla_stats_policy

This structure is defined but never used. Flagged with W=1 Signed-off-by: Stephen Hemminger --- a/net/core/rtnetlink.c 2016-09-07 13:55:17.030107744 -0700 +++ b/net/core/rtnetlink.c 2016-09-07 13:55:45.190236855 -0700 @@ -3669,10 +3669,6 @@ nla_put_failure:

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: > From: Rana Shahout > > Add support for the BPF_PROG_TYPE_PHYS_DEV hook in mlx5e driver. > > When XDP is on we make sure to change channels RQs type to > MLX5_WQ_TYPE_LINKED_LIST rather than "striding

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

On Wed, Sep 7, 2016 at 11:27 PM, David Miller wrote: > From: Saeed Mahameed > Date: Wed, 7 Sep 2016 23:16:13 +0300 > >> Hi Dave, Sorry to bother, but i would like to drop this series for now >> Huy is working to define and come up with a better

Re: ptp

On Wed, Sep 07, 2016 at 01:40:59PM -0700, Daniel Walker wrote: > There is a test (below) , which prevents negative nanosecond updates. The > code below would force a negative update to always return more than > NSEC_PER_SEC. It should be using abs() instead which would return the value > desired.

Re: Minimum MTU Mess

On Wed, 7 Sep 2016 15:53:56 -0400 Jarod Wilson wrote: > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -6466,9 +6466,17 @@ int dev_set_mtu(struct net_device *dev, int new_mtu) > if (new_mtu == dev->mtu) > return 0; > > - /* MTU must be positive.

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

From: Saeed Mahameed Date: Wed, 7 Sep 2016 23:16:13 +0300 > Hi Dave, Sorry to bother, but i would like to drop this series for now > Huy is working to define and come up with a better mechanism to > enable/disable the new DCBX hybrid mode he is adding. I can't "just

Re: Minimum MTU Mess

Hi Jarod > - /* MTU must be positive.*/ > - if (new_mtu < 0) > + if (new_mtu < dev->min_mtu) { > + netdev_err(dev, "Invalid MTU %d requested, hw min %d\n", > +new_mtu, dev->min_mtu); > return -EINVAL; > + } > + > + if

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

On Tue, Sep 6, 2016 at 7:04 PM, Saeed Mahameed wrote: > Hi Dave, > Hi Dave, Sorry to bother, but i would like to drop this series for now Huy is working to define and come up with a better mechanism to enable/disable the new DCBX hybrid mode he is adding. Thanks for

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On Wed, Sep 7, 2016 at 9:19 PM, Eric Dumazet wrote: > On Wed, 2016-09-07 at 19:57 +0300, Saeed Mahameed wrote: > >> Jesper has a similar Idea to make the qdisc think it is under >> pressure, when the device >> TX ring is idle most of the time, i think his idea can come in

Re: [PATCH net] tcp: fastopen: avoid negative sk_forward_alloc

On 09/07/2016 10:34 AM, Eric Dumazet wrote: From: Eric Dumazet When DATA and/or FIN are carried in a SYN/ACK message or SYN message, we append an skb in socket receive queue, but we forget to call sk_forced_mem_schedule(). Effect is that the socket has a negative

Re: Minimum MTU Mess

On Tue, Sep 06, 2016 at 04:55:29PM -0700, David Miller wrote: > From: Jarod Wilson > Date: Fri, 2 Sep 2016 13:07:42 -0400 > > > In any case, the number of "mtu < 68" and "#define FOO_MIN_MTU 68", or > > variations thereof, under drivers/net/ is kind of crazy. > > Agreed, we

Re: [PATCH RFC 04/11] net/mlx5e: Build RX SKB on demand

On Wed, 7 Sep 2016 15:42:25 +0300 Saeed Mahameed wrote: > For non-striding RQ configuration before this patch we had a ring > with pre-allocated SKBs and mapped the SKB->data buffers for > device. > > For robustness and better RX data buffers management, we allocate a >

Re: [PATCH RFC 01/11] net/mlx5e: Single flow order-0 pages for Striding RQ

On Wed, 7 Sep 2016 15:42:22 +0300 Saeed Mahameed wrote: > From: Tariq Toukan > > To improve the memory consumption scheme, we omit the flow that > demands and splits high-order pages in Striding RQ, and stay > with a single Striding RQ flow that uses

[PATCH v2] net: ethernet: renesas: sh_eth: add POST registers for rz

Due to a mistake in the hardware manual, the FWSLC and POST1-4 registers were not documented and left out of the driver for RZ/A making the CAM feature non-operational. Additionally, when the offset values for POST1-4 are left blank, the driver attempts to set them using an offset of 0x which

[PATCH net 3/3] nfp: don't pad frames on receive

There is no need to pad frames to ETH_ZLEN on RX. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Dinan Gunawardena --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4

[PATCH net 1/3] nfp: remove linux/version.h includes

Remove unnecessary version.h includes. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Dinan Gunawardena --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 -

[PATCH net 2/3] nfp: drop support for old firmware ABIs

Be more strict about FW versions. Drop support for old transitional revisions which were never used in production. Dropping support for FW ABI version 0.0.0.0 is particularly useful because 0 could just be uninitialized memory. Signed-off-by: Jakub Kicinski

[PATCH net 0/3] nfp: fixes and trivial cleanup

Hi! First patch drops unnecessary version.h includes. Second one drops support for pre-release versions of FW ABI. Removing FW ABI 0.0 from supported set is particularly good since 0 could just be uninitialized memory. Last but not least I drop unnecessary padding of frames on RX which makes

Re: [PATCH RFC 03/11] net/mlx5e: Implement RX mapped page cache for page recycle

On Wed, 7 Sep 2016 15:42:24 +0300 Saeed Mahameed wrote: > From: Tariq Toukan > > Instead of reallocating and mapping pages for RX data-path, > recycle already used pages in a per ring cache. > > We ran pktgen single-stream benchmarks, with

[PATCH v2] vti: use right inner_mode for inbound inter address family policy checks

In case of inter address family tunneling (IPv6 over vti4 or IPv4 over vti6), the inbound policy checks in vti_rcv_cb() and vti6_rcv_cb() are using the wrong address family. As a result, all inbound inter address family traffic is dropped. Use the xfrm_ip2inner_mode() helper, as done in

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On Wed, 7 Sep 2016 19:57:19 +0300 Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 6:32 PM, Eric Dumazet wrote: > > On Wed, 2016-09-07 at 18:08 +0300, Saeed Mahameed wrote: > >> On Wed, Sep 7, 2016 at 5:41 PM, Eric Dumazet

Re: vlan aware bridge doesn't propagate mac changes to vlans on top of it

On 2016-09-07 02:44, Toshiaki Makita wrote: > On 2016/09/07 6:59, Michal Soltys wrote: >> Consider following scenario: >> >> - create vlan aware bridge (say br0) >> - setup br0's vlans, e.g. >> >> bridge vlan add dev br0 vid 10 self >> >> This will add necessary fdb entries directing

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On Wed, 2016-09-07 at 19:57 +0300, Saeed Mahameed wrote: > Jesper has a similar Idea to make the qdisc think it is under > pressure, when the device > TX ring is idle most of the time, i think his idea can come in handy here. > I am not fully involved in the details, maybe he can elaborate more.

Re: [PATCH v4 6/6] arm64: dts: rockchip: enable the gmac for rk3399 evb board

Am Freitag, 2. September 2016, 01:50:04 CEST schrieb Caesar Wang: > From: Roger Chen > > We add the required and optional properties for evb board. > See the [0] to get the detail information. > > [0]: > Documentation/devicetree/bindings/net/rockchip-dwmac.txt > >

Re: [PATCH v4 5/6] arm64: dts: rockchip: add the gmac needed node for rk3399

Am Freitag, 2. September 2016, 01:50:03 CEST schrieb Caesar Wang: > From: Roger Chen > > The RK3399 GMAC Ethernet Controller provides a complete Ethernet interface > from processor to a Reduced Media Independent Interface (RMII) and Reduced > Gigabit Media Independent

[PATCH v2] tcp: cwnd does not increase in TCP YeAH

Commit 76174004a0f19785a328f40388e87e982bbf69b9 (tcp: do not slow start when cwnd equals ssthresh ) introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual ethernet link kernel 4.2 shows bandwidth ~500KB/s for single TCP connection and kernel 4.3 and above (including 4.8-rc4) shows

Re: [PATCH RFC 04/11] net/mlx5e: Build RX SKB on demand

On Wed, Sep 07, 2016 at 03:42:25PM +0300, Saeed Mahameed wrote: > For non-striding RQ configuration before this patch we had a ring > with pre-allocated SKBs and mapped the SKB->data buffers for > device. > > For robustness and better RX data buffers management, we allocate a > page per packet

Re: [PATCH RFC 01/11] net/mlx5e: Single flow order-0 pages for Striding RQ

On Wed, Sep 07, 2016 at 03:42:22PM +0300, Saeed Mahameed wrote: > From: Tariq Toukan > > To improve the memory consumption scheme, we omit the flow that > demands and splits high-order pages in Striding RQ, and stay > with a single Striding RQ flow that uses order-0 pages. >

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

On Wed, Sep 7, 2016 at 7:54 PM, Tom Herbert wrote: > On Wed, Sep 7, 2016 at 7:48 AM, Saeed Mahameed > wrote: >> On Wed, Sep 7, 2016 at 4:32 PM, Or Gerlitz wrote: >>> On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed

Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

On Wed, 2016-09-07 at 09:27 -0700, Cong Wang wrote: > Fix checkpatch.pl (or whatever tool you prefer). I do not use checkpatch.pl. But I know for sure David cares about this ordering. https://lkml.org/lkml/2016/4/24/91 https://patchwork.ozlabs.org/patch/629958/ So feel free to fix

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On Wed, Sep 7, 2016 at 6:32 PM, Eric Dumazet wrote: > On Wed, 2016-09-07 at 18:08 +0300, Saeed Mahameed wrote: >> On Wed, Sep 7, 2016 at 5:41 PM, Eric Dumazet wrote: >> > On Wed, 2016-09-07 at 15:42 +0300, Saeed Mahameed wrote: >> >> Previously we

[PATCH net-next v22 0/3] openvswitch: add 802.1ad support

This series adds 802.1ad support to openvswitch. It is a continuation of the work originally started by Thomas F Herbert - hence the large rev number. The extra VLAN is implemented by using an additional level of the OVS_KEY_ATTR_ENCAP netlink attribute. In OVS flow speak, this looks like

[PATCH net-next v22 3/3] openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes

Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged vlan. Inner TPID encoded along with ctci in nested attributes. This is based on Thomas

[PATCH net-next v22 1/3] openvswitch: 802.1ad uapi changes.

From: Thomas F Herbert openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8

[PATCH net-next v22 2/3] vlan: Check for vlan ethernet types for 8021.q or 802.1ad

This is to simplify using double tagged vlans. This function allows all valid vlan ethertypes to be checked in a single function call. Also replace some instances that check for both ETH_P_8021Q and ETH_P_8021AD. Patch based on one originally by Thomas F Herbert. Signed-off-by: Thomas F Herbert

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

On Wed, Sep 7, 2016 at 7:48 AM, Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 4:32 PM, Or Gerlitz wrote: >> On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: >> >>> Packet rate performance testing was done with pktgen

Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

On Wed, Sep 7, 2016 at 7:14 AM, Eric Dumazet wrote: > On Wed, 2016-09-07 at 11:08 +0300, Hadar Hen Zion wrote: >> From: Amir Vadai >> > > >> +static int tunnel_key_init(struct net *net, struct nlattr *nla, >> +struct nlattr *est,

Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

On Wed, Sep 7, 2016 at 1:08 AM, Hadar Hen Zion wrote: > +struct tcf_tunnel_key_params { > + struct rcu_head rcu; > + int tcft_action; > + int action; > + struct metadata_dst *tcft_enc_metadata; > +};

Re: [RFC Patch net-next 0/6] net_sched: really switch to RCU for tc actions

On 16-09-01 10:57 PM, Cong Wang wrote: > Currently there are only two tc actions lockless: > gact and mirred. But they are questionable because > we don't have anything to prevent a parallel update > on an existing tc action in hash table while reading > it on fast path, this could be a problem

[PATCH net 4/5] net/mlx5e: Fix global PFC counters replication

From: Gal Pressman Currently when reading global PFC statistics we left the counter iterator out of the equation and we ended up reading the same counter over and over again. Instead of reading the counter at index 0 on every iteration we now read the counter at index (i).

[PATCH net 0/5] Mellanox 100G mlx5 fixes 2016-09-07

Hi Dave, The following series contains bug fixes for the mlx5e driver. from Gal, - Static code checker cleanup (casting overflow) - Fix global PFC counter statistics reading - Fix HW LRO when vlan stripping is off >From Bodong, - Deprecate old autoneg capability

[PATCH net 5/5] net/mlx5e: Fix parsing of vlan packets when updating lro header

From: Gal Pressman Currently vlan tagged packets were not parsed correctly and assumed to be regular IPv4/IPv6 packets. We should check for 802.1Q/802.1ad tags and update the lro header accordingly. This fixes the use case where LRO is on and rxvlan is off (vlan stripping is

[PATCH net 2/5] net/mlx5e: Move an_disable_cap bit to a new position

From: Bodong Wang Previous an_disable_cap position bit31 is deprecated to be use in driver with newer firmware. New firmware will advertise the same capability in bit29. Old capability didn't allow setting more than one protocol for a specific speed when autoneg is off,

[PATCH net 3/5] net/mlx5e: Prevent casting overflow

From: Gal Pressman On 64 bits architectures unsigned long is longer than u32, casting to unsigned long will result in overflow. We need to first allocate an unsigned long variable, then assign the wanted value. Fixes: 665bc53969d7 ('net/mlx5e: Use new ethtool get/set link

[PATCH net 1/5] net/mlx5e: Fix xmit_more counter race issue

From: Tariq Toukan Update the xmit_more counter before notifying the HW, to prevent a possible use-after-free of the skb. Fixes: c8cf78fe100b ("net/mlx5e: Add ethtool counter for TX xmit_more") Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed

[PATCH net-next v3] net: inet: diag: expose the socket mark to privileged processes.

This adds the capability for a process that has CAP_NET_ADMIN on a socket to see the socket mark in socket dumps. Commit a52e95abf772 ("net: diag: allow socket bytecode filters to match socket marks") recently gave privileged processes the ability to filter socket dumps based on mark. This patch

Re: [PATCH net-next] net: inet: diag: expose the socket mark to privileged processes.

On Wed, Sep 7, 2016 at 8:20 PM, kbuild test robot wrote: > [auto build test ERROR on net-next/master] > >net/sctp/sctp_diag.c: In function 'inet_sctp_diag_fill': > >> net/sctp/sctp_diag.c:136:6: error: too few arguments to function > >> 'inet_diag_msg_attrs_fill' > if

[PATCH net-next 2/2] rxrpc: Add tracepoint for working out where aborts happen

Add a tracepoint for working out where local aborts happen. Each tracepoint call is labelled with a 3-letter code so that they can be distinguished - and the DATA sequence number is added too where available. rxrpc_kernel_abort_call() also takes a 3-letter code so that AFS can indicate the

[PATCH net-next 0/2] rxrpc: Local abort tracepoint

Here are two patches. They need to be applied on top of the just-posted call refcount overhaul patch: (1) Fix the return value of some call completion helpers. (2) Add a tracepoint that allows local aborts to be debugged. The patches can be found here also:

[PATCH net-next 1/2] rxrpc: Fix returns of call completion helpers

rxrpc_set_call_completion() returns bool, not int, so the ret variable should match this. rxrpc_call_completed() and __rxrpc_call_completed() should return the value of rxrpc_set_call_completion(). Signed-off-by: David Howells --- net/rxrpc/ar-internal.h | 13

[PATCH net] tcp: fastopen: avoid negative sk_forward_alloc

From: Eric Dumazet When DATA and/or FIN are carried in a SYN/ACK message or SYN message, we append an skb in socket receive queue, but we forget to call sk_forced_mem_schedule(). Effect is that the socket has a negative sk->sk_forward_alloc as long as the message is not

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On Wed, 2016-09-07 at 18:08 +0300, Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 5:41 PM, Eric Dumazet wrote: > > On Wed, 2016-09-07 at 15:42 +0300, Saeed Mahameed wrote: > >> Previously we rang XDP SQ doorbell on every forwarded XDP packet. > >> > >> Here we introduce a

[PATCH net-next 0/1] rxrpc: Local abort tracepoint

Here's a patch that adds a tracepoint that allows local aborts to be debugged. This needs to be applied on top of the just-posted call refcount overhaul patch. The patches can be found here also: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite

[PATCH net-next 4/8] rxrpc: Use call->peer rather than call->conn->params.peer

Use call->peer rather than call->conn->params.peer to avoid the possibility of call->conn being NULL and, whilst we're at it, check it for NULL before we access it. Signed-off-by: David Howells --- net/rxrpc/call_object.c |8 +--- 1 file changed, 5 insertions(+), 3

[PATCH net-next 1/8] rxrpc: Whitespace cleanup

Remove some whitespace. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index bb342f5fe7e4..ad702f9f8d1f 100644 --- a/net/rxrpc/ar-internal.h

  1   2   >