[PATCH v8 8/8] thunderbolt: Adding maintainer entry

2016-09-28 Thread Amir Levy
Add Amir Levy as maintainer for Thunderbolt(TM) ICM driver Signed-off-by: Amir Levy --- MAINTAINERS | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 01bff8e..a4a4614 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10358,7 +10358,13 @@ F:

[PATCH v8 5/8] thunderbolt: Networking transmit and receive

2016-09-28 Thread Amir Levy
This patch provides the handling interface for sending and receiving network packets between the hosts over the full communication route (using the communication path established in the previous patch). The Thunderbolt Network driver interfaces the Linux network stack and the hardware controller c

[PATCH v8 2/8] thunderbolt: Updating the register definitions

2016-09-28 Thread Amir Levy
Adding more Thunderbolt(TM) register definitions and some helper macros. Signed-off-by: Amir Levy --- drivers/thunderbolt/nhi_regs.h | 109 + 1 file changed, 109 insertions(+) diff --git a/drivers/thunderbolt/nhi_regs.h b/drivers/thunderbolt/nhi_regs.h in

[PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-09-28 Thread Amir Levy
This driver enables Thunderbolt Networking on non-Apple platforms running Linux. Thunderbolt Networking provides peer-to-peer connections to transfer files between computers, perform PC migrations, and/or set up small workgroups with shared storage. This is a virtual connection that emulates an E

Re: [PATCH v2 net] net: skbuff: skb_vlan_push: Fix wrong unwinding of skb->data after __vlan_insert_tag call

2016-09-28 Thread Daniel Borkmann
On 09/28/2016 01:56 PM, Shmulik Ladkani wrote: On Wed, 28 Sep 2016 12:30:56 +0200, dan...@iogearbox.net wrote: @@ -4608,6 +4608,8 @@ int skb_vlan_push(struct sk_buff *skb, __be16 vlan_proto, u16 vlan_tci) skb->protocol = skb->vlan_proto; skb->mac_len += VLAN_HLE

Re: [PATCH/RFC 00/12] Programming Open vSwitch (-like) flows into hardware using SwitchDev

2016-09-28 Thread Or Gerlitz
On Wed, Sep 28, 2016 at 3:42 PM, Simon Horman wrote: > A different approach, not implemented by this patch-set, is for user-space > to program flows into hardware by some other means, for example TC, and/or > the (kernel) datapath. Right, and we've submitted that code to the OVS community 24h ag

RE: [PATCH v2] mwifiex: report wakeup for wowlan

2016-09-28 Thread Amitkumar Karwar
> From: Rajat Jain [mailto:raja...@google.com] > Sent: Wednesday, September 28, 2016 7:15 AM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo; linux- > wirel...@vger.kernel.org; netdev@vger.kernel.org > Cc: Rajat Jain; Wei-Ning Huang; Brian Norris; Eric Caruso; > rajatxj...@gmail.com > Subjec

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Eric Dumazet
On Wed, 2016-09-28 at 16:43 +0300, Cyrill Gorcunov wrote: > On Wed, Sep 28, 2016 at 06:29:08AM -0700, Eric Dumazet wrote: > > > > > > Oh, crap :( I've been looking into uapi headers, found that we > > > use anonymous unions (for example include/uapi/linux/bcache.h) > > > and thought it will be saf

Re: [PATCH v5 0/7] Reduce cache miss for snmp_fold_field

2016-09-28 Thread hejianet
On 9/28/16 5:08 PM, David Miller wrote: From: Jia He Date: Wed, 28 Sep 2016 14:22:21 +0800 v5: - order local variables from longest to shortest line I still see many cases where this problem still exists. Please do not resubmit this patch series until you fix all of them. Patch #2: -stat

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 06:29:08AM -0700, Eric Dumazet wrote: > > > > Oh, crap :( I've been looking into uapi headers, found that we > > use anonymous unions (for example include/uapi/linux/bcache.h) > > and thought it will be safe (and my test builds didn't fail). > > Are you happen to know which

Re: [PATCH RFC 3/6] net: phy: Threaded interrupts allow some simplification

2016-09-28 Thread Sergei Shtylyov
On 09/28/2016 03:28 PM, Andrew Lunn wrote: The PHY interrupts are now handled in a threaded interrupt handler, which can sleep. The work queue is no longer needed, phy_change() can be called directly. Additionally, none of the callers of phy_mac_interrupt() did so in interrupt context, so fully

Re: [PATCH nf-next v3 1/2] netfilter: Fix potential null pointer dereference

2016-09-28 Thread Eric Dumazet
On Wed, 2016-09-28 at 09:12 -0400, Aaron Conole wrote: > It's possible for nf_hook_entry_head to return NULL. If two > nf_unregister_net_hook calls happen simultaneously with a single hook > entry in the list, both will enter the nf_hook_mutex critical section. > The first will successfully delete

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-28 Thread Aaron Conole
Liping Zhang writes: > 2016-09-28 11:08 GMT+08:00 Liping Zhang : >> Hi Feng, >> >> 2016-09-28 9:23 GMT+08:00 Feng Gao : >>> Hi Aaraon, >>> >>> On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: It's possible for nf_hook_entry_head to return NULL if two nf_unregister_net_hook calls ha

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Eric Dumazet
On Wed, 2016-09-28 at 16:03 +0300, Cyrill Gorcunov wrote: > On Wed, Sep 28, 2016 at 05:57:12AM -0700, Eric Dumazet wrote: > ... > > Note that some programs could fail to compile with the added union > > anyway. > > > > Some gcc versions are unable to compile a static init with an union > > > > st

[PATCH iproute2-next] tc: fq: display unthrottle latency

2016-09-28 Thread Eric Dumazet
From: Eric Dumazet In linux-4.9 fq packet scheduler got a new stat : unthrottle_latency in nano second units. Gives a good indication of system load or timer implementation latencies. Signed-off-by: Eric Dumazet --- include/linux/pkt_sched.h |2 +- tc/q_fq.c |3 +++ 2

[PATCH nf-next v3 0/2] fixes for recent nf_compact hooks

2016-09-28 Thread Aaron Conole
Two possible error conditions were caught during an extended testing session, and by a build robot. These patches fix the two issues (a missing handler when config is changed, and a potential NULL dereference). Aaron Conole (2): netfilter: Fix potential null pointer dereference nf_set_hooks_h

[PATCH nf-next v3 2/2] nf_set_hooks_head: accommodate different kconfig

2016-09-28 Thread Aaron Conole
When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle the request for registration properly by dropping the hook. This releases the entry during the set. Signed-off-by: Aaron Conole --- net/netfilter/core.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff

[PATCH nf-next v3 1/2] netfilter: Fix potential null pointer dereference

2016-09-28 Thread Aaron Conole
It's possible for nf_hook_entry_head to return NULL. If two nf_unregister_net_hook calls happen simultaneously with a single hook entry in the list, both will enter the nf_hook_mutex critical section. The first will successfully delete the head, but the second will see this NULL pointer and attemp

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 06:02:11AM -0700, Eric Dumazet wrote: > > This is a bit different of course, since struct tc_fq_qd_stats is only > one way : Kernel produces the content and gives it to user space. > > User space should probably not need to initialize such a structure, but > who knows what

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 05:57:12AM -0700, Eric Dumazet wrote: ... > Note that some programs could fail to compile with the added union > anyway. > > Some gcc versions are unable to compile a static init with an union > > struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, }; > > Wh

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Eric Dumazet
On Wed, 2016-09-28 at 05:57 -0700, Eric Dumazet wrote: > Note that some programs could fail to compile with the added union > anyway. > > Some gcc versions are unable to compile a static init with an union > > struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, }; > > When I cooke

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 08:50:31AM -0400, Jamal Hadi Salim wrote: > > struct tcp_info. Yeah I see. As I said naming pads will be safe but to do so we will have to compile on every arch we support and make sure the implicit pad remains here. > Sorry - i didnt mean to drag this for long; but the m

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Eric Dumazet
On Wed, 2016-09-28 at 14:27 +0300, Cyrill Gorcunov wrote: > On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: > > > > > > This structure is uapi, so anyone has complete rights to reference > > > @pad in the userspace programs. Sure it would be more clear to remove > > > the @pad co

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:45 AM, Cyrill Gorcunov wrote: Note: inet_diag somewhere has a netlink structure that has a hole. I pointed it out to Eric D. and he said we cant add it now because it would break ABI. Naming holes generated by a compiler for alignment sake should not break abi (because alignment

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 08:27:24AM -0400, Jamal Hadi Salim wrote: > > > > They must initialize it to zero. > > > > What if in the future actually meant to use 0 for > something?;-> For example in Cyrill's case it means PROTO_IP > Not sure if it useful to interpret or not but it is part of the >

[PATCH/RFC 10/12] openvswitch: make get_dp_rcu() available outside datapath.c

2016-09-28 Thread Simon Horman
Make get_dp_rcu() available outside datapath.c and as a precaution add a check to ensure that rcu_read_lock is held. This is in preparation for calling get_dp_rcu() from other source files which is in turn in preparation for prototyping allowing Open vSwitch to program flows into hardware. Signed

[PATCH/RFC 07/12] rocker: switchdev Add Open vSwitch (-like) flow support to OF-DPA world

2016-09-28 Thread Simon Horman
Prototype programming of Open vSwitch (-like) flows into hardware by implementing SWITCHDEV_OBJ_OVS_FLOW type objects in the rocker_port_obj_{add,del} SDO, a new object type that was added by an earlier patch in that forms part of this prototype. A very limited subset of flows are accepted by this

[PATCH/RFC 06/12] rocker: Add helper to check ports belong to the same rocker switch

2016-09-28 Thread Simon Horman
This will be used by a follow-up patch to add Add Open vSwitch (-like) flow support to the OF-DPA rocker world. Signed-off-by: Simon Horman --- drivers/net/ethernet/rocker/rocker.h | 4 drivers/net/ethernet/rocker/rocker_main.c | 15 +++ 2 files changed, 19 insertions(+)

[PATCH/RFC 08/12] rocker: Support Open vSwitch (-like) flow stats in OF-DPA world

2016-09-28 Thread Simon Horman
Prototype an implementation of the new switchdev_port_obj_get SDO for the SWITCHDEV_OBJ_OVS_FLOW object type. This allows retrieval of statistics for Open vSwitch (-like) flows which have been programmed into hardware. Signed-off-by: Simon Horman --- drivers/net/ethernet/rocker/rocker_hw.h|

[PATCH/RFC 09/12] openvswitch: Add key_attrs to struct sw_flow_match

2016-09-28 Thread Simon Horman
This is in preparation for using key_attrs outside of their current context to allow quickly checking which attributes are set. This is in turn in preparation for prototyping programming Open vSwitch (-like) flows into hardware. Signed-off-by: Simon Horman --- net/openvswitch/flow.h | 1

[PATCH/RFC 12/12] hack: rocker: no ip frag match

2016-09-28 Thread Simon Horman
*** hack; for informational purposes only; not for upstream merge *** Open vSwitch expects to match on the fragmentation state, however, the of-dpa world of rocker does not implement such a field in its flow key. As a work-around ignore it to allow testing (in the absence of fragments). Signed-of

[PATCH/RFC 05/12] rocker: Support Open vSwitch (-like) flow stats

2016-09-28 Thread Simon Horman
Prototype an implementation of the new switchdev_port_obj_get SDO for the SWITCHDEV_OBJ_OVS_FLOW object type. This allows retrieval of statistics for Open vSwitch (-like) flows which have been programmed into hardware. Signed-off-by: Simon Horman --- drivers/net/ethernet/rocker/rocker.h |

[PATCH/RFC 11/12] openvswitch: Support programming of flows into hardware

2016-09-28 Thread Simon Horman
The purpose of this prototype is to attempt to further discussion of how Open vSwitch and similar flows may be programmed into hardware. The approach taken in this prototype here is to always add flows to software, the existing behaviour, and program flows into hardware when possible. As Open vSw

[PATCH/RFC 04/12] rocker: Add Open vSwitch (-like) flow support

2016-09-28 Thread Simon Horman
Prototype programming of Open vSwitch (-like) flows into hardware by implementing SWITCHDEV_OBJ_OVS_FLOW type objects in the rocker_port_obj_{add,del} SDO, a new object type that was added by an earlier patch in that forms part of this prototype. Signed-off-by: Simon Horman --- drivers/net/ether

[PATCH/RFC 03/12] switchdev: Add support for getting port object details

2016-09-28 Thread Simon Horman
The motivation for this prototype is to allow the statistics - number of hits - of Open vSwitch (-line) flows which have been programmed into hardware to be retrieved. This patch takes a generic approach by adding a SDO to allow retrieval of object details. The idea is that an object is passed in

[PATCH/RFC 02/12] switchdev: Add Open vSwitch (-like) flow object support

2016-09-28 Thread Simon Horman
The motivation of this patch is to provide objects for Open vSwitch (-like) flows so that they may be programmed into hardware using switchdev. The structures used here may well prove to be too Open vSwitch centric, but the purpose of the prototype of which this patch is part is to explore if swit

[PATCH/RFC 01/12] sw_flow: make struct sw_flow_key available outside of net/openvswitch/

2016-09-28 Thread Simon Horman
This is preparation for using struct sw_flow_key as a structure to describe Open vSwitch (-like) flows to hardware. This structure was chosen because it has the required fields. It should also be possible to use a different structure if desired. There are a few fields and structures used in struct

[PATCH/RFC 00/12] Programming Open vSwitch (-like) flows into hardware using SwitchDev

2016-09-28 Thread Simon Horman
This series provides a prototype of programming Open vSwitch (-like) flows into hardware using SwitchDev. It is a rework of an approach which I previously posted in 2014. An Netronome has been using in real world products for some time now. Since that time upstream support for offloading flows evo

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:27 AM, Jamal Hadi Salim wrote: On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member

Re: [PATCHv2 net 0/5] sctp: some fixes of prsctp polices

2016-09-28 Thread Xin Long
> >> This patchset is to improve some codes about prsctp polices, and also >> to fix some issues. >> >> v1->v2: >> - wrap the check of chunk->sent_count in a macro: >> sctp_chunk_retransmitted in patch 2/5. > > This series is a mix of bug fixes (patch #1) which should be targetting > 'net' an

Re: [PATCH RFC 3/6] net: phy: Threaded interrupts allow some simplification

2016-09-28 Thread Andrew Lunn
On Wed, Sep 28, 2016 at 03:13:46PM +0300, Sergei Shtylyov wrote: > On 9/28/2016 2:46 PM, Sergei Shtylyov wrote: > > >>The PHY interrupts are now handled in a threaded interrupt handler, > >>which can sleep. The work queue is no longer needed, phy_change() can > >>be called directly. Additionally,

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member of the structure, including 'pad'. So we have t

Re: [PATCH RFC 2/6] net: phy: Use threaded IRQ, to allow IRQ from sleeping devices

2016-09-28 Thread Andrew Lunn
On Wed, Sep 28, 2016 at 02:38:03PM +0300, Sergei Shtylyov wrote: > Hello. > > On 9/28/2016 11:32 AM, Andrew Lunn wrote: > > >The interrupt lines from PHYs maybe connected to I2C bus expanders, or > >from switches on MDIO busses. Such interrupts are sourced from devices > >which sleep, so use thre

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 08:06:51AM -0400, Jamal Hadi Salim wrote: > > I understood well your point;-> Maybe my response was not clear: > _nobody should be fscking fondling pad fields_ setting them or > otherwise. > Maybe let these programs fail. I asked if you knew any such app which > did anythin

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 08:07:01AM -0400, David Miller wrote: ... > > > > I think you miss the point what I'm trying to say: currently end-user > > may have reference to this member (for any reason) and his program > > will compile and run. If we change the name the compilation procedure > > fails

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread David Miller
From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 > On 16-09-28 08:07 AM, David Miller wrote: > >> Right, it would be legal for an existing user to have code that >> explicitly initializes every member of the structure, including 'pad'. >> So we have to keep that member around, at a m

Re: [PATCH RFC 3/6] net: phy: Threaded interrupts allow some simplification

2016-09-28 Thread Sergei Shtylyov
On 9/28/2016 2:46 PM, Sergei Shtylyov wrote: The PHY interrupts are now handled in a threaded interrupt handler, which can sleep. The work queue is no longer needed, phy_change() can be called directly. Additionally, none of the callers of phy_mac_interrupt() did so in interrupt context, so full

Re: [PATCHv2 net 0/5] sctp: some fixes of prsctp polices

2016-09-28 Thread David Miller
From: Xin Long Date: Wed, 28 Sep 2016 18:46:27 +0800 > This patchset is to improve some codes about prsctp polices, and also > to fix some issues. > > v1->v2: > - wrap the check of chunk->sent_count in a macro: > sctp_chunk_retransmitted in patch 2/5. This series is a mix of bug fixes (pa

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member of the structure, including 'pad'. So we have to keep that member around, at a minimum, for their sake. I think we need to start labelling any new pad

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread David Miller
From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:06:51 -0400 > I understood well your point;-> Maybe my response was not clear: > _nobody should be fscking fondling pad fields_ setting them or > otherwise. Especially considering potential future uses of the field, existing users absolutely must

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 07:27 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: This structure is uapi, so anyone has complete rights to reference @pad in the userspace programs. Sure it would be more clear to remove the @pad completely, but if we choose so I thin

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread David Miller
From: Cyrill Gorcunov Date: Wed, 28 Sep 2016 14:27:03 +0300 > On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: >> > >> > This structure is uapi, so anyone has complete rights to reference >> > @pad in the userspace programs. Sure it would be more clear to remove >> > the @pad co

[PATCH net-next 1/2] net: phy: Add Wake-on-LAN driver for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
From: Raju Lakkaraju Wake-on-LAN (WoL) is an Ethernet networking standard that allows a computer/device to be turned on or awakened by a network message. VSC8531 PHY can support this feature configure by driver set function. WoL status get by driver get function. Tested on Beaglebone Black with

[PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
From: Raju Lakkaraju To connect two ports of the same configuration (MDI to MDI or MDI-X to MDI-X) with a 10/100/1000 Mbit/s connection, an Ethernet crossover cable is needed to cross over the transmit and receive signals in the cable, so that they are matched at the connector level. When connect

[PATCH net-next 0/2] net: phy: Add WoL and Auto Mdix drivers for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
From: Raju Lakkaraju This series adds support to the Wake-on-LAN and Auto/Mdi-x set drivers for Microsemi PHYs. Patch 1/2: Wake-on-LAN (WoL) is an Ethernet networking standard that allows a computer/device to be turned on or awakened by a network message. VSC8531 PHY can

Re: [PATCH v2 net] net: skbuff: skb_vlan_push: Fix wrong unwinding of skb->data after __vlan_insert_tag call

2016-09-28 Thread Shmulik Ladkani
Hi, On Wed, 28 Sep 2016 12:30:56 +0200, dan...@iogearbox.net wrote: > > @@ -4608,6 +4608,8 @@ int skb_vlan_push(struct sk_buff *skb, __be16 > > vlan_proto, u16 vlan_tci) > > > > skb->protocol = skb->vlan_proto; > > skb->mac_len += VLAN_HLEN; > > + if (offset) > >

Re: [PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations

2016-09-28 Thread Paul Bolle
On Mon, 2016-09-26 at 17:37 +0200, SF Markus Elfring wrote: > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): >   Use kmalloc_array() in two functions >   Improve another size determination in gigaset_initcs() >   Delete an error message

Re: [PATCH v4 net-next] tcp: Change txhash on every SYN and RTO retransmit

2016-09-28 Thread David Miller
From: Lawrence Brakmo Date: Tue, 27 Sep 2016 19:03:37 -0700 > The current code changes txhash (flowlables) on every retransmitted > SYN/ACK, but only after the 2nd retransmitted SYN and only after > tcp_retries1 RTO retransmits. > > With this patch: > 1) txhash is changed with every SYN retransm

Re: [PATCH] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl

2016-09-28 Thread David Miller
From: David Miller Date: Wed, 28 Sep 2016 07:49:01 -0400 (EDT) > From: Maciej Żenczykowski > Date: Tue, 27 Sep 2016 05:16:45 -0700 > >> From: Maciej Żenczykowski >> >> Signed-off-by: Maciej Żenczykowski > > I was about to ask you to submit this patch alongside an actual > addition of a proc

Re: [PATCH] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl

2016-09-28 Thread David Miller
From: Maciej Żenczykowski Date: Tue, 27 Sep 2016 05:16:45 -0700 > From: Maciej Żenczykowski > > Signed-off-by: Maciej Żenczykowski I was about to ask you to submit this patch alongside an actual addition of a proc_dointvec_minmax user to the table. But upon second checking there is one, indi

Re: [PATCH RFC 3/6] net: phy: Threaded interrupts allow some simplification

2016-09-28 Thread Sergei Shtylyov
Hello. On 9/28/2016 11:32 AM, Andrew Lunn wrote: The PHY interrupts are now handled in a threaded interrupt handler, which can sleep. The work queue is no longer needed, phy_change() can be called directly. Additionally, none of the callers of phy_mac_interrupt() did so in interrupt context, so

Re: [PATCH 3/5] ISDN-Gigaset: Delete an error message for a failed memory allocation

2016-09-28 Thread Paul Bolle
On Tue, 2016-09-27 at 12:57 +0200, Tilman Schmidt wrote: > On Mon, Sep 26, 2016, at 17:42, SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this > > function. > > > > Link: > > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-R > > efactor_Stri

Re: [PATCH RFC 2/6] net: phy: Use threaded IRQ, to allow IRQ from sleeping devices

2016-09-28 Thread Sergei Shtylyov
Hello. On 9/28/2016 11:32 AM, Andrew Lunn wrote: The interrupt lines from PHYs maybe connected to I2C bus expanders, or from switches on MDIO busses. Such interrupts are sourced from devices which sleep, so use threaded interrupts. Threaded interrupts require that the interrupt requester also u

Re: [PATCH 1/5] ISDN-Gigaset: Use kmalloc_array() in two functions

2016-09-28 Thread Paul Bolle
On Mon, 2016-09-26 at 17:38 +0200, SF Markus Elfring wrote: > * Multiplications for the size determination of memory allocations >   indicated that array data structures should be processed. >   Thus use the corresponding function "kmalloc_array". Was the current code incorrect? What makes kmalloc

[PATCH v4 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
From: Raju Lakkaraju Edge-rate: As system and networking speeds increase, a signal's output transition, also know as the edge rate or slew rate (V/ns), takes on greater importance because high-speed signals come with a price. That price is an assortment of interference problems like ringing on th

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: > > > > This structure is uapi, so anyone has complete rights to reference > > @pad in the userspace programs. Sure it would be more clear to remove > > the @pad completely, but if we choose so I think it's better to do > > on top i

Re: [v3,net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
Hi Andrew, Thank you for review and valuable comments. I will implement below suggestion and resend for review. Thanks, Raju. On Tue, Sep 27, 2016 at 11:14:36PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > I just realised the possibly correct binding was starring me in the > face. > > ---

Re: [PATCHv2 net 0/5] sctp: some fixes of prsctp polices

2016-09-28 Thread Marcelo Ricardo Leitner
On Wed, Sep 28, 2016 at 06:46:27PM +0800, Xin Long wrote: > This patchset is to improve some codes about prsctp polices, and also > to fix some issues. > > v1->v2: > - wrap the check of chunk->sent_count in a macro: > sctp_chunk_retransmitted in patch 2/5. > > Xin Long (5): > sctp: move s

Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
Hi Andrew, Thank you for review and valuable comments. Thanks, Raju. On Tue, Sep 27, 2016 at 04:16:33PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > index 000..7ba3855 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > > @@ -0,0 +1,61 @@ > > +* Mi

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:51 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:43:01AM -0400, Jamal Hadi Salim wrote: [..] I dont know how compilation will fail but you may be right with note: that is not how pads have been used in the past. They are supposed to cosmetic annotation which indicates "h

[PATCH net-next v3 2/3] udp: implement memory accounting helpers

2016-09-28 Thread Paolo Abeni
Avoid usage of common memory accounting functions, since the logic is pretty much different. To account for forward allocation, a couple of new atomic_t members are added to udp_sock: 'mem_alloced' and 'can_reclaim'. The current forward allocation is estimated as 'mem_alloced' minus 'sk_rmem_allo

[PATCH net-next v3 3/3] udp: use it's own memory accounting schema

2016-09-28 Thread Paolo Abeni
Completely avoid default sock memory accounting and replace it with udp-specific accounting. The udp code now tracks the memory pressure status, to optimize memory reclaiming. Since the new memory accounting model does not require socket locking, remove the lock on enqueue and free and avoid usin

[PATCH net-next v3 1/3] net/socket: factor out helpers for memory and queue manipulation

2016-09-28 Thread Paolo Abeni
Basic sock operations that udp code can use with its own memory accounting schema. No functional change is introduced in the existing APIs. v1 -> v2: - avoid export sock_rmem_free Signed-off-by: Paolo Abeni --- include/net/sock.h | 5 +++ net/core/datagram.c | 36 net/c

[PATCH net-next v3 0/3] udp: refactor memory accounting

2016-09-28 Thread Paolo Abeni
This patch series refactor the udp memory accounting, replacing the generic implementation with a custom one, in order to remove the needs for locking the socket on the enqueue and dequeue operations. The socket backlog usage is dropped, as well. The first patch factor out core pieces of some queu

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 06:43:01AM -0400, Jamal Hadi Salim wrote: ... > > > > Someone may have set it to zero explicitly on source level, and the > > compilation will fail on new kernel then. So no, keeping the name > > is reasonable. > > > > I dont know how compilation will fail but you may be

[PATCHv2 net 0/5] sctp: some fixes of prsctp polices

2016-09-28 Thread Xin Long
This patchset is to improve some codes about prsctp polices, and also to fix some issues. v1->v2: - wrap the check of chunk->sent_count in a macro: sctp_chunk_retransmitted in patch 2/5. Xin Long (5): sctp: move sent_count to the memory hole in sctp_chunk sctp: reuse sent_count to avoid

[PATCHv2 net 1/5] sctp: move sent_count to the memory hole in sctp_chunk

2016-09-28 Thread Xin Long
Now pahole sctp_chunk, it has 2 memory holes: struct sctp_chunk { struct list_head list; atomic_t refcnt; /* XXX 4 bytes hole, try to pack */ ... long unsigned int prsctp_param; intsent_c

[PATCHv2 net 4/5] sctp: change to check peer prsctp_capable when using prsctp polices

2016-09-28 Thread Xin Long
Now before using prsctp polices, sctp uses asoc->prsctp_enable to check if prsctp is enabled. However asoc->prsctp_enable is set only means local host support prsctp, sctp should not abandon packet if peer host doesn't enable prsctp. So this patch is to use asoc->peer.prsctp_capable to check if pr

[PATCHv2 net 2/5] sctp: reuse sent_count to avoid retransmitted chunks for RTT measurements

2016-09-28 Thread Xin Long
Now sctp uses chunk->resent to record if a chunk is retransmitted, for RTT measurements with retransmitted DATA chunks. chunk->sent_count was introduced to record how many times one chunk has been sent for prsctp RTX policy before. We actually can know if one chunk is retransmitted by checking chun

[PATCHv2 net 3/5] sctp: remove prsctp_param from sctp_chunk

2016-09-28 Thread Xin Long
Now sctp uses chunk->prsctp_param to save the prsctp param for all the prsctp polices, we didn't need to introduce prsctp_param to sctp_chunk. We can just use chunk->sinfo.sinfo_timetolive for RTX and BUF polices, and reuse msg->expires_at for TTL policy, as the prsctp polices and old expires polic

[PATCHv2 net 5/5] sctp: remove the old ttl expires policy

2016-09-28 Thread Xin Long
The prsctp polices include ttl expires policy already, we should remove the old ttl expires codes, and just adjust the new polices' codes to be compatible with the old one for users. This patch is to remove all the old expires codes, and if prsctp polices are not set, it will still set msg's expir

Re: Explaining RX-stages for XDP

2016-09-28 Thread Jesper Dangaard Brouer
On Tue, 27 Sep 2016 19:12:44 -0700 Alexei Starovoitov wrote: > On Tue, Sep 27, 2016 at 11:32:37AM +0200, Jesper Dangaard Brouer wrote: > > > > Let me try in a calm way (not like [1]) to explain how I imagine that > > the XDP processing RX-stage should be implemented. As I've pointed out > > be

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:17 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote: ... @@ -38,7 +38,10 @@ struct inet_diag_req_v2 { __u8sdiag_family; __u8sdiag_protocol; __u8idiag_ext; - __u8pad; + union { +

Re: [PATCH v2 net] net: skbuff: skb_vlan_push: Fix wrong unwinding of skb->data after __vlan_insert_tag call

2016-09-28 Thread Daniel Borkmann
On 09/28/2016 11:08 AM, Shmulik Ladkani wrote: From: Shmulik Ladkani In case 'skb_vlan_push' is called on an skb with a hw-accel vlan tag present, the existing hw-accel tag is inserted into the payload, and the new given tag is placed as new hw-accel tag. In order to insert the existing hw-acc

Re: [PATCH RFC 1/6] net: dsa: mv88e6xxx: Implement interrupt support.

2016-09-28 Thread Andrew Lunn
The cover email got rejected, because i used MV88E6XXX in the subject line, and it did not like the XXX. -- >From 838e38d8079341ffdeb98c3c1bf043627c24cfc2 Mon Sep 17 00:00:00 2001 From: Andrew Lunn Date: Wed, 28 Sep 2016 03:23:0

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote: ... > > @@ -38,7 +38,10 @@ struct inet_diag_req_v2 { > > __u8sdiag_family; > > __u8sdiag_protocol; > > __u8idiag_ext; > > - __u8pad; > > + union { > > + __u8pad; > > + __u8s

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 05:03 AM, Cyrill Gorcunov wrote: In criu we are actively using diag interface to collect sockets present in the system when dumping applications. And while for unix, tcp, udp[lite], packet, netlink it works as expected, the raw sockets do not have. Thus add it. v2: - add missing soc

Re: ath6kl: fix return value in ath6kl_wmi_set_pvb_cmd

2016-09-28 Thread Kalle Valo
Chaehyun Lim wrote: > When building with W=1, we got one warning as belows: > drivers/net/wireless/ath/ath6kl/wmi.c:3509:6: warning: variable ‘ret’ > set but not used [-Wunused-but-set-variable] > > At the end of ath6kl_wmi_set_pvb_cmd, it is returned by 0 regardless of > return value of ath6kl_w

[PATCH v2 net] net: skbuff: skb_vlan_push: Fix wrong unwinding of skb->data after __vlan_insert_tag call

2016-09-28 Thread Shmulik Ladkani
From: Shmulik Ladkani In case 'skb_vlan_push' is called on an skb with a hw-accel vlan tag present, the existing hw-accel tag is inserted into the payload, and the new given tag is placed as new hw-accel tag. In order to insert the existing hw-accel tag, 'skb_vlan_push' adjusts the 'data' pointe

Re: [PATCH v5 0/7] Reduce cache miss for snmp_fold_field

2016-09-28 Thread David Miller
From: Jia He Date: Wed, 28 Sep 2016 14:22:21 +0800 > v5: > - order local variables from longest to shortest line I still see many cases where this problem still exists. Please do not resubmit this patch series until you fix all of them. Patch #2: -static int snmp_seq_show(struct seq_file *seq

Re: [RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace

2016-09-28 Thread Greg KH
On Tue, Sep 27, 2016 at 04:51:49PM -0500, Zach Brown wrote: > Adding led support for phy causes namespace conflicts for some > phy drivers. > > The rtl871 driver declared an enum for representing LED states. The enum > contains constant LED_OFF which conflicted with declaration found in > linux/le

RE: [RFC PATCH net-next 2/2] sfc: report 4-tuple UDP hashing to ethtool, if it's enabled

2016-09-28 Thread David Laight
From: Edward Cree > Sent: 27 September 2016 17:36 ... > + case UDP_V4_FLOW: > + if (efx->rx_hash_udp_4tuple) > + /* fall through */ > + /* else fall further! */ If you invert the above and add a goto...

Re: [PATCH net-next V2] net/sched: pkt_cls: change tc actions order to be as the user sets

2016-09-28 Thread David Miller
From: Hadar Hen Zion Date: Tue, 27 Sep 2016 11:09:51 +0300 > Currently the created tc actions list is reversed against the order > set by the user. > Change the actions list order to be the same as was set by the user. > > This patch doesn't affect dump actions behavior. > For dumping, action->o

[PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
In criu we are actively using diag interface to collect sockets present in the system when dumping applications. And while for unix, tcp, udp[lite], packet, netlink it works as expected, the raw sockets do not have. Thus add it. v2: - add missing sock_put calls in raw_diag_dump_one (by eric.dumaz

Re: [PATCH resend] sh_eth: add R8A7743/5 support

2016-09-28 Thread David Miller
From: Sergei Shtylyov Date: Tue, 27 Sep 2016 01:23:26 +0300 > Add support for the first two members of the Renesas RZ/G family, RZ/G1M/E > (also known as R8A7743/5). The Ether core is the same as in the R-Car gen2 > SoCs, so will share the code/data with them... > > Signed-off-by: Sergei Shtyly

Re: [PATCH v2] mlx5: Add ndo_poll_controller() implementation

2016-09-28 Thread David Miller
From: Calvin Owens Date: Tue, 27 Sep 2016 15:23:27 -0700 > This implements ndo_poll_controller in net_device_ops callback for mlx5, > which is necessary to use netconsole with this driver. > > Cc: Saeed Mahameed > Signed-off-by: Calvin Owens > --- > Changes in v2: > * Only iterate channe

Re: [patch net-next v3 0/6] fib offload: switch to notifier

2016-09-28 Thread David Miller
From: Jiri Pirko Date: Mon, 26 Sep 2016 12:52:28 +0200 > The goal of this patchset is to allow driver to propagate all prefixes > configured in kernel down HW. This is necessary for routing to work > as expected. If we don't do that HW might forward prefixes known to kernel > incorrectly. Take an

Re: [PATCH v2] mlx5: Add ndo_poll_controller() implementation

2016-09-28 Thread Saeed Mahameed
On Wed, Sep 28, 2016 at 1:23 AM, Calvin Owens wrote: > This implements ndo_poll_controller in net_device_ops callback for mlx5, > which is necessary to use netconsole with this driver. > > Cc: Saeed Mahameed > Signed-off-by: Calvin Owens Acked-By: Saeed Mahameed

[PATCH RFC 3/6] net: phy: Threaded interrupts allow some simplification

2016-09-28 Thread Andrew Lunn
The PHY interrupts are now handled in a threaded interrupt handler, which can sleep. The work queue is no longer needed, phy_change() can be called directly. Additionally, none of the callers of phy_mac_interrupt() did so in interrupt context, so fully remove the work queue, and document that phy_m

[PATCH RFC 4/6] net: phy: Use phy name when requesting the interrupt

2016-09-28 Thread Andrew Lunn
Using the fixed name "phy_interrupt" is not very informative in /proc/interrupts when there are a lot of phys, e.g. a device with an Ethernet switch. So when requesting the interrupt, use the name of the phy. Signed-off-by: Andrew Lunn --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertio

<    1   2   3   >