[PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support

2016-11-03 Thread Jon Mason
Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files changed, 17 insertions(+) diff --git

[PATCH v6 3/7] net: phy: broadcom: Add BCM54810 PHY entry

2016-11-03 Thread Jon Mason
The BCM54810 PHY requires some semi-unique configuration, which results in some additional configuration in addition to the standard config. Also, some users of the BCM54810 require the PHY lanes to be swapped. Since there is no way to detect this, add a device tree query to see if it is

[PATCH v6 2/7] Documentation: devicetree: add PHY lane swap binding

2016-11-03 Thread Jon Mason
Add the documentation for PHY lane swapping. This is a boolean entry to notify the phy device drivers that the TX/RX lanes need to be swapped. Signed-off-by: Jon Mason Reviewed-by: Florian Fainelli Reviewed-by: Andrew Lunn ---

[PATCH v6 1/7] net: phy: broadcom: add bcm54xx_auxctl_read

2016-11-03 Thread Jon Mason
Add a helper function to read the AUXCTL register for the BCM54xx. This mirrors the bcm54xx_auxctl_write function already present in the code. Signed-off-by: Jon Mason Reviewed-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 10 ++

[PATCH v6 0/7] add NS2 support to bgmac

2016-11-03 Thread Jon Mason
Changes in v6: * Use a common bgmac_phy_connect_direct (per Rafal Milecki) * Rebased on latest net-next * Added Reviewed-by to the relevant patches Changes in v5: * Change a pr_err to netdev_err (per Scott Branden) * Reword the lane swap binding documentation (per Andrew Lunn) Changes in v4:

[PATCH v6 6/7] net: ethernet: bgmac: add NS2 support

2016-11-03 Thread Jon Mason
Add support for the variant of amac hardware present in the Broadcom Northstar2 based SoCs. Northstar2 requires an additional register to be configured with the port speed/duplexity (NICPM). This can be added to the link callback to hide it from the instances that do not use this. Also, clearing

[PATCH v6 4/7] Documentation: devicetree: net: add NS2 bindings to amac

2016-11-03 Thread Jon Mason
Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason Reviewed-by: Florian Fainelli --- Documentation/devicetree/bindings/net/brcm,amac.txt | 16

[PATCH v6 5/7] net: ethernet: bgmac: device tree phy enablement

2016-11-03 Thread Jon Mason
Change the bgmac driver to allow for phy's defined by the device tree Signed-off-by: Jon Mason --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 22 +++ drivers/net/ethernet/broadcom/bgmac-platform.c | 22 ++-

Re: [mm PATCH v2 18/26] arch/powerpc: Add option to skip DMA sync as a part of mapping

2016-11-03 Thread Michael Ellerman
Alexander Duyck writes: > This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to > avoid invoking cache line invalidation if the driver will just handle it > via a sync_for_cpu or sync_for_device call. > > Cc: Benjamin Herrenschmidt

[PATCH net 1/1] driver: macvlan: Destroy new macvlan port if macvlan_common_newlink failed.

2016-11-03 Thread fgao
From: Gao Feng When there is no existing macvlan port in lowdev, one new macvlan port would be created. But it doesn't be destoried when something failed later. It casues some memleak. Now add one flag to indicate if new macvlan port is created. Signed-off-by: Gao Feng

[PATCH net-next v2 06/11] net: dsa: mv88e6xxx: add port 802.1Q mode setter

2016-11-03 Thread Vivien Didelot
Add port functions to set the port 802.1Q mode. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 33 ++--- drivers/net/dsa/mv88e6xxx/port.c | 32

[PATCH net-next v2 07/11] net: dsa: mv88e6xxx: add port link setter

2016-11-03 Thread Vivien Didelot
Most of the chips will have a port register control bits to force the port's link up, down, or let normal link detection occurs. Implement such operation to use it later when setting duplex, etc. Signed-off-by: Vivien Didelot ---

[PATCH net-next v2 05/11] net: dsa: mv88e6xxx: add port PVID accessors

2016-11-03 Thread Vivien Didelot
Add port functions to access the ports default VID. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 51 drivers/net/dsa/mv88e6xxx/port.c | 38 ++

[PATCH net-next v2 03/11] net: dsa: mv88e6xxx: add port vlan map setter

2016-11-03 Thread Vivien Didelot
Add a port function to access the Port Based VLAN Map register. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 14 ++ drivers/net/dsa/mv88e6xxx/port.c | 25 + drivers/net/dsa/mv88e6xxx/port.h | 2 ++

[PATCH net-next v2 09/11] net: dsa: mv88e6xxx: add port's RGMII delay setter

2016-11-03 Thread Vivien Didelot
Some chips such as 88E6352 and 88E6390 can be programmed to add delays to RXCLK for IND inputs or to GTXCLK for OUTD outputs when port is in RGMII mode. Add a port function to program such delays according to the provided PHY interface mode. Signed-off-by: Vivien Didelot

[PATCH net-next v2 00/11] net: dsa: mv88e6xxx: refine port operations

2016-11-03 Thread Vivien Didelot
The Marvell chips have one internal SMI device per port, containing a set of registers used to configure a port's link, STP state, default VLAN or addresses database, etc. This patchset creates port files to implement the port operations as described in datasheets, and extend the chip ops

[PATCH net-next v2 04/11] net: dsa: mv88e6xxx: add port FID accessors

2016-11-03 Thread Vivien Didelot
Add functions to port files to access the ports default FID. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 77 +++- drivers/net/dsa/mv88e6xxx/port.c | 67 ++

[PATCH net-next v2 02/11] net: dsa: mv88e6xxx: add port state setter

2016-11-03 Thread Vivien Didelot
Add the port STP state setter to the port files. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 49 drivers/net/dsa/mv88e6xxx/port.c | 31 +

[PATCH net-next v2 01/11] net: dsa: mv88e6xxx: add port files

2016-11-03 Thread Vivien Didelot
The Marvell switches contains one internal SMI device per port, called "Port Registers". Depending on the model, the addresses of these devices start from 0x0, 0x8 or 0x10. Start moving Port Registers specific code to their own files. Signed-off-by: Vivien Didelot

[PATCH net-next v2 11/11] net: dsa: mv88e6xxx: setup port's MAC

2016-11-03 Thread Vivien Didelot
Now that we have setters to configure the port's MAC, use them to refactor the port setup and adjust_link code. Note that port's MAC speed, duplex or RGMII delay must not be changed unless the port's link is forced down. So wrap all that in a mv88e6xxx_port_setup_mac function. Signed-off-by:

[PATCH net-next v2 10/11] net: dsa: mv88e6xxx: add port's MAC speed setter

2016-11-03 Thread Vivien Didelot
While the two bits for link, duplex or RGMII delays are used the same way on chips supporting the said feature, the two bits for speed have different meaning for most of the chips out there. Speed value is stored in bits 1:0, 0x3 means unforce (normal detection). Some chips reuse values for

Re: [PATCH net-next v1 18/21] net: phy: expose phy_aneg_done API for use by drivers

2016-11-03 Thread kbuild test robot
Hi Tom, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Lendacky/amd-xgbe-AMD-XGBE-driver-updates-2016-11-01/20161103-222344 config: sparc-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce

Re: bpf: kernel BUG in htab_elem_free

2016-11-03 Thread Dmitry Vyukov
On Thu, Nov 3, 2016 at 10:36 AM, Daniel Borkmann wrote: > On 11/03/2016 03:15 PM, Dmitry Vyukov wrote: >> >> On Wed, Nov 2, 2016 at 11:14 PM, Dmitry Vyukov wrote: >>> >>> Here we go. >>> >>> The following program triggers kernel BUG in htab_elem_free.

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2016 at 04:29:22PM -0700, John Fastabend wrote: > [...] > > >>> - when XDP is attached disable all LRO using > >>> VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET > >>> (not used by driver so far, designed to allow dynamic LRO control with > >>>ethtool) > >> > >> I see there is a UAPI

[Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr

2016-11-03 Thread Cong Wang
family.maxattr is the max index for policy[], the size of ops[] is determined with ARRAY_SIZE(). Reported-by: Andrey Konovalov Tested-by: Andrey Konovalov Cc: Pablo Neira Ayuso Signed-off-by: Cong Wang

[PATCH net] bpf: fix map not being uncharged during map creation failure

2016-11-03 Thread Daniel Borkmann
In map_create(), we first find and create the map, then once that suceeded, we charge it to the user's RLIMIT_MEMLOCK, and then fetch a new anon fd through anon_inode_getfd(). The problem is, once the latter fails f.e. due to RLIMIT_NOFILE limit, then we only destruct the map via

[PATCH net 6/6] net/mlx5: Fix invalid pointer reference when prof_sel parameter is invalid

2016-11-03 Thread Saeed Mahameed
From: Huy Nguyen When prof_sel is invalid, mlx5_core_warn is called but the mlx5_core_dev is not initialized yet. Solution is moving the prof_sel code after dev->pdev assignment Fixes: 2974ab6e8bd8 ('net/mlx5: Improve driver log messages') Signed-off-by: Huy Nguyen

[PATCH net 3/6] net/mlx5e: Disallow changing name-space for VF representors

2016-11-03 Thread Saeed Mahameed
From: Or Gerlitz VF reps should be altogether on the same NS as they were created. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- 1 file changed, 1

[PATCH net 2/6] net/mlx5e: Re-arrange XDP SQ/CQ creation

2016-11-03 Thread Saeed Mahameed
In mlx5e_open_channel CQs must be created before napi is enabled. Here we move the XDP CQ creation to satisfy that fact. mlx5e_close_channel is already working according to the right order. Fixes: b5503b994ed5 ("net/mlx5e: XDP TX forwarding support") Signed-off-by: Saeed Mahameed

[PATCH net 1/6] net/mlx5e: Fix XDP error path of mlx5e_open_channel()

2016-11-03 Thread Saeed Mahameed
In case of mlx5e_open_rq fails the error handling will jump to label err_close_xdp_sq and will try to close the xdp_sq unconditionally. xdp_sq is valid only in case of XDP use cases, i.e priv->xdp_prog is not null. To fix this in this patch we test xdp_sq validity prior to closing it. In

[PATCH net 5/6] net/mlx5: E-Switch, Set the actions for offloaded rules properly

2016-11-03 Thread Saeed Mahameed
From: Or Gerlitz As for the current generation of the mlx5 HW (CX4/CX4-Lx) per flow vlan push/pop actions are emulated, we must not program them to the firmware. Fixes: f5f82476090f ('net/mlx5: E-Switch, Support VLAN actions in the offloads mode') Signed-off-by: Or

[PATCH net 0/6] Mellanox 100G mlx5 fixes 2016-11-04

2016-11-03 Thread Saeed Mahameed
Hi Dave, This series contains six hot fixes of the mlx5 core and mlx5e driver. Huy fixed an invalid pointer dereference on initialization flow for when the selected mlx5 load profile is out of range. Or provided three eswitch offloads related fixes - Prevent changing NS of a VF representor.

[PATCH net 4/6] net/mlx5e: Handle matching on vlan priority for offloaded TC rules

2016-11-03 Thread Saeed Mahameed
From: Or Gerlitz We ignored the vlan priority in offloaded TC rules matching part, fix that. Fixes: 095b6cfd69ce ('net/mlx5e: Add TC vlan match parsing') Signed-off-by: Or Gerlitz Reported-by: Paul Blakey Signed-off-by: Saeed

Re: net/netlink: another global-out-of-bounds in genl_family_rcv_msg/validate_nla

2016-11-03 Thread Andrey Konovalov
On Fri, Nov 4, 2016 at 12:22 AM, Cong Wang wrote: > On Thu, Nov 3, 2016 at 4:04 PM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while running the syzkaller fuzzer: >> >> BUG: KASAN: global-out-of-bounds in

[PATCH] r8169: Module parameter for opt-in of ASPM

2016-11-03 Thread Kast Bernd
This patch adds a module parameter in order to activate ASPM. By that the CPU can enter deep sleep modes (PC6) and power consumption can be reduced (for example from 13W to 8W on my notebook with a Haswell CPU). Basically, it reapplies d64ec841517a25f6d468bde9f67e5b4cffdc67c7, which was reverted

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-11-03 Thread John Fastabend
[...] >>> - when XDP is attached disable all LRO using >>> VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET >>> (not used by driver so far, designed to allow dynamic LRO control with >>>ethtool) >> >> I see there is a UAPI bit for this but I guess we also need to add >> support to vhost as well? Seems

[PATCH net-next] netfilter: Update nf_send_reset6 to consider L3 domain

2016-11-03 Thread David Ahern
nf_send_reset6 is not considering the L3 domain and lookups are sent to the wrong table. For example consider the following output rule: ip6tables -A OUTPUT -p tcp --dport 12345 -j REJECT --reject-with tcp-reset using perf to analyze lookups via the fib6_table_lookup tracepoint shows: swapper

Re: net/netlink: another global-out-of-bounds in genl_family_rcv_msg/validate_nla

2016-11-03 Thread Cong Wang
On Thu, Nov 3, 2016 at 4:04 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while running the syzkaller fuzzer: > > BUG: KASAN: global-out-of-bounds in validate_nla+0x49b/0x4e0 at addr > 84452de0 > Read of size 2 by task syz-executor/19055

[PATCH] net: icmp6_send should use dst dev to determine L3 domain

2016-11-03 Thread David Ahern
icmp6_send is called in response to some event. The skb may not have the device set (skb->dev is NULL), but it is expected to have a dst set. Update icmp6_send to use the dst on the skb to determine L3 domain. Fixes: ca254490c8dfd ("net: Add VRF support to IPv6 stack") Signed-off-by: David Ahern

Re: [PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-03 Thread Hannes Frederic Sowa
[also cc'ed Andy, albeit this doesn't seem to solve his initial problem, right? ] On 03.11.2016 23:24, Soheil Hassas Yeganeh wrote: > From: Soheil Hassas Yeganeh > > Do not set sk_err when dequeuing errors from the error

net/netlink: another global-out-of-bounds in genl_family_rcv_msg/validate_nla

2016-11-03 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: BUG: KASAN: global-out-of-bounds in validate_nla+0x49b/0x4e0 at addr 84452de0 Read of size 2 by task syz-executor/19055 Address belongs to variable ip_vs_cmd_policy+0x20/0x40 CPU: 1 PID: 19055 Comm: syz-executor

[PATCH net] bpf: fix htab map destruction when extra reserve is in use

2016-11-03 Thread Daniel Borkmann
Commit a6ed3ea65d98 ("bpf: restore behavior of bpf_map_update_elem") added an extra per-cpu reserve to the hash table map to restore old behaviour from pre prealloc times. When non-prealloc is in use for a map, then problem is that once a hash table extra element has been linked into the

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-11-03 Thread Michael S. Tsirkin
On Wed, Nov 02, 2016 at 11:44:33PM -0700, John Fastabend wrote: > On 16-11-02 09:11 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 02, 2016 at 06:28:34PM -0700, Shrijeet Mukherjee wrote: > >>> -Original Message- > >>> From: Jesper Dangaard Brouer [mailto:bro...@redhat.com] > >>> Sent:

Re: [PATCH for-next V2 00/15][PULL request] Mellanox mlx5 core driver updates 2016-10-25

2016-11-03 Thread Doug Ledford
On 10/30/16 3:35 PM, David Miller wrote: > From: Saeed Mahameed > Date: Sun, 30 Oct 2016 23:21:53 +0200 > >> This series contains some updates and fixes of mlx5 core and >> IB drivers with the addition of two features that demand >> new low level commands and infrastructure

[PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-03 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Do not set sk_err when dequeuing errors from the error queue. Doing so results in: a) Bugs: By overwriting existing sk_err values, it possibly hides legitimate errors. It is also incorrect when local errors are queued with ip_local_error. That

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-11-03 Thread John Fastabend
On 16-11-02 11:44 PM, John Fastabend wrote: > On 16-11-02 09:11 PM, Michael S. Tsirkin wrote: >> On Wed, Nov 02, 2016 at 06:28:34PM -0700, Shrijeet Mukherjee wrote: -Original Message- From: Jesper Dangaard Brouer [mailto:bro...@redhat.com] Sent: Wednesday, November 2, 2016

[PATCH net-next 2/2] sfc: report 4-tuple UDP hashing to ethtool, if it's enabled

2016-11-03 Thread Edward Cree
Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 6 -- drivers/net/ethernet/sfc/ethtool.c| 12 drivers/net/ethernet/sfc/net_driver.h | 2 ++ 3 files changed, 14 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 1/2] sfc: enable 4-tuple RSS hashing for UDP

2016-11-03 Thread Edward Cree
This improves UDP spreading, and also slightly improves GRO performance of encapsulated TCP on 7000 series NICs. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 82 + 1 file changed, 82 insertions(+) diff --git

[PATCH net-next 0/2] sfc: enable 4-tuple UDP RSS hashing

2016-11-03 Thread Edward Cree
EF10 based NICs have configurable RSS hash fields, and can be made to take the ports into the hash on UDP (they already do so for TCP). This patch series enables this, in order to improve spreading of UDP traffic. Edward Cree (2): sfc: enable 4-tuple RSS hashing for UDP sfc: report 4-tuple

[PATCH net-next V4 4/9] liquidio CN23XX: mailbox interrupt processing

2016-11-03 Thread Raghu Vatsavayi
Adds support for mailbox interrupt processing of various commands. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V4 6/9] liquidio CN23XX: device states

2016-11-03 Thread Raghu Vatsavayi
Cleaned up resource leaks during destroy resources by introducing more device states. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla

[PATCH net-next V4 9/9] liquidio CN23XX: fix for new check patch errors

2016-11-03 Thread Raghu Vatsavayi
New checkpatch script shows some errors with pre-existing driver. This patch provides fix for those errors. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla

[PATCH net-next V4 2/9] liquidio CN23XX: sysfs VF config support

2016-11-03 Thread Raghu Vatsavayi
Adds sysfs based support for enabling or disabling VFs. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V4 8/9] liquidio CN23XX: copyrights changes and alignment

2016-11-03 Thread Raghu Vatsavayi
Updated copyrights comments and also changed some other comments alignments. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by:

[PATCH net-next V4 7/9] liquidio CN23XX: code cleanup

2016-11-03 Thread Raghu Vatsavayi
Cleaned up unnecessary comments and added some minor macros. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V4 5/9] liquidio CN23XX: VF related operations

2016-11-03 Thread Raghu Vatsavayi
Adds support for VF related operations like mac address vlan and link changes. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by:

[PATCH net-next V4 3/9] liquidio CN23XX: Mailbox support

2016-11-03 Thread Raghu Vatsavayi
Adds support for mailbox communication between PF and VF. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V4 1/9] liquidio CN23XX: HW config for VF support

2016-11-03 Thread Raghu Vatsavayi
Adds support for configuring HW for creating VFs. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V4 0/9] liquidio CN23XX VF support

2016-11-03 Thread Raghu Vatsavayi
Dave, Following is the V4 patch series for adding VF support on CN23XX devices. This version addressed: 1) Your concern for ordering of local variable declarations from longest to shortest line. 2) Removed module parameters max_vfs, num_queues_per_{p,v}f. 3) Minor changes for fixing new

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-03 Thread Hannes Frederic Sowa
On 03.11.2016 22:05, Lance Richardson wrote: >> From: "Shmulik Ladkani" >> To: "Lance Richardson" , f...@strlen.de, >> han...@stressinduktion.org >> Cc: netdev@vger.kernel.org, jtl...@redhat.com >> Sent: Thursday, November 3, 2016 4:27:51 PM >>

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-03 Thread Lance Richardson
> From: "Shmulik Ladkani" > To: "Lance Richardson" , f...@strlen.de, > han...@stressinduktion.org > Cc: netdev@vger.kernel.org, jtl...@redhat.com > Sent: Thursday, November 3, 2016 4:27:51 PM > Subject: Re: [PATCH net v3] ipv4: allow local

Re: Time to revisit LISP?

2016-11-03 Thread David Miller
From: Tom Herbert Date: Thu, 3 Nov 2016 13:57:59 -0700 > On Thu, Nov 3, 2016 at 1:37 PM, David Miller wrote: >> Userspace resolution of paths in response to data path signalling >> simply does not scale and is fundamentally an extremely poor design >>

Re: [PATCH net] ipv6: dccp: add missing bind_conflict to dccp_ipv6_mapped

2016-11-03 Thread David Miller
From: Eric Dumazet Date: Thu, 03 Nov 2016 08:59:46 -0700 > From: Eric Dumazet > > While fuzzing kernel with syzkaller, Andrey reported a nasty crash > in inet6_bind() caused by DCCP lacking a required method. > > Fixes: ab1e0a13d7029 ("[SOCK]

Re: Time to revisit LISP?

2016-11-03 Thread Tom Herbert
On Thu, Nov 3, 2016 at 1:37 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 3 Nov 2016 12:22:52 -0700 > >> For instance, one of the his questions is: >> >> "What is to keep one from having to service a full Map-Request --> >> Map-Reply cycle

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-03 Thread David Miller
From: Shmulik Ladkani Date: Thu, 3 Nov 2016 22:40:52 +0200 > On Thu, 03 Nov 2016 16:12:44 -0400 (EDT) David Miller > wrote: >> Applied and queued up for -stable. > > Dave, my response lagged your "Applied" by few minutes ;) > > This seems to

Re: [net-next PATCH 2/3] net/qdisc: IFF_NO_QUEUE drivers should use consistent TX queue len

2016-11-03 Thread Krister Johansen
On Thu, Nov 03, 2016 at 02:56:06PM +0100, Jesper Dangaard Brouer wrote: > The flag IFF_NO_QUEUE marks virtual device drivers that doesn't need a > default qdisc attached, given they will be backed by physical device, > that already have a qdisc attached for pushback. > > It is still supported to

Re: [Patch net] genetlink: fix a memory leak on error path

2016-11-03 Thread David Miller
From: Cong Wang Date: Thu, 3 Nov 2016 09:42:35 -0700 > In __genl_register_family(), when genl_validate_assign_mc_groups() > fails, we forget to free the memory we possibly allocate for > family->attrbuf. > > Note, some callers call genl_unregister_family() to clean up

Re: [RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements)

2016-11-03 Thread Catalin Marinas
On Wed, Nov 02, 2016 at 11:47:55PM +, Jakub Kicinski wrote: > I realized that kmemleak is not scanning the __ro_after_init section... > Following patch solves the false positives but I wonder if it's the > right/acceptable solution. Thanks for putting this together. I actually hit a similar

Re: Time to revisit LISP?

2016-11-03 Thread David Miller
From: Tom Herbert Date: Thu, 3 Nov 2016 12:22:52 -0700 > For instance, one of the his questions is: > > "What is to keep one from having to service a full Map-Request --> > Map-Reply cycle for every packet received?" > > This can be solved by judicious rate limiting, for

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-03 Thread Shmulik Ladkani
On Thu, 03 Nov 2016 16:12:44 -0400 (EDT) David Miller wrote: > Applied and queued up for -stable. Dave, my response lagged your "Applied" by few minutes ;) This seems to deserve some more thought to make sure nothing got broken, as expressed last in

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-03 Thread Shmulik Ladkani
Hi Hannes, Lance, On Wed, 2 Nov 2016 16:36:17 -0400 Lance Richardson wrote: > > - if (skb_iif && !(df & htons(IP_DF))) { > - /* Arrived from an ingress interface, got encapsulated, with > - * fragmentation of encapulating frames allowed. > -

Re: [patch net-next] mlxsw: pci: Fix the FW ready mask length

2016-11-03 Thread David Miller
From: Jiri Pirko Date: Thu, 3 Nov 2016 09:41:55 +0100 > From: Elad Raz > > The system-status register is actually 16-bit wide and not 8 bit-wide. > > Fixes: 233fa44bd67ae ("mlxsw: pci: Implement reset done check") > Signed-off-by: Elad Raz

Re: [PATCH net-next] net/sched: cls_flower: Support matching on SCTP ports

2016-11-03 Thread David Miller
From: Simon Horman Date: Thu, 3 Nov 2016 13:24:21 +0100 > Support matching on SCTP ports in the same way that matching > on TCP and UDP ports is already supported. > > Example usage: > > tc qdisc add dev eth0 ingress > > tc filter add dev eth0 protocol ip parent

Re: [PATCH net] ehea: fix operation state report

2016-11-03 Thread David Miller
From: "Guilherme G. Piccoli" Date: Thu, 3 Nov 2016 08:16:20 -0200 > Currently the ehea driver is missing a call to netif_carrier_off() > before the interface bring-up; this is necessary in order to > initialize the __LINK_STATE_NOCARRIER bit in the net_device state

Re: [PATCH net] netlink: netlink_diag_dump() runs without locks

2016-11-03 Thread David Miller
From: Eric Dumazet Date: Wed, 02 Nov 2016 20:21:20 -0700 > From: Eric Dumazet > > A recent commit removed locking from netlink_diag_dump() but forgot > one error case. ... > Fixes: ad202074320c ("netlink: Use rhashtable walk interface in diag

Re: [PATCH net] ipv6: dccp: fix out of bound access in dccp_v6_err()

2016-11-03 Thread David Miller
From: Eric Dumazet Date: Wed, 02 Nov 2016 20:30:48 -0700 > From: Eric Dumazet > > dccp_v6_err() does not use pskb_may_pull() and might access garbage. > > We only need 4 bytes at the beginning of the DCCP header, like TCP, > so the 8 bytes pulled

Re: [PATCH net] dccp: fix out of bound access in dccp_v4_err()

2016-11-03 Thread David Miller
From: Eric Dumazet Date: Wed, 02 Nov 2016 19:00:40 -0700 > From: Eric Dumazet > > dccp_v4_err() does not use pskb_may_pull() and might access garbage. > > We only need 4 bytes at the beginning of the DCCP header, like TCP, > so the 8 bytes pulled

Re: [PATCH net] dccp: do not release listeners too soon

2016-11-03 Thread David Miller
From: Eric Dumazet Date: Wed, 02 Nov 2016 17:14:41 -0700 > From: Eric Dumazet > > Andrey Konovalov reported following error while fuzzing with syzkaller : ... > It turns out DCCP calls __sk_receive_skb(), and this broke when > lookups no longer

Re: [PATCH net] dccp: do not send reset to already closed sockets

2016-11-03 Thread David Miller
From: Eric Dumazet Date: Wed, 02 Nov 2016 18:04:24 -0700 > From: Eric Dumazet > > Andrey reported following warning while fuzzing with syzkaller > > WARNING: CPU: 1 PID: 21072 at net/dccp/proto.c:83 dccp_set_state+0x229/0x290 > Kernel panic - not

Re: [PATCH net] tcp: fix return value for partial writes

2016-11-03 Thread David Miller
From: Eric Dumazet Date: Wed, 02 Nov 2016 14:41:50 -0700 > From: Eric Dumazet > > After my commit, tcp_sendmsg() might restart its loop after > processing socket backlog. > > If sk_err is set, we blindly return an error, even though we > copied

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-03 Thread David Miller
From: Lance Richardson Date: Wed, 2 Nov 2016 16:36:17 -0400 > Some configurations (e.g. geneve interface with default > MTU of 1500 over an ethernet interface with 1500 MTU) result > in the transmission of packets that exceed the configured MTU. > While this should be

Re: [PATCH net-next] net: remove unused argument in checksum unnecessary conversion

2016-11-03 Thread David Miller
From: Willem de Bruijn Date: Wed, 2 Nov 2016 16:14:11 -0400 > From: Willem de Bruijn > > The check argument is never used. This code has not changed since > the original introduction in d96535a17dbb ("net: Infrastructure for > checksum

Re: [PATCH] net: tcp: check skb is non-NULL for exact match on lookups

2016-11-03 Thread David Miller
From: David Ahern Date: Wed, 2 Nov 2016 12:08:25 -0700 > Andrey reported the following error report while running the syzkaller > fuzzer: ... > MD5 has a code path that calls __inet_lookup_listener with a null skb, > so inet{6}_exact_dif_match needs to check skb

Re: [PATCH v5 0/7] add NS2 support to bgmac

2016-11-03 Thread David Miller
From: Jon Mason Date: Wed, 2 Nov 2016 13:08:01 -0400 > Add support for the amac found in the Broadcom Northstar2 SoC to the > bgmac driver. This necessitates adding support to connect to an > externally defined phy (as described in the device tree) in the driver. >

Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-03 Thread David Miller
From: Madalin Bucur Date: Wed, 2 Nov 2016 22:17:26 +0200 > This introduces the Freescale Data Path Acceleration Architecture > +static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt) > +{ > + u8 i; > + size_t res = DPAA_BP_RAW_SIZE / 2; Always order local

Re: [PATCH net-next 0/3] ip: add RECVFRAGSIZE cmsg

2016-11-03 Thread David Miller
From: Willem de Bruijn Date: Wed, 2 Nov 2016 11:02:15 -0400 > On IP datagrams and raw sockets, when packets arrive fragmented, > expose the largest received fragment size through a new cmsg. > > Protocols implemented on top of these sockets may use this, for >

Re: [PATCH net] qede: Correctly map aggregation replacement pages

2016-11-03 Thread David Miller
From: Yuval Mintz Date: Wed, 2 Nov 2016 16:36:46 +0200 > Driver allocates replacement buffers before-hand to make > sure whenever an aggregation begins there would be a replacement > for the Rx buffers, as we can't release the buffer until > aggregation is terminated and

Re: [PATCH net] tcp: fix potential memory corruption

2016-11-03 Thread David Miller
From: Eric Dumazet Date: Wed, 02 Nov 2016 07:53:17 -0700 > From: Eric Dumazet > > Imagine initial value of max_skb_frags is 17, and last > skb in write queue has 15 frags. > > Then max_skb_frags is lowered to 14 or smaller value. > > tcp_sendmsg()

Re: [PATCH v3 0/2] net: stmmac: Add OXNAS DWMAC Glue

2016-11-03 Thread David Miller
From: Neil Armstrong Date: Wed, 2 Nov 2016 15:02:35 +0100 > This patchset add support for the Sysnopsys DWMAC Gigabit Ethernet > controller Glue layer of the Oxford Semiconductor OX820 SoC. Series applied to net-next, thanks.

Re: [patch net-next 0/2] Fixes for raw diag sockets handling

2016-11-03 Thread David Miller
From: Cyrill Gorcunov Date: Wed, 02 Nov 2016 15:36:30 +0300 > Hi! Here are a few fixes for raw-diag sockets handling: missing > sock_put call and jump for exiting from nested cycle. I made > patches for iproute2 as well so will send them out soon. Series applied, thanks.

Time to revisit LISP?

2016-11-03 Thread Tom Herbert
Hi Chris, Looking at netdev archives I see that Dave's response to the LISP patches from June 2014 was: "Sorry, I'm not too thrilled about LISP and this patch in particular, from several different angles. And therefore I'm going to mark this patch deferred and not apply it at this time." It

Re: [PATCH net] cxgb4: correct device ID of T6 adapter

2016-11-03 Thread David Miller
From: Hariprasad Shenai Date: Wed, 2 Nov 2016 10:52:53 +0530 > Signed-off-by: Hariprasad Shenai Applied, thanks.

Re: [Patch net] inet: fix sleeping inside inet_wait_for_connect()

2016-11-03 Thread David Miller
From: Cong Wang Date: Tue, 1 Nov 2016 16:04:36 -0700 > Andrey reported this kernel warning: ... > Unlike commit 26cabd31259ba43f68026ce3f62b78094124333f > ("sched, net: Clean up sk_wait_event() vs. might_sleep()"), the > sleeping function is called before

Re: [PATCH net-next] netfilter: Update ip_route_me_harder to consider L3 domain

2016-11-03 Thread David Ahern
On 11/3/16 11:43 AM, David Ahern wrote: > ip_route_me_harder is not considering the L3 domain and sending lookups > to the wrong table. For example consider the following output rule: > > iptables -I OUTPUT -p tcp --dport 12345 -j REJECT --reject-with tcp-reset > > using perf to analyze lookups

[PATCH net] sctp: assign assoc_id earlier in __sctp_connect

2016-11-03 Thread Marcelo Ricardo Leitner
sctp_wait_for_connect() currently already holds the asoc to keep it alive during the sleep, in case another thread release it. But Andrey Konovalov and Dmitry Vyukov reported an use-after-free in such situation. Problem is that __sctp_connect() doesn't get a ref on the asoc and will do a read on

Re: net/sctp: use-after-free in __sctp_connect

2016-11-03 Thread Andrey Konovalov
On Thu, Nov 3, 2016 at 7:35 PM, Marcelo Ricardo Leitner wrote: > On Thu, Nov 03, 2016 at 07:02:47PM +0100, Andrey Konovalov wrote: >> On Thu, Nov 3, 2016 at 6:52 PM, Marcelo Ricardo Leitner >> wrote: >> > On Thu, Nov 03, 2016 at 06:11:01PM

Re: net/sctp: use-after-free in __sctp_connect

2016-11-03 Thread Marcelo Ricardo Leitner
On Thu, Nov 03, 2016 at 07:02:47PM +0100, Andrey Konovalov wrote: > On Thu, Nov 3, 2016 at 6:52 PM, Marcelo Ricardo Leitner > wrote: > > On Thu, Nov 03, 2016 at 06:11:01PM +0100, Andrey Konovalov wrote: > >> On Wed, Nov 2, 2016 at 11:42 PM, Andrey Konovalov

[PATCH net-next v1 08/10] amd-xgbe: Support for 64-bit management counter registers

2016-11-03 Thread Tom Lendacky
Add support for reading all management counter registers as 64-bit values. The indication of whether to read the high 32-bits to form a 64-bit value is indicated in the version data. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-dev.c | 36

[PATCH net-next v1 05/10] amd-xgbe: Prepare for introduction of clause 37 autoneg

2016-11-03 Thread Tom Lendacky
Prepare for the future introduction of clause 37 auto-negotiation by updating the current auto-negotiation related functions to identify them as clause 73 functions. Move interrupt enablement to the enable/disable auto-negotiation functions. Update what will be common routines to check for the

[PATCH net-next v1 10/10] amd-xgbe: Prepare for supporting PCI devices

2016-11-03 Thread Tom Lendacky
Update the driver framework to separate out platform/ACPI specific code from general code during device initialization. This will allow for the introduction of PCI device support. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/Makefile|3

  1   2   3   >