Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Greg KH
On Sat, Dec 10, 2016 at 11:18:14PM +0100, Dan Lüdtke wrote: > > > On 8 Dec 2016, at 05:34, Daniel Kahn Gillmor wrote: > > > > On Wed 2016-12-07 19:30:34 -0500, Hannes Frederic Sowa wrote: > >> Your custom protocol should be designed in a way you get an aligned ip > >>

Re: [Patch net] e1000: use disable_hardirq() for e1000_netpoll()

2016-12-10 Thread David Miller
From: Cong Wang Date: Sat, 10 Dec 2016 14:22:42 -0800 > In commit 02cea3958664 ("genirq: Provide disable_hardirq()") > Peter introduced disable_hardirq() for netpoll, but it is forgotten > to use it for e1000. > > This patch changes disable_irq() to disable_hardirq()

Re: [PATCH] i40e: don't truncate match_method assignment

2016-12-10 Thread David Miller
From: Jacob Keller Date: Fri, 9 Dec 2016 13:39:21 -0800 > The .match_method field is a u8, so we shouldn't be casting to a u16, > and because it is only one byte, we do not need to byte swap anything. > Just assign the value directly. This avoids issues on Big Endian >

Re: [PATCH v2] net: ethernet: ti: netcp: add support of cpts

2016-12-10 Thread David Miller
From: Grygorii Strashko Date: Thu, 8 Dec 2016 16:21:56 -0600 > From: WingMan Kwok > > This patch adds support of the cpts device found in the > gbe and 10gbe ethernet switches on the keystone 2 SoCs > (66AK2E/L/Hx, 66AK2Gx). > > Cc: Richard Cochran

Re: [PATCH] [v4] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-12-10 Thread David Miller
From: Timur Tabi Date: Wed, 7 Dec 2016 13:20:51 -0600 > Instead of having individual PHY drivers set the SUPPORTED_Pause and > SUPPORTED_Asym_Pause flags, phylib itself should set those flags, > unless there is a hardware erratum or other special case. During >

Re: [PATCH net-next 1/3] net: l2tp: export debug flags to UAPI

2016-12-10 Thread David Miller
From: Asbjoern Sloth Toennesen Date: Sun, 11 Dec 2016 00:18:57 + > Move the L2TP_MSG_* definitions to UAPI, as it is part of > the netlink API. > > Signed-off-by: Asbjoern Sloth Toennesen Applied.

Re: [PATCH net-next 3/3] net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_*

2016-12-10 Thread David Miller
From: Asbjoern Sloth Toennesen Date: Sun, 11 Dec 2016 00:18:59 + > Signed-off-by: Asbjoern Sloth Toennesen Applied.

Re: [PATCH net-next 2/3] net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_*

2016-12-10 Thread David Miller
From: Asbjoern Sloth Toennesen Date: Sun, 11 Dec 2016 00:18:58 + > PPPOL2TP_MSG_* and L2TP_MSG_* are duplicates, and are being used > interchangeably in the kernel, so let's standardize on L2TP_MSG_* > internally, and keep PPPOL2TP_MSG_* defined in UAPI for compatibility.

Re: Remove private tx queue locks

2016-12-10 Thread David Miller
From: Lino Sanfilippo Date: Fri, 9 Dec 2016 00:55:41 +0100 > this patch series removes unnecessary private locks in the sxgbe and the > stmmac driver. > > v2: > - adjust commit message Series applied to net-next, thanks.

Re: [PATCH net 0/3] net: bridge: fast ageing on topology change

2016-12-10 Thread David Miller
From: Vivien Didelot Date: Sat, 10 Dec 2016 13:44:26 -0500 > 802.1D [1] specifies that the bridges in a network must use a short > value to age out dynamic entries in the Filtering Database for a period, > once a topology change has been communicated by the

Re: [PATCH 09/10] vsock/virtio: fix src/dst cid format

2016-12-10 Thread Michael S. Tsirkin
On Wed, Dec 07, 2016 at 12:31:56PM +0800, Jason Wang wrote: > > > On 2016年12月06日 23:41, Michael S. Tsirkin wrote: > > These fields are 64 bit, using le32_to_cpu and friends > > on these will not do the right thing. > > Fix this up. > > > > Cc: sta...@vger.kernel.org > > Signed-off-by: Michael

[PATCH net-next 3/3] net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_*

2016-12-10 Thread Asbjoern Sloth Toennesen
Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_ppp.c | 54 ++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c index 2ddfec1..36cc56f 100644 ---

[PATCH net-next 1/3] net: l2tp: export debug flags to UAPI

2016-12-10 Thread Asbjoern Sloth Toennesen
Move the L2TP_MSG_* definitions to UAPI, as it is part of the netlink API. Signed-off-by: Asbjoern Sloth Toennesen --- include/uapi/linux/l2tp.h | 17 - net/l2tp/l2tp_core.h | 10 -- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git

[PATCH net-next 2/3] net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_*

2016-12-10 Thread Asbjoern Sloth Toennesen
PPPOL2TP_MSG_* and L2TP_MSG_* are duplicates, and are being used interchangeably in the kernel, so let's standardize on L2TP_MSG_* internally, and keep PPPOL2TP_MSG_* defined in UAPI for compatibility. Signed-off-by: Asbjoern Sloth Toennesen ---

Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread Daniel Borkmann
On 12/10/2016 11:15 PM, David Ahern wrote: On 12/10/16 2:21 PM, Daniel Borkmann wrote: Please name it bpf_prog_create() then, it would be consistent to bpf_map_create() and shorter as well. Sorry, lack of coffee, scratch that. Can't the current bpf_prog_attach() stay as is, and you name the

Re: [PATCH] net: nicvf: use new api ethtool_{get|set}_link_ksettings

2016-12-10 Thread David Miller
From: Philippe Reynes Date: Sat, 10 Dec 2016 15:00:48 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/5] net: ethernet: ti: cpsw: improve re-split policy

2016-12-10 Thread David Miller
From: Ivan Khoronzhuk Date: Sat, 10 Dec 2016 14:23:45 +0200 > This patches add several simplifications and improvements to set > maximum rate for channels taking in account switch and dual emac mode. > > Don't re-split res in the following cases: > - speed of phys is

Re: [PATCH 3/5] net: ethernet: ti: cpsw: combine budget and weight split and check

2016-12-10 Thread David Miller
From: Ivan Khoronzhuk Date: Sat, 10 Dec 2016 14:23:48 +0200 > Re-split weight along with budget. It simplify code a little > and update state after every rate change. Also it's necessarily > to move arguments checks to this combined function. Replace > maximum rate

Re: [PATCH 4/5] net: ethernet: ti: cpsw: re-split res only when speed is changed

2016-12-10 Thread David Miller
From: Ivan Khoronzhuk Date: Sat, 10 Dec 2016 14:23:49 +0200 > Don't re-split res in the following cases: > - speed of phys is not changed > - speed of phys is changed and no rate limited channels > - speed of phys is changed and all channels are rate limited > - phy

Re: [PATCH 5/5] net: ethernet: ti: cpsw: sync rates for channels in dual emac mode

2016-12-10 Thread David Miller
From: Ivan Khoronzhuk Date: Sat, 10 Dec 2016 14:23:50 +0200 > The channels are common for both ndevs in dual emac mode. Hence, keep > in sync their rates. > > Signed-off-by: Ivan Khoronzhuk Applied.

Re: [PATCH 2/5] net: ethernet: ti: cpsw: don't start queue twice

2016-12-10 Thread David Miller
From: Ivan Khoronzhuk Date: Sat, 10 Dec 2016 14:23:47 +0200 > No need to start queues after cpsw is started as it will be done > while cpsw_adjust_link(), after phy connection. > > Signed-off-by: Ivan Khoronzhuk Applied.

Re: [PATCH net-next] net: mvneta: select GENERIC_ALLOCATOR

2016-12-10 Thread David Miller
From: Arnd Bergmann Date: Sat, 10 Dec 2016 11:38:32 +0100 > We previously relied on GENERIC_ALLOCATOR to be selected by CONFIG_ARM, > but now we can compile-test the driver on other architectures that > don't select it: > > drivers/net/built-in.o: In function `mvneta_bm_remove':

Re: [PATCH] net: socket: removed an unnecessary newline

2016-12-10 Thread David Miller
From: kushwah...@samsung.com Date: Sat, 10 Dec 2016 11:14:47 +0530 > From: Amit Kushwaha > > This patch removes a newline which was added > in socket.c file in net-next > > Signed-off-by: Amit Kushwaha Applied.

Re: [Patch net-next] netlink: use blocking notifier

2016-12-10 Thread David Miller
From: Cong Wang Date: Fri, 9 Dec 2016 21:10:59 -0800 > netlink_chain is called in ->release(), which is apparently > a process context, so we don't have to use an atomic notifier > here. > > Signed-off-by: Cong Wang Applied.

[Patch net] e1000: use disable_hardirq() for e1000_netpoll()

2016-12-10 Thread Cong Wang
In commit 02cea3958664 ("genirq: Provide disable_hardirq()") Peter introduced disable_hardirq() for netpoll, but it is forgotten to use it for e1000. This patch changes disable_irq() to disable_hardirq() for e1000. Reported-by: Dave Jones Suggested-by: Sabrina Dubroca

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Dan Lüdtke
> On 8 Dec 2016, at 05:34, Daniel Kahn Gillmor wrote: > > On Wed 2016-12-07 19:30:34 -0500, Hannes Frederic Sowa wrote: >> Your custom protocol should be designed in a way you get an aligned ip >> header. Most protocols of the IETF follow this mantra and it is always >>

Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread David Ahern
On 12/10/16 2:21 PM, Daniel Borkmann wrote: >> >> Please name it bpf_prog_create() then, it would be consistent to >> bpf_map_create() and shorter as well. > > Sorry, lack of coffee, scratch that. > > Can't the current bpf_prog_attach() stay as is, and you name the above new > functions

Re: [iproute2 net-next 3/8] Add libbpf.h header with BPF_ macros

2016-12-10 Thread Daniel Borkmann
On 12/10/2016 09:32 PM, David Ahern wrote: Based on version in kernel repo, samples/bpf/libbpf.h Signed-off-by: David Ahern --- include/libbpf.h | 184 +++ 1 file changed, 184 insertions(+) create mode 100644

Re: [PATCH] sh_eth: add wake-on-lan support via magic packet

2016-12-10 Thread Sergei Shtylyov
Hello! On 12/08/2016 05:56 PM, Niklas Söderlund wrote: You only enable the WOL support fo the R-Car gen2 chips but never say that explicitly, neither in the subject nor here. Signed-off-by: Niklas Söderlund --- drivers/net/ethernet/renesas/sh_eth.c

Re: [iproute2 net-next 2/8] bpf: export bpf_prog_load

2016-12-10 Thread Daniel Borkmann
On 12/10/2016 09:32 PM, David Ahern wrote: Code move only; no functional change intended. Signed-off-by: David Ahern --- include/bpf_util.h | 3 +++ lib/bpf.c | 40 2 files changed, 23 insertions(+), 20

Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread Daniel Borkmann
On 12/10/2016 10:16 PM, Daniel Borkmann wrote: On 12/10/2016 09:32 PM, David Ahern wrote: For consistency with other bpf commands, the functions are named bpf_prog_attach and bpf_prog_detach. The existing bpf_prog_attach is renamed to bpf_prog_load_and_report since it calls bpf_prog_load and

Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread Daniel Borkmann
On 12/10/2016 09:32 PM, David Ahern wrote: For consistency with other bpf commands, the functions are named bpf_prog_attach and bpf_prog_detach. The existing bpf_prog_attach is renamed to bpf_prog_load_and_report since it calls bpf_prog_load and bpf_prog_report. Signed-off-by: David Ahern

Re: [PATCH net v3] ibmveth: set correct gso_size and gso_type

2016-12-10 Thread David Miller
From: Thomas Falcon Date: Sat, 10 Dec 2016 12:39:48 -0600 > v3: include a check for non-zero mss when calculating gso_segs > > v2: calculate gso_segs after Eric Dumazet's comments on the earlier patch > and make sure everyone is included on CC I already applied

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Felix Fietkau
On 2016-12-10 21:32, Måns Rullgård wrote: > Felix Fietkau writes: > >> On 2016-12-10 14:25, Måns Rullgård wrote: >>> Felix Fietkau writes: >>> On 2016-12-07 19:54, Jason A. Donenfeld wrote: > On Wed, Dec 7, 2016 at 7:51 PM, David Miller

[iproute2 net-next 8/8] Introduce ip vrf command

2016-12-10 Thread David Ahern
'ip vrf' follows the user semnatics established by 'ip netns'. The 'ip vrf' subcommand supports 3 usages: 1. Run a command against a given vrf: ip vrf exec NAME CMD Uses the recently committed cgroup/sock BPF option. vrf directory is added to cgroup2 mount. Individual vrfs are

[iproute2 net-next 3/8] Add libbpf.h header with BPF_ macros

2016-12-10 Thread David Ahern
Based on version in kernel repo, samples/bpf/libbpf.h Signed-off-by: David Ahern --- include/libbpf.h | 184 +++ 1 file changed, 184 insertions(+) create mode 100644 include/libbpf.h diff --git a/include/libbpf.h

[iproute2 net-next 6/8] change name_is_vrf to return index

2016-12-10 Thread David Ahern
index of 0 means name is not a valid vrf. Signed-off-by: David Ahern --- ip/ip_common.h | 2 +- ip/iplink_vrf.c | 15 +-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/ip/ip_common.h b/ip/ip_common.h index 0147f45a7a31..3162f1ca5b2c

[iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread David Ahern
For consistency with other bpf commands, the functions are named bpf_prog_attach and bpf_prog_detach. The existing bpf_prog_attach is renamed to bpf_prog_load_and_report since it calls bpf_prog_load and bpf_prog_report. Signed-off-by: David Ahern --- include/bpf_util.h

[iproute2 net-next 7/8] libnetlink: Add variant of rtnl_talk that does not display RTNETLINK answers error

2016-12-10 Thread David Ahern
iplink_vrf has 2 functions used to validate a user given device name is a VRF device and to return the table id. If the user string is not a device name ip commands with a vrf keyword show a confusing error message: "RTNETLINK answers: No such device". Add a variant of rtnl_talk that does not

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Måns Rullgård
Felix Fietkau writes: > On 2016-12-10 14:25, Måns Rullgård wrote: >> Felix Fietkau writes: >> >>> On 2016-12-07 19:54, Jason A. Donenfeld wrote: On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: > It's so much better to analyze

[iproute2 net-next 2/8] bpf: export bpf_prog_load

2016-12-10 Thread David Ahern
Code move only; no functional change intended. Signed-off-by: David Ahern --- include/bpf_util.h | 3 +++ lib/bpf.c | 40 2 files changed, 23 insertions(+), 20 deletions(-) diff --git a/include/bpf_util.h

[iproute2 net-next 4/8] move cmd_exec to lib utils

2016-12-10 Thread David Ahern
Signed-off-by: David Ahern --- include/utils.h | 2 ++ ip/ipnetns.c| 34 -- lib/Makefile| 2 +- lib/exec.c | 41 + 4 files changed, 44 insertions(+), 35 deletions(-) create mode

[iproute2 net-next 5/8] Add filesystem APIs to lib

2016-12-10 Thread David Ahern
Add make_path to recursively call mkdir as needed to create a given path with the given mode. Add find_cgroup2_mount to lookup path where cgroup2 is mounted. If it is not already mounted, cgroup2 is mounted under /var/run/cgroup2 for use by iproute2. Signed-off-by: David Ahern

[iproute2 v2 net-next 0/8] Add support for vrf helper

2016-12-10 Thread David Ahern
This series adds support to iproute2 to run a command against a specific VRF. The user semnatics are similar to 'ip netns'. The 'ip vrf' subcommand supports 3 usages: 1. Run a command against a given vrf: ip vrf exec NAME CMD Uses the recently committed cgroup/sock BPF option. vrf

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Felix Fietkau
On 2016-12-10 14:25, Måns Rullgård wrote: > Felix Fietkau writes: > >> On 2016-12-07 19:54, Jason A. Donenfeld wrote: >>> On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: It's so much better to analyze properly where the misalignment comes from

[PATCH net 1/3] net: bridge: add helper to offload ageing time

2016-12-10 Thread Vivien Didelot
The SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME switchdev attr is actually set when initializing a bridge port, and when configuring the bridge ageing time from ioctl/netlink/sysfs. Add a __set_ageing_time helper to offload the ageing time to physical switches, and add the SWITCHDEV_F_DEFER flag since

[PATCH net 2/3] net: bridge: add helper to set topology change

2016-12-10 Thread Vivien Didelot
Add a __br_set_topology_change helper to set the topology change value. This can be later extended to add actions when the topology change flag is set or cleared. Signed-off-by: Vivien Didelot --- net/bridge/br_private_stp.h | 1 + net/bridge/br_stp.c

[PATCH net 3/3] net: bridge: shorten ageing time on topology change

2016-12-10 Thread Vivien Didelot
802.1D [1] specifies that the bridges must use a short value to age out dynamic entries in the Filtering Database for a period, once a topology change has been communicated by the root bridge. Add a bridge_ageing_time member in the net_bridge structure to store the bridge ageing time value

[PATCH net 0/3] net: bridge: fast ageing on topology change

2016-12-10 Thread Vivien Didelot
802.1D [1] specifies that the bridges in a network must use a short value to age out dynamic entries in the Filtering Database for a period, once a topology change has been communicated by the root bridge. This patchset fixes this for the in-kernel STP implementation. Once the topology change

[PATCH net v3] ibmveth: set correct gso_size and gso_type

2016-12-10 Thread Thomas Falcon
This patch is based on an earlier one submitted by Jon Maxwell with the following commit message: "We recently encountered a bug where a few customers using ibmveth on the same LPAR hit an issue where a TCP session hung when large receive was enabled. Closer analysis revealed that the session was

[iproute2 net-next 5/8] Add filesystem APIs to lib

2016-12-10 Thread David Ahern
Add make_path to recursively call mkdir as needed to create a given path with the given mode. Add find_cgroup2_mount to lookup path where cgroup2 is mounted. If it is not already mounted, cgroup2 is mounted under /var/run/cgroup2 for use by iproute2. Signed-off-by: David Ahern

[iproute2 net-next 2/8] bpf: export bpf_prog_load

2016-12-10 Thread David Ahern
Code move only; no functional change intended. Signed-off-by: David Ahern --- include/bpf_util.h | 3 +++ lib/bpf.c | 40 2 files changed, 23 insertions(+), 20 deletions(-) diff --git a/include/bpf_util.h

[iproute2 net-next 4/8] move cmd_exec to lib utils

2016-12-10 Thread David Ahern
Signed-off-by: David Ahern --- include/utils.h | 2 ++ ip/ipnetns.c| 34 -- lib/Makefile| 2 +- lib/exec.c | 41 + 4 files changed, 44 insertions(+), 35 deletions(-) create mode

[iproute2 net-next 6/8] change name_is_vrf to return index

2016-12-10 Thread David Ahern
index of 0 means name is not a valid vrf. Signed-off-by: David Ahern --- ip/ip_common.h | 2 +- ip/iplink_vrf.c | 15 +-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/ip/ip_common.h b/ip/ip_common.h index 0147f45a7a31..3162f1ca5b2c

[iproute2 net-next 8/8] Introduce ip vrf command

2016-12-10 Thread David Ahern
'ip vrf' follows the user semnatics established by 'ip netns'. The 'ip vrf' subcommand supports 3 usages: 1. Run a command against a given vrf: ip vrf exec NAME CMD Uses the recently committed cgroup/sock BPF option. vrf directory is added to cgroup2 mount. Individual vrfs are

[iproute2 net-next 7/8] libnetlink: Add variant of rtnl_talk that does not display RTNETLINK answers error

2016-12-10 Thread David Ahern
iplink_vrf has 2 functions used to validate a user given device name is a VRF device and to return the table id. If the user string is not a device name ip commands with a vrf keyword show a confusing error message: "RTNETLINK answers: No such device". Add a variant of rtnl_talk that does not

[iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread David Ahern
For consistency with other bpf commands, the functions are named bpf_prog_attach and bpf_prog_detach. The existing bpf_prog_attach is renamed to bpf_prog_load_and_report since it calls bpf_prog_load and bpf_prog_report. Signed-off-by: David Ahern --- include/bpf_util.h

[iproute2 net-next 0/8] Add support for vrf helper

2016-12-10 Thread David Ahern
This series adds support to iproute2 to run a command against a specific VRF. The user semnatics are similar to 'ip netns'. The 'ip vrf' subcommand supports 3 usages: 1. Run a command against a given vrf: ip vrf exec NAME CMD Uses the recently committed cgroup/sock BPF option. vrf

Mr. Mathiang Puk

2016-12-10 Thread mathiang puk044
My Dear Friend, How are you and your family? I hope you all are fine I need your urgent assistance in transferring the sum of Eight Million United States Dollars ($8,000,000:00) into your account within 14 working banking days. I don't want the money to go into our bank treasury as an

Re: [PATCH/RFC net-next] net: fec: allow "mini jumbo" frames

2016-12-10 Thread Vivien Didelot
Hi Nikita, Nikita Yushchenko writes: > This adds support for MTU slightly larger than default, on modern > FEC flavours. > > Currently FEC driver uses single hardware Rx buffer per frame. On most > FEC flavours, size of single buffer is limited by 11-bit field,

Re: [PATCH net-next] netfilter: nft_counter: rework atomic dump and reset

2016-12-10 Thread Eric Dumazet
On Sat, 2016-12-10 at 15:25 +0100, Pablo Neira Ayuso wrote: > On Sat, Dec 10, 2016 at 03:16:55PM +0100, Pablo Neira Ayuso wrote: = > > - nft_counter_fetch(priv, , reset); > + nft_counter_fetch(priv, ); > + if (reset) > + nft_counter_reset(priv, ); > > if

Re: [PATCH net-next] netfilter: nft_counter: rework atomic dump and reset

2016-12-10 Thread Pablo Neira Ayuso
On Sat, Dec 10, 2016 at 03:16:55PM +0100, Pablo Neira Ayuso wrote: > On Sat, Dec 10, 2016 at 03:05:41PM +0100, Pablo Neira Ayuso wrote: > [...] > > -static void nft_counter_reset(struct nft_counter_percpu __percpu *counter, > > - struct nft_counter *total) > > -{ > > -

Re: [PATCH net-next] netfilter: nft_counter: rework atomic dump and reset

2016-12-10 Thread Pablo Neira Ayuso
On Sat, Dec 10, 2016 at 03:05:41PM +0100, Pablo Neira Ayuso wrote: [...] > -static void nft_counter_reset(struct nft_counter_percpu __percpu *counter, > - struct nft_counter *total) > -{ > - struct nft_counter_percpu *cpu_stats; > - u64 bytes, packets; > -

[PATCH net-next] netfilter: nft_counter: rework atomic dump and reset

2016-12-10 Thread Pablo Neira Ayuso
Dump and reset doesn't work unless cmpxchg64() is used both from both packet and control plane paths. This approach is going to be slow though. Instead, use a percpu seqcount to fetch counters consistently, then subtract bytes and packets in case a reset was requested. This patch is based on

[PATCH] net: nicvf: use new api ethtool_{get|set}_link_ksettings

2016-12-10 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- .../net/ethernet/cavium/thunder/nicvf_ethtool.c| 56 +++- 1 files changed, 31 insertions(+), 25 deletions(-)

Re: [PATCH V2 18/22] bnxt_re: Support for DCB

2016-12-10 Thread Or Gerlitz
On Fri, Dec 9, 2016 at 8:48 AM, Selvin Xavier wrote: > This patch queries the configured RoCE APP Priority on the host > using the dcbnl API and programs the RoCE FW with the corresponding > Traffic Class(es) for the priority. > +#define BNXT_RE_ROCE_V1_ETH_TYPE

Re: [PATCH net-next 2/5] liquidio VF vxlan

2016-12-10 Thread Or Gerlitz
On Fri, Dec 9, 2016 at 12:42 AM, Vatsavayi, Raghu wrote: >> From: Or Gerlitz [mailto:gerlitz...@gmail.com] >> On Thu, Dec 8, 2016 at 11:00 PM, Raghu Vatsavayi >> wrote: >>> Adds VF vxlan offload support. >> What's the use case for

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Måns Rullgård
Felix Fietkau writes: > On 2016-12-07 19:54, Jason A. Donenfeld wrote: >> On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: >>> It's so much better to analyze properly where the misalignment comes from >>> and address it at the source, as we have for

Re: [PATCH] ARM: add cmpxchg64 helper for ARMv7-M

2016-12-10 Thread Pablo Neira Ayuso
Hi Arnd, On Sat, Dec 10, 2016 at 11:36:34AM +0100, Arnd Bergmann wrote: > A change to the netfilter code in net-next introduced the first caller of > cmpxchg64 that can get built on ARMv7-M, leading to an error from the > assembler that points out the lack of 64-bit atomics on this architecture:

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Felix Fietkau
On 2016-12-07 19:54, Jason A. Donenfeld wrote: > On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: >> It's so much better to analyze properly where the misalignment comes from >> and address it at the source, as we have for various cases that trip up >> Sparc too. > >

[PATCH 1/5] net: ethernet: ti: cpsw: use same macros to get active slave

2016-12-10 Thread Ivan Khoronzhuk
Use the same, more convenient macros, to get active slave. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index

[PATCH 2/5] net: ethernet: ti: cpsw: don't start queue twice

2016-12-10 Thread Ivan Khoronzhuk
No need to start queues after cpsw is started as it will be done while cpsw_adjust_link(), after phy connection. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c

[PATCH 3/5] net: ethernet: ti: cpsw: combine budget and weight split and check

2016-12-10 Thread Ivan Khoronzhuk
Re-split weight along with budget. It simplify code a little and update state after every rate change. Also it's necessarily to move arguments checks to this combined function. Replace maximum rate check for an interface on maximum possible rate. Signed-off-by: Ivan Khoronzhuk

[PATCH 1/5] net: ethernet: ti: cpsw: improve re-split policy

2016-12-10 Thread Ivan Khoronzhuk
This patches add several simplifications and improvements to set maximum rate for channels taking in account switch and dual emac mode. Don't re-split res in the following cases: - speed of phys is not changed - speed of phys is changed and no rate limited channels - speed of phys is changed and

[PATCH 4/5] net: ethernet: ti: cpsw: re-split res only when speed is changed

2016-12-10 Thread Ivan Khoronzhuk
Don't re-split res in the following cases: - speed of phys is not changed - speed of phys is changed and no rate limited channels - speed of phys is changed and all channels are rate limited - phy is unlinked while dev is open - phy is linked back but speed is not changed The maximum speed is sum

[PATCH 5/5] net: ethernet: ti: cpsw: sync rates for channels in dual emac mode

2016-12-10 Thread Ivan Khoronzhuk
The channels are common for both ndevs in dual emac mode. Hence, keep in sync their rates. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 37/50] netfilter: nf_tables: atomic dump and reset for stateful objects

2016-12-10 Thread Pablo Neira Ayuso
On Fri, Dec 09, 2016 at 07:22:06AM -0800, Eric Dumazet wrote: > On Fri, 2016-12-09 at 06:24 -0800, Eric Dumazet wrote: > > > It looks that you want a seqcount, even on 64bit arches, > > so that CPU 2 can restart its loop, and more importantly you need > > to not accumulate the values you read,

[PATCH net-next] net: mvneta: select GENERIC_ALLOCATOR

2016-12-10 Thread Arnd Bergmann
We previously relied on GENERIC_ALLOCATOR to be selected by CONFIG_ARM, but now we can compile-test the driver on other architectures that don't select it: drivers/net/built-in.o: In function `mvneta_bm_remove': mvneta_bm.c:(.text+0x4ee35): undefined reference to `gen_pool_free' This adds an

[PATCH] ARM: add cmpxchg64 helper for ARMv7-M

2016-12-10 Thread Arnd Bergmann
A change to the netfilter code in net-next introduced the first caller of cmpxchg64 that can get built on ARMv7-M, leading to an error from the assembler that points out the lack of 64-bit atomics on this architecture: /tmp/ccMe7djj.s: Assembler messages: /tmp/ccMe7djj.s:367: Error: selected