Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-19 Thread Rob Herring
On Mon, Dec 19, 2016 at 2:14 AM, Dongpo Li wrote: > Hi Rob and David, > > On 2016/12/12 22:21, Rob Herring wrote: >> On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li wrote: >>> Hi Rob, >>> >>> On 2016/12/10 6:35, Rob Herring wrote: On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: [...]

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

2016-12-19 Thread David Miller
From: Arvind Yadav Date: Thu, 15 Dec 2016 00:33:30 +0530 > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > This error check will avoid NULL pointer dereference. > > Signed-off-by: Arvind Yadav Since ioremap() is in fact designed to poss

Re: [PATCH net] virtio_net: reject XDP programs using header adjustment

2016-12-19 Thread Jakub Kicinski
On Mon, Dec 19, 2016 at 3:23 PM, Mintz, Yuval wrote: >> commit 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog") >> added a new XDP helper to prepend and remove data from a frame. >> Make virtio_net reject programs making use of this helper until proper >> support is added. >> >> Signed

RE: [PATCH v5 1/4] siphash: add cryptographically secure PRF

2016-12-19 Thread David Laight
From: George Spelvin > Sent: 17 December 2016 15:21 ... > uint32_t > hsiphash24(char const *in, size_t len, uint32_t const key[2]) > { > uint32_t c = key[0]; > uint32_t d = key[1]; > uint32_t a = 0x6c796765 ^ 0x736f6d65; > uint32_t b = d ^ 0x74656462 ^ 0x646f7261; I've

Re: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[]

2016-12-19 Thread David Miller
From: Madalin Bucur Date: Mon, 19 Dec 2016 11:22:20 +0200 > The fsl/fman drivers will use of_platform_populate() on all > supported platforms. > > Signed-off-by: Madalin Bucur It seems that this creates a failure point between patches #2 and #3. If the cases handled by this "fsl,fman" entry a

Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread Giuseppe CAVALLARO
On 12/18/2016 9:38 PM, Pavel Machek wrote: Fix up memory barriers in stmmac driver. They are meant to protect against DMA engine, so smp_ variants are certainly wrong, and dma_ variants are preferable. Signed-off-by: Pavel Machek Acked-by: Giuseppe Cavallaro diff --git a/drivers/net/ethe

[PATCH 4/4] arm64: dts: marvell: Add ethernet switch definition for the EXPRESSObin

2016-12-19 Thread Romain Perier
This defines and enables the Marvell ethernet switch MVE886341 on the Marvell EXPRESSObin board. Signed-off-by: Romain Perier --- .../boot/dts/marvell/armada-3720-espressobin.dts | 67 ++ 1 file changed, 67 insertions(+) diff --git a/arch/arm64/boot/dts/marvell/armada-3720

[PATCH 0/4] Add support for the ethernet switch on the EXPRESSObin

2016-12-19 Thread Romain Perier
This set of patches adds support for the Marvell ethernet switch 88E6341. It also add the devicetree definition of thid switch to the DT board. Romain Perier (4): net: dsa: mv88e6xxx: Allow mv88e6xxx_smi_init() to be used at address 0x1 net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY a

RE: [PATCH net] virtio_net: reject XDP programs using header adjustment

2016-12-19 Thread Mintz, Yuval
> commit 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog") > added a new XDP helper to prepend and remove data from a frame. > Make virtio_net reject programs making use of this helper until proper > support is added. > > Signed-off-by: Jakub Kicinski Is that how it goes until we'll a

Re: [PATCH net-next v4 2/4] dt-bindings: net: add EEE capability constants

2016-12-19 Thread Jerome Brunet
Hi Rob, First, Thx for this information and sorry for this late reply As you may have seen yourself, there was little bit of confusion while discussing this patch series. The point is the v3 was applied before your reply (patches 2 and 3 not combined unfortunately). Because of this confusion, the

Re: [PATCH 4/4] arm64: dts: marvell: Add ethernet switch definition for the EXPRESSObin

2016-12-19 Thread Romain Perier
Hi, Le 19/12/2016 à 15:58, Thomas Petazzoni a écrit : Hello, On Mon, 19 Dec 2016 15:16:09 +0100, Romain Perier wrote: This defines and enables the Marvell ethernet switch MVE886341 on the Marvell EXPRESSObin board. Signed-off-by: Romain Perier I didn't want to make this (silly) comment but

[PATCH net 0/3] Fix integration of eee-broken-modes

2016-12-19 Thread Jerome Brunet
The purpose of this series is to fix the integration of the ethernet phy property "eee-broken-modes" [0] The v3 of this series has been merged, missing a fix (error reported by kbuild robot) available in the v4 [1] More importantly, Florian opposed adding a DT property mapping a device register t

[PATCH net 3/3] dt: bindings: net: use boolean dt properties for eee broken modes

2016-12-19 Thread Jerome Brunet
The patches regarding eee-broken-modes was merged before all people involved could find an agreement on the best way to move forward. While we agreed on having a DT property to mark particular modes as broken, the value used for eee-broken-modes mapped the phy register in very direct way. Because

Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread Niklas Cassel
Tested-by: Niklas Cassel On 12/18/2016 09:38 PM, Pavel Machek wrote: > Fix up memory barriers in stmmac driver. They are meant to protect > against DMA engine, so smp_ variants are certainly wrong, and dma_ > variants are preferable. > > Signed-off-by: Pavel Machek > > diff --git a/drivers/

Re: [PATCH 1/4] net: dsa: mv88e6xxx: Allow mv88e6xxx_smi_init() to be used at address 0x1

2016-12-19 Thread Andrew Lunn
On Mon, Dec 19, 2016 at 04:04:32PM +0100, Volodymyr Bendiuga wrote: > Hi Andrew, > > No, it did not get accepted. Or at least I did not see > David accepting it. Let me know if I should resubmit it. Hi Volodymyr Please do resend it. Probably netdev will reopen sometime after the 25th. Don't for

Re: Linux support for 802.1AS-Rev.

2016-12-19 Thread Richard Cochran
On Mon, Dec 19, 2016 at 03:50:08PM +0530, Praveen Bajantri wrote: > I am new to Linux networking and had doubt related to support for > 802.1AS-Rev. Please point me to appropriate forum/mailing list If this > is not a right place. This list is for kernel related issues. The mailing lists for the

[PATCH net 2/3] net: phy: use boolean dt properties for eee broken modes

2016-12-19 Thread Jerome Brunet
The patches regarding eee-broken-modes was merged before all people involved could find an agreement on the best way to move forward. While we agreed on having a DT property to mark particular modes as broken, the value used for eee-broken-modes mapped the phy register in very direct way. Because

[PATCH net 1/3] net: phy: fix sign type error in genphy_config_eee_advert

2016-12-19 Thread Jerome Brunet
In genphy_config_eee_advert, the return value of phy_read_mmd_indirect is checked to know if the register could be accessed but the result is assigned to a 'u32'. Changing to 'int' to correctly get errors from phy_read_mmd_indirect. Fixes: d853d145ea3e ("net: phy: add an option to disable EEE adve

[PATCH net] virtio_net: reject XDP programs using header adjustment

2016-12-19 Thread Jakub Kicinski
commit 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog") added a new XDP helper to prepend and remove data from a frame. Make virtio_net reject programs making use of this helper until proper support is added. Signed-off-by: Jakub Kicinski --- drivers/net/virtio_net.c | 5 + 1 fil

Re: [PATCH 1/4] net: dsa: mv88e6xxx: Allow mv88e6xxx_smi_init() to be used at address 0x1

2016-12-19 Thread Andrew Lunn
On Mon, Dec 19, 2016 at 03:56:34PM +0100, Romain Perier wrote: > Hi Andrew, > > Le 19/12/2016 à 15:38, Andrew Lunn a écrit : > >On Mon, Dec 19, 2016 at 03:16:06PM +0100, Romain Perier wrote: > >>Currently, the function mv88e6xxx_smi_init() returns -EINVAL if the bit > >>zero of sw_addr is 0x1. How

Re: [PATCH 3/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141

2016-12-19 Thread Romain Perier
Hi Andrew, Le 19/12/2016 à 15:52, Andrew Lunn a écrit : Hi Romain diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 76d944e..72ba24b 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -4086,6 +4086,20 @@ static const str

Re: [PATCH 4/4] arm64: dts: marvell: Add ethernet switch definition for the EXPRESSObin

2016-12-19 Thread Thomas Petazzoni
Hello, On Mon, 19 Dec 2016 15:16:09 +0100, Romain Perier wrote: > This defines and enables the Marvell ethernet switch MVE886341 on the > Marvell EXPRESSObin board. > > Signed-off-by: Romain Perier I didn't want to make this (silly) comment but since you got another comment that will let you se

Re: [PATCH 1/4] net: dsa: mv88e6xxx: Allow mv88e6xxx_smi_init() to be used at address 0x1

2016-12-19 Thread Romain Perier
Hi Andrew, Le 19/12/2016 à 15:38, Andrew Lunn a écrit : On Mon, Dec 19, 2016 at 03:16:06PM +0100, Romain Perier wrote: Currently, the function mv88e6xxx_smi_init() returns -EINVAL if the bit zero of sw_addr is 0x1. However, on some platforms, ethernet switches are configured in Multi chip addre

Re: [PATCH 2/4] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports

2016-12-19 Thread Andrew Lunn
On Mon, Dec 19, 2016 at 03:16:07PM +0100, Romain Perier wrote: > Some Marvell ethernet switches have internal ethernet transceivers with > hardcoded phy addresses. These addresses can be grearer than the number > of ports or its value might be different than the associated port number. > This is fo

Re: [PATCH 4/4] arm64: dts: marvell: Add ethernet switch definition for the EXPRESSObin

2016-12-19 Thread Andrew Lunn
> + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + switch0phy0: switch0phy0@0 { > + reg = <0x11>; Since the reg is 0x11, this should be called swi

Re: [PATCH 3/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141

2016-12-19 Thread Andrew Lunn
Hi Romain > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > b/drivers/net/dsa/mv88e6xxx/chip.c > index 76d944e..72ba24b 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.c > +++ b/drivers/net/dsa/mv88e6xxx/chip.c > @@ -4086,6 +4086,20 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = > { >

Re: [PATCH net v2] ipvlan: fix crash when master is set in loopback mode

2016-12-19 Thread Eric Dumazet
On Sun, 2016-12-18 at 11:00 -0800, Mahesh Bandewar wrote: > From: Mahesh Bandewar > > In an IPvlan setup when master is set in loopback mode e.g. > > ethtool -K eth0 set loopback on > > where eth0 is master device for IPvlan setup. > > The failure actually happens while processing mulitcas

Re: [PATCH 1/4] net: dsa: mv88e6xxx: Allow mv88e6xxx_smi_init() to be used at address 0x1

2016-12-19 Thread Andrew Lunn
On Mon, Dec 19, 2016 at 03:16:06PM +0100, Romain Perier wrote: > Currently, the function mv88e6xxx_smi_init() returns -EINVAL if the bit > zero of sw_addr is 0x1. However, on some platforms, ethernet switches > are configured in Multi chip addressing mode and available at MDIO > address 0x1. Hi Ro

Re: [RFC PATCH net-next] virtio_net: Support UDP Tunnel offloads.

2016-12-19 Thread Vlad Yasevich
On 12/15/2016 02:07 AM, Or Gerlitz wrote: > On Fri, Nov 18, 2016 at 1:01 AM, Jarno Rajahalme wrote: >> This patch is a proof-of-concept I did a few months ago for UDP tunnel >> offload support in virtio_net interface [..] > > What's the use case you were considering for a guest running a UDP base

[PATCH 3/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141

2016-12-19 Thread Romain Perier
The Marvell 88E6341 device is single-chip, 6-port ethernet switch with four integrated 10/100/1000Mbps ethernet transceivers and one high speed SerDes interfaces. It is compatible with switches of family 88E6352. This commit adds basic support for this switch by describing its capabilities to the

[PATCH 2/4] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports

2016-12-19 Thread Romain Perier
Some Marvell ethernet switches have internal ethernet transceivers with hardcoded phy addresses. These addresses can be grearer than the number of ports or its value might be different than the associated port number. This is for example the case for MV88E6341 that has 6 ports and internal Port 1 t

[PATCH 1/4] net: dsa: mv88e6xxx: Allow mv88e6xxx_smi_init() to be used at address 0x1

2016-12-19 Thread Romain Perier
Currently, the function mv88e6xxx_smi_init() returns -EINVAL if the bit zero of sw_addr is 0x1. However, on some platforms, ethernet switches are configured in Multi chip addressing mode and available at MDIO address 0x1. Signed-off-by: Romain Perier --- drivers/net/dsa/mv88e6xxx/chip.c | 4

Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

2016-12-19 Thread Michał Kępień
Mike, Johannes, sorry for the trouble caused. > Thanks for the report. I'm sorry I missed this in review - obviously we > can't call something that acquires the mutex from rfkill_set_sw_state() > which clearly states, in the documentation: > >  * This function can be called in any context, even f

Re: [PATCH net 2/2] sctp: not copying duplicate addrs to the assoc's bind address list

2016-12-19 Thread Neil Horman
On Sat, Dec 17, 2016 at 05:56:51PM +0800, Xin Long wrote: > On Wed, Aug 24, 2016 at 6:38 PM, Neil Horman wrote: > > On Wed, Aug 24, 2016 at 01:14:27PM +0800, Xin Long wrote: > >> >> > Ah, I see what you're doing. Ok, this makes some sense, at least on > >> >> > the receive > >> >> > side, when y

Re: [PATCH v8 3/8] thunderbolt: Communication with the ICM (firmware)

2016-12-19 Thread Mika Westerberg
On Thu, Dec 01, 2016 at 05:21:01PM -0800, Andy Lutomirski wrote: > On 09/28/2016 07:44 AM, Amir Levy wrote: > > This patch provides the communication protocol between the > > Intel Connection Manager(ICM) firmware that is operational in the > > Thunderbolt controller in non-Apple hardware. > > The

Re: [PATCH] af_unix: fix garbage collect vs. MSG_PEEK

2016-12-19 Thread Miklos Szeredi
On Tue, Oct 4, 2016 at 3:51 AM, David Miller wrote: > From: Miklos Szeredi > Date: Thu, 29 Sep 2016 14:09:14 +0200 > >> @@ -1550,6 +1550,17 @@ static int unix_attach_fds(struct scm_cookie *scm, >> struct sk_buff *skb) >> return max_level; >> } >> >> +static void unix_peek_fds(struct scm_c

Re: Synopsys Ethernet QoS

2016-12-19 Thread Joao Pinto
Às 10:55 AM de 12/19/2016, Joao Pinto escreveu: > > Hi Pavel, > > Às 5:38 PM de 12/17/2016, Pavel Machek escreveu: >> Hi! >> > So if there is a long time before handling interrupts, > I guess that it makes sense that one stream could > get an advantage in the net scheduler. >

Re: Synopsys Ethernet QoS

2016-12-19 Thread Joao Pinto
Hi Pavel, Às 5:38 PM de 12/17/2016, Pavel Machek escreveu: > Hi! > So if there is a long time before handling interrupts, I guess that it makes sense that one stream could get an advantage in the net scheduler. If I find the time, and if no one beats me to it, I will try

Linux support for 802.1AS-Rev.

2016-12-19 Thread Praveen Bajantri
Hello everyone, I am new to Linux networking and had doubt related to support for 802.1AS-Rev. Please point me to appropriate forum/mailing list If this is not a right place. I know that Linux supports gPTP (802.1AS), As there are new clauses added to gPTP to support new features such as one step

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-19 Thread Pavel Machek
Hi! > Lino, have you considered via-rhine.c since its "move work from irq to > workqueue context" changes that started in > 7ab87ff4c770eed71e3777936299292739fcd0fe [*] ? > > It's a shameless plug - originated in r8169.c - but it should be rather > close to what the sxgbe and friends require. Tho

[PATCH net v2 1/5] fsl/fman: fix 1G support for QSGMII interfaces

2016-12-19 Thread Madalin Bucur
QSGMII ports were not advertising 1G speed. Signed-off-by: Madalin Bucur Reviewed-by: Camelia Groza --- drivers/net/ethernet/freescale/fman/mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 69ca

[PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[]

2016-12-19 Thread Madalin Bucur
The fsl/fman drivers will use of_platform_populate() on all supported platforms. Signed-off-by: Madalin Bucur --- arch/powerpc/platforms/85xx/corenet_generic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/coren

[PATCH net v2 0/5] fsl/fman: fixes for ARM

2016-12-19 Thread Madalin Bucur
The patch set fixes advertised speeds for QSGMII interfaces, disables A007273 erratum workaround on non-PowerPC platforms where it does not apply, enables compilation on ARM64 and addresses a probing issue on non PPC platforms. Changes from v1: unifying probing on all supported platforms Igal Lib

[PATCH net v2 3/5] fsl/fman: call of_platform_populate()

2016-12-19 Thread Madalin Bucur
From: Igal Liberman Call of_platform_populate() to probe the FMan sub-nodes. Signed-off-by: Igal Liberman Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drive

[PATCH net v2 4/5] fsl/fman: A007273 only applies to PPC SoCs

2016-12-19 Thread Madalin Bucur
Signed-off-by: Madalin Bucur Reviewed-by: Camelia Groza --- drivers/net/ethernet/freescale/fman/fman.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c index 0b7f711..003b86d 100644 --- a/drivers/

[PATCH net v2 5/5] fsl/fman: enable compilation on ARM64

2016-12-19 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/Kconfig b/drivers/net/ethernet/freescale/fman/Kconfig index 79b7c84..dc0850b 100644 --- a/drivers/net/ethernet/free

Re: [PATCH 5/8] linux: drop __bitwise__ everywhere

2016-12-19 Thread Luca Coelho
On Thu, 2016-12-15 at 07:15 +0200, Michael S. Tsirkin wrote: > __bitwise__ used to mean "yes, please enable sparse checks > unconditionally", but now that we dropped __CHECK_ENDIAN__ > __bitwise is exactly the same. > There aren't many users, replace it by __bitwise everywhere. > > Signed-off-by:

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

2016-12-19 Thread Luca Coelho
On Thu, 2016-12-15 at 07:15 +0200, Michael S. Tsirkin wrote: > That's the default now, no need for makefiles to set it. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/bluetooth/Makefile| 2 -- > drivers/net/can/Makefile | 1

ovs internal_dev mtu

2016-12-19 Thread nickcooper-zhangtonghao
The upstream net-next has removed the “internal_dev_change_mtu”. It will be ok for ovs(e.g. mtu_request) ? I think that code should be keep. Can you provide more information ?

Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

2016-12-19 Thread Johannes Berg
Hi Mike, Thanks for the report. I'm sorry I missed this in review - obviously we can't call something that acquires the mutex from rfkill_set_sw_state() which clearly states, in the documentation:  * This function can be called in any context, even from within rfkill  * callbacks. I've reverted

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-19 Thread Dongpo Li
Hi Rob and David, On 2016/12/12 22:21, Rob Herring wrote: > On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li wrote: >> Hi Rob, >> >> On 2016/12/10 6:35, Rob Herring wrote: >>> On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: The "hix5hd2" is SoC name, add the generic ethernet driver name

<    1   2