Re: [PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS

❦ 24 novembre 2016 10:55 +0100, Miroslav Lichvar  : > The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET > command and likewise it shouldn't require the CAP_NET_ADMIN > capability. Could this patch be pushed to stable branches too? -- Each module should do

[PATCH v2] ipv4: Namespaceify tcp_tw_reuse knob

Different namespaces might have different requirements to reuse TIME-WAIT sockets for new connections. This might be required in cases where different namespace applications are in place which require TIME_WAIT socket connections to be reduced independently of the host. Signed-off-by: Haishuang

Re: [PATCH] ipv4: Namespaceify tcp_tw_reuse knob

From: Haishuang Yan Date: Sat, 24 Dec 2016 20:43:07 +0800 > Signed-off-by: Haishuang Yan You need to provide something more than an empty commit message. Instead, the commit message must explain why this particular sysctl

Re: [PATCH v3 1/2] drivers: net: ethernet: 3com: fix return value

It is never, ever, appropriate to use the same exact Subject: line text for two different changes. Someone looking at "git shortlog" has no way to know what is different between the two changes. You must put care and time into constructing Subject: lines because this text is critical for data

[PATCH v3 1/2] drivers: net: ethernet: 3com: fix return value

In a few cases the err-variable is not set to a negative error code if a function call fails and thus 0 is returned instead. It may be better to set err to the appropriate negative error code before returning. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188841 Reported-by: Pan Bian

Re: Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

Hello. On Sat, 2016-12-24 at 20:06 +0100, Sergei Shtylyov wrote: >Hello! > >On 12/24/2016 03:02 PM, Thomas Preisner wrote: > >> In a few cases the err-variable is not set to a negative error code if a >> function call fails and thus 0 is returned instead. >> It may be better to set err to the

[PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan ---

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

Hello! On 12/19/2016 08:11 PM, Geert Uytterhoeven wrote: One quirk needed for WoL is that the module clock needs to be prevented from being switched off by Runtime PM. To keep the clock alive the I tried to find the code in question and failed, getting muddled in the RPM maze. Could you

Re: [PATCH net] net, sched: fix soft lockup in tc_classify

On 12/24/2016 08:34 AM, Cong Wang wrote: On Thu, Dec 22, 2016 at 4:26 PM, Daniel Borkmann wrote: On 12/22/2016 08:05 PM, Cong Wang wrote: On Wed, Dec 21, 2016 at 1:07 PM, Daniel Borkmann wrote: Ok, you mean for net. In that case I prefer the

Re: [RFC PATCH 4.10 3/6] bpf: Use SHA256 instead of SHA1 for bpf digests

On 12/24/2016 03:22 AM, Andy Lutomirski wrote: BPF digests are intended to be used to avoid reloading programs that are already loaded. For use cases (CRIU?) where untrusted programs are involved, intentional hash collisions could cause the wrong BPF program to execute. Additionally, if BPF

Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

Hello! On 12/24/2016 03:02 PM, Thomas Preisner wrote: In a few cases the err-variable is not set to a negative error code if a function call fails and thus 0 is returned instead. It may be better to set err to the appropriate negative error code before returning. Bugzilla:

Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data

On Saturday 24 December 2016 19:17:30 Pavel Machek wrote: > Hi! > > > In case there is no valid MAC address kernel generates random one. > > This patch propagate this generated MAC address back to NVS data > > which will be uploaded to wl1251 chip. So HW would have same MAC > > address as linux

Re: [PATCH 5/6] wl1251: Parse and use MAC address from supplied NVS data

On Saturday 24 December 2016 19:14:21 Pavel Machek wrote: > On Sat 2016-12-24 17:53:00, Pali Rohár wrote: > > @@ -1581,10 +1598,16 @@ int wl1251_init_ieee80211(struct wl1251 > > *wl) > > > > wl->hw->queues = 4; > > > > + if (wl->nvs == NULL && !wl->use_eeprom) { > > + ret =

Re: [PATCH 4/6] wl1251: Generate random MAC address only if driver does not have valid

On Saturday 24 December 2016 19:08:54 Pavel Machek wrote: > On Sat 2016-12-24 17:52:59, Pali Rohár wrote: > > Before this patch driver generated random MAC address every time > > when was doing initialization. And after that random MAC address > > could be overwritten with fixed one if provided. >

Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data

Hi! > In case there is no valid MAC address kernel generates random one. This > patch propagate this generated MAC address back to NVS data which will be > uploaded to wl1251 chip. So HW would have same MAC address as linux kernel > uses. > return 0; > } > > +static int

Re: [PATCH 5/6] wl1251: Parse and use MAC address from supplied NVS data

On Sat 2016-12-24 17:53:00, Pali Rohár wrote: > This patch implements parsing MAC address from NVS data which are sent to > wl1251 chip. Calibration NVS data could contain valid MAC address and it > will be used instead randomly generated. will be used instead of randomly generated one. > This

Re: [PATCH 4/6] wl1251: Generate random MAC address only if driver does not have valid

On Sat 2016-12-24 17:52:59, Pali Rohár wrote: > Before this patch driver generated random MAC address every time when was > doing initialization. And after that random MAC address could be > overwritten with fixed one if provided. Before this patch, driver generated random MAC address every time

Re: [PATCH 3/6] wl1251: Update wl->nvs_len after wl->nvs is valid

On Sat 2016-12-24 17:52:58, Pali Rohár wrote: > In case kmemdup fails thne wl->nvs_len will contains invalid non-zero size. > This patch fixes it. If kmemdup fails, then wl->nvs_len will contain invalid non-zero size. ? This probably should go as first in series, as it is bugfix?

Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash

On Sat, Dec 24, 2016 at 2:33 AM, Ard Biesheuvel wrote: > Hi Andy, > > On 24 December 2016 at 02:22, Andy Lutomirski wrote: >> There are some pieecs of kernel code that want to compute SHA256 >> directly without going through the crypto core. Adjust

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

On Sat, Dec 24, 2016 at 11:17:18AM -0500, Geoff Lansberry wrote: > Mark - I'm sorry, but I did not write this code, and therefore was not > able to accurately describe it. It is fixing a different issue, not > the neard segfault that we are still chasing. Last week Jaret Cantu > sent a separate

[PATCH 6/6] wl1251: Set generated MAC address back to NVS data

In case there is no valid MAC address kernel generates random one. This patch propagate this generated MAC address back to NVS data which will be uploaded to wl1251 chip. So HW would have same MAC address as linux kernel uses. Signed-off-by: Pali Rohár ---

[PATCH 4/6] wl1251: Generate random MAC address only if driver does not have valid

Before this patch driver generated random MAC address every time when was doing initialization. And after that random MAC address could be overwritten with fixed one if provided. This patch changes order. First it tries to read fixed MAC address and if it fails then driver generates random MAC

[PATCH 5/6] wl1251: Parse and use MAC address from supplied NVS data

This patch implements parsing MAC address from NVS data which are sent to wl1251 chip. Calibration NVS data could contain valid MAC address and it will be used instead randomly generated. This patch also move code for requesting NVS data from userspace to driver initialization code to make sure

[PATCH 1/6] firmware: Add request_firmware_prefer_user() function

This function works pretty much like request_firmware(), but it prefer usermode helper. If usermode helper fails then it fallback to direct access. Useful for dynamic or model specific firmware data. Signed-off-by: Pali Rohár --- drivers/base/firmware_class.c | 45

[PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

NVS calibration data for wl1251 are model specific. Every one device with wl1251 chip has different and calibrated in factory. Not all wl1251 chips have own EEPROM where are calibration data stored. And in that case there is no "standard" place. Every device has stored them on different place

[PATCH 3/6] wl1251: Update wl->nvs_len after wl->nvs is valid

In case kmemdup fails thne wl->nvs_len will contains invalid non-zero size. This patch fixes it. Signed-off-by: Pali Rohár --- drivers/net/wireless/ti/wl1251/main.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 0/6] wl1251: Fix MAC address for Nokia N900

This patch series fix processing MAC address for wl1251 chip found in Nokia N900. Pali Rohár (6): firmware: Add request_firmware_prefer_user() function wl1251: Use request_firmware_prefer_user() for loading NVS calibration data wl1251: Update wl->nvs_len after wl->nvs is valid

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

Mark - I'm sorry, but I did not write this code, and therefore was not able to accurately describe it. It is fixing a different issue, not the neard segfault that we are still chasing. Last week Jaret Cantu sent a separate email explaining the purpose of the code, which had you copied, did you

Re: [PATCH] ipv4: Namespaceify tcp_tw_reuse knob

On 24.12.2016 14:43, Haishuang Yan wrote: > Signed-off-by: Haishuang Yan Reviewed-by: Nikolay Borisov

ATTENTION Quota de messagerie

Votre boite aux lettres a atteint la taille de 270.25Mo, et depasse les 90% de votre quota de 300.00Mo. https://formcrafts.com/a/24769 Cliquez sur le lien ci-dessous pour mettre à jour votre compte maintenant. https://formcrafts.com/a/24769 Postmaster

[PATCH] ipv4: Namespaceify tcp_tw_reuse knob

Signed-off-by: Haishuang Yan --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

In a few cases the err-variable is not set to a negative error code if a function call fails and thus 0 is returned instead. It may be better to set err to the appropriate negative error code before returning. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188841 Reported-by: Pan Bian

Re: [PATCH] drivers: net: ethernet: 3com: fix return value

On Sat, 2016-12-24 at 02:06 +0100, David Dillow wrote: >On Sat, 2016-12-24 at 00:00 +0100, Thomas Preisner wrote: >> diff --git a/drivers/net/ethernet/3com/typhoon.c >> b/drivers/net/ethernet/3com/typhoon.c >> index a0cacbe..9a3ab58 100644 >> --- a/drivers/net/ethernet/3com/typhoon.c >> +++

[PATCH v2 2/2] drivers: net: ethernet: 3com: fix return value

In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan ---

Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash

Hi Andy, On 24 December 2016 at 02:22, Andy Lutomirski wrote: > There are some pieecs of kernel code that want to compute SHA256 > directly without going through the crypto core. Adjust the exported > API to decouple it from the crypto core. > There are a bunch of things

RE: [PATCH] ethtool: add one ethtool option to set relax ordering mode

> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Friday, December 23, 2016 11:43 PM > To: maowenan > Cc: Jeff Kirsher; Stephen Hemminger; netdev@vger.kernel.org; weiyongjun (A); > Dingtianhong > Subject: Re: [PATCH] ethtool: add one ethtool option