Re: [PATCH net-next 1/2] net: dsa: Implement ndo_get_phys_port_name()

2017-01-10 Thread Jiri Pirko
Tue, Jan 10, 2017 at 09:32:36PM CET, f.faine...@gmail.com wrote: >Return the physical port number of a DSA created network device using >ndo_get_phys_port_name(). > >Signed-off-by: Florian Fainelli Reviewed-by: Jiri Pirko >--- > net/dsa/slave.c | 10

Re: [PATCH net-next 2/2] Revert "net: dsa: Implement ndo_get_phys_port_id"

2017-01-10 Thread Jiri Pirko
Tue, Jan 10, 2017 at 09:32:37PM CET, f.faine...@gmail.com wrote: >This reverts commit 3a543ef479868e36c95935de320608a7e41466ca ("net: dsa: >Implement ndo_get_phys_port_id") since it misuses the purpose of >ndo_get_phys_port_id(). We have ndo_get_phys_port_name() to do the >correct thing for us

Re: [PATCH net-next 1/2] net: dsa: Implement ndo_get_phys_port_name()

2017-01-10 Thread Jiri Pirko
Tue, Jan 10, 2017 at 09:58:53PM CET, f.faine...@gmail.com wrote: >On 01/10/2017 12:50 PM, Andrew Lunn wrote: >> On Tue, Jan 10, 2017 at 12:32:36PM -0800, Florian Fainelli wrote: >>> Return the physical port number of a DSA created network device using >>> ndo_get_phys_port_name(). >> >> At what

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-10 Thread Jiri Pirko
Tue, Jan 10, 2017 at 06:58:18PM CET, f.faine...@gmail.com wrote: >On 01/10/2017 01:55 AM, Jiri Pirko wrote: >> Mon, Jan 09, 2017 at 07:06:39PM CET, f.faine...@gmail.com wrote: >>> On 01/09/2017 09:58 AM, Jiri Pirko wrote: Mon, Jan 09, 2017 at 06:42:07PM CET, f.faine...@gmail.com wrote: >

Re: [RFC PATCH 2/4] page_pool: basic implementation of page_pool

2017-01-10 Thread Jesper Dangaard Brouer
On Mon, 9 Jan 2017 21:58:26 + Mel Gorman wrote: > On Mon, Jan 09, 2017 at 09:45:24PM +0100, Jesper Dangaard Brouer wrote: > > > I see. I guess if all page pool pages were order>0 compound pages, you > > > could hook this to the existing compound_dtor

Re: [PATCH net-next v3 10/27] benet: use __vlan_hwaccel helpers

2017-01-10 Thread Somnath Kotur
On Wed, Jan 4, 2017 at 4:41 AM, Michał Mirosław wrote: > > Signed-off-by: Michał Mirosław > --- > v3: fix adapter->pvid handling > > drivers/net/ethernet/emulex/benet/be_main.c | 13 + > 1 file changed, 9 insertions(+), 4

Re: [RFC PATCH] tcp: accept RST for rcv_nxt - 1 after receiving a FIN

2017-01-10 Thread Christoph Paasch
Hello Jason, (resending as Gmail sent out with HTML) On 05/01/17 - 16:33:28, Jason Baron wrote: > Using a Mac OSX box as a client connecting to a Linux server, we have found > that when certain applications (such as 'ab'), are abruptly terminated > (via ^C), a FIN is sent followed by a RST

Re: [PATCH v2 2/2] stmmac: rename it to synopsys

2017-01-10 Thread Jie Deng
Hi Joao, On 2017/1/10 22:52, Joao Pinto wrote: > This patch renames stmicro/stmmac to synopsys/ since it is a standard > ethernet software package regarding synopsys ethernet controllers, supporting > the majority of Synopsys Ethernet IPs. The config IDs remain the same, for >

[PATCH net] gro: use min_t() in skb_gro_reset_offset()

2017-01-10 Thread Eric Dumazet
From: Eric Dumazet On 32bit arches, (skb->end - skb->data) is not 'unsigned int', so we shall use min_t() instead of min() to avoid a compiler error. Fixes: 1272ce87fa01 ("gro: Enter slow-path if there is no tailroom") Reported-by: kernel test robot

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-10 Thread Jason Wang
On 2017年01月10日 13:00, Michael S. Tsirkin wrote: On Mon, Jan 09, 2017 at 08:25:43PM -0800, John Fastabend wrote: On 17-01-09 07:55 PM, Michael S. Tsirkin wrote: On Mon, Jan 09, 2017 at 07:30:34PM -0800, John Fastabend wrote: On 17-01-09 06:51 PM, Michael S. Tsirkin wrote: On Tue, Jan 10,

[PATCH v2] net: netcp: correct netcp_get_stats function signature

2017-01-10 Thread Keerthy
Commit: bc1f44709cf2 - net: make ndo_get_stats64 a void function and Commit: 6a8162e99ef3 - net: netcp: store network statistics in 64 bits. The commit 6a8162e99ef3 adds ndo_get_stats64 function as per old signature which causes compilation error: drivers/net/ethernet/ti/netcp_core.c:1951:28:

Re: [PATCH] net: netcp: correct netcp_get_stats function signature

2017-01-10 Thread Keerthy
On Tuesday 10 January 2017 10:22 PM, David Miller wrote: From: Keerthy Date: Tue, 10 Jan 2017 16:56:25 +0530 @@ -1909,7 +1909,7 @@ static int netcp_setup_tc(struct net_device *dev, u32 handle, __be16 proto, return 0; } -static struct rtnl_link_stats64 * +void

[net:master 16/18] net/core/dev.c:4444:33: note: in expansion of macro 'min'

2017-01-10 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: 6c711c8691bf91d0e830ff4215b08e51c0626769 commit: 1272ce87fa017ca4cf32920764d879656b7a005a [16/18] gro: Enter slow-path if there is no tailroom config: i386-randconfig-x004-201702 (attached as .config) compiler:

Re: [PATCH v2 7/8] net: Rename TCA*BPF_DIGEST to ..._SHA256

2017-01-10 Thread Andy Lutomirski
On Tue, Jan 10, 2017 at 4:50 PM, Daniel Borkmann wrote: > On 01/11/2017 12:24 AM, Andy Lutomirski wrote: >> >> This makes it easier to add another digest algorithm down the road if >> needed. It also serves to force any programs that might have been >> written against a

Re: linux-next: build failure after merge of the selinux tree

2017-01-10 Thread Paul Moore
On Mon, Jan 9, 2017 at 8:27 PM, Stephen Rothwell wrote: > Hi Paul, > > After merging the selinux tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from /home/sfr/next/next/security/selinux/avc.c:35:0: >

Re: [PATCH net 00/10] Mellanox mlx5 fixes and cleanups 2017-01-10

2017-01-10 Thread David Miller
From: Saeed Mahameed Date: Tue, 10 Jan 2017 22:33:29 +0200 > This series includes some mlx5e general cleanups from Daniel, Gil, Hadar > and myself. > Also it includes some critical mlx5e TC offloads fixes from Or Gerlitz. Series applied, thanks. > For -stable: > -

Re: [PATCH net] gro: Disable frag0 optimization on IPv6 ext headers

2017-01-10 Thread David Miller
From: Eric Dumazet Date: Tue, 10 Jan 2017 12:24:15 -0800 > From: Herbert Xu > > The GRO fast path caches the frag0 address. This address becomes > invalid if frag0 is modified by pskb_may_pull or its variants. > So whenever that happens we

Re: [PATCH net] gro: Enter slow-path if there is no tailroom

2017-01-10 Thread David Miller
From: Eric Dumazet Date: Tue, 10 Jan 2017 12:24:01 -0800 > From: Herbert Xu > > The GRO path has a fast-path where we avoid calling pskb_may_pull > and pskb_expand by directly accessing frag0. However, this should > only be done if we have

Re: [PATCH net-next 5/8] net: dsa: Export dev_to_net_device()

2017-01-10 Thread David Miller
From: Florian Fainelli Date: Tue, 10 Jan 2017 12:12:32 -0800 > @@ -491,7 +491,7 @@ struct mii_bus *dsa_host_dev_to_mii_bus(struct device > *dev) > } > EXPORT_SYMBOL_GPL(dsa_host_dev_to_mii_bus); > > -static struct net_device *dev_to_net_device(struct device *dev) >

Re: [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP

2017-01-10 Thread David Miller
From: Martin KaFai Lau Date: Tue, 10 Jan 2017 09:41:49 -0800 > In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus > eth and vlan hdrs"), > it changed EOPNOTSUPP to ENOTSUPP by mistake. This patch fixes it. > > Fixes: b45f0674b997 ("mlx4: xdp: Allow

Re: [PATCH] vxlan: Set flow*_dport when doing route lookups

2017-01-10 Thread David Miller
From: Martynas Pumputis Date: Tue, 10 Jan 2017 17:29:45 + > Otherwise, no xfrm policy with dport being set can be matched. > > Signed-off-by: Martynas Pumputis And likewise you should also be adding the source port, since it is available, to the

Re: [PATCH net 1/1] net/af_iucv: don't use paged skbs for TX on HiperSockets

2017-01-10 Thread David Miller
From: Ursula Braun Date: Tue, 10 Jan 2017 17:10:34 +0100 > From: Julian Wiedmann > > With commit e53743994e21 > ("af_iucv: use paged SKBs for big outbound messages"), > we transmit paged skbs for both of AF_IUCV's transport modes > (IUCV or

Re: [PATCH net] netvsc: add rcu_read locking to netvsc callback

2017-01-10 Thread David Miller
From: Stephen Hemminger Date: Tue, 10 Jan 2017 07:50:16 -0800 > Lockdep finds a case where netvsc receive processing is incorrectly > assuming it is in RCU safe zone. The driver is using RCU to handle > VF reference but RCU read lock not held. > > Fixes 0c9d3ba9a87b

Re: [PATCH net-next] packet: pdiag_put_ring() should return TX_RING info for TPACKET_V3

2017-01-10 Thread David Miller
From: Sowmini Varadhan Date: Tue, 10 Jan 2017 07:47:15 -0800 > Commit 7f953ab2ba46 ("af_packet: TX_RING support for TPACKET_V3") > now makes it possible to use TX_RING with TPACKET_V3, so make the > the relevant information available via 'ss -e -a --packet' > >

Re: [PATCH net-next] bpf: Make unnecessarily global functions static

2017-01-10 Thread David Miller
From: Tobias Klauser Date: Tue, 10 Jan 2017 15:02:16 +0100 > Make the functions __local_list_pop_free(), __local_list_pop_pending(), > bpf_common_lru_populate() and bpf_percpu_lru_populate() static as they > are not used outide of bpf_lru_list.c > > This fixes the following

Re: [PATCH net-next] bpf: Remove unused but set variable in __bpf_lru_list_shrink_inactive()

2017-01-10 Thread David Miller
From: Tobias Klauser Date: Tue, 10 Jan 2017 15:02:07 +0100 > Remove the unused but set variable 'first_node' in > __bpf_lru_list_shrink_inactive() to fix the following GCC warning when > building with 'W=1': > > kernel/bpf/bpf_lru_list.c:216:41: warning: variable

Re: [PATCH net] ipv6: sr: fix BUG in HMAC init when preemption is enabled

2017-01-10 Thread David Miller
From: David Lebrun Date: Tue, 10 Jan 2017 14:39:22 +0100 > When CONFIG_PREEMPT=y, CONFIG_IPV6=m and CONFIG_SEG6_HMAC=y, > seg6_hmac_init() is called during the initialization of the ipv6 module. > This causes a subsequent call to smp_processor_id() with preemption >

Re: [PATCH 3/4] net: ethernet: ti: cpsw: don't duplicate ndev_running

2017-01-10 Thread Ivan Khoronzhuk
On Mon, Jan 09, 2017 at 11:25:38AM -0600, Grygorii Strashko wrote: > > > On 01/08/2017 10:41 AM, Ivan Khoronzhuk wrote: > > No need to create additional vars to identify if interface is running. > > So simplify code by removing redundant var and checking usage counter > > instead. > > > >

Re: [PATCH] net: add the AF_QIPCRTR entries to family name tables

2017-01-10 Thread David Miller
From: Suman Anna Date: Mon, 9 Jan 2017 21:48:56 -0600 > Commit bdabad3e363d ("net: Add Qualcomm IPC router") introduced a > new address family. Update the family name tables accordingly so > that the lockdep initialization can use the proper names for this > family. > > Cc:

Re: [PATCH next v2] ipvlan: improvise dev_id generation logic in IPvlan

2017-01-10 Thread David Miller
From: Mahesh Bandewar Date: Mon, 9 Jan 2017 15:05:54 -0800 > From: Mahesh Bandewar > > The patch 009146d117b ("ipvlan: assign unique dev-id for each slave > device.") used ida_simple_get() to generate dev_ids assigned to the > slave devices. However

Re: [PATCH] net: qrtr: Mark 'buf' as little endian

2017-01-10 Thread David Miller
From: Stephen Boyd Date: Mon, 9 Jan 2017 14:31:58 -0800 > Failure to mark this pointer as __le32 causes checkers like > sparse to complain: > > net/qrtr/qrtr.c:274:16: warning: incorrect type in assignment (different base > types) > net/qrtr/qrtr.c:274:16:expected

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-10 Thread Florian Fainelli
On 01/10/2017 08:08 AM, Ido Schimmel wrote: > On Tue, Jan 10, 2017 at 03:18:07PM +0100, Jiri Pirko wrote: >> Tue, Jan 10, 2017 at 02:25:06PM CET, ido...@idosch.org wrote: >>> On Tue, Jan 10, 2017 at 01:08:46PM +0100, Jiri Pirko wrote: Mon, Jan 09, 2017 at 10:14:36PM CET, ido...@idosch.org

Re: [PATCH net-next 6/7] net: ipv4: return route match in GETROUTE request

2017-01-10 Thread David Miller
From: David Ahern Date: Mon, 9 Jan 2017 13:32:50 -0800 > diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h > index 8c93ad1ef9ab..471384b72cea 100644 > --- a/include/uapi/linux/rtnetlink.h > +++ b/include/uapi/linux/rtnetlink.h > @@ -319,6

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-10 Thread David Miller
From: Florian Fainelli Date: Mon, 9 Jan 2017 12:56:48 -0800 > On 01/09/2017 12:48 PM, Ido Schimmel wrote: >> Hi Florian, >> >> On Mon, Jan 09, 2017 at 11:44:59AM -0800, Florian Fainelli wrote: >>> Hi all, >>> >>> This patch series is to resolve a sleeping function called

Re: [PATCH 7/9] RDS: IB: Remove an unused structure member

2017-01-10 Thread santosh.shilim...@oracle.com
On 1/10/17 4:56 PM, Bart Van Assche wrote: Signed-off-by: Bart Van Assche Acked-by: Santosh Shilimkar

Re: kill off pci_enable_msi_{exact,range}

2017-01-10 Thread David Miller
From: Christoph Hellwig Date: Mon, 9 Jan 2017 21:37:37 +0100 > I had hope that we could kill these old interfaces of for 4.10-rc, > but as of today Linus tree still has two users: > > (1) the cobalt media driver, for which I sent a patch long time ago, > it got missed in the

Re: [PATCH net] net: dsa: Ensure validity of dst->ds[0]

2017-01-10 Thread David Miller
From: Florian Fainelli Date: Mon, 9 Jan 2017 11:58:34 -0800 > It is perfectly possible to have non zero indexed switches being present > in a DSA switch tree, in such a case, we will be deferencing a NULL > pointer while dsa_cpu_port_ethtool_{setup,restore}. Be more

[PATCH net-next 2/6] bnxt_en: Clear TPA flags when BNXT_FLAG_NO_AGG_RINGS is set.

2017-01-10 Thread Michael Chan
Commit bdbd1eb59c56 ("bnxt_en: Handle no aggregation ring gracefully.") introduced the BNXT_FLAG_NO_AGG_RINGS flag. For consistency, bnxt_set_tpa_flags() should also clear TPA flags when there are no aggregation rings. Signed-off-by: Michael Chan ---

[PATCH net-next 4/6] bnxt_en: Add support for ethtool -p.

2017-01-10 Thread Michael Chan
Add LED blinking code to support ethtool -p on the PF. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 40 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 17 +

[PATCH net-next 6/6] bnxt_en: Add the ulp_sriov_cfg hooks for bnxt_re RDMA driver.

2017-01-10 Thread Michael Chan
Add the ulp_sriov_cfg callbacks when the number of VFs is changing. This allows the RDMA driver to provision RDMA resources for the VFs. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH net-next 1/6] bnxt_en: Fix compiler warnings when CONFIG_RFS_ACCEL is not defined.

2017-01-10 Thread Michael Chan
CC [M] drivers/net/ethernet/broadcom/bnxt/bnxt.o drivers/net/ethernet/broadcom/bnxt/bnxt.c:4947:21: warning: ‘bnxt_get_max_func_rss_ctxs’ defined but not used [-Wunused-function] static unsigned int bnxt_get_max_func_rss_ctxs(struct bnxt *bp) ^ CC [M]

[PATCH net-next 5/6] bnxt_en: Pass RoCE app priority to firmware.

2017-01-10 Thread Michael Chan
When the driver gets the RoCE app priority set/delete call through DCBNL, the driver will send the information to the firmware. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 106 +-

[PATCH net-next 0/6] bnxt_en: Misc. updates for net-next.

2017-01-10 Thread Michael Chan
Miscellaneous updates including firmware spec update, ethtool -p blinking LED support, RDMA SRIOV and app TLV support, and minor fixes. Michael Chan (6): bnxt_en: Fix compiler warnings when CONFIG_RFS_ACCEL is not defined. bnxt_en: Clear TPA flags when BNXT_FLAG_NO_AGG_RINGS is set.

[PATCH net-next 3/6] bnxt_en: Update to firmware interface spec to 1.6.1.

2017-01-10 Thread Michael Chan
Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 261 +++--- 1 file changed, 237 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h

Re: [PATCH v2 0/8] Switch BPF's digest to SHA256

2017-01-10 Thread Alexei Starovoitov
On Tue, Jan 10, 2017 at 03:24:38PM -0800, Andy Lutomirski wrote: > I can imagine future uses for the new-in-4.10 BPF digest feature that > would be problematic if malicious users could produce collisions, and > SHA-1 is no longer consdiered to be collision-free. Even without > needing collision

Re: 4.9.2 panic, __skb_flow_dissect, gro?

2017-01-10 Thread David Miller
From: Denys Fedoryshchenko Date: Wed, 11 Jan 2017 01:49:34 +0200 > It seems this patch solve issue. I hope it will go to stable asap, > because without it loaded routers crashing almost instantly on 4.9. I will submit this soon.

[PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-10 Thread Andrew Lunn
Marvell Ethernet switches contain temperature sensors. They are inside the embedded PHYs. Move the code into the PHY driver, so that discrete PHY drivers also export there temperature sensor. Andrew Lunn (2): phy: marvell: Add support for temperature sensor net: dsa: Remove hwmon support

[PATCH net-next 1/2] phy: marvell: Add support for temperature sensor

2017-01-10 Thread Andrew Lunn
Some Marvell PHYs have an inbuilt temperature sensor. Add hwmon support for this sensor. There are two different variants. The simpler, older chips have a 5 degree accuracy. The newer devices have 1 degree accuracy. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 426

[PATCH net-next 2/2] net: dsa: Remove hwmon support

2017-01-10 Thread Andrew Lunn
Only the Marvell mv88e6xxx DSA driver made use of the HWMON support in DSA. The temperature sensor is actually in the embedded PHY, and the PHY driver now supports it. So remove all HWMON support from DSA and drivers. Signed-off-by: Andrew Lunn ---

[PATCH 7/9] RDS: IB: Remove an unused structure member

2017-01-10 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Cc: Santosh Shilimkar Cc: Santosh Shilimkar Cc: David S. Miller Cc: linux-r...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: rds-de...@oss.oracle.com ---

[PATCH 9/9] treewide: Inline ib_dma_map_*() functions

2017-01-10 Thread Bart Van Assche
Almost all changes in this patch except the removal of local variables that became superfluous and the actual removal of the ib_dma_map_*() functions have been generated as follows: git grep -lE 'ib_(sg_|)dma_' | xargs -d\\n \ sed -i -e

Re: [PATCH net-next] bpf: Remove unused but set variable in __bpf_lru_list_shrink_inactive()

2017-01-10 Thread Martin KaFai Lau
On Tue, Jan 10, 2017 at 03:02:07PM +0100, Tobias Klauser wrote: > Remove the unused but set variable 'first_node' in > __bpf_lru_list_shrink_inactive() to fix the following GCC warning when > building with 'W=1': > > kernel/bpf/bpf_lru_list.c:216:41: warning: variable ‘first_node’ set but > not

[PATCH 8/9] IB: Convert ib_dma_*_coherent() argument type from u64 into dma_addr_t

2017-01-10 Thread Bart Van Assche
This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: David S. Miller Cc: linux-r...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: rds-de...@oss.oracle.com --- include/rdma/ib_verbs.h | 11 +++ net/rds/ib.h

Re: [PATCH net-next] bpf: Remove unused but set variable in __bpf_lru_list_shrink_inactive()

2017-01-10 Thread Martin KaFai Lau
On Tue, Jan 10, 2017 at 04:25:23PM -0800, Alexei Starovoitov wrote: > On Tue, Jan 10, 2017 at 03:02:07PM +0100, Tobias Klauser wrote: > > Remove the unused but set variable 'first_node' in > > __bpf_lru_list_shrink_inactive() to fix the following GCC warning when > > building with 'W=1': > > > >

Re: [PATCH v2 7/8] net: Rename TCA*BPF_DIGEST to ..._SHA256

2017-01-10 Thread Daniel Borkmann
On 01/11/2017 12:24 AM, Andy Lutomirski wrote: This makes it easier to add another digest algorithm down the road if needed. It also serves to force any programs that might have been written against a kernel that had the old field name to notice the change and make any necessary changes. This

Re: [PATCH net-next] bpf: Make unnecessarily global functions static

2017-01-10 Thread Martin KaFai Lau
On Tue, Jan 10, 2017 at 04:22:25PM -0800, Alexei Starovoitov wrote: > On Tue, Jan 10, 2017 at 03:02:16PM +0100, Tobias Klauser wrote: > > Make the functions __local_list_pop_free(), __local_list_pop_pending(), > > bpf_common_lru_populate() and bpf_percpu_lru_populate() static as they > > are not

Re: 4.9.2 panic, __skb_flow_dissect, gro?

2017-01-10 Thread Denys Fedoryshchenko
Yes, it is in the list (ixgbe) On 2017-01-11 02:16, Ian Kumlien wrote: Added David Miller to CC since he said it was queued for stable, maybe he can comment On Wed, Jan 11, 2017 at 12:49 AM, Denys Fedoryshchenko wrote: It seems this patch solve issue. I hope it will

Re: [PATCH net-next] bpf: Remove unused but set variable in __bpf_lru_list_shrink_inactive()

2017-01-10 Thread Alexei Starovoitov
On Tue, Jan 10, 2017 at 03:02:07PM +0100, Tobias Klauser wrote: > Remove the unused but set variable 'first_node' in > __bpf_lru_list_shrink_inactive() to fix the following GCC warning when > building with 'W=1': > > kernel/bpf/bpf_lru_list.c:216:41: warning: variable ‘first_node’ set but >

Re: [PATCH net-next] bpf: Make unnecessarily global functions static

2017-01-10 Thread Alexei Starovoitov
On Tue, Jan 10, 2017 at 03:02:16PM +0100, Tobias Klauser wrote: > Make the functions __local_list_pop_free(), __local_list_pop_pending(), > bpf_common_lru_populate() and bpf_percpu_lru_populate() static as they > are not used outide of bpf_lru_list.c > > This fixes the following GCC warnings when

Re: 4.9.2 panic, __skb_flow_dissect, gro?

2017-01-10 Thread Ian Kumlien
Added David Miller to CC since he said it was queued for stable, maybe he can comment On Wed, Jan 11, 2017 at 12:49 AM, Denys Fedoryshchenko wrote: > It seems this patch solve issue. I hope it will go to stable asap, because > without it loaded routers crashing almost

Copyright © 2017 MIcrosoft OUtlook .Inc . All rights reserved.

2017-01-10 Thread Devaraj Veerasamy, Dr
MICROSOFT OUTLOOK NOTIFICATION Your e-mail box account needs to be verify now for irregularities found in your e-mail box account or will be block. Please CLICK HERE to verify your mail box and fill in your complete user name and password

Re: 4.9.2 panic, __skb_flow_dissect, gro?

2017-01-10 Thread Denys Fedoryshchenko
It seems this patch solve issue. I hope it will go to stable asap, because without it loaded routers crashing almost instantly on 4.9. commit d0af683407a26a4437d8fa6e283ea201f2ae8146 (patch) treee769779cf59b0b7b50a68db5d0b8897a7cb6 /net/core/flow_dissector.c parent

[PATCH iproute2] rttable: Fix invalid range checking when table id is converted to u32

2017-01-10 Thread David Ahern
Frank reported that table ids for very large numbers are not properly detected: $ ip li add foobar type vrf table 98765432100123456789 command succeeds and resulting table id is actually: 21: foobar: mtu 65536 qdisc noop state DOWN mode DEFAULT group default qlen 1000

[PATCH v2 7/8] net: Rename TCA*BPF_DIGEST to ..._SHA256

2017-01-10 Thread Andy Lutomirski
This makes it easier to add another digest algorithm down the road if needed. It also serves to force any programs that might have been written against a kernel that had the old field name to notice the change and make any necessary changes. This shouldn't violate any stable API policies, as no

[PATCH v2 8/8] crypto/testmgr: Allocate only the required output size for hash tests

2017-01-10 Thread Andy Lutomirski
There are some hashes (e.g. sha224) that have some internal trickery to make sure that only the correct number of output bytes are generated. If something goes wrong, they could potentially overrun the output buffer. Make the test more robust by allocating only enough space for the correct

4.9.2 panic, __skb_flow_dissect, gro?

2017-01-10 Thread Denys Fedoryshchenko
Hi, Got panic message on 4.9.2 with latest patches from stable-queue, probably it affects all 4.9 version Panic message: dmesg-erst-6374119981415661569:<6>[ 23.110324] ip_set: protocol 6 dmesg-erst-6374119981415661569:<1>[ 28.117455] BUG: unable to handle kernel NULL pointer dereference

[PATCH v2 5/8] bpf: Avoid copying the entire BPF program when hashing it

2017-01-10 Thread Andy Lutomirski
The sha256 helpers can consume a message incrementally, so there's no need to allocate a buffer to store the whole blob to be hashed. This may be a slight slowdown for very long messages because gcc can't inline the sha256_update() calls. For reasonably-sized programs, however, this should be a

[PATCH v2 3/8] crypto/sha256: Build the SHA256 core separately from the crypto module

2017-01-10 Thread Andy Lutomirski
This just moves code around -- no code changes in this patch. This wil let BPF-based tracing link against the SHA256 core code without depending on the crypto core. Cc: Ard Biesheuvel Cc: Herbert Xu Signed-off-by: Andy Lutomirski

[PATCH v2 6/8] bpf: Rename fdinfo's prog_digest to prog_sha256

2017-01-10 Thread Andy Lutomirski
This makes it easier to add another digest algorithm down the road if needed. It also serves to force any programs that might have been written against a kernel that had 'prog_digest' to be updated. This shouldn't violate any stable API policies, as no released kernel has ever had 'prog_digest'.

[PATCH v2 4/8] bpf: Use SHA256 instead of SHA1 for bpf digests

2017-01-10 Thread Andy Lutomirski
SHA1 is considered obsolete. It is no longer considered to be collision resistant and, in general, it should not be used for new applications. Change the new-in-4.10 BPF digest to SHA-256. This means that potential future applications of the digest that need collision resistance will be able to

[PATCH v2 0/8] Switch BPF's digest to SHA256

2017-01-10 Thread Andy Lutomirski
I can imagine future uses for the new-in-4.10 BPF digest feature that would be problematic if malicious users could produce collisions, and SHA-1 is no longer consdiered to be collision-free. Even without needing collision resistance, SHA-1 is no longer recommended for new applications. Switch

[PATCH v2 1/8] crypto/sha256: Factor out the parts of base API that don't use shash_desc

2017-01-10 Thread Andy Lutomirski
I want to expose a minimal SHA256 API that can be used without the depending on the crypto core. To prepare for this, factor out the meat of the sha256_base_*() helpers. Cc: Ard Biesheuvel Cc: Herbert Xu Signed-off-by: Andy Lutomirski

[PATCH v2 2/8] crypto/sha256: Export a sha256_{init,update,final}_direct() API

2017-01-10 Thread Andy Lutomirski
This provides a very simple interface for kernel code to use to do synchronous, unaccelerated, virtual-address-based SHA256 hashing without needing to create a crypto context. Subsequent patches will make this work without building the crypto core and will use to avoid making BPF-based tracing

Re: [PATCH] net: phy: marvell: fix Marvell 88E1512 used in SGMII mode

2017-01-10 Thread Florian Fainelli
On 01/10/2017 03:13 PM, Russell King wrote: > When an Marvell 88E1512 PHY is connected to a nic in SGMII mode, the > fiber page is used for the SGMII host-side connection. The PHY driver > notices that SUPPORTED_FIBRE is set, so it tries reading the fiber page > for the link status, and ends up

[PATCH] net: vrf: do not allow table id 0

2017-01-10 Thread David Ahern
Frank reported that vrf devices can be created with a table id of 0. This breaks many of the run time table id checks and should not be allowed. Detect this condition at create time and fail with EINVAL. Fixes: 193125dbd8eb ("net: Introduce VRF device driver") Reported-by: Frank Kellermann

[PATCH] net: phy: marvell: fix Marvell 88E1512 used in SGMII mode

2017-01-10 Thread Russell King
When an Marvell 88E1512 PHY is connected to a nic in SGMII mode, the fiber page is used for the SGMII host-side connection. The PHY driver notices that SUPPORTED_FIBRE is set, so it tries reading the fiber page for the link status, and ends up reading the MAC-side status instead of the outgoing

[PATCH] sctp: Fix spelling mistake: "Atempt" -> "Attempt"

2017-01-10 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in WARN_ONCE message Signed-off-by: Colin Ian King --- net/sctp/outqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c

WITH ALL DUE RESPECT TO YOUR PERSON

2017-01-10 Thread Lincoln Bah Bah
Dear Friend, With due respect to your person and much sincerity of purpose. I have a business proposal which I will like to handle with you. $35 million USD is involves. But be rest assured that everything is legal and risk free as I have concluded all the arrangements and the legal papers

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-10 Thread Francois Romieu
Eric Dumazet : > On Tue, Jan 10, 2017 at 9:35 AM, Cong Wang wrote: > > On Mon, Jan 9, 2017 at 9:20 AM, Andrey Konovalov > > wrote: > > > > The fix should be straight-forward. Mind to try the attached patch? > > > You

[PATCH net] net: ipv4: Fix multipath selection with vrf

2017-01-10 Thread David Ahern
fib_select_path does not call fib_select_multipath if oif is set in the flow struct. For VRF use cases oif is always set, so multipath route selection is bypassed. Use the FLOWI_FLAG_SKIP_NH_OIF to skip the oif check similar to what is done in fib_table_lookup. Add saddr and proto to the flow

Re: [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP

2017-01-10 Thread Martin KaFai Lau
On Tue, Jan 10, 2017 at 10:04:55PM +0200, Saeed Mahameed wrote: > On Tue, Jan 10, 2017 at 7:41 PM, Martin KaFai Lau wrote: > > In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus > > eth and vlan hdrs"), > > it changed EOPNOTSUPP to ENOTSUPP by mistake. This

Re: [PATCH net-next 6/8] net: dsa: Add support for platform data

2017-01-10 Thread Florian Fainelli
On 01/10/2017 01:21 PM, Andrew Lunn wrote: >> Last time we discussed this, I had a super complex dsa2_platform_data >> that allowed you to do exactly the same thing we currently do with >> Device Tree, except that this was with platform_data. It took a lot of >> effort to get there, but I

Re: [net-next PATCH 1/3] Revert "icmp: avoid allocating large struct on stack"

2017-01-10 Thread Eric Dumazet
On Tue, 2017-01-10 at 21:08 +0100, Jesper Dangaard Brouer wrote: > On Tue, 10 Jan 2017 10:44:59 -0800 Cong Wang wrote: > > > On Tue, Jan 10, 2017 at 10:12 AM, David Miller wrote: > [...] > > > You can keep showing us how expertly you can deflect

Re: [net-next PATCH 1/3] Revert "icmp: avoid allocating large struct on stack"

2017-01-10 Thread Joe Perches
On Tue, 2017-01-10 at 13:12 -0500, David Miller wrote: > From: Cong Wang > Date: Tue, 10 Jan 2017 10:06:01 -0800 > > > On Mon, Jan 9, 2017 at 10:52 AM, David Miller wrote: > >> From: Eric Dumazet > >> Date: Mon, 09 Jan 2017

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-10 Thread Felix Fietkau
On 2017-01-10 11:56, Johannes Berg wrote: > On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote: >> > I wonder if MAC80211 should be doing IGMP snooping and not bridge >> > in this environment. >> >> In the long term, yes.

Re: [PATCH net-next 6/8] net: dsa: Add support for platform data

2017-01-10 Thread Andrew Lunn
> Last time we discussed this, I had a super complex dsa2_platform_data > that allowed you to do exactly the same thing we currently do with > Device Tree, except that this was with platform_data. It took a lot of > effort to get there, but I essentially had the ZII vf160 board example >

Re: [PATCH net-next 6/8] net: dsa: Add support for platform data

2017-01-10 Thread Florian Fainelli
On 01/10/2017 12:41 PM, Andrew Lunn wrote: >> @@ -452,11 +455,14 @@ static int dsa_cpu_parse(struct dsa_port *port, u32 >> index, >> struct net_device *ethernet_dev; >> struct device_node *ethernet; >> >> -ethernet = of_parse_phandle(port->dn, "ethernet", 0); >> -if

Re: [PATCH net-next 1/2] net: dsa: Implement ndo_get_phys_port_name()

2017-01-10 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Tue, Jan 10, 2017 at 12:32:36PM -0800, Florian Fainelli wrote: >> Return the physical port number of a DSA created network device using >> ndo_get_phys_port_name(). > > At what level does this need to be unique? The port name must be unique

Re: [PATCH net-next 1/2] net: dsa: Implement ndo_get_phys_port_name()

2017-01-10 Thread Florian Fainelli
On 01/10/2017 12:50 PM, Andrew Lunn wrote: > On Tue, Jan 10, 2017 at 12:32:36PM -0800, Florian Fainelli wrote: >> Return the physical port number of a DSA created network device using >> ndo_get_phys_port_name(). > > At what level does this need to be unique? This needs to be unique to the

Re: [PATCH net-next 1/2] net: dsa: Implement ndo_get_phys_port_name()

2017-01-10 Thread Andrew Lunn
On Tue, Jan 10, 2017 at 12:32:36PM -0800, Florian Fainelli wrote: > Return the physical port number of a DSA created network device using > ndo_get_phys_port_name(). At what level does this need to be unique? We can have multiple switches within one switch cluster. p->port will be unique within

Re: [PATCH net-next 2/2] Revert "net: dsa: Implement ndo_get_phys_port_id"

2017-01-10 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > This reverts commit 3a543ef479868e36c95935de320608a7e41466ca ("net: dsa: > Implement ndo_get_phys_port_id") since it misuses the purpose of > ndo_get_phys_port_id(). We have ndo_get_phys_port_name() to do the > correct thing for us

Re: [PATCH net-next 1/2] net: dsa: Implement ndo_get_phys_port_name()

2017-01-10 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Return the physical port number of a DSA created network device using > ndo_get_phys_port_name(). > > Signed-off-by: Florian Fainelli Tested-by: Vivien Didelot Thanks,

Re: [PATCH net-next 6/8] net: dsa: Add support for platform data

2017-01-10 Thread Andrew Lunn
> @@ -452,11 +455,14 @@ static int dsa_cpu_parse(struct dsa_port *port, u32 > index, > struct net_device *ethernet_dev; > struct device_node *ethernet; > > - ethernet = of_parse_phandle(port->dn, "ethernet", 0); > - if (!ethernet) > - return -EINVAL; > + if

[PATCH net 00/10] Mellanox mlx5 fixes and cleanups 2017-01-10

2017-01-10 Thread Saeed Mahameed
Hi Dave, This series includes some mlx5e general cleanups from Daniel, Gil, Hadar and myself. Also it includes some critical mlx5e TC offloads fixes from Or Gerlitz. For -stable: - net/mlx5e: Remove WARN_ONCE from adaptive moderation code Although this fix doesn't affect any functionality,

[PATCH net-next 1/2] net: dsa: Implement ndo_get_phys_port_name()

2017-01-10 Thread Florian Fainelli
Return the physical port number of a DSA created network device using ndo_get_phys_port_name(). Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index

[PATCH net 05/10] net/mlx5e: Set inline mode requirements for matching on IP fragments

2017-01-10 Thread Saeed Mahameed
From: Or Gerlitz For e-switch level matching on packets being an IP fragment, we need to make sure the source vport inline mode is L3, fix that. Fixes: 3f7d0eb42d59 ('net/mlx5e: Offload TC matching on packets being IP fragments') Signed-off-by: Or Gerlitz

[PATCH net 01/10] net/mlx5e: Properly handle offloading of source udp port for IP tunnels

2017-01-10 Thread Saeed Mahameed
From: Or Gerlitz We can offload the matching on source udp port of ip tunnels for decapsulation. We can not offload setting source udp port for tunnels as part of encapsulation. Fix both the code that deals with matching offload (decap) and the code that deal with encap

[PATCH net 04/10] net/mlx5e: Properly get address type of encapsulation IP headers

2017-01-10 Thread Saeed Mahameed
From: Or Gerlitz As done elsewhere in our TC/flower offload code, the address type of the encapsulation IP headers should be realized accroding to the addr_type field of the encapsulation control dissector key, do that. Fixes: bbd00f7e2349 ('net/mlx5e: Add TC tunnel

[PATCH net 09/10] net/mlx5e: Remove WARN_ONCE from adaptive moderation code

2017-01-10 Thread Saeed Mahameed
From: Gil Rockah When trying to do interface down or changing interface configuration under heavy traffic, some of the adaptive moderation corner cases can occur and leave a WARN_ONCE call trace in the kernel log. Those WARN_ONCE are meant for debug only, and should have been

[PATCH net 03/10] net/mlx5e: TC ipv4 tunnel encap offload error flow fixes

2017-01-10 Thread Saeed Mahameed
From: Or Gerlitz When the route lookup fails we should return the actual error. When the neigh isn't valid, we should return -EOPNOTSUPP as done in similar cases along the code. When the offload can't take place as of invalid neigh etc, we must release the neigh. Fixes:

  1   2   3   >