Re: kill off pci_enable_msi_{exact,range}

2017-01-12 Thread Christoph Hellwig
On Thu, Jan 12, 2017 at 03:29:00PM -0600, Bjorn Helgaas wrote: > Applied all three (with Tom's ack on the amd-xgbe patch) to pci/msi for > v4.11, thanks! Tom had just send me an event better version of the xgbe patch. Tom, maybe you can resend that relative to the PCI tree [1], so that we don't

Re: [net PATCH v3 3/5] virtio_net: factor out xdp handler for readability

2017-01-12 Thread Jason Wang
On 2017年01月13日 10:51, John Fastabend wrote: At this point the do_xdp_prog is mostly if/else branches handling the different modes of virtio_net. So remove it and handle running the program in the per mode handlers. Signed-off-by: John Fastabend ---

Re: [net PATCH v3 5/5] virtio_net: XDP support for adjust_head

2017-01-12 Thread Jason Wang
On 2017年01月13日 10:52, John Fastabend wrote: Add support for XDP adjust head by allocating a 256B header region that XDP programs can grow into. This is only enabled when a XDP program is loaded. In order to ensure that we do not have to unwind queue headroom push queue setup below

Re: [PATCH net-next] IPsec: do not ignore crypto err in ah input

2017-01-12 Thread Alexander Alemayhu
On Thu, Jan 12, 2017 at 03:33:22PM +0200, Gilad Ben-Yossef wrote: > ah input processing uses the asynchrnous hash crypto API which > supplies an error code as part of the operation completion but > the error code was being ignored. > s/asynchrnous/asynchronous -- Mit freundlichen Grüßen

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread Joe Perches
On Thu, 2017-01-12 at 22:57 -0800, David VomLehn wrote: > On 01/12/2017 09:59 PM, Joe Perches wrote: > > On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote: > > > On 01/12/2017 09:06 PM, Joe Perches wrote: > > > > On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: > > > > > From:

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread David VomLehn
On 01/12/2017 09:59 PM, Joe Perches wrote: On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote: On 01/12/2017 09:06 PM, Joe Perches wrote: On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: From: David VomLehn Patches to create the make and configuration

Re: To netlink or not to netlink, that is the question

2017-01-12 Thread Johannes Berg
On Thu, 2017-01-12 at 20:02 +0100, Jason A. Donenfeld wrote: > Hi Dan, > > Thanks for your response. I'd thought about this, at least for > adding/removing wgpeers/wgipmasks and for configuring wgdevices. This > would fit into multiple smaller messages indeed. > > But what about fetching the

[PATCH net-next v2 4/5] bnxt_en: Add support for ethtool -p.

2017-01-12 Thread Michael Chan
Add LED blinking code to support ethtool -p on the PF. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 40 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 17 +

[PATCH net-next v2 3/5] bnxt_en: Update to firmware interface spec to 1.6.1.

2017-01-12 Thread Michael Chan
Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 261 +++--- 1 file changed, 237 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h

[PATCH net-next v2 0/5] bnxt_en: Misc. updates for net-next.

2017-01-12 Thread Michael Chan
Miscellaneous updates including firmware spec update, ethtool -p blinking LED support, RDMA SRIOV config callback, and minor fixes. v2: Dropped the DCBX RoCE app TLV patch until the ETH_P_IBOE RDMA patch is merged. Michael Chan (5): bnxt_en: Fix compiler warnings when CONFIG_RFS_ACCEL is not

[PATCH net-next v2 2/5] bnxt_en: Clear TPA flags when BNXT_FLAG_NO_AGG_RINGS is set.

2017-01-12 Thread Michael Chan
Commit bdbd1eb59c56 ("bnxt_en: Handle no aggregation ring gracefully.") introduced the BNXT_FLAG_NO_AGG_RINGS flag. For consistency, bnxt_set_tpa_flags() should also clear TPA flags when there are no aggregation rings. Signed-off-by: Michael Chan ---

[PATCH net-next v2 1/5] bnxt_en: Fix compiler warnings when CONFIG_RFS_ACCEL is not defined.

2017-01-12 Thread Michael Chan
CC [M] drivers/net/ethernet/broadcom/bnxt/bnxt.o drivers/net/ethernet/broadcom/bnxt/bnxt.c:4947:21: warning: ‘bnxt_get_max_func_rss_ctxs’ defined but not used [-Wunused-function] static unsigned int bnxt_get_max_func_rss_ctxs(struct bnxt *bp) ^ CC [M]

[PATCH net-next v2 5/5] bnxt_en: Add the ulp_sriov_cfg hooks for bnxt_re RDMA driver.

2017-01-12 Thread Michael Chan
Add the ulp_sriov_cfg callbacks when the number of VFs is changing. This allows the RDMA driver to provision RDMA resources for the VFs. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 5 + 1 file changed, 5 insertions(+) diff

Re: [PATCH] [v2] net: qcom/emac: add ethtool support

2017-01-12 Thread Timur Tabi
Timur Tabi wrote: +static void emac_get_pauseparam(struct net_device *netdev, + struct ethtool_pauseparam *pause) +{ + struct phy_device *phydev = netdev->phydev; + + if (phydev) { + if (phydev->autoneg) +

[PATCH net-next v2 02/13] tcp: new helper for RACK to detect loss

2017-01-12 Thread Yuchung Cheng
Create a new helper tcp_rack_detect_loss to prepare the upcoming RACK reordering timer patch. Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Acked-by: Eric Dumazet --- include/net/tcp.h | 3 +--

[PATCH net-next v2 03/13] tcp: record most recent RTT in RACK loss detection

2017-01-12 Thread Yuchung Cheng
Record the most recent RTT in RACK. It is often identical to the "ca_rtt_us" values in tcp_clean_rtx_queue. But when the packet has been retransmitted, RACK choses to believe the ACK is for the (latest) retransmitted packet if the RTT is over minimum RTT. This requires passing the arrival time of

[PATCH net-next v2 04/13] tcp: add reordering timer in RACK loss detection

2017-01-12 Thread Yuchung Cheng
This patch makes RACK install a reordering timer when it suspects some packets might be lost, but wants to delay the decision a little bit to accomodate reordering. It does not create a new timer but instead repurposes the existing RTO timer, because both are meant to retransmit packets.

[PATCH net-next v2 07/13] tcp: enable RACK loss detection to trigger recovery

2017-01-12 Thread Yuchung Cheng
This patch changes two things: 1. Start fast recovery with RACK in addition to other heuristics (e.g., DUPACK threshold, FACK). Prior to this change RACK is enabled to detect losses only after the recovery has started by other algorithms. 2. Disable TCP early retransmit. RACK subsumes

[PATCH net-next v2 12/13] tcp: remove thin_dupack feature

2017-01-12 Thread Yuchung Cheng
Thin stream DUPACK is to start fast recovery on only one DUPACK provided the connection is a thin stream (i.e., low inflight). But this older feature is now subsumed with RACK. If a connection receives only a single DUPACK, RACK would arm a reordering timer and soon starts fast recovery instead

[PATCH net-next v2 06/13] tcp: check undo conditions before detecting losses

2017-01-12 Thread Yuchung Cheng
Currently RACK would mark loss before the undo operations in TCP loss recovery. This could incorrectly identify real losses as spurious. For example a sender first experiences a delay spike and then eventually some packets were lost due to buffer overrun. In this case, the sender should perform

[PATCH net-next v2 13/13] tcp: disable fack by default

2017-01-12 Thread Yuchung Cheng
This patch disables FACK by default as RACK is the successor of FACK (inspired by the insights behind FACK). FACK[1] in Linux works as follows: a packet P is deemed lost, if packet Q of higher sequence is s/acked and P and Q are distant by at least dupthresh number of packets in sequence space.

[PATCH net-next v2 10/13] tcp: remove early retransmit

2017-01-12 Thread Yuchung Cheng
This patch removes the support of RFC5827 early retransmit (i.e., fast recovery on small inflight with <3 dupacks) because it is subsumed by the new RACK loss detection. More specifically when RACK receives DUPACKs, it'll arm a reordering timer to start fast recovery after a quarter of (min)RTT,

[PATCH net-next v2 11/13] tcp: remove RFC4653 NCR

2017-01-12 Thread Yuchung Cheng
This patch removes the (partial) implementation of the aggressive limited transmit in RFC4653 TCP Non-Congestion Robustness (NCR). NCR is a mitigation to the problem created by the dynamic DUPACK threshold. With the current adaptive DUPACK threshold (tp->reordering) could cause timeouts by

[PATCH net-next v2 00/13] tcp: RACK fast recovery

2017-01-12 Thread Yuchung Cheng
The patch set enables RACK loss detection (draft-ietf-tcpm-rack-01) to trigger fast recovery with a reordering timer. Previously RACK has been running in auxiliary mode where it is used to detect packet losses once the recovery has triggered by other algorithms (e.g., FACK). By inspecting packet

[PATCH net-next v2 05/13] tcp: use sequence to break TS ties for RACK loss detection

2017-01-12 Thread Yuchung Cheng
The packets inside a jumbo skb (e.g., TSO) share the same skb timestamp, even though they are sent sequentially on the wire. Since RACK is based on time, it can not detect some packets inside the same skb are lost. However, we can leverage the packet sequence numbers as extended timestamps to

[PATCH net-next v2 09/13] tcp: remove forward retransmit feature

2017-01-12 Thread Yuchung Cheng
Forward retransmit is an esoteric feature in RFC3517 (condition(3) in the NextSeg()). Basically if a packet is not considered lost by the current criteria (# of dupacks etc), but the congestion window has room for more packets, then retransmit this packet. However it actually conflicts with the

[PATCH net-next v2 01/13] tcp: new helper function for RACK loss detection

2017-01-12 Thread Yuchung Cheng
Create a new helper tcp_rack_mark_skb_lost to prepare the upcoming RACK reordering timer support. Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Acked-by: Eric Dumazet --- net/ipv4/tcp_recovery.c | 21

[PATCH net-next v2 08/13] tcp: extend F-RTO to catch more spurious timeouts

2017-01-12 Thread Yuchung Cheng
Current F-RTO reverts cwnd reset whenever a never-retransmitted packet was (s)acked. The timeout can be declared spurious because the packets acknoledged with this ACK was transmitted before the timeout, so clearly not all the packets are lost to reset the cwnd. This nice detection does not

Re: [net-next 01/13] tcp: new helper function for RACK loss detection

2017-01-12 Thread Yuchung Cheng
On Thu, Jan 12, 2017 at 10:03 PM, Yuchung Cheng wrote: > > Create a new helper tcp_rack_mark_skb_lost to prepare the > upcoming RACK reordering timer support. > > Signed-off-by: Yuchung Cheng > Signed-off-by: Neal Cardwell > Acked-by:

[net-next 07/13] tcp: enable RACK loss detection to trigger recovery

2017-01-12 Thread Yuchung Cheng
This patch changes two things: 1. Start fast recovery with RACK in addition to other heuristics (e.g., DUPACK threshold, FACK). Prior to this change RACK is enabled to detect losses only after the recovery has started by other algorithms. 2. Disable TCP early retransmit. RACK subsumes

[net-next 11/13] tcp: remove RFC4653 NCR

2017-01-12 Thread Yuchung Cheng
This patch removes the (partial) implementation of the aggressive limited transmit in RFC4653 TCP Non-Congestion Robustness (NCR). NCR is a mitigation to the problem created by the dynamic DUPACK threshold. With the current adaptive DUPACK threshold (tp->reordering) could cause timeouts by

[net-next 08/13] tcp: extend F-RTO to catch more spurious timeouts

2017-01-12 Thread Yuchung Cheng
Current F-RTO reverts cwnd reset whenever a never-retransmitted packet was (s)acked. The timeout can be declared spurious because the packets acknoledged with this ACK was transmitted before the timeout, so clearly not all the packets are lost to reset the cwnd. This nice detection does not

[net-next 05/13] tcp: use sequence to break TS ties for RACK loss detection

2017-01-12 Thread Yuchung Cheng
The packets inside a jumbo skb (e.g., TSO) share the same skb timestamp, even though they are sent sequentially on the wire. Since RACK is based on time, it can not detect some packets inside the same skb are lost. However, we can leverage the packet sequence numbers as extended timestamps to

[net-next 12/13] tcp: remove thin_dupack feature

2017-01-12 Thread Yuchung Cheng
Thin stream DUPACK is to start fast recovery on only one DUPACK provided the connection is a thin stream (i.e., low inflight). But this older feature is now subsumed with RACK. If a connection receives only a single DUPACK, RACK would arm a reordering timer and soon starts fast recovery instead

[net-next 06/13] tcp: check undo conditions before detecting losses

2017-01-12 Thread Yuchung Cheng
Currently RACK would mark loss before the undo operations in TCP loss recovery. This could incorrectly identify real losses as spurious. For example a sender first experiences a delay spike and then eventually some packets were lost due to buffer overrun. In this case, the sender should perform

[net-next 02/13] tcp: new helper for RACK to detect loss

2017-01-12 Thread Yuchung Cheng
Create a new helper tcp_rack_detect_loss to prepare the upcoming RACK reordering timer patch. Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Acked-by: Eric Dumazet --- include/net/tcp.h | 3 +--

[net-next 04/13] tcp: add reordering timer in RACK loss detection

2017-01-12 Thread Yuchung Cheng
This patch makes RACK install a reordering timer when it suspects some packets might be lost, but wants to delay the decision a little bit to accomodate reordering. It does not create a new timer but instead repurposes the existing RTO timer, because both are meant to retransmit packets.

[net-next 13/13] tcp: disable fack by default

2017-01-12 Thread Yuchung Cheng
This patch disables FACK by default as RACK is the successor of FACK (inspired by the insights behind FACK). FACK[1] in Linux works as follows: a packet P is deemed lost, if packet Q of higher sequence is s/acked and P and Q are distant by at least dupthresh number of packets in sequence space.

[net-next 01/13] tcp: new helper function for RACK loss detection

2017-01-12 Thread Yuchung Cheng
Create a new helper tcp_rack_mark_skb_lost to prepare the upcoming RACK reordering timer support. Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Acked-by: Eric Dumazet --- net/ipv4/tcp_recovery.c | 21

[net-next 09/13] tcp: remove forward retransmit feature

2017-01-12 Thread Yuchung Cheng
Forward retransmit is an esoteric feature in RFC3517 (condition(3) in the NextSeg()). Basically if a packet is not considered lost by the current criteria (# of dupacks etc), but the congestion window has room for more packets, then retransmit this packet. However it actually conflicts with the

[net-next 10/13] tcp: remove early retransmit

2017-01-12 Thread Yuchung Cheng
This patch removes the support of RFC5827 early retransmit (i.e., fast recovery on small inflight with <3 dupacks) because it is subsumed by the new RACK loss detection. More specifically when RACK receives DUPACKs, it'll arm a reordering timer to start fast recovery after a quarter of (min)RTT,

[net-next 03/13] tcp: record most recent RTT in RACK loss detection

2017-01-12 Thread Yuchung Cheng
Record the most recent RTT in RACK. It is often identical to the "ca_rtt_us" values in tcp_clean_rtx_queue. But when the packet has been retransmitted, RACK choses to believe the ACK is for the (latest) retransmitted packet if the RTT is over minimum RTT. This requires passing the arrival time of

[net-next 00/13] RACK fast recovery

2017-01-12 Thread Yuchung Cheng
The patch set enables RACK loss detection (draft-ietf-tcpm-rack-01) to trigger fast recovery with a reordering timer. Previously RACK has been running in auxiliary mode where it is used to detect packet losses once the recovery has triggered by other algorithms (e.g., FACK). By inspecting packet

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread Joe Perches
On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote: > On 01/12/2017 09:06 PM, Joe Perches wrote: > > On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: > > > From: David VomLehn > > > > > > Patches to create the make and configuration files. > > > > This patch

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread David VomLehn
On 01/12/2017 09:06 PM, Joe Perches wrote: On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: From: David VomLehn Patches to create the make and configuration files. This patch should _really_ be the last in the series not the first. Could you explain the basis

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread Joe Perches
On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: > From: David VomLehn > > Patches to create the make and configuration files. This patch should _really_ be the last in the series not the first.

[PATCH v5 03/13] net: ethernet: aquantia: Add ring support code

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add code to support the transmit and receive ring buffers. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v5 02/13] net: ethernet: aquantia: Common functions and definitions

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add files containing the functions and definitions used in common in different functional areas. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel

[PATCH v5 07/13] net: ethernet: aquantia: Vector operations

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add functions to manululate the vector of receive and transmit rings. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel.Belous

[PATCH v5 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

2017-01-12 Thread Alexander Loktionov
From: David VomLehn v1: Initial version v2: o Make necessary drivers/net/ethernet changes to integrate software o Drop intermediate atlantic directory o Remove Makefile things only appropriate to out of tree module building v3: o Move changes to

[PATCH v5 10/13] net: ethernet: aquantia: Hardware interface and utility functions

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add functions to interface with the hardware and some utility functions. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v5 09/13] net: ethernet: aquantia: Atlantic hardware abstraction layer

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add common functions for Atlantic hardware abstraction layer. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v5 08/13] net: ethernet: aquantia: PCI operations

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add functions that handle the PCI bus interface. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by:

[PATCH v5 11/13] net: ethernet: aquantia: Ethtool support

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add the driver interfaces required for support by the ethtool utility. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v5 13/13] net: ethernet: aquantia: Integrate AQtion 2.5/5 GB NIC driver

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Modify the drivers/net/ethernet/{Makefile,Kconfig} file to make them a part of the network drivers build. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by:

[PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Patches to create the make and configuration files. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v5 06/13] net: ethernet: aquantia: Atlantic A0 and B0 specific functions.

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add Atlantic A0 and B0 specific functions. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry

[PATCH v5 05/13] net: ethernet: aquantia: Support for NIC-specific code

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add support for code specific to the Atlantic NIC. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v5 12/13] net: ethernet: aquantia: Receive side scaling

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add definitions that support receive side scaling. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

Re: [PATCH net-next v2 05/10] drivers: base: Add device_find_class()

2017-01-12 Thread David Miller
From: Florian Fainelli Date: Thu, 12 Jan 2017 14:50:39 -0800 > Well, this is really so that we don't need to cast the arguments passed > to device_find_child(), which takes a void *data as well. Aha, I didn't catch that, my bad.

Re: [RFC] [PATCH] audit: log 32-bit socketcalls

2017-01-12 Thread Richard Guy Briggs
On 2017-01-12 16:32, Paul Moore wrote: > On Thu, Jan 12, 2017 at 7:36 AM, Richard Guy Briggs wrote: > > 32-bit socketcalls were not being logged by audit on x86_64 systems. > > Log them. > > > > See: https://github.com/linux-audit/audit-kernel/issues/14 > > > > Signed-off-by:

Re: [net PATCH v3 1/5] virtio_net: use dev_kfree_skb for small buffer XDP receive

2017-01-12 Thread Jason Wang
On 2017年01月13日 10:50, John Fastabend wrote: In the small buffer case during driver unload we currently use put_page instead of dev_kfree_skb. Resolve this by adding a check for virtnet mode when checking XDP queue type. Also name the function so that the code reads correctly to match the

Re: [net PATCH v2 0/5] virtio_net XDP fixes and adjust_header support

2017-01-12 Thread John Fastabend
On 17-01-12 04:34 PM, John Fastabend wrote: > This has a fix to handle small buffer free logic correctly and then > also adds adjust head support. > > I pushed adjust head at net (even though its rc3) to avoid having > to push another exception case into virtio_net to catch if the > program uses

[net PATCH v3 5/5] virtio_net: XDP support for adjust_head

2017-01-12 Thread John Fastabend
Add support for XDP adjust head by allocating a 256B header region that XDP programs can grow into. This is only enabled when a XDP program is loaded. In order to ensure that we do not have to unwind queue headroom push queue setup below bpf_prog_add. It reads better to do a prog ref unwind vs

[net PATCH v3 3/5] virtio_net: factor out xdp handler for readability

2017-01-12 Thread John Fastabend
At this point the do_xdp_prog is mostly if/else branches handling the different modes of virtio_net. So remove it and handle running the program in the per mode handlers. Signed-off-by: John Fastabend --- drivers/net/virtio_net.c | 76

[net PATCH v3 4/5] virtio_net: remove duplicate queue pair binding in XDP

2017-01-12 Thread John Fastabend
Factor out qp assignment. Signed-off-by: John Fastabend --- drivers/net/virtio_net.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index ec54644..6041828 100644 ---

[net PATCH v3 2/5] net: virtio: wrap rtnl_lock in test for calling with lock already held

2017-01-12 Thread John Fastabend
For XDP use case and to allow ethtool reset tests it is useful to be able to use reset routines from contexts where rtnl lock is already held. Signed-off-by: John Fastabend --- drivers/net/virtio_net.c | 16 +--- 1 file changed, 9 insertions(+), 7

[net PATCH v3 0/5] virtio_net XDP fixes and adjust_header support

2017-01-12 Thread John Fastabend
This has a fix to handle small buffer free logic correctly and then also adds adjust head support. I pushed adjust head at net (even though its rc3) to avoid having to push another exception case into virtio_net to catch if the program uses adjust_head and then block it. If there are any strong

[net PATCH v3 1/5] virtio_net: use dev_kfree_skb for small buffer XDP receive

2017-01-12 Thread John Fastabend
In the small buffer case during driver unload we currently use put_page instead of dev_kfree_skb. Resolve this by adding a check for virtnet mode when checking XDP queue type. Also name the function so that the code reads correctly to match the additional check. Signed-off-by: John Fastabend

Re: [PATCH net-next v2 00/10] net: dsa: Support for pdata in dsa2

2017-01-12 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Hi all, > > This is not exactly new, and was sent before, although back then, I did not > have an user of the pre-declared MDIO board information, but now we do. Note > that I have additional changes queued up to have b53 register

Re: [PATCH iproute2] Add support for rt_protos.d

2017-01-12 Thread David Ahern
On 1/12/17 6:27 PM, Stephen Hemminger wrote: >> diff --git a/etc/iproute2/rt_protos.d/README >> b/etc/iproute2/rt_protos.d/README >> new file mode 100644 >> index ..723509ce56b6 >> --- /dev/null >> +++ b/etc/iproute2/rt_protos.d/README >> @@ -0,0 +1,3 @@ >> +Each file in this

Re: [PATCH] i40e: Invoke softirqs after napi_reschedule

2017-01-12 Thread Benjamin Poirier
On 2017/01/12 17:15, Eric Dumazet wrote: > On Thu, 2017-01-12 at 17:04 -0800, Benjamin Poirier wrote: > > The following message is logged from time to time when using i40e: > > NOHZ: local_softirq_pending 08 > > > > i40e may schedule napi from a workqueue. Afterwards, softirqs are not run > > in

Re: [PATCH iproute2/net-next 0/2] net/sched: cls_flower: Support matching ARP

2017-01-12 Thread Stephen Hemminger
On Thu, 12 Jan 2017 09:11:57 +0100 Simon Horman wrote: > Add support for support matching on ARP operation, and hardware and > protocol addresses for Ethernet hardware and IPv4 protocol addresses. > > Changes since RFC: > * Drop RFC designation; kernel patches are

Re: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics

2017-01-12 Thread Stephen Hemminger
On Thu, 12 Jan 2017 15:49:50 +0200 Nogah Frankel wrote: > The default stats for ifstat are 32 bits based. > The kernel supports 64 bits based stats. (They are returned in struct > rtnl_link_stats64 which is an exact copy of struct rtnl_link_stats, in > which the "normal"

Re: [PATCH iproute2] bridge: fdb: add state filter support

2017-01-12 Thread Stephen Hemminger
On Thu, 12 Jan 2017 17:47:39 +0100 Nikolay Aleksandrov wrote: > This patch adds a new argument to the bridge fdb show command that allows > to filter by entry state. > Also update the man page to include all available show arguments. > > Signed-off-by: Nikolay

Re: [PATCH iproute2] rttable: Fix invalid range checking when table id is converted to u32

2017-01-12 Thread Stephen Hemminger
On Tue, 10 Jan 2017 15:33:55 -0800 David Ahern wrote: > Frank reported that table ids for very large numbers are not properly > detected: > $ ip li add foobar type vrf table 98765432100123456789 > > command succeeds and resulting table id is actually: > > 21: foobar:

Re: [PATCH iproute2] ip6tunnel: Align ipv6 tunnel key display with ipv4

2017-01-12 Thread Stephen Hemminger
On Tue, 10 Jan 2017 10:45:54 + David Forster wrote: > Show ipv6 tunnel keys on presence of GRE_KEY flag for tunnel types > other than GRE. Aligns ipv6 behaviour with ipv4. > > Signed-off-by: dfors...@brocade.com Applied thanks.

Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

2017-01-12 Thread Jeff Epler
On Thu, Jan 12, 2017 at 05:32:09PM +0100, Nicolas Dichtel wrote: > What I was trying to say is that I export those directories like other are. > Removing those files is not related to that series. Perhaps the correct solution is to only copy files matching "*.h" to reduce the risk of copying

Re: [PATCH iproute2] Add support for rt_protos.d

2017-01-12 Thread Stephen Hemminger
On Mon, 9 Jan 2017 15:43:09 -0800 David Ahern wrote: > Add support for reading proto id/name mappings from rt_protos.d > directory. Allows users to have custom protocol values converted > to human friendly names. > > Each file under rt_protos.d has the 'id name'

Re: [PATCH] i40e: Invoke softirqs after napi_reschedule

2017-01-12 Thread Eric Dumazet
On Thu, 2017-01-12 at 17:04 -0800, Benjamin Poirier wrote: > The following message is logged from time to time when using i40e: > NOHZ: local_softirq_pending 08 > > i40e may schedule napi from a workqueue. Afterwards, softirqs are not run > in a deterministic time frame. The problem is the same

Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

2017-01-12 Thread Dilger, Andreas
> On Jan 12, 2017, at 08:37, Michal Hocko wrote: > > From: Michal Hocko > > There are many code paths opencoding kvmalloc. Let's use the helper > instead. The main difference to kvmalloc is that those users are usually > not considering all the aspects of

[PATCH] i40e: Invoke softirqs after napi_reschedule

2017-01-12 Thread Benjamin Poirier
The following message is logged from time to time when using i40e: NOHZ: local_softirq_pending 08 i40e may schedule napi from a workqueue. Afterwards, softirqs are not run in a deterministic time frame. The problem is the same as what was described in commit ec13ee80145c ("virtio_net: invoke

[net PATCH v2 2/5] net: virtio: wrap rtnl_lock in test for calling with lock already held

2017-01-12 Thread John Fastabend
For XDP use case and to allow ethtool reset tests it is useful to be able to use reset routines from contexts where rtnl lock is already held. Signed-off-by: John Fastabend --- drivers/net/virtio_net.c | 16 +--- 1 file changed, 9 insertions(+), 7

[net PATCH v2 1/5] virtio_net: use dev_kfree_skb for small buffer XDP receive

2017-01-12 Thread John Fastabend
In the small buffer case during driver unload we currently use put_page instead of dev_kfree_skb. Resolve this by adding a check for virtnet mode when checking XDP queue type. Also name the function so that the code reads correctly to match the additional check. Signed-off-by: John Fastabend

[net PATCH v2 0/5] virtio_net XDP fixes and adjust_header support

2017-01-12 Thread John Fastabend
This has a fix to handle small buffer free logic correctly and then also adds adjust head support. I pushed adjust head at net (even though its rc3) to avoid having to push another exception case into virtio_net to catch if the program uses adjust_head and then block it. If there are any strong

[PATCH net] openvswitch: maintain correct checksum state in conntrack actions

2017-01-12 Thread Lance Richardson
When executing conntrack actions on skbuffs with checksum mode CHECKSUM_COMPLETE, the checksum must be updated to account for header pushes and pulls. Otherwise we get "hw csum failure" logs similar to this (ICMP packet received on geneve tunnel via ixgbe NIC): [ 405.740065] genev_sys_6081: hw

[PATCH net-next] liquidio: use fallback for selecting txq

2017-01-12 Thread Felix Manlunas
From: Satanand Burla Remove assignment to ndo_select_queue so that fallback is used for selecting txq. Also remove the now-useless function that used to be assigned to ndo_select_queue. Signed-off-by: Satanand Burla Signed-off-by: Felix

Re: [Patch net] atm: remove an unnecessary loop

2017-01-12 Thread Cong Wang
On Thu, Jan 12, 2017 at 4:07 PM, Francois Romieu wrote: > Cong Wang : > [...] >> diff --git a/net/atm/common.c b/net/atm/common.c >> index a3ca922..7ec3bbc 100644 >> --- a/net/atm/common.c >> +++ b/net/atm/common.c >> @@ -72,10 +72,11 @@ static

Re: [Patch net] atm: remove an unnecessary loop

2017-01-12 Thread Francois Romieu
Cong Wang : [...] > diff --git a/net/atm/common.c b/net/atm/common.c > index a3ca922..7ec3bbc 100644 > --- a/net/atm/common.c > +++ b/net/atm/common.c > @@ -72,10 +72,11 @@ static struct sk_buff *alloc_tx(struct atm_vcc *vcc, > unsigned int size) >

Re: [net PATCH 5/5] virtio_net: XDP support for adjust_head

2017-01-12 Thread John Fastabend
On 17-01-12 02:22 PM, Michael S. Tsirkin wrote: > On Thu, Jan 12, 2017 at 01:45:19PM -0800, John Fastabend wrote: >> Add support for XDP adjust head by allocating a 256B header region >> that XDP programs can grow into. This is only enabled when a XDP >> program is loaded. >> >> In order to ensure

Re: [PATCH] can: Fix kernel panic at security_sock_rcv_skb

2017-01-12 Thread Eric Dumazet
On Thu, 2017-01-12 at 14:40 -0800, william.c.robe...@intel.com wrote: > From: Zhang Yanmin > > The patch is for fix the below kernel panic: > BUG: unable to handle kernel NULL pointer dereference at (null) > IP: [] selinux_socket_sock_rcv_skb+0x65/0x2a0 Same patch was

Re: [PATCH] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-12 Thread Vineeth Remanan Pillai
On 01/12/2017 12:17 PM, David Miller wrote: From: Vineeth Remanan Pillai Date: Wed, 11 Jan 2017 23:17:17 + @@ -1054,7 +1059,11 @@ static int xennet_poll(struct napi_struct *napi, int budget) napi_complete(napi);

[PATCH net-next] net: dsa: mv88e6xxx: add EEPROM support to 6390

2017-01-12 Thread Vivien Didelot
The Marvell 6352 chip has a 8-bit address/16-bit data EEPROM access. The Marvell 6390 chip has a 16-bit address/8-bit data EEPROM access. This patch implements the 8-bit data EEPROM access in the mv88e6xxx driver and adds its support to chips of the 6390 family. Signed-off-by: Vivien Didelot

[�PATCH net-next] ARM: dts: vf610-zii-dev: add EEPROM entry to Rev B

2017-01-12 Thread Vivien Didelot
The ZII Dev Rev B board has EEPROMs hanging the 88E6352 Ethernet switch chips. Add an "eeprom-length" property to allow access from ethtool. Signed-off-by: Vivien Didelot --- arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH] ARM: dts: am57xx-beagle-x15: implement errata "Ethernet RGMII2 Limited to 10/100 Mbps"

2017-01-12 Thread Tony Lindgren
* Grygorii Strashko [170112 09:15]: > According to errata i880 description the speed of Ethernet port 1 on AM572x > SoCs rev 1.1 shuld be limited to 10/100Mbps, because RGMII2 Switching > Characteristics are not compatible with 1000 Mbps operation [1]. > The issue is

Re: [PATCH net-next v2 05/10] drivers: base: Add device_find_class()

2017-01-12 Thread Florian Fainelli
On 01/12/2017 01:21 PM, David Miller wrote: > From: Florian Fainelli > Date: Wed, 11 Jan 2017 19:41:16 -0800 > >> Add a helper function to lookup a device reference given a class name. >> This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and >> make it

Re: [PATCH v2] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Eric Dumazet
On Thu, 2017-01-12 at 14:24 -0800, Shannon Nelson wrote: > Fix up a data alignment issue on sparc by swapping the order > of the cookie byte array field with the length field in > struct tcp_fastopen_cookie, and making it a proper union > to clean up the typecasting. > > This addresses log

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-12 Thread Kwok, WingMan
Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, January 12, 2017 4:50 PM > To: Kwok, WingMan > Cc: rmk+ker...@arm.linux.org.uk; Karicheri, Muralidharan; > netdev@vger.kernel.org > Subject: Re: Marvell Phy (1510) issue since v4.7 kernel > > >

Re: [net-next PATCH 1/3] Revert "icmp: avoid allocating large struct on stack"

2017-01-12 Thread Cong Wang
On Tue, Jan 10, 2017 at 10:54 AM, David Miller wrote: > From: Cong Wang > Date: Tue, 10 Jan 2017 10:44:59 -0800 >> The only countries you hold netdev are Canada, Japan and Spain >> (to my knowledge). If you check: >> >>

[PATCH] can: Fix kernel panic at security_sock_rcv_skb

2017-01-12 Thread william . c . roberts
From: Zhang Yanmin The patch is for fix the below kernel panic: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [] selinux_socket_sock_rcv_skb+0x65/0x2a0 Call Trace: [] security_sock_rcv_skb+0x4c/0x60 [] sk_filter+0x41/0x210 []

  1   2   3   4   >