pull request: bluetooth 2017-01-16

2017-01-15 Thread Johan Hedberg
Hi Dave, Here are a couple of important 802.15.4 driver fixes for the 4.10 kernel. Please let me know if there are any issues pulling. Thanks. Johan --- The following changes since commit 8a430ed50bb1b19ca14a46661f3b1b35f2fb5c39: net: ipv4: fix table id in getroute response (2017-01-12

Re: [PATCH net-next] net/sched: cls_flower: Add user specified data

2017-01-15 Thread Paul Blakey
On 15/01/2017 21:08, John Fastabend wrote: On 17-01-15 09:36 AM, Paul Blakey wrote: On 08/01/2017 19:12, Jiri Pirko wrote: Mon, Jan 02, 2017 at 03:59:49PM CET, j...@mojatatu.com wrote: We have been using a cookie as well for actions (which we have been using but have been too lazy to

Re: [PATCH v2 net-next] IPsec: do not ignore crypto err in ah input

2017-01-15 Thread Steffen Klassert
On Sun, Jan 15, 2017 at 08:09:43AM +0200, Gilad Ben-Yossef wrote: > ah input processing uses the asynchronous hash crypto API which supplies > an error code as part of the operation completion but the error code was > being ignored. > > Treat a crypto API error indication as a verification

Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

2017-01-15 Thread Michal Hocko
On Sat 14-01-17 12:56:32, Leon Romanovsky wrote: [...] > Hi Michal, > > I don't see mlx5_vzalloc in the changed list. Any reason why did you skip it? > > 881 static inline void *mlx5_vzalloc(unsigned long size) > 882 { > 883 void *rtn; > 884 > 885 rtn = kzalloc(size,

Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jiri Pirko
Sun, Jan 15, 2017 at 04:18:20PM CET, j...@mojatatu.com wrote: >On 17-01-15 10:01 AM, Jiri Pirko wrote: >> Sun, Jan 15, 2017 at 03:01:19PM CET, j...@mojatatu.com wrote: > >> > +cls_set_class(struct tcf_proto *tp, unsigned long *clp, >> >> ?? >> >> >unsigned long cl) >> > { >> >unsigned

Re: sctp: kernel memory overwrite attempt detected in sctp_getsockopt_assoc_stats

2017-01-15 Thread Dmitry Vyukov
On Sun, Jan 15, 2017 at 9:35 PM, Neil Horman wrote: > On Sun, Jan 15, 2017 at 06:29:59PM +0100, Dmitry Vyukov wrote: >> Hello, >> >> I've enabled CONFIG_HARDENED_USERCOPY_PAGESPAN on syzkaller fuzzer and >> now I am seeing lots of: >> > If I'm not mistaken, its because

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-15 Thread Juergen Gross
On 13/01/17 18:55, Remanan Pillai wrote: > From: Vineeth Remanan Pillai > > During an OOM scenario, request slots could not be created as skb > allocation fails. So the netback cannot pass in packets and netfront > wrongly assumes that there is no more work to be done and it

Re: [net PATCH v4 0/6] virtio_net XDP fixes and adjust_header support

2017-01-15 Thread Jason Wang
On 2017年01月16日 07:59, John Fastabend wrote: This has a fix to handle small buffer free logic correctly and then also adds adjust head support. I pushed adjust head at net (even though its rc3) to avoid having to push another exception case into virtio_net to catch if the program uses

Re: [net PATCH v4 6/6] virtio_net: XDP support for adjust_head

2017-01-15 Thread Jason Wang
On 2017年01月16日 08:01, John Fastabend wrote: Add support for XDP adjust head by allocating a 256B header region that XDP programs can grow into. This is only enabled when a XDP program is loaded. In order to ensure that we do not have to unwind queue headroom push queue setup below

Re: [PATCH net 2/3] be2net: don't delete MAC on close on unprivileged BE3 VFs

2017-01-15 Thread David Miller
From: Ivan Vecera Date: Fri, 13 Jan 2017 22:38:28 +0100 > BE3 VFs without FILTMGMT privilege are not allowed to modify its MAC, > VLAN table and UC/MC lists. So don't try to delete MAC on such VFs. > > Cc: Sathya Perla > Cc: Ajit Khaparde

Re: [PATCH net 1/3] be2net: fix status check in be_cmd_pmac_add()

2017-01-15 Thread David Miller
From: Ivan Vecera Date: Fri, 13 Jan 2017 22:38:27 +0100 > Return value from be_mcc_notify_wait() contains a base completion status > together with an additional status. The base_status() macro need to be > used to access base status. > > Fixes: e3a7ae2 be2net: Changing MAC Address

Re: [PATCH net 3/3] be2net: fix MAC addr setting on privileged BE3 VFs

2017-01-15 Thread David Miller
From: Ivan Vecera Date: Fri, 13 Jan 2017 22:38:29 +0100 > During interface opening MAC address stored in netdev->dev_addr is > programmed in the HW with exception of BE3 VFs where the initial > MAC is programmed by parent PF. This is OK when MAC address is not > changed when an

Re: pull-request: mac80211 2017-01-13

2017-01-15 Thread David Miller
From: Johannes Berg Date: Fri, 13 Jan 2017 14:55:15 +0100 > Here's another update for the current cycle. Some of those > patches have been sitting in our tree and I haven't been > pulling them out quickly enough - will try to do better... > > Please pull and let me

Re: [PATCH v2 net-next] net:add one common config ARCH_WANT_RELAX_ORDER to support relax ordering.

2017-01-15 Thread David Miller
From: Mao Wenan Date: Mon, 9 Jan 2017 13:32:34 +0800 > Relax ordering(RO) is one feature of 82599 NIC, to enable this feature can > enhance the performance for some cpu architecure, such as SPARC and so on. > Currently it only supports one special cpu architecture(SPARC) in

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-15 Thread David Miller
Please do not ever submit two patches which have the same exact commit header line, as these two patches do. When someone looks into the shortlog of GIT history all they will see is "qed: Replace memset with eth_zero_addr" twice. This gives the reader no idea what might be different between

Re: [net PATCH v4 5/6] virtio: add pci_down/pci_up configuration

2017-01-15 Thread John Fastabend
On 17-01-15 07:57 PM, Jason Wang wrote: > > > On 2017年01月16日 08:01, John Fastabend wrote: >> In virtio_net we need to do a full reset of the device to support >> queue reconfiguration and also we can trigger this via ethtool >> commands. So instead of open coding this in net driver push this >>

Re: [net PATCH v4 5/6] virtio: add pci_down/pci_up configuration

2017-01-15 Thread Jason Wang
On 2017年01月16日 08:01, John Fastabend wrote: In virtio_net we need to do a full reset of the device to support queue reconfiguration and also we can trigger this via ethtool commands. So instead of open coding this in net driver push this into generic code in virtio. This also avoid exporting a

Re: [PATCHv3 net-next 2/7] sctp: add support for generating stream reconf ssn reset request chunk

2017-01-15 Thread Xin Long
On Sun, Jan 15, 2017 at 11:51 PM, Marcelo Ricardo Leitner wrote: > On Sat, Jan 14, 2017 at 03:15:36AM +0800, Xin Long wrote: >> This patch is to add asoc strreset_outseq and strreset_inseq for >> saving the reconf request sequence, initialize them when create >> assoc

[PATCH] sfc: Replace memset with eth_zero_addr

2017-01-15 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero which makes the code clearer and also add header file linux/etherdevice.h Signed-off-by: Shyam Saini ---

[PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-15 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 +- 1 file changed, 1

[PATCH 2/2] qed: Replace memset with eth_zero_addr

2017-01-15 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_sriov.c | 7 +++ 1 file

Re: [PATCH net] openvswitch: maintain correct checksum state in conntrack actions

2017-01-15 Thread David Miller
From: Lance Richardson Date: Thu, 12 Jan 2017 19:33:18 -0500 > When executing conntrack actions on skbuffs with checksum mode > CHECKSUM_COMPLETE, the checksum must be updated to account for > header pushes and pulls. Otherwise we get "hw csum failure" > logs similar to this

Re: [patch net-next] stmmac: indent an if statement

2017-01-15 Thread David Miller
From: Dan Carpenter Date: Thu, 12 Jan 2017 21:46:32 +0300 > The break statement should be indented one more tab. > > Signed-off-by: Dan Carpenter Applied, but like Julia I think we might have a missing of_node_put() here.

Re: [PATCH] synopsys: remove dwc_eth_qos driver

2017-01-15 Thread David Miller
From: Joao Pinto Date: Thu, 12 Jan 2017 09:56:18 + > This driver is no longer necessary since it was merged into stmmac. > > Acked-by: Lars Persson > Signed-off-by: Joao Pinto Applied.

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-15 Thread Tejun Heo
Hello, Sorry about the delay. Some fire fighthing followed the holidays. On Tue, Jan 03, 2017 at 11:25:59AM +0100, Michal Hocko wrote: > > So from what I understand the proposed cgroup is not in fact > > hierarchical at all. > > > > @TJ, I thought you were enforcing all new cgroups to be

[net PATCH v4 6/6] virtio_net: XDP support for adjust_head

2017-01-15 Thread John Fastabend
Add support for XDP adjust head by allocating a 256B header region that XDP programs can grow into. This is only enabled when a XDP program is loaded. In order to ensure that we do not have to unwind queue headroom push queue setup below bpf_prog_add. It reads better to do a prog ref unwind vs

[net PATCH v4 4/6] virtio_net: remove duplicate queue pair binding in XDP

2017-01-15 Thread John Fastabend
Factor out qp assignment. Signed-off-by: John Fastabend --- drivers/net/virtio_net.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 7dda206..ac853b9 100644 ---

[net PATCH v4 5/6] virtio: add pci_down/pci_up configuration

2017-01-15 Thread John Fastabend
In virtio_net we need to do a full reset of the device to support queue reconfiguration and also we can trigger this via ethtool commands. So instead of open coding this in net driver push this into generic code in virtio. This also avoid exporting a handful of internal virtio routines.

[net PATCH v4 3/6] virtio_net: factor out xdp handler for readability

2017-01-15 Thread John Fastabend
At this point the do_xdp_prog is mostly if/else branches handling the different modes of virtio_net. So remove it and handle running the program in the per mode handlers. Signed-off-by: John Fastabend --- drivers/net/virtio_net.c | 75

[net PATCH v4 2/6] virtio_net: wrap rtnl_lock in test for calling with lock already held

2017-01-15 Thread John Fastabend
For XDP use case and to allow ethtool reset tests it is useful to be able to use reset paths from contexts where rtnl lock is already held. This requries updating virtnet_set_queues and free_receive_bufs the two places where rtnl_lock is taken in virtio_net. To do this we use the following

[net PATCH v4 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

2017-01-15 Thread John Fastabend
In the small buffer case during driver unload we currently use put_page instead of dev_kfree_skb. Resolve this by adding a check for virtnet mode when checking XDP queue type. Also name the function so that the code reads correctly to match the additional check. Fixes: bb91accf2733 ("virtio-net:

[net PATCH v4 0/6] virtio_net XDP fixes and adjust_header support

2017-01-15 Thread John Fastabend
This has a fix to handle small buffer free logic correctly and then also adds adjust head support. I pushed adjust head at net (even though its rc3) to avoid having to push another exception case into virtio_net to catch if the program uses adjust_head and then block it. If there are any strong

[PATCH] net: jme: use new api ethtool_{get|set}_link_ksettings

2017-01-15 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/jme.c | 34

Re: sctp: kernel memory overwrite attempt detected in sctp_getsockopt_assoc_stats

2017-01-15 Thread Neil Horman
On Sun, Jan 15, 2017 at 06:29:59PM +0100, Dmitry Vyukov wrote: > Hello, > > I've enabled CONFIG_HARDENED_USERCOPY_PAGESPAN on syzkaller fuzzer and > now I am seeing lots of: > If I'm not mistaken, its because thats specifically what that option does. From the Kconfig: onfig

[PATCH net-next v2 1/3] net: ipv6: Allow shorthand delete of all nexthops in multipath route

2017-01-15 Thread David Ahern
IPv4 allows multipath routes to be deleted using just the prefix and length. For example: $ ip ro ls vrf red unreachable default metric 8192 1.1.1.0/24 nexthop via 10.100.1.254 dev eth1 weight 1 nexthop via 10.11.200.2 dev eth11.200 weight 1 10.11.200.0/24 dev

[PATCH net-next 3/3] net: ipv6: Add option to dump multipath routes via RTA_MULTIPATH attribute

2017-01-15 Thread David Ahern
IPv6 returns multipath routes as a series of individual routes making their display different than IPv4 and putting the burden on the user to see that a route is part of a multipath route. This patch addresses this difference, allowing users to request multipath routes to be returned using the

[PATCH net-next 0/3] net: ipv6: Improve user experience with multipath routes

2017-01-15 Thread David Ahern
This series closes a couple of gaps between IPv4 and IPv6 with respect to multipath routes. Patch 1 allows IPv6 multipath routes to be deleted using just the prefix and length - similar to what IPv4 allows. Patch 2 removes the nowait arg which is always 0. Patch 3 allows IPv6 multipath routes

[PATCH net-next 2/3] net: ipv6: remove nowait arg to rt6_fill_node

2017-01-15 Thread David Ahern
All callers of rt6_fill_node pass 0 for nowait arg. Remove the arg and simplify rt6_fill_node accordingly. rt6_fill_node passes the nowait of 0 to ip6mr_get_route. Remove the nowait arg from it as well. Signed-off-by: David Ahern --- include/linux/mroute6.h | 2 +-

Re: [PATCH for bnxt_re V3 03/21] bnxt_re: register with the NIC driver

2017-01-15 Thread Leon Romanovsky
On Tue, Dec 20, 2016 at 01:13:13AM -0800, Selvin Xavier wrote: > This patch handles the registration with the bnxt_en driver. > The bnxt_re driver first registers with netdev notifier chain and upon > receiving the NETDEV_REGISTER event, it registers with bnxt_en driver. > > 1. bnxt_en's

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-15 Thread Andrew Lunn
> > What exactly is the relationship between these devices (a ascii-art tree > > or sysfs tree output might be nice) so I can try to understand what is > > going on here. Hi Greg, Florian A few diagrams and trees which might help understand what is going on. The first diagram comes from the

Re: [PATCH net-next] net/sched: cls_flower: Add user specified data

2017-01-15 Thread John Fastabend
On 17-01-15 09:36 AM, Paul Blakey wrote: > > > On 08/01/2017 19:12, Jiri Pirko wrote: >> Mon, Jan 02, 2017 at 03:59:49PM CET, j...@mojatatu.com wrote: >>> >>> We have been using a cookie as well for actions (which we have been >>> using but have been too lazy to submit so far). I am going to

Re: net: stmmac: don't use netdev_[dbg, info, ..] before net_device is registered

2017-01-15 Thread Heiner Kallweit
Am 15.01.2017 um 19:23 schrieb Joe Perches: > On Sun, 2017-01-15 at 19:17 +0100, Heiner Kallweit wrote: >> Don't use netdev_info and friends before the net_device is registered. >> This avoids ugly messages like >> "meson8b-dwmac c941.ethernet (unnamed net_device) (uninitialized): >> Enable RX

Re: net: stmmac: don't use netdev_[dbg, info, ..] before net_device is registered

2017-01-15 Thread Joe Perches
On Sun, 2017-01-15 at 19:17 +0100, Heiner Kallweit wrote: > Don't use netdev_info and friends before the net_device is registered. > This avoids ugly messages like > "meson8b-dwmac c941.ethernet (unnamed net_device) (uninitialized): > Enable RX Mitigation via HW Watchdog Timer" It'd be nice

[PATCH] net: stmmac: don't use netdev_[dbg, info, ..] before net_device is registered

2017-01-15 Thread Heiner Kallweit
Don't use netdev_info and friends before the net_device is registered. This avoids ugly messages like "meson8b-dwmac c941.ethernet (unnamed net_device) (uninitialized): Enable RX Mitigation via HW Watchdog Timer" Signed-off-by: Heiner Kallweit ---

net: stmmac: don't use netdev_[dbg, info, ..] before net_device is registered

2017-01-15 Thread Heiner Kallweit
Don't use netdev_info and friends before the net_device is registered. This avoids ugly messages like "meson8b-dwmac c941.ethernet (unnamed net_device) (uninitialized): Enable RX Mitigation via HW Watchdog Timer" Signed-off-by: Heiner Kallweit ---

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-15 Thread Florian Fainelli
On 01/15/2017 09:39 AM, Greg KH wrote: > On Sun, Jan 15, 2017 at 09:27:22AM -0800, Florian Fainelli wrote: >> >> >> On 01/15/2017 03:06 AM, Greg KH wrote: >>> On Sat, Jan 14, 2017 at 01:47:09PM -0800, Florian Fainelli wrote: Now that the base device driver code provides an identical

[PATCH net V2] net/mlx5e: Fix a -Wmaybe-uninitialized warning

2017-01-15 Thread Or Gerlitz
From: Arnd Bergmann As found by Olof's build bot, we gain a harmless warning about a potential uninitialized variable reference in mlx5: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'parse_tc_fdb_actions': drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:769:13:

Re: [PATCH net-next v3 00/10] net: dsa: Support for pdata in dsa2

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 09:40:24AM -0800, Florian Fainelli wrote: > On 01/15/2017 03:08 AM, Greg KH wrote: > > On Sat, Jan 14, 2017 at 01:47:03PM -0800, Florian Fainelli wrote: > >> Hi all, > >> > >> This is not exactly new, and was sent before, although back then, I did not > >> have an user of

Re: [PATCH net-next v3 07/10] net: Relocate dev_to_net_device() into core

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 09:20:06AM -0800, Florian Fainelli wrote: > > > On 01/15/2017 03:07 AM, Greg KH wrote: > > On Sat, Jan 14, 2017 at 01:47:10PM -0800, Florian Fainelli wrote: > >> dev_to_net_device() is moved from net/dsa/dsa.c to net/core/dev.c since > >> it going to be used by

Re: [PATCH net-next v3 00/10] net: dsa: Support for pdata in dsa2

2017-01-15 Thread Florian Fainelli
On 01/15/2017 03:08 AM, Greg KH wrote: > On Sat, Jan 14, 2017 at 01:47:03PM -0800, Florian Fainelli wrote: >> Hi all, >> >> This is not exactly new, and was sent before, although back then, I did not >> have an user of the pre-declared MDIO board information, but now we do. Note >> that I have

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 09:27:22AM -0800, Florian Fainelli wrote: > > > On 01/15/2017 03:06 AM, Greg KH wrote: > > On Sat, Jan 14, 2017 at 01:47:09PM -0800, Florian Fainelli wrote: > >> Now that the base device driver code provides an identical > >> implementation of dev_find_class() utilize

Re: [PATCH net-next v3 05/10] drivers: base: Add device_find_class()

2017-01-15 Thread Florian Fainelli
On 01/15/2017 03:04 AM, Greg KH wrote: > On Sat, Jan 14, 2017 at 01:47:08PM -0800, Florian Fainelli wrote: >> Add a helper function to lookup a device reference given a class name. >> This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and >> make it more generic. >> >>

Re: [PATCH net-next] net/sched: cls_flower: Add user specified data

2017-01-15 Thread Paul Blakey
On 08/01/2017 19:12, Jiri Pirko wrote: Mon, Jan 02, 2017 at 03:59:49PM CET, j...@mojatatu.com wrote: We have been using a cookie as well for actions (which we have been using but have been too lazy to submit so far). I am going to port it over to the newer kernels and post it. Hard to deal

sctp: kernel memory overwrite attempt detected in sctp_getsockopt_assoc_stats

2017-01-15 Thread Dmitry Vyukov
Hello, I've enabled CONFIG_HARDENED_USERCOPY_PAGESPAN on syzkaller fuzzer and now I am seeing lots of: usercopy: kernel memory overwrite attempt detected to 8801a74f6f10 () (256 bytes) kernel BUG at mm/usercopy.c:75! invalid opcode: [#1] SMP KASAN Dumping ftrace buffer: (ftrace

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-15 Thread Florian Fainelli
On 01/15/2017 03:06 AM, Greg KH wrote: > On Sat, Jan 14, 2017 at 01:47:09PM -0800, Florian Fainelli wrote: >> Now that the base device driver code provides an identical >> implementation of dev_find_class() utilize device_find_class() instead >> of our own version of it. >> >> Signed-off-by:

Re: [PATCH] net: add regs attribute to phy device for user diagnose

2017-01-15 Thread Andrew Lunn
On Sun, Jan 15, 2017 at 09:51:03AM +0800, yuan linyu wrote: > On ???, 2017-01-14 at 10:35 -0800, Florian Fainelli wrote: > > On 01/14/2017 08:24 AM, Andrew Lunn wrote: > > > > > > On Sat, Jan 14, 2017 at 10:46:31AM +0800, yuan linyu wrote: > > > > > > > > From: yuan linyu

Re: [PATCH net-next] net: ipv6: Allow shorthand delete of all nexthops in multipath route

2017-01-15 Thread David Ahern
On 1/13/17 4:54 PM, David Ahern wrote: > The same notation does not work with IPv6 because of how multipath routes > are implemented for IPv6. For IPv6 only the first nexthop of a multipath > route is deleted if the request contains only a prefix and length. This > leads to unnecessary complexity

Re: [PATCH net-next v3 07/10] net: Relocate dev_to_net_device() into core

2017-01-15 Thread Florian Fainelli
On 01/15/2017 03:07 AM, Greg KH wrote: > On Sat, Jan 14, 2017 at 01:47:10PM -0800, Florian Fainelli wrote: >> dev_to_net_device() is moved from net/dsa/dsa.c to net/core/dev.c since >> it going to be used by net/dsa/dsa2.c and the namespace of the function >> justifies making it available to

Re: [PATCHv3 net-next 2/7] sctp: add support for generating stream reconf ssn reset request chunk

2017-01-15 Thread Marcelo Ricardo Leitner
On Sat, Jan 14, 2017 at 03:15:36AM +0800, Xin Long wrote: > This patch is to add asoc strreset_outseq and strreset_inseq for > saving the reconf request sequence, initialize them when create > assoc and process init, and also to define Incoming and Outgoing > SSN Reset Request Parameter described

Re: [PATCH] secure_seq: initialize secret at boot instead of at runtime

2017-01-15 Thread Jason A. Donenfeld
On Sun, Jan 15, 2017 at 4:37 PM, Daniel Borkmann wrote: > commit aebda156a570782a86fc4426842152237a19427d > Author: Eric Dumazet > Date: Mon Apr 29 05:58:52 2013 + > > net: defer net_secret[] initialization Thanks for that. Suspected as much.

Re: [PATCH] secure_seq: initialize secret at boot instead of at runtime

2017-01-15 Thread Daniel Borkmann
On 01/15/2017 03:01 PM, Jason A. Donenfeld wrote: While the static key stuff is fast, it's not as fast as simply not having any code to run. So, this patch generates the secret at boot, rather than at runtime. Signed-off-by: Jason A. Donenfeld --- I can imagine this patch not

Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jamal Hadi Salim
On 17-01-15 10:01 AM, Jiri Pirko wrote: Sun, Jan 15, 2017 at 03:01:19PM CET, j...@mojatatu.com wrote: +cls_set_class(struct tcf_proto *tp, unsigned long *clp, ?? unsigned long cl) { unsigned long old_cl; - + ?? tcf_tree_lock(tp); old_cl =

[PATCH net 1/1] net sched actions: fix refcnt when GETing of action after bind

2017-01-15 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Demonstrating the issue: .. add a drop action $sudo $TC actions add action drop index 10 .. retrieve it $ sudo $TC -s actions get action gact index 10 action order 1: gact action drop random type none pass val 0 index 10 ref

Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jiri Pirko
Sun, Jan 15, 2017 at 03:01:19PM CET, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Introduce optional 128-bit action cookie. >Like all other cookie schemes in the networking world (eg in protocols >like http or existing kernel fib protocol field, etc) the idea is to save

Re: [PATCH 3/3] powerpc: bpf: implement in-register swap for 64-bit endian operations

2017-01-15 Thread Benjamin Herrenschmidt
On Fri, 2017-01-13 at 23:22 +0530, 'Naveen N. Rao' wrote: > > That rather depends on whether the processor has a store to load forwarder > > that will satisfy the read from the store buffer. > > I don't know about ppc, but at least some x86 will do that. > > Interesting - good to know that. > >

[PATCH net-next v2] ipv6: sr: add missing Kbuild export for header files

2017-01-15 Thread David Lebrun
Add missing IPv6-SR header files in include/uapi/linux/Kbuild. Also, prevent seg6_lwt_headroom() from being exported and add missing linux/types.h include. Signed-off-by: David Lebrun --- include/uapi/linux/Kbuild | 4 include/uapi/linux/seg6.h

[PATCH iproute2] tc: flower: Fix flower output for src and dst ports

2017-01-15 Thread Roi Dayan
This fix a missing use case after the introduction of enum flower_endpoint. Fixes: 6910d65661a3 ("tc: flower: introduce enum flower_endpoint") Signed-off-by: Roi Dayan Signed-off-by: Paul Blakey --- tc/f_flower.c |4 ++-- 1 files changed, 2

[PATCH] secure_seq: initialize secret at boot instead of at runtime

2017-01-15 Thread Jason A. Donenfeld
While the static key stuff is fast, it's not as fast as simply not having any code to run. So, this patch generates the secret at boot, rather than at runtime. Signed-off-by: Jason A. Donenfeld --- I can imagine this patch not being desirable because: a) It was done this way

[PATCH net-next v3 0/1] Add support for tc cookies

2017-01-15 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Changes in v3: - use TC_ prefix for the max size - move the cookie struct so visible only to kernel - remove unneeded void * cast Changes in V2: -move from a union to a length-value representation Jamal Hadi Salim (1): net sched actions: Add

[PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The kernel

RE: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics

2017-01-15 Thread Nogah Frankel
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, January 13, 2017 3:44 AM > To: Nogah Frankel > Cc: netdev@vger.kernel.org; roszenr...@gmail.com; ro...@cumulusnetworks.com; > Jiri > Pirko ; Ido

RE: [PATCH iproute2 v4 1/4] ifstat: Includes reorder

2017-01-15 Thread Nogah Frankel
> -Original Message- > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Friday, January 13, 2017 12:11 PM > To: Nogah Frankel ; netdev@vger.kernel.org > Cc: step...@networkplumber.org; roszenr...@gmail.com; > ro...@cumulusnetworks.com; Jiri

Re: [PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jamal Hadi Salim
On 17-01-15 04:11 AM, Jiri Pirko wrote: Subject should contain "V2" Sat, Jan 14, 2017 at 10:52:44PM CET, j...@mojatatu.com wrote: From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like

qla3xxx: u32 constant overflow in fm93c56a_select()

2017-01-15 Thread Nicolas Iooss
Hello, In drivers/net/ethernet/qlogic/qla3xxx.c, fm93c56a_select() currently calls: ql_write_nvram_reg(qdev, spir, ((ISP_NVRAM_MASK << 16) | qdev->eeprom_cmd_data)); and ISP_NVRAM_MASK is defined as (0x000F << 16). ql_write_nvram_reg() writes a 32-bit value but (ISP_NVRAM_MASK << 16)

Re: [PATCH net-next v3 00/10] net: dsa: Support for pdata in dsa2

2017-01-15 Thread Greg KH
On Sat, Jan 14, 2017 at 01:47:03PM -0800, Florian Fainelli wrote: > Hi all, > > This is not exactly new, and was sent before, although back then, I did not > have an user of the pre-declared MDIO board information, but now we do. Note > that I have additional changes queued up to have b53

Re: [PATCH net-next v3 07/10] net: Relocate dev_to_net_device() into core

2017-01-15 Thread Greg KH
On Sat, Jan 14, 2017 at 01:47:10PM -0800, Florian Fainelli wrote: > dev_to_net_device() is moved from net/dsa/dsa.c to net/core/dev.c since > it going to be used by net/dsa/dsa2.c and the namespace of the function > justifies making it available to other users potentially. > > Signed-off-by:

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-15 Thread Greg KH
On Sat, Jan 14, 2017 at 01:47:09PM -0800, Florian Fainelli wrote: > Now that the base device driver code provides an identical > implementation of dev_find_class() utilize device_find_class() instead > of our own version of it. > > Signed-off-by: Florian Fainelli > --- >

Re: [PATCH net-next v3 05/10] drivers: base: Add device_find_class()

2017-01-15 Thread Greg KH
On Sat, Jan 14, 2017 at 01:47:08PM -0800, Florian Fainelli wrote: > Add a helper function to lookup a device reference given a class name. > This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and > make it more generic. > > Signed-off-by: Florian Fainelli >

Re: [PATCH] net: add regs attribute to phy device for user diagnose

2017-01-15 Thread yuan linyu
On 六, 2017-01-14 at 17:57 -0800, Florian Fainelli wrote: > Le 01/14/17 à 17:51, yuan linyu a écrit : > > > > I think mii-tool or ethtool can't do it currently. > Maybe they cannot right now but they can certainly be patched to support > that. sysfs is not an appropriate interface for what you are

Re: [PATCH net-next v3 04/10] net: dsa: Move ports assignment closer to error checking

2017-01-15 Thread Sergei Shtylyov
Hello! On 1/15/2017 12:47 AM, Florian Fainelli wrote: Move the assignment of ports in _dsa_register_switch() closer to where it is checked, no functional change. Re-order declarations to be "Be" not needed. preserve the inverted christmas tree style. Signed-off-by: Florian Fainelli

Re: [PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jiri Pirko
Subject should contain "V2" Sat, Jan 14, 2017 at 10:52:44PM CET, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Introduce optional 128-bit action cookie. >Like all other cookie schemes in the networking world (eg in protocols >like http or existing kernel fib protocol