[PATCH net 1/3] bnxt_en: Fix bnxt_reset() in the slow path task.

In bnxt_sp_task(), we set a bit BNXT_STATE_IN_SP_TASK so that bnxt_close() will synchronize and wait for bnxt_sp_task() to finish. Some functions in bnxt_sp_task() require us to clear BNXT_STATE_IN_SP_TASK and then acquire rtnl_lock() to prevent race conditions. There are some bugs related to

Re: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

Hi Andrew, On mer., janv. 25 2017, Andrew Lunn wrote: >> +[MV88E6341] = { >> +.prod_num = PORT_SWITCH_ID_PROD_NUM_6341, >> +.family = MV88E6XXX_FAMILY_6341, >> +.name = "Marvell 88E6341", >> +.num_databases = 4096, >> +

[PATCH net 0/3] bnxt_en: Fix RTNL lock usage in bnxt_sp_task().

There are 2 function calls from bnxt_sp_task() that have buggy RTNL usage. These 2 functions take RTNL lock under some conditions, but some callers (such as open, ethtool) have already taken RTNL. These 3 patches fix the issue by making it clear that callers must take RTNL. If the caller is

[PATCH net 3/3] bnxt_en: Fix RTNL lock usage on bnxt_get_port_module_status().

bnxt_get_port_module_status() calls bnxt_update_link() which expects RTNL to be held. In bnxt_sp_task() that does not hold RTNL, we need to call it with a prior call to bnxt_rtnl_lock_sp() and the call needs to be moved to the end of bnxt_sp_task(). Signed-off-by: Michael Chan

[PATCH net 2/3] bnxt_en: Fix RTNL lock usage on bnxt_update_link().

bnxt_update_link() is called from multiple code paths. Most callers, such as open, ethtool, already hold RTNL. Only the caller bnxt_sp_task() does not. So it is a bug to take RTNL inside bnxt_update_link(). Fix it by removing the RTNL inside bnxt_update_link(). The function now expects the

Re: linux-next: manual merge of the kselftest tree with the net-next tree

On 01/25/2017 05:03 AM, Stephen Rothwell wrote: Hi Shuah, Today's linux-next merge of the kselftest tree got a conflict in: tools/testing/selftests/bpf/Makefile between commit: 62b64660262a ("bpf: add prog tag test case to bpf selftests") from the net-next tree and commit:

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Tue, Jan 24, 2017 at 8:02 PM, John Fastabend wrote: > > Finally just to point out here are the drivers with XDP support on latest > net tree, > > mlx/mlx5 > mlx/mlx4 > qlogic/qede > netronome/nfp > virtio_net > > And here is the

Re: [PATCH net 1/3] qed: Release CQ resource under lock on failure

On Tue, Jan 24, 2017 at 11:15:21PM +0200, Yuval Mintz wrote: > From: Ram Amrani > > The CQ resource pool is protected by a spin lock. When a CQ creation > fails it now deallocates under that lock as well. > > Signed-off-by: Ram Amrani >

TT PAYMENT CONFIRMATION - FW: OT16229ZA0620339 - OTT Payment Advice

Attention, Attached is the payment transferred to your bank account for INV-* as directed by our customer to you, we are sorry for the delay. Please review for your reference PDF id is INVOICEPAYMENT1. Thanks & Best Regards, Donna -- Forwarded message -- From: WELLS

A PMTU auto-discovery error for large SCTP packets

Hi All, Recently, I met a problem of SCTP association broken which was resulted from large SCTP packets as attached in this mail. Because the 1st packet’s length is 1626 that exceeds the next hop’s MTU of 1500, an ICMP packet of code 4 (Fragmentation needed) reflects back and carries the

Re: [PATCH] cxgbit: use T6 specific macro to set force bit

On Wed, Jan 25, 2017 at 02:41:40AM +0530, Joe Perches wrote: > On Tue, 2017-01-24 at 17:07 +0530, Varun Prakash wrote: > > For T6 adapters use T6 specific macro to set > > force bit. > [] > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h > >

Re: [PATCH] cxgbit: use T6 specific macro to set force bit

On Wed, Jan 25, 2017 at 01:56:16AM +0530, David Miller wrote: > From: Varun Prakash > Date: Tue, 24 Jan 2017 17:07:02 +0530 > > > For T6 adapters use T6 specific macro to set > > force bit. > > > > Signed-off-by: Varun Prakash > > What tree is this for? >

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On 2017年01月25日 12:02, John Fastabend wrote: On 17-01-24 07:23 PM, Michael S. Tsirkin wrote: On Wed, Jan 25, 2017 at 10:57:12AM +0800, Jason Wang wrote: On 2017年01月25日 04:08, Michael S. Tsirkin wrote: On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: From: "Michael S.

[PATCH net-next] r8152: fix the wrong spelling

Replace rumtime with runtime. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f3b48ad..d59d773 100644 --- a/drivers/net/usb/r8152.c +++

Re: [PATCH net 1/4] r8152: avoid start_xmit to call napi_schedule during autosuspend

On Wed, 25 Jan 2017 10:50:51 +0800 Hayes Wang wrote: > Adjust the setting of the flag of SELECTIVE_SUSPEND to prevent start_xmit() > from calling napi_schedule() directly during runtime suspend. > > After calling napi_disable() or clearing the flag of WORK_ENABLE, >

Re: [PATCH net] tcp: correct memory barrier usage in tcp_check_space()

On Tue, 2017-01-24 at 21:49 -0500, Jason Baron wrote: > From: Jason Baron > > sock_reset_flag() maps to __clear_bit() not the atomic version clear_bit(). > Thus, we need smp_mb(), smp_mb__after_atomic() is not sufficient. > > Fixes: 3c7151275c0c ("tcp: add memory barriers to

Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k

On Tue, Jan 24, 2017 at 7:48 PM, John Fastabend wrote: > > It is a concern on my side. I want XDP and Linux stack to work > reasonably well together. btw the micro benchmarks showed that page per packet approach that xdp took in mlx4 should be 10% slower vs normal

Re: [PATCH net-next] net: ipv6: ignore null_entry on route dumps

On 1/24/17 6:39 PM, David Miller wrote: > Although, it's troubling that we are trying to dump unfinished entries > simply because of initialization order. It's arguable that this is > the real thing to fix. that's rabbit hole from which I have not found an exit

linux-next: manual merge of the kselftest tree with the net-next tree

Hi Shuah, Today's linux-next merge of the kselftest tree got a conflict in: tools/testing/selftests/bpf/Makefile between commit: 62b64660262a ("bpf: add prog tag test case to bpf selftests") from the net-next tree and commit: 88baa78d1f31 ("selftests: remove duplicated all and clean

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On 17-01-24 07:23 PM, Michael S. Tsirkin wrote: > On Wed, Jan 25, 2017 at 10:57:12AM +0800, Jason Wang wrote: >> >> >> On 2017年01月25日 04:08, Michael S. Tsirkin wrote: >>> On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: From: "Michael S. Tsirkin" Date: Mon,

Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k

On 17-01-24 01:56 PM, Michael S. Tsirkin wrote: > On Tue, Jan 24, 2017 at 04:10:46PM -0500, David Miller wrote: >> This works in the regimen that XDP packets always live in exactly one >> page. That will be needed to mmap the RX ring into userspace, and it >> helps make adjust_header trivial as

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Wed, Jan 25, 2017 at 10:57:12AM +0800, Jason Wang wrote: > > > On 2017年01月25日 04:08, Michael S. Tsirkin wrote: > > On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: > > > From: "Michael S. Tsirkin" > > > Date: Mon, 23 Jan 2017 23:08:35 +0200 > > > > > > > On

Re: XDP offload to hypervisor

On Wed, Jan 25, 2017 at 10:45:18AM +0800, Jason Wang wrote: > > > On 2017年01月24日 05:56, John Fastabend wrote: > > On 17-01-23 01:40 PM, Michael S. Tsirkin wrote: > > > I've been thinking about passing XDP programs from guest to the > > > hypervisor. Basically, after getting an incoming packet,

Re: XDP offload to hypervisor

On Wed, Jan 25, 2017 at 10:41:24AM +0800, Jason Wang wrote: > > > On 2017年01月24日 05:40, Michael S. Tsirkin wrote: > > I've been thinking about passing XDP programs from guest to the > > hypervisor. Basically, after getting an incoming packet, we could run > > an XDP program in host kernel. > >

Re: XDP offload to hypervisor

On 2017年01月24日 09:02, Alexei Starovoitov wrote: Frankly I don't understand the whole virtio nit picking that was happening. imo virtio+xdp by itself is only useful for debugging, development and testing of xdp programs in a VM. The discussion about performance of virtio+xdp will only be

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On 2017年01月25日 04:08, Michael S. Tsirkin wrote: On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: From: "Michael S. Tsirkin" Date: Mon, 23 Jan 2017 23:08:35 +0200 On Tue, Jan 17, 2017 at 02:19:50PM -0800, John Fastabend wrote: In the small buffer case during

[PATCH net] tcp: correct memory barrier usage in tcp_check_space()

From: Jason Baron sock_reset_flag() maps to __clear_bit() not the atomic version clear_bit(). Thus, we need smp_mb(), smp_mb__after_atomic() is not sufficient. Fixes: 3c7151275c0c ("tcp: add memory barriers to write space paths") Cc: Eric Dumazet Cc:

[PATCH net 4/4] r8152: check rx after napi is enabled

Schedule the napi after napi_enable() for rx, if it is necessary. If the rx is completed when napi is disabled, the sheduling of napi would be lost. Then, no one handles the rx packet until next napi is scheduled. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 7

[PATCH net 3/4] r8152: re-schedule napi for tx

Re-schedule napi after napi_complete() for tx, if it is necessay. In r8152_poll(), if the tx is completed after tx_bottom() and before napi_complete(), the scheduling of napi would be lost. Then, no one handles the next tx until the next napi_schedule() is called. Signed-off-by: Hayes Wang

[PATCH net 0/4] r8152: fix scheduling napi

Scheduling the napi during the following periods would let it be ignored. And the events wouldn't be handled until next napi_schedule() is called. 1. after napi_disable and before napi_enable(). 2. after all actions of napi function is completed and before calling napi_complete(). If no next

[PATCH net 2/4] r8152: avoid start_xmit to schedule napi when napi is disabled

Stop the tx when the napi is disabled to prevent napi_schedule() is called. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index

[PATCH net 1/4] r8152: avoid start_xmit to call napi_schedule during autosuspend

Adjust the setting of the flag of SELECTIVE_SUSPEND to prevent start_xmit() from calling napi_schedule() directly during runtime suspend. After calling napi_disable() or clearing the flag of WORK_ENABLE, scheduling the napi is useless. Signed-off-by: Hayes Wang ---

Re: XDP offload to hypervisor

On 2017年01月24日 09:02, Alexei Starovoitov wrote: On Mon, Jan 23, 2017 at 11:40:29PM +0200, Michael S. Tsirkin wrote: I've been thinking about passing XDP programs from guest to the hypervisor. Basically, after getting an incoming packet, we could run an XDP program in host kernel. If the

Re: XDP offload to hypervisor

On 2017年01月24日 05:56, John Fastabend wrote: On 17-01-23 01:40 PM, Michael S. Tsirkin wrote: I've been thinking about passing XDP programs from guest to the hypervisor. Basically, after getting an incoming packet, we could run an XDP program in host kernel. Interesting. I am planning on

Re: XDP offload to hypervisor

On 2017年01月24日 05:40, Michael S. Tsirkin wrote: I've been thinking about passing XDP programs from guest to the hypervisor. Basically, after getting an incoming packet, we could run an XDP program in host kernel. If the result is XDP_DROP or XDP_TX we don't need to wake up the guest at all!

Re: [PATCHv2 perf/core 5/7] tools lib bpf: Add bpf_program__pin()

On 2017/1/25 9:16, Joe Stringer wrote: On 24 January 2017 at 17:06, Wangnan (F) wrote: On 2017/1/25 9:04, Wangnan (F) wrote: On 2017/1/23 9:11, Joe Stringer wrote: Add a new API to pin a BPF program to the filesystem. The user can specify the path full path within a

Re: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

> + [MV88E6341] = { > + .prod_num = PORT_SWITCH_ID_PROD_NUM_6341, > + .family = MV88E6XXX_FAMILY_6341, > + .name = "Marvell 88E6341", > + .num_databases = 4096, > + .num_ports = 6, > + .port_base_addr = 0x10, > +

Re: [PATCH net-next 0/2] Work around missing PHY prodcut ID in mv88e6390

On Wed, Jan 25, 2017 at 02:55:12AM +0100, Andrew Lunn wrote: > The internal PHYs of the MV88E6390 have a Marvell OUI, but the product > ID is zero. Work around this by trapping reads to the ID, and if it is > zero, return the MV88E6390 family ID. Hi Gregory This should just work for your switch

[PATCH net-next 2/2] net: phy: Marvell: Add mv88e6390 internal PHY

The mv88e6390 Ethernet switch has internal PHYs. These PHYs don't have an model ID in the ID2 register. So the MDIO driver in the switch intercepts reads to this register, and returns the switch family ID. Extend the Marvell PHY driver by including this ID, and tread the PHY as a 88E1540.

[PATCH net-next 1/2] net: dsa: mv88e6xxx: Workaround missing PHY ID on mv88e6390

The internal PHYs of the mv88e6390 do not have a model ID. Trap any calls to the ID register, and if it is zero, return the ID for the mv88e6390. The Marvell PHY driver can then bind to this ID. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli ---

[PATCH net-next 0/2] Work around missing PHY prodcut ID in mv88e6390

The internal PHYs of the MV88E6390 have a Marvell OUI, but the product ID is zero. Work around this by trapping reads to the ID, and if it is zero, return the MV88E6390 family ID. Andrew Lunn (2): net: dsa: mv88e6xxx: Workaround missing PHY ID on mv88e6390 net: phy: Marvell: Add mv88e6390

[PATCH net-next] Doc: DT: bindings: net: dsa: marvell.txt: Tabification

Replace spaces with tabs. Fix indentation to be multiples of tabs, not a mixture or tabs and spaces. Signed-off-by: Andrew Lunn --- .../devicetree/bindings/net/dsa/marvell.txt| 112 ++--- 1 file changed, 56 insertions(+), 56 deletions(-) diff --git

Re: [PATCH net-next] net: ipv6: ignore null_entry on route dumps

From: David Ahern Date: Tue, 24 Jan 2017 18:35:02 -0700 > On 1/23/17 9:51 AM, David Ahern wrote: >> On 1/22/17 9:58 PM, David Miller wrote: >>> David, please slow down. >>> >>> How is the NULL entry getting selected to be dumped and passed >>> down here in the first

Re: [PATCH net-next] net: ipv6: ignore null_entry on route dumps

On 1/23/17 9:51 AM, David Ahern wrote: > On 1/22/17 9:58 PM, David Miller wrote: >> David, please slow down. >> >> How is the NULL entry getting selected to be dumped and passed >> down here in the first place? > The null_entry might be a 'marker' but is integral to the ipv6 fib. As I mentioned

Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: Implement the 6390 external MDIO bus

> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > index 7d24add45e74..572d585dc1e2 100644 > --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > @@ -387,6 +387,7 @@ > #define GLOBAL2_PTP_AVB_DATA 0x17 >

[PATCH net-next 1/3] trace: add variant without spacing in trace_print_hex_seq

For upcoming tracepoint support for BPF, we want to dump the program's tag. Format should be similar to __print_hex(), but without spacing. Add a __print_hex_str() variant for exactly that purpose that reuses trace_print_hex_seq(). Signed-off-by: Daniel Borkmann Cc: Steven

[PATCH net-next 0/3] BPF tracepoints

This set adds tracepoints to BPF for better introspection and debugging. The first two patches are prerequisite for the actual third patch that adds the tracepoints. I think the first two are small and straight forward enough that they could ideally go via net-next, but I'm also open to other

[PATCH net-next 3/3] bpf: add initial bpf tracepoints

This work adds a number of tracepoints to paths that are either considered slow-path or exception-like states, where monitoring or inspecting them would be desirable. For bpf(2) syscall, tracepoints have been placed for main commands when they succeed. In XDP case, tracepoint is for exceptions,

[PATCH net-next 2/3] lib, traceevent: add PRINT_HEX_STR variant

Add support for the __print_hex_str() macro that was added for tracing, so that user space tools such as perf can understand it as well. Signed-off-by: Daniel Borkmann Cc: Steven Rostedt Cc: Arnaldo Carvalho de Melo ---

Re: [PATCHv2 perf/core 5/7] tools lib bpf: Add bpf_program__pin()

On 24 January 2017 at 17:06, Wangnan (F) wrote: > > > On 2017/1/25 9:04, Wangnan (F) wrote: >> >> >> >> On 2017/1/23 9:11, Joe Stringer wrote: >>> >>> Add a new API to pin a BPF program to the filesystem. The user can >>> specify the path full path within a BPF filesystem to

[lkp-robot] [ipv6] 31cdaa587d: BUG:sleeping_function_called_from_invalid_context_at_kernel/locking/mutex.c

FYI, we noticed the following commit: commit: 31cdaa587d8ea13f02f357ed5a95958889b18df3 ("ipv6: sr: fix BUG in HMAC init when preemption is enabled") url: https://github.com/0day-ci/linux/commits/David-Lebrun/ipv6-sr-fix-BUG-in-HMAC-init-when-preemption-is-enabled/20170111-000430 in testcase:

Re: [PATCHv2 perf/core 5/7] tools lib bpf: Add bpf_program__pin()

On 2017/1/25 9:04, Wangnan (F) wrote: On 2017/1/23 9:11, Joe Stringer wrote: Add a new API to pin a BPF program to the filesystem. The user can specify the path full path within a BPF filesystem to pin the program. Programs with multiple instances are pinned as 'foo', 'foo_1', 'foo_2', and

Re: [PATCHv2 perf/core 5/7] tools lib bpf: Add bpf_program__pin()

On 2017/1/23 9:11, Joe Stringer wrote: Add a new API to pin a BPF program to the filesystem. The user can specify the path full path within a BPF filesystem to pin the program. Programs with multiple instances are pinned as 'foo', 'foo_1', 'foo_2', and so on. Signed-off-by: Joe Stringer

Re: [PATCHv2 perf/core 0/7] Libbpf improvements

On 24 January 2017 at 08:12, Arnaldo Carvalho de Melo wrote: > Em Sun, Jan 22, 2017 at 05:11:21PM -0800, Joe Stringer escreveu: >> Patch 1 fixes an issue when using drastically different BPF map definitions >> inside ELFs from a client using libbpf, vs the map definition libbpf

RE: [PATCH v8 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

We really want to thank the community for all the time, effort and very valuable feedback provided. This wouldn't have been possible without each and every one of you. A big thank you to all ya'all ! --ttfn Simon Edelhaus Aquantia Corporation -Original Message- From: David Miller

Re: [PATCH v2] bpf: Restrict cgroup bpf hooks to the init netns

On 1/24/17 5:11 PM, Alexei Starovoitov wrote: > I think bpf_get_sock_netns_id() helper or sk->netns_id field would > be good addition as well, since it will allow 'ip vrf' to be smarter today. > It's also more flexible, since bpf_type_cgroup_sock program can make > its own decision when netns_id

Re: [PATCH v2] bpf: Restrict cgroup bpf hooks to the init netns

On Tue, Jan 24, 2017 at 01:24:54PM -0800, Andy Lutomirski wrote: > On Tue, Jan 24, 2017 at 12:29 PM, David Ahern > wrote: > > > > Users do not run around exec'ing commands in random network contexts > > (namespace, vrf, device, whatever) and expect them to just work. >

Re: [PATCH 3/5] gtp: fix cross netns recv on gtp socket

Hi Andreas, [auto build test ERROR on net-next/master] [also build test ERROR on v4.10-rc5 next-20170124] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andreas-Schultz/simple-gtp-improvements

Re: [PATCH 18/18] netvsc: call netif_receive_skb

On Tue, 2017-01-24 at 15:00 -0800, Stephen Hemminger wrote: > On Tue, 24 Jan 2017 14:39:19 -0800 > Eric Dumazet wrote: > > > On Tue, 2017-01-24 at 13:06 -0800, Stephen Hemminger wrote: > > > To improve performance, netvsc can call network stack directly and > > > avoid

Re: [PATCH 18/18] netvsc: call netif_receive_skb

On Tue, 24 Jan 2017 14:39:19 -0800 Eric Dumazet wrote: > On Tue, 2017-01-24 at 13:06 -0800, Stephen Hemminger wrote: > > To improve performance, netvsc can call network stack directly and > > avoid the local backlog queue. This is safe since incoming packets are > >

[PATCH net-next] tcp: reduce skb overhead in selected places

From: Eric Dumazet tcp_add_backlog() can use skb_condense() helper to get better gains and less SKB_TRUESIZE() magic. This only happens when socket backlog has to be used. Some attacks involve specially crafted out of order tiny TCP packets, clogging the ofo queue of (many)

Re: [PATCH net-next 00/18] netvsc driver enhancements for net-next

On Tue, 24 Jan 2017 16:30:05 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Tue, 24 Jan 2017 13:05:57 -0800 > > > Lots of little things in here. Support for minor more ethtool control, > > negotiation of offload parameters

Re: [PATCH 18/18] netvsc: call netif_receive_skb

On Tue, 2017-01-24 at 13:06 -0800, Stephen Hemminger wrote: > To improve performance, netvsc can call network stack directly and > avoid the local backlog queue. This is safe since incoming packets are > handled in softirq context already because the receive function > callback is called from a

Re: [PATCH net] net: dsa: Keep a reference count on ethernet_dev

On 01/24/2017 09:39 AM, David Miller wrote: > From: Florian Fainelli > Date: Sat, 21 Jan 2017 09:40:54 -0800 > >> of_find_net_device_by_node() just returns a reference to a net_device but >> does >> not increment its reference count, which means that the master network

Re: [PATCH v2] bpf: Restrict cgroup bpf hooks to the init netns

Hello, Andy. On Tue, Jan 24, 2017 at 10:54:03AM -0800, Andy Lutomirski wrote: > Tejun, I can see two basic ways that cgroup+bpf delegation could work > down the road. Both depend on unprivileged users being able to load > BPF programs of the correct type, but that's mostly a matter of > auditing

Re: [PATCH net-next 00/18] netvsc driver enhancements for net-next

On Tue, 24 Jan 2017 16:30:05 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Tue, 24 Jan 2017 13:05:57 -0800 > > > Lots of little things in here. Support for minor more ethtool control, > > negotiation of offload parameters

Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k

On Tue, Jan 24, 2017 at 04:10:46PM -0500, David Miller wrote: > This works in the regimen that XDP packets always live in exactly one > page. That will be needed to mmap the RX ring into userspace, and it > helps make adjust_header trivial as well. I think the point was to avoid resets across

Re: [PATCH v2] bpf: Restrict cgroup bpf hooks to the init netns

On 1/24/17 2:24 PM, Andy Lutomirski wrote: > I was hoping for an actual likely use case for the bpf hooks to be run > in all namespaces. You're arguing that iproute2 can be made to work > mostly okay if bpf hooks can run in all namespaces, but the use case > of intentionally making

Re: [PATCH net-next 0/5] External MDIO support for mv88e6xxx

From: Vivien Didelot Date: Tue, 24 Jan 2017 16:24:55 -0500 > David Miller writes: > >> And maybe I should apply patches aggressively, as this lights a fire >> under everyone's butt and people review and fix things more quickly. > >

Re: [PATCH net-next 00/18] netvsc driver enhancements for net-next

From: Stephen Hemminger Date: Tue, 24 Jan 2017 13:05:57 -0800 > Lots of little things in here. Support for minor more ethtool control, > negotiation of offload parameters with host (based on FreeBSD) and > several cleanups. Series applied, but two comments for

Re: [PATCH] ibmveth: Add a proper check for the availability of the checksum features

On 01/24/2017 12:28 AM, Thomas Huth wrote: > When using the ibmveth driver in a KVM/QEMU based VM, it currently > always prints out a scary error message like this when it is started: > > ibmveth 7103 (unregistered net_device): unable to change > checksum offload settings. 1 rc=-2

Re: [PATCH v2] bpf: Restrict cgroup bpf hooks to the init netns

On Tue, Jan 24, 2017 at 12:29 PM, David Ahern wrote: > > Users do not run around exec'ing commands in random network contexts > (namespace, vrf, device, whatever) and expect them to just work. I worked on some code once (deployed in production, even!) that calls

Re: [PATCH net-next 0/5] External MDIO support for mv88e6xxx

Hi David, David Miller writes: >> Andrew just replied to my comment an hour ago, and I still have concerns >> about the patchset. I didn't like the list_head of busses, and the 6352 >> family don't support the external mode. That needed to be addressed. >> >> Why such an

Re: [PATCH net v3 0/2] net: Fix oops on state free after lwt module unload

From: Robert Shearman Date: Tue, 24 Jan 2017 16:26:46 + > An oops is seen in lwtstate_free after an lwt ops module has been > unloaded. This patchset fixes this by preventing modules implementing > lwtunnel ops from being unloaded whilst there's state alive using >

Re: [PATCH v5 2/3] Bluetooth: btusb: Add out-of-band wakeup support

Hi Rajat, On Thu, Jan 12, 2017 at 10:01:06AM -0800, Rajat Jain wrote: > Some onboard BT chips (e.g. Marvell 8997) contain a wakeup pin that > can be connected to a gpio on the CPU side, and can be used to wakeup > the host out-of-band. This can be useful in situations where the > in-band wakeup

Re: [PATCH net] net: free ip_vs_dest structs when refcnt=0

From: Julian Anastasov Date: Tue, 24 Jan 2017 23:14:29 +0200 (EET) > The changes look ok to me but as this is a net-next > material I also prefer some comments in the code to be updated: It also needs to be posted to netfilter-devel with the IPVS maintainer CC:'d

[PATCH net 2/3] qed: Read queue state before releasing buffer

From: Ram Amrani Currently the state is read only after the buffers are relesed. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 12 ++-- 1 file changed, 6

[PATCH net 0/3] qed: RoCE infrastrucutre fixes

This series contains three RoCE bug fixes that improve stability and robustness. Dave, Please consider applying these to 'net'. Thanks, Yuval Ram Amrani (3): qed: on failure release CQ resource under lock qed: read queue state before releasing buffer qed: don't free a QP more than once

Re: [PATCH net v1 0/6] topology server fixes for nametable soft lockup

From: Parthasarathy Bhuvaragan Date: Tue, 24 Jan 2017 13:00:42 +0100 > In this series, we revert the commit 333f796235a527 ("tipc: fix a > race condition leading to subscriber refcnt bug") and provide an > alternate solution to fix the race conditions in

[PATCH net 1/3] qed: Release CQ resource under lock on failure

From: Ram Amrani The CQ resource pool is protected by a spin lock. When a CQ creation fails it now deallocates under that lock as well. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz ---

[PATCH net 3/3] qed: Don't free a QP more than once

From: Ram Amrani If QP is in reset state then there are no resources to free so avoid freeing any. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 49

Re: [PATCH net] net: free ip_vs_dest structs when refcnt=0

Hello, On Tue, 24 Jan 2017, David Windsor wrote: > Currently, the ip_vs_dest cache frees ip_vs_dest objects when their reference > count becomes < 0. Aside from not being semantically sound, this is > problematic > for the new type refcount_t, which will be introduced shortly in a

[PATCH 16/18] netvsc: report per-channel stats in ethtool statistics

From: Simon Xiao Report packets and bytes transferred through a vmbus channel via ethtool. This supersedes need for per-cpu statistics. Example: $ ethtool -S eth0 NIC statistics: ... tx_queue_0_packets: 3523179 tx_queue_0_bytes: 505370920 rx_queue_0_packets:

[PATCH 14/18] netvsc: eliminate per-device outstanding send counter

Since now keep track of per-queue outstanding sends, we can avoid one atomic update by removing no longer needed per-device atomic. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 1 - drivers/net/hyperv/netvsc.c | 44

[PATCH 15/18] netvsc: account for packets/bytes transmitted after completion

Most drivers do not increment transmit statistics until after the transmit is completed. This will also be necessary for BQL support. Slight additional complexity because the netvsc driver aggregates multiple packets into one transmit. Signed-off-by: Stephen Hemminger

Re: [PATCH net-next 0/5] External MDIO support for mv88e6xxx

Hi David, David Miller writes: > Series applied, thanks Andrew. > > There seems to be a bit of inconsistency wrt. tab vs. space for > indentation in the binding files, just FYI. I had to make some small > adjustments to this patch series in order to keep GIT from warning >

Re: [PATCH] cxgbit: use T6 specific macro to set force bit

On Tue, 2017-01-24 at 17:07 +0530, Varun Prakash wrote: > For T6 adapters use T6 specific macro to set > force bit. [] > diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h > b/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h [] > @@ -1349,6 +1349,10 @@ struct cpl_tx_data { > #define TX_FORCE_S

Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k

From: "Michael S. Tsirkin" Date: Tue, 24 Jan 2017 23:07:51 +0200 > On Tue, Jan 24, 2017 at 03:53:31PM -0500, David Miller wrote: >> From: "Michael S. Tsirkin" >> Date: Tue, 24 Jan 2017 22:45:37 +0200 >> >> > On Tue, Jan 24, 2017 at 03:09:59PM -0500, David

Re: [PATCH net-next 0/5] External MDIO support for mv88e6xxx

From: David Miller Date: Tue, 24 Jan 2017 16:07:50 -0500 (EST) > From: Vivien Didelot > Date: Tue, 24 Jan 2017 16:05:08 -0500 > >> Hi David, >> >> David Miller writes: >> >>> Series applied, thanks Andrew. >>>

[PATCH 09/18] netvsc: remove unused variables

Fixes set but never used warnings Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 4 drivers/net/hyperv/rndis_filter.c | 3 --- 2 files changed, 7 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c

[PATCH 08/18] netvsc: enhance transmit select_queue

The netvsc select queue function was missing many of the flow caching features that exist in default tx queue selection. Add the same logic to remember queue based on socket and implement two level mapping (like RSS). Signed-off-by: Stephen Hemminger ---

[PATCH 01/18] netvsc: remove no longer needed receive staging buffers

The ring buffer mapping now handles the wraparound case inside get_next_pkt_raw. Therefore it is not necessary to have an additional special receive staging buffer. See commit 1562edaed8c164ca5199 ("Drivers: hv: ring_buffer: count on wrap around mappings") Signed-off-by: Stephen Hemminger

[PATCH 05/18] netvsc: add ethtool ops to get/set RSS key

For some cases it is useful to be able to change RSS key value. For example, replacing RSS key with a symmetric hash. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 7 +- drivers/net/hyperv/netvsc_drv.c | 46

[PATCH 10/18] netvsc: group all per-channel state together

Put all the per-channel state together in one data struct. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 14 +--- drivers/net/hyperv/netvsc.c | 73 +++ drivers/net/hyperv/netvsc_drv.c | 5 ++-

[PATCH 17/18] netvsc: simplify get next send section

Use kernel for_each_clear_bit macro to simplify finding next available send section. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git

[PATCH 06/18] netvsc: allow more flexible setting of number of channels

This allows for number of channels to be managed in a manner similar to existing hardware drivers. It also removes the restriction of maximum 8 channels and allows as many as the host will allow. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 1

Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k

On Tue, Jan 24, 2017 at 03:53:31PM -0500, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Tue, 24 Jan 2017 22:45:37 +0200 > > > On Tue, Jan 24, 2017 at 03:09:59PM -0500, David Miller wrote: > >> From: "Michael S. Tsirkin" > >> Date: Tue, 24 Jan 2017

[PATCH 18/18] netvsc: call netif_receive_skb

To improve performance, netvsc can call network stack directly and avoid the local backlog queue. This is safe since incoming packets are handled in softirq context already because the receive function callback is called from a tasklet. Signed-off-by: Stephen Hemminger

[PATCH 07/18] netvsc: allow get/set of RSS indirection table

Allow setting receive indirection table. Also uses the system standard for initialization. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 1 + drivers/net/hyperv/netvsc_drv.c | 26 +++--- drivers/net/hyperv/rndis_filter.c

[PATCH 02/18] netvsc: negotiate checksum and segmentation parameters

Redo how Hyper-V network driver negotiates offload features. Query the host to determine offload settings, and use the result. Also: * disable IPv4 header checksum offload (not used by Linux) * enable TSO only if host supports * enable UDP checksum offload if supported * don't advertise

  1   2   3   4   >