Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data

2017-01-26 Thread Kalle Valo
Pali Rohár writes: > In case there is no valid MAC address kernel generates random one. This > patch propagate this generated MAC address back to NVS data which will be > uploaded to wl1251 chip. So HW would have same MAC address as linux kernel > uses. > > Signed-off-by:

Re: [PATCH 5/6] wl1251: Parse and use MAC address from supplied NVS data

2017-01-26 Thread Kalle Valo
Pali Rohár writes: > This patch implements parsing MAC address from NVS data which are sent to > wl1251 chip. Calibration NVS data could contain valid MAC address and it > will be used instead randomly generated. > > This patch also move code for requesting NVS data from

Re: netvsc NAPI patch process

2017-01-26 Thread Greg KH
On Thu, Jan 26, 2017 at 01:06:46PM -0500, David Miller wrote: > From: Stephen Hemminger > Date: Thu, 26 Jan 2017 10:04:05 -0800 > > > I have a working set of patches to enable NAPI in the netvsc driver. > > The problem is that it requires a set of patches to vmbus

[PATCH v2] net: phy: micrel: add support for KSZ8795

2017-01-26 Thread Sean Nyekjaer
This is adds support for the PHYs in the KSZ8795 5port managed switch. It will allow to detect the link between the switch and the soc and uses the same read_status functions as the KSZ8873MLL switch. Signed-off-by: Sean Nyekjaer --- Changes in v2: - Removed "switch"

Re: [PATCH v2 0/4] USB support for Broadcom NSP SoC

2017-01-26 Thread Kishon Vijay Abraham I
Hi, On Thursday 26 January 2017 10:57 PM, Florian Fainelli wrote: > On 01/26/2017 07:34 AM, Kishon Vijay Abraham I wrote: >> >> >> On Tuesday 17 January 2017 09:44 PM, Yendapally Reddy Dhananjaya Reddy wrote: >>> This patch set contains the usb support for Broadcom NSP SoC. The >>> usb3 phy is

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-26 Thread Kalle Valo
Pali Rohár writes: > NVS calibration data for wl1251 are model specific. Every one device with > wl1251 chip has different and calibrated in factory. > > Not all wl1251 chips have own EEPROM where are calibration data stored. And > in that case there is no "standard" place.

Re: [PATCH net-next] net: Fix ndo_setup_tc comment

2017-01-26 Thread Jiri Pirko
Thu, Jan 26, 2017 at 11:44:17PM CET, f.faine...@gmail.com wrote: >Commit 16e5cc647173 ("net: rework setup_tc ndo op to consume >general tc operand") changed the ndo_setup_tc() signature, but did not >update the comments in netdevice.h, so do that now. > >Signed-off-by: Florian Fainelli

[PATCH RFC ipsec-next 1/2] net: Drop secpath on free after gro merge.

2017-01-26 Thread Steffen Klassert
With a followup patch, a gro merged skb can have a secpath. So drop it before freeing or reusing the skb. Signed-off-by: Steffen Klassert --- net/core/dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 56818f7..ef3a969

[PATCH RFC ipsec-next 2/2] xfrm: Add a dummy network device for napi.

2017-01-26 Thread Steffen Klassert
This patch adds a dummy network device so that we can use gro_cells for IPsec GRO. With this, we handle IPsec GRO with no impact on the generic networking code. Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_input.c | 12 +++- 1 file changed, 11

[PATCH RFC ipsec-next v2] IPsec GRO

2017-01-26 Thread Steffen Klassert
This adds a dummy network device so that we can use gro_cells for IPsec GRO. We now may have a secpath at a GRO merged skb, so we need to drop it. This is the only change to the generic networking code. The packet still travels two times through the stack, but might be aggregated in the second

Re: [PATCH RFC ipsec-next 2/2] xfrm: Add a device independent napi instance

2017-01-26 Thread Steffen Klassert
On Thu, Jan 26, 2017 at 07:10:22AM -0800, Eric Dumazet wrote: > On Thu, 2017-01-26 at 06:26 -0800, Eric Dumazet wrote: > > > > > Alternative would be to use a > > > > static struct net_device xfrm_napi_anchor_device; > > > > and use gro_cell > > Also take a look at init_dummy_netdev() I

Re: fs, net: deadlock between bind/splice on af_unix

2017-01-26 Thread Mateusz Guzik
On Thu, Jan 26, 2017 at 09:11:07PM -0800, Cong Wang wrote: > On Thu, Jan 26, 2017 at 3:29 PM, Mateusz Guzik wrote: > > On Tue, Jan 17, 2017 at 01:21:48PM -0800, Cong Wang wrote: > >> On Mon, Jan 16, 2017 at 1:32 AM, Dmitry Vyukov wrote: > >> > On Fri, Dec

Re: [PATCH net-next 3/4] mlx5: Make building tc hardware offload configurable

2017-01-26 Thread kbuild test robot
Hi Tom, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/mlx5-Create-build-configuration-options/20170127-084348 config: x86_64-randconfig-s3-01271208 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

RE: [patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-26 Thread Yotam Gigi
>-Original Message- >From: Cong Wang [mailto:xiyou.wangc...@gmail.com] >Sent: Thursday, January 26, 2017 1:30 AM >To: Jiri Pirko >Cc: Linux Kernel Network Developers ; David Miller >; Yotam Gigi ; Ido

Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

2017-01-26 Thread Harini Katakam
Hi Rafal, On Thu, Jan 26, 2017 at 8:45 PM, Rafal Ozieblo wrote: >> -Original Message- >> From: Andrei Pistirica [mailto:andrei.pistir...@microchip.com] >> Sent: 19 stycznia 2017 16:56 >> Subject: [PATCH net-next v2] macb: Common code to enable ptp support for >>

Re: [PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-26 Thread Or Gerlitz
On Fri, Jan 27, 2017 at 1:32 AM, Tom Herbert wrote: > Add a configuration option (CONFIG_MLX5_CORE_ESWITCH) for controlling > whether the eswitch code is built. Change Kconfig and Makefile > accordingly. Tom, FWIW, please note that the basic e-switch functionality is needed

Re: fs, net: deadlock between bind/splice on af_unix

2017-01-26 Thread Cong Wang
On Thu, Jan 26, 2017 at 3:29 PM, Mateusz Guzik wrote: > On Tue, Jan 17, 2017 at 01:21:48PM -0800, Cong Wang wrote: >> On Mon, Jan 16, 2017 at 1:32 AM, Dmitry Vyukov wrote: >> > On Fri, Dec 9, 2016 at 7:41 AM, Al Viro wrote: >> >>

[PATCHv5 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs

2017-01-26 Thread Chris Packham
The Marvell 98DX3236, 98DX3336, 98DX4521 and variants are switch ASICs with integrated CPUs. They are similar to the Armada XP SoCs but have different I/O interfaces. Signed-off-by: Chris Packham Acked-by: Rob Herring --- Notes: Changes

Re: loopback device reference count leakage

2017-01-26 Thread Kaiwen Xu
On Thu, Jan 26, 2017 at 05:01:38PM -0800, Cong Wang wrote: > I'd suggest to you add some debugging printk's to the dst refcount functions, > or maybe just inside dst_gc_task(). I think the last dst referring to > the loopback > dev is still being referred at that point, which prevents GC from

cls_matchall and port mirroring questions

2017-01-26 Thread Florian Fainelli
Hi, As I am adding support for cls_matchall in the b53/bcm_sf2 drivers, I was looking into several, yet unrelated things: - mlxsw does not seem to specify whether the port used for capture remains usable, or blocks non-mirror traffic ingressing/egressing it, do we want a control knob for that?

Re: [PATCH net-next] net: adjust skb->truesize in pskb_expand_head()

2017-01-26 Thread Eric Dumazet
On Fri, 2017-01-27 at 10:22 +0800, kbuild test robot wrote: > Hi Eric, > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-adjust-skb-truesize-in-pskb_expand_head/20170127-082517 > config: i386-randconfig-x0-01270914 (attached

Re: [PATCH net-next] net: adjust skb->truesize in pskb_expand_head()

2017-01-26 Thread kbuild test robot
Hi Eric, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-adjust-skb-truesize-in-pskb_expand_head/20170127-082517 config: i386-randconfig-x0-01270914 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

Re: [net-next] openvswitch: Simplify do_execute_actions().

2017-01-26 Thread Jarno Rajahalme
Nice clean-up. Acked-by: Jarno Rajahalme > On Jan 25, 2017, at 9:24 PM, Andy Zhou wrote: > > do_execute_actions() implements a worthwhile optimization: in case > an output action is the last action in an action list, skb_clone() > can be avoided by outputing the

Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver

2017-01-26 Thread Sowmini Varadhan
On (01/26/17 19:08), Willem de Bruijn wrote: > > Thanks for the context. ax25_addr_parse doesn't adjust length, it only > verifies that the contents of the variable length header matches > protocol spec. I don't think that it or the .validate callback have to > be modified to return length. Yes,

Re: loopback device reference count leakage

2017-01-26 Thread Cong Wang
On Thu, Jan 26, 2017 at 2:51 PM, Kaiwen Xu wrote: > Hi Cong, > > I tested out your patch, it does seem to be preventing the issue from > happening. Here are the dev_put/dev_hold() calls with your patch > applied. Good. Now we narrow down the bug to those dst's referring

Re: [1/3] powerpc: bpf: remove redundant check for non-null image

2017-01-26 Thread Michael Ellerman
On Fri, 2017-01-13 at 17:10:00 UTC, "Naveen N. Rao" wrote: > From: Daniel Borkmann > > We have a check earlier to ensure we don't proceed if image is NULL. As > such, the redundant check can be removed. > > Signed-off-by: Daniel Borkmann > [Added

Re: [2/3] powerpc: bpf: flush the entire JIT buffer

2017-01-26 Thread Michael Ellerman
On Fri, 2017-01-13 at 17:10:01 UTC, "Naveen N. Rao" wrote: > With bpf_jit_binary_alloc(), we allocate at a page granularity and fill > the rest of the space with illegal instructions to mitigate BPF spraying > attacks, while having the actual JIT'ed BPF program at a random location > within the

[PATCH net-next 4/4] mlx5: Make building vxlan hardware offload configurable

2017-01-26 Thread Tom Herbert
Add a configuration option (CONFIG_MLX5_CORE_EN_UDP_ENCAP_OFFLOAD) for controlling whether the support for UDP encapsulation offlaod is supported. Note that only VXLAN offload is supported currently, however the config option is named to be generic for UDP offloads. Signed-off-by: Tom Herbert

[PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-26 Thread Tom Herbert
Add a configuration option (CONFIG_MLX5_CORE_ESWITCH) for controlling whether the eswitch code is built. Change Kconfig and Makefile accordingly. Signed-off-by: Tom Herbert --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 11 +++

[PATCH net-next] net: adjust skb->truesize in pskb_expand_head()

2017-01-26 Thread Eric Dumazet
From: Eric Dumazet Slava Shwartsman reported a warning in skb_try_coalesce(), when we detect skb->truesize is completely wrong. In his case, issue came from IPv6 reassembly coping with malicious datagrams, that forced various pskb_may_pull() to reallocate a bigger skb->head

Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver

2017-01-26 Thread Willem de Bruijn
On Thu, Jan 26, 2017 at 4:37 PM, Sowmini Varadhan wrote: > On (01/26/17 15:21), Willem de Bruijn wrote: >> > If the application has provided fewer than hard_header_len bytes, >> > dev_validate_header() will zero out the skb->data as needed. This is >> > acceptable for

[PATCH net-next 2/4] mlx5: Make building SR-IOV configurable

2017-01-26 Thread Tom Herbert
Add a configuration option (CONFIG_MLX5_CORE_EN_SRIOV) for controlling whether the eswitch code is built. Change Kconfig and Makefile accordingly. Signed-off-by: Tom Herbert --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 8

[PATCH net-next 3/4] mlx5: Make building tc hardware offload configurable

2017-01-26 Thread Tom Herbert
Add a configuration option (CONFIG_MLX5_CORE_EN_TC) for controlling whether the eswitch code is built. Change Kconfig and Makefile accordingly. Signed-off-by: Tom Herbert --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 8

Re: [PATCH v5 net] ravb: unmap descriptors when freeing rings

2017-01-26 Thread David Miller
From: Simon Horman Date: Thu, 26 Jan 2017 14:29:27 +0100 > From: Kazuya Mizuguchi > > "swiotlb buffer is full" errors occur after repeated initialisation of a > device - f.e. suspend/resume or ip link set up/down. This is because

[PATCH net-next 0/4] mlx5: Create build configuration options

2017-01-26 Thread Tom Herbert
This patchset creates configuration options for sriov, vxlan, eswitch, and tc features in the mlx5 driver. The purpose of this is to allow not building these features. These features are optional advanced features that are not required for a core Ethernet driver. A user can disable these features

Re: [PATCH net-next v2] net: ipv6: ignore null_entry on route dumps

2017-01-26 Thread David Miller
From: David Ahern Date: Thu, 26 Jan 2017 13:54:08 -0800 > Dave: per last email you suggested putting this in fib6_dump_node, but > fib6_dump_node does not have knowledge of the network namespace > because of the way the fib_walker works. I could put >

Re: [PATCH net-next] net: ipv6: remove skb_reserve in getroute

2017-01-26 Thread David Miller
From: David Ahern Date: Thu, 26 Jan 2017 14:08:36 -0800 > Remove skb_reserve and skb_reset_mac_header from inet6_rtm_getroute. The > allocated skb is not passed through the routing engine (like it is for > IPv4) and has not since the beginning of git time. > >

Re: fs, net: deadlock between bind/splice on af_unix

2017-01-26 Thread Mateusz Guzik
On Tue, Jan 17, 2017 at 01:21:48PM -0800, Cong Wang wrote: > On Mon, Jan 16, 2017 at 1:32 AM, Dmitry Vyukov wrote: > > On Fri, Dec 9, 2016 at 7:41 AM, Al Viro wrote: > >> On Thu, Dec 08, 2016 at 10:32:00PM -0800, Cong Wang wrote: > >> > >>> > Why do

Re: [PATCH net-next] net: Fix ndo_setup_tc comment

2017-01-26 Thread John Fastabend
On 17-01-26 02:44 PM, Florian Fainelli wrote: > Commit 16e5cc647173 ("net: rework setup_tc ndo op to consume > general tc operand") changed the ndo_setup_tc() signature, but did not > update the comments in netdevice.h, so do that now. > > Signed-off-by: Florian Fainelli >

Re: loopback device reference count leakage

2017-01-26 Thread Kaiwen Xu
Hi Cong, I tested out your patch, it does seem to be preventing the issue from happening. Here are the dev_put/dev_hold() calls with your patch applied. Jan 26 00:29:08 kernel: [ 4385.940243] lo: dev_hold 1 rx_queue_add_kobject Jan 26 00:29:08 kernel: [ 4385.940255] lo: dev_hold 2

Re: [PATCHv3 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs

2017-01-26 Thread Chris Packham
On 27/01/17 09:24, Chris Packham wrote: > On 27/01/17 04:10, Gregory CLEMENT wrote: >>> + internal-regs { > > [snip] > >>> + >>> + dfx-registers { >> node label >> > > [snip] > >>> + switch { >> node label >> > > These are peers to the internal-regs, i.e. parts of the

[PATCH net-next] net: Fix ndo_setup_tc comment

2017-01-26 Thread Florian Fainelli
Commit 16e5cc647173 ("net: rework setup_tc ndo op to consume general tc operand") changed the ndo_setup_tc() signature, but did not update the comments in netdevice.h, so do that now. Signed-off-by: Florian Fainelli --- include/linux/netdevice.h | 11 ++- 1 file

Re: [PATCH net-next] net: ipv6: remove skb_reserve in getroute

2017-01-26 Thread Eric Dumazet
On Thu, 2017-01-26 at 14:08 -0800, David Ahern wrote: > Remove skb_reserve and skb_reset_mac_header from inet6_rtm_getroute. The > allocated skb is not passed through the routing engine (like it is for > IPv4) and has not since the beginning of git time. > > Signed-off-by: David Ahern

[PATCH V3 net-next 01/14] net/ena: remove ntuple filter support from device feature list

2017-01-26 Thread Netanel Belgazal
Remove NETIF_F_NTUPLE from netdev->features. The ENA device driver does not support ntuple filtering. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails

2017-01-26 Thread Netanel Belgazal
When driver fails in probe, it will release all resources, including adapter. In case of probe failure, ena_remove should not try to free the adapter resources. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + 1 file changed, 1

[PATCH V3 net-next 03/14] net/ena: fix queues number calculation

2017-01-26 Thread Netanel Belgazal
The ENA driver tries to open a queue per vCPU. To determine how many vCPUs the instance have it uses num_possible_cpus() while it should have use num_online_cpus() instead. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file

[PATCH V3 net-next 00/14] Bug Fixes in ENA driver.

2017-01-26 Thread Netanel Belgazal
Changes between V3 and V2: * Fix typos and correct alignment in commit messages. * use napi_complete_done() return value to determine when the napi handler needs to unmask the interrupts rather than implementing non standard solution. * Remove new features from this patchset and leave bug fixes

[PATCH V3 net-next 04/14] net/ena: fix ethtool RSS flow configuration

2017-01-26 Thread Netanel Belgazal
ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power of two values. This bug effect the ethtool set/get rxnfc. ethtool will report wrong values hash fields for get

[PATCH V3 net-next 09/14] net/ena: use napi_complete_done() return value

2017-01-26 Thread Netanel Belgazal
Do not unamsk interrupts if we are in busy poll mode. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 44 ++-- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git

[PATCH V3 net-next 06/14] net/ena: fix NULL dereference when removing the driver after device reset failed

2017-01-26 Thread Netanel Belgazal
If for some reason the device stops responding, and the device reset failes to recover the device, the mmio register read data structure will not be reinitialized. On driver removal, the driver will also try to reset the device, but this time the mmio data structure will be NULL. To solve this

[PATCH V3 net-next 05/14] net/ena: fix RSS default hash configuration

2017-01-26 Thread Netanel Belgazal
ENA default hash configures IPv4_frag hash twice instead of configure non-IP packets. The bug caused IPv4 fragmented packets to be calculated based on L2 source and destination address instead of L3 source and destination. IPv4 packets can reach to the wrong Rx queue. Signed-off-by: Netanel

[PATCH V3 net-next 08/14] net/ena: fix potential access to freed memory during device reset

2017-01-26 Thread Netanel Belgazal
If the ena driver detects that the device is not behave as expected, it tries to reset the device. The reset flow calls ena_down, which will frees all the resources the driver allocates and then it will reset the device. This flow can cause memory corruption if the device is still writes to the

[PATCH V3 net-next 07/14] net/ena: refactor ena_get_stats64 to be atomic context safe

2017-01-26 Thread Netanel Belgazal
ndo_get_stat64() can be called from atomic context, but the current implementation sends an admin command to retrieve the statistics from the device. This admin command can sleep. This patch re-factors the implementation of ena_get_stats64() to use the {rx,tx}bytes/count from the driver's inner

[PATCH V3 net-next 10/14] net/ena: use READ_ONCE to access completion descriptors

2017-01-26 Thread Netanel Belgazal
Completion descriptors are accessed from the driver and from the device. To avoid reading the old value, use READ_ONCE macro. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.h | 1 + drivers/net/ethernet/amazon/ena/ena_eth_com.c | 8

[PATCH V3 net-next 12/14] net/ena: change driver's default timeouts

2017-01-26 Thread Netanel Belgazal
The timeouts were too agressive and sometimes cause false alarms. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c| 4 ++-- drivers/net/ethernet/amazon/ena/ena_netdev.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff

[PATCH V3 net-next 14/14] net/ena: update driver version to 1.1.2

2017-01-26 Thread Netanel Belgazal
Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h index efe0ea1..ed62d8e

[PATCH V3 net-next 11/14] net/ena: reduce the severity of ena printouts

2017-01-26 Thread Netanel Belgazal
Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c| 27 +-- drivers/net/ethernet/amazon/ena/ena_netdev.c | 14 +++--- 2 files changed, 28 insertions(+), 13 deletions(-) diff --git

[PATCH V3 net-next 13/14] net/ena: change condition for host attribute configuration

2017-01-26 Thread Netanel Belgazal
Move the host info config to be the first admin command that is executed. This change require the driver to remove the 'feature check' from host info configuration flow. The check is removed since the supported features bitmask field is retrieved only after calling ENA_ADMIN_DEVICE_ATTRIBUTES

[PATCH net-next] net: ipv6: remove skb_reserve in getroute

2017-01-26 Thread David Ahern
Remove skb_reserve and skb_reset_mac_header from inet6_rtm_getroute. The allocated skb is not passed through the routing engine (like it is for IPv4) and has not since the beginning of git time. Signed-off-by: David Ahern --- net/ipv6/route.c | 6 -- 1 file

Re: TCP stops sending packets over loopback on 4.10-rc3?

2017-01-26 Thread Josef Bacik
On Wed, 2017-01-25 at 06:39 -0800, Eric Dumazet wrote: > On Wed, 2017-01-25 at 09:26 -0500, Josef Bacik wrote: > > > > > Nope ftrace isn't broken, I'm just dumb, the space is being > > reclaimed  > > by sk_wmem_free_skb().  So I guess I need to figure out why I stop  > > getting ACK's from the

[PATCH net] tcp: don't annotate mark on control socket from tcp_v6_send_response()

2017-01-26 Thread Pablo Neira Ayuso
Unlike ipv4, this control socket is shared by all cpus so we cannot use it as scratchpad area to annotate the mark that we pass to ip6_xmit(). Add a new parameter to ip6_xmit() to indicate the mark. The SCTP socket family caches the flowi6 structure in the sctp_transport structure, so we cannot

[PATCH net-next v2] net: ipv6: ignore null_entry on route dumps

2017-01-26 Thread David Ahern
lkp-robot reported a BUG: [ 10.151226] BUG: unable to handle kernel NULL pointer dereference at 0198 [ 10.152525] IP: rt6_fill_node+0x164/0x4b8 [ 10.153307] *pdpt = 12ee5001 *pde = [ 10.153309] [ 10.154492] Oops: [#1] [ 10.154987] CPU: 0 PID: 909 Comm:

Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver

2017-01-26 Thread Sowmini Varadhan
On (01/26/17 15:21), Willem de Bruijn wrote: > > If the application has provided fewer than hard_header_len bytes, > > dev_validate_header() will zero out the skb->data as needed. This is > > acceptable for SOCK_DGRAM/PF_PACKET sockets but in all other cases, > > This was added not for datagram

Re: netvsc NAPI patch process

2017-01-26 Thread David Miller
From: KY Srinivasan Date: Thu, 26 Jan 2017 20:46:40 + > In the past, we have done this in two stages - get the supporting > vmbus patches into Greg's tree first and in the next merge cycle get > the netvsc patches in. Why not continue to do what we have done in > the past

[PATCHv3 perf/core 1/6] tools lib bpf: Add BPF program pinning APIs.

2017-01-26 Thread Joe Stringer
Add new APIs to pin a BPF program (or specific instances) to the filesystem. The user can specify the path full path within a BPF filesystem to pin the program. bpf_program__pin_instance(prog, path, n) will pin the nth instance of 'prog' to the specified path. bpf_program__pin(prog, path) will

[PATCH] net: intel: e1000e: use new api ethtool_{get|set}_link_ksettings

2017-01-26 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/intel/e1000e/ethtool.c | 91

[PATCHv3 perf/core 0/6] Libbpf object pinning

2017-01-26 Thread Joe Stringer
This series adds pinning functionality for maps, programs, and objects. Library users may call bpf_map__pin(map, path) or bpf_program__pin(prog, path) to pin maps and programs separately, or use bpf_object__pin(obj, path) to pin all maps and programs from the BPF object to the path. The map and

[PATCHv3 perf/core 5/6] tools lib api fs: Add bpf_fs filesystem detector

2017-01-26 Thread Joe Stringer
Allow mounting of the BPF filesystem at /sys/fs/bpf. Signed-off-by: Joe Stringer --- v3: Initial post. --- tools/lib/api/fs/fs.c | 16 tools/lib/api/fs/fs.h | 1 + 2 files changed, 17 insertions(+) diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c index

[PATCHv3 perf/core 2/6] tools lib bpf: Add bpf_map__pin()

2017-01-26 Thread Joe Stringer
Add a new API to pin a BPF map to the filesystem. The user can specify the path full path within a BPF filesystem to pin the map. Signed-off-by: Joe Stringer --- v3: No change. v2: Don't automount BPF filesystem Split program, map, object pinning into separate APIs and separate

[PATCHv3 perf/core 6/6] perf test: Add libbpf pinning test

2017-01-26 Thread Joe Stringer
Add a test for the newly added BPF object pinning functionality. For example: # tools/perf/perf test 37 37: BPF filter : 37.1: Basic BPF filtering : Ok 37.2: BPF pinning : Ok 37.3: BPF prologue

[PATCHv3 perf/core 3/6] tools lib bpf: Add bpf_object__pin()

2017-01-26 Thread Joe Stringer
Add a new API to pin a BPF object to the filesystem. The user can specify the path within a BPF filesystem to pin the object. Programs will be pinned under a subdirectory named the same as the program, with each instance appearing as a numbered file under that directory, and maps will be pinned

[PATCHv3 perf/core 4/6] tools perf util: Make rm_rf(path) argument const

2017-01-26 Thread Joe Stringer
rm_rf() doesn't modify its path argument, and a future caller will pass a string constant into it to delete. Signed-off-by: Joe Stringer --- v3: Initial post. --- tools/perf/util/util.c | 2 +- tools/perf/util/util.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH v2 net] net: free ip_vs_dest structs when refcnt=0

2017-01-26 Thread Julian Anastasov
Hello, On Mon, 23 Jan 2017, David Windsor wrote: > Currently, the ip_vs_dest cache frees ip_vs_dest objects when their > reference count becomes < 0. Aside from not being semantically sound, > this is problematic for the new type refcount_t, which will be introduced > shortly in a

RE: netvsc NAPI patch process

2017-01-26 Thread KY Srinivasan
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, January 26, 2017 10:04 AM > To: da...@davemloft.net; KY Srinivasan ; Greg KH > > Cc: netdev@vger.kernel.org > Subject: netvsc NAPI patch process > >

Re: [PATCH 0/6 v3] kvmalloc

2017-01-26 Thread Daniel Borkmann
On 01/26/2017 02:40 PM, Michal Hocko wrote: On Thu 26-01-17 14:10:06, Daniel Borkmann wrote: On 01/26/2017 12:58 PM, Michal Hocko wrote: On Thu 26-01-17 12:33:55, Daniel Borkmann wrote: On 01/26/2017 11:08 AM, Michal Hocko wrote: [...] If you disagree I can drop the bpf part of course...

Re: [PATCH net-next v2 0/4] net: dsa: Preparatory patches

2017-01-26 Thread David Miller
From: Florian Fainelli Date: Thu, 26 Jan 2017 10:45:50 -0800 > This patch series extracts the 4 patches of the larger: net: dsa: Support for > pdata in dsa2 while we wait for feedback from Greg KH on the device > references. > > Changes in v2: > > - rebased properly

Re: [PATCH net-next] liquidio: Avoid accessing skb after submitting to input queue

2017-01-26 Thread David Miller
From: Felix Manlunas Date: Thu, 26 Jan 2017 11:52:35 -0800 > From: Satanand Burla > > Accessing skb after submitting to input queue can cause > access to stale pointers if the skb ends up being transmitted > and freed by that time. > >

Re: [PATCH net-next 1/3] trace: add variant without spacing in trace_print_hex_seq

2017-01-26 Thread Daniel Borkmann
On 01/26/2017 08:53 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jan 25, 2017 at 02:28:16AM +0100, Daniel Borkmann escreveu: For upcoming tracepoint support for BPF, we want to dump the program's tag. Format should be similar to __print_hex(), but without spacing. Add a __print_hex_str() variant

Re: [PATCHv3 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs

2017-01-26 Thread Chris Packham
On 27/01/17 04:10, Gregory CLEMENT wrote: >> +internal-regs { [snip] >> + >> +dfx-registers { > node label > [snip] >> +switch { > node label > These are peers to the internal-regs, i.e. parts of the SoC with mappable windows in the address space. Do they

Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver

2017-01-26 Thread Willem de Bruijn
> If the application has provided fewer than hard_header_len bytes, > dev_validate_header() will zero out the skb->data as needed. This is > acceptable for SOCK_DGRAM/PF_PACKET sockets but in all other cases, This was added not for datagram sockets, but to be able to bypass validation. See the

Re: [PATCHv3 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs

2017-01-26 Thread Chris Packham
On 27/01/17 04:10, Gregory CLEMENT wrote: > Hi Chris, > > On ven., janv. 06 2017, Chris Packham > wrote: > >> The Marvell 98DX3236, 98DX3336, 98DX4521 and variants are switch ASICs >> with integrated CPUs. They are similar to the Armada XP SoCs but have >>

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

2017-01-26 Thread Stephen Hemminger
On Wed, 25 Jan 2017 15:02:19 -0600 Thomas Falcon wrote: > static irqreturn_t ibmvnic_interrupt(int irq, void *instance) > { > struct ibmvnic_adapter *adapter = instance; > + unsigned long flags; > + > + spin_lock_irqsave(>crq.lock, flags); > +

Re: [PATCH net] bpf: expose netns inode to bpf programs

2017-01-26 Thread Alexei Starovoitov
On 1/26/17 11:07 AM, Andy Lutomirski wrote: On Thu, Jan 26, 2017 at 10:32 AM, Alexei Starovoitov wrote: On 1/26/17 10:12 AM, Andy Lutomirski wrote: On Thu, Jan 26, 2017 at 9:46 AM, Alexei Starovoitov wrote: On 1/26/17 8:37 AM, Andy Lutomirski wrote: Think of

Re: [PATCH net-next 1/3] trace: add variant without spacing in trace_print_hex_seq

2017-01-26 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 25, 2017 at 02:28:16AM +0100, Daniel Borkmann escreveu: > For upcoming tracepoint support for BPF, we want to dump the program's > tag. Format should be similar to __print_hex(), but without spacing. > Add a __print_hex_str() variant for exactly that purpose that reuses >

[PATCH net-next] liquidio: Avoid accessing skb after submitting to input queue

2017-01-26 Thread Felix Manlunas
From: Satanand Burla Accessing skb after submitting to input queue can cause access to stale pointers if the skb ends up being transmitted and freed by that time. Signed-off-by: Satanand Burla Signed-off-by: Derek Chickles

Re: [PATCHv2 perf/core 5/7] tools lib bpf: Add bpf_program__pin()

2017-01-26 Thread Joe Stringer
On 26 January 2017 at 11:32, Arnaldo Carvalho de Melo wrote: > Em Wed, Jan 25, 2017 at 10:18:22AM +0800, Wangnan (F) escreveu: >> On 2017/1/25 9:16, Joe Stringer wrote: >> > On 24 January 2017 at 17:06, Wangnan (F) wrote: >> > > On 2017/1/25 9:04, Wangnan

Re: [PATCH net-next 2/3] sfc: refactor debug-or-warnings printks

2017-01-26 Thread David Miller
From: Edward Cree Date: Thu, 26 Jan 2017 17:53:48 + > diff --git a/drivers/net/ethernet/sfc/net_driver.h > b/drivers/net/ethernet/sfc/net_driver.h > index 5927c20..c640955 100644 > --- a/drivers/net/ethernet/sfc/net_driver.h > +++

Re: [PATCHv2 perf/core 5/7] tools lib bpf: Add bpf_program__pin()

2017-01-26 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 25, 2017 at 10:18:22AM +0800, Wangnan (F) escreveu: > On 2017/1/25 9:16, Joe Stringer wrote: > > On 24 January 2017 at 17:06, Wangnan (F) wrote: > > > On 2017/1/25 9:04, Wangnan (F) wrote: > > > Is it possible to use directory tree instead? > > >

Re: [PATCH 0/7] pull request for net-next: batman-adv 2017-01-26

2017-01-26 Thread David Miller
From: Simon Wunderlich Date: Thu, 26 Jan 2017 17:43:57 +0100 > this is the updated version of yesterdays feature/cleanup pull request for > batman-adv which should go into net-next. We've followed your suggestion > regarding the NET_XMIT_CN handling and modified Gaos

Re: [PATCH 02/14] tcp: fix mark propagation with fwmark_reflect enabled

2017-01-26 Thread Eric Dumazet
On Thu, 2017-01-26 at 20:19 +0100, Pablo Neira Ayuso wrote: > Right. This is not percpu as in IPv4. > > I can send a follow up patch to get this in sync with the way we do it > in IPv4, ie. add percpu socket. > > Fine with this approach? Thanks! Not really. percpu sockets are going to slow

Re: [PATCH net v2 3/3] gtp: fix cross netns recv on gtp socket

2017-01-26 Thread David Miller
From: Andreas Schultz Date: Thu, 26 Jan 2017 16:11:34 +0100 > The use of the passed through netlink src_net to check for a > cross netns operation was wrong. Using the GTP socket and the > GTP netdevice is always correct (even if the netdev has been > moved to new netns after

Re: [BUG/RFC] vhost: net: big endian viring access despite virtio 1

2017-01-26 Thread Michael S. Tsirkin
On Thu, Jan 26, 2017 at 06:39:14PM +0100, Halil Pasic wrote: > > Hi! > > Recently I have been investigating some strange migration problems on > s390x. > > It turned out under certain circumstances vhost_net corrupts avail.idx by > using wrong endianness. > > I managed to track the problem

Re: [PATCH 02/14] tcp: fix mark propagation with fwmark_reflect enabled

2017-01-26 Thread Pablo Neira Ayuso
On Thu, Jan 26, 2017 at 10:02:40AM -0800, Eric Dumazet wrote: > On Thu, 2017-01-26 at 17:37 +0100, Pablo Neira Ayuso wrote: > > From: Pau Espin Pedrol > > > > Otherwise, RST packets generated by the TCP stack for non-existing > > sockets always have mark 0. > > The mark

Re: [PATCH] [net-next] ISDN: eicon: reduce stack size of sig_ind function

2017-01-26 Thread David Miller
From: Arnd Bergmann Date: Wed, 25 Jan 2017 23:15:53 +0100 > I noticed that this function uses a lot of kernel stack when the > "latent entropy" plugin is enabled: > > drivers/isdn/hardware/eicon/message.c: In function 'sig_ind': > drivers/isdn/hardware/eicon/message.c:6113:1:

Re: [PATCH net] bpf: expose netns inode to bpf programs

2017-01-26 Thread Andy Lutomirski
On Thu, Jan 26, 2017 at 10:32 AM, Alexei Starovoitov wrote: > On 1/26/17 10:12 AM, Andy Lutomirski wrote: >> >> On Thu, Jan 26, 2017 at 9:46 AM, Alexei Starovoitov wrote: >>> >>> On 1/26/17 8:37 AM, Andy Lutomirski wrote: > > > Think of bpf programs as safe

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

2017-01-26 Thread Thomas Falcon
On 01/26/2017 12:28 PM, Stephen Hemminger wrote: > On Wed, 25 Jan 2017 15:02:19 -0600 > Thomas Falcon wrote: > >> static irqreturn_t ibmvnic_interrupt(int irq, void *instance) >> { >> struct ibmvnic_adapter *adapter = instance; >> +unsigned long flags; >> +

[PATCH] macvtap: Use kmalloc_array() in macvtap_queue_resize()

2017-01-26 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 26 Jan 2017 19:47:38 +0100 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected

Re: NAPI on USB network drivers

2017-01-26 Thread Oliver Hartkopp
On 01/25/2017 09:57 PM, Alexander Duyck wrote: On Wed, Jan 25, 2017 at 5:33 AM, Oliver Hartkopp wrote: You could probably get around the o-o-o problem by enabling RPS for the interface. I have found that it works for me to do that in order to resolve o-o-o frames

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

2017-01-26 Thread Thomas Falcon
On 01/26/2017 11:56 AM, David Miller wrote: > From: Thomas Falcon > Date: Thu, 26 Jan 2017 10:44:22 -0600 > >> On 01/25/2017 10:04 PM, David Miller wrote: >>> From: Thomas Falcon >>> Date: Wed, 25 Jan 2017 15:02:19 -0600 >>> Move

[PATCH net-next v2 0/4] net: dsa: Preparatory patches

2017-01-26 Thread Florian Fainelli
Hi David, This patch series extracts the 4 patches of the larger: net: dsa: Support for pdata in dsa2 while we wait for feedback from Greg KH on the device references. Changes in v2: - rebased properly after the multi-MDIO bus support added to mv88e6xxx Thanks! Florian Fainelli (4): net:

  1   2   3   >