[PATCH net-next v3 11/12] bnxt_en: Add basic XDP support.

2017-02-06 Thread Michael Chan
Add basic ndo_xdp support to setup and query program, configure the NIC to run in rx page mode, and support XDP_PASS, XDP_DROP, XDP_ABORTED actions only. v3: Pass modified offset and length to stack for XDP_PASS. Remove Kconfig option. v2: Added trace_xdp_exception() Added dma_syncs.

[PATCH net-next v3 09/12] bnxt_en: Add a set of TX rings to support XDP.

2017-02-06 Thread Michael Chan
Add logic for an extra set of TX rings for XDP. If enabled, this set of TX rings equals the number of RX rings and shares the same IRQ as the RX ring set. A new field bp->tx_nr_rings_xdp is added to keep track of these TX XDP rings. Adjust all other relevant functions to handle bp->tx_nr_rings_x

[PATCH net-next v3 06/12] bnxt_en: Use event bit map in RX path.

2017-02-06 Thread Michael Chan
In the current code, we have separate rx_event and agg_event parameters to keep track of rx and aggregation events. Combine these events into an u8 event mask with different bits defined for different events. This way, it is easier to expand the logic to include XDP tx events. Signed-off-by: Mic

Re: [PATCH net-next 0/6] net: dsa: add fabric notifier

2017-02-06 Thread David Miller
From: Vivien Didelot Date: Fri, 3 Feb 2017 13:20:15 -0500 > When a switch fabric is composed of multiple switch chips, these chips > must be programmed accordingly when an event occurred on one of them. > > Examples of such event include hardware bridging: when a Linux bridge > spans interconne

[PATCH net-next v3 00/12] bnxt_en: Add XDP support.

2017-02-06 Thread Michael Chan
The first 10 patches refactor the code (rx/tx code paths and ring logic) and add the basic infrastructure to support XDP. The 11th patch adds basic ndo_xdp to support XDP_DROP and XDP_PASS only. The 12th patch completes the series with XDP_TX. Thanks to Andy Gospodarek for testing and uncovering

[PATCH net-next v3 01/12] bnxt_en: Refactor rx SKB function.

2017-02-06 Thread Michael Chan
Minor refactoring of bnxt_rx_skb() so that it can easily be replaced by a new function that handles packets in a single page. Also, use a function pointer bp->rx_skb_func() to switch to a new function when we add the new mode in the next patch. Add a new field data_ptr that points to the packet d

[PATCH net-next v3 03/12] bnxt_en: Add bp->rx_dir field for rx buffer DMA direction.

2017-02-06 Thread Michael Chan
When driver is running in XDP mode, rx buffers are DMA mapped as DMA_BIDIRECTIONAL. Add a field so the code will map/unmap rx buffers according to this field. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 --- drivers/net/ethernet/broadco

Re: [PATCH net-next 4/7] openvswitch: Inherit master's labels.

2017-02-06 Thread Joe Stringer
On 2 February 2017 at 17:10, Jarno Rajahalme wrote: > We avoid calling into nf_conntrack_in() for expected connections, as > that would remove the expectation that we want to stick around until > we are ready to commit the connection. Instead, we do a lookup in the > expectation table directly.

Re: [iproute PATCH] man: ip-route.8: Fix 'expires' indenting

2017-02-06 Thread Stephen Hemminger
On Thu, 2 Feb 2017 16:22:56 +0100 Phil Sutter wrote: > Descriptions of each route sub-command's arguments are enclosed in > .RS/.RE pairs. For 'replace' sub-command, '.RE' was incorrectly put > before the last argument ('expires'). > > Fixes: 3fbe7ca847367 ("iproute2: ip-route.8.in: Add expires

Re: [PATCH v2 iproute2] ss: print tcpi_rcv_mss and tcpi_advmss

2017-02-06 Thread Stephen Hemminger
On Thu, 02 Feb 2017 05:47:27 -0800 Eric Dumazet wrote: > From: Eric Dumazet > > tcpi_rcv_mss and tcpi_advmss tcp info fields were not yet reported > by ss. > > While adding GRO support to packetdrill, I found this was useful. > > Signed-off-by: Eric Dumazet Applied, thanks.

Re: [PATCH iproute2] ip: HSR: Fix cut and paste error

2017-02-06 Thread Stephen Hemminger
On Mon, 6 Feb 2017 21:47:35 +0100 Ralf Baechle wrote: > Fixes: 5c0aec93a516 ("ip: Add HSR support") > Signed-off-by: Ralf Baechle > --- Applied, thanks.

Re: [PATCH net-next 3/7] openvswitch: Do not trigger events for unconfirmed connection.

2017-02-06 Thread Joe Stringer
On 2 February 2017 at 17:10, Jarno Rajahalme wrote: > Avoid triggering change events for setting conntrack mark or labels > before the conntrack entry has been confirmed. Refactoring on this > patch also makes chenges in later patches easier to review. > > Fixes: 182e3042e15d ("openvswitch: Allow

[PATCHv4 2/7] tap: Renaming tap related APIs, data structures, macros

2017-02-06 Thread Sainath Grandhi
Renaming tap related APIs, data structures and macros in tap.c from macvtap_.* to tap_.* Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 18 +-- drivers/net/tap.c | 332 ++--- drivers/vhost/net.c| 3 +- include/linux/if

[PATCHv4 3/7] tap: Tap character device creation/destroy API

2017-02-06 Thread Sainath Grandhi
This patch provides tap device create/destroy APIs in tap.c. Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 30 +++--- drivers/net/tap.c | 62 ++ include/linux/if_tap.h | 3 +++ 3 files changed, 63 inserti

[PATCHv4 1/7] tap: Refactoring macvtap.c

2017-02-06 Thread Sainath Grandhi
macvtap module has code for tap/queue management and link management. This patch splits the code into macvtap_main.c for link management and tap.c for tap/queue management. Functionality in tap.c can be re-used for implementing tap on other virtual interfaces. Signed-off-by: Sainath Grandhi --

[PATCHv4 4/7] tap: Abstract type of virtual interface from tap implementation

2017-02-06 Thread Sainath Grandhi
macvlan object is re-structured to hold tap related elements in a separate entity, tap_dev. Upon NETDEV_REGISTER device_event, tap_dev is registered with idr and fetched again on tap_open. Few of the tap functions are modified to accepted tap_dev as argument. tap_dev object includes callbacks to be

[PATCHv4 5/7] tap: Extending tap device create/destroy APIs

2017-02-06 Thread Sainath Grandhi
Extending tap APIs get/free_minor and create/destroy_cdev to handle more than one type of virtual interface. Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 6 +-- drivers/net/tap.c | 101 +++-- include/linux/if_tap.h | 4

[PATCHv4 7/7] ipvtap: IP-VLAN based tap driver

2017-02-06 Thread Sainath Grandhi
This patch adds a tap character device driver that is based on the IP-VLAN network interface, called ipvtap. An ipvtap device can be created in the same way as an ipvlan device, using 'type ipvtap', and then accessed using the tap user space interface. Signed-off-by: Sainath Grandhi --- drivers/

[PATCHv4 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

2017-02-06 Thread Sainath Grandhi
Tap character devices can be implemented on other virtual interfaces like ipvlan, similar to macvtap. Source code for tap functionality in macvtap can be re-used for this purpose. This patch series splits macvtap source into two modules, macvtap and tap. This patch series also includes a patch for

[PATCHv4 6/7] tap: tap as an independent module

2017-02-06 Thread Sainath Grandhi
This patch makes tap a separate module for other types of virtual interfaces, for example, ipvlan to use. Signed-off-by: Sainath Grandhi --- drivers/net/Kconfig | 15 +++ drivers/net/Makefile | 3 +-- drivers/net/{macvtap_main.c => macvtap

Re: [PATCH] [net-next] net/mlx5e: fix another maybe-uninitialized false-positive

2017-02-06 Thread David Miller
From: Arnd Bergmann Date: Fri, 3 Feb 2017 17:37:03 +0100 > In commit abeffce ("net/mlx5e: Fix a -Wmaybe-uninitialized warning"), I fixed > a > gcc warning for the ipv4 offload handling. Now we get the same warning for the > added ipv6 support: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.

Re: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

2017-02-06 Thread David Miller
From: Parav Pandit Date: Sat, 4 Feb 2017 11:00:49 -0600 > This patch makes use of is_vlan_dev() function instead of flag > comparison which is exactly done by is_vlan_dev() helper function. > > Signed-off-by: Parav Pandit > Reviewed-by: Daniel Jurgens Applied.

[PATCH] [net-next] net: qcom/emac: add ethool support for setting pause parameters

2017-02-06 Thread Timur Tabi
To support setting the pause parameters, the driver can no longer just mirror the PHY. The set_pauseparam feature allows the driver to force the setting in the MAC, regardless of how the PHY is configured. This means that we now need to maintain an internal state for pause frame support, and so ge

Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the library

2017-02-06 Thread Mickaël Salaün
On 06/02/2017 20:18, Daniel Borkmann wrote: > On 02/06/2017 08:16 PM, Mickaël Salaün wrote: >> On 06/02/2017 16:30, Daniel Borkmann wrote: >>> On 02/06/2017 12:14 AM, Mickaël Salaün wrote: Replace bpf_prog_load() with bpf_load_program() calls. Use the tools include directory instead

RE: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

2017-02-06 Thread Haiyang Zhang
> -Original Message- > From: Parav Pandit [mailto:pa...@mellanox.com] > Sent: Saturday, February 4, 2017 12:01 PM > To: dledf...@redhat.com; Sean Hefty ; > hal.rosenst...@gmail.com; mo...@mellanox.com; sant...@chelsio.com; > ganes...@chelsio.com; manish.cho...@cavium.com; rahul.ve...@cavi

Re: [PATCH net-next v2 3/3] bpf: Always test unprivileged programs

2017-02-06 Thread Alexei Starovoitov
On 2/6/17 12:52 PM, Mickaël Salaün wrote: If selftests are run as root, then execute the unprivileged checks as well. This switch from 240 to 364 tests. The test numbers are suffixed with "/u" when executed as unprivileged or with "/p" when executed as privileged. The geteuid() check is replace

[PATCHv4 net-next 2/7] net: add dst_pending_confirm flag to skbuff

2017-02-06 Thread Julian Anastasov
Add new skbuff flag to allow protocols to confirm neighbour. When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. Add sock_confirm_neigh() helper to confirm the neighbour and use it for IPv4, IPv6 and VRF before dst_neigh_output. Signed

[PATCHv4 net-next 6/7] net: use dst_confirm_neigh for UDP, RAW, ICMP, L2TP

2017-02-06 Thread Julian Anastasov
When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. The datagram protocols can use MSG_CONFIRM to confirm the neighbour. When used with MSG_PROBE we do not reach the code where neighbour is confirmed, so we have to do the same slow look

[PATCHv4 net-next 3/7] sctp: add dst_pending_confirm flag

2017-02-06 Thread Julian Anastasov
Add new transport flag to allow sockets to confirm neighbour. When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. The flag is propagated from transport to every packet. It is reset when cached dst is reset. Reported-by: YueHaibing Fixe

[PATCHv4 net-next 0/7] net: dst_confirm replacement

2017-02-06 Thread Julian Anastasov
This patchset addresses the problem of neighbour confirmation where received replies from one nexthop can cause confirmation of different nexthop when using the same dst. Thanks to YueHaibing for tracking the dst->pending_confirm problem. Sockets can obtain cached output route. Su

[PATCHv4 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-02-06 Thread Julian Anastasov
Add confirm_neigh method to dst_ops and use it from IPv4 and IPv6 to lookup and confirm the neighbour. Its usage via the new helper dst_confirm_neigh() should be restricted to MSG_PROBE users for performance reasons. For XFRM prefer the last tunnel address, if present. With help from Steffen Klass

[PATCHv4 net-next 1/7] sock: add sk_dst_pending_confirm flag

2017-02-06 Thread Julian Anastasov
Add new sock flag to allow sockets to confirm neighbour. When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. As not all call paths lock the socket use full word for the flag. Add sk_dst_confirm as replacement for dst_confirm when called

[PATCHv4 net-next 7/7] net: pending_confirm is not used anymore

2017-02-06 Thread Julian Anastasov
When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. As last step, we can remove the pending_confirm flag. Reported-by: YueHaibing Fixes: 5110effee8fd ("net: Do delayed neigh confirmation.") Fixes: f2bb4bedf35d ("ipv4: Cache output rout

[PATCHv4 net-next 4/7] tcp: replace dst_confirm with sk_dst_confirm

2017-02-06 Thread Julian Anastasov
When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. Use the new sk_dst_confirm() helper to propagate the indication from received packets to sock_confirm_neigh(). Reported-by: YueHaibing Fixes: 5110effee8fd ("net: Do delayed neigh conf

Re: "TCP: eth0: Driver has suspect GRO implementation, TCP performance may be compromised." message with "ethtool -K eth0 gro off"

2017-02-06 Thread Marcelo Ricardo Leitner
On Fri, Feb 03, 2017 at 06:47:33AM -0800, Eric Dumazet wrote: > On Fri, 2017-02-03 at 12:28 -0200, Marcelo Ricardo Leitner wrote: > > > Aren't you mixing the endpoints here? MSS is the largest amount of data > > that the peer can receive in a single segment, and not how much it will > > send. For

[PATCH net-next] net: phy: bcm7xxx: Add BCM74371 PHY ID

2017-02-06 Thread Florian Fainelli
Add the BCM74371 PHY ID to the list of supported chips. This is a 28nm technology Gigabit PHY SoC. Signed-off-by: Florian Fainelli --- drivers/net/phy/bcm7xxx.c | 2 ++ include/linux/brcmphy.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm

[PATCH net-next v2 1/3] tools: Sync {,tools/}include/uapi/linux/bpf.h

2017-02-06 Thread Mickaël Salaün
The tools version of this header is out of date; update it to the latest version from kernel header. Synchronize with the following commits: * b95a5c4db09b ("bpf: add a longest prefix match trie map implementation") * a5e8c07059d0 ("bpf: add bpf_probe_read_str helper") * d1b662adcdb8 ("bpf: allow

[PATCH net-next v2 2/3] bpf: Change the include directory for selftest

2017-02-06 Thread Mickaël Salaün
Use the tools include directory instead of the installed one to allow builds from other kernels. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: David S. Miller --- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insert

[PATCH net-next v2 3/3] bpf: Always test unprivileged programs

2017-02-06 Thread Mickaël Salaün
If selftests are run as root, then execute the unprivileged checks as well. This switch from 240 to 364 tests. The test numbers are suffixed with "/u" when executed as unprivileged or with "/p" when executed as privileged. The geteuid() check is replaced with a capability check. Handling capabil

[PATCH iproute2] ip: HSR: Fix cut and paste error

2017-02-06 Thread Ralf Baechle
Fixes: 5c0aec93a516 ("ip: Add HSR support") Signed-off-by: Ralf Baechle --- I found this by coincidence when reading the HSR code. ip/iplink_hsr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink_hsr.c b/ip/iplink_hsr.c index cb744eb..696b2c9 100644 --- a/ip/iplink_h

Re: Fw: [Bug 193911] New: net_prio.ifpriomap is not aware of the network namespace, and discloses all network interface

2017-02-06 Thread Tejun Heo
Hello, On Sun, Feb 05, 2017 at 11:05:36PM -0800, Cong Wang wrote: > > To be more specific, the read operation of net_prio.ifpriomap is handled by > > the > > function read_priomap. Tracing from this function, we can find it invokes > > for_each_netdev_rcu and set the first parameter as the addres

[PATCH v2 3/5] samples/bpf: Ignore already processed ELF sections

2017-02-06 Thread Mickaël Salaün
Add a missing check for the map fixup loop. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann --- samples/bpf/bpf_load.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c index 396e204888b3

[PATCH v2 4/5] samples/bpf: Reset global variables

2017-02-06 Thread Mickaël Salaün
Before loading a new ELF, clean previous kernel version, license and processed sections. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: David S. Miller --- samples/bpf/bpf_load.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v2 1/5] bpf: Add missing header to the library

2017-02-06 Thread Mickaël Salaün
Include stddef.h to define size_t. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: Wang Nan --- tools/lib/bpf/bpf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h index a2f9853dd882..df6e

[PATCH v2 5/5] samples/bpf: Add missing header

2017-02-06 Thread Mickaël Salaün
Include unistd.h to define __NR_getuid and __NR_getsid. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: David S. Miller --- samples/bpf/tracex5_kern.c | 1 + 1 file changed, 1 insertion(+) diff --git a/samples/bpf/tracex5_kern.c b/sa

[PATCH v2 2/5] bpf: Simplify bpf_load_program() error handling in the library

2017-02-06 Thread Mickaël Salaün
Do not call a second time bpf(2) when a program load failed. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: Wang Nan --- tools/lib/bpf/bpf.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/tool

[PATCH 2/2] sierra_net: Skip validating irrelevant fields for IDLE LSIs

2017-02-06 Thread Stefan Brüns
When the context is deactivated, the link_type is set to 0xff, which triggers a warning message, and results in a wrong link status, as the LSI is ignored. Signed-off-by: Stefan Brüns --- drivers/net/usb/sierra_net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --gi

[PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-06 Thread Stefan Brüns
If a context is configured as dualstack ("IPv4v6"), the modem indicates the context activation with a slightly different indication message. The dual-stack indication omits the link_type (IPv4/v6) and adds additional address fields. IPv6 LSIs are identical to IPv4 LSIs, but have a different link ty

[PATCH 0/2] Fixes for sierra_net driver

2017-02-06 Thread Stefan Brüns
When trying to initiate a dual-stack (ipv4v6) connection, a MC7710, FW version SWI9200X_03.05.24.00ap answers with an unsupported LSI. Add support for this LSI. Also the link_type should be ignored when going idle, otherwise the modem is stuck in a bad link state. Tested on MC7710, T-Mobile DE, APN

Re: [PATCH for bnxt_re V4 03/21] RDMA/bnxt_re: register with the NIC driver

2017-02-06 Thread Doug Ledford
On Wed, 2016-12-21 at 03:41 -0800, Selvin Xavier wrote: > +static void bnxt_re_dev_remove(struct bnxt_re_dev *rdev) > +{ > +   int i = BNXT_RE_REF_WAIT_COUNT; > + > +   /* Wait for rdev refcount to come down */ > +   while ((atomic_read(&rdev->ref_count) > 1) && i--) > +   m

Re: [PATCH V3 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-02-06 Thread Chad Dupuis
On Mon, 6 Feb 2017, 3:56pm -, Hannes Reinecke wrote: > On 02/03/2017 08:17 PM, Dupuis, Chad wrote: > > From: "Dupuis, Chad" > > > > The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific module for > > 41000 > > Series Converged Network Adapters by QLogic. This patch consists of

[PATCH net] sctp: avoid BUG_ON on sctp_wait_for_sndbuf

2017-02-06 Thread Marcelo Ricardo Leitner
Alexander Popov reported that an application may trigger a BUG_ON in sctp_wait_for_sndbuf if the socket tx buffer is full, a thread is waiting on it to queue more data and meanwhile another thread peels off the association being used by the first thread. This patch replaces the BUG_ON call with a

Re: [PATCH net-next v1 4/7] tools: Sync {,tools/}include/uapi/linux/bpf.h

2017-02-06 Thread Mickaël Salaün
This patch only make sense in net-next, however. On 06/02/2017 00:14, Mickaël Salaün wrote: > The tools version of this header is out of date; update it to the latest > version from kernel header. > > Signed-off-by: Mickaël Salaün > Cc: Alexei Starovoitov > Cc: Arnaldo Carvalho de Melo > Cc: D

net/icmp: null-ptr-deref in ping_v4_push_pending_frames

2017-02-06 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer. The null-ptr-deref is caused by sendto() on a socket(PF_INET, SOCK_DGRAM, PROT_ICMP). Note, that this requires the ability to create such sockets, which can be configured by net.ipv4.ping_group_range (https://lwn.net/Arti

Re: [net-next PATCH v2 5/5] virtio_net: XDP support for adjust_head

2017-02-06 Thread John Fastabend
On 17-02-05 11:08 PM, Jason Wang wrote: > > > On 2017年02月03日 11:16, John Fastabend wrote: >> Add support for XDP adjust head by allocating a 256B header region >> that XDP programs can grow into. This is only enabled when a XDP >> program is loaded. >> >> In order to ensure that we do not have to

Re: [PATCH net-next v1 7/7] bpf: Always test unprivileged programs

2017-02-06 Thread Mickaël Salaün
On 06/02/2017 17:09, Alexei Starovoitov wrote: > On 2/5/17 3:14 PM, Mickaël Salaün wrote: >> -if (unpriv && test->prog_type) >> -continue; >> +if (!test->prog_type) { >> +if (!unpriv) >> +set_admin(false); >> +printf("#%d/u %s ",

[PATCH] net: phy: dp83867: Fall-back to default values of clock delay and FIFO depth

2017-02-06 Thread Alexey Brodkin
Given there're default values mentioned in the PHY datasheet fall-back gracefully to them instead of silently return an error through the whole call-chain. This allows to use minimalistic description in DT if no special features are required. Signed-off-by: Alexey Brodkin Cc: Murali Karicheri C

Re: [RFC PATCH net-next 1/2] bpf: Save original ebpf instructions

2017-02-06 Thread Alexei Starovoitov
On Mon, Feb 06, 2017 at 03:13:15PM +0100, Daniel Borkmann wrote: > On 02/06/2017 11:56 AM, Quentin Monnet wrote: > >2017-02-03 (15:28 -0700) ~ David Ahern > >>On 2/3/17 2:09 PM, Daniel Borkmann wrote: > >>>On 02/03/2017 09:38 PM, David Ahern wrote: > Similar to classic bpf, support saving orig

Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the library

2017-02-06 Thread Daniel Borkmann
On 02/06/2017 08:16 PM, Mickaël Salaün wrote: On 06/02/2017 16:30, Daniel Borkmann wrote: On 02/06/2017 12:14 AM, Mickaël Salaün wrote: Replace bpf_prog_load() with bpf_load_program() calls. Use the tools include directory instead of the installed one to allow builds from other kernels. Signe

Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the library

2017-02-06 Thread Mickaël Salaün
On 06/02/2017 16:30, Daniel Borkmann wrote: > On 02/06/2017 12:14 AM, Mickaël Salaün wrote: >> Replace bpf_prog_load() with bpf_load_program() calls. >> >> Use the tools include directory instead of the installed one to allow >> builds from other kernels. >> >> Signed-off-by: Mickaël Salaün >> Cc

Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs

2017-02-06 Thread Alexey Brodkin
Hi Florian, all, On Fri, 2017-02-03 at 10:34 -0800, Florian Fainelli wrote: > On 02/03/2017 09:30 AM, Alexey Brodkin wrote: > > > > Hi Andrew, > > > > On Fri, 2017-02-03 at 18:10 +0100, Andrew Lunn wrote: > > > > > > On Fri, Feb 03, 2017 at 07:52:37PM +0300, Alexey Brodkin wrote: > > > > > > >

Re: [PATCH net-next v5 3/4] net: phy: Allow pre-declaration of MDIO devices

2017-02-06 Thread Florian Fainelli
On 02/06/2017 06:04 AM, Andrew Lunn wrote: >> +/** >> + * mdio_register_board_info - register MDIO devices for a given board >> + * @info: array of devices descriptors >> + * @n: number of descriptors provided >> + * Context: can sleep >> + * >> + * The board info passed can be marked with __initda

Re: Disabling msix interrupts

2017-02-06 Thread David Miller
From: David Laight Date: Mon, 6 Feb 2017 17:23:54 + > Although the 'store buffer' on the sparc cpus I used to use would > let reads overtake writes. So you did have to read back the address > of the last write - not sure about modern sparc cpus. Never would any sparc cpu do so when any of th

Re: [PATCH net-next v5 3/4] net: phy: Allow pre-declaration of MDIO devices

2017-02-06 Thread Florian Fainelli
On 02/06/2017 05:48 AM, Andrew Lunn wrote: >> diff --git a/include/linux/mod_devicetable.h >> b/include/linux/mod_devicetable.h >> index 8a57f0b1242d..8850fcaf50db 100644 >> --- a/include/linux/mod_devicetable.h >> +++ b/include/linux/mod_devicetable.h >> @@ -501,6 +501,7 @@ struct platform_device

Re: [PATCH net v2] mlx4: Invoke softirqs after napi_reschedule

2017-02-06 Thread Eric Dumazet
On Mon, 2017-02-06 at 10:14 -0800, Benjamin Poirier wrote: > mlx4 may schedule napi from a workqueue. Afterwards, softirqs are not run > in a deterministic time frame and the following message may be logged: > NOHZ: local_softirq_pending 08 > > The problem is the same as what was described in comm

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

2017-02-06 Thread Pablo Neira Ayuso
On Mon, Feb 06, 2017 at 03:16:22PM +0100, Harald Welte wrote: > Hi Jonas, > > On Mon, Feb 06, 2017 at 02:33:07PM +0100, Jonas Bonn wrote: > > Fair enough. The use-case I am looking at involves PGW load-testing where > > the simulated load is generated locally on the SGSN so it _is_ seeing IP > >

[PATCH net v2] mlx4: Invoke softirqs after napi_reschedule

2017-02-06 Thread Benjamin Poirier
mlx4 may schedule napi from a workqueue. Afterwards, softirqs are not run in a deterministic time frame and the following message may be logged: NOHZ: local_softirq_pending 08 The problem is the same as what was described in commit ec13ee80145c ("virtio_net: invoke softirqs after __napi_schedule")

Re: [PATCH] Documentation: devicetree: Add PHY no lane swap binding

2017-02-06 Thread Florian Fainelli
On 02/06/2017 06:15 AM, Lukasz Majewski wrote: > Hi Florian, Andrew, > >> Le 02/04/17 à 09:23, Andrew Lunn a écrit : >>> On Sat, Feb 04, 2017 at 04:47:47PM +0100, Lukasz Majewski wrote: Add the documentation to avoid PHY lane swapping. This is a boolean entry to notify the phy device dri

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

2017-02-06 Thread Pablo Neira Ayuso
Hi Jonas, On Mon, Feb 06, 2017 at 02:33:07PM +0100, Jonas Bonn wrote: > Hi Pablo, > > On 02/06/2017 12:08 PM, Pablo Neira Ayuso wrote: > >Hi Jonas, > > > >On Fri, Feb 03, 2017 at 10:12:31AM +0100, Jonas Bonn wrote: > >>The GTP-tunnel driver is explicitly GGSN-side as it searches for PDP > >>conte

Re: [PATCH net] mlx4: Invoke softirqs after napi_reschedule

2017-02-06 Thread Eric Dumazet
On Mon, 2017-02-06 at 09:10 -0800, Benjamin Poirier wrote: > mlx4 may schedule napi from a workqueue. Afterwards, softirqs are not run > in a deterministic time frame and the following message may be logged: > NOHZ: local_softirq_pending 08 > > The problem is the same as what was described in comm

[PATCH net] ipv6: addrconf: fix generation of new temporary addresses

2017-02-06 Thread Marcus Huewe
Under some circumstances it is possible that no new temporary addresses will be generated. For instance, addrconf_prefix_rcv_add_addr() indirectly calls ipv6_create_tempaddr(), which creates a tentative temporary address and starts dad. Next, addrconf_prefix_rcv_add_addr() indirectly calls addrcon

Re: [PATCH net-next 1/7] openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted.

2017-02-06 Thread David Miller
From: Pravin Shelar Date: Mon, 6 Feb 2017 09:06:29 -0800 > On Sun, Feb 5, 2017 at 2:28 PM, David Miller wrote: >> From: Jarno Rajahalme >> Date: Thu, 2 Feb 2017 17:10:00 -0800 >> >>> This does not match either of the conntrack tuples above. Normally >>> this does not matter, as the conntrack

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

2017-02-06 Thread Andreas Schultz
Hi Jonas, Sorry, for later reply, I'm currently on vacation with almost no internet access. - On Feb 6, 2017, at 2:33 PM, Jonas Bonn jo...@southpole.se wrote: > Hi Pablo, > > On 02/06/2017 12:08 PM, Pablo Neira Ayuso wrote: >> Hi Jonas, >> >> On Fri, Feb 03, 2017 at 10:12:31AM +0100, Jonas

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

2017-02-06 Thread Andreas Schultz
- On Feb 6, 2017, at 12:08 PM, pablo pa...@netfilter.org wrote: > Hi Jonas, > > On Fri, Feb 03, 2017 at 10:12:31AM +0100, Jonas Bonn wrote: >> The GTP-tunnel driver is explicitly GGSN-side as it searches for PDP >> contexts based on the incoming packets _destination_ address. If we >> want t

RE: Disabling msix interrupts

2017-02-06 Thread David Laight
From: Alexander > Sent: 06 February 2017 16:27 > To: David Laight > On Mon, Feb 6, 2017 at 7:33 AM, David Laight wrote: > > netdev probably isn't the right list for this, but I suspect people > > reading it understand what happens. > > > > I'm fairly sure that an msix interrupt can get raised aft

[PATCH net] mlx4: Invoke softirqs after napi_reschedule

2017-02-06 Thread Benjamin Poirier
mlx4 may schedule napi from a workqueue. Afterwards, softirqs are not run in a deterministic time frame and the following message may be logged: NOHZ: local_softirq_pending 08 The problem is the same as what was described in commit ec13ee80145c ("virtio_net: invoke softirqs after __napi_schedule")

Re: [PATCH net-next 6/7] openvswitch: Add force commit.

2017-02-06 Thread Pravin Shelar
On Thu, Feb 2, 2017 at 5:10 PM, Jarno Rajahalme wrote: > Stateful network admission policy may allow connections to one > direction and reject connections initiated in the other direction. > After policy change it is possible that for a new connection an > overlapping conntrack entry already exist

Re: [PATCH net-next 1/7] openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted.

2017-02-06 Thread Pravin Shelar
On Thu, Feb 2, 2017 at 5:10 PM, Jarno Rajahalme wrote: > When looking for an existing conntrack entry, the packet 5-tuple > must be inverted if NAT has already been applied, as the current > packet headers do not match any conntrack tuple. For > example, if a packet from private address X to a pu

Re: [PATCH net-next 1/7] openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted.

2017-02-06 Thread Pravin Shelar
On Sun, Feb 5, 2017 at 2:28 PM, David Miller wrote: > From: Jarno Rajahalme > Date: Thu, 2 Feb 2017 17:10:00 -0800 > >> This does not match either of the conntrack tuples above. Normally >> this does not matter, as the conntrack lookup was already done using >> the tuple (B,A), but if the curre

Re: [PATCH] [net-next?] hns: avoid stack overflow with CONFIG_KASAN

2017-02-06 Thread David Miller
From: Arnd Bergmann Date: Fri, 3 Feb 2017 17:35:46 +0100 > The use of ACCESS_ONCE() looks like a micro-optimization to force gcc to use > an indexed load for the register address, but it has an absolutely detrimental > effect on builds with gcc-5 and CONFIG_KASAN=y, leading to a very likely > ke

Re: [patch net-next] net/mlx4_en: fix a condition

2017-02-06 Thread David Miller
From: Dan Carpenter Date: Fri, 3 Feb 2017 12:54:59 +0300 > There is a "||" vs "|" typo here so we test 0x1 instead of 0x6. > > Fixes: 1f8176f7352a ("net/mlx4_en: Check the enabling pptx/pprx flags in > SET_PORT wrapper flow") > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH net-next] sfc: don't rearm interrupts if busy polling

2017-02-06 Thread David Miller
From: Bert Kenward Date: Mon, 6 Feb 2017 16:50:55 + > Since commit 364b6055738b ("net: busy-poll: return busypolling status > to drivers"), napi_complete_done() returns a boolean that can be used > by drivers to conditionally rearm interrupts. > > Testing with a 7142 shows a small latency im

Re: pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06,Re: pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06

2017-02-06 Thread David Miller
From: Marc Kleine-Budde Date: Mon, 6 Feb 2017 17:43:43 +0100 > On 02/06/2017 05:12 PM, David Miller wrote: >> From: Marc Kleine-Budde >> Date: Mon, 6 Feb 2017 15:50:48 +0100 >> >>> this is a pull request of 16 patches for net-next/master. >>> >>> The first two patches by David Jander and me add

Re: [PATCH net-next] sctp: process fwd tsn chunk only when prsctp is enabled

2017-02-06 Thread David Miller
From: Xin Long Date: Fri, 3 Feb 2017 17:37:06 +0800 > This patch is to check if asoc->peer.prsctp_capable is set before > processing fwd tsn chunk, if not, it will return an ERROR to the > peer, just as rfc3758 section 3.3.1 demands. > > Reported-by: Julian Cordes > Signed-off-by: Xin Long A

[PATCH net-next] sfc: don't rearm interrupts if busy polling

2017-02-06 Thread Bert Kenward
Since commit 364b6055738b ("net: busy-poll: return busypolling status to drivers"), napi_complete_done() returns a boolean that can be used by drivers to conditionally rearm interrupts. Testing with a 7142 shows a small latency improvement of ~100 ns. Signed-off-by: Bert Kenward Cc: Eric Dumazet

Re: pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06

2017-02-06 Thread Marc Kleine-Budde
On 02/06/2017 05:12 PM, David Miller wrote: > From: Marc Kleine-Budde > Date: Mon, 6 Feb 2017 15:50:48 +0100 > >> this is a pull request of 16 patches for net-next/master. >> >> The first two patches by David Jander and me add the rx-offload >> framework for CAN devices to the kernel. The remaini

Re: [PATCH net] ipv6: Fix IPv6 packet loss in scenarios involving roaming + snooping switches

2017-02-06 Thread David Miller
From: Linus Lüssing Date: Fri, 3 Feb 2017 08:11:03 +0100 > When for instance a mobile Linux device roams from one access point to > another with both APs sharing the same broadcast domain and a > multicast snooping switch in between: > > 1)(c) <~~~> (AP1) <--[SSW]--> (AP2) > > 2)

RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-06 Thread Yotam Gigi
>-Original Message- >From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >Behalf Of Arnd Bergmann >Sent: Monday, February 06, 2017 6:27 PM >To: Jiri Pirko ; Ido Schimmel >Cc: Arnd Bergmann ; David S. Miller ; >Vadim Pasternak ; Elad Raz ; Ivan >Vecera ; netdev@vger.

Re: [net-next PATCH v2 0/5] XDP adjust head support for virtio

2017-02-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 6 Feb 2017 06:39:54 +0200 > Well the point is to avoid resets completely, at the cost of extra 256 bytes > for packets > 128 bytes on ppc (64k pages) only. > > Found a volunteer so I hope to have this idea tested on ppc Tuesday. > > And really all we need t

Re: [PATCH 3/3] net: ethernet: bgmac: driver power manangement

2017-02-06 Thread Jon Mason
On Fri, Feb 3, 2017 at 9:16 PM, Florian Fainelli wrote: > On 02/03/2017 01:39 PM, Jon Mason wrote: >> From: Joey Zhong >> >> Implements suspend/resume, external phy 54810 is assumed >> to remain powered up during deep-sleep for wake-on-lane. > > s/wake-on-lane/Wake-on-LAN, are you positive phy_st

Re: [patch net-next 0/8] mlxsw: cleanup neigh handling

2017-02-06 Thread David Miller
From: Jiri Pirko Date: Mon, 6 Feb 2017 16:20:09 +0100 > From: Jiri Pirko > > Ido says: > > This series addresses long standing issues in the mlxsw driver > concerning neighbour reflection. It also prepares the code for follow-up > changes dealing with proper resource cleanup and nexthop refle

Re: Disabling msix interrupts

2017-02-06 Thread Alexander Duyck
On Mon, Feb 6, 2017 at 7:33 AM, David Laight wrote: > netdev probably isn't the right list for this, but I suspect people > reading it understand what happens. > > I'm fairly sure that an msix interrupt can get raised after > the kernel thinks it has masked it. > > When an msix interrupt is disabl

[PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-06 Thread Arnd Bergmann
When PSAMPLE is a loadable module, spectrum must not be built-in: drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func': spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet' This adds a Kconfig dependency to enforce usable configurations. Fixes: 98d0f7b9acd

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

2017-02-06 Thread Ben Hutchings
On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > From: Ben Hutchings [...] > > + ret = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0), > > + RTL8150_REQ_GET_REGS, RTL8150_REQT_READ, > > + indx, 0, buf, size, 500); > > + if

Re: pull-request: wireless-drivers 2017-02-06

2017-02-06 Thread David Miller
From: Kalle Valo Date: Mon, 06 Feb 2017 17:19:52 +0200 > one more fix I still would like to get to 4.10 if possible. Please let > me know if there are any problems. This is fine, pulled, thanks Kalle.

RE: [PATCH 1/2] libceph: Remove unneeded stddef.h include

2017-02-06 Thread David Laight
From: Stafford Horne > Sent: 05 February 2017 07:08 > This was causing a build failure for openrisc when using musl and > gcc 5.4.0 since the file is not available in the toolchain. > > It doesnt seem this is needed and removing it does not cause any build > warnings for me. Hmmm... stddef.h is p

[PATCH net-next] ipv6: sr: fix non static symbol warnings

2017-02-06 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warnings: net/ipv6/seg6_iptunnel.c:58:5: warning: symbol 'nla_put_srh' was not declared. Should it be static? net/ipv6/seg6_iptunnel.c:238:5: warning: symbol 'seg6_input' was not declared. Should it be static? net/ipv6/seg6_iptunnel.c:254:5: warning

Re: pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06

2017-02-06 Thread David Miller
From: Marc Kleine-Budde Date: Mon, 6 Feb 2017 15:50:48 +0100 > this is a pull request of 16 patches for net-next/master. > > The first two patches by David Jander and me add the rx-offload > framework for CAN devices to the kernel. The remaining 14 patches > convert the flexcan driver to make us

Re: [PATCH net-next v1 7/7] bpf: Always test unprivileged programs

2017-02-06 Thread Alexei Starovoitov
On 2/5/17 3:14 PM, Mickaël Salaün wrote: - if (unpriv && test->prog_type) - continue; + if (!test->prog_type) { + if (!unpriv) + set_admin(false); + printf("#%d/u %s ", i, t

RE: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

2017-02-06 Thread David Laight
From: Ben Hutchings > Sent: 04 February 2017 16:57 > Allocating USB buffers on the stack is not portable, and no longer > works on x86_64 (with VMAP_STACK enabled as per default). > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Ben Hutchings > --- > drivers/net/usb/rtl8150.c | 34 +

<    1   2   3   >