[PATCH net-next] cxgb4: Remove redundant code in t4_uld_clean_up()

Remove variable rxq_info and also remove redundant assignment to it. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c

[PATCH net-next] cxgb4: Add new T5 and T6 pci device id's

Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h index ecf3ccc..a323185

[PATCH net-next] cxgb4: Increase max number of tc u32 links

From: Arjun V Make max number of supported tc u32 links equal to max number of filters supported by hardware. Signed-off-by: Arjun V Signed-off-by: Rahul Lakkireddy Signed-off-by: Casey Leedom

Re: [PATCH 1/3] net: stmicro: prepare dwmac4 core for mtl

Hi Joao, [auto build test WARNING on net-next/master] [also build test WARNING on next-20170215] [cannot apply to v4.10-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Joao-Pinto/add

Re: [PATCH v4 net] bpf: add bpf_sk_netns_id() helper

David Ahern writes: > On 2/15/17 8:25 PM, Andy Lutomirski wrote: >> On Wed, Feb 15, 2017 at 7:18 PM, David Ahern >> wrote: >>> On 2/15/17 8:08 PM, Eric W. Biederman wrote: David Ahern writes: > On

Re: linux-next: build failure after merge of the net tree

Hi Dave, On Wed, 15 Feb 2017 22:27:46 -0500 (EST) David Miller wrote: > > I applied the fix that synced the two header files already. Sorry about that, I missed it in checking your tree over breakfast :-) -- Cheers, Stephen Rothwell

Re: [PATCH v4 net] bpf: add bpf_sk_netns_id() helper

On 2/15/17 8:25 PM, Andy Lutomirski wrote: > On Wed, Feb 15, 2017 at 7:18 PM, David Ahern wrote: >> On 2/15/17 8:08 PM, Eric W. Biederman wrote: >>> David Ahern writes: >>> On 2/14/17 12:21 AM, Eric W. Biederman wrote: >> in cases

Re: [GIT] Networking

From: David Miller Date: Wed, 15 Feb 2017 22:26:56 -0500 (EST) > From: Linus Torvalds > Date: Wed, 15 Feb 2017 18:01:24 -0800 > >> So David, you really need to convince me that this pull is truly >> required. > > I'll revert those changes,

Re: linux-next: build failure after merge of the net tree

On 2/15/17 7:27 PM, David Miller wrote: From: Alexei Starovoitov Date: Wed, 15 Feb 2017 19:06:02 -0800 On 2/15/17 7:02 PM, Stephen Rothwell wrote: Hi all, On Tue, 14 Feb 2017 09:12:50 +1100 Stephen Rothwell wrote: After merging the net tree, today's

Re: [PATCH net v5] bpf: add helper to compare network namespaces

David Ahern writes: > In cases where bpf programs are looking at sockets and packets > that belong to different netns, it could be useful to compare the > network namespace of the socket or packet > > Introduce bpf_sk_netns_cmp and bpf_skb_netns_cmp helpers to compare >

Re: linux-next: build failure after merge of the net tree

From: Alexei Starovoitov Date: Wed, 15 Feb 2017 19:06:02 -0800 > On 2/15/17 7:02 PM, Stephen Rothwell wrote: >> Hi all, >> >> On Tue, 14 Feb 2017 09:12:50 +1100 Stephen Rothwell >> wrote: >>> >>> After merging the net tree, today's linux-next build

Re: [GIT] Networking

From: Linus Torvalds Date: Wed, 15 Feb 2017 18:01:24 -0800 > So David, you really need to convince me that this pull is truly > required. I'll revert those changes, give me a second.

Re: [PATCH v4 net] bpf: add bpf_sk_netns_id() helper

On Wed, Feb 15, 2017 at 7:18 PM, David Ahern wrote: > On 2/15/17 8:08 PM, Eric W. Biederman wrote: >> David Ahern writes: >> >>> On 2/14/17 12:21 AM, Eric W. Biederman wrote: > in cases where bpf programs are looking at sockets and packets

linux-next: manual merge of the kselftest tree with the net-next tree

Hi Shuah, Today's linux-next merge of the kselftest tree got a conflict in: tools/testing/selftests/bpf/Makefile between commit: d498f8719a09 ("bpf: Rebuild bpf.o for any dependency update") from the net-next tree and commit: 88baa78d1f31 ("selftests: remove duplicated all and clean

Re: [PATCH v4 net] bpf: add bpf_sk_netns_id() helper

On 2/15/17 8:08 PM, Eric W. Biederman wrote: > David Ahern writes: > >> On 2/14/17 12:21 AM, Eric W. Biederman wrote: in cases where bpf programs are looking at sockets and packets that belong to different netns, it could be useful to get an id that

Re: [PATCH v4 net] bpf: add bpf_sk_netns_id() helper

David Ahern writes: > On 2/14/17 12:21 AM, Eric W. Biederman wrote: >>> in cases where bpf programs are looking at sockets and packets >>> that belong to different netns, it could be useful to get an id >>> that uniquely identify a netns within the whole system. >> It

Re: linux-next: build failure after merge of the net tree

On 2/15/17 7:02 PM, Stephen Rothwell wrote: Hi all, On Tue, 14 Feb 2017 09:12:50 +1100 Stephen Rothwell wrote: After merging the net tree, today's linux-next build (powerpc64le perf) failed like this: Warning: tools/include/uapi/linux/bpf.h differs from kernel bpf.c:

Re: linux-next: build failure after merge of the net tree

Hi all, On Tue, 14 Feb 2017 09:12:50 +1100 Stephen Rothwell wrote: > > After merging the net tree, today's linux-next build (powerpc64le perf) > failed like this: > > Warning: tools/include/uapi/linux/bpf.h differs from kernel > bpf.c: In function 'bpf_prog_attach': >

Re: [PATCH v4 net] bpf: add bpf_sk_netns_id() helper

On 2/14/17 12:21 AM, Eric W. Biederman wrote: >> in cases where bpf programs are looking at sockets and packets >> that belong to different netns, it could be useful to get an id >> that uniquely identify a netns within the whole system. > It could be useful but there is no unique namespace id. >

Re: [GIT] Networking

On Wed, Feb 15, 2017 at 5:31 PM, David Miller wrote: > > 3) More gracefully handle rhashtable insertion errors when vmalloc is >not possible, from Herbert Xu. Ugh. So I pulled this, but when I look at his code, I'm really not sure that I should have, and I haven't

[GIT] Networking

1) In order to avoid problems in the future, make cgroup bpf overriding explicit using BPF_F_ALLOW_OVERRIDE. From Alexei Staovoitov. 2) LLC sets skb->sk without proper skb->destructor and this explodes, fix from Eric Dumazet. 3) More gracefully handle rhashtable insertion errors when

[PATCH net v5] bpf: add helper to compare network namespaces

In cases where bpf programs are looking at sockets and packets that belong to different netns, it could be useful to compare the network namespace of the socket or packet Introduce bpf_sk_netns_cmp and bpf_skb_netns_cmp helpers to compare network namespace of the socket or skb to the namespace

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

On Wed, 15 Feb 2017 23:56:53 +0200, Or Gerlitz wrote: > On Wed, Feb 15, 2017 at 8:28 PM, Jakub Kicinski > wrote: > > On Wed, 15 Feb 2017 18:19:17 +0200, Or Gerlitz wrote: > >> On Wed, Feb 15, 2017 at 10:52 AM, Or Gerlitz > >> wrote: > >>>

[PATCH] netfilter: ipset: Null pointer exception in ipset list:set

If we use before/after to add an element to an empty list it will cause a kernel panic. $> cat crash.restore create a hash:ip create b hash:ip create test list:set timeout 5 size 4 add test b before a $> ipset -R < crash.restore Executing the above will crash the kernel. Signed-off-by:

Re: [PATCH v2 2/6] ARM: dts: armada-xp-98dx3236: combine dfx server nodes

On Wed, Feb 08, 2017 at 09:28:11AM +1300, Chris Packham wrote: > Rather than having a separate node for the dfx server add a reg property > to the parent node. This give somes compatibility with the Marvell > supplied SDK. But breaks upstream compatibility. Need to explain why that's okay. > >

Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality

Andrew, On Wed, Feb 15, 2017 at 2:12 PM, Andrew Lunn wrote: >> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev) >> macb_get_hwaddr(bp); >> >> /* Power up the PHY if there is a GPIO reset */ >> - phy_node =

Re: [PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

On Wed, Feb 15, 2017 at 1:49 PM, Michael S. Tsirkin wrote: > The logic is simple really. With #VCPUs == #queues we can reasonably > assume this box is mostly doing networking so we can set affinity > the way we like. With VCPUs > queues clearly VM is doing more stuff > so we

Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality

> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev) > macb_get_hwaddr(bp); > > /* Power up the PHY if there is a GPIO reset */ > - phy_node = of_get_next_available_child(np, NULL); > - if (phy_node) { > + phy_node = of_parse_phandle(np,

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

On Wed, Feb 15, 2017 at 8:28 PM, Jakub Kicinski wrote: > On Wed, 15 Feb 2017 18:19:17 +0200, Or Gerlitz wrote: >> On Wed, Feb 15, 2017 at 10:52 AM, Or Gerlitz wrote: >>> Currently there is no way of querying whether a filter is >>> offloaded

Re: [PATCH net-next 11/13] net: ethernet: aquantia: Refactoring buffers copying.

Thank you. I will think about how to avoid copying.. Regards, Pavel On 16.02.2017 00:31, Lino Sanfilippo wrote: On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous This fix simplified copying data to the ring buffer. Also, there was an error in the code

Re: [PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

On Wed, Feb 15, 2017 at 01:38:48PM -0800, Benjamin Serebrin wrote: > On Wed, Feb 15, 2017 at 11:17 AM, Michael S. Tsirkin wrote: > > > Right. But userspace knows it's random at least. If kernel supplies > > affinity e.g. the way your patch does, userspace ATM accepts this as a >

Re: [PATCH net-next 10/13] net: ethernet: aquantia: Checking for success dma_map_single.

Ok, I will fix it in the patch v2. Thank you. Regards, Pavel On 16.02.2017 00:40, Lino Sanfilippo wrote: On 15.02.2017 22:23, Lino Sanfilippo wrote: In case of this error you have to undo all mappings that you have done so far (i.e the complete frag list and the head buffer). And,

Re: [PATCH net-next V3 5/7] net/sched: cls_matchall: Reflect HW offloading status

On Wed, Feb 15, 2017 at 8:15 PM, David Miller wrote: > From: Or Gerlitz > Date: Wed, 15 Feb 2017 10:52:35 +0200 > >> @@ -194,6 +199,9 @@ static int mall_change(struct net *net, struct sk_buff >> *in_skb, >> } >> } >> >> + if

Re: [PATCH net-next 10/13] net: ethernet: aquantia: Checking for success dma_map_single.

On 15.02.2017 22:23, Lino Sanfilippo wrote: In case of this error you have to undo all mappings that you have done so far (i.e the complete frag list and the head buffer). And, since mapping failed, set ret = 0 and handle this case in the caller, too. Regards, Lino

Re: [PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

On Wed, Feb 15, 2017 at 11:17 AM, Michael S. Tsirkin wrote: > Right. But userspace knows it's random at least. If kernel supplies > affinity e.g. the way your patch does, userspace ATM accepts this as a > gospel. The existing code supplies the same affinity gospels in the #vcpu

[PATCH iproute2 1/2] testsuite: refactor kernel config search

Signed-off-by: Asbjørn Sloth Tønnesen --- testsuite/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/testsuite/Makefile b/testsuite/Makefile index 50a7bafa..fc693368 100644 --- a/testsuite/Makefile +++ b/testsuite/Makefile @@ -17,8 +17,9 @@

[PATCH iproute2 2/2] testsuite: search for kernel config in /boot

Add support for finding the kernel config in Debian and derivatives. Signed-off-by: Asbjørn Sloth Tønnesen --- testsuite/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/Makefile b/testsuite/Makefile index fc693368..055136b5 100644 ---

Re: [PATCH v3 net] packet: Do not call fanout_release from atomic contexts

On Wed, 2017-02-15 at 21:30 +, Anoob Soman wrote: > If statement looks like this. > if (atomic_dec_and_test(sk_ref)) > list_del(f->list); > else > f = NULL; > > there are no multiple lines under if. Yes, I just noticed that. Thanks.

Re: [PATCH v3 net] packet: Do not call fanout_release from atomic contexts

On Wed, 2017-02-15 at 13:02 -0800, Eric Dumazet wrote: > On Wed, 2017-02-15 at 20:25 +, Anoob Soman wrote: > > > +static struct packet_fanout *fanout_release(struct sock *sk) > > { > > struct packet_sock *po = pkt_sk(sk); > > struct packet_fanout *f; > > @@ -1728,17 +1736,17 @@

Re: [PATCH net-next 11/13] net: ethernet: aquantia: Refactoring buffers copying.

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous This fix simplified copying data to the ring buffer. Also, there was an error in the code when the second memcpy is called with zero length. It didn't break the driver, but it's bad. Signed-off-by: Pavel

Re: [PATCH v3 net] packet: Do not call fanout_release from atomic contexts

On 15/02/17 21:02, Eric Dumazet wrote: On Wed, 2017-02-15 at 20:25 +, Anoob Soman wrote: +static struct packet_fanout *fanout_release(struct sock *sk) { struct packet_sock *po = pkt_sk(sk); struct packet_fanout *f; @@ -1728,17 +1736,17 @@ static void fanout_release(struct

Re: [PATCH net-next 10/13] net: ethernet: aquantia: Checking for success dma_map_single.

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous Dma mapping can fail. We should check the result. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 13 ++--- 1 file changed, 10

Re: [PATCH net-next 09/13] net: ethernet: aquantia: Call netdev_register after all initialized.

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous netdev_register should be called when everything is initialized. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 10 ++ 1 file changed,

Re: [PATCH net-next 08/13] net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc.

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous We should check for a null pointer for aq_nic_ndev_alloc instead netdev_priv. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 7 --- 1 file

Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality

Hi Florian, thanks for the quick reply. On Wed, Feb 15, 2017 at 12:57 PM, Florian Fainelli wrote: > On 02/15/2017 12:44 PM, m...@kernel.org wrote: >> From: Moritz Fischer >> >> This allows 'fixed-link' direct MAC connections to be declared >> in

Re: [PATCH net-next 07/13] net: ethernet: aquantia: Using NETDEV_TX_OK instead 0.

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous Use NETDEV_TX_OK as the return value for successful transmission. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- 1 file changed, 1

Re: [PATCH v3 net] packet: Do not call fanout_release from atomic contexts

On Wed, 2017-02-15 at 20:25 +, Anoob Soman wrote: > +static struct packet_fanout *fanout_release(struct sock *sk) > { > struct packet_sock *po = pkt_sk(sk); > struct packet_fanout *f; > @@ -1728,17 +1736,17 @@ static void fanout_release(struct sock *sk) > if (f) { >

Re: [PATCH net-next 06/13] net: ethernet: aquantia: Fixed missing rtnl_unlock.

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous rtnl_unlock should be called if error occurred. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH net-next 05/13] net: ethernet: aquantia: Superfluous initialization of "err".

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous Fixed superfluous initialization of err. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 8 +--- 1 file changed, 1 insertion(+), 7

Re: [PATCH net-next 04/13] net: ethernet: aquantia: Using module_pci_driver.

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous Remove boilerplate code by using macro module_pci_driver. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 20 +--- 1 file

Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality

On 02/15/2017 12:44 PM, m...@kernel.org wrote: > From: Moritz Fischer > > This allows 'fixed-link' direct MAC connections to be declared > in devicetree. > > Signed-off-by: Moritz Fischer > Cc: Nicolas Ferre > --- >

Re: [PATCH net-next 03/13] net: ethernet: aquantia: Removed unnecessary comparsion "old_mtu == new_mtu".

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous This check is not needed. Function aq_ndev_change_mtu wont be called if mtu has not changed. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 6

Re: [PATCH net-next 02/13] net: ethernet: aquantia: Removed busy_count field.

On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous busy_count field and is_busy flag is not needed at all. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 11 ---

Re: [PATCH net-next 01/13] net: ethernet: aquantia: Removed extra assignment for skb->dev.

Hi, On 15.02.2017 21:01, Pavel Belous wrote: From: Pavel Belous This assignment is not needed. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] net: ethernet: cadence: Add fixed-link functionality

From: Moritz Fischer This allows 'fixed-link' direct MAC connections to be declared in devicetree. Signed-off-by: Moritz Fischer Cc: Nicolas Ferre --- drivers/net/ethernet/cadence/macb.c | 61 ++---

Re: [PATCH] Implement full-functionality option for ECN encapsulation in tunnel

Hello, On Wed, 15 Feb 2017, Vadim Fedorenko wrote: > IPVS tunnel mode works as simple tunnel (see RFC 3168) copying ECN field > to outer header. That's result in packet drops on egress tunnels in case > the egress tunnel operates as ECN-capable with Full-functionality option > (like

[PATCH v3 net] packet: Do not call fanout_release from atomic contexts

Commit 6664498280cf ("packet: call fanout_release, while UNREGISTERING a netdev"), unfortunately, introduced the following issues. 1. calling mutex_lock(_mutex) (fanout_release()) from inside rcu_read-side critical section. rcu_read_lock disables preemption, most often, which prohibits calling

[PATCH net-next 08/13] net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc.

From: Pavel Belous We should check for a null pointer for aq_nic_ndev_alloc instead netdev_priv. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH net-next 12/13] net: ethernet: aquantia: Fixed incorrect buff->len calculation.

From: Pavel Belous rxd_wb->pkt_len is the total length of the packet. If we received a large packet (with length > AQ_CFG_RX_FRAME_MAX) then we will get multiple buffers. We need to fix the length of the last buffer. Signed-off-by: Pavel Belous

[PATCH net-next 10/13] net: ethernet: aquantia: Checking for success dma_map_single.

From: Pavel Belous Dma mapping can fail. We should check the result. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[PATCH net-next 13/13] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page.

From: Pavel Belous We should allocate the number of pages based on the config parameter AQ_CFG_RX_FRAME_MAX. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 4 ++--

[PATCH net-next 03/13] net: ethernet: aquantia: Removed unnecessary comparsion "old_mtu == new_mtu".

From: Pavel Belous This check is not needed. Function aq_ndev_change_mtu wont be called if mtu has not changed. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH net-next 05/13] net: ethernet: aquantia: Superfluous initialization of "err".

From: Pavel Belous Fixed superfluous initialization of err. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[PATCH net-next 09/13] net: ethernet: aquantia: Call netdev_register after all initialized.

From: Pavel Belous netdev_register should be called when everything is initialized. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH net-next 07/13] net: ethernet: aquantia: Using NETDEV_TX_OK instead 0.

From: Pavel Belous Use NETDEV_TX_OK as the return value for successful transmission. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 11/13] net: ethernet: aquantia: Refactoring buffers copying.

From: Pavel Belous This fix simplified copying data to the ring buffer. Also, there was an error in the code when the second memcpy is called with zero length. It didn't break the driver, but it's bad. Signed-off-by: Pavel Belous ---

[PATCH net-next 06/13] net: ethernet: aquantia: Fixed missing rtnl_unlock.

From: Pavel Belous rtnl_unlock should be called if error occurred. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH net-next 02/13] net: ethernet: aquantia: Removed busy_count field.

From: Pavel Belous busy_count field and is_busy flag is not needed at all. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 11 --- drivers/net/ethernet/aquantia/atlantic/aq_utils.h | 1 - 2

[PATCH net-next 04/13] net: ethernet: aquantia: Using module_pci_driver.

From: Pavel Belous Remove boilerplate code by using macro module_pci_driver. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff

[PATCH net-next 01/13] net: ethernet: aquantia: Removed extra assignment for skb->dev.

From: Pavel Belous This assignment is not needed. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c

[PATCH net-next 00/13] net: ethernet: aquantia: improvements and fixes

From: Pavel Belous The following patchset contains improvements and fixes for aQuantia AQtion ethernet driver from net-next tree. Most fixes are based on the comments from Lino Sanfilippo. Sanity testing was performed on real HW. Please review. Thanks. Pavel

Re: [PATCH net] ibmvnic: Fix endian errors in error reporting output

From: Thomas Falcon Date: Wed, 15 Feb 2017 10:33:33 -0600 > Error reports received from firmware were not being converted from > big endian values, leading to bogus error codes reported on little > endian systems. > > Signed-off-by: Thomas Falcon

Re: [PATCH net] ibmvnic: Fix endian error when requesting device capabilities

From: Thomas Falcon Date: Wed, 15 Feb 2017 10:32:11 -0600 > When a vNIC client driver requests a faulty device setting, the > server returns an acceptable value for the client to request. > This 64 bit value was incorrectly being swapped as a 32 bit value, >

Re: [PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

On Wed, Feb 15, 2017 at 10:27:37AM -0800, Benjamin Serebrin wrote: > On Wed, Feb 15, 2017 at 9:42 AM, Michael S. Tsirkin wrote: > > > > > > > For pure network load, assigning each txqueue IRQ exclusively > > > to one of the cores that generates traffic on that queue is the > > >

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

On Wed, 15 Feb 2017 18:19:17 +0200, Or Gerlitz wrote: > On Wed, Feb 15, 2017 at 10:52 AM, Or Gerlitz wrote: > > Currently there is no way of querying whether a filter is > > offloaded to HW or not when using "both" policy (where none > > of skip_sw or skip_hw flags are set

Re: [PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

On Wed, Feb 15, 2017 at 9:42 AM, Michael S. Tsirkin wrote: > > > > For pure network load, assigning each txqueue IRQ exclusively > > to one of the cores that generates traffic on that queue is the > > optimal layout in terms of load spreading. Irqbalance does > > not have the XPS

Re: [PATCH] atm: idt77252, use setup_timer and mod_timer

From: Jiri Slaby Date: Wed, 15 Feb 2017 16:59:35 +0100 > From: Jan Koniarik > > Stop accessing timer struct members directly and use setup_timer and > mod_timer helpers intended for that use. It makes the code cleaner and > will allow for easier change

Re: [patch net-next] mlxsw: acl: Use PBS type for forward action

From: Jiri Pirko Date: Wed, 15 Feb 2017 12:09:51 +0100 > From: Jiri Pirko > > Current behaviour of "mirred redirect" action (forward) offload is a bit > odd. For matched packets the action forwards them to the desired > destination, but it also lets the

Re: [PATCH v3 0/8] misc patchs

From: Corentin Labbe Date: Wed, 15 Feb 2017 10:46:37 +0100 > This is a follow up of my previous stmmac serie which address some comment > done in v2. Series applied.

[PATCH net] ibmvnic: Make CRQ interrupt tasklet wait for all capabilities crqs

After sending device capability queries and requests to the vNIC Server, an interrupt is triggered and the responses are written to the driver's CRQ response buffer. Since the interrupt can be triggered before all responses are written and visible to the partition, there is a danger that the

[PATCH net] ibmvnic: Handle processing of CRQ messages in a tasklet

Create a tasklet to process queued commands or messages received from firmware instead of processing them in the interrupt handler. Note that this handler does not process network traffic, but communications related to resource allocation and device settings. Signed-off-by: Thomas Falcon

[PATCH net] ibmvnic: Use common counter for capabilities checks

Two different counters were being used for capabilities requests and queries. These commands are not called at the same time so there is no reason a single counter cannot be used. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 71

Re: [PATCH net-next V3 7/7] net/sched: cls_bpf: Reflect HW offload status

From: Or Gerlitz Date: Wed, 15 Feb 2017 10:52:37 +0200 > @@ -511,6 +517,9 @@ static int cls_bpf_change(struct net *net, struct sk_buff > *in_skb, > return ret; > } > > + if (!(tc_in_hw(prog->gen_flags))) Again, less parenthesis. Thanks.

Re: [PATCH net-next V3 6/7] net/sched: cls_u32: Reflect HW offload status

From: Or Gerlitz Date: Wed, 15 Feb 2017 10:52:36 +0200 > @@ -895,6 +899,9 @@ static int u32_change(struct net *net, struct sk_buff > *in_skb, > return err; > } > > + if (!(tc_in_hw(new->flags))) Less parenthesis, please.

Re: [PATCH net-next V3 5/7] net/sched: cls_matchall: Reflect HW offloading status

From: Or Gerlitz Date: Wed, 15 Feb 2017 10:52:35 +0200 > @@ -194,6 +199,9 @@ static int mall_change(struct net *net, struct sk_buff > *in_skb, > } > } > > + if (!(tc_in_hw(new->flags))) > + new->flags |= TCA_CLS_FLAGS_NOT_IN_HW; Too

Re: [PATCH] net: ethernet: aquantia: switch to pci_alloc_irq_vectors

From: Christoph Hellwig Date: Wed, 15 Feb 2017 08:38:47 +0100 > pci_enable_msix has been long deprecated, but this driver adds a new > instance. Convert it to pci_alloc_irq_vectors so that no new instance > of the deprecated function reaches mainline. > > Signed-off-by: Christoph

Re: [PATCH] net: ethernet: aquantia: switch to pci_alloc_irq_vectors

On 15.02.2017 10:38, Christoph Hellwig wrote: pci_enable_msix has been long deprecated, but this driver adds a new instance. Convert it to pci_alloc_irq_vectors so that no new instance of the deprecated function reaches mainline. Signed-off-by: Christoph Hellwig ---

Re: [PATCH] average: change to declare precision, not factor

From: Johannes Berg Date: Wed, 15 Feb 2017 09:49:26 +0100 > From: Johannes Berg > > Declaring the factor is counter-intuitive, and people are prone > to using small(-ish) values even when that makes no sense. > > Change the DECLARE_EWMA()

[PATCH] net: ethernet: ti: cpsw: correct ale dev to cpsw

The ale is a property of cpsw, so change dev to cpsw->dev, aka pdev->dev, to be consistent. Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/cpsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next v7 0/2] qed*: Add support for PTP

From: Yuval Mintz Date: Wed, 15 Feb 2017 10:24:09 +0200 > This patch series adds required changes for qed/qede drivers for > supporting the IEEE Precision Time Protocol (PTP). Series applied, thanks.

Re: [PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

On Wed, Feb 15, 2017 at 08:50:34AM -0800, Willem de Bruijn wrote: > On Tue, Feb 14, 2017 at 1:05 PM, Michael S. Tsirkin wrote: > > On Tue, Feb 14, 2017 at 11:17:41AM -0800, Benjamin Serebrin wrote: > >> On Wed, Feb 8, 2017 at 11:37 AM, Michael S. Tsirkin > >>

Re: [PATCH net-next] openvswitch: Set internal device max mtu to ETH_MAX_MTU.

From: Jarno Rajahalme Date: Tue, 14 Feb 2017 21:16:28 -0800 > Commit 91572088e3fd ("net: use core MTU range checking in core net > infra") changed the openvswitch internal device to use the core net > infra for controlling the MTU range, but failed to actually set the > max_mtu as

Re: [PATCH v2 net] packet: Do not call fanout_release from atomic contexts

On Wed, 2017-02-15 at 16:43 +, Anoob Soman wrote: > > net/packet/af_packet.c | 29 ++--- > 1 file changed, 22 insertions(+), 7 deletions(-) > > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > index d56ee46..af29510 100644 > ---

Re: [PATCH net-next] cxgb4: Update proper netdev stats for rx drops

From: Ganesh Goudar Date: Wed, 15 Feb 2017 11:45:25 +0530 > Count buffer group drops or truncates as rx drops rather than > rx errors in netdev stats. > > Signed-off-by: Ganesh Goudar > Signed-off-by: Arjun V Applied.

Re: [PATCH net] net: neigh: Fix netevent NETEVENT_DELAY_PROBE_TIME_UPDATE notification

From: Ido Schimmel Date: Wed, 15 Feb 2017 08:59:25 +0200 > On Wed, Feb 15, 2017 at 01:00:36AM +0100, Marcus Huewe wrote: >> When setting a neigh related sysctl parameter, we always send a >> NETEVENT_DELAY_PROBE_TIME_UPDATE netevent. For instance, when >> executing >> >>

Re: [RFC PATCH v2] net: ethtool: add support for forward error correction modes

Vidya and I have been in communication on how to support Forward Error Correction Management on Links. My own thoughts are that we should consider using the new Get/Set Link Ksettiongs API because FEC is a low-level Link parameter which is either negotiated at the same time as Link Speed if

Re: [patch net-next] sched: have stub for tcf_destroy_chain in case NET_CLS is not configured

From: Jiri Pirko Date: Wed, 15 Feb 2017 11:57:50 +0100 > From: Jiri Pirko > > This fixes broken build for !NET_CLS: > > net/built-in.o: In function `fq_codel_destroy': > /home/sab/linux/net-next/net/sched/sch_fq_codel.c:468: undefined reference to >

Re: [PATCH v2 0/4] PTP attribute handling cleanup

From: Dmitry Torokhov Date: Tue, 14 Feb 2017 10:23:30 -0800 > PTP core was creating some attributes, such as "period" and "fifo", and the > entire "pins" attribute group, after creating class deevice, which creates > a race for userspace: uevent may arrive before all

Re: [PATCH 2/2] net: xilinx_emaclite: fix freezes due to unordered I/O

From: Anssi Hannula Date: Tue, 14 Feb 2017 19:11:45 +0200 > The xilinx_emaclite uses __raw_writel and __raw_readl for register > accesses. Those functions do not imply any kind of memory barriers and > they may be reordered. > > The driver does not seem to take that

Re: [PATCH 1/2] net: xilinx_emaclite: fix receive buffer overflow

From: Anssi Hannula Date: Tue, 14 Feb 2017 19:11:44 +0200 > xilinx_emaclite looks at the received data to try to determine the > Ethernet packet length but does not properly clamp it if > proto_type == ETH_P_IP or 1500 < proto_type <= 1518, causing a buffer > overflow

  1   2   >