Re: [patch net-next] sched: have stub for tcf_destroy_chain in case NET_CLS is not configured

2017-02-15 Thread Sabrina Dubroca
2017-02-15, 11:57:50 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > This fixes broken build for !NET_CLS: > > net/built-in.o: In function `fq_codel_destroy': > /home/sab/linux/net-next/net/sched/sch_fq_codel.c:468: undefined reference to > `tcf_destroy_chain' > > Fixes:

Re: [PATCH net-next] DCTCP drop compatibility

2017-02-15 Thread David Miller
First, this needs to be reviewed by other DCTCP experts. Second, it is missing a proper Signed-off-by: tag.

Re: [PATCH v2 net] packet: Do not call fanout_release from atomic contexts

2017-02-15 Thread kbuild test robot
Hi Anoob, [auto build test WARNING on net-next/master] [also build test WARNING on v4.10-rc8] [cannot apply to net/master next-20170215] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Anoob

Re: [PATCH net-next v1] bpf: Rebuild bpf.o for any dependency update

2017-02-15 Thread David Miller
From: Mickaël Salaün Date: Sat, 11 Feb 2017 23:20:23 +0100 > This is needed to force a rebuild of bpf.o when one of its dependencies > (e.g. uapi/linux/bpf.h) is updated. > > Add a phony target. > > Signed-off-by: Mickaël Salaün Applied.

Re: [PATCH net-next v1] bpf: Remove redundant ifdef

2017-02-15 Thread David Miller
From: Mickaël Salaün Date: Sat, 11 Feb 2017 20:37:08 +0100 > Remove a useless ifdef __NR_bpf as requested by Wang Nan. > > Inline one-line static functions as it was in the bpf_sys.h file. > > Signed-off-by: Mickaël Salaün > Cc: Alexei Starovoitov

Re: [PATCH net-next] mlx4: do not use rwlock in fast path

2017-02-15 Thread David Miller
From: Eric Dumazet Date: Thu, 09 Feb 2017 09:10:04 -0800 > From: Eric Dumazet > > Using a reader-writer lock in fast path is silly, when we can > instead use RCU or a seqlock. > > For mlx4 hwstamp clock, a seqlock is the way to go, removing > two

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-15 Thread Eric Dumazet
On Wed, Feb 15, 2017 at 8:42 AM, Tariq Toukan wrote: > > > Isn't it the same principle in page_frag_alloc() ? > It is called form __netdev_alloc_skb()/__napi_alloc_skb(). > > Why is it ok to have order-3 pages (PAGE_FRAG_CACHE_MAX_ORDER) there? This is not ok. This is a

Re: [PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

2017-02-15 Thread Willem de Bruijn
On Tue, Feb 14, 2017 at 1:05 PM, Michael S. Tsirkin wrote: > On Tue, Feb 14, 2017 at 11:17:41AM -0800, Benjamin Serebrin wrote: >> On Wed, Feb 8, 2017 at 11:37 AM, Michael S. Tsirkin wrote: >> >> > IIRC irqbalance will bail out and avoid touching affinity >> >

Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-15 Thread Rob Herring
On Tue, Feb 07, 2017 at 07:10:26PM +0530, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > LED Mode: > Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different > status information that can be selected by setting LED mode. > > LED Mode parameter

Re: [kernel-hardening] Re: [RFC][PATCH] nfsd: add +1 to reference counting scheme for struct nfsd4_session

2017-02-15 Thread Bruce Fields
On Mon, Feb 13, 2017 at 06:46:19AM -0500, David Windsor wrote: > On Mon, Feb 13, 2017 at 5:54 AM, Hans Liljestrand wrote: > > On Sat, Feb 11, 2017 at 01:42:53AM -0500, David Windsor wrote: > >> > >> > >> > >>> Signed-off-by: David Windsor > >>> --- > >>>

[PATCH v2 net] packet: Do not call fanout_release from atomic contexts

2017-02-15 Thread Anoob Soman
Commit 6664498280cf ("packet: call fanout_release, while UNREGISTERING a netdev"), unfortunately, introduced the following issues. 1. calling mutex_lock(_mutex) (fanout_release()) from inside rcu_read-side critical section. rcu_read_lock disables preemption, most often, which prohibits calling

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-15 Thread Tariq Toukan
On 14/02/2017 7:29 PM, Tom Herbert wrote: On Tue, Feb 14, 2017 at 7:51 AM, Eric Dumazet wrote: On Tue, 2017-02-14 at 16:56 +0200, Tariq Toukan wrote: As the previous series caused hangs, we must run functional regression tests over this series as well. Run has

Re: [PATCH net] packet: Do not call fanout_release from atomic contexts

2017-02-15 Thread Anoob Soman
On 15/02/17 13:46, Eric Dumazet wrote: On Wed, 2017-02-15 at 11:07 +, Anoob Soman wrote: On 13/02/17 14:50, Anoob Soman wrote: On 13/02/17 14:26, Eric Dumazet wrote: On Mon, 2017-02-13 at 13:28 +, Anoob Soman wrote: Wouldn't it be easier to call synchronize_net(), before calling

[PATCH net] ibmvnic: Fix endian errors in error reporting output

2017-02-15 Thread Thomas Falcon
Error reports received from firmware were not being converted from big endian values, leading to bogus error codes reported on little endian systems. Signed-off-by: Thomas Falcon --- This patch depends on "[PATCH net] ibmvnic: Fix endian error when requesting device

[PATCH net] ibmvnic: Fix endian error when requesting device capabilities

2017-02-15 Thread Thomas Falcon
When a vNIC client driver requests a faulty device setting, the server returns an acceptable value for the client to request. This 64 bit value was incorrectly being swapped as a 32 bit value, resulting in loss of data. This patch corrects that by using the 64 bit swap function. Signed-off-by:

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-15 Thread Or Gerlitz
On Wed, Feb 15, 2017 at 10:52 AM, Or Gerlitz wrote: > Currently there is no way of querying whether a filter is > offloaded to HW or not when using "both" policy (where none > of skip_sw or skip_hw flags are set by user-space). > Add two new flags, "in hw" and "not in hw"

Re: [PATCH net-next v3 2/8] gtp: switch from struct socket to struct sock for the GTP sockets

2017-02-15 Thread David Miller
From: Andreas Schultz Date: Wed, 15 Feb 2017 08:04:56 +0100 (CET) > - On Feb 14, 2017, at 6:48 PM, David S. Miller da...@davemloft.net wrote: > >> From: Andreas Schultz >> Date: Mon, 13 Feb 2017 16:36:18 +0100 >> >>> + if (gtp->sk0) { >>> +

[PATCH] atm: idt77252, use setup_timer and mod_timer

2017-02-15 Thread Jiri Slaby
From: Jan Koniarik Stop accessing timer struct members directly and use setup_timer and mod_timer helpers intended for that use. It makes the code cleaner and will allow for easier change of the timer struct internals. Signed-off-by: Jan Koniarik

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-15 Thread Eric Dumazet
On Wed, 2017-02-15 at 16:52 +0200, Matan Barak (External) wrote: > So, in case of RDMA CQs, we add some per-CQE overhead of comparing the > list pointers and condition upon that. Maybe we could add an > invoke_tasklet boolean field on mlx4_cq and return its value from > mlx4_cq_completion. >

RE: [PATCH 1/2] net: xilinx_emaclite: fix receive buffer overflow

2017-02-15 Thread David Laight
From: Anssi Hannula > Sent: 15 February 2017 08:29 ... > Looking through the product guide [1] I don't see the actual receive > packet length provided anywhere, so I guess that is why the crazy stuff > is done. If the hardware doesn't provide the receive packet length then I suggest you 'fix' the

Re: [PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

2017-02-15 Thread Michael S. Tsirkin
On Tue, Feb 14, 2017 at 11:17:41AM -0800, Benjamin Serebrin wrote: > On Wed, Feb 8, 2017 at 11:37 AM, Michael S. Tsirkin wrote: > > > IIRC irqbalance will bail out and avoid touching affinity > > if you set affinity from driver. Breaking that's not nice. > > Pls correct me if

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-15 Thread Matan Barak (External)
On 15/02/2017 13:10, Saeed Mahameed wrote: On Fri, Feb 10, 2017 at 2:27 PM, Eric Dumazet wrote: From: Eric Dumazet All rx and rx netdev interrupts are handled by respectively by mlx4_en_rx_irq() and mlx4_en_tx_irq() which simply schedule a NAPI.

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-15 Thread Eric Dumazet
On Wed, 2017-02-15 at 15:59 +0200, Saeed Mahameed wrote: > can the tasklet run on a different core ? No. tasklets are scheduled on local cpu, like softirqs in general. They are not migrated, unless cpu is removed (hotplug) > > the point is that if the EQ is full of CQEs from different CQs

[PATCH V5 net-next 1/2] qed: Add support for hardware offloaded FCoE.

2017-02-15 Thread Dupuis, Chad
From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH V5 0/2] Add QLogic FastLinQ FCoE (qedf) driver

2017-02-15 Thread Dupuis, Chad
From: "Dupuis, Chad" Dave, please apply the qed patch to net-next at your earliest convenience. Martin, the qed patch needs to be applied first as the qedf patch is dependent on the FCoE bits in the first qed driver patch. This series introduces the hardware offload FCoE

[PATCH iproute2 net-next 0/3] iplink: add support for link xstats

2017-02-15 Thread Nikolay Aleksandrov
Hi, This set adds support for printing link xstats per link type. Currently only the bridge and its ports support such call and it dumps the mcast stats. This model makes it easy to use the same callback for both bridge and bridge_slave link types. Patch 01 also updates the man page with the new

[PATCH iproute2 net-next 2/3] iplink: bridge: add support for displaying xstats

2017-02-15 Thread Nikolay Aleksandrov
Add support for the new parse/print_ifla_xstats callbacks and use them to print the per-bridge multicast stats. Example: $ ip link xstats type bridge br0 IGMP queries: RX: v1 0 v2 0 v3 0 TX: v1 0 v2 0 v3 0 IGMP

[PATCH iproute2 net-next 1/3] iplink: add support for xstats subcommand

2017-02-15 Thread Nikolay Aleksandrov
This patch adds support for a new xstats link subcommand which uses the specified link type's new parse/print_ifla_xstats callbacks to display extended statistics. Signed-off-by: Nikolay Aleksandrov --- ip/Makefile | 2 +- ip/ip_common.h| 9

[PATCH iproute2 net-next 3/3] iplink: bridge_slave: add support for displaying xstats

2017-02-15 Thread Nikolay Aleksandrov
This patch adds support to the bridge_slave link type for displaying xstats by reusing the previously added bridge xstats callbacks. Signed-off-by: Nikolay Aleksandrov --- ip/ip_common.h | 3 +++ ip/iplink_bridge.c | 6 +++---

Re: [RFC 2/2] net: emac: add support for device-tree based PHY discovery and setup

2017-02-15 Thread Andrew Lunn
> > > Is the PHY just powered down by chance (BMCR_PWRDN set?) and resetting > > > it implicitly clears the power down that seems to be what is going on. > > > > Yes, the PHY is just in the BMCR_PDOWN state. I can do the same > > on the WNDR4700, by messing with u-boot: Hi Christian What

Re: [PATCH net-next] sctp: change to use uint_t in uapi sctp.h

2017-02-15 Thread Neil Horman
On Tue, Feb 14, 2017 at 11:26:04AM -0500, David Miller wrote: > From: Xin Long > Date: Tue, 14 Feb 2017 16:23:48 +0800 > > > All structures in uapi sctp.h are exported for userspace, their members' > > types should use uint_t instead of __u. > > This is not true. > > __u

[RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

2017-02-15 Thread Quentin Schulz
From: Florian Vallee According to the m_can user manual changelog the BTP register layout was updated with core revision 3.1.0 This change is not backward-compatible and using the current driver along with a recent IP results in an incorrect bitrate on the wire. Tested with

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-15 Thread Eric Dumazet
On Wed, 2017-02-15 at 05:29 -0800, Eric Dumazet wrote: > > mlx4_eq_int() is a hard irq handler. > > How a tasklet could run in the middle of it ? > > A tasklet is a softirq handler. Speaking of mlx4_eq_int() , 50% of cycles are spent on mb() (mfence) in eq_set_ci() I wonder why this very

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-15 Thread Saeed Mahameed
On Wed, Feb 15, 2017 at 3:29 PM, Eric Dumazet wrote: > On Wed, 2017-02-15 at 13:10 +0200, Saeed Mahameed wrote: >> On Fri, Feb 10, 2017 at 2:27 PM, Eric Dumazet wrote: >> > From: Eric Dumazet >> > >> > All rx and rx netdev

Re: [PATCH net] packet: Do not call fanout_release from atomic contexts

2017-02-15 Thread Eric Dumazet
On Wed, 2017-02-15 at 11:07 +, Anoob Soman wrote: > On 13/02/17 14:50, Anoob Soman wrote: > > On 13/02/17 14:26, Eric Dumazet wrote: > >> On Mon, 2017-02-13 at 13:28 +, Anoob Soman wrote: > >> > >>> Wouldn't it be easier to call synchronize_net(), before calling > >>> fanout_release_data()

[PATCH] Implement full-functionality option for ECN encapsulation in tunnel

2017-02-15 Thread Vadim Fedorenko
IPVS tunnel mode works as simple tunnel (see RFC 3168) copying ECN field to outer header. That's result in packet drops on egress tunnels in case the egress tunnel operates as ECN-capable with Full-functionality option (like ip_tunnel and ip6_tunnel kernel modules), according to RFC 3168 section

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-15 Thread Eric Dumazet
On Wed, 2017-02-15 at 13:10 +0200, Saeed Mahameed wrote: > On Fri, Feb 10, 2017 at 2:27 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > All rx and rx netdev interrupts are handled by respectively > > by mlx4_en_rx_irq() and mlx4_en_tx_irq()

Re: [PATCH RFC v2 ipsec-next 0/6] IPsec GRO layer decapsulation

2017-02-15 Thread Steffen Klassert
On Mon, Feb 13, 2017 at 10:57:55AM +0100, Steffen Klassert wrote: > This patchset adds a software GRO codepath for IPsec ESP. > The ESP gro_receive callback functions decapsulate the > ESP packets at the GRO layer and reinject them back with > gro_cells_receive(). This saves a complete round

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-15 Thread Saeed Mahameed
On Fri, Feb 10, 2017 at 2:27 PM, Eric Dumazet wrote: > From: Eric Dumazet > > All rx and rx netdev interrupts are handled by respectively > by mlx4_en_rx_irq() and mlx4_en_tx_irq() which simply schedule a NAPI. > > But mlx4_eq_int() also fires a

[patch net-next] mlxsw: acl: Use PBS type for forward action

2017-02-15 Thread Jiri Pirko
From: Jiri Pirko Current behaviour of "mirred redirect" action (forward) offload is a bit odd. For matched packets the action forwards them to the desired destination, but it also lets the packet duplicates to go the original way down (bridge, router, etc). That is more like

[PATCH net-next] ixgb: Omit private ndo_get_stats function

2017-02-15 Thread Tobias Klauser
ixgb_get_stats() just returns dev->stats so we can leave it out altogether and let dev_get_stats() do the job. Suggested-by: Joe Perches Signed-off-by: Tobias Klauser --- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 16 1 file changed,

[PATCH net-next] e1000: Omit private ndo_get_stats function

2017-02-15 Thread Tobias Klauser
e1000_get_stats() just returns dev->stats so we can leave it out altogether and let dev_get_stats() do the job. Suggested-by: Joe Perches Signed-off-by: Tobias Klauser --- drivers/net/ethernet/intel/e1000/e1000_main.c | 15 --- 1 file changed,

Re: [PATCH net] packet: Do not call fanout_release from atomic contexts

2017-02-15 Thread Anoob Soman
On 13/02/17 14:50, Anoob Soman wrote: On 13/02/17 14:26, Eric Dumazet wrote: On Mon, 2017-02-13 at 13:28 +, Anoob Soman wrote: Wouldn't it be easier to call synchronize_net(), before calling fanout_release_data() and kfree(f). The behavior, wrt synchronize_net, would be same as before and

[patch net-next] sched: have stub for tcf_destroy_chain in case NET_CLS is not configured

2017-02-15 Thread Jiri Pirko
From: Jiri Pirko This fixes broken build for !NET_CLS: net/built-in.o: In function `fq_codel_destroy': /home/sab/linux/net-next/net/sched/sch_fq_codel.c:468: undefined reference to `tcf_destroy_chain' Fixes: cf1facda2f61 ("sched: move tcf_proto_destroy and tcf_destroy_chain

Re: [PATCH] net: hip04: Omit private ndo_get_stats function

2017-02-15 Thread Joe Perches
On Wed, 2017-02-15 at 11:38 +0100, Tobias Klauser wrote: > On 2017-02-15 at 11:28:08 +0100, Joe Perches wrote: > > On Tue, 2017-02-14 at 15:10 +0100, Tobias Klauser wrote: > > > hip04_get_stats() just returns dev->stats so we can leave it > > > out altogether and let

Re: [PATCH] net: hip04: Omit private ndo_get_stats function

2017-02-15 Thread Tobias Klauser
On 2017-02-15 at 11:28:08 +0100, Joe Perches wrote: > On Tue, 2017-02-14 at 15:10 +0100, Tobias Klauser wrote: > > hip04_get_stats() just returns dev->stats so we can leave it > > out altogether and let dev_get_stats() do the job. > > This could be done for at least a few more

Re: [PATCH] net: hip04: Omit private ndo_get_stats function

2017-02-15 Thread Joe Perches
On Tue, 2017-02-14 at 15:10 +0100, Tobias Klauser wrote: > hip04_get_stats() just returns dev->stats so we can leave it > out altogether and let dev_get_stats() do the job. This could be done for at least a few more drivers: drivers/net/ethernet/chelsio/cxgb/sge.c

[PATCH v3 6/8] net: stmmac: split the stmmac_adjust_link 10/100 case

2017-02-15 Thread Corentin Labbe
The 10/100 case have too many ifcase. This patch split it for removing an if. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro Reviewed-by: Giuseppe Cavallaro ---

[PATCH v3 7/8] net: stmmac: reduce indentation by adding a continue

2017-02-15 Thread Corentin Labbe
As suggested by Joe Perches, replacing the "if phydev" logic permit to reduce indentation in the for loop. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro Reviewed-by: Giuseppe Cavallaro ---

[PATCH v3 8/8] net: stmmac: invert the logic for dumping regs

2017-02-15 Thread Corentin Labbe
It is easier to follow the logic by removing the not operator Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro Reviewed-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 18

[PATCH v3 5/8] net: stmmac: run stmmac_hw_fix_mac_speed when speed is valid

2017-02-15 Thread Corentin Labbe
This patch mutualise a bit by running stmmac_hw_fix_mac_speed() after the switch in case of valid speed. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro Reviewed-by: Giuseppe Cavallaro ---

Re: [PATCH net-next] mlx4: do not use rwlock in fast path

2017-02-15 Thread Tariq Toukan
On 14/02/2017 6:28 PM, David Miller wrote: From: Eric Dumazet Date: Thu, 09 Feb 2017 09:10:04 -0800 From: Eric Dumazet Using a reader-writer lock in fast path is silly, when we can instead use RCU or a seqlock. For mlx4 hwstamp clock, a

[PATCH v3 4/8] net: stmmac: set speed at SPEED_UNKNOWN in case of broken speed

2017-02-15 Thread Corentin Labbe
In case of invalid speed given, stmmac_adjust_link() still record it as current speed. This patch modify the default case to set speed as SPEED_UNKNOWN if not 10/100/1000. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro Reviewed-by:

[PATCH v3 3/8] net: stmmac: use SPEED_UNKNOWN/DUPLEX_UNKNOWN

2017-02-15 Thread Corentin Labbe
It is better to use DUPLEX_UNKNOWN instead of just "-1". Using 0 for an invalid speed is bad since 0 is a valid value for speed. So this patch replace 0 by SPEED_UNKNOWN. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro Reviewed-by:

[PATCH v3 1/8] net: stmmac: remove useless parenthesis

2017-02-15 Thread Corentin Labbe
This patch remove some useless parenthesis. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro Reviewed-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8

[PATCH v3 2/8] net: stmmac: likely is useless in occasional function

2017-02-15 Thread Corentin Labbe
The stmmac_adjust_link() function is called too rarely for having likely() macros being useful. Just remove likely annotation in it. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro Reviewed-by: Giuseppe Cavallaro

[PATCH v3 0/8] misc patchs

2017-02-15 Thread Corentin Labbe
Hello This is a follow up of my previous stmmac serie which address some comment done in v2. Corentin Labbe (8): net: stmmac: remove useless parenthesis net: stmmac: likely is useless in occasional function net: stmmac: use SPEED_UNKNOWN/DUPLEX_UNKNOWN net: stmmac: set speed at

Re: rt2500usb: don't mark register accesses as inline

2017-02-15 Thread Kalle Valo
Arnd Bergmann wrote: > When CONFIG_KASAN is set, we get a rather large stack here: > > drivers/net/wireless/ralink/rt2x00/rt2500usb.c: In function > 'rt2500usb_set_device_state': > drivers/net/wireless/ralink/rt2x00/rt2500usb.c:1074:1: error: the frame size > of 3032 bytes is

Re: brcmfmac: Use net_device_stats from struct net_device

2017-02-15 Thread Kalle Valo
Tobias Klauser wrote: > Instead of using a private copy of struct net_device_stats in struct > brcm_if, use stats from struct net_device. Also remove the now > unnecessary .ndo_get_stats function. > > Signed-off-by: Tobias Klauser > Acked-by: Arend van

Re: orinoco: Use net_device_stats from struct net_device

2017-02-15 Thread Kalle Valo
Tobias Klauser wrote: > Instead of using a private copy of struct net_device_stats in > struct orinoco_private, use stats from struct net_device. Also remove > the now unnecessary .ndo_get_stats function. > > Signed-off-by: Tobias Klauser Patch applied

Re: rtlwifi: btcoexist: fix semicolon.cocci warnings

2017-02-15 Thread Kalle Valo
Julia Lawall wrote: > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > CC: Larry Finger > Signed-off-by: Julia Lawall > Signed-off-by: Fengguang Wu >

Re: [PATCH 0/8] net: stmmac: misc patchs

2017-02-15 Thread Giuseppe CAVALLARO
On 2/15/2017 8:39 AM, Corentin Labbe wrote: Since all patch in v2 already hit linux-next, I just want to be sure, I can add "Acked-by and Reviewed-by" to thoses 8 new patchs ? Right I have just seen the V2 patches are in net-next. pls consider, for this set, my Acked-by: Giuseppe Cavallaro

[PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-15 Thread Jason Wang
We set queues before reset which will cause a crash[1]. This is because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs number to do the correct detection. So fix this by: - set queues after reset, to keep the old vi->curr_queue_pairs. (in fact setting queues before reset does not

[PATCH net-next V3 6/7] net/sched: cls_u32: Reflect HW offload status

2017-02-15 Thread Or Gerlitz
U32 support for the "in hw" offloading flags. Signed-off-by: Or Gerlitz Reviewed-by: Amir Vadai --- net/sched/cls_u32.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index a6ec3e4b..8c6cc39 100644

[PATCH net-next V3 7/7] net/sched: cls_bpf: Reflect HW offload status

2017-02-15 Thread Or Gerlitz
BPF classifier support for the "in hw" offloading flags. Signed-off-by: Or Gerlitz Reviewed-by: Amir Vadai Acked-by: Jakub Kicinski --- net/sched/cls_bpf.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

[PATCH net-next V3 2/7] net/sched: cls_matchall: Dump the classifier flags

2017-02-15 Thread Or Gerlitz
The classifier flags are not dumped to user-space, do that. Signed-off-by: Or Gerlitz Acked-by: Jiri Pirko Acked-by: Yotam Gigi --- net/sched/cls_matchall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH net-next V3 4/7] net/sched: cls_flower: Reflect HW offload status

2017-02-15 Thread Or Gerlitz
Flower support for the "in hw" offloading flags. Signed-off-by: Or Gerlitz Reviewed-by: Amir Vadai Acked-by: Jiri Pirko --- net/sched/cls_flower.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/sched/cls_flower.c

[PATCH net-next V3 5/7] net/sched: cls_matchall: Reflect HW offloading status

2017-02-15 Thread Or Gerlitz
Matchall support for the "in hw" offloading flags. Signed-off-by: Or Gerlitz Reviewed-by: Amir Vadai Acked-by: Jiri Pirko --- net/sched/cls_matchall.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH net-next V3 0/7] net/sched: Reflect HW offload status in classifiers

2017-02-15 Thread Or Gerlitz
Currently there is no way of querying whether a filter is offloaded to HW or not when using "both" policy (where none of skip_sw or skip_hw flags are set by user-space). Added two new flags, "in hw" and "not in hw" such that user space can determine if a filter is actually offloaded to hw. The

[PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-15 Thread Or Gerlitz
Currently there is no way of querying whether a filter is offloaded to HW or not when using "both" policy (where none of skip_sw or skip_hw flags are set by user-space). Add two new flags, "in hw" and "not in hw" such that user space can determine if a filter is actually offloaded to hw or not.

[PATCH net-next V3 1/7] net/sched: cls_flower: Properly handle classifier flags dumping

2017-02-15 Thread Or Gerlitz
Dump the classifier flags only if non zero and make sure to check the return status of the handler that puts them into the netlink msg. Signed-off-by: Or Gerlitz --- net/sched/cls_flower.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] average: change to declare precision, not factor

2017-02-15 Thread Johannes Berg
From: Johannes Berg Declaring the factor is counter-intuitive, and people are prone to using small(-ish) values even when that makes no sense. Change the DECLARE_EWMA() macro to take the fractional precision, in bits, rather than a factor, and update all users. While

Re: [PATCH 1/2] net: xilinx_emaclite: fix receive buffer overflow

2017-02-15 Thread Anssi Hannula
On 14.2.2017 22:12, David Miller wrote: > From: Anssi Hannula > Date: Tue, 14 Feb 2017 19:11:44 +0200 > >> xilinx_emaclite looks at the received data to try to determine the >> Ethernet packet length but does not properly clamp it if >> proto_type == ETH_P_IP or 1500 <

[PATCH net-next v7 2/2] qede: Add driver support for PTP

2017-02-15 Thread Yuval Mintz
From: Sudarsana Reddy Kalluru This patch adds the driver support for, - Registering the ptp clock functionality with the OS. - Timestamping the Rx/Tx PTP packets. - Ethtool callbacks related to PTP. Signed-off-by: Sudarsana Reddy Kalluru

[PATCH net-next v7 0/2] qed*: Add support for PTP

2017-02-15 Thread Yuval Mintz
This patch series adds required changes for qed/qede drivers for supporting the IEEE Precision Time Protocol (PTP). Dave, Please consider applying this series to "net-next". Thanks, Yuval Changes from previous versions: --- v7: Fixed Kbuild robot warnings. v6:

[PATCH net-next v7 1/2] qed: Add infrastructure for PTP support

2017-02-15 Thread Yuval Mintz
From: Sudarsana Reddy Kalluru The patch adds the required qed interfaces for configuring/reading the PTP clock on the adapter. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz ---

Re: [PATCH net-next V2 1/6] net/sched: cls_matchall: Dump skip flags

2017-02-15 Thread Or Gerlitz
On Tue, Feb 14, 2017 at 9:28 PM, Jakub Kicinski wrote: > On Tue, 14 Feb 2017 16:30:35 +0200, Or Gerlitz wrote: >> The skip flags are not dumped to user-space, do that. >> >> Signed-off-by: Or Gerlitz >> Acked-by: Jiri Pirko >> Acked-by:

<    1   2