[net-next 08/13] i40e: convert to cpu from le16 to generate switch_id correctly

From: Jacob Keller On Big Endian platforms we would incorrectly calculate the wrong switch id since we did not properly convert the le16 value into CPU format. Caught by sparse. Change-ID: I69a2f9fa064a0a91691f7d0e6fcc206adceb8e36 Signed-off-by: Jacob Keller

[net-next 10/13] i40e: Error handling for link event

From: Harshitha Ramamurthy There exists an intermittent bug which causes the 'Link Detected' field reported by the 'ethtool ' command to be 'Yes' when in fact, there is no link. This patch fixes the problem by enabling temporary link polling when

[net-next 03/13] i40e: remove unnecessary call to i40e_update_link_info

From: Jacob Keller This call is made just prior to running i40e_link_event. In i40e_link_event, we set hw->phy.get_link_info to true just prior to calling i40e_get_link_status, which conveniently runs i40e_update_link_info for us. Thus, we are running

[net-next 06/13] i40e: Fix Adaptive ITR enabling

From: Carolyn Wyborny This patch fixes a bug introduced with the addition of the per queue ITR feature support in ethtool. With that addition, there were functions added which converted the ITR settings to binary values. The IS_ENABLED macros that run on those values

[net-next 04/13] i40evf: free rings in remove function

From: Mitch Williams When the i40evf_remove() calls netdev close, the device doesn't actually close - it schedules the work for the watchdog to perform. Since we're stopping the watchdog, this work doesn't get done. However, we're resetting the part, so we can free

[net-next 07/13] i40e: refactor AQ CMD buffer debug printing

From: Alan Brady This patch refactors the '%*ph' printk format specifier to instead use the print_hex_dump function, as recommended by the '%*ph' documentation. This produces better/more standardized output. Change-ID: Id56700b4e8abc40ff8c04bc8379e7df04cb4d6fd

[net-next 02/13] i40e: enable mc magic pkt wakeup during power down

From: Joshua Hay This patch adds a call to the mac_address_write admin q function during power down to update the PRTPM_SAH/SAL registers with the MC_MAG_EN bit thus enabling multicast magic packet wakeup. A FW workaround is needed to write the multicast magic wake up

[net-next 09/13] i40e: properly convert le16 value to CPU format

From: Jacob Keller This ensures that the pvid which is stored in __le16 format is converted to the CPU format. This will fix comparison issues on Big Endian platforms. Change-ID: I92c80d1315dc2a0f9f095d5a0c48d461beb052ed Signed-off-by: Jacob Keller

[net-next 00/13][pull request] 40GbE Intel Wired LAN Driver Updates 2017-02-18

This series contains updates to i40e and i40evf only. Alan fixes a bug in which the driver is unable to exit overflow promiscuous mode after having added "too many" mac filters. Ractored the '%*ph' printk format specifier to instead use the print_hex_dump(). Josh adds enabling multicast magic

[net-next 13/13] i40e: Invoke softirqs after napi_reschedule

From: Benjamin Poirier The following message is logged from time to time when using i40e: NOHZ: local_softirq_pending 08 i40e may schedule napi from a workqueue. Afterwards, softirqs are not run in a deterministic time frame. The problem is the same as what was described in

[net-next 11/13] i40e: mark the value passed to csum_replace_by_diff as __wsum

From: Jacob Keller Fix, or rather, avoid a sparse warning caused by the fact that csum_replace_by_diff expects to receive a __wsum value. Since the calculation appears to work, simply typecast the passed paylen value to __wsum to avoid the warning. This seems pretty

[net-next 12/13] i40e: remove duplicate device id from PCI table

From: Carolyn Wyborny Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 - 1 file changed, 1

[net-next 05/13] i40evf: add comment

From: Mitch Williams Add a comment to reduce confusion. Change-ID: I3d5819c0f3f5174680442ae54398a073d4a61f4f Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 01/13] i40e: fix disable overflow promiscuous mode

From: Alan Brady There exists a bug in which the driver is unable to exit overflow promiscuous mode after having added "too many" mac filters. It is expected that after triggering overflow promiscuous, removing the failed/extra filters should then disable overflow

Re: [PATCH rfc 4/4] iscsi-target: use generic inet_pton_with_scope

On Thu, 2017-02-16 at 19:43 +0200, Sagi Grimberg wrote: > Signed-off-by: Sagi Grimberg > --- > drivers/target/iscsi/iscsi_target_configfs.c | 46 > > 1 file changed, 12 insertions(+), 34 deletions(-) > > diff --git

Re: [PATCH repost] ptr_ring: fix race conditions when resizing

From: "Michael S. Tsirkin" Date: Sun, 19 Feb 2017 07:17:17 +0200 > Dave, could you merge this before 4.10? If not - I can try. I just sent my last pull request to Linus, please merge it to him directly. Thanks.

Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce

On Sat, Feb 18, 2017 at 06:28:39PM +0100, Dmitry Vyukov wrote: > On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote: > > > > > > On 2017年02月10日 02:10, Michael S. Tsirkin wrote: > >> > >> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote: > >>> > >>> - Original

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

On Fri, Feb 17, 2017 at 01:10:08PM +0800, Jason Wang wrote: > > > On 2017年02月17日 12:53, John Fastabend wrote: > > On 17-02-15 01:08 AM, Jason Wang wrote: > > > We set queues before reset which will cause a crash[1]. This is > > > because is_xdp_raw_buffer_queue() depends on the old xdp queue

[PATCH repost] ptr_ring: fix race conditions when resizing

Resizing currently drops consumer lock. This can cause entries to be reordered, which isn't good in itself. More importantly, consumer can detect a false ring empty condition and block forever. Further, nesting of consumer within producer lock is problematic for tun, since it produces entries

[GIT] Networking

One last brown-paper-bag fix for the release. If we fail the ipv4 mapped source address check, we have to release the route. From Willem de Bruijn. Please pull, thanks a lot! The following changes since commit 2763f92f858f7c4c3198335c0542726eaed07ba3: Merge tag 'fixes-for-linus' of

Re: [PATCH net v2] ipv6: release dst on error in ip6_dst_lookup_tail

From: Willem de Bruijn Date: Sat, 18 Feb 2017 19:00:45 -0500 > From: Willem de Bruijn > > If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped > check, release the dst before returning an error. > > Fixes: ec5e3b0a1d41

Re: Questions on XDP

On 17-02-18 06:16 PM, Alexander Duyck wrote: > On Sat, Feb 18, 2017 at 3:48 PM, John Fastabend > wrote: >> On 17-02-18 03:31 PM, Alexei Starovoitov wrote: >>> On Sat, Feb 18, 2017 at 10:18 AM, Alexander Duyck >>> wrote: > XDP_DROP

Re: Questions on XDP

On Sat, Feb 18, 2017 at 3:48 PM, John Fastabend wrote: > On 17-02-18 03:31 PM, Alexei Starovoitov wrote: >> On Sat, Feb 18, 2017 at 10:18 AM, Alexander Duyck >> wrote: >>> XDP_DROP does not require having one page per frame. >>> >>>

Re: [PATCH iproute2 net-next 0/3] iplink: add support for link xstats

On Wed, 15 Feb 2017 15:23:10 +0100 Nikolay Aleksandrov wrote: > Hi, > This set adds support for printing link xstats per link type. Currently > only the bridge and its ports support such call and it dumps the mcast > stats. This model makes it easy to use the same

Re: [PATCH iproute2] devlink: Call dl_free in early exit case

On Tue, 14 Feb 2017 07:29:38 +0200 Leon Romanovsky wrote: > From: Leon Romanovsky > > Prior to parsing command options, the devlink tool allocates memory > to store results. In case of early exit (wrong parameters or version > check), this memory wasn't

Re: [PATCH iproute2 1/1] man page: add page for skbmod action

On Fri, 10 Feb 2017 18:28:54 -0500 Lucas Bates wrote: > Signed-off-by: Lucas Bates > Signed-off-by: Jamal Hadi Salim > Signed-off-by: Roman Mashak Applied to master branch.

Re: [PATCH net v2] ipv6: release dst on error in ip6_dst_lookup_tail

On Sat, 2017-02-18 at 19:00 -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped > check, release the dst before returning an error. > > Fixes: ec5e3b0a1d41 ("ipv6: Inhibit IPv4-mapped src address on

Re: [PATCH v2 iproute2 2/2] actions: Add support for user cookies

On Fri, 10 Feb 2017 06:25:44 -0500 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Make use of 128b user cookies > > Introduce optional 128-bit action cookie. > Like all other cookie schemes in the networking world (eg in protocols > like http or

Re: [PATCH v2 iproute2 1/2] utils: make hex2mem available to all users

On Fri, 10 Feb 2017 06:25:43 -0500 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > hex2mem() api is useful for parsing hexstrings which are then packed in > a stream of chars. > > Signed-off-by: Jamal Hadi Salim I went ahead and

Re: [PATCH iproute2/net-next repost 0/3] tc: flower: support masked ICMP code and type match

On Thu, 9 Feb 2017 14:48:58 +0100 Simon Horman wrote: > Hi, > > this short series allows the tc tool to configure masked matches on the > ICMP code and type. Unmasked matches are already supported by the tool. > > This does not depend on any kernel changes as

Re: [PATCH iproute2 0/4] ip vrf: updates to handle cgroup hiearchy and namespace nesting

On Thu, 16 Feb 2017 08:58:54 -0800 David Ahern wrote: > More updates to ip vrf for 4.10. Major changes: handle vrf in an existing > cgroup hierarchy and handle vrf nesting in network namespaces. > > Comparison of the netns in bpf code will be added once the kernel

Re: [PATCH iproute2 1/2] testsuite: refactor kernel config search

On Wed, 15 Feb 2017 21:26:41 + Asbjørn Sloth Tønnesen wrote: > Signed-off-by: Asbjørn Sloth Tønnesen Both applied thanks

Re: [PATCH iproute] tc: matchall: Print skip flags when dumping a filter

On Thu, 9 Feb 2017 15:10:14 +0200 Or Gerlitz wrote: > Print the skip flags when we dump a filter. > > Signed-off-by: Or Gerlitz > Acked by: Yotam Gigi Applied, thanks

Re: [PATCH iproute2 v2] ip route: Make name of protocol 0 consistent

On Mon, 13 Feb 2017 12:21:53 -0800 David Ahern wrote: > iproute2 can inconsistently show the name of protocol 0 if a route with > a custom protocol is added. For example: > dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec' > local ::1 dev lo

[PATCH net v2] ipv6: release dst on error in ip6_dst_lookup_tail

From: Willem de Bruijn If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped check, release the dst before returning an error. Fixes: ec5e3b0a1d41 ("ipv6: Inhibit IPv4-mapped src address on the wire.") Signed-off-by: Willem de Bruijn ---

Re: Questions on XDP

On Sat, Feb 18, 2017 at 3:48 PM, John Fastabend wrote: > > We are running our vswitch in userspace now for many workloads > it would be nice to have these in kernel if possible. ... > Maybe Alex had something else in mind but we have many virtual interfaces > plus

Re: Questions on XDP

On Sat, 2017-02-18 at 15:48 -0800, John Fastabend wrote: > I'm not seeing the distinction here. If its a 4k page and > in the stack the driver will get overrun as well. Agree. Using a full page per Ethernet frame does not change the attack vector. It makes attacker job easier.

Re: [PATCH net] ipv6: release dst on error in ip6_dst_lookup_tail

> But looks like the commit sha1 was > ec5e3b0a1d41fbda0cc33a45bc9e54e91d9d12c7 > > So the correct tag would be > > Fixes: ec5e3b0a1d41 ("ipv6: Inhibit IPv4-mapped src address on the wire.") Thanks for catching that! I'll send a v2 with the fixed commit.

Re: [PATCH net] ipv6: release dst on error in ip6_dst_lookup_tail

On Sat, 2017-02-18 at 18:51 -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped > check, release the dst before returning an error. > > Fixes: b2e6f0c8dde5 ("ipv6: Inhibit IPv4-mapped src address on

[PATCH net] ipv6: release dst on error in ip6_dst_lookup_tail

From: Willem de Bruijn If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped check, release the dst before returning an error. Fixes: b2e6f0c8dde5 ("ipv6: Inhibit IPv4-mapped src address on the wire.") Signed-off-by: Willem de Bruijn ---

Re: Questions on XDP

On 17-02-18 03:31 PM, Alexei Starovoitov wrote: > On Sat, Feb 18, 2017 at 10:18 AM, Alexander Duyck > wrote: >> >>> XDP_DROP does not require having one page per frame. >> >> Agreed. > > why do you think so? > xdp_drop is targeting ddos where in good case > all traffic

[PATCH] fsl/fman: fix spelling mistake in variable name en_tsu_err_exeption

From: Colin Ian King trivial fix to spelling mistake, en_tsu_err_exeption should be en_tsu_err_exception Signed-off-by: Colin Ian King --- drivers/net/ethernet/freescale/fman/fman_dtsec.c | 8 1 file changed, 4 insertions(+), 4

Re: Questions on XDP

On 17-02-18 10:18 AM, Alexander Duyck wrote: > On Sat, Feb 18, 2017 at 9:41 AM, Eric Dumazet wrote: >> On Sat, 2017-02-18 at 17:34 +0100, Jesper Dangaard Brouer wrote: >>> On Thu, 16 Feb 2017 14:36:41 -0800 >>> John Fastabend wrote: >>> On

Re: Questions on XDP

On Sat, Feb 18, 2017 at 10:18 AM, Alexander Duyck wrote: > >> XDP_DROP does not require having one page per frame. > > Agreed. why do you think so? xdp_drop is targeting ddos where in good case all traffic is passed up and in bad case most of the traffic is dropped,

[PATCH] net: qlogic: qla3xxx: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/qlogic/qla3xxx.c | 29

[patch] sunrpc: silence uninitialized variable warning

kstrtouint() can return a couple different error codes so the check for "ret == -EINVAL" is wrong and static analysis tools correctly complain that we can use "num" without initializing it. It's not super harmful because we check the bounds. But it's also easy enough to fix. Signed-off-by: Dan

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Did not apply on linux-next-20170217 > > Signed-off-by: Romain Perier

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: Tested all patches by compilation and checkpatch. All of them compile fine, but patches 11 and 12 need some fixes. You can resend as PATCH instead of RFC. > The current PCI pool API are simple macro functions direct expanded to > the

Re: [RFC v2 12/20] scsi: mpt3sas: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:48AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Please run checkpatch, fix the style issue and resend. > > Signed-off-by: Romain Perier

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: Hi Romain, Checkpatch gives some warnings you can fix related to NULL tests before dma_pool_destroy(), and you changed indentation style in some of your changes. Some times it is important to keep consistency within a file even if

[PATCH net] mlx4: reduce OOM risk on arches with large pages

From: Eric Dumazet Since mlx4 NIC are used on PowerPC with 64K pages, we need to adapt MLX4_EN_ALLOC_PREFER_ORDER definition. Otherwise, a fragment sitting in an out of order TCP queue can hold 0.5 Mbytes and it is a serious OOM risk. Fixes: 51151a16a60f ("mlx4: allow

Re: Questions on XDP

On Sat, Feb 18, 2017 at 9:41 AM, Eric Dumazet wrote: > On Sat, 2017-02-18 at 17:34 +0100, Jesper Dangaard Brouer wrote: >> On Thu, 16 Feb 2017 14:36:41 -0800 >> John Fastabend wrote: >> >> > On 17-02-16 12:41 PM, Alexander Duyck wrote: >> > > So

[PATCH net-next 2/2] sctp: add support for MSG_MORE

This patch is to add support for MSG_MORE on sctp. It adds force_delay in sctp_datamsg to save MSG_MORE, and sets it after creating datamsg according to the send flag. sctp_packet_can_append_data then uses it to decide if the chunks of this msg will be sent at once or delay it. Note that unlike

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

Le 18/02/2017 à 14:06, Greg Kroah-Hartman a écrit : > On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: >> The current PCI pool API are simple macro functions direct expanded to >> the appropriated dma pool functions. The prototypes are almost the same >> and semantically, they are

[PATCH net-next 0/2] sctp: support MSG_MORE flag when sending msg

This patch is to add support for MSG_MORE on sctp. Patch 1/2 is an improvement ahead of patch 2/2 to solve the close block problem mentioned in https://patchwork.ozlabs.org/patch/372404/. Xin Long (2): sctp: flush out queue once assoc state falls into SHUTDOWN_PENDING sctp: add support for

[PATCH net-next 1/2] sctp: flush out queue once assoc state falls into SHUTDOWN_PENDING

This patch is to flush out queue when assoc state falls into SHUTDOWN_PENDING if there are still chunks in it, so that the data can be sent out as soon as possible before sending SHUTDOWN chunk. When sctp supports MSG_MORE flag in next patch, this improvement can also solve the problem that the

Re: Questions on XDP

On Sat, 2017-02-18 at 17:34 +0100, Jesper Dangaard Brouer wrote: > On Thu, 16 Feb 2017 14:36:41 -0800 > John Fastabend wrote: > > > On 17-02-16 12:41 PM, Alexander Duyck wrote: > > > So I'm in the process of working on enabling XDP for the Intel NICs > > > and I had a

Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce

On Sat, Feb 18, 2017 at 6:28 PM, Dmitry Vyukov wrote: > On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote: >> >> >> On 2017年02月10日 02:10, Michael S. Tsirkin wrote: >>> >>> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote: -

Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce

On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote: > > > On 2017年02月10日 02:10, Michael S. Tsirkin wrote: >> >> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote: >>> >>> - Original Message - Hello, I've got the following report while

Re: [PATCH net-next v2 11/12] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page.

On 02/18/2017 02:50 PM, Lino Sanfilippo wrote: Hi, On 17.02.2017 22:07, Pavel Belous wrote: From: Pavel Belous We should allocate the number of pages based on the config parameter AQ_CFG_RX_FRAME_MAX. Signed-off-by: Pavel Belous

Re: [PATCH net-next v2 00/12] net: ethernet: aquantia: improvements and fixes

On 02/18/2017 02:56 PM, Lino Sanfilippo wrote: Hi, On 17.02.2017 22:07, Pavel Belous wrote: From: Pavel Belous The following patchset contains improvements and fixes for aQuantia AQtion ethernet driver from net-next tree. Most fixes are based on the comments from

Re: [PATCH net-next v2 11/12] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page.

On 02/18/2017 01:43 AM, Andrew Lunn wrote: diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c index 4c40644..0877625 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c

Re: Questions on XDP

On Thu, 16 Feb 2017 14:36:41 -0800 John Fastabend wrote: > On 17-02-16 12:41 PM, Alexander Duyck wrote: > > So I'm in the process of working on enabling XDP for the Intel NICs > > and I had a few questions so I just thought I would put them out here > > to try and get

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

On Sat, Feb 18, 2017 at 4:19 AM, David Miller wrote: > From: Xin Long > Date: Fri, 17 Feb 2017 16:35:24 +0800 > > >> + list = rhltable_lookup(_transport_hashtable, , >> +sctp_hash_params); >> + >> +

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: > The current PCI pool API are simple macro functions direct expanded to > the appropriated dma pool functions. The prototypes are almost the same > and semantically, they are very similar. I propose to use the DMA pool > API directly

[PATCH net-next] GTP: Add some basic documentation about drivers/net/gtp.c

In order to clarify what the module actually does, and how to use it, let's add some basic documentation to the kernel tree, together with pointers to related specs and projects. Signed-off-by: Harald Welte --- Documentation/networking/gtp.txt | 135

Re: [RFC v2 01/20] block: DAC960: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:37AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > no new errors added, tested by compilation only. > Signed-off-by: Romain Perier

Re: [PATCH net-next v2 00/12] net: ethernet: aquantia: improvements and fixes

Hi, On 17.02.2017 22:07, Pavel Belous wrote: > From: Pavel Belous > > The following patchset contains improvements and fixes for aQuantia > AQtion ethernet driver from net-next tree. > > Most fixes are based on the comments from Lino Sanfilippo. > > Sanity testing

Re: [PATCH net-next v2 11/12] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page.

Hi, On 17.02.2017 22:07, Pavel Belous wrote: > From: Pavel Belous > > We should allocate the number of pages based on the config parameter > AQ_CFG_RX_FRAME_MAX. > > Signed-off-by: Pavel Belous > do { > if

[PATCH] net: aquantia: remove function aq_ring_tx_deinit

Both functions aq_ring_rx_deinit() and aq_ring_tx_clean() are almost identical aside from an additional check in the latter. Move that check from the function into its caller and replace aq_ring_rx_deinit() with aq_ring_rx_deinit(). By doing this also adjust the functions return value from int to

[PATCH] net: ena: remove superfluous check in ena_remove()

The check in ena_remove() for the pci driver data not being NULL is not needed, since it is always set in the probe() function. Remove the superfluous check. Signed-off-by: Lino Sanfilippo --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 6 -- 1 file changed, 6

Re: [PATCH 1/2] tcp: setup random timestamp offset when write_seq already set

Hi, On 18.02.2017 3:56, Alexey Kodanev wrote: > Found that when random offset enabled (default) TCP client can > still start new connections with and without random offsets. Later, > if server does active close and re-use sockets in TIME-WAIT state, > new SYN from client can be rejected on PAWS