RE: create drivers/net/mdio and move mdio drivers into it

2017-02-19 Thread YUAN Linyu
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Monday, February 20, 2017 1:42 PM > To: YUAN Linyu; David S . Miller; Andrew Lunn > Cc: netdev@vger.kernel.org; cug...@163.com > Subject: Re: create drivers/net/mdio and move mdio drivers into it > > 4.

RE: create drivers/net/mdio and move mdio drivers into it

2017-02-19 Thread YUAN Linyu
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Monday, February 20, 2017 2:16 PM > To: YUAN Linyu; David S . Miller; Andrew Lunn > Cc: netdev@vger.kernel.org; cug...@163.com > Subject: Re: create drivers/net/mdio and move mdio drivers into it > > >

Re: create drivers/net/mdio and move mdio drivers into it

2017-02-19 Thread Florian Fainelli
On 02/19/2017 10:10 PM, YUAN Linyu wrote: > > >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Monday, February 20, 2017 1:42 PM >> To: YUAN Linyu; David S . Miller; Andrew Lunn >> Cc: netdev@vger.kernel.org; cug...@163.com >> Subject: Re: create

RE: create drivers/net/mdio and move mdio drivers into it

2017-02-19 Thread YUAN Linyu
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Monday, February 20, 2017 1:42 PM > To: YUAN Linyu; David S . Miller; Andrew Lunn > Cc: netdev@vger.kernel.org; cug...@163.com > Subject: Re: create drivers/net/mdio and move mdio drivers into it > > 3.

Re: [PATCH net-next] openvswitch: Set event bit after initializing labels.

2017-02-19 Thread Pravin Shelar
On Fri, Feb 17, 2017 at 6:11 PM, Jarno Rajahalme wrote: > Connlabels are included in conntrack netlink event messages only if > the IPCT_LABEL bit is set in the event cache (see > ctnetlink_conntrack_event()). Set it after initializing labels for a > new connection. > > Found upon

Re: create drivers/net/mdio and move mdio drivers into it

2017-02-19 Thread Florian Fainelli
On 02/19/2017 09:23 PM, YUAN Linyu wrote: > 1. the main issue is mdio driver mixed with phy driver/ethernet driver. You can have a standalone MDIO bus driver located anywhere you want in the kernel tree. See drivers/net/ethernet/marvell/mvmdio.c for an example. > 2. move them together, it's

RE: create drivers/net/mdio and move mdio drivers into it

2017-02-19 Thread YUAN Linyu
1. the main issue is mdio driver mixed with phy driver/ethernet driver. 2. move them together, it's easy to maintain, add, delete or optimization(we can do it step by step). 3. another idea is bind mdio device to network device 4. support mdio auto probe phy device. For 3, 4 can take device tree

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

2017-02-19 Thread Heiko Schocher
Hello all, Am 13.02.2017 um 22:31 schrieb Rob Herring: On Mon, Feb 13, 2017 at 12:38 AM, Heiko Schocher wrote: Hello Rob, Am 10.02.2017 um 16:51 schrieb Rob Herring: On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote: From: Guan Ben

Re: [PATCH v1 2/2] net: emac: add support for device-tree based PHY discovery and setup

2017-02-19 Thread Florian Fainelli
On 02/19/2017 01:22 PM, Christian Lamparter wrote: > This patch adds glue-code that allows the EMAC driver to interface > with the existing dt-supported PHYs in drivers/net/phy. > > Because currently, the emac driver maintains a small library of > supported phys for in a private phy.c file

Re: [PATCH repost] ptr_ring: fix race conditions when resizing

2017-02-19 Thread Michael S. Tsirkin
On Sun, Feb 19, 2017 at 12:52:48AM -0500, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Sun, 19 Feb 2017 07:17:17 +0200 > > > Dave, could you merge this before 4.10? If not - I can try. > > I just sent my last pull request to Linus, please merge it to > him directly.

Re: create drivers/net/mdio and move mdio drivers into it

2017-02-19 Thread Florian Fainelli
On 02/19/2017 04:20 PM, YUAN Linyu wrote: > Hi, > > I have an idea to create drivers/net/mdio and move mdio > drivers(drivers/net/phy/mdio-* | drivers/net/ethernet/xxx/mdio-yyy | ) into > it. > > Do you think it is acceptable ? What problem are you trying to fix by doing such a move? Moving

Re: [PATCH net v5] bpf: add helper to compare network namespaces

2017-02-19 Thread Eric W. Biederman
Daniel Borkmann writes: > On 02/16/2017 02:29 AM, David Ahern wrote: >> In cases where bpf programs are looking at sockets and packets >> that belong to different netns, it could be useful to compare the >> network namespace of the socket or packet >> >> Introduce

[PATCH net-next V2] virito-net: set queues after reset during xdp_set

2017-02-19 Thread Jason Wang
We set queues before reset which will cause a crash[1]. This is because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs number to do the correct detection. So fix this by - passing xdp queue pairs and current queue pairs to virtnet_reset() - change vi->xdp_qp after reset but before

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-19 Thread Jason Wang
On 2017年02月19日 13:08, Michael S. Tsirkin wrote: - oxdp_qp = vi->xdp_queue_pairs; - /* Changing the headroom in buffers is a disruptive operation because * existing buffers must be flushed and reallocated. This will happen * when a xdp program is initially added

linux-next: manual merge of the tip tree with the net-next tree

2017-02-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in: kernel/extable.c between commit: 74451e66d516 ("bpf: make jited programs visible in traces") from the net-next tree and commit: 5b485629ba0d ("kprobes, extable: Identify kprobes trampolines as kernel text area") from

create drivers/net/mdio and move mdio drivers into it

2017-02-19 Thread YUAN Linyu
Hi, I have an idea to create drivers/net/mdio and move mdio drivers(drivers/net/phy/mdio-* | drivers/net/ethernet/xxx/mdio-yyy | ) into it. Do you think it is acceptable ? Thanks

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-19 Thread Michael S. Tsirkin
On Fri, Feb 17, 2017 at 03:30:51PM -0800, John Fastabend wrote: > On 17-02-16 09:10 PM, Jason Wang wrote: > > > > > > On 2017年02月17日 12:53, John Fastabend wrote: > >> On 17-02-15 01:08 AM, Jason Wang wrote: > >>> We set queues before reset which will cause a crash[1]. This is > >>> because

linux-next: manual merge of the kspp tree with the net-next tree

2017-02-19 Thread Stephen Rothwell
Hi Kees, Today's linux-next merge of the kspp tree got a conflict in: include/linux/filter.h between commit: 74451e66d516 ("bpf: make jited programs visible in traces") from the net-next tree and commit: 0f5bf6d0afe4 ("arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX")

Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

2017-02-19 Thread David Miller
From: David Daney Date: Fri, 17 Feb 2017 12:04:12 -0800 > Some Cavium dev boards have firmware which doesn't supply a proper > ethernet-phy-ieee802.3-c22" compatible property. Restore these boards > to working order by whitelisting this compatible value. > >

Re: [PATCH] net: ethernet: stmmac: dwmac-rk: Add RK3328 gmac support

2017-02-19 Thread David Miller
From: David Wu Date: Fri, 17 Feb 2017 20:55:11 +0800 > From: "david.wu" > > Add constants and callback functions for the dwmac on rk3328 socs. > As can be seen, the base structure is the same, only registers and the > bits in them moved

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-19 Thread David Miller
From: Xin Long Date: Fri, 17 Feb 2017 16:35:24 +0800 > sctp has changed to use rhlist for transport rhashtable since commit > 7fda702f9315 ("sctp: use new rhlist interface on sctp transport > rhashtable"). > > But rhltable_insert_key doesn't check the duplicate node when

Re: [PATCH net-next] sctp: sctp_transport_dst_check should check if transport pmtu is dst mtu

2017-02-19 Thread David Miller
From: Xin Long Date: Fri, 17 Feb 2017 16:41:45 +0800 > Now when sending a packet, sctp_transport_dst_check will check if dst > is obsolete by calling ipv4/ip6_dst_check. But they return obsolete > only when adding a new cache, after that when the cache's pmtu is > updated

Re: [PATCHv2 net-next 0/7] sctp: add receiver-side procedures for stream reconf ssn reset request chunk

2017-02-19 Thread David Miller
From: Xin Long Date: Fri, 17 Feb 2017 12:45:36 +0800 > Patch 3/7 and 4/7 are to implement receiver-side procedures for the > Outgoing and Incoming SSN Reset Request Parameter described in rfc6525 > section 5.2.2 and 5.2.3 > > Patch 1/7 and 2/7 are ahead of them to define

Re: [PATCH v2] uapi: fix linux/mroute.h userspace compilation errors

2017-02-19 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 16 Feb 2017 18:04:46 +0300 > Include to fix the following linux/mroute.h userspace > compilation errors: > > /usr/include/linux/mroute.h:58:18: error: field 'vifc_lcl_addr' has > incomplete type > struct in_addr vifc_lcl_addr; /*

Re: [PATCH V5 net-next 1/2] qed: Add support for hardware offloaded FCoE.

2017-02-19 Thread David Miller
Applied to net-next, thanks.

Re: [PATCH v2 2/2] uapi: fix linux/rds.h userspace compilation error

2017-02-19 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 16 Feb 2017 18:05:45 +0300 > On the kernel side, sockaddr_storage is #define'd to > __kernel_sockaddr_storage. Replacing struct sockaddr_storage with > struct __kernel_sockaddr_storage defined by fixes > the following linux/rds.h userspace

Re: [PATCH v2 1/2] uapi: fix linux/rds.h userspace compilation errors

2017-02-19 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 16 Feb 2017 18:05:13 +0300 > Consistently use types from linux/types.h to fix the following > linux/rds.h userspace compilation errors: ... > Signed-off-by: Dmitry V. Levin Applied.

Re: [PATCH v2] uapi: fix linux/mroute6.h userspace compilation errors

2017-02-19 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 16 Feb 2017 18:04:29 +0300 > Include to fix the following linux/mroute6.h userspace > compilation errors: > > /usr/include/linux/mroute6.h:80:22: error: field 'mf6cc_origin' has > incomplete type > struct sockaddr_in6 mf6cc_origin; /*

Re: [PATCH v2] uapi: fix linux/ipv6_route.h userspace compilation errors

2017-02-19 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 16 Feb 2017 18:04:14 +0300 > Include to fix the following linux/ipv6_route.h userspace > compilation errors: > > /usr/include/linux/ipv6_route.h:42:19: error: field 'rtmsg_dst' has > incomplete type > struct in6_addr rtmsg_dst; >

Re: [PATCH net] ibmvnic: Handle processing of CRQ messages in a tasklet

2017-02-19 Thread David Miller
From: Thomas Falcon Date: Wed, 15 Feb 2017 12:17:58 -0600 > Create a tasklet to process queued commands or messages received from > firmware instead of processing them in the interrupt handler. Note that > this handler does not process network traffic, but

Re: [PATCH net] ibmvnic: Make CRQ interrupt tasklet wait for all capabilities crqs

2017-02-19 Thread David Miller
From: Thomas Falcon Date: Wed, 15 Feb 2017 12:18:00 -0600 > After sending device capability queries and requests to the vNIC Server, > an interrupt is triggered and the responses are written to the driver's > CRQ response buffer. Since the interrupt can be triggered

Re: [PATCH net] ibmvnic: Use common counter for capabilities checks

2017-02-19 Thread David Miller
From: Thomas Falcon Date: Wed, 15 Feb 2017 12:17:59 -0600 > Two different counters were being used for capabilities > requests and queries. These commands are not called > at the same time so there is no reason a single counter > cannot be used. > > Signed-off-by:

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-19 Thread Saeed Mahameed
On Sat, Feb 18, 2017 at 4:46 AM, Eric Dumazet wrote: > On Thu, 2017-02-16 at 07:30 -0800, Eric Dumazet wrote: >> On Thu, 2017-02-16 at 14:38 +0200, Saeed Mahameed wrote: >> >> > Acked-by: Saeed Mahameed >> >> Thanks for reviewing this Saeed ! > > Note

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-19 Thread Saeed Mahameed
On Fri, Feb 17, 2017 at 1:13 AM, Eric Dumazet wrote: > On Thu, 2017-02-16 at 23:17 +0200, Saeed Mahameed wrote: > >> so i guess you are not busy polling .. and adaptive moderation decided >> to lower down >> rx-usecs for you, and you are looking to improve latency. >> >> >

[PATCH] net: qlogic: qlge: use new api ethtool_{get|set}_link_ksettings

2017-02-19 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c |

Re: [PATCH net] mlx4: fix potential divide by 0 in mlx4_en_auto_moderation()

2017-02-19 Thread Saeed Mahameed
On Fri, Feb 17, 2017 at 1:23 AM, Eric Dumazet wrote: > From: Eric Dumazet > > 1) In the case where rate == priv->pkt_rate_low == priv->pkt_rate_high, > mlx4_en_auto_moderation() does a divide by zero. > > 2) We want to properly change the moderation

[PATCH] net: qlogic: qlcnic: use new api ethtool_{get|set}_link_ksettings

2017-02-19 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c

[PATCH v1 2/2] net: emac: add support for device-tree based PHY discovery and setup

2017-02-19 Thread Christian Lamparter
This patch adds glue-code that allows the EMAC driver to interface with the existing dt-supported PHYs in drivers/net/phy. Because currently, the emac driver maintains a small library of supported phys for in a private phy.c file located in the drivers directory. The support is limited to mostly

[PATCH v1 1/2] dt: emac: document device-tree based phy discovery and setup

2017-02-19 Thread Christian Lamparter
This patch adds documentation for a new "phy-handle" property, "fixed-link" and "mdio" sub-node. These allows the enumeration of PHYs which are supported by the phy library under drivers/net/phy. The EMAC ethernet controller in IBM and AMCC 4xx chips is currently stuck with a few privately

Re: [patch] socket.7: Document SO_INCOMING_CPU

2017-02-19 Thread Michael Kerrisk (man-pages)
[CC += Eric, so that he might review] Hello Francois, On 02/18/2017 05:06 AM, Francois Saint-Jacques wrote: > This socket option is undocumented. Applies on the latest version > (man-pages-4.09-511). > > diff --git a/man7/socket.7 b/man7/socket.7 > index 3efd7a5d8..1a3ffa253 100644 > ---

Re: [patch iproute2/net-next] devlink: use DEVLINK_CMD_ESWITCH_* instead of DEVLINK_CMD_ESWITCH_MODE_*

2017-02-19 Thread Jiri Pirko
Sun, Feb 19, 2017 at 09:01:15PM CET, step...@networkplumber.org wrote: >On Sun, 19 Feb 2017 15:37:06 +0100 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> Sync with kernel and don't use the obsolete enum values. >> >> Signed-off-by: Jiri Pirko

Re: [PATCH net-next 7/7] nfp: allow application firmware to limit number of SR-IOV VFs

2017-02-19 Thread Jakub Kicinski
On Sun, Feb 19, 2017 at 8:00 AM, Mintz, Yuval wrote: >> +static void nfp_pcie_sriov_read_nfd_limit(struct nfp_pf *pf) >> +{ >> + int err; >> + >> + pf->limit_vfs = nfp_rtsym_read_le(pf->cpp, "nfd_vf_cfg_max_vfs", >> ); >> + if (!err) >> + return; >>

Re: [patch iproute2/net-next] devlink: use DEVLINK_CMD_ESWITCH_* instead of DEVLINK_CMD_ESWITCH_MODE_*

2017-02-19 Thread Stephen Hemminger
On Sun, 19 Feb 2017 15:37:06 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > Sync with kernel and don't use the obsolete enum values. > > Signed-off-by: Jiri Pirko > --- > devlink/devlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH net-next v2 5/7] nfp: add very basic access to NSP logs

2017-02-19 Thread Jakub Kicinski
Allow dumping "arm.diag" resource with ethtool -w. This resource should contain a text log of the NSP (control processor) application. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 2 +

[PATCH net-next v2 3/7] nfp: store NSP ABI version in state structure

2017-02-19 Thread Jakub Kicinski
We read the status register on each NSP open, we can store the NSP ABI version in the state structure so that we don't have to read it again. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 27 +++--- 1 file

[PATCH net-next v2 0/7] nfp: expose more firmware and hw debug info

2017-02-19 Thread Jakub Kicinski
Hi! This series is mostly a result of flash firmware team requesting access to some of the information and data necessary for debugging firmware problems. Patch 1 adds a missing error message. Patch 2 prints manufacturing info to logs in case PCI VPD capability is not programmed correctly.

[PATCH net-next v2 4/7] nfp: report NSP ABI version in ethtool FW version

2017-02-19 Thread Jakub Kicinski
ethtool_drvinfo->fw_version can cantain multiple FW strings. We already report NFD ABI version there, add NSP ABI version if available (i.e. on PF) with 'sp:' prefix. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 4

[PATCH net-next v2 1/7] nfp: refactor NSP initialization and add error message

2017-02-19 Thread Jakub Kicinski
When acquiring NSP communication resource fails user is left with "probe failed with error -2" PCI code message but no info on what caused the problem. Some development boards may not have NSP FW in the flash image. Help users with a more verbouse message. While at it move the whole NSP init to

[PATCH net-next v2 2/7] nfp: report manufacturing info on load

2017-02-19 Thread Jakub Kicinski
Report card manufacturing information when driver loads. These identify the version of the board and its subcomponents. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH net-next v2 7/7] nfp: allow application firmware to limit number of SR-IOV VFs

2017-02-19 Thread Jakub Kicinski
Some application firmware projects may choose to limit the number of VFs available below what is specified in PCI capability to be able to reuse the PCIe interface resources. There may also be projects which use cases don't require SR-IOV support at all and therefore don't want to spend time

[PATCH net-next v2 6/7] nfp: return nfp_rtsym_read_le() errors correctly

2017-02-19 Thread Jakub Kicinski
nfp_rtsym_read_le() has an out parameter for error codes. We have to use that instead of returning errors directly. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c | 8 +--- 1 file changed, 5 insertions(+), 3

Re: [patch iproute2/net-next] devlink: use DEVLINK_CMD_ESWITCH_* instead of DEVLINK_CMD_ESWITCH_MODE_*

2017-02-19 Thread Stephen Hemminger
On Sun, 19 Feb 2017 15:37:06 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > Sync with kernel and don't use the obsolete enum values. > > Signed-off-by: Jiri Pirko > --- > devlink/devlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH][CFT] Saner error handling in skb_copy_datagram_iter() et.al.

2017-02-19 Thread Christian Lamparter
On Saturday, February 18, 2017 12:02:14 AM CET Al Viro wrote: > On Fri, Feb 17, 2017 at 05:03:15PM +, Al Viro wrote: > > On Fri, Feb 17, 2017 at 10:54:20AM -0500, David Miller wrote: > > > From: Al Viro > > > Date: Tue, 14 Feb 2017 01:33:06 + > > > > > > > OK...

[PATCH] wcn36xx: Fix error handling

2017-02-19 Thread Christophe JAILLET
Reorder 'out_free_dxe_pool' and 'out_free_dxe_ctl' error handling labels in order to match the way resources have been allocated. Signed-off-by: Christophe JAILLET --- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-19 Thread Christoph Hellwig
On Thu, Feb 16, 2017 at 07:43:34PM +0200, Sagi Grimberg wrote: > Several locations in the stack need to handle ipv4/ipv6 > (with scope) and port strings conversion to sockaddr. > Add a helper that takes either AF_INET, AF_INET6 or > AF_UNSPEC (for wildcard) to centralize this handling. > >

RE: [PATCH net-next 7/7] nfp: allow application firmware to limit number of SR-IOV VFs

2017-02-19 Thread Mintz, Yuval
> +static void nfp_pcie_sriov_read_nfd_limit(struct nfp_pf *pf) > +{ > + int err; > + > + pf->limit_vfs = nfp_rtsym_read_le(pf->cpp, "nfd_vf_cfg_max_vfs", > ); > + if (!err) > + return; > + > + pf->limit_vfs = ~0; > + /* Allow any setting for backwards compatibility

pull request: bluetooth-next 2017-02-19

2017-02-19 Thread Johan Hedberg
Hi Dave, Here's a set of Bluetooth patches for the 4.11 kernel: - New USB IDs to the btusb driver - Race fix in btmrvl driver - Added out-of-band wakeup support to the btusb driver - NULL dereference fix to bt_sock_recvmsg Please let me know if there are any issues pulling. Thanks. Johan

Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

2017-02-19 Thread Oliver Hartkopp
Hi all, On 02/15/2017 03:08 PM, Quentin Schulz wrote: From: Florian Vallee According to the m_can user manual changelog the BTP register layout was updated with core revision 3.1.0 This change is not backward-compatible and using the current driver along with a recent IP

Re: [RFC 1/2] dt: emac: document device-tree based phy discovery and setup

2017-02-19 Thread Christian Lamparter
On Sunday, February 5, 2017 2:33:44 PM CET Florian Fainelli wrote: > Le 02/05/17 à 14:25, Christian Lamparter a écrit : > > This patch adds documentation for a new "phy-handler" property > > and "mdio" sub-node. These allows the enumeration of PHYs which > > are supported by the phy library under

Re: [PATCH net-next] GTP: Add some basic documentation about drivers/net/gtp.c

2017-02-19 Thread Andreas Schultz
- On Feb 18, 2017, at 1:58 PM, laforge lafo...@gnumonks.org wrote: > In order to clarify what the module actually does, and how to use it, > let's add some basic documentation to the kernel tree, together with > pointers to related specs and projects. > > Signed-off-by: Harald Welte

Re: [RFC 2/2] net: emac: add support for device-tree based PHY discovery and setup

2017-02-19 Thread Christian Lamparter
On Wednesday, February 15, 2017 3:23:08 PM CET Andrew Lunn wrote: > > > > Is the PHY just powered down by chance (BMCR_PWRDN set?) and resetting > > > > it implicitly clears the power down that seems to be what is going on. > > > > > > Yes, the PHY is just in the BMCR_PDOWN state. I can do the

[patch iproute2/net-next] devlink: use DEVLINK_CMD_ESWITCH_* instead of DEVLINK_CMD_ESWITCH_MODE_*

2017-02-19 Thread Jiri Pirko
From: Jiri Pirko Sync with kernel and don't use the obsolete enum values. Signed-off-by: Jiri Pirko --- devlink/devlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 34a409f..c357580

Re: [PATCH net 0/4] update ipvs sysctl document

2017-02-19 Thread Julian Anastasov
Hello, On Fri, 17 Feb 2017, Hangbin Liu wrote: > Fix and add some new ipvs sysctl options. Also use tab instead of whitespaces > to indent the descriptions. You change only docs, so the patchset should be for the net-next tree. > Hangbin Liu (4): > ipvs: fix sync_threshold

[PATCH net 09/10] qed: Don't allocate SBs using main PTT

2017-02-19 Thread Yuval Mintz
Flows accessing registers require the flow to hold a PTT entry. To protect 'major' load/unload flows a main_ptt is pre-allocated to guarantee such flows wouldn't be blocked by PTT being unavailable. Status block initialization currently uses the main_ptt which is incorrect, as this flow might run

[PATCH net 10/10] qed*: Fix link indication race

2017-02-19 Thread Yuval Mintz
Driver changes the link properties via communication with the management firmware, and re-reads the resulting link status when it receives an indication that the link has changed. However, there are certain scenarios where such indications might be missing, and so driver also re-reads the current

[PATCH net 07/10] qed: Reflect PF link when initializing VF

2017-02-19 Thread Yuval Mintz
VF learns of the current link state via its bulletin board, which might reflect either the physical link state or some user-configured logical state. Whenever the physical link changes or whnever such a configuration is explicitly made by user the PF driver would update the bulletin that the VF

[PATCH net 02/10] qed: Read queue state before releasing buffer

2017-02-19 Thread Yuval Mintz
From: Ram Amrani Currently the state is read only after the buffers are relesed. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 12 ++-- 1 file changed, 6

[PATCH net 08/10] qede: Prevent index problems in loopback test

2017-02-19 Thread Yuval Mintz
From: Sudarsana Reddy Kalluru Driver currently utilizes the same loop variable in two nested loops. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz ---

[PATCH net 05/10] qede: Initialize lock and slowpath workqueue early

2017-02-19 Thread Yuval Mintz
Need to make sure the slowpath workqueue and the qede lock are ready for the registration of the netdevice, as once registered there's no guarantee those wouldn't be used. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 9 +++-- 1 file

[PATCH net 03/10] qed: Don't free a QP more than once

2017-02-19 Thread Yuval Mintz
From: Ram Amrani If QP is in reset state then there are no resources to free so avoid freeing any. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 49

[PATCH net 04/10] qed: Reserve doorbell BAR space for present CPUs

2017-02-19 Thread Yuval Mintz
From: Ram Amrani Reserving doorbell BAR space according to the currently active CPUs may result in a bug if disabled CPUs are later enabled but no doorbell space was reserved for them. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz

[PATCH net 06/10] qede: Free netdevice only after stoping slowpath

2017-02-19 Thread Yuval Mintz
qed needs to be informed of the removal of the qede interface prior to its actual removal, as qede has some registered callbacks that might get called async to the removal flow. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 10 --

[PATCH net 00/10] qed*: Bug fixes

2017-02-19 Thread Yuval Mintz
Hi Dave, The 3 first patches here are a repost of ("qed: RoCE infrastructure fixes"). The fourth is an additional RoCE-related infrastructure fix, and the latter contain various fixes to qed/qede. Notice patch #10 will create a conflict when net and net-next would be merged [although its fix is

[PATCH net 01/10] qed: Release CQ resource under lock on failure

2017-02-19 Thread Yuval Mintz
From: Ram Amrani The CQ resource pool is protected by a spin lock. When a CQ creation fails it now deallocates under that lock as well. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz ---

Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller

2017-02-19 Thread Neftin, Sasha
On 2/16/2017 20:42, Bernd Faust wrote: After an upgrade to Linux kernel v4.x the hardware timestamps of the 82579 Gigabit Ethernet Controller are different than expected. The values that are being read are almost four times as big as before the kernel upgrade. The difference is that after the

Re: [PATCH net-next 11/13] net: ethernet: aquantia: Refactoring buffers copying.

2017-02-19 Thread Lino Sanfilippo
Hi, On 16.02.2017 17:37, David Laight wrote: > From: Lino Sanfilippo >> Sent: 16 February 2017 16:02 > ... >> I was referring to the copy of tx descriptors, not the frames/fragments >> itself. >> I wrote "tx buffers" because in this driver a descriptor is represented as >> a struct

[PATCH] qlcnic: Fix a memory leak in error handling path

2017-02-19 Thread Christophe JAILLET
If 'dma_alloc_coherent()' fails, we should release resources allocated so far, just as done in all other cases in this function. Signed-off-by: Christophe JAILLET --- checkpatch.pl complains about '== NULL'. I have left it as-is because both '== NULL' and '!' are

[PATCH] net: mvpp2: Fix a memory leak in error handling path

2017-02-19 Thread Christophe JAILLET
if 'devm_kzalloc()' fails, we should release resources allocated so far, just as done a few lines below. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/marvell/mvpp2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

RE: Support for 2500BaseT and 5000BaseT patch

2017-02-19 Thread Ami Hadas
OK, Here it is again. Thanks, Ami -Original Message- From: John W. Linville [mailto:linvi...@tuxdriver.com] Sent: Friday, February 17, 2017 4:42 PM To: Ami Hadas Subject: Re: Support for 2500BaseT and 5000BaseT patch Well, I think the patch looks fine. But I