Re: Questions on XDP

On Mon, Feb 20, 2017 at 08:00:57PM -0800, Alexander Duyck wrote: > > I assumed "toy Tx" since I wasn't aware that they were actually > allowing writing to the page. I think that might work for the XDP_TX > case, Take a look at samples/bpf/xdp_tx_iptunnel_kern.c It's close enough approximation

Re: [PATCH net-next 1/1] net: sock: Use USEC_PER_SEC macro instead of literal 1000000

On Tue, Feb 21, 2017 at 3:13 PM, Joe Perches wrote: > On Mon, 2017-02-20 at 22:33 +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> The USEC_PER_SEC is used once in sock_set_timeout as the max value of >> tv_usec. But there are other similar codes which use

Re: [PATCH net-next 1/1] net: sock: Use USEC_PER_SEC macro instead of literal 1000000

On Mon, 2017-02-20 at 22:33 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > The USEC_PER_SEC is used once in sock_set_timeout as the max value of > tv_usec. But there are other similar codes which use the literal > 100 in this file. > It is minor cleanup to keep

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Gregory, On Mon, 20 Feb 2017 15:21:35 +0100 Gregory CLEMENT wrote: > Hi Jisheng, > > On lun., févr. 20 2017, Jisheng Zhang wrote: > > > In hot code path such as mvneta_rx_swbm(), we access fields of rx_desc > > and tx_desc. These DMA descs are allocated by

Re: Questions on XDP

On Mon, Feb 20, 2017 at 7:39 PM, John Fastabend wrote: > On 17-02-20 07:18 PM, Alexei Starovoitov wrote: >> On Sat, Feb 18, 2017 at 06:16:47PM -0800, Alexander Duyck wrote: >>> >>> I was thinking about the fact that the Mellanox driver is currently >>> mapping pages as

Re: Questions on XDP

On 17-02-20 07:18 PM, Alexei Starovoitov wrote: > On Sat, Feb 18, 2017 at 06:16:47PM -0800, Alexander Duyck wrote: >> >> I was thinking about the fact that the Mellanox driver is currently >> mapping pages as bidirectional, so I was sticking to the device to >> device case in regards to that

Re: [PATCH net-next V2] virito-net: set queues after reset during xdp_set

From: Jason Wang Date: Mon, 20 Feb 2017 11:50:20 +0800 > We set queues before reset which will cause a crash[1]. This is > because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs > number to do the correct detection. So fix this by > > - passing xdp queue pairs

Re: [PATCH] dpaa_eth: implement ioctl() for PHY-related ops

From: Michael Walle Date: Mon, 20 Feb 2017 16:54:18 +0100 > This commit adds the ndo_do_ioctl() callback which allows the userspace to > access PHY registers, for example. This will make mii-diag and similar > tools work. > > Signed-off-by: Michael Walle

Re: [PATCH] net: qualcomm: qca: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 20 Feb 2017 22:59:13 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: Questions on XDP

On Sat, Feb 18, 2017 at 06:16:47PM -0800, Alexander Duyck wrote: > > I was thinking about the fact that the Mellanox driver is currently > mapping pages as bidirectional, so I was sticking to the device to > device case in regards to that discussion. For virtual interfaces we > don't even need

Re: [net-next][PATCH v2] RDS: Make user visible data types consistent with rest of the kernel

From: Santosh Shilimkar Date: Mon, 20 Feb 2017 14:16:53 -0800 > Use "__uX/__sX" kernel types rather than current uint*/int* for > entire file. > > Reviewed-by: Sowmini Varadhan > Signed-off-by: Santosh Shilimkar

Re: [PATCH net-next 0/3] bnxt_en: Fix probe and open bugs.

From: Michael Chan Date: Mon, 20 Feb 2017 19:25:15 -0500 > Fix 3 issues related to bnxt_init_one() and bnxt_open(). Don't probe > bridge devices and fixup some error code paths. Series applied, thanks Michael.

Re: [PATCH net-next 3/3] bpf: make jited programs visible in traces

On 02/20/2017 08:07 PM, Daniel Borkmann wrote: On 02/20/2017 08:05 PM, Eric Dumazet wrote: [...] Latest net-next tree dies on my hosts, and my bisection came to this commit. Thanks for the report, I'll take a look! Fyi, fix will come tomorrow.

Re: [PATCH net-next v3 1/8] gtp: add documentation

On Mon, Feb 20, 2017 at 06:28:07PM +0100, Andreas Schultz wrote: > >> +A specific tunnel is only defined by the destination entity. Since the > >> +destination port is constant, only the destination IP and TEID define > >> +a tunnel. The source IP and Port have no meaning for the tunnel. > > > >

Re: [lkp-robot] [tcp] e70ac17165: WARNING:at_kernel/softirq.c:#__local_bh_enable_ip

On 02/20, Eric Dumazet wrote: >On Sun, Feb 19, 2017 at 6:11 PM, kernel test robot > wrote: >> >> FYI, we noticed the following commit: >> >> commit: e70ac171658679ecf6bea4bbd9e9325cd6079d2b ("tcp: tcp_probe: use >> spin_lock_bh()") >>

RE: create drivers/net/mdio and move mdio drivers into it

> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Tuesday, February 21, 2017 6:31 AM > To: YUAN Linyu; David S . Miller; Andrew Lunn > Cc: netdev@vger.kernel.org; cug...@163.com > Subject: Re: create drivers/net/mdio and move mdio drivers into it > > >

Re: Focusing the XDP project

On Mon, Feb 20, 2017 at 3:39 PM, Jesper Dangaard Brouer wrote: > On Mon, 20 Feb 2017 12:09:30 -0800 > Alexander Duyck wrote: > >> On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer >> wrote: >> > >> > First thing to bring in

[PATCH net-next 0/3] bnxt_en: Fix probe and open bugs.

Fix 3 issues related to bnxt_init_one() and bnxt_open(). Don't probe bridge devices and fixup some error code paths. Michael Chan (1): bnxt_en: Fix NULL pointer dereference in a failure path during open. Ray Jui (1): bnxt_en: Reject driver probe against all bridge devices Sathya Perla (1):

[PATCH net-next 3/3] bnxt_en: fix pci cleanup in bnxt_init_one() failure path

From: Sathya Perla In the bnxt_init_one() failure path, bar1 and bar2 are not being unmapped. This commit fixes this issue. Reorganize the code so that bnxt_init_one()'s failure path and bnxt_remove_one() can call the same function to do the PCI cleanup.

[PATCH net-next 1/3] bnxt_en: Reject driver probe against all bridge devices

From: Ray Jui There are additional SoC devices that use the same device ID for bridge and NIC devices. The bnxt driver should reject probe against all bridge devices since it's meant to be used with only endpoint devices. Signed-off-by: Ray Jui

[PATCH net-next 2/3] bnxt_en: Fix NULL pointer dereference in a failure path during open.

If bnxt_hwrm_ring_free() is called during a failure path in bnxt_open(), it is possible that the completion rings have not been allocated yet. In that case, the completion doorbell has not been initialized, and calling bnxt_disable_int() will crash. Fix it by checking that the completion ring has

Re: Focusing the XDP project

On Mon, Feb 20, 2017 at 2:57 PM, Saeed Mahameed wrote: > > > On 02/20/2017 10:09 PM, Alexander Duyck wrote: >> On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer >> wrote: >>> >>> First thing to bring in order for the XDP project: >>> >>> RX

Re: Focusing the XDP project

On Mon, 20 Feb 2017 12:09:30 -0800 Alexander Duyck wrote: > On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer > wrote: > > > > First thing to bring in order for the XDP project: > > > > RX batching is missing. > > > > I don't want to discuss

Re: Focusing the XDP project

On 02/20/2017 10:09 PM, Alexander Duyck wrote: > On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer > wrote: >> >> First thing to bring in order for the XDP project: >> >> RX batching is missing. >> >> I don't want to discuss packet page-sizes or multi-port forwarding,

Re: net: possible deadlock in skb_queue_tail

On Mon, Feb 20, 2017 at 5:29 AM, Andrey Konovalov wrote: > other info that might help us debug this: > > Possible unsafe locking scenario: > >CPU0CPU1 > > lock(&(>lock)->rlock); >

Re: [PATCH net-next v4 12/12] net: ethernet: aquantia: Copying tx buffers is not needed.

On 20.02.2017 20:36, Pavel Belous wrote: > From: Pavel Belous > > This fix removes copying of tx biffers. Typo: biffers -> buffers > Now we use ring->buff_fing directly. > > Signed-off-by: Pavel Belous > --- >

Re: [PATCH net-next v4 09/12] net: ethernet: aquantia: Call netdev_register after all initialized.

On 20.02.2017 20:36, Pavel Belous wrote: > From: Pavel Belous > > netdev_register should be called when everything is initialized. > Also we should use net_device->reg_state field instead own > "is_ndev_registered" flag to avoid any race. > > Signed-off-by: Pavel

Re: [PATCH net-next v4 03/12] net: ethernet: aquantia: Fixes for aq_ndev_change_mtu

Hi, On 20.02.2017 20:36, Pavel Belous wrote: > From: Pavel Belous > > 1)Removed unnecessary comparsion "old_mtu == new_mtu". > This check is not needed. Function aq_ndev_change_mtu wont be called > if mtu has not changed. > > 2)Removed extra assignment ndev->mtu =

Re: create drivers/net/mdio and move mdio drivers into it

On 02/19/2017 10:29 PM, YUAN Linyu wrote: > > >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Monday, February 20, 2017 1:42 PM >> To: YUAN Linyu; David S . Miller; Andrew Lunn >> Cc: netdev@vger.kernel.org; cug...@163.com >> Subject: Re: create

Re: create drivers/net/mdio and move mdio drivers into it

On 02/19/2017 10:26 PM, YUAN Linyu wrote: > > >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Monday, February 20, 2017 2:16 PM >> To: YUAN Linyu; David S . Miller; Andrew Lunn >> Cc: netdev@vger.kernel.org; cug...@163.com >> Subject: Re: create

[net-next][PATCH v2] RDS: Make user visible data types consistent with rest of the kernel

Use "__uX/__sX" kernel types rather than current uint*/int* for entire file. Reviewed-by: Sowmini Varadhan Signed-off-by: Santosh Shilimkar --- v1->v2: As suggested by David Miller, cleaned up entire header to use kernel types.

Re: [PATCH net-next 00/10] qed*: Bug fixes

From: Yuval Mintz Date: Mon, 20 Feb 2017 22:43:29 +0200 > This is a respin of the series with same name for net-next > instead of net [only patch #10 is changed]. > > The 3 first patches here are a repost of > ("qed: RoCE infrastructure fixes"). The fourth is an

Re: [PATCH net-next v4 00/12] net: ethernet: aquantia: improvements and fixes

From: Pavel Belous Date: Mon, 20 Feb 2017 22:36:38 +0300 > The following patchset contains improvements and fixes for aQuantia > AQtion ethernet driver from net-next tree. > > Most fixes are based on the comments from Lino Sanfilippo. > > Sanity testing was performed

Re: [PATCH v3 4/5] ipv6: addrconf: fix 48 bit 6lowpan autoconfiguration

Hello. [Added netdev in cc as it touches ipv6/addrconf] 6LoWPAN handling changes only so an ACK should be ok and we could carry it through the bluetooth tree after the respin (see below). David, is that ok with you? On 02/17/2017 04:50 PM, Luiz Augusto von Dentz wrote: From: Alexander

[PATCH] net: qualcomm: qca: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/qualcomm/qca_debug.c | 18

[PATCH net-next 08/10] qede: Prevent index problems in loopback test

From: Sudarsana Reddy Kalluru Driver currently utilizes the same loop variable in two nested loops. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz ---

[PATCH net-next 00/10] qed*: Bug fixes

Hi Dave, This is a respin of the series with same name for net-next instead of net [only patch #10 is changed]. The 3 first patches here are a repost of ("qed: RoCE infrastructure fixes"). The fourth is an additional RoCE-related infrastructure fix, and the latter contain various fixes to

[PATCH net-next 02/10] qed: Read queue state before releasing buffer

From: Ram Amrani Currently the state is read only after the buffers are relesed. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 12 ++-- 1 file changed, 6

[PATCH net-next 09/10] qed: Don't allocate SBs using main PTT

Flows accessing registers require the flow to hold a PTT entry. To protect 'major' load/unload flows a main_ptt is pre-allocated to guarantee such flows wouldn't be blocked by PTT being unavailable. Status block initialization currently uses the main_ptt which is incorrect, as this flow might run

[PATCH net-next 06/10] qede: Free netdevice only after stoping slowpath

qed needs to be informed of the removal of the qede interface prior to its actual removal, as qede has some registered callbacks that might get called async to the removal flow. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 10 --

[PATCH net-next 10/10] qed*: Fix link indication race

Driver changes the link properties via communication with the management firmware, and re-reads the resulting link status when it receives an indication that the link has changed. However, there are certain scenarios where such indications might be missing, and so driver also re-reads the current

[PATCH net-next 01/10] qed: Release CQ resource under lock on failure

From: Ram Amrani The CQ resource pool is protected by a spin lock. When a CQ creation fails it now deallocates under that lock as well. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz ---

[PATCH net-next 07/10] qed: Reflect PF link when initializing VF

VF learns of the current link state via its bulletin board, which might reflect either the physical link state or some user-configured logical state. Whenever the physical link changes or whnever such a configuration is explicitly made by user the PF driver would update the bulletin that the VF

[PATCH net-next 03/10] qed: Don't free a QP more than once

From: Ram Amrani If QP is in reset state then there are no resources to free so avoid freeing any. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 49

[PATCH net-next 04/10] qed: Reserve doorbell BAR space for present CPUs

From: Ram Amrani Reserving doorbell BAR space according to the currently active CPUs may result in a bug if disabled CPUs are later enabled but no doorbell space was reserved for them. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz

[PATCH net-next 05/10] qede: Initialize lock and slowpath workqueue early

Need to make sure the slowpath workqueue and the qede lock are ready for the registration of the netdevice, as once registered there's no guarantee those wouldn't be used. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 9 +++-- 1 file

RE

I am Viet Xuan Luong. I am an American soldier presently on active service with 4th Squadron battalion here in Afghanistan. I served with the third Infantry Division in Iraq before thousand of my lucky colleagues were pulled out in August Last year, leaving me among the unlucky ones drafted

Re: [PATCH net 00/10] qed*: Bug fixes

From: "Mintz, Yuval" Date: Mon, 20 Feb 2017 20:14:17 + > > > Hi Dave, >> > >> > The 3 first patches here are a repost of >> > ("qed: RoCE infrastructure fixes"). The fourth is an additional >> > RoCE-related infrastructure fix, and the latter contain various fixes >>

RE: [PATCH net 00/10] qed*: Bug fixes

> > Hi Dave, > > > > The 3 first patches here are a repost of > > ("qed: RoCE infrastructure fixes"). The fourth is an additional > > RoCE-related infrastructure fix, and the latter contain various fixes > > to qed/qede. > > > > Notice patch #10 will create a conflict when net and net-next would

Re: Focusing the XDP project

On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer wrote: > > First thing to bring in order for the XDP project: > > RX batching is missing. > > I don't want to discuss packet page-sizes or multi-port forwarding, > before we have established the most fundamental

Re: Questions on XDP

On Sat, 18 Feb 2017 19:48:25 -0800, John Fastabend wrote: > On 17-02-18 06:16 PM, Alexander Duyck wrote: > > On Sat, Feb 18, 2017 at 3:48 PM, John Fastabend > > wrote: > >> On 17-02-18 03:31 PM, Alexei Starovoitov wrote: > >>> On Sat, Feb 18, 2017 at 10:18 AM,

[PATCH net-next v4 10/12] net: ethernet: aquantia: Fixed incorrect buff->len calculation.

From: Pavel Belous rxd_wb->pkt_len is the total length of the packet. If we received a large packet (with length > AQ_CFG_RX_FRAME_MAX) then we will get multiple buffers. We need to fix the length of the last buffer. Signed-off-by: Pavel Belous

[PATCH net-next v4 05/12] net: ethernet: aquantia: Superfluous initialization of "err".

From: Pavel Belous Fixed superfluous initialization of err. Signed-off-by: Pavel Belous Reviewed-by: Lino Sanfilippo --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 8 +--- 1 file changed, 1 insertion(+),

[PATCH net-next v4 07/12] net: ethernet: aquantia: Using NETDEV_TX_OK instead 0.

From: Pavel Belous Use NETDEV_TX_OK as the return value for successful transmission. Signed-off-by: Pavel Belous Reviewed-by: Lino Sanfilippo --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- 1 file

[PATCH net-next v4 12/12] net: ethernet: aquantia: Copying tx buffers is not needed.

From: Pavel Belous This fix removes copying of tx biffers. Now we use ring->buff_fing directly. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 170 +--

[PATCH net-next v4 04/12] net: ethernet: aquantia: Using module_pci_driver.

From: Pavel Belous Remove boilerplate code by using macro module_pci_driver. Signed-off-by: Pavel Belous Reviewed-by: Lino Sanfilippo --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 20 +--- 1

[PATCH net-next v4 06/12] net: ethernet: aquantia: Fixed missing rtnl_unlock.

From: Pavel Belous rtnl_unlock should be called if error occurred. Signed-off-by: Pavel Belous Reviewed-by: Lino Sanfilippo --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 5 +++-- 1 file changed, 3

[PATCH net-next v4 02/12] net: ethernet: aquantia: Removed busy_count field.

From: Pavel Belous busy_count field and is_busy flag is not needed at all. Signed-off-by: Pavel Belous Reviewed-by: Lino Sanfilippo --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 11 ---

[PATCH net-next v4 11/12] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page.

From: Pavel Belous We should allocate the number of pages based on the config parameter AQ_CFG_RX_FRAME_MAX. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH net-next v4 09/12] net: ethernet: aquantia: Call netdev_register after all initialized.

From: Pavel Belous netdev_register should be called when everything is initialized. Also we should use net_device->reg_state field instead own "is_ndev_registered" flag to avoid any race. Signed-off-by: Pavel Belous ---

[PATCH net-next v4 08/12] net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc.

From: Pavel Belous We should check for a null pointer for aq_nic_ndev_alloc instead netdev_priv. Signed-off-by: Pavel Belous Reviewed-by: Lino Sanfilippo --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 7

[PATCH net-next v4 03/12] net: ethernet: aquantia: Fixes for aq_ndev_change_mtu

From: Pavel Belous 1)Removed unnecessary comparsion "old_mtu == new_mtu". This check is not needed. Function aq_ndev_change_mtu wont be called if mtu has not changed. 2)Removed extra assignment ndev->mtu = new_mtu; This assignment already done inside __dev_set_mtu().

[PATCH net-next v4 00/12] net: ethernet: aquantia: improvements and fixes

From: Pavel Belous The following patchset contains improvements and fixes for aQuantia AQtion ethernet driver from net-next tree. Most fixes are based on the comments from Lino Sanfilippo. Sanity testing was performed on real HW. No regression found. v1->v2:

[PATCH net-next v4 01/12] net: ethernet: aquantia: Removed extra assignment for skb->dev.

From: Pavel Belous This assignment is not needed. Signed-off-by: Pavel Belous Reviewed-by: Lino Sanfilippo --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH net] Don't allow overwrite of config src addr

Hello! On 02/20/2017 08:03 PM, Brian Russell wrote: When using IPv6 transport and a default dst, a pointer to the configured source address is passed into the route lookup. If no source address is configured, then the value is overwritten. IPv6 route lookup ignores egress ifindex match if the

[PATCH v1.1] net: emac: add support for device-tree based PHY discovery and setup

This patch adds glue-code that allows the EMAC driver to interface with the existing dt-supported PHYs in drivers/net/phy. Because currently, the emac driver maintains a small library of supported phys for in a private phy.c file located in the drivers directory. The support is limited to mostly

Re: [PATCH net-next 3/3] bpf: make jited programs visible in traces

On 02/20/2017 08:05 PM, Eric Dumazet wrote: [...] Latest net-next tree dies on my hosts, and my bisection came to this commit. Thanks for the report, I'll take a look!

Re: [PATCH net-next 3/3] bpf: make jited programs visible in traces

On Thu, 2017-02-16 at 22:24 +0100, Daniel Borkmann wrote: > Long standing issue with JITed programs is that stack traces from > function tracing check whether a given address is kernel code > through {__,}kernel_text_address(), which checks for code in core > kernel, modules and dynamically

[ANNOUNCE] iproute2-4.10

Release of iproute2 for Linux 4.10 Update to iproute2 utility to support new features in Linux 4.10 This release includes enhanced support for BPF, VRF and Flow based classifier (flower). The ss utility now can print more information when using TCP BBR. Also the usual array of small manual and

Re: [PATCH net-next v3 1/8] gtp: add documentation

Hi, - On Feb 20, 2017, at 5:15 PM, laforge lafo...@gnumonks.org wrote: > Hi Andreas, > > this is not really about the documentation, but it still makes sense to > discuss here as the issue is best described: > > On Mon, Feb 13, 2017 at 04:36:17PM +0100, Andreas Schultz wrote: >> +Local

[PATCH net] vxlan: don't allow overwrite of config src addr

When using IPv6 transport and a default dst, a pointer to the configured source address is passed into the route lookup. If no source address is configured, then the value is overwritten. IPv6 route lookup ignores egress ifindex match if the source adress is set, so if egress ifindex match is

Re: [PATCH net] ip: fix IP_CHECKSUM handling

On Mon, 20 Feb 2017 17:55:39 +0100 Paolo Abeni wrote: > The skbs processed by ip_cmsg_recv() are not guaranteed to > be linear e.g. when sending UDP packets over loopback with > MSGMORE. > Using csum_partial() on [potentially] the whole skb len > is dangerous; instead be on

[PATCH net] Don't allow overwrite of config src addr

When using IPv6 transport and a default dst, a pointer to the configured source address is passed into the route lookup. If no source address is configured, then the value is overwritten. IPv6 route lookup ignores egress ifindex match if the source adress is set, so if egress ifindex match is

[PATCH net] ip: fix IP_CHECKSUM handling

The skbs processed by ip_cmsg_recv() are not guaranteed to be linear e.g. when sending UDP packets over loopback with MSGMORE. Using csum_partial() on [potentially] the whole skb len is dangerous; instead be on the safe side and use skb_checksum(). Thanks to syzkaller team to detect the issue and

Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

On 02/15/2017 03:08 PM, Quentin Schulz wrote: > From: Florian Vallee > > According to the m_can user manual changelog the BTP register layout was > updated with core revision 3.1.0 > > This change is not backward-compatible and using the current driver along > with a recent

Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

On 02/20/2017 05:37 PM, Alexandre Belloni wrote: > On 19/02/2017 at 16:37:50 +0100, Oliver Hartkopp wrote: >> Fortunately I was contacted by Bosch this Friday as they want to contribute >> a driver upgrade to support IP cores up to 3.2.x. >> Additionally their plan is to use Device Tree

Re: [PATCH net-next V2] virito-net: set queues after reset during xdp_set

On Mon, Feb 20, 2017 at 11:50:20AM +0800, Jason Wang wrote: > We set queues before reset which will cause a crash[1]. This is > because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs > number to do the correct detection. So fix this by > > - passing xdp queue pairs and current queue

[PATCH net-next] vxlan: remove unused variable saddr in neigh_reduce

From: Roopa Prabhu silences the below warning: drivers/net/vxlan.c: In function ‘neigh_reduce’: drivers/net/vxlan.c:1599:25: warning: variable ‘saddr’ set but not used [-Wunused-but-set-variable] Signed-off-by: Roopa Prabhu ---

Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

On 19/02/2017 at 16:37:50 +0100, Oliver Hartkopp wrote: > Fortunately I was contacted by Bosch this Friday as they want to contribute > a driver upgrade to support IP cores up to 3.2.x. > Additionally their plan is to use Device Tree information to determine the > IP core revision - or at least to

Re: [PATCH 1/2] tcp: setup random timestamp offset when write_seq already set

On 20.02.2017 18:18, David Miller wrote: > This would be so much easier to understand if it were coded as: > if (!tp->repair) { > seq = secure_tcp_sequence_number(...); > if (!tp->write_seq) > tp->write_seq = seq; > } Hi David,

[PATCH net-next] vxlan: add changelink support

From: Roopa Prabhu This patch adds changelink rtnl op support for vxlan netdevs. code changes involve: - refactor vxlan_newlink into vxlan_nl2conf to be used by vxlan_newlink and vxlan_changelink - vxlan_nl2conf and vxlan_dev_configure take a changelink

Re: [PATCH net-next v3 09/12] net: ethernet: aquantia: Call netdev_register after all initialized.

From: Pavel Belous Date: Mon, 20 Feb 2017 14:41:51 +0300 > From: Pavel Belous > > netdev_register should be called when everything is initialized. > > Signed-off-by: Pavel Belous > Reviewed-by: Lino Sanfilippo

Re: [lkp-robot] [tcp] e70ac17165: WARNING:at_kernel/softirq.c:#__local_bh_enable_ip

On Sun, Feb 19, 2017 at 6:11 PM, kernel test robot wrote: > > FYI, we noticed the following commit: > > commit: e70ac171658679ecf6bea4bbd9e9325cd6079d2b ("tcp: tcp_probe: use > spin_lock_bh()") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > in

Re: [PATCH net-next] bpf: return errno -ENOMEM when exceeding RLIMIT_MEMLOCK

On Mon, 20 Feb 2017 16:57:34 +0100 Daniel Borkmann wrote: > On 02/20/2017 04:35 PM, Jesper Dangaard Brouer wrote: > > It is confusing users of samples/bpf that exceeding the resource > > limits for RLIMIT_MEMLOCK result in an "Operation not permitted" > > message. This is

Re: [PATCH net-next v3 00/12] net: ethernet: aquantia: improvements and fixes

From: Pavel Belous Date: Mon, 20 Feb 2017 14:41:42 +0300 > From: Pavel Belous > > The following patchset contains improvements and fixes for aQuantia > AQtion ethernet driver from net-next tree. > > Most fixes are based on the comments

Re: [PATCH repost] ptr_ring: fix race conditions when resizing

From: "Michael S. Tsirkin" Date: Mon, 20 Feb 2017 07:05:35 +0200 > On Sun, Feb 19, 2017 at 12:52:48AM -0500, David Miller wrote: >> From: "Michael S. Tsirkin" >> Date: Sun, 19 Feb 2017 07:17:17 +0200 >> >> > Dave, could you merge this before 4.10? If not - I

Re: [PATCH net-next v2] net: mpls: Add support for netconf

From: David Ahern Date: Mon, 20 Feb 2017 08:03:30 -0800 > Add netconf support to MPLS. Allows userpsace to learn and be notified > of changes to 'input' enable setting per interface. > > Acked-by: Nicolas Dichtel > Signed-off-by: David Ahern

Re: [PATCH] net: qlogic: qlge: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 19 Feb 2017 23:21:41 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: qlogic: qlcnic: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 19 Feb 2017 23:06:01 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH net-next v2 0/7] nfp: expose more firmware and hw debug info

From: Jakub Kicinski Date: Sun, 19 Feb 2017 11:58:07 -0800 > This series is mostly a result of flash firmware team requesting > access to some of the information and data necessary for debugging > firmware problems. Patch 1 adds a missing error message. Patch 2

Re: [PATCH net-next v3 1/8] gtp: add documentation

Hi Andreas, this is not really about the documentation, but it still makes sense to discuss here as the issue is best described: On Mon, Feb 13, 2017 at 04:36:17PM +0100, Andreas Schultz wrote: > +Local GTP-U entity and tunnel identification > + > + >

Re: pull request: bluetooth-next 2017-02-19

From: Johan Hedberg Date: Sun, 19 Feb 2017 07:39:56 -0800 > Here's a set of Bluetooth patches for the 4.11 kernel: > > - New USB IDs to the btusb driver > - Race fix in btmrvl driver > - Added out-of-band wakeup support to the btusb driver > - NULL dereference fix

Re: [PATCHv3 net-next 00/12] net: mvpp2: misc improvements and preparation patches

From: Thomas Petazzoni Date: Mon, 20 Feb 2017 16:47:41 +0100 > Hello, > > On Mon, 20 Feb 2017 09:53:57 -0500 (EST), David Miller wrote: > >> > This series has been on the list for a while, and has received review >> > and a Acked-by. Would it be possible to

Re: [PATCH net-next v2] net: mpls: Add support for netconf

On 20/02/17 16:03, David Ahern wrote: Add netconf support to MPLS. Allows userpsace to learn and be notified of changes to 'input' enable setting per interface. Acked-by: Robert Shearman Acked-by: Nicolas Dichtel Signed-off-by: David Ahern

[PATCH] dpaa_eth: implement ioctl() for PHY-related ops

This commit adds the ndo_do_ioctl() callback which allows the userspace to access PHY registers, for example. This will make mii-diag and similar tools work. Signed-off-by: Michael Walle --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 8 1 file changed, 8

[PATCH net-next v2] net: mpls: Add support for netconf

Add netconf support to MPLS. Allows userpsace to learn and be notified of changes to 'input' enable setting per interface. Acked-by: Nicolas Dichtel Signed-off-by: David Ahern --- v2 - s/NETCONFA_MPLS_INPUT_ENABLED/NETCONFA_INPUT/g Nicolas:

Re: [PATCH net-next] bpf: return errno -ENOMEM when exceeding RLIMIT_MEMLOCK

On 02/20/2017 04:35 PM, Jesper Dangaard Brouer wrote: It is confusing users of samples/bpf that exceeding the resource limits for RLIMIT_MEMLOCK result in an "Operation not permitted" message. This is due to bpf limits check return -EPERM. Instead return -ENOMEM, like most other users of this

Re: [PATCHv3 net-next 00/12] net: mvpp2: misc improvements and preparation patches

Hello, On Mon, 20 Feb 2017 09:53:57 -0500 (EST), David Miller wrote: > > This series has been on the list for a while, and has received review > > and a Acked-by. Would it be possible to merge it? > > You need to repost the series if it isn't in patchwork in state > "Under Review". Is

Re: [PATCH net-next] net: mpls: Add support for netconf

On 20/02/17 14:53, David Ahern wrote: On 2/20/17 3:01 AM, Robert Shearman wrote: On 18/02/17 01:36, David Ahern wrote: Add netconf support to MPLS. Allows userpsace to learn and be notified of changes to 'input' enable setting per interface. Signed-off-by: David Ahern

Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header

From: Sowmini Varadhan Date: Mon, 20 Feb 2017 10:37:22 -0500 > On (02/20/17 10:19), David Miller wrote: >> >> The correct fix it to use "__u8", "__u64", etc. > > So the rest of rds.h uses uint8_t, uint32_t etc > Perhaps (I'm not sure of the origins) this was

  1   2   >