> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Philippe Reynes
> Sent: Saturday, January 21, 2017 7:06 AM
> To: Kirsher, Jeffrey T ; da...@davemloft.net
> Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux-
>
On Fri, Feb 24, 2017 at 6:03 PM, Alexei Starovoitov
wrote:
> On Wed, Feb 22, 2017 at 11:38:49AM -0500, Willem de Bruijn wrote:
>>
>> * Limitations / Known Issues
>>
>> - PF_INET6 is not yet supported.
>
> we struggled so far to make it work in our setups which are
On Fri, 24 Feb 2017 18:28:54 +0100 (CET)
Jiri Kosina wrote:
> From: Jiri Kosina
>
> Rebuilding libnetlink doesn't trigger rebuild of tc, which is wrong
> (especially so for builds where libnetlink.a gets statically linked into
> tc). Fix that by introducing
On Wed, Feb 22, 2017 at 11:38:49AM -0500, Willem de Bruijn wrote:
>
> * Limitations / Known Issues
>
> - PF_INET6 is not yet supported.
we struggled so far to make it work in our setups which are ipv6 only.
Looking at patches it seems the code should just work.
What particularly is missing ?
Hi Jouni,
[auto build test ERROR on net-next/master]
[also build test ERROR on next-20170224]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jouni-Malinen/bridge-Add-support-for-IEEE-802-11
nla_memdup_cookie was overwriting err value, declared at function
scope and earlier initialized with result of ->init(). At success
nla_memdup_cookie() returns 0, and thus module refcnt decremented,
although the action was installed.
$ sudo tc actions add action pass index 1 cookie 1234
$ sudo tc
[ 244.251557] ===
[ 244.263321] [ ERR: suspicious RCU usage. ]
[ 244.274982] 4.10.0-think+ #7 Not tainted
[ 244.286511] ---
[ 244.298008] ./include/linux/rhashtable.h:602 suspicious
rcu_dereference_check() usage!
[ 244.309665]
Cong Wang writes:
> On Fri, Feb 24, 2017 at 8:00 AM, Roman Mashak wrote:
>> When tc actions are loaded as a module and no actions have been installed,
>> flushing them would result in actions removed from the memory, but modules
>> reference count
Calls made through the in-kernel interface can end up getting stuck because
of a missed variable update in a loop in rxrpc_recvmsg_data(). The problem
is like this:
(1) A new packet comes in and doesn't cause a notification to be given to
the client as there's still another packet in the
On Fri, Feb 24, 2017 at 2:30 AM, Geert Uytterhoeven
wrote:
> With gcc-4.1.2 and -Os:
>
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function
> ‘xgene_enet_start_xmit’:
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c:297: warning:
> ‘mss_index’ may be
The concept is fine.
Please add some comments to the code about what is happening and why.
The proposed patch is too sparse and has no comments.
> + skb = alloc_skb(hlen + sizeof(struct ipv6hdr) + sizeof(*msg) +
> + ndisc_opt_addr_space(dev,
> +
Hi!
VXLAN and GENEVE need to take RCU lock explicitly because TX path
only has the _bh() flavour of RCU locked. Making the reconfiguration
path wait for both normal and _bh() RCU would be bigger hassle so
just acquire the lock, as suggested by Pravin:
There is no guarantees that callers of the TX path will hold
the RCU lock. Grab it explicitly.
Fixes: c6fcc4fc5f8b ("vxlan: avoid using stale vxlan socket.")
Signed-off-by: Jakub Kicinski
---
drivers/net/vxlan.c | 8 ++--
1 file changed, 6 insertions(+), 2
There is no guarantees that callers of the TX path will hold
the RCU lock. Grab it explicitly.
Fixes: fceb9c3e3825 ("geneve: avoid using stale geneve socket.")
Signed-off-by: Jakub Kicinski
---
drivers/net/geneve.c | 2 ++
1 file changed, 2 insertions(+)
diff
On Fri, 24 Feb 2017 11:30:05 -0800, Cong Wang wrote:
> On Thu, Feb 23, 2017 at 12:20 AM, Jakub Kicinski wrote:
> >
> > Ugh. Looks like this may not work even if it makes the splat go away.
> > synchronize_net() doesn't seem to wait for the _bh() flavor of RCU, so
> > we need to
On Thu, Feb 23, 2017 at 12:20 AM, Jakub Kicinski wrote:
>
> Ugh. Looks like this may not work even if it makes the splat go away.
> synchronize_net() doesn't seem to wait for the _bh() flavor of RCU, so
> we need to add syncronize_rcu_bh() call before freeing the socket or do
> a
From: Geert Uytterhoeven
Date: Fri, 24 Feb 2017 11:30:03 +0100
> With gcc-4.1.2 and -Os:
>
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function
> ‘xgene_enet_start_xmit’:
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c:297: warning:
> ‘mss_index’
From: Santosh Shilimkar
Date: Fri, 24 Feb 2017 08:49:19 -0800
> On 2/24/2017 1:28 AM, Zhu Yanjun wrote:
>> When the function register_netdevice_notifier fails, the memory
>> allocated by kmem_cache_create should be freed by the function
>> kmem_cache_destroy.
>>
>>
On 2/24/17 11:12 AM, David Miller wrote:
From: Santosh Shilimkar
Date: Fri, 24 Feb 2017 08:49:19 -0800
On 2/24/2017 1:28 AM, Zhu Yanjun wrote:
When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the
From: Zhu Yanjun
Date: Fri, 24 Feb 2017 04:28:01 -0500
> When the function register_netdevice_notifier fails, the memory
> allocated by kmem_cache_create should be freed by the function
> kmem_cache_destroy.
>
> Cc: Joe Jin
> Cc: Junxiao Bi
From: Brian Russell
Date: Fri, 24 Feb 2017 17:47:11 +
> When using IPv6 transport and a default dst, a pointer to the configured
> source address is passed into the route lookup. If no source address is
> configured, then the value is overwritten.
>
> IPv6 route lookup
From: Jiri Kosina
Rebuilding libnetlink doesn't trigger rebuild of tc, which is wrong
(especially so for builds where libnetlink.a gets statically linked into
tc). Fix that by introducing an explicit dependency.
Signed-off-by: Jiri Kosina
---
tc/Makefile |
This is an IPv6 extension of commit 958501163ddd ("bridge: Add support
for IEEE 802.11 Proxy ARP"). The IEEE 802.11 Proxy ARP feature is
defined in IEEE Std 802.11-2012, 10.23.13. It allows the AP devices to
keep track of the hardware-address-to-IP-address mapping of the mobile
devices within the
On Fri, 24 Feb 2017 11:13:12 +0100
Petr Vorel wrote:
> COLORFGBG environment variable is used to detect dark background.
>
> Idea and a bit of code is borrowed from Vim, thanks.
>
> Signed-off-by: Petr Vorel
> ---
> Colors are nice, but the ones chosen aren't
On Fri, Feb 24, 2017 at 5:29 AM, Paolo Abeni wrote:
> Currently the sock queue's spin locks get their lockdep
> classes by the default init_spin_lock() initializer:
> all socket families get - usually, see below - a single
> class for rx, another specific class for tx, etc.
>
When using IPv6 transport and a default dst, a pointer to the configured
source address is passed into the route lookup. If no source address is
configured, then the value is overwritten.
IPv6 route lookup ignores egress ifindex match if the source address is set,
so if egress ifindex match is
This patch adds a function to clean up duplicate config info
on Ubuntu.
Signed-off-by: Haiyang Zhang
---
tools/hv/bondvf.sh | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/tools/hv/bondvf.sh b/tools/hv/bondvf.sh
index
On Fri, Feb 24, 2017 at 8:00 AM, Roman Mashak wrote:
> When tc actions are loaded as a module and no actions have been installed,
> flushing them would result in actions removed from the memory, but modules
> reference count not being decremented, so that the modules would not
On Fri, 2017-02-24 at 14:29 +0100, Paolo Abeni wrote:
> Currently the sock queue's spin locks get their lockdep
> classes by the default init_spin_lock() initializer:
> all socket families get - usually, see below - a single
> class for rx, another specific class for tx, etc.
> This can lead to
On 02/24/2017 04:28 AM, Zhu Yanjun wrote:
When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the function
kmem_cache_destroy.
Cc: Joe Jin
Cc: Junxiao Bi
Signed-off-by: Zhu Yanjun
On Thu, Feb 23, 2017 at 11:59 PM, Raju Lakkaraju
wrote:
> From: Raju Lakkaraju
>
> Fix the LED mode DT parameters combine to a single property
> and change the vendor prefix i.e. mscc.
>
> Signed-off-by: Raju Lakkaraju
On Thu, Feb 23, 2017 at 11:50:28AM -0800, stephen hemminger wrote:
> Some use cases create Linux networking devices which are not intended for use
> by normal networking. This is an enhancement to ip command to hide network
> devices starting with period (like files in normal directory).
On Fri, 24 Feb 2017 11:22:13 -0500 (EST)
David Miller wrote:
> From: Johannes Berg
> Date: Fri, 24 Feb 2017 17:11:42 +0100
>
> >
> >> > Chosen colors are questionable. Best solution would be also allow
> >> user to
> >> > redefine colors,
On 2/24/2017 1:28 AM, Zhu Yanjun wrote:
When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the function
kmem_cache_destroy.
Cc: Joe Jin
Cc: Junxiao Bi
Signed-off-by: Zhu Yanjun
Hi all,
[intentionally breaking the thread here]
On Thu, Feb 23, 2017 at 05:46:57PM +0100, Harald Welte wrote:
> I'll try to cook up some instructions extending
> https://osmocom.org/projects/openggsn/wiki/OpenGGSN to cover also
> sgsnemu for a basic use case of establishing one single tunnel.
From: David Forster
Date: Fri, 24 Feb 2017 14:20:32 +
> Align vti6 with vti by returning GRE_KEY flag. This enables iproute2
> to display tunnel keys on "ip -6 tunnel show"
>
> Signed-off-by: David Forster
Applied, thanks.
From: Johannes Berg
Date: Fri, 24 Feb 2017 17:11:42 +0100
>
>> > Chosen colors are questionable. Best solution would be also allow
>> user to
>> > redefine colors, like ls does with LS_COLORS or grep with
>> GREP_COLORS. But that
>> > is maybe overkill.
>>
>> I think
From: Matthias Schiffer
Date: Thu, 23 Feb 2017 17:19:41 +0100
> The incorrect check caused an off-by-one error: the maximum VID 0xff
> was unusable.
>
> Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
> Signed-off-by: Matthias Schiffer
From: David Howells
Date: Fri, 24 Feb 2017 12:33:09 +
> From: Marc Dionne
>
> In the rxrpc_read() function, which allows a user to read the contents of a
> key, we miscalculate the expected length of an encoded rxkad token by not
> taking into
From: Eric Dumazet
Date: Thu, 23 Feb 2017 15:22:43 -0800
> From: Eric Dumazet
>
> The cited commit makes a great job of finding optimal shift/multiplier
> values assuming a 10 seconds wrap around, but forgot to change the
> overflow_period
From: Florian Fainelli
Date: Thu, 23 Feb 2017 14:22:19 -0800
> Dan's static checker caught a potential code path in phy_state_machine() where
> we were not checking phydev->drv which is in phy_aneg_done().
>
> Reported-by: Dan Carpenter
> Fixes:
From: Corentin Labbe
Date: Thu, 23 Feb 2017 14:12:25 +0100
> The stmmac driver have two methods for registers dumps: via ethtool and
> at init (if NETIF_MSG_HW is enabled).
>
> It is better to keep only one method, ethtool, since the other was ugly.
>
> This patch
From: Jon Maloy
Date: Thu, 23 Feb 2017 11:10:31 -0500
> In the function tipc_rcv() we initialize a couple of stack variables
> from the message header before that same header has been validated.
> In rare cases when the arriving header is non-linar, the validation
>
From: kbuild test robot
Date: Thu, 23 Feb 2017 20:47:01 +0800
> net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like
> kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not
> needed. Maybe consider reorganizing relevant code to avoid
> > Chosen colors are questionable. Best solution would be also allow
> user to
> > redefine colors, like ls does with LS_COLORS or grep with
> GREP_COLORS. But that
> > is maybe overkill.
>
> I think you may have posted this to the wrong mailing list.
Actually, it seems to just be missing the
From: Marcelo Ricardo Leitner
Date: Thu, 23 Feb 2017 09:31:18 -0300
> commit 2dcab5984841 ("sctp: avoid BUG_ON on sctp_wait_for_sndbuf")
> attempted to avoid a BUG_ON call when the association being used for a
> sendmsg() is blocked waiting for more sndbuf and another
When tc actions are loaded as a module and no actions have been installed,
flushing them would result in actions removed from the memory, but modules
reference count not being decremented, so that the modules would not be
unloaded.
Following is example with GACT action:
% sudo modprobe act_gact
On 2/23/17 8:12 PM, David Miller wrote:
> This really need to be a fundamental facility, so that it transparently
> works for NetworkManager, router daemons, everything. Not just iproute2
> and "ls".
I'll rebase my patch and send out as RFC.
On Thu, Feb 23, 2017 at 05:31:14PM -0800, Stephen Hemminger wrote:
> On Thu, 23 Feb 2017 18:07:07 -0700
> David Ahern wrote:
>
> > On 2/23/17 5:30 PM, Stephen Hemminger wrote:
> > > On Thu, 23 Feb 2017 16:39:52 -0700
> > > David Ahern wrote:
>
From: Petr Vorel
Date: Fri, 24 Feb 2017 11:13:12 +0100
> COLORFGBG environment variable is used to detect dark background.
>
> Idea and a bit of code is borrowed from Vim, thanks.
>
> Signed-off-by: Petr Vorel
> ---
> Colors are nice, but the ones chosen aren't
Align vti6 with vti by returning GRE_KEY flag. This enables iproute2
to display tunnel keys on "ip -6 tunnel show"
Signed-off-by: David Forster
---
net/ipv6/ip6_vti.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c
index
According to C9-147, MSN should only be incremented when the last packet of
a multi packet request has been received.
"Logically, the requester associates a sequential Send Sequence Number
(SSN) with each WQE posted to the send queue. The SSN bears a one-
to-one relationship to the MSN returned
Hello.
On 02/24/2017 01:14 PM, Luiz Augusto von Dentz wrote:
From: Luiz Augusto von Dentz
Accourding to RFC 7668 U/L bit shall not be used:
https://wiki.tools.ietf.org/html/rfc7668#section-3.2.2 [Page 10]:
In the figure, letter 'b' represents a bit from the
Currently the sock queue's spin locks get their lockdep
classes by the default init_spin_lock() initializer:
all socket families get - usually, see below - a single
class for rx, another specific class for tx, etc.
This can lead to false positive lockdep splat, as
reported by Andrey.
Moreover
From: Marc Dionne
In the rxrpc_read() function, which allows a user to read the contents of a
key, we miscalculate the expected length of an encoded rxkad token by not
taking into account the key length. However, the data is stored later
anyway with an ENCODE_DATA()
Hi Kalle,
On 02/24/2017 07:01 PM, Kalle Valo wrote:
Jeffy Chen writes:
Currrently we are disabling this wake irq after receiving it. If this
happens before we finish suspend and the pm event check is disabled,
the system will continue suspending, and this irq would
From: Luiz Augusto von Dentz
This allow technologies such as Bluetooth to use its native lladdr which
is eui48 instead of eui64 which was expected by functions like
lowpan_header_decompress and lowpan_header_compress.
Signed-off-by: Luiz Augusto von Dentz
From: Patrik Flykt
Set MAC address length according to the 6LoWPAN link layer in use.
Bluetooth Low Energy uses 48 bit addressing while IEEE802.15.4 uses
64 bits.
Signed-off-by: Patrik Flykt
Reviewed-by: Stefan Schmidt
From: Patrik Flykt
Set BTLE MAC addresses that are 6 bytes long and not 8 bytes
that are used in other places with 6lowpan.
Signed-off-by: Patrik Flykt
Signed-off-by: Luiz Augusto von Dentz
Reviewed-by:
From: Luiz Augusto von Dentz
These patches fixes lladdr length to be 6 bytes long and not 8 which cause
neighbor advertisement to be sent with wrong lladdr including FF:FE filler
bytes for eui64.
Note: This does not fix some of the existing crashes which I hope to
From: Alexander Aring
This patch adds support for 48 bit 6LoWPAN address length
autoconfiguration which is the case for BTLE 6LoWPAN.
Signed-off-by: Alexander Aring
Signed-off-by: Luiz Augusto von Dentz
Reviewed-by: Stefan
From: Alexander Aring
The skb->pkt_type need to be set by L2, but on 6LoWPAN there exists L2
e.g. BTLE which doesn't has multicast addressing. If it's a multicast or
not is detected by IPHC headers multicast bit. The IPv6 layer will
evaluate this pkt_type, so we force set
From: Luiz Augusto von Dentz
Accourding to RFC 7668 U/L bit shall not be used:
https://wiki.tools.ietf.org/html/rfc7668#section-3.2.2 [Page 10]:
In the figure, letter 'b' represents a bit from the
Bluetooth device address, copied as is without any changes on any
Hi David, Marcin,
On Tue, 21 Feb 2017 11:16:02 -0500 David Miller wrote:
> From: Jisheng Zhang
> Date: Tue, 21 Feb 2017 12:37:40 +0800
>
> > Thanks for your review.
> >
> > The measurement is simple: record how much time we spent in mvneta_rx_swbm()
> > for receiving 1GB
Dear friend,
My name is Mr Micheal Rita, I am the Bill and Exchange (assistant)
Manager of Bank of Africa Ouagadougou, Burkina Faso. In my department
I discovered an abandoned sum of teen million five hundred thousand United
State of American dollars (10.5MILLION USA DOLLARS) in an account that
Jeffy Chen writes:
> Currrently we are disabling this wake irq after receiving it. If this
> happens before we finish suspend and the pm event check is disabled,
> the system will continue suspending, and this irq would not work again.
>
> We may need to abort system
From: Raju Lakkaraju
Fix the LED mode DT parameters combine to a single property
and change the vendor prefix i.e. mscc.
Signed-off-by: Raju Lakkaraju
---
Change set:
v0: Fix the LED mode DT parameters combine to a single property
v1:
With gcc-4.1.2 and -Os:
drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function
‘xgene_enet_start_xmit’:
drivers/net/ethernet/apm/xgene/xgene_enet_main.c:297: warning: ‘mss_index’
may be used uninitialized in this function
Using a separate variable to track success may confuse
This allows to enable and run the accompanying test (test_parman)
without dependencies on other users of parman.
Signed-off-by: Geert Uytterhoeven
---
lib/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig b/lib/Kconfig
index
From: Xin Long
> Sent: 24 February 2017 06:44
...
> > IIRC sctp_packet_can_append_data() is called for the first queued
> > data chunk in order to decide whether to generate a message that
> > consists only of data chunks.
> > If it returns SCTP_XMIT_OK then a message is built collecting the
> >
COLORFGBG environment variable is used to detect dark background.
Idea and a bit of code is borrowed from Vim, thanks.
Signed-off-by: Petr Vorel
---
Colors are nice, but the ones chosen aren't suitable for dark background.
COLORFGBG environment variable is used in some libraries
Hi Raju,
[auto build test ERROR on net/master]
url:
https://github.com/0day-ci/linux/commits/Raju-Lakkaraju/net-phy-Fix-LED-mode-in-DT-single-property/20170224-171412
config: i386-randconfig-x011-201708 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce
On Wed, 22 Feb 2017 18:06:58 -0800
Eric Dumazet wrote:
> On Wed, 2017-02-22 at 17:08 -0800, Alexander Duyck wrote:
>
> >
> > Right but you were talking about using both halves one after the
> > other. If that occurs you have nothing left that you can reuse. That
> >
When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the function
kmem_cache_destroy.
Cc: Joe Jin
Cc: Junxiao Bi
Signed-off-by: Zhu Yanjun
---
net/rds/tcp.c | 7
From: Raju Lakkaraju
Fix the LED mode DT parameters combine to a single property
and change the vendor prefix i.e. mscc.
Signed-off-by: Raju Lakkaraju
---
Change set:
v0: Fix the LED mode DT parameters combine to a single property
v1:
Fri, Feb 24, 2017 at 08:54:04AM CET, ge...@linux-m68k.org wrote:
>Hi Jiri,
>
>On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko wrote:
>> From: Jiri Pirko
>>
>> As reported by Geert, remove the string so the user does not see this
>> config option. The option is
Hi Jiri,
On Fri, Feb 24, 2017 at 9:25 AM, Jiri Pirko wrote:
> Fri, Feb 24, 2017 at 08:54:04AM CET, ge...@linux-m68k.org wrote:
>>On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko wrote:
>>> From: Jiri Pirko
>>>
>>> As reported by Geert, remove
Commit 5e1859fbcc3c ("ipv4: ipmr: various fixes and cleanups") fixed
the issue for ipv4 ipmr:
ip_mroute_setsockopt() & ip_mroute_getsockopt() should not
access/set raw_sk(sk)->ipmr_table before making sure the socket
is a raw socket, and protocol is IGMP
The same fix should be done for
78 matches
Mail list logo