[PATCH 1/1] rds: ib: add error handle

In the function rds_ib_setup_qp, the error handle is missing. When some error occurs, it is possible that memory leak occurs. As such, error handle is added. Cc: Joe Jin Reviewed-by: Junxiao Bi Reviewed-by: Guanglei Li

Re: [PATCH] udp: avoid ufo handling on IP payload compression packets

On Mon, Mar 06, 2017 at 07:16:57AM +0100, Steffen Klassert wrote: > > > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > > index b67719f..18383ef 100644 > > --- a/net/ipv4/ip_output.c > > +++ b/net/ipv4/ip_output.c > > @@ -960,7 +960,10 @@ static int __ip_append_data(struct sock *sk, > >

Re: netlink: GPF in netlink_unicast

On 2017-03-06 10:10, Cong Wang wrote: > On Mon, Mar 6, 2017 at 2:54 AM, Dmitry Vyukov wrote: > > Hello, > > > > I've got the following crash while running syzkaller fuzzer on > > net-next/8d70eeb84ab277377c017af6a21d0a337025dede: > > > > kasan: GPF could be caused by NULL-ptr

Re: [PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

On 3/6/2017 3:53 PM, Florian Fainelli wrote: On 03/06/2017 03:15 PM, Shannon Nelson wrote: When an ldom VM is bound, the network vswitch infrastructure is set up for it, but was being forced 'UP' by the userland switch configuration script. When 'UP' but not actually connected to a running

Re: [PATCH net 0/3] rds: tcp: fix various rds-tcp issues during netns create/delete sequences

On 3/4/17 8:57 AM, Sowmini Varadhan wrote: Dmitry Vyukov reported some syszkaller panics during netns deletion. While I have not been able to reproduce those exact panics, my attempts to do so uncovered a few other problems, which are fixed patch 2 and patch 3 of this patch series. In addition,

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On 3/6/17 11:51 AM, Dmitry Vyukov wrote: > We hit it several thousand times, but we get only several dozens of > crashes per day on ~80 VMs. So if you try to reproduce it on a single > machine it can take days for a single crash. > If you are ready to go that route, here are some instructions on >

[PATCH net-next 0/5] sunvnet: better connection management

These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Shannon Nelson (5): ldmvsw: better use of link up and down on ldom vswitch

[PATCH v3 net-next] liquidio: improve UDP TX performance

From: VSR Burru Improve UDP TX performance by: * reducing the ring size from 2K to 512 * replacing the numerous streaming DMA allocations for info buffers and gather lists with one large consistent DMA allocation per ring BQL is not effective here. We reduced

Re: [PATCH] net: smsc: epic100: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 27 Feb 2017 23:43:14 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH net-next] tools: hv: Add clean up function for Ubuntu config

From: Haiyang Zhang Date: Fri, 24 Feb 2017 17:30:32 + > This patch adds a function to clean up duplicate config info > on Ubuntu. > > Signed-off-by: Haiyang Zhang Applied, thanks.

Re: [PATCH net 0/5] NAPI support for Hyper-V

On Mon, 06 Mar 2017 17:13:33 -0800 (PST) David Miller wrote: > From: Stephen Hemminger > Date: Mon, 27 Feb 2017 10:26:46 -0800 > > > These patches enable NAPI, GRO and napi_alloc_skb for Hyper-V netvsc > > driver. > > Series applied to

Re: [PATCH net-next v3 0/3] net: ethernet: bgmac: PM support and clean-ups

From: Jon Mason Date: Tue, 28 Feb 2017 13:50:58 -0500 > Changes in v3: > * Corrected a bug Florian found and added his Reviewed-by > > Changes in v2: > * Reworked the PM patch with Florian's suggestions > > > Add code to support Power Management (only tested on NS2),

Re: [PATCH] net: axienet: use eth_hw_addr_random()

From: Tobias Klauser Date: Tue, 28 Feb 2017 12:21:12 +0100 > Use eth_hw_addr_random() to set a random MAC address in order to make > sure ndev->addr_assign_type will be properly set to NET_ADDR_RANDOM. > > Signed-off-by: Tobias Klauser Applied to

Re: [PATCH] net: silan: sc92031: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 27 Feb 2017 22:50:25 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: smsc: smc91c92_cs: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Fri, 3 Mar 2017 23:39:35 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: sis: sis190: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 27 Feb 2017 23:06:41 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: sis: sis900: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 27 Feb 2017 23:17:37 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH net 0/5] NAPI support for Hyper-V

From: Stephen Hemminger Date: Mon, 27 Feb 2017 10:26:46 -0800 > These patches enable NAPI, GRO and napi_alloc_skb for Hyper-V netvsc > driver. Series applied to net-next.

Re: [PATCH net]ipv6: Provide ipv6 version of "disable_policy" sysctl

From: David Forster Date: Thu, 23 Feb 2017 16:27:18 + > This provides equivalent functionality to the existing ipv4 > "disable_policy" systcl. ie. Allows IPsec processing to be skipped > on terminating packets on a per-interface basis. > > Signed-off-by: David Forster

RE: [PATCH v2] can: m_can: enable transmission of FD frame on latest version

HI Oliver, > -Original Message- > From: Oliver Hartkopp [mailto:socket...@hartkopp.net] > Sent: 2017年3月7日 5:26 > To: Marc Kleine-Budde ; Wenyou Yang - A41535 > ; Wolfgang Grandegger > Cc: Alexandre Belloni

Re: [PATCH] net: realtek: r8169: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Thu, 23 Feb 2017 22:34:43 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: sgi: ioc3-eth: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 26 Feb 2017 22:48:59 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: realtek: 8139cp: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Wed, 22 Feb 2017 08:50:27 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: rocker: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 26 Feb 2017 19:00:29 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: realtek: 8139too: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Thu, 23 Feb 2017 00:14:08 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

On Mon, Mar 06, 2017 at 04:27:11PM +0100, Johannes Thumshirn wrote: > On 03/06/2017 03:21 PM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter

Re: [PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

On 03/06/2017 03:15 PM, Shannon Nelson wrote: > When an ldom VM is bound, the network vswitch infrastructure is set up for > it, but was being forced 'UP' by the userland switch configuration script. > When 'UP' but not actually connected to a running VM, the ipv6 neighbor > probes fail (not a

Re: net: BUG in unix_notinflight

On Mon, Mar 6, 2017 at 2:40 AM, Dmitry Vyukov wrote: > Now with a nice single-threaded C reproducer! Excellent... > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #define _GNU_SOURCE > #include > #include > #include > #include > #include >

[PATCH] net: ipv6: Remove redundant RTA_OIF in multipath routes

Dinesh reported that RTA_MULTIPATH nexthops are 8-bytes larger with IPv6 than IPv4. The recent refactoring for multipath support in netlink messages does discriminate between non-multipath which needs the OIF and multipath which adds a rtnexthop struct for each hop making the RTA_OIF attribute

[PATCH] net: tundra: tsi108: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/tundra/tsi108_eth.c | 14

[PATCH net-next 4/5] sunvnet: count multicast packets

Make sure multicast packets get counted in the device. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c

[PATCH net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes

In this driver, there is a "port" created for the connection to each of the other ldoms; a netdev queue is mapped to each port, and they are collected under a single netdev. The generic netdev statistics show us all the traffic in and out of our network device, but don't show individual

[PATCH net-next 5/5] sunvnet: xoff not needed when removing port link

The sunvnet netdev is connected to the controlling ldom's vswitch for network bridging. However, for higher performance between ldoms, there also is a channel between each client ldom. These connections are represented in the sunvnet driver by a queue for each ldom. The driver uses select_queue

[PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

When an ldom VM is bound, the network vswitch infrastructure is set up for it, but was being forced 'UP' by the userland switch configuration script. When 'UP' but not actually connected to a running VM, the ipv6 neighbor probes fail (not a horrible thing) and start cluttering up the kernel logs.

[PATCH net-next 3/5] sunvnet: track port queues correctly

Track our used and unused queue indices correctly. Otherwise, as ports dropped out and returned, they all eventually ended up with the same queue index. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c | 24

[PATCH v2] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

This logic seems to be duplicated in (at least) three separate files. Move it to one place so code can be re-use. Signed-off-by: Yuval Shaia --- v0 -> v1: * Add missing #include * Rename to genaddrconf_ifid_eui48 v1 -> v2: * Reset eui[0] to default

Re: [PATCH net] bpf: disable broken write protection on i386

On 03/06/2017 07:52 PM, David Miller wrote: From: Daniel Borkmann Date: Mon, 06 Mar 2017 19:35:47 +0100 I can do a few more tests with the kernel I have. I'm also totally fine if we drop this patch; it's just rc1, so there's plenty of time till a final release. I would

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

On Mon, Mar 6, 2017 at 9:45 AM, Willem de Bruijn wrote: > On Mon, Mar 6, 2017 at 12:13 PM, chetan loke wrote: Gosh. Can we also replace this BUG() into something less aggressive ? >>> >>> >>> There are currently 5 of these WARN()

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

> Gosh. Can we also replace this BUG() into something less aggressive ? There are currently 5 of these WARN() + BUG() constructs and 1 BUG()-only for the 'default' TPACKET version spread all over af_packet, so probably makes sense to rather make all of them less

Re: [PATCH RFC net-next v2 1/4] skbuff: add stub to help computing crc32c on SCTP packets

On Tue, 2017-02-28 at 14:46 -0800, Alexander Duyck wrote: > On Tue, Feb 28, 2017 at 2:32 AM, Davide Caratti wrote: > > > > sctp_compute_checksum requires crc32c symbol (provided by libcrc32c), so > > it can't be used in net core. Like it has been done previously with other >

Re: [RFC PATCH 1/2] af_packet: direct dma for packet ineterface

On Tue, Jan 31, 2017 at 9:09 PM, John Fastabend wrote: >> If I understand correctly, the difficulty lies in v3 requiring that the >> timer "close" the block when the timer expires. That may not be worth >> implementing, indeed. >> > > Yep that is where I just gave up

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo wrote: > Arend Van Spriel writes: > >> On 2-3-2017 17:38, Arnd Bergmann wrote: >>> With KASAN and a couple of other patches applied, this driver is one >>> of the few remaining ones that actually use

Re: [PATCH v2] can: m_can: enable transmission of FD frame on latest version

@Wenyou Yang: Can you please test the two patches posted here: [PATCH 1/2] can: m_can: handle bitrate setup on IP core >= 3.1.x http://marc.info/?l=linux-can=148883529927720=2 [PATCH 2/2] can: m_can: handle frame transmission on IP core >= 3.1.x http://marc.info/?l=linux-can=148883529927718=2

[PATCH net-next] tg3: Add the ability to conditionally build w/ HWMON

Introduce a Kconfig option: CONFIG_TIGON3_HWMON which allows to build in/out support for thermal sensors reported by Tigon3 NICs. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/Kconfig | 8 +++- drivers/net/ethernet/broadcom/tg3.c | 7 +++ 2

[patch net-next 0/2] mlxsw: cosmetics

From: Jiri Pirko Couple of cosmetic mlxsw patches Ido Schimmel (1): mlxsw: pci: Remove unused bit Jiri Pirko (1): mlxsw: spectrum: Fix helper function and port variable names drivers/net/ethernet/mellanox/mlxsw/cmd.h | 12

[patch net-next 2/2] mlxsw: pci: Remove unused bit

From: Ido Schimmel The overrun ignore bit isn't supported by the device's firmware and was recently removed from the programmer's reference manual (PRM). Remove it from the driver as well. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 1/2] mlxsw: spectrum: Fix helper function and port variable names

From: Jiri Pirko Commit dd82364c3ab9 ("mlxsw: Flip to the new dev walk API") did some small changes in mlxsw code, but it did not respect the naming conventions. So fix this now. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel ---

[patch net] mlxsw: spectrum_flower: Remove bogus warns in mlxsw_sp_flower_destroy

From: Jiri Pirko This warnings may be hit even in case they should not - in case user puts a TC-flower rule which failed to be offloaded. So just remove them. Reported-by: Petr Machata Reported-by: Ido Schimmel Fixes: commit

Re: [PATCH v2] selinux: check for address length in selinux_socket_bind()

On Mon, 2017-03-06 at 19:46 +0100, Alexander Potapenko wrote: > KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of > uninitialized memory in selinux_socket_bind(): > ... > Signed-off-by: Alexander Potapenko > --- > Changes since v1: > - fixed patch

Re: netlink: GPF in netlink_unicast

On Mon, Mar 6, 2017 at 2:54 AM, Dmitry Vyukov wrote: > Hello, > > I've got the following crash while running syzkaller fuzzer on > net-next/8d70eeb84ab277377c017af6a21d0a337025dede: > > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection

Re: [PATCH net-next RFC 2/4] virtio-net: transmit napi

On Mon, Mar 06, 2017 at 10:55:22AM -0800, David Miller wrote: > From: Willem de Bruijn > Date: Mon, 6 Mar 2017 12:50:19 -0500 > > >>> drivers/net/virtio_net.c | 73 > >>> > >>> 1 file changed, 61 insertions(+),

Re: [PATCH v6 6/6] 6lowpan: Fix IID format for Bluetooth

Hi, sorry, I decided now to take a look into the patch... Currently I have no time to do anything... normally. That's why I simple said "everything okay" in irc. On 03/02/2017 02:23 PM, Luiz Augusto von Dentz wrote: > From: Luiz Augusto von Dentz > > According to RFC

[PATCH net-next] net: use proper lockdep annotation in __sk_dst_set()

From: Eric Dumazet __sk_dst_set() must be called while we own the socket. We can get proper lockdep coverage using lockdep_sock_is_held() and rcu_dereference_protected() Signed-off-by: Eric Dumazet --- include/net/sock.h |7 ++- 1 file

Re: [PATCH net-next RFC 0/4] virtio-net tx napi

On Fri, Mar 03, 2017 at 09:39:05AM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Add napi for virtio-net transmit completion processing. Based on > previous patchsets by Jason Wang: > > [RFC V7 PATCH 0/7] enable tx interrupts for virtio-net >

Re: [PATCH net-next RFC 2/4] virtio-net: transmit napi

On Mon, Mar 6, 2017 at 2:33 PM, Michael S. Tsirkin wrote: > On Mon, Mar 06, 2017 at 10:55:22AM -0800, David Miller wrote: >> From: Willem de Bruijn >> Date: Mon, 6 Mar 2017 12:50:19 -0500 >> >> >>> drivers/net/virtio_net.c | 73 >> >>>

Re: [PATCH v2] can: m_can: enable transmission of FD frame on latest version

Hi Marc, On 03/06/2017 11:53 AM, Marc Kleine-Budde wrote: On 03/06/2017 03:21 AM, Wenyou Yang wrote: Enables the transmission of CAN FD frames on M_CAN IP core >= v3.1.x and with the bit rate switching. Tested on M_CAN IP 3.1.0 (CREL = 0x31040730) of SAMA5D2 SoC. Does this patch work still

Re: [PATCH net-next RFC 2/4] virtio-net: transmit napi

From: Willem de Bruijn Date: Mon, 6 Mar 2017 12:50:19 -0500 >>> drivers/net/virtio_net.c | 73 >>> >>> 1 file changed, 61 insertions(+), 12 deletions(-) >>> >>> diff --git a/drivers/net/virtio_net.c

Re: [PATCH net] bpf: disable broken write protection on i386

From: Daniel Borkmann Date: Mon, 06 Mar 2017 19:35:47 +0100 > I can do a few more tests with the kernel I have. I'm also totally > fine if we drop this patch; it's just rc1, so there's plenty of time > till a final release. I would really prefer we get to the bottom of

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On Mon, Mar 6, 2017 at 6:31 PM, David Ahern wrote: > On 3/4/17 1:15 PM, Eric Dumazet wrote: >> On Sat, 2017-03-04 at 19:57 +0100, Dmitry Vyukov wrote: >>> On Fri, Mar 3, 2017 at 8:12 PM, David Ahern >>> wrote: On 3/3/17 6:39 AM, Dmitry

[PATCH v2] selinux: check for address length in selinux_socket_bind()

KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of uninitialized memory in selinux_socket_bind(): == BUG: KMSAN: use of unitialized memory inter: 0 CPU: 3 PID: 1074 Comm: packet2 Tainted: GB

Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

On 03/06/2017 09:21 AM, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > > Signed-off-by:

Re: [PATCH net] bpf: disable broken write protection on i386

On Fri, Mar 3, 2017 at 7:23 PM, Daniel Borkmann wrote: > Since d2852a224050 ("arch: add ARCH_HAS_SET_MEMORY config") and > 9d876e79df6a ("bpf: fix unlocking of jited image when module ronx > not set") that uses the former, Fengguang reported random corruptions > on his i386

Re: [PATCH net] bpf: disable broken write protection on i386

On 03/06/2017 07:11 PM, Kees Cook wrote: On Fri, Mar 3, 2017 at 7:23 PM, Daniel Borkmann wrote: Since d2852a224050 ("arch: add ARCH_HAS_SET_MEMORY config") and 9d876e79df6a ("bpf: fix unlocking of jited image when module ronx not set") that uses the former, Fengguang

Re: [PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump

From: Jiri Kosina Date: Mon, 6 Mar 2017 12:03:38 +0100 (CET) > Ah, right you are, thanks. The complete fix is not super trivial, as it > needs some more surgery to tc_dump_qdisc_root(), tc_dump_tclass_root() and > qdisc_match_from_root() (see 69012ae42 for some details). > >

Re: [PATCH net] dccp: fix use-after-free in dccp_feat_activate_values

On Sun, Mar 5, 2017 at 10:42 PM, Eric Dumazet wrote: > On Sun, 2017-03-05 at 21:38 -0800, Cong Wang wrote: > >> Do you really want to disable BH again here? >> >> dccp_check_req() should be always called on RX path where BH >> is already disabled and BH can't be disabled

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

On Mon, Mar 6, 2017 at 12:13 PM, chetan loke wrote: >>> >>> Gosh. Can we also replace this BUG() into something less aggressive ? >> >> >> There are currently 5 of these WARN() + BUG() constructs and 1 BUG()-only >> for the 'default' TPACKET version spread all over

Re: [PATCH net-next RFC 4/4] virtio-net: clean tx descriptors from rx napi

>> +static void virtnet_poll_cleantx(struct receive_queue *rq) >> +{ >> + struct virtnet_info *vi = rq->vq->vdev->priv; >> + unsigned int index = vq2rxq(rq->vq); >> + struct send_queue *sq = >sq[index]; >> + struct netdev_queue *txq = netdev_get_tx_queue(vi->dev, index); >>

Re: [PATCH net-next RFC 4/4] virtio-net: clean tx descriptors from rx napi

On Mon, Mar 6, 2017 at 12:43 PM, Willem de Bruijn wrote: >>> +static void virtnet_poll_cleantx(struct receive_queue *rq) >>> +{ >>> + struct virtnet_info *vi = rq->vq->vdev->priv; >>> + unsigned int index = vq2rxq(rq->vq); >>> + struct send_queue

Re: [PATCH net-next RFC 2/4] virtio-net: transmit napi

>> drivers/net/virtio_net.c | 73 >> >> 1 file changed, 61 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >> index 8c21e9a4adc7..9a9031640179 100644 >> --- a/drivers/net/virtio_net.c >> +++

[PATCH] vrf: Fix use-after-free in vrf_xmit

KASAN detected a use-after-free: [ 269.467067] BUG: KASAN: use-after-free in vrf_xmit+0x7f1/0x827 [vrf] at addr 8800350a21c0 [ 269.467067] Read of size 4 by task ssh/1879 [ 269.467067] CPU: 1 PID: 1879 Comm: ssh Not tainted 4.10.0+ #249 [ 269.467067] Hardware name: QEMU Standard PC

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

>> >> Gosh. Can we also replace this BUG() into something less aggressive ? > > > There are currently 5 of these WARN() + BUG() constructs and 1 BUG()-only > for the 'default' TPACKET version spread all over af_packet, so probably > makes sense to rather make all of them less aggressive. > > Very

Re: [PATCH net-next RFC 3/4] vhost: interrupt coalescing support

On Mon, Mar 6, 2017 at 4:28 AM, Jason Wang wrote: > > > On 2017年03月03日 22:39, Willem de Bruijn wrote: >> >> +void vhost_signal(struct vhost_dev *dev, struct vhost_virtqueue *vq); >> +static enum hrtimer_restart vhost_coalesce_timer(struct hrtimer *timer) >> +{ >> +

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On 3/4/17 1:15 PM, Eric Dumazet wrote: > On Sat, 2017-03-04 at 19:57 +0100, Dmitry Vyukov wrote: >> On Fri, Mar 3, 2017 at 8:12 PM, David Ahern wrote: >>> On 3/3/17 6:39 AM, Dmitry Vyukov wrote: I am getting heap out-of-bounds reports in

Re: [PATCH] netfilter: Use pr_cont where appropriate

On Tue, Feb 28, 2017 at 02:09:24PM -0800, Joe Perches wrote: > Logging output was changed when simple printks without KERN_CONT > are now emitted on a new line and KERN_CONT is required to continue > lines so use pr_cont. > > Miscellanea: > > o realign arguments > o use print_hex_dump instead of

Re: [PATCH] netfilter: remove redundant check on ret being non-zero

On Tue, Feb 28, 2017 at 11:31:15AM +, Colin King wrote: > From: Colin Ian King > > ret is initialized to zero and if it is set to non-zero in the > xt_entry_foreach loop then we exit via the out_free label. Hence > the check for ret being non-zero is redundant and

Re: [PATCH] bridge: Add support for IEEE 802.11 Proxy ARP for IPv6

On Fri, Feb 24, 2017 at 11:55:37AM -0800, Stephen Hemminger wrote: > The concept is fine. Thanks for taking a look. > Please add some comments to the code about what is happening and why. > The proposed patch is too sparse and has no comments. Sure, will do that for the next version. > > +

Re: [PATCH net-next] net: ipv4: add support for ECMP hash policy choice

On 06/03/17 18:24, David Ahern wrote: > On 3/6/17 7:59 AM, Nikolay Aleksandrov wrote: >> diff --git a/include/net/route.h b/include/net/route.h >> index c0874c87c173..77a5c613a290 100644 >> --- a/include/net/route.h >> +++ b/include/net/route.h >> @@ -113,13 +113,12 @@ struct in_device; >> int

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

Arend Van Spriel writes: > On 2-3-2017 17:38, Arnd Bergmann wrote: >> With KASAN and a couple of other patches applied, this driver is one >> of the few remaining ones that actually use more than 2048 bytes of >> kernel stack: >> >>

Re: [PATCH 10/26] brcmsmac: reindent split functions

Arend Van Spriel writes: > On 2-3-2017 17:38, Arnd Bergmann wrote: >> In the previous commit I left the indentation alone to help reviewing >> the patch, this one now runs the three new functions through 'indent -kr -8' >> with some manual fixups to avoid silliness.

Re: [PATCH 1/4] net: thunderx: Fix IOMMU translation faults

On 06/03/17 12:57, Sunil Kovvuri wrote: >>> >>> We are seeing a 0.75Mpps drop with IP forwarding rate due to that. >>> Hence I have restricted calling DMA interfaces to only when IOMMU is >>> enabled. >> >> What's 0.07Mpps as a percentage of baseline? On a correctly configured >> coherent arm64

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

Hello. On 03/06/2017 05:20 PM, Elena Reshetova wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by:

Re: [4.9.13] use after free in ipv4_mtu

On Mon, 2017-03-06 at 05:45 -0800, Eric Dumazet wrote: > On Mon, 2017-03-06 at 14:33 +0800, Daniel J Blueman wrote: > > I do change the network queueing discipline and related at runtime [1] > > which may be triggering this, though I did think I saw the KASAN > > report only after resuming from

Re: [PATCH net-next] net: ipv4: add support for ECMP hash policy choice

On 3/6/17 7:59 AM, Nikolay Aleksandrov wrote: > diff --git a/include/net/route.h b/include/net/route.h > index c0874c87c173..77a5c613a290 100644 > --- a/include/net/route.h > +++ b/include/net/route.h > @@ -113,13 +113,12 @@ struct in_device; > int ip_rt_init(void); > void rt_cache_flush(struct

Please view the attached file.

Hello.docx Description: MS-Word 2007 document

Re: [patch net-next RFC 1/2] flow_dissecror: Move ARP dissection into a separate function

Tue, Feb 21, 2017 at 07:50:53PM CET, t...@herbertland.com wrote: >On Tue, Feb 21, 2017 at 6:33 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Make the main flow_dissect function a bit smaller and move the ARP >> dissection into a separate function. Along

[patch net-next 3/5] flow_dissector: Fix GRE header error path

From: Jiri Pirko Now, when an unexpected element in the GRE header appears, we break so the l4 ports are processed. But since the ports are processed unconditionally, there will be certainly random values dissected. Fix this by just bailing out in such situations.

[patch net-next 5/5] flow_dissector: Move GRE dissection into a separate function

From: Jiri Pirko Make the main flow_dissect function a bit smaller and move the GRE dissection into a separate function. Signed-off-by: Jiri Pirko --- net/core/flow_dissector.c | 244 +- 1 file changed, 134

[patch net-next 2/5] flow_dissector: Move MPLS dissection into a separate function

From: Jiri Pirko Make the main flow_dissect function a bit smaller and move the MPLS dissection into a separate function. Along with that, do the MPLS header processing only in case the flow dissection user requires it. Signed-off-by: Jiri Pirko ---

[patch net-next 0/5] make flow dissector great again

From: Jiri Pirko This patchset follows-up the discussion about future extensions of flow dissector and tries to address the mentioned concerns. Some parts are cut out into sub-functions. Also, the processing of the code (ARP, MPLS) is made dependent on user actually requiring

[patch net-next 4/5] flow_dissector: rename "proto again" goto label

From: Jiri Pirko Align with "ip_proto_again" label used in the same function and rename vague "again" to "proto_again". Signed-off-by: Jiri Pirko --- net/core/flow_dissector.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[patch net-next 1/5] flow_dissector: Move ARP dissection into a separate function

From: Jiri Pirko Make the main flow_dissect function a bit smaller and move the ARP dissection into a separate function. Along with that, do the ARP header processing only in case the flow dissection user requires it. Signed-off-by: Jiri Pirko ---

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

On 03/06/2017 03:21 PM, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. The subject is

[PATCH 03/29] drivers, char: convert vma_data.refcnt from atomic_t to refcount_t

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

[RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

Lockdep issues a circular dependency warning when AFS issues an operation through AF_RXRPC from a context in which the VFS/VM holds the mmap_sem. The theory lockdep comes up with is as follows: (1) If the pagefault handler decides it needs to read pages from AFS, it calls AFS with mmap_sem

[PATCH net-next] net: ipv4: add support for ECMP hash policy choice

This patch adds support for ECMP hash policy choice via a new sysctl called fib_multipath_hash_policy and also adds support for L4 hashes. The current values for fib_multipath_hash_policy are: 0 - layer 3 1 - layer 4 (new default) If there's an skb hash already set and it matches the chosen

Re: [PATCH] 4.9.13 brcmfmac: fix use-after-free on resume

On 6 March 2017 at 21:00, Arend Van Spriel wrote: > + linux-wireless > > On 6-3-2017 8:14, Daniel J Blueman wrote: >> KASAN reported 'struct wireless_dev wdev' was read after being freed. >> Fix by freeing after the access. > > I would rather like to see the KASAN

Re: [PATCH v3 17/20] usb: gadget: pch_udc: Replace PCI pool old API

Peter Senna Tschudin writes: > On Sun, Feb 26, 2017 at 08:24:22PM +0100, Romain Perier wrote: >> The PCI pool API is deprecated. This commits replaces the PCI pool old >> API by the appropriated function with the DMA pool API. >> > Reviewed-by: Peter Senna Tschudin

[PATCH net 3/7 v2] bnx2x: fix possible overrun of VFPF multicast addresses array

It is too late to check for the limit of the number of VF multicast addresses after they have already been copied to the req->multicast[] array, possibly overflowing it. Do the check before copying. Checking early also avoids having to (and forgetting to) unlock vf2pf_mutex. While we're

[PATCH 18/29] drivers, s390: convert urdev.ref_count from atomic_t to refcount_t

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

[PATCH 01/29] drivers, block: convert xen_blkif.refcnt from atomic_t to refcount_t

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

  1   2   >