Re: regression (4.10) - interface remove uevents not generated

On Sat, Mar 11, 2017 at 11:24:34PM +0200, Mantas Mikulėnas wrote: > On 2017-03-11 21:50, Andrei Vagin wrote: > > Hi Mantas, > > > > Thank you for the report. Could you try out the attached patch? > > Thanks, I tested it on current master but it doesn't seem to help; there > still aren't any

Re: [PATCH 2/5] rds: ib: replace spin_lock_irq with spin_lock_irqsave

On 3/11/17 6:33 PM, Yanjun Zhu wrote: Sorry. I have no test case to show some issue. But from Linux Kernel Development Second Edition by Robert Love. Yes I know the book and what the API does :D Use spin_lock_irq is dangerous since spin_unlock_irq unconditionally enables interrupts. We can

[net-next:master 38/46] drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c:1548:36: error: 'IEEE_8021QAZ_MAX_TCS' undeclared

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 01461abe62df44844efc5a57f9a365270a7c0299 commit: 65e0ace2c5cdd7aa898fea17d6e7bdc909394bf9 [38/46] net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet config: i386-randconfig-x0-03121309

Proposal...

Personal Business proposal for you,contact me via my personal E-mail for more detail's: ms_teresa_a...@outlook.com

Re: [PATCH 2/5] rds: ib: replace spin_lock_irq with spin_lock_irqsave

Sorry. I have no test case to show some issue. But from Linux Kernel Development Second Edition by Robert Love. Use spin_lock_irq is dangerous since spin_unlock_irq unconditionally enables interrupts. We can assume the following scenario: --->the interrupt is disabled.

Re: [PATCH net-next v2 00/17] net: dsa: mv88e6xxx: rework ATU support

Le 03/11/17 à 13:12, Vivien Didelot a écrit : > The purpose of this patch series is to rework the code related to the > Address Translation Unit (ATU), and bring support for it to the 88E6390 > family of switch chips. > > All Global (1) ATU related code have been reworked and moved to its own >

Re: [PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

Le 03/11/17 à 13:12, Vivien Didelot a écrit : > Introduce a dsa_is_normal_port helper to check if a given port is a > normal user port as opposed to a CPU port or DSA link. net/dsa/dsa2.c uses the "user" terminology should we use something like that here? > > Signed-off-by: Vivien Didelot

[Patch net-next] atm: remove an unnecessary loop

From: Francois Romieu Andrey reported this kernel warning: WARNING: CPU: 0 PID: 4114 at kernel/sched/core.c:7737 __might_sleep+0x149/0x1a0 do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait+0x182/0x530 The deeply nested alloc_skb is a problem.

Proposal...

Personal Business proposal for you,contact me via my personal E-mail for more detail's: ms_teresa_a...@outlook.com

Re: [PATCH net-next v2 03/17] net: dsa: mv88e6xxx: add ATU setup helper

On Sat, Mar 11, 2017 at 04:12:49PM -0500, Vivien Didelot wrote: > Move the configuration of the default ageing time in a new > mv88e6xxx_atu_setup function. > > That function will be extended later to contain all ATU related > configuration bits. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next v2 17/17] etherdevice: remove unused eth_addr_greater

On Sat, Mar 11, 2017 at 04:13:03PM -0500, Vivien Didelot wrote: > eth_addr_greater() was introduced for the mv88e6xxx driver, but is not > used anymore. There is no other user, thus remove this function. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew

Re: [PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

On Sat, Mar 11, 2017 at 04:12:58PM -0500, Vivien Didelot wrote: > Introduce a dsa_is_normal_port helper to check if a given port is a > normal user port as opposed to a CPU port or DSA link. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn

Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge

> > I really wished you had moved the code, unmodified, into > > global1_atu.c. Then made lots of easy to review small changes. I > > cannot just look at this patch and know it is correct. What i need to > > compare against is not in this patch. So it is a lot harder to review. > > I've addressed

Re: [PATCH] Enable tx timestamping on loopback and dummy

2 and 3 were recommendations by the checkpatch.pl script; as suggested, I've broken them down from the timestamping code and resubmitted as two separate patches (on separate emails though). > On 11 Mar 2017, at 23:17, Oliver Hartkopp wrote: > > Hi Ezequiel, > >> On

Re: [PATCH] Enable tx timestamping on loopback and dummy

Hi Ezequiel, On 03/11/2017 03:42 PM, Ezequiel Lara Gomez wrote: Also, cleanup some warnings from timestamping code. in fact you're doing three different things here: 1. introduce tx timestamping 2. silently change an include: -> 3. fix some whitespace and empty line issues You'd better

Proposal...

Personal Business proposal for you,contact me via my personal E-mail for more detail's: ms_teresa_a...@outlook.com

[no subject]

-- Hi, I appreciate your beauty! can we get to know each other better if you don't mind? My name is karl, Can you please tell me a little about yourself so that we can get to know each other better? Best Regards Karl.

Re: [PATCH net-next v5 0/7] gtp: misc improvements

Hi Andreas, > Andreas Schultz (7): > gtp: switch from struct socket to struct sock for the GTP sockets > gtp: make GTP sockets in gtp_newlink optional > gtp: merge gtp_get_net and gtp_genl_find_dev > gtp: consolidate gtp socket rx path > gtp: unify genl_find_pdp and prepare for per

Re: regression (4.10) - interface remove uevents not generated

On 2017-03-11 21:50, Andrei Vagin wrote: > Hi Mantas, > > Thank you for the report. Could you try out the attached patch? Thanks, I tested it on current master but it doesn't seem to help; there still aren't any uevents for removed interfaces. -- Mantas Mikulėnas

[PATCH net-next v2 02/17] net: dsa: mv88e6xxx: move ATU ageing time setter

Move the ATU ageing time setter code in a new global1_atu.c file, which will be extended in future patches to contains all consequent Global (1) ATU support code. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/Makefile | 1 +

[PATCH net-next v2 06/17] net: dsa: mv88e6xxx: rework ATU Load/Purge

All Marvell switch chips have an ATU accessed using the same Global (1) register layout. Only the handling of the FID differs as more bits were necessary to support more and more databases. Add and use a fresh documented implementation of the ATU Load/Purge. The static

[PATCH net-next v2 03/17] net: dsa: mv88e6xxx: add ATU setup helper

Move the configuration of the default ageing time in a new mv88e6xxx_atu_setup function. That function will be extended later to contain all ATU related configuration bits. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 13

[PATCH net-next v2 13/17] net: dsa: mv88e6xxx: rework port mode setup

A switch port mode is defined by the association of its egress mode, its frame mode and if supported or required, the ether type value. Pack all this in a mv88e6xxx_set_port_mode function and provide helpers for the Normal Network mode, the DSA mode, and the Ether Type DSA mode, as well as an

[PATCH net-next v2 17/17] etherdevice: remove unused eth_addr_greater

eth_addr_greater() was introduced for the mv88e6xxx driver, but is not used anymore. There is no other user, thus remove this function. Signed-off-by: Vivien Didelot --- include/linux/etherdevice.h | 15 --- 1 file changed, 15 deletions(-) diff

[PATCH net-next v2 10/17] net: dsa: mv88e6xxx: rename new FID helper

Rename the _mv88e6xxx_fid_new helper to mv88e6xxx_atu_new to get rid of the old underscore prefix naming convention and be consistent with the rest of the chip-wide ATU API. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn ---

[PATCH net-next v2 01/17] net: dsa: mv88e6xxx: add port mask helper

Add a mv88e6xxx_port_mask() helper to get the bitmask of ports in a switch chip, that will be used in several features. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 5 +

[PATCH net-next v2 11/17] net: dsa: mv88e6xxx: rename the port vector member

Not all Marvell switch chips support port trunking, which is embedded in the port vector data for ATU operations. Rename the portv_trunkid member of the mv88e6xxx_atu_entry structure to portvec to be more concise and consistent with the different chips. Signed-off-by: Vivien Didelot

[PATCH net-next v2 16/17] net: dsa: mv88e6xxx: add port priority override op

Add a new operation to disable the DA, SA and VTU priority override. Setting such limit is not likely to be used soon, so provide a port_disable_pri_override operation directly. This can be changed later for port_set_pri_override when we'll need it. Also remove the now obsolete

[PATCH net-next v2 04/17] net: dsa: mv88e6xxx: setup message ports

All interconnectable Marvell switch chips have an ATU Learn2All feature which allows newly learnt addresses to be spanned on ports marked as "Message Port". This commit configures the DSA ports as Message Port. Note that this has no effect until the Learn2All feature is enabled. Signed-off-by:

[PATCH net-next v2 09/17] net: dsa: mv88e6xxx: rework ATU Remove

Add a fresh documented implementation of the ATU Move operation, and use it to replace the current ATU Remove operation. Note that not all Marvell switch chip support the ATU Move operation. For those supporting it, the number of bits used to mask the destination port may vary. 6352 and such use

[PATCH net-next v2 00/17] net: dsa: mv88e6xxx: rework ATU support

The purpose of this patch series is to rework the code related to the Address Translation Unit (ATU), and bring support for it to the 88E6390 family of switch chips. All Global (1) ATU related code have been reworked and moved to its own file. Some port related bits used for ATU configuration

[PATCH net-next v2 07/17] net: dsa: mv88e6xxx: rework ATU GetNext

Add and use a fresh documented implementation of the ATU GetNext. Since it is not necessary to write the MAC address to iterate from, only do it once directly in the ATU GetNext operation, if the provided ATU entry structure is not valid. This makes the user code simpler. Also, there is no need

[PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

Introduce a dsa_is_normal_port helper to check if a given port is a normal user port as opposed to a CPU port or DSA link. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/dsa.h

[PATCH net-next v2 15/17] net: dsa: mv88e6xxx: add port ATU learn limit op

Add a new operation to disable the limiting of learnt MAC addresses. Setting such limit is not likely to be used soon, so provide a port_disable_learn_limit operation directly. This can be changed later for port_set_learn_limit when we'll need it. Signed-off-by: Vivien Didelot

[PATCH net-next v2 05/17] net: dsa: mv88e6xxx: enable ATU Learn2All

The ATU Learn2All feature allows newly learnt addresses to be spanned on ports marked as "Message Port", currently all DSA ports. This commit enables this feature which is necessary and quite convenient for multi-chip switch fabrics. Signed-off-by: Vivien Didelot

[PATCH net-next v2 08/17] net: dsa: mv88e6xxx: rework ATU Flush

Add a fresh documented implementation of the ATU Flush/Move operation. Use it to replace the current ATU Flush operation. _mv88e6xxx_atu_flush_move is still used by the Move operation so keep it until the Move operation is refactored in a next commit. Signed-off-by: Vivien Didelot

[PATCH net-next v2 14/17] net: dsa: mv88e6xxx: fix port egress flooding mode

The Marvell switch ports can be configured to allow or prevent egress of frames with an unknown unicast or multicast destination address. Some switch chips such as 88E6095 and 88E6185 have two disjoint bits in Port Control Register (0x04) bit 2 "Forward Unknown" (for unicast) and Port Control 2

[PATCH v2] net: tun: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- Changelog: v2: - Finaly, I've found the hardware and do basic test ;) thanks Michael S. Tsirkin and Eric Dumazet for the feedback

Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge

Hi Andrew, Andrew Lunn writes: > On Thu, Mar 09, 2017 at 06:33:14PM -0500, Vivien Didelot wrote: >> All Marvell switch chips have an ATU accessed using the same Global (1) >> register layout. Only the handling of the FID differs as more bits were >> necessary to support more and

[PATCH] Cleanup some warning from timestamping code.

--- drivers/net/loopback.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index b23b719..122cc2d 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -13,7 +13,7 @@ * * Alan Cox

[PATCH] Enable tx timestamping on loopback and dummy

This enables testing of SO_TIMESTAMPING options by targetting localhost addresses. Tested on qemu using txtimestamping.c from the kernel selftests. --- drivers/net/dummy.c| 1 + drivers/net/loopback.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/dummy.c

Re: regression (4.10) - interface remove uevents not generated

Hi Mantas, Thank you for the report. Could you try out the attached patch? On Sat, Mar 11, 2017 at 05:10:22PM +0200, Mantas Mikulėnas wrote: > Hello, > > It seems that commit 002d8a1a6c11b9b2a8ac615095589111dd52749b ("net: > skip genenerating uevents for network namespaces that are exiting") >

Proposal...

Personal Business proposal for you,contact me via my personal E-mail for more detail's: ms_teresa_a...@outlook.com

Re: [PATCH] Enable tx timestamping on loopback and dummy

On Sat, Mar 11, 2017 at 9:42 AM, Ezequiel Lara Gomez wrote: > Also, cleanup some warnings from timestamping code. Can you please submit the styling fixes as a separate patch? Thanks, Soheil

[PATCH net] bpf: improve read-only handling

Improve bpf_{prog,jit_binary}_{un,}lock_ro() by throwing a one-time warning in case of an error when the image couldn't be set read-only, and also mark struct bpf_prog as locked when bpf_prog_lock_ro() was called. Reason for the latter is that bpf_prog_unlock_ro() is called from various places

regression (4.10) - interface remove uevents not generated

Hello, It seems that commit 002d8a1a6c11b9b2a8ac615095589111dd52749b ("net: skip genenerating uevents for network namespaces that are exiting") broke 'remove' uevents for *all* network interfaces, even for those in the main/default namespace. Other than breaking some of my udev rules, this also

[PATCH] Enable tx timestamping on loopback and dummy

Also, cleanup some warnings from timestamping code. This enables testing of SO_TIMESTAMPING options by targetting localhost addresses. Tested on qemu using txtimestamping.c from the kernel selftests. Signed-off-by: Ezequiel Lara Gomez --- drivers/net/dummy.c| 1 +

ANNOUNCE: Netdev Conference: What you have been missing

As announced last time, we are making more frequent announcements on peo...@netdevconf.org You can subscribe via mailman here: https://lists.netdevconf.org/cgi-bin/mailman/listinfo/people We urge people to subscribe to that list to get more up to date information and conference discussions. We

Re: [PATCH net] selftests/bpf: fix broken build

On 03/11/2017 07:05 AM, Alexei Starovoitov wrote: Recent merge of 'linux-kselftest-4.11-rc1' tree broke bpf test build. None of the tests were building and test_verifier.c had tons of compiler errors. Fix it and add #ifdef CAP_IS_SUPPORTED to support old versions of libcap. Tested on centos 6.8

Re: [PATCH] netfilter: Force fake conntrack entry to be at least 8 bytes aligned

Steven Rostedt (VMware) wrote: > Since the nfct and nfctinfo have been combined, the nf_conn structure > must be at least 8 bytes aligned, as the 3 LSB bits are used for the > nfctinfo. But there's a fake nf_conn structure to denote untracked > connections, which is created

[patch net-next 6/9] mlxsw: spectrum: Add periodic ACL rule activity update

From: Arkadi Sharshevsky Introduce periodic task for dumping the activity status for the ACL rule TCAM entries. This is done in order to emulate last use statistics. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel

[patch net-next 9/9] mlxsw: spectrum: Add support for TC flower offload statistics

From: Arkadi Sharshevsky Add support for TC flower offload statistics including number of packets, bytes and last use timestamp. Currently the statistics are gathered on a per-rule basis. Signed-off-by: Arkadi Sharshvesky Reviewed-by: Ido Schimmel

[patch net-next 4/9] mlxsw: spectrum_acl_tcam: Add support for retrieving TCAM entry activity

From: Arkadi Sharshevsky Add support for retrieving TCAM entry activity. In order to support ACL rule activity corresponding TCAM entry should be queried. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel

[patch net-next 5/9] mlxsw: spectrum: Add support for direct rule access

From: Arkadi Sharshevsky Currently the ACL rules can be accessed only by hashing. In order to dump the activity the rules are also placed in a list. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by: Jiri

[patch net-next 8/9] mlxsw: spectrum: Add support for counters on TCAM entries

From: Arkadi Sharshevsky Add support for packets and byte statistics on TCAM entries. The counters are allocated from the generic flow counters pool. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by:

[patch net-next 7/9] mlxsw: spectrum: Add support for Policing and Counting action block

From: Arkadi Sharshevsky Add support for Policing and Counting action block. This action block will be used to bind counter to TCAM entries. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 2/9] mlxsw: reg: Add Monitoring General Purpose Counter Set register

From: Arkadi Sharshevsky The MGPC register retrieves generic flow counter value. It will be used to query ACL counters. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 3/9] mlxsw: spectrum: Add support for generic flow counter allocation

From: Arkadi Sharshevsky Add support for allocating generic flow counter. Generic flow counter can count packets or packets and bytes and can be assigned to different hardware processes. First use will be for counting packets and bytes of ACL rules, and will be introduced

[patch net-next 1/9] mlxsw: spectrum: Add support for counter allocator

From: Arkadi Sharshevsky Add implementation for counter allocator. The ASIC has special memory pool for various counting purposes. Counter memory is distributed between equal size banks. The static sub-pool configuration should specify the following parameters for each

[patch net-next 0/9] mlxsw: Add support for TC flower offload statistics

From: Jiri Pirko Arkadi says: This patchset adds support for retrieving TC flower statistics for offloaded rules, which includes packets count, bytes count and last used time stamp. Currently The statistics are gathered on a per-rule basis. This patchset also includes generic