Re: [PATCHv2 net-next 2/7] sctp: implement receiver-side procedures for the SSN/TSN Reset Request Parameter

On Fri, Mar 10, 2017 at 12:11:07PM +0800, Xin Long wrote: > This patch is to implement Receiver-Side Procedures for the SSN/TSN > Reset Request Parameter described in rfc6525 section 6.2.4. > > The process is kind of complicate, it's wonth having some comments > from section 6.2.4 in the codes. >

Re: [PATCH iproute2] ip route: Add missing space between nexthop and via for mpls multipath routes

On Fri, 17 Mar 2017 16:39:14 -0700 David Ahern wrote: > MPLS multipath routes are missing a space between 'nexthop' and 'via': > > $ ip -net ns1 -f mpls ro ls > 100 > nexthopvia inet 172.16.2.2 dev virt12 > nexthopvia inet 172.16.3.2 dev br0 > > Add it.

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

Às 5:44 PM de 3/20/2017, Niklas Cassel escreveu: > On 03/20/2017 06:42 PM, Joao Pinto wrote: >> Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: >>> From: Niklas Cassel >>> >>> It is usually possible to do >>> ethtool -s autoneg on >>> so that you trigger an autoneg before

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

On 03/20/2017 06:42 PM, Joao Pinto wrote: > Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: >> From: Niklas Cassel >> >> It is usually possible to do >> ethtool -s autoneg on >> so that you trigger an autoneg before calling >> ip link set dev eth0 up >> >> However, stmmac

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

On 03/20/2017 10:29 AM, Niklas Cassel wrote: > From: Niklas Cassel > > It is usually possible to do > ethtool -s autoneg on > so that you trigger an autoneg before calling > ip link set dev eth0 up This is completely driver specific and there is no guarantee for this to

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: > From: Niklas Cassel > > It is usually possible to do > ethtool -s autoneg on > so that you trigger an autoneg before calling > ip link set dev eth0 up > > However, stmmac returns -EBUSY if !netif_running. > The only

[PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

From: Niklas Cassel It is usually possible to do ethtool -s autoneg on so that you trigger an autoneg before calling ip link set dev eth0 up However, stmmac returns -EBUSY if !netif_running. The only reason for this appears to be that stmmac_init_phy is called from

Re: [PATCH] vxlan: use preferred address family when neither group or remote is specified

On Thu, 9 Mar 2017 21:05:42 +0100 Vincent Bernat wrote: > When neither group or remote is specified (or if they are specified with > the any address), nothing is sent to the kernel. In this case, the > kernel defaults to IPv4. This makes impossible to use IPv6 with >

Re: ipw2200: remove redundant check of rc < 0

Colin Ian King wrote: > From: Colin Ian King > > The check for rc < 0 is always false so the check is redundant > and can be removed. > > Detected with CoverityScan, CID#101143 ("Logically dead code") > > Signed-off-by: Colin Ian King

Re: [PATCH] net: convert sk_filter.refcnt from atomic_t to refcount_t

On 03/20/2017 10:37 AM, Elena Reshetova wrote: [...] diff --git a/net/core/filter.c b/net/core/filter.c index ebaeaf2..389cb8d 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -928,7 +928,7 @@ static void sk_filter_release_rcu(struct rcu_head *rcu) */ static void

Re: [3/3] mwifiex: wake system up when receives a wake irq

Jeffy Chen wrote: > Currrently we are disabling this wake irq after receiving it. If this > happens before we finish suspend and the pm event check is disabled, > the system will continue suspending, and this irq would not work again. > > We may need to abort system

Re: atmel: remove time_t usage

Alexandre Belloni wrote: > last_qual never really holds a time. It only holds jiffies. Make it the > same type as jiffies. > > Signed-off-by: Alexandre Belloni Patch applied to wireless-drivers-next.git, thanks.

Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

On 03/20/2017 09:45 AM, Alexei Starovoitov wrote: > On Mon, Mar 20, 2017 at 04:31:28PM +0100, Daniel Borkmann wrote: >> On 03/20/2017 07:03 AM, Zi Shen Lim wrote: >>> Merge of 'linux-kselftest-4.11-rc1': >>> >>> 1. Partially removed use of 'test_objs' target, breaking force rebuild of >>> BPFOBJ,

Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts

On 03/15/2017 08:00 AM, Roger Quadros wrote: > Andrew, > > On 15/03/17 16:08, Andrew Lunn wrote: >> On Wed, Mar 15, 2017 at 03:51:27PM +0200, Roger Quadros wrote: >>> Since commit 3c293f4e08b5 ("net: phy: Trigger state machine on state change >>> and not polling.") >>> phy_suspend() doesn't get

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 20.03.2017 um 16:14 schrieb Akshay Bhat: Hi Wolfgang, On 03/19/2017 12:17 PM, Wolfgang Grandegger wrote: Hello Akshay, I still see some improvements... Am 17.03.2017 um 22:10 schrieb Akshay Bhat: This patch adds support for the Holt HI-311x CAN controller. The HI311x CAN

Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts

On 03/16/2017 12:46 AM, Roger Quadros wrote: > On 15/03/17 17:49, Andrew Lunn wrote: >> On Wed, Mar 15, 2017 at 05:00:08PM +0200, Roger Quadros wrote: >>> Andrew, >>> >>> On 15/03/17 16:08, Andrew Lunn wrote: On Wed, Mar 15, 2017 at 03:51:27PM +0200, Roger Quadros wrote: > Since commit

Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

On 03/20/2017 01:15 PM, Feng Gao wrote: From: Gao Feng In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp Angle brackets not needed. :-) The commit citing style is the same as for the Fixes: tag. The checkpatch.pl reports the following error,

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, 2017-03-20 at 09:18 -0700, Eric Dumazet wrote: > Interesting. > > UDP ipv4 xmit path gets a ~25 % improvement on PPC with this patch. > > ( 20 concurrent netperf -t UDP_STREAM : 2.45 Mpps -> 3.07 Mpps ) Well, there _is_ a difference, but not 25 % (this was probably caused by different

RE: [PATCH 01/23] net, sunrpc: convert rpc_cred.cr_count from atomic_t to refcount_t

> On Fri, 2017-03-17 at 09:02 -0400, Jeff Layton wrote: > > On Fri, 2017-03-17 at 12:50 +, Trond Myklebust wrote: > > > On Fri, 2017-03-17 at 14:10 +0200, Elena Reshetova wrote: > > > > refcount_t type and corresponding API should be > > > > used instead of atomic_t when the variable is used

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, 2017-03-20 at 07:59 -0700, Eric Dumazet wrote: > On Mon, 2017-03-20 at 07:51 -0700, Eric Dumazet wrote: > > > atomic_cmpxchg() on PowerPC is horribly more expensive because of the > > added two SYNC instructions. > > Although I just saw that refcount was using atomic_cmpxchg_relaxed() >

Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

On 03/20/2017 07:03 AM, Zi Shen Lim wrote: Merge of 'linux-kselftest-4.11-rc1': 1. Partially removed use of 'test_objs' target, breaking force rebuild of BPFOBJ, introduced in commit d498f8719a09 ("bpf: Rebuild bpf.o for any dependency update"). Update target so dependency on BPFOBJ is

Re: [PATCH net-next v4 1/3] Add a helper function to get socket cookie in eBPF

On Sun, Mar 19, 2017 at 05:08:42PM -0700, Chenbo Feng wrote: > From: Chenbo Feng > > Retrieve the socket cookie generated by sock_gen_cookie() from a sk_buff > with a known socket. Generates a new cookie if one was not yet set.If > the socket pointer inside sk_buff is NULL, 0

Re: [PATCH net-next v4 3/3] A Sample of using socket cookie and uid for traffic monitoring

On Sun, Mar 19, 2017 at 05:08:44PM -0700, Chenbo Feng wrote: > From: Chenbo Feng > > Add a sample program to demostrate the possible usage of > get_socket_cookie and get_socket_uid helper function. The program will > store bytes and packets counting of in/out traffic monitored

Re: [PATCH net-next v4 1/3] Add a helper function to get socket cookie in eBPF

On Sun, Mar 19, 2017 at 05:08:42PM -0700, Chenbo Feng wrote: > From: Chenbo Feng > > Retrieve the socket cookie generated by sock_gen_cookie() from a sk_buff > with a known socket. Generates a new cookie if one was not yet set.If > the socket pointer inside sk_buff is NULL, 0

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, Mar 20, 2017 at 07:51:01AM -0700, Eric Dumazet wrote: > PowerPC has no efficient atomic_inc() and this definitely shows on > network intensive workloads involving concurrent cores/threads. Correct, PPC LL/SC are dreadfully expensive. > atomic_cmpxchg() on PowerPC is horribly more

Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

On Mon, Mar 20, 2017 at 04:31:28PM +0100, Daniel Borkmann wrote: > On 03/20/2017 07:03 AM, Zi Shen Lim wrote: > >Merge of 'linux-kselftest-4.11-rc1': > > > >1. Partially removed use of 'test_objs' target, breaking force rebuild of > >BPFOBJ, introduced in commit d498f8719a09 ("bpf: Rebuild bpf.o

Re: ath10k: remove redundant check of len with buf_len

Colin Ian King wrote: > From: Colin Ian King > > The check of len > buf_len is redundant as len is initialized > to 0 and buf_len to 4096, so this comparison is always false. > Remove it. > > Signed-off-by: Colin Ian King

Re: [PATCH net-next] liquidio: use meaningful names for IRQs

On Mon, 13 Mar 2017 12:58:04 -0700 Felix Manlunas wrote: > From: Rick Farrington > > All IRQs owned by the PF and VF drivers share the same nondescript name > "octeon"; this makes it difficult to setup interrupt affinity. > > Change

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, 2017-03-20 at 14:40 +0100, Peter Zijlstra wrote: > On Mon, Mar 20, 2017 at 09:27:13PM +0800, Herbert Xu wrote: > > On Mon, Mar 20, 2017 at 02:23:57PM +0100, Peter Zijlstra wrote: > > > > > > So what bench/setup do you want ran? > > > > You can start by counting how many cycles an atomic

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/19/2017 12:17 PM, Wolfgang Grandegger wrote: > Hello Akshay, > > I still see some improvements... > > Am 17.03.2017 um 22:10 schrieb Akshay Bhat: >> This patch adds support for the Holt HI-311x CAN controller. The HI311x >> CAN controller is capable of transmitting and

Re: [PATCH v2 1/9] net: stmmac: Rename clk_ptp_ref clock to ptp_ref

On Fri, Mar 10, 2017 at 05:34:53PM +0100, Thierry Reding wrote: > From: Thierry Reding > > There aren't currently any users of the "clk_ptp_ref", but there are > other references to "ptp_ref", so I'm leaning towards considering that a > typo. Fix it. > > Cc: Mark Rutland

liquidio: coverity scan errors

This showed up new Coverity scan erros ** CID 1403160:(FORWARD_NULL) /drivers/net/ethernet/cavium/liquidio/lio_main.c: 802 in setup_glists() /drivers/net/ethernet/cavium/liquidio/lio_vf_main.c: 560 in setup_glists()

RE: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

From: Peter Zijlstra > Sent: 20 March 2017 14:28 > On Mon, Mar 20, 2017 at 02:10:24PM +, David Laight wrote: > > On x86 the cpu flags from the 'lock inc/dec' could be used to reasonably > > cheaply detect errors - provided you actually generate a forwards branch. > > Note that currently there

Re: [PATCH net] sctp: remove useless err from sctp_association_init

On Mon, Mar 20, 2017 at 06:00:28PM +0800, Xin Long wrote: > This patch is to remove the unnecessary temporary variable 'err' from > sctp_association_init. > > Signed-off-by: Xin Long > --- > net/sctp/associola.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-)

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, 2017-03-20 at 07:51 -0700, Eric Dumazet wrote: > atomic_cmpxchg() on PowerPC is horribly more expensive because of the > added two SYNC instructions. Although I just saw that refcount was using atomic_cmpxchg_relaxed() Time to find some documentation (probably missing) or get some specs

Re: [PATCH net] sctp: declare struct sctp_stream before using it

On Mon, Mar 20, 2017 at 9:29 PM, Neil Horman wrote: > On Mon, Mar 20, 2017 at 05:46:27PM +0800, Xin Long wrote: >> sctp_stream_free uses struct sctp_stream as a param, but struct sctp_stream >> is defined after it's declaration. >> >> This patch is to declare struct

[PATCH] i40e: fix memcpy with swapped arguments

From: Colin Ian King The current code copies an uninitialized params into cdev->lan_info.params and then passes the uninitialized params to the call cdev->client->ops->l2_param_change. I believe the order of the source and destination in the memcpy is the wrong way

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, Mar 20, 2017 at 02:23:57PM +0100, Peter Zijlstra wrote: > > So what bench/setup do you want ran? You can start by counting how many cycles an atomic op takes vs. how many cycles this new code takes. Cheers, -- Email: Herbert Xu Home Page:

RE: [PATCH RFC 3/7] net: lan78xx: update for phy_(read|write)_mmd_indirect() removal

> lan78xx appears to use phylib in a rather weird way, accessing the PHY > partly through phylib, and partly by makign direct accesses to it, > including to the Clause 45 registers. As the indirect MMD accessors are > going away, update this driver to use the plain phy_(read|write)_mmd() >

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, Mar 20, 2017 at 02:10:24PM +, David Laight wrote: > On x86 the cpu flags from the 'lock inc/dec' could be used to reasonably > cheaply detect errors - provided you actually generate a forwards branch. Note that currently there is no arch specific implementation. We could of course

RE: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

From: Herbert Xu > Sent: 20 March 2017 13:16 > On Mon, Mar 20, 2017 at 11:39:37AM +0100, Peter Zijlstra wrote: > > > > Can we at least give a benchmark and have someone run numbers? We should > > be able to quantify these things. > > Do you realise how many times this thing gets hit at 10Gb/s or

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, Mar 20, 2017 at 09:27:13PM +0800, Herbert Xu wrote: > On Mon, Mar 20, 2017 at 02:23:57PM +0100, Peter Zijlstra wrote: > > > > So what bench/setup do you want ran? > > You can start by counting how many cycles an atomic op takes > vs. how many cycles this new code takes. On what uarch? I

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, Mar 20, 2017 at 11:39:37AM +0100, Peter Zijlstra wrote: > > Can we at least give a benchmark and have someone run numbers? We should > be able to quantify these things. Do you realise how many times this thing gets hit at 10Gb/s or higher? Anyway, since you're proposing this change you

Re: [PATCH net] sctp: declare struct sctp_stream before using it

On Mon, Mar 20, 2017 at 05:46:27PM +0800, Xin Long wrote: > sctp_stream_free uses struct sctp_stream as a param, but struct sctp_stream > is defined after it's declaration. > > This patch is to declare struct sctp_stream before sctp_stream_free. > > Fixes: a83863174a61 ("sctp: prepare asoc

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Mon, Mar 20, 2017 at 09:16:29PM +0800, Herbert Xu wrote: > On Mon, Mar 20, 2017 at 11:39:37AM +0100, Peter Zijlstra wrote: > > > > Can we at least give a benchmark and have someone run numbers? We should > > be able to quantify these things. > > Do you realise how many times this thing gets

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

On Mon, Mar 20, 2017 at 5:59 AM, Tariq Toukan wrote: > > Hi Eric, > > While testing XDP scenarios, I noticed a small degradation. > However, more importantly, I hit a kernel panic, see trace below. > > I'll need time to debug this. > I will update about progress in debug

Admin

ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

On 15/03/2017 5:36 PM, Tariq Toukan wrote: On 14/03/2017 5:11 PM, Eric Dumazet wrote: When adding order-0 pages allocations and page recycling in receive path, I added issues on PowerPC, or more generally on arches with large pages. A GRO packet, aggregating 45 segments, ended up using 45

Re: [PATCH] [netfilter-next] netfilter: remove unused refcount variable

On Mon, Mar 20, 2017 at 01:37:01PM +0100, Arnd Bergmann wrote: > The refcount variable was accidentally introduced without any reference > to it. Removing it again avoids this warning: > > net/netfilter/nfnetlink_acct.c: In function 'nfnl_acct_try_del': > net/netfilter/nfnetlink_acct.c:329:15:

RE: [PATCH] net: convert sk_filter.refcnt from atomic_t to refcount_t

> Hello! > > On 3/18/2017 3:58 PM, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > >

Re: net: deadlock between ip_expire/sch_direct_xmit

On Mon, 2017-03-20 at 10:59 +0100, Dmitry Vyukov wrote: > On Tue, Mar 14, 2017 at 5:41 PM, Cong Wang wrote: > > On Tue, Mar 14, 2017 at 7:56 AM, Eric Dumazet wrote: > >> On Tue, Mar 14, 2017 at 7:46 AM, Dmitry Vyukov wrote: > >>

[PATCH] [netfilter-next] netfilter: remove unused refcount variable

The refcount variable was accidentally introduced without any reference to it. Removing it again avoids this warning: net/netfilter/nfnetlink_acct.c: In function 'nfnl_acct_try_del': net/netfilter/nfnetlink_acct.c:329:15: error: unused variable 'refcount' [-Werror=unused-variable] Fixes:

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

On Sat, Mar 18, 2017 at 06:21:21PM -0700, David Miller wrote: > From: Herbert Xu > Date: Sun, 19 Mar 2017 00:47:59 +0800 > > > Eric Dumazet wrote: > >> On Fri, 2017-03-17 at 07:42 +, Reshetova, Elena wrote: > >> > >>> Should we then

Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes

Mon, Mar 20, 2017 at 12:37:22PM CET, colin.k...@canonical.com wrote: >From: Colin Ian King > >The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are >in the wrong order. Fix this by swapping them. > >Detected by CoverityScan, CID#1419705 ("Arguments in

Re: [PATCH] net: veth: use new api ethtool_{get|set}_link_ksettings

On Sat, Mar 18, 2017 at 7:13 PM, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes > --- > drivers/net/veth.c | 22

[PATCH] i40evf: dereference vsi after vsi has been null checked

From: Colin Ian King vsi is being dereferenced before the vsi null check; if vsi is null we end up with a null pointer dereference. Fix this by performing vsi deference after the vsi null check. Also remove the need for using adapter by using vsi->back->cinst.

Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes

On Mon, Mar 20, 2017 at 11:37:22AM +, Colin King wrote: > From: Colin Ian King > > The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are > in the wrong order. Fix this by swapping them. > > Detected by CoverityScan, CID#1419705 ("Arguments in

[PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes

From: Colin Ian King The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are in the wrong order. Fix this by swapping them. Detected by CoverityScan, CID#1419705 ("Arguments in wrong order") Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for

Re: [PATCH net-next] net: ethoc: Use ether_addr_copy()

On Fri, Mar 17, 2017 at 11:52:15AM +0100, Tobias Klauser wrote: > Use ether_addr_copy() instead of memcpy() to set netdev->dev_addr (which > is 2-byte aligned). > > Signed-off-by: Tobias Klauser > --- > drivers/net/ethernet/ethoc.c | 4 ++-- > 1 file changed, 2

Re: [PATCH nf 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

On Mon, Mar 20, 2017 at 5:37 PM, Sergei Shtylyov wrote: > Hello! > > On 3/20/2017 4:44 AM, f...@ikuai8.com wrote: > >> From: Gao Feng >> >> In the commit ("netfilter: nf_conntrack: nf_conntrack snmp helper"), > > >Need to specify the

Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

On Mon, Mar 20, 2017 at 6:09 PM, Sergei Shtylyov wrote: > On 3/20/2017 12:55 PM, f...@ikuai8.com wrote: > >> From: Gao Feng >> >> In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp > > >Angle brackets not needed. :-)

[PATCH 02/22] netfilter: nft_hash: rename nft_hash to nft_jhash

From: Laura Garcia Liebana This patch renames the local nft_hash structure and functions to nft_jhash in order to prepare the nft_hash module code to add new hash functions. Signed-off-by: Laura Garcia Liebana Signed-off-by: Pablo Neira Ayuso

Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

On 3/20/2017 12:55 PM, f...@ikuai8.com wrote: From: Gao Feng In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp Angle brackets not needed. :-) The commit citing style is the same as for the Fixes: tag. helper"), the snmp_helper is replaced by

[PATCH 00/22] Netfilter/IPVS updates for net-next

Hi David, The following patchset contains Netfilter/IPVS updates for your net-next tree. A couple of new features for nf_tables, and unsorted cleanups and incremental updates for the Netfilter tree. More specifically, they are: 1) Allow to check for TCP option presence via nft_exthdr, patch

[PATCH 05/22] netfilter: arp_tables: remove redundant check on ret being non-zero

From: Colin Ian King ret is initialized to zero and if it is set to non-zero in the xt_entry_foreach loop then we exit via the out_free label. Hence the check for ret being non-zero is redundant and can be removed. Detected by CoverityScan, CID#1357132 ("Logically Dead

[PATCH 13/22] netfilter: nf_conntrack: reduce resolve_normal_ct args

From: Florian Westphal also mark init_conntrack noinline, in most cases resolve_normal_ct will find an existing conntrack entry. textdata bss dec hex filename 167355707 176 22618585a net/netfilter/nf_conntrack_core.o 166875707 176 22570

[PATCH 11/22] netfilter: nft_ct: add helper set support

From: Florian Westphal this allows to assign connection tracking helpers to connections via nft objref infrastructure. The idea is to first specifiy a helper object: table ip filter { ct helper some-name { type "ftp" protocol tcp l3proto ip } } and

[PATCH 09/22] netfilter: nf_reject: remove unused variable

From: Taehee Yoo variable oiph is not used. Signed-off-by: Taehee Yoo Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/nf_reject_ipv4.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 20/22] ipvs: Document sysctl pmtu_disc

From: Hangbin Liu Document sysctl pmtu_disc based on commit 3654e61137db ("ipvs: add pmtu_disc option to disable IP DF for TUN packets"). Signed-off-by: Hangbin Liu Signed-off-by: Simon Horman ---

[PATCH net] sctp: remove useless err from sctp_association_init

This patch is to remove the unnecessary temporary variable 'err' from sctp_association_init. Signed-off-by: Xin Long --- net/sctp/associola.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/sctp/associola.c b/net/sctp/associola.c index

[PATCH 06/22] netfilter: nf_tables: validate the expr explicitly after init successfully

From: Liping Zhang When we want to validate the expr's dependency or hooks, we must do two things to accomplish it. First, write a X_validate callback function and point ->validate to it. Second, call X_validate in init routine. This is very common, such as fib, nat, reject

[PATCH 07/22] netfilter: nf_tables: add nft_set_lookup()

This new function consolidates set lookup via either name or ID by introducing a new nft_set_lookup() function. Replace existing spots where we can use this too. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 9 +

[PATCH 16/22] ipvs: remove an annoying printk in netns init

From: Cong Wang At most it is used for debugging purpose, but I don't think it is even useful for debugging, just remove it. Signed-off-by: Cong Wang Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_core.c | 2 --

[PATCH 19/22] ipvs: Document sysctl sync_ports

From: Hangbin Liu Document sysctl sync_ports based on commit f73181c8288f ("ipvs: add support for sync threads"). Signed-off-by: Hangbin Liu Signed-off-by: Simon Horman --- Documentation/networking/ipvs-sysctl.txt | 8

[PATCH 03/22] netfilter: nft_hash: support of symmetric hash

From: Laura Garcia Liebana This patch provides symmetric hash support according to source ip address and port, and destination ip address and port. For this purpose, the __skb_get_hash_symmetric() is used to identify the flow as it uses FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL flag

Re: net: deadlock between ip_expire/sch_direct_xmit

On Tue, Mar 14, 2017 at 5:41 PM, Cong Wang wrote: > On Tue, Mar 14, 2017 at 7:56 AM, Eric Dumazet wrote: >> On Tue, Mar 14, 2017 at 7:46 AM, Dmitry Vyukov wrote: >> >>> I am confused. Lockdep has observed both of these stacks:

[PATCH 04/22] netfilter: Use pr_cont where appropriate

From: Joe Perches Logging output was changed when simple printks without KERN_CONT are now emitted on a new line and KERN_CONT is required to continue lines so use pr_cont. Miscellanea: o realign arguments o use print_hex_dump instead of a local variant Signed-off-by: Joe

[PATCH 21/22] netfilter: refcounter conversions

From: "Reshetova, Elena" refcount_t type and corresponding API (see include/linux/refcount.h) should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free

[PATCH 15/22] netfilter: nft_set_rbtree: use per-set rwlock to improve the scalability

From: Liping Zhang Karel Rericha reported that in his test case, ICMP packets going through boxes had normally about 5ms latency. But when running nft, actually listing the sets with interval flags, latency would go up to 30-100ms. This was observed when router throughput is

[PATCH 22/22] netfilter: fix the warning on unused refcount variable

From: "Reshetova, Elena" net/netfilter/nfnetlink_acct.c: In function 'nfnl_acct_try_del': net/netfilter/nfnetlink_acct.c:329:15: warning: unused variable 'refcount' [-Wunused-variable] unsigned int refcount; ^ Fixes: b54ab92b84b6 ("netfilter: refcounter

[PATCH 14/22] netfilter: limit: use per-rule spinlock to improve the scalability

From: Liping Zhang The limit token is independent between each rules, so there's no need to use a global spinlock. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_limit.c | 10 +-

[PATCH 12/22] netfilter: nft_fib: Support existence check

From: Phil Sutter Instead of the actual interface index or name, set destination register to just 1 or 0 depending on whether the lookup succeeded or not if NFTA_FIB_F_PRESENT was set in userspace. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso

[PATCH 17/22] ipvs: fix sync_threshold description and add sync_refresh_period, sync_retries

From: Hangbin Liu Fix sync_threshold description which should have two values. Also add sync_refresh_period and sync_retries based on commit 749c42b620a9 ("ipvs: reduce sync rate with time thresholds"). Signed-off-by: Hangbin Liu Signed-off-by: Simon

[PATCH 10/22] netfilter: provide nft_ctx in object init function

From: Florian Westphal this is needed by the upcoming ct helper object type -- we'd like to be able use the table family (ip, ip6, inet) to figure out which helper has to be requested. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso

[PATCH 18/22] ipvs: Document sysctl sync_qlen_max and sync_sock_size

From: Hangbin Liu Document sysctl sync_qlen_max and sync_sock_size based on commit 1c003b1580e2 ("ipvs: wakeup master thread"). Signed-off-by: Hangbin Liu Signed-off-by: Simon Horman --- Documentation/networking/ipvs-sysctl.txt

[PATCH 08/22] netfilter: bridge: remove unneeded rcu_read_lock

From: Florian Westphal as comment says, the function is always called with rcu read lock held. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/bridge/br_netfilter_hooks.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH 01/22] netfilter: nft_exthdr: Allow checking TCP option presence, too

From: Phil Sutter Honor NFT_EXTHDR_F_PRESENT flag so we check if the TCP option is present. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_exthdr.c | 13 ++--- 1 file changed, 10 insertions(+), 3

[PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

From: Gao Feng In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the snmp_helper is never registered. But it still tries to unregister the snmp_helper, it could cause the panic. Now remove the

[PATCH net] sctp: declare struct sctp_stream before using it

sctp_stream_free uses struct sctp_stream as a param, but struct sctp_stream is defined after it's declaration. This patch is to declare struct sctp_stream before sctp_stream_free. Fixes: a83863174a61 ("sctp: prepare asoc stream for stream reconf") Signed-off-by: Xin Long

Re: [PATCH nf 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

Hello! On 3/20/2017 4:44 AM, f...@ikuai8.com wrote: From: Gao Feng In the commit ("netfilter: nf_conntrack: nf_conntrack snmp helper"), Need to specify the 12-digit SHA1 ID as well. the snmp_helper is replaced by nf_nat_snmp_hook. So the snmp_helper is never

[PATCH] net: convert sk_filter.refcnt from atomic_t to refcount_t

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

Re: [PATCH net-next v4 1/2]L2TP:Adjust intf MTU, add underlay L3, L2 hdrs

The patch comment of each patch should represent the changes of the patch. You seem to be using a common description for your two commits and this will look out of place when viewed using git log on one of the files modified by this patch. The patch summary line here is also inaccurate. Are you

Re: [PATCH net-next v4 2/2]L2TP:Adjust intf MTU, add underlay L3, L2 hdrs

I suggest change the wording of the first paragraph in the patch comment to better represent why the changes are being made. Perhaps something like the following? "Existing L2TP kernel code does not derive the optimal MTU for Ethernet pseudowires and instead leaves this to a userspace L2TP daemon

[PATCH] [v2, -net] cpsw/netcp: cpts depends on posix_timers

With posix timers having become optional, we get a build error with the cpts time sync option of the CPSW driver: drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts': drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of function 'ptp_classify_raw';did you mean

[PATCH] [v2, -net] cpsw/netcp: work around reverse cpts dependency

The dependency is reversed: cpsw and netcp call into cpts, but cpts depends on the other two in Kconfig. This can lead to cpts being a loadable module and its callers built-in: drivers/net/ethernet/ti/cpsw.o: In function `cpsw_remove': cpsw.c:(.text.cpsw_remove+0xd0): undefined reference to

[PATCH net-next] cxgb4: Update IngPad and IngPack values

From: Arjun Vynipadath We are using the smallest padding boundary (8 bytes), which isn't smaller than the Memory Controller Read/Write Size We get best performance in 100G when the Packing Boundary is a multiple of the Maximum Payload Size. Its related to inefficient chopping

[PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h

Without this header, we can run into a build error: drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c: In function 'xlgmac_config_queue_mapping': drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c:1548:36: error: 'IEEE_8021QAZ_MAX_TCS' undeclared (first use in this function) prio_queues =

[PATCH 2/2] [net-next] net: dwc-xlgmac: add module license

When building the driver as a module, we get a warning about the lack of a license: WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o see include/linux/module.h for more information Curiously the text in the .c files only mentions GPLv2+, while the license

RE: [PATCH net-next] liquidio: use meaningful names for IRQs

> > 2. The IRQ name can only be specified at the time it is requested. > > It cannot be changed after that. Is there any inherent difficulty in adding that capability? I.e., to rename the IRQ's action & kthread. It would allow drivers to re-name their IRQ names upon

[PATCH net 0/2] r8152: fix the rx settings of RTL8153

The RMS and the rx early size should base on the same rx size. However, the RMS is set to 9K bytes now and the rx early depends on mtu. For using the rx buffer effectively, sync the two settings according to the mtu. Hayes Wang (2): r8152: set the RMS of RTL8153 according to the mtu r8152:

<    1   2   3   >