Re: [net-next 05/13] i40e: rework exit flow of i40e_add_fdir_ethtool

2017-03-21 Thread Sergei Shtylyov
Hello! On 3/21/2017 2:47 AM, Jeff Kirsher wrote: From: Jacob Keller Refactor the exit flow of the i40e_add_fdir_ethtool function. Move the input_label to the end of the function, removing the dependency on I don't see 'input_label' anywhere. Perhaps

Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts

2017-03-21 Thread Roger Quadros
On 20/03/17 18:41, Florian Fainelli wrote: > On 03/16/2017 12:46 AM, Roger Quadros wrote: >> On 15/03/17 17:49, Andrew Lunn wrote: >>> On Wed, Mar 15, 2017 at 05:00:08PM +0200, Roger Quadros wrote: Andrew, On 15/03/17 16:08, Andrew Lunn wrote: > On Wed, Mar 15, 2017 at

Re: [Bridge] [PATCH net] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-03-21 Thread Pablo Neira Ayuso
On Tue, Mar 21, 2017 at 01:09:47AM +0100, Linus Lüssing wrote: > On Sun, Mar 19, 2017 at 05:55:06PM +0100, Linus Lüssing wrote: > > On Fri, Mar 17, 2017 at 02:10:44PM +0100, Pablo Neira Ayuso wrote: > > > Wait. > > > > > > May this break local multicast listener that are bound to the bridge > > >

[PATCH net v1 1/1] tipc: fix nametbl deadlock at tipc_nametbl_unsubscribe

2017-03-21 Thread Parthasarathy Bhuvaragan
From: Ying Xue Until now, tipc_nametbl_unsubscribe() is called at subscriptions reference count cleanup. Usually the subscriptions cleanup is called at subscription timeout or at subscription cancel or at subscriber delete. We have ignored the possibility of this being

[PATCH net-next v2 2/5] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-21 Thread sean.wang
From: Sean Wang Add the support for the 4-bytes tag for DSA port distinguishing inserted allowing receiving and transmitting the packet via the particular port. The tag is being added after the source MAC address in the ethernet header. Signed-off-by: Sean Wang

Re: mlx5e backports for v4.9 -stable

2017-03-21 Thread Saeed Mahameed
On Mon, Mar 20, 2017 at 11:32 PM, Saeed Mahameed wrote: > > > On 03/17/2017 02:06 AM, David Miller wrote: >> >> Commits: >> >> >> From b0d4660b4cc52e6477ca3a43435351d565dfcedc Mon Sep 17 00:00:00 2001 >> From: Tariq Toukan >> Date:

[PATCH net-next v2 3/5] net-next: ethernet: mediatek: add CDM able to recognize the tag for DSA

2017-03-21 Thread sean.wang
From: Sean Wang The patch adds the setup for allowing CDM can recognize these packets with carrying port-distinguishing tag. Otherwise, these tagging packets will be handled incorrectly by CDM. The setup is working out for general untag packets as well. Signed-off-by:

[PATCH net-next v2 4/5] net-next: ethernet: mediatek: add device_node of GMAC pointing into the netdev instance

2017-03-21 Thread sean.wang
From: Sean Wang the patch adds the setup of the corresponding device node of GMAC into the netdev instance which could allow other modules such as DSA to find the instance through the node in dt-bindings using of_find_net_device_by_node() call. Signed-off-by: Sean Wang

[PATCH net-next v2 0/5] net-next: dsa: add Mediatek MT7530 support

2017-03-21 Thread sean.wang
From: Sean Wang MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on Mediatek router platforms such as MT7623A or MT7623N which includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. Among these ports, The port from 0 to 4 are the user ports

[PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-21 Thread sean.wang
From: Sean Wang MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on Mediatek router platforms such as MT7623A or MT7623N platform which includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. Among these ports, The port from 0 to 4 are the

[PATCH net-next v2 1/5] dt-bindings: net: dsa: add Mediatek MT7530 binding

2017-03-21 Thread sean.wang
From: Sean Wang Add device-tree binding for Mediatek MT7530 switch. Cc: devicet...@vger.kernel.org Signed-off-by: Sean Wang --- .../devicetree/bindings/net/dsa/mt7530.txt | 92 ++ 1 file changed, 92 insertions(+)

Re: linux-next-20170320 break stmmac on dwmac-sunxi

2017-03-21 Thread Giuseppe CAVALLARO
+ Joao please Joao, could you do a check if new changes have any impact on that? peppe On 3/20/2017 8:54 PM, Corentin Labbe wrote: Hello Just pushed next-20170320 to my boards and stmmac stop working on both intree dwmac-sunxi and my dev dwmac-sun8i. It seems that interrupts never fire, and

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-21 Thread Niklas Cassel
On 03/20/2017 11:07 PM, Florian Fainelli wrote: > > (snip) >> >> However, it is kind of sad that drivers are so inconsistent of what goes >> in probe and what goes in ndo_open...which is tied together with the >> whole mess of when certain ethtool commands work or do not work. > Well, inconsistent

[PATCH 0/5] netfilter: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
This patch series clean up tests if NULL returned on failure. simran singhal (5): netfilter: ipvs: Clean up tests if NULL returned on failure netfilter: Clean up tests if NULL returned on failure netfilter: nf_tables_api: Clean up tests if NULL returned on failure netfilter: nfnetlink:

[PATCH 1/5] netfilter: ipvs: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal --- --This is

[PATCH 2/5] netfilter: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 5/5] netfilter: xt_TEE: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 4/5] netfilter: nfnetlink: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 3/5] netfilter: nf_tables_api: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-21 Thread Marcel Holtmann
Hi Bjorn, > By moving these client drivers to use RPMSG instead of the direct SMD > API we can reuse them ontop of the newly added GLINK wire-protocol > support found in the 820 and 835 Qualcomm platforms. > > As the new (RPMSG-based) and old SMD implementations are mutually > exclusive we have

Re: "tipc: fix socket timer deadlock" to stable?

2017-03-21 Thread Tommi Rantala
On 13.03.2017 14:18, Jon Maloy wrote: -Original Message- From: Tommi Rantala [mailto:tommi.t.rant...@nokia.com] We're seeing this tipc deadlock in 4.4.y, that was fixed in the mainline commit f1d048f24e66ba85d3dabf3d076cefa5f2b546b0 "tipc: fix socket timer deadlock". Could/should this

Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

2017-03-21 Thread Nicholas A. Bellinger
Hi Elena, On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [PATCH net-next v6 2/3] Add a eBPF helper function to retrieve socket uid

2017-03-21 Thread Lorenzo Colitti
On Tue, Mar 21, 2017 at 1:08 PM, Chenbo Feng wrote: > + if (!sk || !sk_fullsock(sk)) > + return overflowuid; > + kuid = sock_net_uid(sock_net(sk), sk); > + return from_kuid_munged(current_user_ns(), kuid); Is current_user_ns() correct

Re: [PATCH] enic: Store permanent MAC address during probe()

2017-03-21 Thread PJ Waskiewicz
On Mon, Mar 20, 2017 at 6:49 PM, Govindarajulu Varadarajan wrote: > On Mon, 20 Mar 2017, PJ Waskiewicz wrote: > >> On Mon, Mar 20, 2017 at 5:33 PM, Govindarajulu Varadarajan >> wrote: >>> >>> On Mon, 20 Mar 2017, PJ Waskiewicz wrote: >>> From: PJ

Re: SCTP MSG_MORE code

2017-03-21 Thread Xin Long
On Tue, Mar 21, 2017 at 1:49 AM, David Laight wrote: > Something needs to be done with SCTP MSG_MORE before the end of the rc cycle. > The current code is definitely broken. agreed. > > I objected to the last 'fix' patch because it clears the flag is a place where > I

<    1   2   3