Re: [net-next PATCH v2 5/8] net: Track start of busy loop instead of when it should end

On Thu, Mar 23, 2017 at 9:27 PM, Eric Dumazet wrote: > On Thu, 2017-03-23 at 20:42 -0700, Alexander Duyck wrote: >> On Thu, Mar 23, 2017 at 6:24 PM, Eric Dumazet wrote: >> > On Thu, 2017-03-23 at 14:37 -0700, Alexander Duyck wrote: >> >> From:

Re: [PATCHv2] net: usbnet: support 64bit stats in qmi_wwan driver

Hi Eric, On 24/03/17 14:59, Eric Dumazet wrote: > On Fri, 2017-03-24 at 11:27 +1000, Greg Ungerer wrote: >> Add support for the net stats64 counters to the usbnet core and then to >> the qmi_wwan driver. >> >> This is a strait forward addition of 64bit counters for RX and TX packets >> and byte

Re: r8169 regression: UDP packets dropped intermittantly

On Thu, Jun 23, 2016 at 01:22:50AM +0200, Francois Romieu wrote: > Jonathan Woithe : > [...] > > to mainline (in which case I'll keep watching out for it)? Or is the > > out-of-tree workaround mentioned above considered to be the long term > > fix for those who encounter

[net-next 09/10] i40e: document drivers use of ntuple filters

From: Jacob Keller Add documentation describing the drivers use of ethtool ntuple filters, including the limitations that it has due to hardware, as well as how it reads and parses the user-def data block. Signed-off-by: Jacob Keller

[net-next 07/10] i40e: implement support for flexible word payload

From: Jacob Keller Add support for flexible payloads passed via ethtool user-def field. This support is somewhat limited due to hardware design. The input set can only be programmed once per filter type, and the flexible offset is part of this filter input set. This

[net-next 10/10] i40e: make use of hlist_for_each_entry_continue

From: Jacob Keller Replace a complex if->continue->else->break construction in i40e_next_filter. We can simply use hlist_for_each_entry_continue instead. This drops a lot of confusing code. The resulting code is much easier to understand the intention, and follows the

[net-next 06/10] i40e: add parsing of flexible filter fields from userdef

From: Jacob Keller Add code to parse the user-def field into a data structure format. This code is intended to allow future extensions of the user-def field by keeping all code that actually reads and writes the field into a single location. This ensures that we do not

[net-next 05/10] i40e: partition the ring_cookie to get VF index

From: Jacob Keller Do not use the user-def field for determining the VF target. Instead, similar to ixgbe, partition the ring_cookie value into 8bits of VF index, along with 32bits of queue number. This is better than using the user-def field, because it leaves the

[net-next 08/10] i40e: add support for SCTPv4 FDir filters

From: Jacob Keller Enable FDir filters for SCTPv4 packets using the ethtool ntuple interface to enable filters. The ethtool API does not allow masking on the verification tag. Change-Id: I093e88a8143994c7e6f4b7b17a0bd5cf861d18e4 Signed-off-by: Jacob Keller

[net-next 03/10] i40e: restore default input set for each flow type

From: Jacob Keller Ensure that the default input set is correctly reprogrammed when cleaning up after disabling flow director support. This ensures that the programmed value will be in a clean state. Although we do not yet have support for SCTPv4 filters, a future

[net-next 02/10] i40e: check current configured input set when adding ntuple filters

From: Jacob Keller Do not assume that hardware has been programmed with the default mask, but instead read the input set registers to determine what is currently programmed. This ensures that all programmed filters match exactly how the hardware will interpret them,

[net-next 01/10] i40e: correctly honor the mask fields for ETHTOOL_SRXCLSRLINS

From: Jacob Keller The current implementation of .set_rxnfc does not properly read the mask field for filter entries. This results in incorrect driver behavior, as we do not reject filters which have masks set to ignore some fields. The current implementation simply

[net-next 04/10] i40e: allow changing input set for ntuple filters

From: Jacob Keller Add support to detect when we can update the input set for each flow type. Because the hardware only supports a single input set for all flows of that matching type, the driver shall only allow the input set to change if there are no other configured

[net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2017-03-23

This series contains updates to i40e and i40e.txt documentation. Jake provides all the changes in the series which are centered around ntuple filter fixes and additional support. Fixed the current implementation of .set_rxnfc, where we were not reading the mask field for filter entries which was

Re: [net-next PATCH v2 8/8] net: Introduce SO_INCOMING_NAPI_ID

On Thu, Mar 23, 2017 at 9:47 PM, Andy Lutomirski wrote: > So don't we want queue id, not NAPI id? Or am I still missing something? > > But I'm also a but confused as to the overall performance effect. > Suppose I have an rx queue that has its interrupt bound to cpu 0. For >

Re: [PATCHv2] net: usbnet: support 64bit stats in qmi_wwan driver

On Fri, 2017-03-24 at 11:27 +1000, Greg Ungerer wrote: > Add support for the net stats64 counters to the usbnet core and then to > the qmi_wwan driver. > > This is a strait forward addition of 64bit counters for RX and TX packets > and byte counts. It is done in the same style as for the other

Re: [net-next PATCH v2 8/8] net: Introduce SO_INCOMING_NAPI_ID

On Thu, Mar 23, 2017 at 5:58 PM, Alexander Duyck wrote: > On Thu, Mar 23, 2017 at 3:43 PM, Andy Lutomirski wrote: >> On Thu, Mar 23, 2017 at 2:38 PM, Alexander Duyck >> wrote: >>> From: Sridhar Samudrala

Re: [net-next PATCH v2 5/8] net: Track start of busy loop instead of when it should end

On Thu, 2017-03-23 at 21:27 -0700, Eric Dumazet wrote: > If you believe min/max values should be added to the sysctls, because we > do not trust root anymore, please send patches only addressing that. extern unsigned int sysctl_net_busy_read; extern unsigned int sysctl_net_busy_poll; ...

Re: [patch net-next] mlxsw: Remove debugfs interface

From: Jiri Pirko Date: Thu, 23 Mar 2017 11:14:24 +0100 > From: Ido Schimmel > > We don't use it during development and we can't extend it either, so > remove it. > > Signed-off-by: Ido Schimmel > Signed-off-by: Jiri Pirko

Re: [PATCH net] net: neigh: guard against NULL solicit() method

From: Eric Dumazet Date: Thu, 23 Mar 2017 12:39:21 -0700 > From: Eric Dumazet > > Dmitry posted a nice reproducer of a bug triggering in neigh_probe() > when dereferencing a NULL neigh->ops->solicit method. > > This can happen for

Re: [net-next PATCH v2 5/8] net: Track start of busy loop instead of when it should end

On Thu, 2017-03-23 at 20:42 -0700, Alexander Duyck wrote: > On Thu, Mar 23, 2017 at 6:24 PM, Eric Dumazet wrote: > > On Thu, 2017-03-23 at 14:37 -0700, Alexander Duyck wrote: > >> From: Alexander Duyck > >> > > > >> The last bit I changed is

Re: [net] Revert "e1000e: driver trying to free already-free irq"

On Thu, 2017-03-23 at 20:47 -0700, Jeff Kirsher wrote: > This reverts commit 7e54d9d063fa239c95c21548c5267f0ef419ff56. > > After additional regression testing, several users are experiencing > kernel panics during shutdown on e1000e devices.  Reverting this > change resolves the issue. > >

[net] Revert "e1000e: driver trying to free already-free irq"

This reverts commit 7e54d9d063fa239c95c21548c5267f0ef419ff56. After additional regression testing, several users are experiencing kernel panics during shutdown on e1000e devices. Reverting this change resolves the issue. Signed-off-by: Jeff Kirsher ---

Re: [net-next PATCH v2 5/8] net: Track start of busy loop instead of when it should end

On Thu, Mar 23, 2017 at 6:24 PM, Eric Dumazet wrote: > On Thu, 2017-03-23 at 14:37 -0700, Alexander Duyck wrote: >> From: Alexander Duyck >> > >> The last bit I changed is to move from using a shift by 10 to just using >> NSEC_PER_USEC and

[iproute2 net-next v2 1/3] netlink: Add flag to suppress print of nlmsg error

Allow callers of the dump API to handle nlmsg errors (e.g., an unsupported feature). Setting RTNL_HANDLE_F_SUPPRESS_NLERR in the rtnl_handle avoids unnecessary messages to the users in some case. For example, RTNETLINK answers: Operation not supported when probing for support of a new feature.

[iproute2 net-next v2 2/3] ip netconf: Show all address families by default in dumps

Currently, 'ip netconf' only shows ipv4 and ipv6 netconf settings. If IPv6 is not enabled, the dump ends with RTNETLINK answers: Operation not supported when IPv6 request is attempted. Further, if the mpls_router module is also loaded a separate request is needed to get MPLS settings. To

[iproute2 net-next v2 3/3] ip netconf: show all families on dev request

Currently specifying a device to ip netconf and it dumps only values for IPv4. Change this to dump data for all families unless a specific family is given. Signed-off-by: David Ahern --- ip/ipnetconf.c | 23 +-- 1 file changed, 13 insertions(+), 10

[iproute2 net-next v2 0/3] ip netconf improvements

Currently, ip netconf only shows data for ipv4 and ipv6 for dumps and just ipv4 for device requests. Improve the user experience by using the new kernel patch to dump all address families that have registered. For example, if mpls_router module is loaded then mpls values are displayed along with

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

Hi Dave, Please see inline: On Thu, 23 Mar 2017, David Miller wrote: > From: "R. Parameswaran" > Date: Wed, 22 Mar 2017 15:59:13 -0700 (PDT) > > > A new function, kernel_sock_ip_overhead(), is provided > > to calculate the cumulative overhead imposed by the IP > >

[PATCHv2] net: usbnet: support 64bit stats in qmi_wwan driver

Add support for the net stats64 counters to the usbnet core and then to the qmi_wwan driver. This is a strait forward addition of 64bit counters for RX and TX packets and byte counts. It is done in the same style as for the other net drivers that support stats64. The bulk of the change is to the

Re: linux-next: manual merge of the net-next tree with Linus' tree

On 3/23/17 5:10 PM, David Miller wrote: From: Stephen Rothwell Date: Fri, 24 Mar 2017 11:05:14 +1100 Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/hashtab.c between commit: 8c290e60fa2a ("bpf: fix hashmap extra_elems logic")

Re: [net-next PATCH v2 5/8] net: Track start of busy loop instead of when it should end

On Thu, 2017-03-23 at 14:37 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > The last bit I changed is to move from using a shift by 10 to just using > NSEC_PER_USEC and using multiplication for any run time calculations and > division for a few compile

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

Hi Parameswaran, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/R-Parameswaran/New-kernel-function-to-get-IP-overhead-on-a-socket/20170324-065003 config: x86_64-randconfig-s1-03240701 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7

Re: [net-next PATCH v2 3/8] net: Only define skb_mark_napi_id in one spot instead of two

On Thu, 2017-03-23 at 14:36 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Instead of defining two versions of skb_mark_napi_id I think it is more > readable to just match the format of the sk_mark_napi_id functions and just > wrap the contents of the

Re: [net-next PATCH v2 4/8] net: Change return type of sk_busy_loop from bool to void

On Thu, 2017-03-23 at 14:37 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > >From what I can tell there is only a couple spots where we are actually > checking the return value of sk_busy_loop. As there are only a few > consumers of that data, and the data

[PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2

Fix copy and paste error setting rt_ttl_propagate. Fixes: 5b441ac8784c1 ("mpls: allow TTL propagation to IP packets to be configured") Signed-off-by: David Ahern --- net/mpls/af_mpls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [net-next PATCH v2 2/8] tcp: Record Rx hash and NAPI ID in tcp_child_process

On Thu, 2017-03-23 at 14:36 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > While working on some recent busy poll changes we found that child sockets > were being instantiated without NAPI ID being set. In our first attempt to > fix it, it was suggested

Re: [net-next PATCH v2 8/8] net: Introduce SO_INCOMING_NAPI_ID

On Thu, Mar 23, 2017 at 3:43 PM, Andy Lutomirski wrote: > On Thu, Mar 23, 2017 at 2:38 PM, Alexander Duyck > wrote: >> From: Sridhar Samudrala >> >> This socket option returns the NAPI ID associated with the queue on which

Re: [PATCH net-next] sched: act_csum: don't mangle TCP and UDP GSO packets

From: Davide Caratti Date: Thu, 23 Mar 2017 10:39:40 +0100 > after act_csum computes the checksum on skbs carrying GSO TCP/UDP packets, > subsequent segmentation fails because skb_needs_check(skb, true) returns > true. Because of that, skb_warn_bad_offload() is invoked and

RE: [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller

> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Bernd Faust > Sent: Thursday, February 16, 2017 10:42 AM > To: Kirsher, Jeffrey T ; Lubetkin, YanirX > ; intel-wired-...@lists.osuosl.org; >

Re: [PATCH net] net: phy: Export mdiobus_register_board_info()

From: Florian Fainelli Date: Wed, 22 Mar 2017 22:40:30 -0700 > We can build modular code that uses mdiobus_register_board_info() which would > lead to linking failure since this symbol is not expoerted. > > Fixes: 648ea0134069 ("net: phy: Allow pre-declaration of MDIO

Re: linux-next: manual merge of the net-next tree with Linus' tree

From: Stephen Rothwell Date: Fri, 24 Mar 2017 11:05:14 +1100 > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > kernel/bpf/hashtab.c > > between commit: > > 8c290e60fa2a ("bpf: fix hashmap extra_elems logic") > > from Linus' tree

linux-next: manual merge of the net-next tree with Linus' tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/hashtab.c between commit: 8c290e60fa2a ("bpf: fix hashmap extra_elems logic") from Linus' tree and commit: bcc6b1b7ebf8 ("bpf: Add hash of maps support") from the net-next tree. I fixed it up (see

Re: [PATCH net-next 1/2] net: dwc-xlgmac: declaration of dual license in headers

From: Jie Deng Date: Thu, 23 Mar 2017 12:03:45 +0800 > The driver "dwc-xlgmac" is dual-licensed. This patch adds > declaration of dual license in file headers. > > Signed-off-by: Jie Deng Applied.

Re: [PATCH net-next 2/2] net: dwc-xlgmac: use dual license

From: Jie Deng Date: Thu, 23 Mar 2017 12:03:46 +0800 > The driver "dwc-xlgmac" is dual-licensed. > Declare the dual license with MODULE_LICENSE(). > > Signed-off-by: Jie Deng Applied.

Re: [PATCH net-next v8 0/3] net: core: Two Helper function about socket information

From: Chenbo Feng Date: Wed, 22 Mar 2017 17:27:33 -0700 > Introduce two eBpf helper function to get the socket cookie and > socket uid for each packet. The helper function is useful when > the *sk field inside sk_buff is not empty. These helper functions > can be

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

From: Bjorn Andersson Date: Wed, 22 Mar 2017 14:57:33 -0700 > On Wed 22 Mar 11:44 PDT 2017, David Miller wrote: > >> From: Bjorn Andersson >> Date: Mon, 20 Mar 2017 16:35:42 -0700 >> >> What is the status of the Kconfig dependency fix

[PATCH] xfrm: branchless addr4_match() on 64-bit

Current addr4_match() code has special test for /0 prefixes because of standard required undefined behaviour. However, it is possible to omit it on 64-bit because shifting can be done in a 64-bit register and then truncated to the expected value (which is 0 mask). Implicit truncation by htonl()

[PATCH] xfrm: use "unsigned int" in addr_match()

x86_64 is zero-extending arch so "unsigned int" is preferred over "int" for address calculations and extending to size_t. Space savings: add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-24 (-24) function old new delta xfrm_state_walk

[PATCH net-next 1/1] tcp: sysctl: Fix a race to avoid unexpected 0 window from space

From: Gao Feng Because sysctl_tcp_adv_win_scale could be changed any time, so there is one race in tcp_win_from_space. For example, 1.sysctl_tcp_adv_win_scale<=0 (sysctl_tcp_adv_win_scale is negative now) 2.space>>(-sysctl_tcp_adv_win_scale) (sysctl_tcp_adv_win_scale is postive

[PATCH] xfrm: use "unsigned int" in __xfrm6_pref_hash()

x86_64 is zero-extending arch so "unsigned int" is preferred over "int" for address calculations. Space savings: add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-58 (-58) function old new delta xfrm_hash_resize

Re: [net-next PATCH v2 0/8] Add busy poll support for epoll

On Thu, Mar 23, 2017 at 3:38 PM, Alexander Duyck wrote: > On Thu, Mar 23, 2017 at 3:07 PM, Alexei Starovoitov >> it all sounds awesome, but i cannot quite visualize the impact. >> Can you post some sample code/minibenchmark and numbers before/after? >> >> Thanks! >> >

Re: [net-next PATCH v2 8/8] net: Introduce SO_INCOMING_NAPI_ID

On Thu, Mar 23, 2017 at 2:38 PM, Alexander Duyck wrote: > From: Sridhar Samudrala > > This socket option returns the NAPI ID associated with the queue on which > the last frame is received. This information can be used by the apps to >

Re: [net-next PATCH v2 0/8] Add busy poll support for epoll

On Thu, Mar 23, 2017 at 3:07 PM, Alexei Starovoitov wrote: > On Thu, Mar 23, 2017 at 02:36:29PM -0700, Alexander Duyck wrote: >> This is my second pass at trying to add support for busy polling when using >> epoll. It is pretty much a full rewrite as I have made

[PATCH] xfrm: remove unused struct xfrm_mgr::id

Signed-off-by: Alexey Dobriyan --- include/net/xfrm.h |1 - net/key/af_key.c |1 - net/xfrm/xfrm_user.c |1 - 3 files changed, 3 deletions(-) --- a/include/net/xfrm.h +++ b/include/net/xfrm.h @@ -586,7 +586,6 @@ struct xfrm_migrate { struct xfrm_mgr {

Re: [net-next PATCH v2 6/8] net: Commonize busy polling code to focus on napi_id instead of socket

On Thu, 2017-03-23 at 14:37 -0700, Alexander Duyck wrote: > From: Sridhar Samudrala > > Move the core functionality in sk_busy_loop() to napi_busy_loop() and > make it independent of sk. > > This enables re-using this function in epoll busy loop implementation. > >

Re: [net-next PATCH v2 8/8] net: Introduce SO_INCOMING_NAPI_ID

On Thu, 2017-03-23 at 14:38 -0700, Alexander Duyck wrote: > From: Sridhar Samudrala > > This socket option returns the NAPI ID associated with the queue on which > the last frame is received. This information can be used by the apps to > split the incoming flows

Re: Problem: net: mvneta: auto-negotiation with disconnected network cable

23.03.2017 14:30, Maxime Morin пишет: Hi, Thank you very much for your help and your reactivity! See my answer bellow: 22.03.2017 16:23, Maxime Morin пишет: Hi all, I work on an embedded platform based on the Marvell Armada 88F6707, that is connected to a Marvell Alaska 88E1512 ethernet

Re: [net-next PATCH v2 0/8] Add busy poll support for epoll

On Thu, Mar 23, 2017 at 02:36:29PM -0700, Alexander Duyck wrote: > This is my second pass at trying to add support for busy polling when using > epoll. It is pretty much a full rewrite as I have made serious changes to > most of the patches. > > In the v1 series I had submitted we only allowed

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

From: "R. Parameswaran" Date: Wed, 22 Mar 2017 15:59:13 -0700 (PDT) > A new function, kernel_sock_ip_overhead(), is provided > to calculate the cumulative overhead imposed by the IP > Header and IP options, if any, on a socket's payload. > The new function returns an

Re: [net-next PATCH v2 1/8] net: Busy polling should ignore sender CPUs

On Thu, 2017-03-23 at 14:36 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > This patch is a cleanup/fix for NAPI IDs following the changes that made it > so that sender_cpu and napi_id were doing a better job of sharing the same > location in the sk_buff. >

[PATCH] net: make in_aton() 32-bit internally

Converting IPv4 address doesn't need 64-bit arithmetic. Space savings: 10 bytes! add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10) function old new delta in_aton96 86 -10 Signed-off-by: Alexey

Re: [PATCH] net: phy: handle state correctly in phy_stop_machine

On 03/23/2017 02:41 PM, Florian Fainelli wrote: > On 03/22/2017 01:27 PM, Zach Brown wrote: >> From: Nathan Sullivan >> >> If the PHY is halted on stop, then do not set the state to PHY_UP. This >> ensures the phy will be restarted later in phy_start when the machine is

Re: [PATCH] net: phy: handle state correctly in phy_stop_machine

On 03/22/2017 01:27 PM, Zach Brown wrote: > From: Nathan Sullivan > > If the PHY is halted on stop, then do not set the state to PHY_UP. This > ensures the phy will be restarted later in phy_start when the machine is > started again. So essentially what you want to

[net-next PATCH v2 6/8] net: Commonize busy polling code to focus on napi_id instead of socket

From: Sridhar Samudrala Move the core functionality in sk_busy_loop() to napi_busy_loop() and make it independent of sk. This enables re-using this function in epoll busy loop implementation. Signed-off-by: Sridhar Samudrala

[net-next PATCH v2 0/8] Add busy poll support for epoll

This is my second pass at trying to add support for busy polling when using epoll. It is pretty much a full rewrite as I have made serious changes to most of the patches. In the v1 series I had submitted we only allowed epoll to make use of busy poll when all NAPI IDs were the same. I gave this

[net-next PATCH v2 8/8] net: Introduce SO_INCOMING_NAPI_ID

From: Sridhar Samudrala This socket option returns the NAPI ID associated with the queue on which the last frame is received. This information can be used by the apps to split the incoming flows among the threads based on the Rx queue on which they are received. If

[net-next PATCH v2 7/8] epoll: Add busy poll support to epoll with socket fds.

From: Sridhar Samudrala This patch adds busy poll support to epoll. The implementation is meant to be opportunistic in that it will take the NAPI ID from the last socket that is added to the ready list that contains a valid NAPI ID and it will use that for busy

[net-next PATCH v2 5/8] net: Track start of busy loop instead of when it should end

From: Alexander Duyck This patch flips the logic we were using to determine if the busy polling has timed out. The main motivation for this is that we will need to support two different possible timeout values in the future and by recording the start time rather

[net-next PATCH v2 4/8] net: Change return type of sk_busy_loop from bool to void

From: Alexander Duyck >From what I can tell there is only a couple spots where we are actually checking the return value of sk_busy_loop. As there are only a few consumers of that data, and the data being checked for can be replaced with a check for

[net-next PATCH v2 3/8] net: Only define skb_mark_napi_id in one spot instead of two

From: Alexander Duyck Instead of defining two versions of skb_mark_napi_id I think it is more readable to just match the format of the sk_mark_napi_id functions and just wrap the contents of the function instead of defining two versions of the function. This way we

[net-next PATCH v2 1/8] net: Busy polling should ignore sender CPUs

From: Alexander Duyck This patch is a cleanup/fix for NAPI IDs following the changes that made it so that sender_cpu and napi_id were doing a better job of sharing the same location in the sk_buff. One issue I found is that we weren't validating the napi_id as being

[net-next PATCH v2 2/8] tcp: Record Rx hash and NAPI ID in tcp_child_process

From: Alexander Duyck While working on some recent busy poll changes we found that child sockets were being instantiated without NAPI ID being set. In our first attempt to fix it, it was suggested that we should just pull programming the NAPI ID into the function

Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute

On Thu, Mar 23, 2017 at 02:16:22PM -0700, David Miller wrote: > Can I get a review of these two patches from some GTP experts? I asked Jonas to resend indicating [PATCH net-next] in the subject and some minor comestic change. Apart from patches look good so Jonas, you can add this in your follow

Re: [PATCH] net: phy: handle state correctly in phy_stop_machine

From: Zach Brown Date: Wed, 22 Mar 2017 15:27:01 -0500 > From: Nathan Sullivan > > If the PHY is halted on stop, then do not set the state to PHY_UP. This > ensures the phy will be restarted later in phy_start when the machine is > started again. >

Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute

Can I get a review of these two patches from some GTP experts? Thanks.

[PATCH net-next] liquidio: do not reset Octeon if NIC firmware was preloaded

The PF driver is incorrectly resetting Octeon when the module parameter "fw_type=none" is there. "fw_type=none" means the PF should not load any firmware to the NIC because Octeon is already running preloaded firmware. Fix it by putting an if (fw_type != none) around the reset code. Because the

Re: [PATCH net-next 0/2] net: bridge: allow user-space to add ext learned entries

On Thu, Mar 23, 2017 at 12:27:11PM +0200, Nikolay Aleksandrov wrote: > Hi, > This set adds the ability to add externally learned entries from > user-space. For symmetry and proper function we need to allow SW entries > to take over HW learned ones (similar to how HW can take over SW entries >

Re: [PATCH net-next 2/2] net: bridge: allow to add externally learned entries from user-space

On Thu, Mar 23, 2017 at 12:27:13PM +0200, Nikolay Aleksandrov wrote: > The NTF_EXT_LEARNED flag was added for switchdev and externally learned > entries, but it can also be used for entries learned via a software > in user-space which requires dynamic entries that do not expire. > One such case

Re: [PATCH net-next 1/2] net: bridge: allow SW learn to take over HW fdb entries

On Thu, Mar 23, 2017 at 12:27:12PM +0200, Nikolay Aleksandrov wrote: > Allow to take over an entry which was previously learned via HW when it > shows up from a SW port. This is analogous to how HW takes over SW learned > entries already. > > Suggested-by: Roopa Prabhu

[PATCH net-next v5] net: Add sysctl to toggle early demux for tcp and udp

Certain system process significant unconnected UDP workload. It would be preferrable to disable UDP early demux for those systems and enable it for TCP only. By disabling UDP demux, we see these slight gains on an ARM64 system- 782 -> 788Mbps unconnected single stream UDPv4 633 -> 654Mbps

[PATCH net] net: neigh: guard against NULL solicit() method

From: Eric Dumazet Dmitry posted a nice reproducer of a bug triggering in neigh_probe() when dereferencing a NULL neigh->ops->solicit method. This can happen for arp_direct_ops/ndisc_direct_ops and similar, which can be used for NUD_NOARP neighbours (created when

Re: netlink: NULL timer crash

On Thu, 2017-03-23 at 12:00 -0700, David Miller wrote: > From: Eric Dumazet > Date: Thu, 23 Mar 2017 09:00:58 -0700 > > > On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote: > > > >> Nice ! > >> > >> Looks like neigh->ops->solicit is NULL > > > > Apparently we allow

Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function

Hi Mark, On Thu, Mar 23, 2017 at 06:54:52PM +, Mark Rutland wrote: > Hi Daniel, > > On Thu, Mar 23, 2017 at 06:42:01PM +0100, Daniel Lezcano wrote: > > In the next changes, we track the interrupts but we discard the timers as > > that does not make sense. The next interrupt on a timer is

Re: net/sched: GPF in qdisc_hash_add

On Thu, Mar 23, 2017 at 12:06 PM, Dmitry Vyukov wrote: > > On Thu, Mar 23, 2017 at 8:00 PM, Cong Wang wrote: > > On Thu, Mar 23, 2017 at 9:06 AM, Dmitry Vyukov wrote: > >> kasan: CONFIG_KASAN_INLINE enabled > >> kasan: GPF could

Re: Extending socket timestamping API for NTP

On Thu, Mar 23, 2017 at 05:21:45PM +0100, Miroslav Lichvar wrote: > A better approach might be a control message that would provide the > original interface index together with the length of the packet, so > the application could transpose the HW timestamp and map the HW > interface to the PHC.

Re: net/sched: GPF in qdisc_hash_add

On Thu, Mar 23, 2017 at 8:00 PM, Cong Wang wrote: > On Thu, Mar 23, 2017 at 9:06 AM, Dmitry Vyukov wrote: >> kasan: CONFIG_KASAN_INLINE enabled >> kasan: GPF could be caused by NULL-ptr deref or user memory access >> general protection fault:

Re: netlink: NULL timer crash

From: Eric Dumazet Date: Thu, 23 Mar 2017 09:00:58 -0700 > On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote: > >> Nice ! >> >> Looks like neigh->ops->solicit is NULL > > Apparently we allow admins to do really stupid things with neighbours > on tunnels. > >

Re: net/sched: GPF in qdisc_hash_add

On Thu, Mar 23, 2017 at 9:06 AM, Dmitry Vyukov wrote: > kasan: CONFIG_KASAN_INLINE enabled > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault: [#1] SMP KASAN > Dumping ftrace buffer: >(ftrace buffer empty) > Modules linked

Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function

Hi Daniel, On Thu, Mar 23, 2017 at 06:42:01PM +0100, Daniel Lezcano wrote: > In the next changes, we track the interrupts but we discard the timers as > that does not make sense. The next interrupt on a timer is predictable. Sorry, but I could not parse this. [...] > diff --git

Re: [PATCH 1/3] net: hns: avoid gcc-7.0.1 warning for uninitialized data

Arnd, I only see 2 patches out of 3 and no series header posting.

Re: Extending socket timestamping API for NTP

[Resend as plain text for netdev] > On Mar 23, 2017, at 09:21, Miroslav Lichvar wrote: > > After becoming a bit more familiar with the code I don't think this is > a good idea anymore :). I suspect there would be a noticeable > performance impact if each timestamped packet

Re: [PATCH net-next] liquidio: allocate RX buffers in OOM conditions in PF and VF

The 03/22/2017 19:37, David Miller wrote: > From: Felix Manlunas > Date: Wed, 22 Mar 2017 11:31:13 -0700 > > > From: Satanand Burla > > > > Add workqueue that is periodically run to try to allocate RX buffers in OOM > > conditions in PF and

Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function

On 03/23/2017 10:42 AM, Daniel Lezcano wrote: > In the next changes, we track the interrupts but we discard the timers as > that does not make sense. The next interrupt on a timer is predictable. > > But, the API request_percpu_irq does not allow to pass a flag, hence > specifying > if the

Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

Hi Subash, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-Add-sysctl-to-toggle-early-demux-for-tcp-and-udp/20170323-205131 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

0057ac6e9d] [size=0 bytes] > > Humm... Something in stmmac_free_tx_buffers... I'll need to check. > > > [ 112.266606] [ cut here ] > > [ 112.271220] WARNING: CPU: 0 PID: 0 at > > /home/thierry.reding/src/kernel/linux-tegra.git/lib/d

Re: net/kcm: double free of kcm inode

On Thu, Mar 23, 2017 at 5:09 AM, Dmitry Vyukov wrote: > Hello, > > I've got the following report while running syzkaller fuzzer. Note the > preceding kmem_cache_alloc injected failure, it's most likely the root > cause. > > FAULT_INJECTION: forcing a failure. > name failslab,

[Patch net] kcm: return immediately after copy_from_user() failure

There is no reason to continue after a copy_from_user() failure. Fixes: ab7ac4eb9832 ("kcm: Kernel Connection Multiplexor module") Cc: Tom Herbert Signed-off-by: Cong Wang --- net/kcm/kcmsock.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH V8 1/3] irq: Add flags to request_percpu_irq function

In the next changes, we track the interrupts but we discard the timers as that does not make sense. The next interrupt on a timer is predictable. But, the API request_percpu_irq does not allow to pass a flag, hence specifying if the interrupt type is a timer. Solve this by passing a 'flags'

[PATCH net-next 3/3] net: systemport: Simplify circular pointer arithmetic

Similar to c298ede2fe21 ("net: bcmgenet: simplify circular pointer arithmetic") we don't need to complex arthimetic since we always have a ring size that is a power of 2. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 6 +- 1 file

  1   2   >