Re: [PATCH] irda: vlsi_ir: fix check for dma mapping errors

2017-03-25 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 25 Mar 2017 01:48:08 +0300 > vlsi_alloc_ring() checks for dma mapping errors by comparison > returned address with zero, while pci_dma_mapping_error() should be used. > > Found by Linux Driver Verification project (linuxtesting.org). >

Re: [PATCH net-next 0/2] netvsc: Fix miscellaneous issues

2017-03-25 Thread David Miller
From: k...@exchange.microsoft.com Date: Fri, 24 Mar 2017 20:54:08 -0700 > Fix miscellaneous issues. Series applied, thanks.

Re: [RESEND PATCH 1/3] net: hns: fix uninitialized data use

2017-03-25 Thread David Miller
From: Arnd Bergmann Date: Fri, 24 Mar 2017 23:02:49 +0100 > When dev_dbg() is enabled, we print uninitialized data, as gcc-7.0.1 > now points out: > > ethernet/hisilicon/hns/hns_dsaf_main.c: In function > 'hns_dsaf_set_promisc_tcam': >

Re: [PATCH net-next v5 0/2] GTP SGSN-side tunnel

2017-03-25 Thread David Miller
From: Jonas Bonn Date: Fri, 24 Mar 2017 23:23:19 +0100 > Changes since v4: > > * Respin the series on top of net-next; the conflicts were trivial, > amounting to just code having been shifted about Series applied, but you really have to make improvements to your header

Re: [PATCH] padata: avoid race in reordering

2017-03-25 Thread Herbert Xu
On Sat, Mar 25, 2017 at 08:01:51PM -0700, David Miller wrote: > From: Steffen Klassert > Date: Fri, 24 Mar 2017 10:41:59 +0100 > > > On Thu, Mar 23, 2017 at 12:24:43PM +0100, Jason A. Donenfeld wrote: > >> Under extremely heavy uses of padata, crashes occur, and

Re: [RESEND PATCH 2/3] net: hns: avoid gcc-7.0.1 warning for uninitialized data

2017-03-25 Thread David Miller
From: Arnd Bergmann Date: Fri, 24 Mar 2017 23:02:50 +0100 > hns_dsaf_set_mac_key() calls dsaf_set_field() on an uninitialized field, > which will then change only a few of its bits, causing a warning with > the latest gcc: > > hisilicon/hns/hns_dsaf_main.c: In function

Re: [PATCH 0/2] net: usb: qmi_wwan: add qmap mux protocol support

2017-03-25 Thread David Miller
From: Daniele Palmas Date: Fri, 24 Mar 2017 14:22:44 +0100 > This patch adds support for qmap mux protocol available in recent > Qualcomm based modems. > > The qmap mux protocol can be used for multiplexing data packets in > order to have multiple ip streams through the same

Re: [patch net-next] mlxsw: spectrum_kvdl: Cosmetic kvdl allocator API change

2017-03-25 Thread David Miller
From: Jiri Pirko Date: Sat, 25 Mar 2017 08:28:22 +0100 > From: Arkadi Sharshevsky > > Currently the return allocated index and err value are multiplexed. > This patch changes the API to decouple the ret value from the allocated > index. > >

Re: [PATCH] padata: avoid race in reordering

2017-03-25 Thread David Miller
From: Steffen Klassert Date: Fri, 24 Mar 2017 10:41:59 +0100 > On Thu, Mar 23, 2017 at 12:24:43PM +0100, Jason A. Donenfeld wrote: >> Under extremely heavy uses of padata, crashes occur, and with list >> debugging turned on, this happens instead: ... >>

Re: [net-next 05/11] i40e: fix for queue timing delays

2017-03-25 Thread David Miller
From: Jeff Kirsher Date: Sat, 25 Mar 2017 01:12:59 -0700 > From: Carolyn Wyborny > > This patch adds a delay to Rx queue disables to accommodate HW needs. > > Change-ID: I2864ca667ce5dcc2cc44f8718113b719742a46a1 > Signed-off-by: Carolyn

[PATCH net-next] rtnl: Add support for netdev event to link messages

2017-03-25 Thread Vladislav Yasevich
RTNL currently generates notifications on some netdev notifier events. However, user space has no idea what changed. All it sees is the data and has to infer what has changed. For some events that is not possible. This patch adds a new field to RTM_NEWLINK message called IFLA_EVENT that would

EMAIL BENUTZER

2017-03-25 Thread HEIDI MEIER
-- Attn: Gewinner Ihre E-Mail-Adresse hat die Summe von €1,200.000.00 Euro gewonnen. Im Email Benützer Online Programm Weihnachtslotterie Navida , in Madrid Spanien . Wir schreiben ihnen ,um sich offiziel über die Auszeichnung zu Benachrichtigen , damit Sie sich mit der Zuständigen

Re: [PATCH ethtool] ethtool: Support for configurable RSS hash function

2017-03-25 Thread Jakub Kicinski
On Wed, 8 Mar 2017 16:03:51 +0200, Gal Pressman wrote: > This ethtool patch adds support to set and get the current RSS hash > function for the device through the new hfunc mask field in the > ethtool_rxfh struct. Kernel supported hash function names are queried > with ETHTOOL_GSTRINGS - each

Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-25 Thread Eric W. Biederman
David Ahern writes: > Bump the maximum number of labels for MPLS routes from 2 to 12. To keep > memory consumption in check the labels array is moved to the end of mpls_nh > and mpls_iptunnel_encap structs as a 0-sized array. Allocations use the > maximum number of

[PATCH] net: cris: eth_v10: use new api ethtool_{get|set}_link_ksettings

2017-03-25 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/cris/eth_v10.c | 32

[PATCH net-next 3/4] net: mpls: bump maximum number of labels

2017-03-25 Thread David Ahern
Allow users to push down more labels per MPLS route. With the previous patch no memory allocations for routes are based on MAX_NEW_LABELS, so the limit is only used to keep userspace in check. Per discussions, 16 labels has been deemed execessive, 8 seems to handle most use cases, though 1 user

[PATCH net-next 2/4] net: mpls: change mpls_route layout

2017-03-25 Thread David Ahern
Move labels to the end of mpls_nh as a 0-sized array and within mpls_route move the via for a nexthop after the mpls_nh. The new layout becomes: +--+ | mpls_route | +--+ | mpls_nh 0| +--+ |

[PATCH net-next 4/4] net: mpls: Increase max number of labels for lwt encap

2017-03-25 Thread David Ahern
Alow users to push down more labels per MPLS encap. Same logic as LSR use case, so re-use the maximum number of labels. Signed-off-by: David Ahern --- include/net/mpls_iptunnel.h | 4 +--- net/mpls/af_mpls.c | 5 - net/mpls/internal.h | 5 +

[PATCH net-next 1/4] net: mpls: Convert number of nexthops to u8

2017-03-25 Thread David Ahern
Number of nexthops and number of alive nexthops are tracked using an unsigned int. A route should never have more than 255 nexthops so convert both to u8. Update all references and intermediate variables to consistently use u8 as well. Shrinks the size of mpls_route from 32 bytes to 24 bytes with

[PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-25 Thread David Ahern
Bump the maximum number of labels for MPLS routes from 2 to 12. To keep memory consumption in check the labels array is moved to the end of mpls_nh and mpls_iptunnel_encap structs as a 0-sized array. Allocations use the maximum number of labels across all nexthops in a route for LSR and the number

Re: [PATCH v6 05/15] mlx4: Replace PCI pool old API

2017-03-25 Thread Doug Ledford
On Mon, 2017-03-20 at 08:32 +0200, Leon Romanovsky wrote: > On Sun, Mar 19, 2017 at 06:03:54PM +0100, Romain Perier wrote: > > > > The PCI pool API is deprecated. This commit replaces the PCI pool > > old > > API by the appropriate function with the DMA pool API. > > > > Signed-off-by: Romain

Re: [PATCH net-next 00/12] Mellanox mlx5e XDP performance optimization

2017-03-25 Thread Tom Herbert
On Fri, Mar 24, 2017 at 2:52 PM, Saeed Mahameed wrote: > Hi Dave, > > This series provides some preformancee optimizations for mlx5e > driver, especially for XDP TX flows. > > 1st patch is a simple change of rmb to dma_rmb in CQE fetch routine > which shows a huge gain for

[PATCH v2] xfrm: branchless addr4_match() on 64-bit

2017-03-25 Thread Alexey Dobriyan
Current addr4_match() code has special test for /0 prefixes because of standard required undefined behaviour. However, it is possible to omit it on 64-bit because shifting can be done within a 64-bit register and then truncated to the expected value (which is 0 mask). Implicit truncation by

Re: [PATCH] xfrm: branchless addr4_match() on 64-bit

2017-03-25 Thread Alexey Dobriyan
On Fri, Mar 24, 2017 at 05:16:44PM +, David Laight wrote: > From: Alexey Dobriyan > > Sent: 23 March 2017 23:33 > > Current addr4_match() code has special test for /0 prefixes because of > > standard required undefined behaviour. However, it is possible to omit > > it on 64-bit because

Re: [PATCH 0/2] net: usb: qmi_wwan: add qmap mux protocol support

2017-03-25 Thread Daniele Palmas
Hi Subash, 2017-03-24 18:45 GMT+01:00 Subash Abhinov Kasiviswanathan : > On 2017-03-24 07:22, Daniele Palmas wrote: >> >> This patch adds support for qmap mux protocol available in recent >> Qualcomm based modems. >> >> The qmap mux protocol can be used for multiplexing

Re: [PATCH 2/2] Documentation: ABI: testing: sysfs-class-net-qmi: add new qmap mux files description

2017-03-25 Thread Daniele Palmas
Hi Sergei, 2017-03-24 17:31 GMT+01:00 Sergei Shtylyov : > Hello! > > > On 03/24/2017 04:22 PM, Daniele Palmas wrote: > >> This patch updates the documentation related to the new files added for >> qmap mux support. >> >> Signed-off-by: Daniele Palmas

[PATCH] netvsc: fix dereference before null check errors

2017-03-25 Thread Colin King
From: Colin Ian King ndev is being checked to see if it is a null pointer however before the null check ndev is being dereferenced; hence there is a potential null pointer dereference bug that needs fixing. Fix this by only dereferencing ndev after the null check.

[PATCH] netvsc: fix unititialized return value in variable ret

2017-03-25 Thread Colin King
From: Colin Ian King It is possible for an uninitialized value of ret to be returned so fix this by initializing ret to zero. Detected by CoverityScan, CID#1420762 ("Uninitialized scalar variable") Fixes: 163891d7d429 ("netvsc: handle offline mtu and channel change")

[PATCH] net: netfilters: Remove extra parenthesis

2017-03-25 Thread Arushi Singhal
Rmoved parentheses on the right hand side of assignment, as they are not required. The following coccinelle script was used to fix this issue: @@ local idexpression id; expression e; @@ id = -( e -) Signed-off-by: Arushi Singhal ---

[PATCH] net: netfilter: Remove multiple assignment.

2017-03-25 Thread Arushi Singhal
This patch removes multiple assignments. Done using coccinelle. @@ identifier i1,i2; constant c; @@ - i1=i2=c; + i1=c; + i2=c; Signed-off-by: Arushi Singhal --- contribution to outreachy netfilter project. net/netfilter/nf_conntrack_proto_sctp.c | 3 ++- 1 file

__nf_conntrack_find_get - NMI watchdog, 4.10.5

2017-03-25 Thread Denys Fedoryshchenko
Hi, While applying/removing shapers on few thousands of ppp interfaces got pppoe server rebooted with this message: [51306.144984] NMI watchdog: BUG: soft lockup - CPU#0 stuck for 22s! [swapper/0:0] [51306.145319] Modules linked in: sch_sfq cls_fw act_police cls_u32 sch_ingress sch_htb pppoe

Re: [PATCH net-next 00/12] Mellanox mlx5e XDP performance optimization

2017-03-25 Thread Saeed Mahameed
On Sat, Mar 25, 2017 at 2:26 AM, Alexei Starovoitov wrote: > On 3/24/17 2:52 PM, Saeed Mahameed wrote: >> >> Hi Dave, >> >> This series provides some preformancee optimizations for mlx5e >> driver, especially for XDP TX flows. >> >> 1st patch is a simple change of rmb to dma_rmb in

[PATCH 0/2] net: netfilters: Remove typedef

2017-03-25 Thread Arushi Singhal
Remove typedef from struct. Arushi Singhal (2): net: netfilter: Remove typedef from "typedef struct field_t" net: netfilter: Remove typedef from "typedef struct bitstr_t" net/netfilter/nf_conntrack_h323_asn1.c | 98 +- 1 file changed, 49 insertions(+), 49

[PATCH 2/2] net: netfilter: Remove typedef from "typedef struct bitstr_t"

2017-03-25 Thread Arushi Singhal
This patch removes typedefs from struct and renames it from "typedef struct bitstr_t" to "struct bitstr" as per kernel coding standards." Signed-off-by: Arushi Singhal --- net/netfilter/nf_conntrack_h323_asn1.c | 80 +- 1 file

[PATCH 1/2] net: netfilter: Remove typedef from "typedef struct field_t"

2017-03-25 Thread Arushi Singhal
This patch removes typedefs from struct and renames it from "typedef struct field_t" to "struct field" as per kernel coding standards." Signed-off-by: Arushi Singhal --- net/netfilter/nf_conntrack_h323_asn1.c | 68 +- 1 file

Re: [net-next 05/11] i40e: fix for queue timing delays

2017-03-25 Thread Sergei Shtylyov
On 3/25/2017 11:12 AM, Jeff Kirsher wrote: From: Carolyn Wyborny This patch adds a delay to Rx queue disables to accommodate HW needs. Change-ID: I2864ca667ce5dcc2cc44f8718113b719742a46a1 Signed-off-by: Carolyn Wyborny Tested-by: Andrew

Re: [PATCH] irda: vlsi_ir: fix check for dma mapping errors

2017-03-25 Thread Sergei Shtylyov
Hello! On 3/25/2017 1:48 AM, Alexey Khoroshilov wrote: vlsi_alloc_ring() checks for dma mapping errors by comparison DMA. Comparing. returned address with zero, while pci_dma_mapping_error() should be used. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:

[PATCH stable 4.10] secure_seq: downgrade to per-host timestamp offsets

2017-03-25 Thread Florian Westphal
commit 28ee1b746f493b7c62347d714f58fbf4f70df4f0 upstream. Unfortunately too many devices (not under our control) use tcp_tw_recycle=1, which depends on timestamps being identical of the same saddr. Although tcp_tw_recycle got removed in net-next we can't make such end hosts disappear so

Re: [PATCH net-next 0/2] Performances improvement for IPv6 Segment Routing

2017-03-25 Thread David Lebrun
On 03/24/2017 10:48 PM, David Miller wrote: > Series applied, thanks. > > I think you should make SEG6_IPTUNNEL select DST_CACHE and then remove all of > these ugly ifdefs. Thanks Agreed, I'll submit a patch for that :) David signature.asc Description: OpenPGP digital signature

[net-next 06/11] i40e: removed no longer needed delays

2017-03-25 Thread Jeff Kirsher
From: Bimmy Pujari Removed no longer needed delays. At preproduction stage those delays were needed but now these delays are not needed. Signed-off-by: Bimmy Pujari Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 05/11] i40e: fix for queue timing delays

2017-03-25 Thread Jeff Kirsher
From: Carolyn Wyborny This patch adds a delay to Rx queue disables to accommodate HW needs. Change-ID: I2864ca667ce5dcc2cc44f8718113b719742a46a1 Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers

[net-next 07/11] i40e/i40evf: Clean-up process_skb_fields

2017-03-25 Thread Jeff Kirsher
From: Alexander Duyck This is a minor clean-up to make the i40e/i40evf process_skb_fields function look a little more like what we have in igb. The Rx checksum function called out a need for skb->protocol but I can't see where it actually needs it. I am assuming

[net-next 04/11] i40e: Fixed race conditions in VF reset

2017-03-25 Thread Jeff Kirsher
From: Robert Konklewski First, this patch eliminates IOMMU DMAR Faults caused by VF hardware. This is done by enabling VF hardware only after VSI resources are freed. Otherwise, hardware could DMA into memory that is (or just has been) being freed. Then, the VF

[net-next 09/11] i40e: Drop FCoE code that always evaluates to false or 0

2017-03-25 Thread Jeff Kirsher
From: Alexander Duyck Since FCoE isn't supported by the i40e products there isn't much point in carrying around code that will always evaluate to false. This patch goes through and strips out the code in several spots so that we don't go around carrying variables

[net-next 03/11] i40e/i40evf: Fix use after free in Rx cleanup path

2017-03-25 Thread Jeff Kirsher
From: Alexander Duyck We need to reset skb back to NULL when we have freed it in the Rx cleanup path. I found one spot where this wasn't occurring so this patch fixes it. Change-ID: Iaca68934200732cd4a63eb0bd83b539c95f8c4dd Signed-off-by: Alexander Duyck

[net-next 02/11] i40e: fix configuration of RSS table with DCB

2017-03-25 Thread Jeff Kirsher
From: Harshitha Ramamurthy There exists a bug in the driver where the calculation of the RSS size was not taking into account the number of traffic classes enabled. This patch factors in the traffic classes both in the initial configuration of the table as well as

[net-next 08/11] i40e: Drop FCoE code from core driver files

2017-03-25 Thread Jeff Kirsher
From: Alexander Duyck Looking over the code for FCoE it looks like the Rx path has been broken at least since the last major Rx refactor almost a year ago. It seems like FCoE isn't supported for any of the Fortville/Fortpark hardware so there isn't much point in

[net-next 11/11] i40e: initialize params before notifying of l2_param_changes

2017-03-25 Thread Jeff Kirsher
From: Jacob Keller Probably due to some mis-merging fix a bug associated with commits d7ce6422d6e6 ("i40e: don't check params until after checking for client instance", 2017-02-09) and 3140aa9a78c9 ("i40e: KISS the client interface", 2017-03-14) The first commit tried

[net-next 01/11] i40e/i40evf: Update code to better handle incrementing page count

2017-03-25 Thread Jeff Kirsher
From: Alexander Duyck Update the driver code so that we do bulk updates of the page reference count instead of just incrementing it by one reference at a time. The advantage to doing this is that we cut down on atomic operations and this in turn should give us a

[net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2017-03-25

2017-03-25 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Alex updates the driver code so that we can do bulk updates of the page reference count instead of just incrementing it by one reference at a time. Fixed an issue where we were not resetting skb back to NULL when we have freed it. Cleaned up

[net-next 10/11] i40evf: dereference VSI after VSI has been null checked

2017-03-25 Thread Jeff Kirsher
From: Colin Ian King VSI is being dereferenced before the VSI null check; if VSI is null we end up with a null pointer dereference. Fix this by performing VSI deference after the VSI null check. Also remove the need for using adapter by using vsi->back->cinst.

[patch iproute2/net-next] devlink: Add support for pipeline debug (dpipe)

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for pipeline debug (dpipe). The headers are used both the gain visibillity into the headers supported by the hardware, and to build the headers/field database which is used by other commands. Examples: First we can see the headers

[patch net-next 0/8] Add support for pipeline debug (dpipe)

2017-03-25 Thread Jiri Pirko
From: Jiri Pirko Arkadi says: While doing the hardware offloading process much of the hardware specifics cannot be presented. An example for such is the routing LPM algorithm which differ in hardware implementation from the kernel software implementation. The only information

[patch net-next 1/8] devlink: Support for pipeline debug (dpipe)

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky The pipeline debug is used to export the pipeline abstractions for the main objects - tables, headers and entries. The only support for set is for changing the counter parameter on specific table. The basic structures: Header - can represent a

[patch net-next 6/8] mlxsw: spectrum: Support for counters on router interfaces

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for counter allocation on router interfaces. The allocation depends on the counter state of relevant table. In case the counting is disabled or no counters left the counter index will be set as invalid. Also a counter pool for router

[patch net-next 2/8] mlxsw: reg: Add counter fields to RITR register

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Update RITR for counter support. This allows adding counters for ASIC's router ports. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 54

[patch net-next 5/8] mlxsw: reg: Add Router Interface Counter Register

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky The RICNT register retrieves per port performance counter. It will be used to query the router interfaces statistics. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko ---

[patch net-next 3/8] mlxsw: spectrum: Add placeholder for dpipe

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Add placeholder for dpipe. Support for specific tables and headers will be introduced in following patches. The headers are shared between all mlxsw_sp instances. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko

[patch net-next 8/8] mlxsw: spectrum: Add Support for erif table entries access

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Implement dpipe's table ops for erif table which provide: 1. Getting the entries in the table with the associate values. - match on "mlxsw_meta:erif_index" - action on "mlxsw_meta:forwared_out" 2. Synchronize the hardware in case of

[patch net-next 7/8] mlxsw: spectrum_router: Add rif helper functions

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Add rif helper function to access the rif index and rif devices ifindex. This functions will be used by dpipe in order to dump the rif table. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko ---

[patch net-next 4/8] mlxsw: spectrum: Add definition for egress rif table

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Add definition for egress router interface table. This table describes the final part in the routing pipeline. This table matches the egress interface index (rif index, which is set by the previous stages and determine the out port) and makes the

[patch net-next] mlxsw: spectrum_kvdl: Cosmetic kvdl allocator API change

2017-03-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the return allocated index and err value are multiplexed. This patch changes the API to decouple the ret value from the allocated index. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

2017-03-25 Thread Corentin Labbe
On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: > For cores that have more than 1 TX queue configured, the kernel would crash, > since only one TX queue is permitted by default. > > Signed-off-by: Joao Pinto > --- >