Re: [PATCHv3] net: usbnet: support 64bit stats in qmi_wwan driver

Hi Bjorn, On 31/03/17 18:48, Bjørn Mork wrote: Greg Ungerer writes: Add support for the net stats64 counters to the usbnet core and then to the qmi_wwan driver. This is a strait forward addition of 64bit counters for RX and TX packets and byte counts. It is done in the

Re: [PATCH net-next] udp: use sk_protocol instead of pcflag to detect udplite sockets

On Fri, 2017-03-31 at 11:47 +0200, Paolo Abeni wrote: > In the udp_sock struct, the 'forward_deficit' and 'pcflag' fields > share the same cacheline. While the first is dirtied by > udp_recvmsg, the latter is read, possibly several times, by the > bottom half processing to discriminate between udp

[PATCH] net: stmmac: fix cbs configuration

Sending again, because forgot to include net-dev. The QoS IP does not accept AVB capabilities to default/queue 0, this way we guarantee 75% bandwidth for AVB. This patch assures that only queues >= 1 gets CBS confgured. Additional info was also added to stmmac.txt. Reported-by: Niklas Cassel

[PATCH v2] tracing/kprobes: expose maxactive for kretprobe in kprobe_events

When a kretprobe is installed on a kernel function, there is a maximum limit of how many calls in parallel it can catch (aka "maxactive"). A kernel module could call register_kretprobe() and initialize maxactive (see example in samples/kprobes/kretprobe_example.c). But that is not exposed to

[PATCH] selftests: add a generic testsuite for ethernet device

Hello My original intent was to add network test to the kernelci project. Since they use kselftests, they forwarded me to this. This patch add a basic network test suite which do: - bring up netdev - change mac address - try some ethtool commands - bring down netdev The test is non disruptive,

[PATCH] selftests: add a generic testsuite for ethernet device

This patch add a generic testsuite for testing ethernet network device driver. Signed-off-by: Corentin Labbe --- tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/net/netdevice.sh | 185 +++ 2 files changed, 186

[PATCH V2 net-next 01/18] net: hns: Fix the implementation of irq affinity function

From: lipeng This patch fixes the implementation of the IRQ affinity function. This function is used to create the cpu mask which eventually is used to initialize the cpu<->queue association for XPS(Transmit Packet Steering). Signed-off-by: lipeng

[PATCH V2 net-next 00/18] net: hns: Misc. HNS Bug Fixes & Code Improvements

This patch set introduces various HNS bug fixes, optimizations and code improvements. Daode Huang (1): net: hns: bug fix of ethtool show the speed Kejian Yan (7): net: hns: Remove the redundant adding and deleting mac function net: hns: Remove redundant mac_get_id() net: hns: Remove

[PATCH V2 net-next 04/18] net: hns: Remove redundant memset during buffer release

From: lipeng Because all members of desc_cb is assigned when xmit one package, so it can delete in hnae_free_buffer, as follows: - "dma, priv, length, type" are assigned in fill_v2_desc. - "page_offset, reuse_flag, buf" are not used in tx direction.

[PATCH V2 net-next 02/18] net: hns: Modify GMAC init TX threshold value

From: lipeng This patch reduces GMAC TX threshold value to avoid gmac hang-up with speed 100M/duplex half. Signed-off-by: lipeng Signed-off-by: JinchuanTian Reviewed-by: Yisen Zhuang Signed-off-by:

[PATCH V2 net-next 03/18] net: hns: Optimize the code for GMAC pad and crc Config

From: lipeng This patch optimises the init configuration code leg for gmac pad and crc set interface. Signed-off-by: lipeng Signed-off-by: JinchuanTian Reviewed-by: Yisen Zhuang Signed-off-by:

[PATCH V2 net-next 06/18] net: hns: Optimize hns_nic_common_poll for better performance

From: lipeng After polling less than buget packages, we need check again. If there are still some packages, we call napi_schedule add softirq queue, this is not better way. So we return buget value instead of napi_schedule. Signed-off-by: lipeng

[PATCH V2 net-next 08/18] net: hns: Replace netif_tx_lock to ring spin lock

From: lipeng netif_tx_lock is a global spin lock, it will take affect in all rings in the netdevice. In tx_poll_one process, it can only lock the current ring, in this case, we define a spin lock in hnae_ring struct for it. Signed-off-by: lipeng

[PATCH V2 net-next 09/18] net: hns: Correct HNS RSS key set function

From: lipeng This patch fixes below ethtool configuration error: localhost:~ # ethtool -X eth0 hkey XX:XX:XX... Cannot set Rx flow hash configuration: Operation not supported Signed-off-by: lipeng Reviewed-by: Yisen Zhuang

[PATCH V2 net-next 05/18] net: hns: bug fix of ethtool show the speed

From: Daode Huang When run ethtool ethX on hns driver, the speed will show as "Unknown". The base.speed is not correct assigned, this patch fix this bug. Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang

[PATCH V2 net-next 07/18] net: hns: Fix to adjust buf_size of ring according to mtu

From: lipeng Because buf_size of ring set to 2048, the process of rx_poll_one can reuse the page, therefore the performance of XGE can improve. But the chip only supports three bds in one package, so the max mtu is 6K when it sets to 2048. For better performane in litter

[PATCH V2 net-next 10/18] net: hns: Remove the redundant adding and deleting mac function

From: Kejian Yan The functions (hns_dsaf_set_mac_mc_entry() and hns_mac_del_mac()) are not called by any functions. They are dead code in hns. And the same features are implemented by the patch (the id is 66355f5). Reported-by: Weiwei Deng

[PATCH V2 net-next 11/18] net: hns: Remove redundant mac_get_id()

From: Kejian Yan There is a mac_id in mac control block structure, so the callback function mac_get_id() is useless. Here we remove this function. Reported-by: Weiwei Deng Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta

[PATCH V2 net-next 13/18] net: hns: Clean redundant code from hns_mdio.c file

From: Kejian Yan This patch cleans the redundant code from hns_mdio.c. Reported-by: Ping Zhang Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta Signed-off-by: Salil Mehta

[PATCH V2 net-next 12/18] net: hns: Remove redundant mac table operations

From: Kejian Yan This patch removes redundant functions used only for debugging purposes. Reported-by: Weiwei Deng Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta Signed-off-by: Salil Mehta

[PATCH V2 net-next 14/18] net: hns: Optimise the code in hns_mdio_wait_ready()

From: Kejian Yan This patch fixes the code to clear pclint warning/info. Reported-by: Ping Zhang Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta Signed-off-by: Salil Mehta

[PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl script & warning fixes

This patch fixes some checkpatch.pl script caught errors and warnings during the compilation time. Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hnae.h | 1 - drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 11 +--

[PATCH V2 net-next 17/18] net: hns: Avoid Hip06 chip TX packet line bug

From: lipeng There is a bug on Hip06 that tx ring interrupts packets count will be clear when drivers send data to tx ring, so that the tx packets count will never upgrade to packets line, and cause the interrupts engendered was delayed. Sometimes, it will cause sending

[PATCH V2 net-next 16/18] net: hns: Adjust the SBM module buffer threshold

From: Kejian Yan HNS needs SMB Buffers to store at least two packets after sending pause frame because of the link delay. The MTU of HNS is 9728. As the processor user manual described, the SBM buffer threshold should be modified. Reported-by: Ping Zhang

[PATCH V2 net-next 15/18] net: hns: Simplify the exception sequence in hns_ppe_init()

From: Kejian Yan We need to free all ppe submodule if it fails to initialize ppe by any fault, so this patch will free all ppe resource before hns_ppe_init() returns exception situation Reported-by: JinchuanTian Signed-off-by: Kejian Yan

Re: stmmac CBS configuration for TX AVB queue

Às 10:59 AM de 3/31/2017, Niklas Cassel escreveu: > Hello Joao > > > I was looking at > > commit 19d9187317979cf0c25f67017d2676149abc46b2 > Author: Joao Pinto > Date: Fri Mar 10 18:24:59 2017 + > > net: stmmac: configuration of CBS in case of a TX AVB queue

[PATCH net 4/5] l2tp: hold session while sending creation notifications

l2tp_session_find() doesn't take any reference on the returned session. Therefore, the session may disappear while sending the notification. Use l2tp_session_get() instead and decrement session's refcount once the notification is sent. Fixes: 33f72e6f0c67 ("l2tp : multicast notification to the

[PATCH net 3/5] l2tp: fix duplicate session creation

l2tp_session_create() relies on its caller for checking for duplicate sessions. This is racy since a session can be concurrently inserted after the caller's verification. Fix this by letting l2tp_session_create() verify sessions uniqueness upon insertion. Callers need to be adapted to check for

[PATCH net 2/5] l2tp: ensure session can't get removed during pppol2tp_session_ioctl()

Holding a reference on session is required before calling pppol2tp_session_ioctl(). The session could get freed while processing the ioctl otherwise. Since pppol2tp_session_ioctl() uses the session's socket, we also need to take a reference on it in l2tp_session_get(). Fixes: fd558d186df2 ("l2tp:

[PATCH net 1/5] l2tp: fix race in l2tp_recv_common()

Taking a reference on sessions in l2tp_recv_common() is racy; this has to be done by the callers. To this end, a new function is required (l2tp_session_get()) to atomically lookup a session and take a reference on it. Callers then have to manually drop this reference. Fixes: fd558d186df2 ("l2tp:

[PATCH net 5/5] l2tp: take a reference on sessions used in genetlink handlers

Callers of l2tp_nl_session_find() need to hold a reference on the returned session since there's no guarantee that it isn't going to disappear from under them. Relying on the fact that no l2tp netlink message may be processed concurrently isn't enough: sessions can be deleted by other means (e.g.

[PATCH net 0/5] l2tp: fix usage of l2tp_session_find()

l2tp_session_find() doesn't take a reference on the session returned to its caller. Virtually all l2tp_session_find() users are racy, either because the session can disappear from under them or because they take a reference too late. This leads to bugs like 'use after free' or failure to notice

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 11:14 AM de 3/31/2017, Joao Pinto escreveu: > Às 6:48 PM de 3/30/2017, David Miller escreveu: >> From: Thierry Reding >> Date: Thu, 30 Mar 2017 16:34:36 +0200 >> >>> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: On Tue, Mar 28, 2017 at 06:01:05PM

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 6:48 PM de 3/30/2017, David Miller escreveu: > From: Thierry Reding > Date: Thu, 30 Mar 2017 16:34:36 +0200 > >> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >>> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann

[PATCH net-next] sctp: add SCTP_PR_STREAM_STATUS sockopt for prsctp

Before when implementing sctp prsctp, SCTP_PR_STREAM_STATUS wasn't added, as it needs to save abandoned_(un)sent for every stream. After sctp stream reconf is added in sctp, assoc has structure sctp_stream_out to save per stream info. This patch is to add SCTP_PR_STREAM_STATUS by putting the

Re: [PATCH] bluetooth: 6lowpan: fix delay work init in add_peer_chan()

Hi Michael, > When adding 6lowpan devices very rapidly we sometimes see a crash: > [23122.306615] CPU: 2 PID: 0 Comm: swapper/2 Not tainted 4.9.0-43-arm64 #1 > Debian 4.9.9.linaro.43-1 > [23122.315400] Hardware name: HiKey Development Board (DT) > [23122.320623] task: 800075443080

Re: [PATCH] bluetooth: 6lowpan: fix use after free in chan_suspend/resume

Hi Michael, > A status field in the skb_cb struct was storing a channel status > based on channel suspend/resume events. This stored status was > then used to return EAGAIN if there were packet sending issues > in snd_pkt(). > > The issue is that the skb has been freed by the time the callback

Re: [PATCH] treewide: Correct diffrent[iate] and banlance typos

Em Thu, 30 Mar 2017 20:44:16 -0700 Joe Perches escreveu: > Add these misspellings to scripts/spelling.txt too > > Signed-off-by: Joe Perches > --- > drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.h | 2 +- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c

Re: [PATCH net] ftgmac100: Mostly rewrite the driver

On Wed, 2017-03-29 at 20:15 -0700, David Miller wrote: > > > I've started re-doing the work in the form of a series of patches. > >  > > I can't promise I'll manage to make them all really small but I'll > > do my best. So hold onto reviewing if you haven't started already. > >  > > The end

stmmac CBS configuration for TX AVB queue

Hello Joao I was looking at commit 19d9187317979cf0c25f67017d2676149abc46b2 Author: Joao Pinto Date: Fri Mar 10 18:24:59 2017 + net: stmmac: configuration of CBS in case of a TX AVB queue This patch adds the configuration of the AVB Credit-Based

RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, March 31, 2017 4:03 AM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net 00/19] net:

[PATCH net] sctp: use right in and out stream cnt

Since sctp reconf was added in sctp, the real cnt of in/out stream have not been c.sinit_max_instreams and c.sinit_num_ostreams any more. This patch is to replace them with stream->in/outcnt. Signed-off-by: Xin Long --- net/sctp/outqueue.c | 3 +-- net/sctp/proc.c

[PATCH net-next] net: dsa: fix build error with devlink build as module

After commit 96567d5dacf4 ("net: dsa: dsa2: Add basic support of devlink") I see the following link error with CONFIG_NET_DSA=y and CONFIG_NET_DEVLINK=m: net/built-in.o: In function 'dsa_register_switch': (.text+0xe226b): undefined reference to `devlink_alloc' net/built-in.o: In function

[PATCH net-next] udp: use sk_protocol instead of pcflag to detect udplite sockets

In the udp_sock struct, the 'forward_deficit' and 'pcflag' fields share the same cacheline. While the first is dirtied by udp_recvmsg, the latter is read, possibly several times, by the bottom half processing to discriminate between udp and udplite sockets. With this patch, sk->sk_protocol is

Re: [RFC PATCH tip/master 1/3] trace: kprobes: Show sum of probe/retprobe nmissed count

On Wed, Mar 29, 2017 at 7:22 AM, Masami Hiramatsu wrote: > Show sum of probe and retprobe nmissed count in > kprobe_profile, since retprobe can be missed even > if the kprobe itself succeeeded. > This explains user why their return probe didn't hit > sometimes. > >

Re: [PATCHv3] net: usbnet: support 64bit stats in qmi_wwan driver

Am Freitag, den 31.03.2017, 10:48 +0200 schrieb Bjørn Mork: > You get *all* the "0" line drivers for free, not only "qmi_wwan".  No > code changes needed, except for adding the single .ndo line to drivers > overriding the usbnet default net_device_ops. And even that only applies > to a few of

[PATCH v3 1/3] net: phy: avoid setting unsupported EEE advertisments

We currently allow userspace to set any EEE advertisments it desires, whether or not the PHY supports them. For example: # ethtool --set-eee eth1 advertise 0x # ethtool --show-eee eth1 EEE Settings for eth1: EEE status: disabled Tx LPI: disabled Supported EEE

[PATCH v3 2/3] net: phy: restart phy autonegotiation after EEE advertisment change

When the EEE advertisment is changed, we should restart autonegotiation to update the link partner with the new EEE settings. Add this trigger but only if the advertisment has changed. Reviewed-by: Florian Fainelli Signed-off-by: Russell King

[PATCH v3 3/3] net: phy: allow EEE with any interface mode

EEE is able to work in any PHY interface mode, there is nothing which fundamentally restricts it to only a few modes. For example, EEE works in SGMII mode with the Marvell 88E1512. Rather than just adding SGMII mode to the list, Florian suggests removing the list of interface modes entirely:

Re: [PATCH] bluetooth: 6lowpan: fix delay work init in add_peer_chan()

Hi Michael, On Tue, 2017-03-28 at 23:10 -0700, Michael Scott wrote: > When adding 6lowpan devices very rapidly we sometimes see a crash: > [23122.306615] CPU: 2 PID: 0 Comm: swapper/2 Not tainted 4.9.0-43- > arm64 #1 Debian 4.9.9.linaro.43-1 > [23122.315400] Hardware name: HiKey Development Board

[PATCH v3 0/3] phylib EEE updates

David, This series of patches depends on the previous set of changes, and is therefore net-next material. While testing the EEE code, I discovered a number of issues: 1. It is possible to enable advertisment of EEE modes which are not supported by the hardware. We omit to check the

Re: [PATCH] bluetooth: 6lowpan: fix use after free in chan_suspend/resume

Hi Michael, On Tue, 2017-03-28 at 23:10 -0700, Michael Scott wrote: > A status field in the skb_cb struct was storing a channel status > based on channel suspend/resume events.  This stored status was > then used to return EAGAIN if there were packet sending issues > in snd_pkt(). > > The issue

Re: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs

Florian, On 30/03/17 23:02, Florian Fainelli wrote: > On 03/27/2017 04:59 AM, Roger Quadros wrote: >> The Ethernet link on an interrupt driven PHY was not coming up if the >> Ethernet cable was plugged before the Ethernet interface was brought up. >> >> The PHY state machine seems to be stuck

Re: [PATCHv3] net: usbnet: support 64bit stats in qmi_wwan driver

Greg Ungerer writes: > Add support for the net stats64 counters to the usbnet core and then to > the qmi_wwan driver. > > This is a strait forward addition of 64bit counters for RX and TX packets > and byte counts. It is done in the same style as for the other net drivers >

Re: [PATCH] bluetooth: 6lowpan: fix use after free in chan_suspend/resume

Hi Michael, On Wed, Mar 29, 2017 at 9:10 AM, Michael Scott wrote: > A status field in the skb_cb struct was storing a channel status > based on channel suspend/resume events. This stored status was > then used to return EAGAIN if there were packet sending issues > in

[net-next v3] vxlan: fix ND proxy when skb doesn't have transport header offset

When an incoming frame is tagged or when GRO is disabled, the skb handled to vxlan_xmit() doesn't contain a valid transport header offset. This makes ND proxying fail. We combine two changes: replace use of skb_transport_offset() and ensure the necessary amount of skb is linear just before using

Re: [PATCH v2 net-next 3/6] tools/lib/bpf: expose bpf_program__set_type()

Hi Alexei, Please see the patch I sent. Since we export bpf_program__set_type(), bpf_program__set_xxx() should be built based on it. Thank you. On 2017/3/31 12:45, Alexei Starovoitov wrote: expose bpf_program__set_type() to set program type Signed-off-by: Alexei Starovoitov

[PATCH] af_key: Add lock to key dump

A dump may come in the middle of another dump, modifying its dump structure members. This race condition will result in NULL pointer dereference in kernel. So add a lock to prevent that race. Fixes: 83321d6b9872 ("[AF_KEY]: Dump SA/SP entries non-atomically") Signed-off-by: Yuejie Shi

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

On Donnerstag, 30. März 2017 23:01:27 CEST Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > I've only compiled this change. If someone may test it, > it would be very nice. > > Signed-off-by: Philippe Reynes

Re: [PATCH V2 net-next 7/7] vhost_net: try batch dequing from skb array

On 2017年03月31日 12:02, Jason Wang wrote: On 2017年03月30日 22:21, Michael S. Tsirkin wrote: On Thu, Mar 30, 2017 at 03:22:30PM +0800, Jason Wang wrote: We used to dequeue one skb during recvmsg() from skb_array, this could be inefficient because of the bad cache utilization which cache does

Re: [PATCH v2 net-next 2/6] tools/lib/bpf: add support for BPF_PROG_TEST_RUN command

On 2017/3/31 12:45, Alexei Starovoitov wrote: add support for BPF_PROG_TEST_RUN command to libbpf.a Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau Acked-by: Wang Nan ---

[PATCHv3] net: usbnet: support 64bit stats in qmi_wwan driver

Add support for the net stats64 counters to the usbnet core and then to the qmi_wwan driver. This is a strait forward addition of 64bit counters for RX and TX packets and byte counts. It is done in the same style as for the other net drivers that support stats64. The bulk of the change is to the

pull-request: mac80211 2017-03-31

Hi Dave, Before netconf, I figured I'd get these two fixes to you, at least I wanted to have them out of the way. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit b768b16de58d5e0b1d7c3f936825b25327ced20c: openvswitch: Fix refcount

<    1   2