Re: [PATCH 1/4 v3 net-next] net: stmmac: break some functions into RX and TX scopes

2017-04-06 Thread Niklas Cassel
Survived 10/10 reboot + ping test Tested-by: Niklas Cassel On 04/06/2017 10:49 AM, Joao Pinto wrote: > This patch breaks several functions into RX and TX scopes, which > will be useful when adding multiple buffers mechanism. > > Signed-off-by: Joao Pinto

Re: [PATCH 4/4 v3 net-next] net: stmmac: adding multiple napi mechanism

2017-04-06 Thread Niklas Cassel
Survived 10/10 reboot + ping test Tested-by: Niklas Cassel On 04/06/2017 10:49 AM, Joao Pinto wrote: > This patch adds the napi variable to the stmmac_rx_queue > structure and forces that operations like netif_queue_stopped, > netif_wake_queue, netif_stop_queue,

Re: [Patch net] net_sched: check noop_qdisc before qdisc_hash_add()

2017-04-06 Thread Jiri Kosina
On Tue, 4 Apr 2017, Cong Wang wrote: > Dmitry reported a crash when injecting faults in > attach_one_default_qdisc() and dev->qdisc is still > a noop_disc, the check before qdisc_hash_add() fails > to catch it because it tests NULL. We should test > against noop_qdisc since it is the default

[PATCH 3/4 v3 net-next] net: stmmac: adding multiple buffers for TX

2017-04-06 Thread Joao Pinto
This patch adds the structure stmmac_tx_queue which contains tx queues specific data (previously in stmmac_priv). Signed-off-by: Joao Pinto --- changes v1->v3: - just to keep up with patch-set version drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 38 +-

[PATCH 4/4 v3 net-next] net: stmmac: adding multiple napi mechanism

2017-04-06 Thread Joao Pinto
This patch adds the napi variable to the stmmac_rx_queue structure and forces that operations like netif_queue_stopped, netif_wake_queue, netif_stop_queue, netdev_reset_queue and netdev_sent_queue be made by queue. Signed-off-by: Joao Pinto --- changes v2->v3: - just to keep

[PATCH 0/4 v3 net-next] net: stmmac: adding multiple buffers

2017-04-06 Thread Joao Pinto
This patch adds multiple buffers to stmmac in a more fragmented way, in order to make problem debug easier. I would kindly request to people to test this patch in their HWs in order to check if everything's functional. Thank you. Joao Pinto (4): net: stmmac: break some functions into RX and TX

[PATCH 1/4 v3 net-next] net: stmmac: break some functions into RX and TX scopes

2017-04-06 Thread Joao Pinto
This patch breaks several functions into RX and TX scopes, which will be useful when adding multiple buffers mechanism. Signed-off-by: Joao Pinto --- changes v2->v3: - just to keep up with patch-set version changes v1->v2: - RX and TX inconsistency - stmmac_free_rx_buffers

[PATCH 2/4 v3 net-next] net: stmmac: adding multiple buffers for rx

2017-04-06 Thread Joao Pinto
This patch adds the structure stmmac_rx_queue which contains rx queues specific data (previously in stmmac_priv). Signed-off-by: Joao Pinto --- changes v2->v3: - fixed infinite loop in err_init_rx_buffers error handling changes v1->v2: - %d replaced by %u when printing

Re: [PATCH rfc 0/6] Automatic affinity settings for nvme over rdma

2017-04-06 Thread Sagi Grimberg
Hi Sagi, Hey Max, the patchset looks good and of course we can add support for more drivers in the future. have you run some performance testing with the nvmf initiator ? I'm limited by the target machine in terms of IOPs, but the host shows ~10% cpu usage decrease, and latency improves

Re: [PATCH rfc 6/6] nvme-rdma: use intelligent affinity based queue mappings

2017-04-06 Thread Sagi Grimberg
Use the geneic block layer affinity mapping helper. Also, generic nr_io_queues = min(opts->nr_io_queues, num_online_cpus()); + nr_io_queues = min_t(unsigned int, nr_io_queues, + ibdev->num_comp_vectors); + Add a comment here? Will do

Re: [PATCH rfc 2/6] mlx5: move affinity hints assignments to generic code

2017-04-06 Thread Sagi Grimberg
static int mlx5e_get_cpu(struct mlx5e_priv *priv, int ix) { - return cpumask_first(priv->mdev->priv.irq_info[ix].mask); + return cpumask_first(pci_irq_get_affinity(priv->mdev->pdev, + MLX5_EQ_VEC_COMP_BASE + ix)); This looks ok for now, but if we look at the

Re: [PATCH 0/4 v2 net-next] net: stmmac: adding multiple buffers

2017-04-06 Thread Joao Pinto
Às 5:59 PM de 4/5/2017, Corentin Labbe escreveu: > On Wed, Apr 05, 2017 at 05:43:00PM +0100, Joao Pinto wrote: >> This patch adds multiple buffers to stmmac in a more fragmented >> way, in order to make problem debug easier. >> >> I would kindly request to people to test this patch in their HWs in

Re: [PATCH 2/4 v2 net-next] net: stmmac: adding multiple buffers for RX (fwd)

2017-04-06 Thread Joao Pinto
Às 6:29 AM de 4/6/2017, Julia Lawall escreveu: > It looks like an infinite loop, if queue is unsigned. > > julia > Yes you are right, I will fix it, thanks. Joao > -- Forwarded message -- > Date: Thu, 6 Apr 2017 11:49:01 +0800 > From: kbuild test robot

[PATCH 1/4] crypto: user - Prepare for CRYPTO_MAX_ALG_NAME expansion

2017-04-06 Thread Herbert Xu
This patch hard-codes CRYPTO_MAX_NAME in the user-space API to 64, which is the current value of CRYPTO_MAX_ALG_NAME. This patch also replaces all remaining occurences of CRYPTO_MAX_ALG_NAME in the user-space API with CRYPTO_MAX_NAME. This way the user-space API will not be modified when we

[PATCH 4/4] crypto: api - Extend algorithm name limit to 128 bytes

2017-04-06 Thread Herbert Xu
With the new explicit IV generators, we may now exceed the 64-byte length limit on the algorithm name, e.g., with echainiv(authencesn(hmac(sha256-generic),cbc(des3_ede-generic))) This patch extends the length limit to 128 bytes. Reported-by: Alexander Sverdlin

[PATCH 3/4] xfrm: Prepare for CRYPTO_MAX_ALG_NAME expansion

2017-04-06 Thread Herbert Xu
This patch fixes the xfrm_user code to use the actual array size rather than the hard-coded CRYPTO_MAX_ALG_NAME length. This is because the array size is fixed at 64 bytes while we want to increase the in-kernel CRYPTO_MAX_ALG_NAME value. Signed-off-by: Herbert Xu

[PATCH 2/4] crypto: af_alg - Allow arbitrarily long algorithm names

2017-04-06 Thread Herbert Xu
This patch removes the hard-coded 64-byte limit on the length of the algorithm name through bind(2). The address length can now exceed that. The user-space structure remains unchanged. In order to use a longer name simply extend the salg_name array beyond its defined 64 bytes length.

[PATCH 0/4] crypto: CRYPTO_MAX_ALG_NAME is too low

2017-04-06 Thread Herbert Xu
On Thu, Mar 16, 2017 at 03:16:29PM +0100, Alexander Sverdlin wrote: > > This is a regression caused by 856e3f4092 > ("crypto: seqiv - Add support for new AEAD interface") > > As I've said above, I can offer one of the two solutions, which patch should > I send? > Or do you see any better

[net-next 6/7] fm10k: disable receive queue when configuring ring

2017-04-06 Thread Jeff Kirsher
From: Ngai-Mint Kwan Write to RXQCTL register to disable the receive queue when configuring the RX ring. Signed-off-by: Ngai-Mint Kwan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher

[net-next 5/7] fm10k: update function header comment for fm10k_get_stats64

2017-04-06 Thread Jeff Kirsher
From: Jacob Keller Re-word the comment to avoid stating that we return a value for this void function. Additionally, there is no need to mention older kernels, since this is the upstream kernel. Signed-off-by: Jacob Keller Tested-by:

[net-next 7/7] fm10k: do not enqueue mailbox when host not ready

2017-04-06 Thread Jeff Kirsher
From: Ngai-Mint Kwan Interfaces will reset whenever the TX mailbox FIFO has become full. This occurs more frequently whenever the IES API application is not running to process and clear the messages in the FIFO. Thus, this could lead to situations where the interface

[net-next 0/7][pull request] 100GbE Intel Wired LAN Driver Updates 2017-04-05

2017-04-06 Thread Jeff Kirsher
This series contains updates to fm10k only. Phil Turnbull from Oracle fixes an issue where the argument provided to FM10K_REMOVED macro was not what was expecting. Jake modifies the driver to replace the bitwise operators and defines with a BITMAP and enumeration values to avoid race conditions.

[net-next 3/7] fm10k: future-proof state bitmaps using DECLARE_BITMAP

2017-04-06 Thread Jeff Kirsher
From: Jacob Keller This ensures that future programmers do not have to remember to re-size the bitmaps due to adding new values. Although this is unlikely for this driver, it may happen and it's best to prevent it from ever being an issue. Signed-off-by: Jacob Keller

[net-next 1/7] fm10k: correctly check if interface is removed

2017-04-06 Thread Jeff Kirsher
From: Phil Turnbull FM10K_REMOVED expects a hardware address, not a 'struct fm10k_hw'. Fixes: 5cb8db4a4cbc ("fm10k: Add support for VF") Signed-off-by: Phil Turnbull Tested-by: Krishneil Singh Signed-off-by: Jeff

[net-next 2/7] fm10k: use a BITMAP for flags to avoid race conditions

2017-04-06 Thread Jeff Kirsher
From: Jacob Keller Replace bitwise operators and #defines with a BITMAP and enumeration values. This is similar to how we handle the "state" values as well. This has two distinct advantages over the old method. First, we ensure correctness of operations which are

[net-next 4/7] fm10k: allow service task to reschedule itself

2017-04-06 Thread Jeff Kirsher
From: Jacob Keller If some code path executes fm10k_service_event_schedule(), it is guaranteed that we only queue the service task once, since we use __FM10K_SERVICE_SCHED flag. Unfortunately this has a side effect that if a service request occurs while we are currently

Re: [PATCH 4/4] mtd: nand: nandsim: convert to memalloc_noreclaim_*()

2017-04-06 Thread Michal Hocko
On Thu 06-04-17 09:33:44, Adrian Hunter wrote: > On 05/04/17 14:39, Vlastimil Babka wrote: > > On 04/05/2017 01:36 PM, Richard Weinberger wrote: > >> Michal, > >> > >> Am 05.04.2017 um 13:31 schrieb Michal Hocko: > >>> On Wed 05-04-17 09:47:00, Vlastimil Babka wrote: > Nandsim has own

Re: [Nbd] [PATCH 3/4] treewide: convert PF_MEMALLOC manipulations to new helpers

2017-04-06 Thread Wouter Verhelst
On Wed, Apr 05, 2017 at 01:30:31PM +0200, Michal Hocko wrote: > On Wed 05-04-17 09:46:59, Vlastimil Babka wrote: > > We now have memalloc_noreclaim_{save,restore} helpers for robust setting and > > clearing of PF_MEMALLOC. Let's convert the code which was using the generic > > tsk_restore_flags().

[PATCH] net: i40evf: Use net_device_stats from struct net_device

2017-04-06 Thread Tobias Klauser
Instead of using a private copy of struct net_device_stats in struct i40evf_adapter, use stats from struct net_device. Also remove the now unnecessary .ndo_get_stats function. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/intel/i40evf/i40evf.h | 1 -

[PATCH] net: igbvf: Use net_device_stats from struct net_device

2017-04-06 Thread Tobias Klauser
Instead of using a private copy of struct net_device_stats in struct igbvf_adapter, use stats from struct net_device. Also remove the now unnecessary .ndo_get_stats function. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/intel/igbvf/igbvf.h | 1 -

Re: [PATCH 4/4] mtd: nand: nandsim: convert to memalloc_noreclaim_*()

2017-04-06 Thread Adrian Hunter
On 05/04/17 14:39, Vlastimil Babka wrote: > On 04/05/2017 01:36 PM, Richard Weinberger wrote: >> Michal, >> >> Am 05.04.2017 um 13:31 schrieb Michal Hocko: >>> On Wed 05-04-17 09:47:00, Vlastimil Babka wrote: Nandsim has own functions set_memalloc() and clear_memalloc() for robust

<    1   2   3