Re: [PATCH net-next RFC] Generic XDP

On Sat, Apr 8, 2017 at 11:07 PM, David Miller wrote: > > This provides a generic non-optimized XDP implementation when the > device driver does not provide an optimized one. > > It is arguable that perhaps I should have required something like > this as part of the initial

[PATCH net-next 7/7] ibmvnic: Remove inflight list

The inflight list used to track memory that is allocated for crq that are inflight is not needed. The one piece of the inflight list that does need to be cleaned at module exit is the error buffer list which is already attached to the adapter struct. This patch removes the inflight list and moves

[PATCH net-next 6/7] ibmvnic: Do not disable IRQ after scheduling tasklet

From: Brian King Since the primary CRQ is only used for service functions and not in the performance path, simplify the code a bit and avoid disabling the IRQ. Signed-off-by: Brian King Signed-off-by: Nathan Fontenot

[PATCH net-next 3/7] ibmvnic: Fix ibmvnic_change_mac_addr struct format

From: Murilo Fossa Vicentini The ibmvnic_change_mac_addr struct alignment was not matching the defined format in PAPR+, it had the reserved and return code fields swapped. As a consequence, the CHANGE_MAC_ADDR_RSP commands were being improperly handled and executed even

[PATCH net-next 5/7] ibmvnic: Fixup atomic API usage

From: Brian King Replace a couple of modifications of an atomic followed by a read of the atomic, which is no longer atomic, to use atomic_XX_return variants to avoid race conditions. Signed-off-by: Brian King Signed-off-by: Nathan Fontenot

[PATCH net-next 4/7] ibmvnic: Unmap longer term buffer before free

From: Brian King Make sure we unregister long term buffers from the adapter prior to DMA unmapping it and freeing the buffer. Failure to do so could result in a DMA to a now invalid address. Signed-off-by: Brian King Signed-off-by: Nathan

[PATCH net-next 0/7] ibmvnic: Assorted driver updates

This is a set of updates to the ibmvnic driver to fix severalbugs in the ibmvnic driver. Patch 1/7: Add is_up flag to avoid sending packets when drivern is down Patch 2/7: Report errors releasing sub-crqs Patch 3/7: Correct change_mac_addr struct format Patch 4/7: Unmap long term buffers before

[PATCH net-next 2/7] ibmvnic: Report errors when failing to release sub-crqs

From: Thomas Falcon Add reporting of errors when releasing sub-crqs fails. Signed-off-by: Thomas Falcon Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |6 ++ 1 file changed, 6

[PATCH net-next 1/7] ibmvnic: Add is_up flag to avoid transmits when driver is down

From: Thomas Falcon There are brief windows when handling events such as failover where we could attempt to transmit packets between receiving the transport event notification and handling the reset in the workqueue. This patch introduces an is_up flag so we can

[PATCH net-next RFC] Generic XDP

This provides a generic non-optimized XDP implementation when the device driver does not provide an optimized one. It is arguable that perhaps I should have required something like this as part of the initial XDP feature merge. I believe this is critical for two reasons: 1) Accessibility.

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

On 4/8/17 9:36 PM, Vlad Yasevich wrote: > On 04/07/2017 05:25 PM, David Ahern wrote: >> Changing MTU on a link currently causes 3 messages to be sent to userspace: >> >> [LINK]11: dummy1: mtu 1490 qdisc noqueue state >> UNKNOWN group default event PRE_CHANGE_MTU >>

Re: [PATCH v3 iproute] ip: Add support for netdev events to monitor

On 4/8/17 10:33 PM, David Miller wrote: > From: David Ahern > Date: Sat, 8 Apr 2017 18:24:06 -0400 > >> per comments on the email thread about reducing notifications, the >> kernel patch for this should be reverted (and hence this iproute2 patch >> is not needed) in

Re: [PATCH v3 iproute] ip: Add support for netdev events to monitor

From: David Ahern Date: Sat, 8 Apr 2017 18:24:06 -0400 > per comments on the email thread about reducing notifications, the > kernel patch for this should be reverted (and hence this iproute2 patch > is not needed) in favor of using a bitmask. Right now there are too

Re: [PATCH net-next 7/8] rtnetlink: Do not generate notifications for NOTIFY_PEERS event

On 04/07/2017 05:25 PM, David Ahern wrote: > NOTIFY_PEERS is an internal event; do not generate userspace > notifications. We actually need this event to support macvtap over bonding as well as to resolve some issues with VMs using a bonded uplink on the host. -vlad > > Signed-off-by: David

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

On 04/07/2017 05:25 PM, David Ahern wrote: > Changing MTU on a link currently causes 3 messages to be sent to userspace: > > [LINK]11: dummy1: mtu 1490 qdisc noqueue state > UNKNOWN group default event PRE_CHANGE_MTU > link/ether f2:52:5c:6d:21:f3 brd

[PATCH net-next,3/3] hv_netvsc: Exclude non-TCP port numbers from vRSS hashing

From: Haiyang Zhang Azure hosts are not supporting non-TCP port numbers in vRSS hashing for now. For example, UDP packet loss rate will be high if port numbers are also included in vRSS hash. So, we created this patch to use only IP numbers for hashing in non-TCP

[PATCH net-next,1/3] hv_netvsc: Use per socket hash when available

From: Haiyang Zhang The per socket hash is set when a socket is connected. Use it, when available, to save CPU cycles on repeatedly computing hash on the same connection. Signed-off-by: Haiyang Zhang Reviewed-by: Stephen Hemminger

[PATCH net-next,2/3] hv_netvsc: Fix the queue index computation in forwarding case

From: Haiyang Zhang If the outgoing skb has a RX queue mapping available, we use the queue number directly, other than put it through Send Indirection Table. Signed-off-by: Haiyang Zhang Reviewed-by: Stephen Hemminger ---

Performance regression on loopback devices when qdiscs are attached in 4.4

Hello, I apologize if this is the wrong list to report this bug to, I did not find a more specific listing in the maintainers file. I think this is a kernel issue and not an issue with my distro, but if you disagree I can re-direct this report as appropriate. I am upgrading some Linux 4.2

Horrid balance-rr bonding udp throughput

I'm digging into some bug reports covering performance issues with balance-rr, and discovered something even worse than the reporter. My test setup has a pair of NICs, one e1000e, one e1000 (but dual e1000e seems the same). When I do a test run in LNST with bonding mode balance-rr and either

Re: [RFC net-next] bpf: taint loading !is_gpl programs

On Fri, Apr 07, 2017 at 01:46:28PM -0400, Aaron Conole wrote: > Hi Alexei, and Daniel, > > Alexei Starovoitov writes: > > > On Wed, Apr 05, 2017 at 10:59:49PM -0400, Aaron Conole wrote: > >> Hi Daniel, > >> > >> Daniel Borkmann writes: > >>

Re: [PATCH v3 iproute] ip: Add support for netdev events to monitor

On 4/4/17 9:25 AM, Vladislav Yasevich wrote: > Add IFLA_EVENT handling so that event types can be viewed with > 'monitor' command. This gives a little more information for why > a given message was receivied. > > Signed-off-by: Vladislav Yasevich > --- >

Re: [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison

Hi Arushi, [auto build test WARNING on ipvs-next/master] [also build test WARNING on v4.11-rc5 next-20170407] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH net-next] bpf: fix comment typo

On 04/08/2017 10:08 PM, Alexander Alemayhu wrote: o s/bpf_bpf_get_socket_cookie/bpf_get_socket_cookie Signed-off-by: Alexander Alemayhu Acked-by: Daniel Borkmann

[PATCH] net: rfkill: gpio: Add OBDA8723 ACPI HID

The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets for bluetooth rfkill functionality. Tested-by: russianneuroman...@ya.ru Signed-off-by: Hans de Goede --- net/rfkill/rfkill-gpio.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH net-next v2 0/3] net: dsa: Receive path simplifications

From: Florian Fainelli Date: Sat, 8 Apr 2017 08:55:20 -0700 > This patch series does factor the common code found in all tag implementations > into dsa_switch_rcv(). The original motivation was to add GRO support, but > this > may be a lot of work with unclear benefits at

Non-standard TCP stack processing of packets with unacceptable ACK numbers

Hello, My name is Paul Fiterau, I am a PhD student at Radboud University whose focus for the past few years has been among others to develop and apply inference techniques on TCP stacks in order to obtain nice models, and to verify them if possible using formal methods. We contacted you on

[PATCH v3 2/5] genetlink: pass extended ACK report down

From: Johannes Berg Pass the extended ACK reporting struct down from generic netlink to the families, using the existing struct genl_info for simplicity. Also add support to set the extended ACK information from generic netlink users. Signed-off-by: Johannes Berg

[PATCH v3 5/5] netlink: pass extended ACK struct where available

From: Johannes Berg This is an add-on to the previous patch that passes the extended ACK structure where it's already available by existing genl_info or extack function arguments. This was done with this spatch (with some manual adjustment of indentation): @@

Re: [PATCH net] netfilter: xt_TCPMSS: add more sanity tests on tcph->doff

On Mon, Apr 03, 2017 at 10:55:11AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > Denys provided an awesome KASAN report pointing to an use > after free in xt_TCPMSS > > I have provided three patches to fix this issue, either in xt_TCPMSS or > in xt_tcpudp.c. It seems

[PATCH v3 3/5] netlink: allow sending extended ACK with cookie on success

From: Johannes Berg Now that we have extended error reporting and a new message format for netlink ACK messages, also extend this to be able to return arbitrary cookie data on success. This will allow, for example, nl80211 to not send an extra message for cookies

[PATCH v3 1/5] netlink: extended ACK reporting

From: Johannes Berg Add the base infrastructure and UAPI for netlink extended ACK reporting. All "manual" calls to netlink_ack() pass NULL for now and thus don't get extended ACK reporting. Big thanks goes to Pablo Neira Ayuso for not only bringing up the whole topic at

[PATCH v3 4/5] netlink: pass extended ACK struct to parsing functions

From: Johannes Berg Pass the new extended ACK reporting struct to all of the generic netlink parsing functions. For now, pass NULL in almost all callers (except for some in the core.) Signed-off-by: Johannes Berg --- crypto/crypto_user.c

[PATCH v3 0/5] netlink extended ACK reporting

Changes since v2: * add NUM_NLMSGERR_ATTRS, NLMSGERR_ATTR_MAX * fix cookie length to 20 (sha-1 length) * move struct members for cookie to patch 3 where they should be * another cleanup suggested by David Ahern johannes

Re: [PATCH 4/5] netlink: pass extended ACK struct to parsing functions

On Sat, 2017-04-08 at 14:50 -0400, David Ahern wrote: > On 4/8/17 1:48 PM, Johannes Berg wrote: > > From: Johannes Berg > > > > Pass the new extended ACK reporting struct to all of the > > generic netlink parsing functions. For now, pass NULL in > > almost all callers

Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

On Sat, Apr 08, 2017 at 08:21:56PM +0200, Jan Engelhardt wrote: > On Saturday 2017-04-08 19:21, Arushi Singhal wrote: > > >Replace explicit NULL comparison with ! operator to simplify code. > > I still wouldn't do this, for the same reason as before. Comparing to > NULL explicitly more or less

Re: [PATCH 1/5] netlink: extended ACK reporting

On 4/8/17 1:48 PM, Johannes Berg wrote: > diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h > index f3946a27bd07..d1564557d645 100644 > --- a/include/uapi/linux/netlink.h > +++ b/include/uapi/linux/netlink.h > @@ -101,6 +101,29 @@ struct nlmsghdr { > struct nlmsgerr { >

Re: [PATCH 1/5] netlink: extended ACK reporting

On Sat, 2017-04-08 at 20:40 +0200, Jiri Pirko wrote: > > I think I'll leave it like this - if anyone really wants to say > > "attribute 0 is missing" then we can add a flag later... The UAPI > > does > > take this into account by not including the attribute at all if the > > data is invalid, so 0

Re: [PATCH] net: ipv6: Remove unneccessary comments

On Sat, Apr 08, 2017 at 09:19:30PM +0530, Arushi Singhal wrote: > This comments are obsolete and should go, as there are no set of rules per > CPU anymore. Applied, thanks.

[PATCH net-next] bpf: fix comment typo

o s/bpf_bpf_get_socket_cookie/bpf_get_socket_cookie Signed-off-by: Alexander Alemayhu --- include/uapi/linux/bpf.h | 2 +- tools/include/uapi/linux/bpf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/bpf.h

[PATCH net-next v2] net: allow configuring default qdisc

Since 3.12 it has been possible to configure the default queuing discipline via sysctl. This patch adds ability to configure the default queue discipline in kernel configuration. This is useful for environments where configuring the value from userspace is difficult to manage. The default is

Re: [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int.

From: Eric Dumazet Date: Sat, 08 Apr 2017 11:55:32 -0700 > On Sat, 2017-04-08 at 20:36 +0200, Steffen Klassert wrote: >> All available gso_type flags are currently in use, so >> extend gso_type from 'unsigned short' to 'unsigned int' >> to be able to add further flags. >>

Re: [PATCH net-next] net_sched: allow configuring default qdisc

On Sat, 2017-04-08 at 14:50 -0400, Stephen Hemminger wrote: > Since 3.12 it has been possible to configure the default queuing discipline > via sysctl. This patch adds ability to configure the default queue discipline > in kernel configuration. This is useful for environments where configuring >

Re: [PATCH v2 3/5] netlink: allow sending extended ACK with cookie on success

since a v3 is coming another small cleanup ... On 4/8/17 2:34 PM, Johannes Berg wrote: > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > index c74f56a4fcf1..98e55a59c97e 100644 > --- a/net/netlink/af_netlink.c > +++ b/net/netlink/af_netlink.c > @@ -2336,20 +2339,27 @@ void

XDP Newbies...

I've created a new mailing list: xdp-newb...@vger.kernel.org Which is a place where people can talk about getting up to speed with setting up an XDP build environment and writing XDP programs. Please spread the word!

Re: [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int.

On Sat, 2017-04-08 at 20:36 +0200, Steffen Klassert wrote: > All available gso_type flags are currently in use, so > extend gso_type from 'unsigned short' to 'unsigned int' > to be able to add further flags. > > We reorder the struct skb_shared_info to use > two bytes of the four byte hole before

[PATCH net-next] net_sched: allow configuring default qdisc

Since 3.12 it has been possible to configure the default queuing discipline via sysctl. This patch adds ability to configure the default queue discipline in kernel configuration. This is useful for environments where configuring the value from userspace is difficult to manage. The default is

Re: [PATCH 4/5] netlink: pass extended ACK struct to parsing functions

On 4/8/17 1:48 PM, Johannes Berg wrote: > From: Johannes Berg > > Pass the new extended ACK reporting struct to all of the > generic netlink parsing functions. For now, pass NULL in > almost all callers (except for some in the core.) > > Signed-off-by: Johannes Berg

Re: [PATCH] ibmveth: Support to enable LSO/CSO for Trunk VEA.

From: Sivakumar Krishnasamy Date: Fri, 7 Apr 2017 05:57:59 -0400 > Enable largesend and checksum offload for ibmveth configured in trunk mode. > Added support to SKB frag_list in TX path by skb_linearize'ing such SKBs. > > Signed-off-by: Sivakumar Krishnasamy

Re: [PATCH 1/5] netlink: extended ACK reporting

Sat, Apr 08, 2017 at 08:37:01PM CEST, johan...@sipsolutions.net wrote: >On Sat, 2017-04-08 at 20:34 +0200, Jiri Pirko wrote: >> nla_total_size(sizeof(u32)); >> > + if (extack && >> > + (extack->missing_attr || extack- >> > >bad_attr)) >> >> Attr could be 0,

Re: [PATCH 1/5] netlink: extended ACK reporting

On Sat, 2017-04-08 at 14:36 -0400, David Ahern wrote: > > I think v3 is in your future ... > > /home/dsa/kernel-4.git/include/linux/netlink.h:78:12: error: > ‘NETLINK_MAX_COOKIE_LEN’ undeclared here (not in a function) >   u8 cookie[NETLINK_MAX_COOKIE_LEN]; > ^ > > it's defined in

Re: [PATCH 1/5] netlink: extended ACK reporting

On Sat, 2017-04-08 at 20:34 +0200, Jiri Pirko wrote: > nla_total_size(sizeof(u32)); > > + if (extack && > > + (extack->missing_attr || extack- > > >bad_attr)) > > Attr could be 0, right? I know that on the most of the places 0 is > UNSPEC, but I'm pretty

[PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int.

All available gso_type flags are currently in use, so extend gso_type from 'unsigned short' to 'unsigned int' to be able to add further flags. We reorder the struct skb_shared_info to use two bytes of the four byte hole before dataref. All fields before dataref are cleared, i.e. four bytes more

Re: [PATCH 1/5] netlink: extended ACK reporting

On 4/8/17 1:48 PM, Johannes Berg wrote: > diff --git a/include/linux/netlink.h b/include/linux/netlink.h > index da14ab61f363..47562e940e9c 100644 > --- a/include/linux/netlink.h > +++ b/include/linux/netlink.h > @@ -62,11 +62,41 @@ netlink_kernel_create(struct net *net, int unit, struct >

[PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int

We need a GSO type for IPsec ESP to be able to integrate the IPsec hardware offloading infrastructure. Unfortunately, all gso_type flags are currently in use. This change extends gso_type from 'unsigned short' to 'unsigned int'. Changes from v1: - Place the remaining two byte hole in front,

[PATCH v2 4/5] netlink: pass extended ACK struct to parsing functions

From: Johannes Berg Pass the new extended ACK reporting struct to all of the generic netlink parsing functions. For now, pass NULL in almost all callers (except for some in the core.) Signed-off-by: Johannes Berg --- crypto/crypto_user.c

[PATCH v2 1/5] netlink: extended ACK reporting

From: Johannes Berg Add the base infrastructure and UAPI for netlink extended ACK reporting. All "manual" calls to netlink_ack() pass NULL for now and thus don't get extended ACK reporting. Big thanks goes to Pablo Neira Ayuso for not only bringing up the whole topic at

[PATCH v2 2/5] genetlink: pass extended ACK report down

From: Johannes Berg Pass the extended ACK reporting struct down from generic netlink to the families, using the existing struct genl_info for simplicity. Also add support to set the extended ACK information from generic netlink users. Signed-off-by: Johannes Berg

[PATCH v2 5/5] netlink: pass extended ACK struct where available

From: Johannes Berg This is an add-on to the previous patch that passes the extended ACK structure where it's already available by existing genl_info or extack function arguments. This was done with this spatch (with some manual adjustment of indentation): @@

[PATCH v2 3/5] netlink: allow sending extended ACK with cookie on success

From: Johannes Berg Now that we have extended error reporting and a new message format for netlink ACK messages, also extend this to be able to return arbitrary cookie data on success. This will allow, for example, nl80211 to not send an extra message for cookies

[PATCH v2 0/5]

Changes since v1: * credit Pablo and Jamal * incorporate suggestion from David Ahern * fix compilation in decnet

Re: [PATCH 1/5] netlink: extended ACK reporting

Sat, Apr 08, 2017 at 07:48:56PM CEST, johan...@sipsolutions.net wrote: >From: Johannes Berg > >Add the base infrastructure and UAPI for netlink >extended ACK reporting. All "manual" calls to >netlink_ack() pass NULL for now and thus don't >get extended ACK reporting. Why

Re: [PATCH 1/5] netlink: extended ACK reporting

On 4/8/17 1:48 PM, Johannes Berg wrote: > @@ -2267,21 +2284,37 @@ int __netlink_dump_start(struct sock *ssk, struct > sk_buff *skb, > } > EXPORT_SYMBOL(__netlink_dump_start); > > -void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err) > +void netlink_ack(struct sk_buff

Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

On Saturday 2017-04-08 19:21, Arushi Singhal wrote: >Replace explicit NULL comparison with ! operator to simplify code. I still wouldn't do this, for the same reason as before. Comparing to NULL explicitly more or less gave an extra guarantee that the other operand was also a pointer.

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

On 4/8/17, 11:13 AM, David Ahern wrote: > On 4/8/17 2:06 PM, Roopa Prabhu wrote: >> On 4/7/17, 2:25 PM, David Ahern wrote: >>> Changing MTU on a link currently causes 3 messages to be sent to userspace: >>> >>> [LINK]11: dummy1: mtu 1490 qdisc noqueue >>> state

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

On 4/8/17 2:06 PM, Roopa Prabhu wrote: > On 4/7/17, 2:25 PM, David Ahern wrote: >> Changing MTU on a link currently causes 3 messages to be sent to userspace: >> >> [LINK]11: dummy1: mtu 1490 qdisc noqueue state >> UNKNOWN group default event PRE_CHANGE_MTU >>

Re: [PATCH net-next v2] can: initial support for network namespaces

Hi Mario, I started to convert the statistics ... but there's some code adaption missing in proc.c Is this the right way to start? diff --git a/include/net/netns/can.h b/include/net/netns/can.h index e8beba772f1a..a8866ae1788f 100644 --- a/include/net/netns/can.h +++

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

On 4/7/17, 2:25 PM, David Ahern wrote: > Changing MTU on a link currently causes 3 messages to be sent to userspace: > > [LINK]11: dummy1: mtu 1490 qdisc noqueue state > UNKNOWN group default event PRE_CHANGE_MTU > link/ether f2:52:5c:6d:21:f3 brd

Re: [PATCH 06/12] audit: Use timespec64 to represent audit timestamps

> I have no problem merging this patch into audit/next for v4.12, would > you prefer me to do that so at least this patch is merged? This would be fine. But, I think whoever takes the last 2 deletion patches should also take them. I'm not sure how that part works out. > It would probably make

[PATCH 5/5] netlink: pass extended ACK struct where available

From: Johannes Berg This is an add-on to the previous patch that passes the extended ACK structure where it's already available by existing genl_info or extack function arguments. This was done with this spatch (with some manual adjustment of indentation): @@

[PATCH 3/5] netlink: allow sending extended ACK with cookie on success

From: Johannes Berg Now that we have extended error reporting and a new message format for netlink ACK messages, also extend this to be able to return arbitrary cookie data on success. This will allow, for example, nl80211 to not send an extra message for cookies

[PATCH 1/5] netlink: extended ACK reporting

From: Johannes Berg Add the base infrastructure and UAPI for netlink extended ACK reporting. All "manual" calls to netlink_ack() pass NULL for now and thus don't get extended ACK reporting. Signed-off-by: Johannes Berg --- crypto/crypto_user.c

[PATCH 4/5] netlink: pass extended ACK struct to parsing functions

From: Johannes Berg Pass the new extended ACK reporting struct to all of the generic netlink parsing functions. For now, pass NULL in almost all callers (except for some in the core.) Signed-off-by: Johannes Berg --- crypto/crypto_user.c

[PATCH 0/5] extended netlink ACK reporting

Hi, After testing and fixing the ack message length calculation, this now works. The UAPI changes are like before - the ACK message format becomes [nlmsg header] [ack header] [request nlmsg header] [request nlmsg body (already optional) - length aligned] [extended ACK TLVs - this is NEW]

[PATCH 2/5] genetlink: pass extended ACK report down

From: Johannes Berg Pass the extended ACK reporting struct down from generic netlink to the families, using the existing struct genl_info for simplicity. Also add support to set the extended ACK information from generic netlink users. Signed-off-by: Johannes Berg

Re: [PATCH net-next v2] can: initial support for network namespaces

Hello Mario, unfortunately Marc pushed this patch before I finally was able to review it ... :-( Some questions: On 02/21/2017 12:19 PM, Mario Kicherer wrote: This patch adds initial support for network namespaces. The changes only enable support in the CAN raw, proc and af_can code. GW and

[PATCH] net: netfilter: Replace explicit NULL comparisons

Replace explicit NULL comparison with ! operator to simplify code. Signed-off-by: Arushi Singhal --- net/netfilter/nf_conntrack_broadcast.c | 2 +- net/netfilter/nf_conntrack_core.c | 2 +- net/netfilter/nf_conntrack_ecache.c| 4 +--

[PATCH] net: netfilter: ipvs: Replace explicit NULL comparison

Replace explicit NULL comparison to simplify code. Signed-off-by: Arushi Singhal --- net/netfilter/ipvs/ip_vs_ctl.c | 40 net/netfilter/ipvs/ip_vs_proto.c | 22 +++--- 2 files changed, 31 insertions(+),

Re: pull-request: can 2017-04-04,Re: pull-request: can 2017-04-04

From: Marc Kleine-Budde Date: Fri, 7 Apr 2017 11:00:20 +0200 > Sorry. The "tag" some git lost, here it is: ... > git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git > tags/linux-can-fixes-for-4.12-20170404 Thanks, and pulled, but you probably meant to name

[PATCH 20/22] staging rtl8723bs: Fix indenting errors and an off-by-one mistake in core/rtw_mlme_ext.c

Smatch lists the following: CHECK drivers/staging/rtl8723bs/core/rtw_mlme_ext.c drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:525 _mgt_dispatcher() warn: inconsistent indenting drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1595 OnAssocReq() error: buffer overflow 'pstapriv->sta_aid' 32 <=

[PATCH 19/22] staging: rtl8723bs: Fix white-space errors in core/rtw_recv.c

Smart reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_recv.c drivers/staging/rtl8723bs/core/rtw_recv.c:598 portctrl() warn: inconsistent indenting drivers/staging/rtl8723bs/core/rtw_recv.c:838 sta2sta_data_frame() warn: inconsistent indenting

[PATCH 13/22] staging: rtl8723bs: Fix indenting mistake in core/rtw_ap.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_ap.c drivers/staging/rtl8723bs/core/rtw_ap.c:382 expire_timeout_chk() warn: inconsistent indenting Fixing this requires changing the indentatikon of a long for loop. Signed-off-by: Larry Finger

[PATCH 21/22] staging: rtl8723bs: Fix indenting problems in core/rtw_odm.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_odm.c drivers/staging/rtl8723bs/core/rtw_odm.c:109 rtw_odm_dbg_comp_msg() warn: if statement not indented drivers/staging/rtl8723bs/core/rtw_odm.c:146 rtw_odm_ability_msg() warn: if statement not indented Signed-off-by:

[PATCH 15/22] staging: rtl8723bs: Fix indenting mistakes in core/rtw_mlme.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_mlme.c drivers/staging/rtl8723bs/core/rtw_mlme.c:862 rtw_survey_event_callback() warn: inconsistent indenting drivers/staging/rtl8723bs/core/rtw_mlme.c:1102 rtw_free_assoc_resources() warn: if statement not indented

[PATCH 17/22] staging: rtl8723bs: Fix indenting problem in core/rtw_sta_mgt.c

Sparse reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_sta_mgt.c drivers/staging/rtl8723bs/core/rtw_sta_mgt.c:25 _rtw_init_stainfo() warn: inconsistent indenting This problem is fixed with a white-spcae change. Signed-off-by: Larry Finger ---

[PATCH 16/22] staging: rtl8723bs: Fix some indenting problems and a potential data overrun

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_wlan_util.c drivers/staging/rtl8723bs/core/rtw_wlan_util.c:67 cckrates_included() warn: if statement not indented drivers/staging/rtl8723bs/core/rtw_wlan_util.c:81 cckratesonly_included() warn: if statement not indented

[PATCH 18/22] staging: rtl8723bs: Fix some white-space errors in core/rtw_security.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_security.c drivers/staging/rtl8723bs/core/rtw_security.c:266 rtw_wep_encrypt() warn: inconsistent indenting drivers/staging/rtl8723bs/core/rtw_security.c:433 rtw_seccalctkipmic() warn: inconsistent indenting

[PATCH 22/22] staging: rtl8723bs: Fix indenting error in core/rtw_pwrctrl.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_pwrctrl.c drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:641 LeaveAllPowerSaveModeDirect() warn: inconsistent indenting Signed-off-by: Larry Finger ---

[PATCH 07/22] staging: rtl8723bs: Fix potential usage while NULL error in hal/rtl8723b_hal_init.c

Smatch logs the following: CHECK drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:518 rtl8723b_FirmwareDownload() error: we previously assumed 'pFirmware' could be null (see line 382) Fixing this error required a rewrite of the error exits

[PATCH 10/22] staging: rtl8723bs: Fix indenting problem for hal/hal_com.c

Smatch lists the following: CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090 Hal_ChannelPlanToRegulation() warn: inconsistent indenting Fixed by changing the white space. Signed-off-by: Larry Finger ---

[PATCH 14/22] staging: rtl8723bs: Fix indenting mistakes in core/rtw_ieee80211.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_ieee80211.c drivers/staging/rtl8723bs/core/rtw_ieee80211.c:83 rtw_is_cckrates_included() warn: if statement not indented drivers/staging/rtl8723bs/core/rtw_ieee80211.c:98 rtw_is_cckratesonly_included() warn: if statement

[PATCH 09/22] staging: rtl8723bs: Fix indening problem in hal/hal_com_phycfg.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090 Hal_ChannelPlanToRegulation() warn: inconsistent indenting This warning is fixed with a white-space change. Signed-off-by: Larry Finger

[PATCH 05/22] staging: rtl8723bs: Fix indenting mistake in os_dep/mlme_linux.c

Smatch reports the following warning: CHECK drivers/staging/rtl8723bs/os_dep/mlme_linux.c drivers/staging/rtl8723bs/os_dep/mlme_linux.c:149 rtw_os_indicate_disconnect() warn: inconsistent indenting Again, a simple change in the white space fixes this problem. Signed-off-by: Larry Finger

[PATCH 12/22] staging: rtl8723bs: Fix possible usage of NULL pointer in core/rtw_debug.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_debug.c drivers/staging/rtl8723bs/core/rtw_debug.c:454 proc_get_survey_info() error: we previously assumed 'phead' could be null (see line 453) drivers/staging/rtl8723bs/core/rtw_debug.c:455 proc_get_survey_info() warn:

[PATCH 06/22] staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c

Smatch lists the following: CHECK drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470 rtw_cfg80211_ibss_indicate_connect() error: we previously assumed 'scanned' could be null (see line 466)

[PATCH 08/22] staging: rtl8723bs: Fix indenting problems in hal/HalHWImg8723B_BB.c

Smatch lists the following: CHECK drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c:314 ODM_ReadAndConfig_MP_8723B_AGC_TAB() warn: for statement not indented drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c:583

[PATCH 11/22] staging: rtl8723bs: Fix indenting problems in core/rtw_xmit.c

Smatch logs the following: CHECK drivers/staging/rtl8723bs/core/rtw_xmit.c drivers/staging/rtl8723bs/core/rtw_xmit.c:277 _rtw_init_xmit_priv() warn: inconsistent indenting drivers/staging/rtl8723bs/core/rtw_xmit.c:294 _rtw_free_xmit_priv() warn: inconsistent indenting

[PATCH 01/22] staging: rtl8723bs: Fix indenting warning in os_dep/xmit_linux.c

Smatch issues the warning CHECK drivers/staging/rtl8723bs/os_dep/xmit_linux.c drivers/staging/rtl8723bs/os_dep/xmit_linux.c:42 _rtw_pktfile_read() warn: inconsistent indenting A simple indent changes fixes this. Signed-off-by: Larry Finger ---

[PATCH 02/22] staging: rtl8723bs: Fix indenting warning in os_dep/rtw_proc.c

Smatch lists the following warning: CHECK drivers/staging/rtl8723bs/os_dep/rtw_proc.c drivers/staging/rtl8723bs/os_dep/rtw_proc.c:102 rtw_drv_proc_open() warn: inconsistent indenting This warning is fixed with a simple change in the white space. Signed-off-by: Larry Finger

[PATCH 03/22] staging: rtl8723bs: Fix dereference before check warning in os_dep/recv_linux.c

Smatch lists the following warning: CHECK drivers/staging/rtl8723bs/os_dep/recv_linux.c drivers/staging/rtl8723bs/os_dep/recv_linux.c:353 rtw_recv_indicatepkt() warn: variable dereferenced before check 'precv_frame' (see line 312) This warning is fixed by removing the test at line 353.

  1   2   >