Re: ipsec doesn't route TCP with 4.11 kernel

On 3 May 2017 at 04:14, Steffen Klassert wrote: > On Sat, Apr 29, 2017 at 08:39:34PM -0400, Don Bowman wrote: >> On 28 April 2017 at 03:13, Steffen Klassert >> wrote: >> > On Thu, Apr 27, 2017 at 06:13:38PM -0400, Don Bowman wrote: >>

Re: [PATCH 1/2] net-next: stmmac: add adjust_link function

On Tue, May 16, 2017 at 09:43:04AM -0700, Florian Fainelli wrote: > On 05/15/2017 04:41 AM, Corentin Labbe wrote: > > My dwmac-sun8i serie will add some if (has_sun8i) to > > stmmac_adjust_link() > > Since the current stmmac_adjust_link() alreaady have lots of if > > (has_gmac/gmac4), > > It is

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

From: Doug Ledford Date: Tue, 16 May 2017 14:03:22 -0400 > On Tue, 2017-05-16 at 13:36 -0400, David Miller wrote: >> From: Doug Ledford >> Date: Tue, 16 May 2017 13:20:44 -0400 >> >> > Anyway, we're just talking out what happened, when what we really

Re: [PATCH] net: Improve handling of failures on link and route dumps

From: David Ahern Date: Mon, 15 May 2017 23:19:17 -0700 > In general, rtnetlink dumps do not anticipate failure to dump a single > object (e.g., link or route) on a single pass. As both route and link > objects have grown via more attributes, that is no longer a given. > >

Re: [PATCH V3 net 1/1] smc: switch to usage of IB_PD_UNSAFE_GLOBAL_RKEY

From: Ursula Braun Date: Mon, 15 May 2017 17:33:37 +0200 > Currently, SMC enables remote access to physical memory when a user > has successfully configured and established an SMC-connection until ten > minutes after the last SMC connection is closed. Because this is

Re: [PATCH net v1] net/smc: Add warning about remote memory exposure

From: Leon Romanovsky Date: Tue, 16 May 2017 09:51:38 +0300 > From: Christoph Hellwig > > The driver explicitly bypasses APIs to register all memory once a > connection is made, and thus allows remote access to memory. > > Signed-off-by: Christoph Hellwig

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

| From: Ding Tianhong | Sent: Wednesday, May 10, 2017 6:15 PM | | Hi Casey: | | Will you continue to work on this solution or send a new version patches? I won't be able to work on this any time soon given several other urgent issues. If you've got a desire to pick this

[PATCH net-next] ipv6: Prevent overrun when parsing v6 header options

From: Craig Gallek The KASAN warning repoted below was discovered with a syzkaller program. The reproducer is basically: int s = socket(AF_INET6, SOCK_RAW, NEXTHDR_HOP); send(s, _byte_of_data, 1, MSG_MORE); send(s, _than_mtu_bytes_data, 2000, 0); The socket() call sets

Re: [PATCH] xen/9pfs: fix return value check in xen_9pfs_front_probe()

On Tue, 16 May 2017, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function xenbus_read() returns ERR_PTR() and never > returns NULL. The NULL test in the return value check should be replaced > with IS_ERR(). > > Fixes: 71ebd71921e4 ("xen/9pfs:

[PATCH net-next] liquidio: fix PF falsely indicating success at setting MAC address of a nonexistent VF

In the function assigned to .ndo_set_vf_mac, check the validity of the vfidx argument before proceeding to tell the firmware to set the VF MAC address. Signed-off-by: Felix Manlunas Signed-off-by: Derek Chickles ---

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

Jim Baxter writes: > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources but wish to maximise the throughput of

Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index

On Tue, 16 May 2017 19:29:35 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Allow user to put filter to a specific chain identified by index. > > Signed-off-by: Jiri Pirko This will have to wait for the chain bits to show up upstream

Re: [Patch net] ipv4: restore rt->fi for reference counting

On Tue, May 16, 2017 at 10:53 AM, Cong Wang wrote: > How about adding a check for ->fib_dead in these work's? > If the last treeref is gone, probably it is no longer needed > to continue to do the offloading work. Hmm, this doesn't look correct either, we may miss an

[PATCH net-next] liquidio: fix insmod failure when multiple NICs are plugged in

From: Rick Farrington When multiple liquidio NICs are plugged in, the first insmod of the PF driver succeeds. But after an rmmod, a subsequent insmod fails. Reason is during rmmod, the PF driver resets the Octeon of only one of the NICs; it neglects to reset the

[PATCH net-next] net: dsa: store CPU port pointer in the tree

A dsa_switch_tree instance holds a dsa_switch pointer and a port index to identify the switch port to which the CPU is attached. Now that the DSA layer has a dsa_port structure to hold this data, use it to point the switch CPU port. This patch simply substitutes

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

On Tue, 2017-05-16 at 13:36 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 13:20:44 -0400 > > > Anyway, we're just talking out what happened, when what we really > need > > to focus on is moving forward.  Again, your thoughts on marking SMC > >

Re: [Patch net] ipv4: restore rt->fi for reference counting

On Tue, May 16, 2017 at 12:46 AM, Julian Anastasov wrote: > > Hello, > > On Mon, 15 May 2017, Cong Wang wrote: > >> On Mon, May 15, 2017 at 1:37 PM, Julian Anastasov wrote: >> > Any user that does not set FIB_LOOKUP_NOREF >> > will need nh_dev refcounts.

Re: cxgb4 is broken in v4.12-rc1

Hey, Ok, yes with the latest firmware the issue seems to have gone away. Still, it's probably not a great idea to break peoples hardware with a kernel update even if their firmware is old. Thanks, Logan On 16/05/17 09:19 AM, Ganesh GR wrote: > > Hi Logan, > > The latest firmware available

[RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

The CDC-NCM driver can require large amounts of memory to create skb's and this can be a problem when the memory becomes fragmented. This especially affects embedded systems that have constrained resources but wish to maximise the throughput of CDC-NCM with 16KiB NTB's. The issue is after

[RFC V1 0/1] Reduce cdc_ncm memory use when kernel memory low

Please review this patch Problem --- We are using an ARM embedded platform and require 16KiB NTB's to allow for fast data transfer. Unfortunately we have found that there are times after running the kernel for a while and transferring a lot of data over the CDC-NCM connection that it can

[patch net-next 09/12] mlxsw: spectrum_switchdev: Don't batch STP operations

From: Ido Schimmel Simplify the code by using the common function that sets an STP state for a Port-VLAN and remove the existing one that tries to batch it for several VLANs. This will help us in a follow-up patchset to introduce a unified infrastructure for bridge ports,

[patch net-next 05/12] mlxsw: spectrum_router: Move FIB notification block to router struct

From: Ido Schimmel The FIB notification block logically belongs inside the router specific struct, so move it there. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.h|

[patch net-next 04/12] mlxsw: spectrum_router: Move RIFs array to its rightful place

From: Ido Schimmel The router interfaces (RIFs) array is of no interest to code outside the routing realm, so declare it inside the router specific struct instead of the chip-wide one. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 08/12] mlxsw: spectrum_switchdev: Don't batch VLAN operations

From: Ido Schimmel switchdev's VLAN object has the ability to describe a range of VLAN IDs, but this is only used when VLAN operations are done using the SELF flag, which is something we would like to remove as it allows one to bypass the bridge driver. Do VLAN operations

[patch net-next 12/12] mlxsw: spectrum: Default ports to non-virtual mode

From: Ido Schimmel In virtual mode, packets are classified to FIDs based on their ingress port and VLAN whereas in non-virtual mode only the VLAN is taken into account. Currently ports are initialized to use virtual mode due to the presence of the PVID vPort. However, we're

[patch net-next 11/12] mlxsw: spectrum: Move PVID code to appropriate place

From: Ido Schimmel PVID is a port attribute and should therefore reside in the main driver file and not the switchdev specific one. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

[patch net-next 02/12] mlxsw: spectrum_router: Reduce scope of router struct

From: Ido Schimmel In a similar fashion to previous patch, the router structure ('mlxsw_sp_router') doesn't need to be accessible to anyone, but the router code located at spectrum_router.c Make this apparent and reduce its scope by defining it there. Signed-off-by: Ido

[patch net-next 06/12] mlxsw: spectrum_router: Initialize RIFs in a separate function

From: Ido Schimmel The router interfaces (RIFs) array is currently initialized together with the general router configuration. However, in a follow-up patchset we're going to introduce a common RIF core that will require us to initialize more RIF constructs, so move the RIF

[patch net-next 10/12] mlxsw: spectrum_switchdev: Don't batch learning operations

From: Ido Schimmel We no longer batch VLAN operations, so there's no need to set the learning state for a range of VLANs. Use a common function to set the learning state for a Port-VLAN, thereby making the code saner more receptive for upcoming changes. Signed-off-by: Ido

[patch net-next 03/12] mlxsw: spectrum_switchdev: Reduce scope of bridge struct

From: Ido Schimmel Some attributes in the global chip struct are only relevant for bridge operation, so encapsulate them in their own struct that isn't exposed to non-bridge code. This will also help us later, when we add more bridge-specific attributes. Signed-off-by: Ido

[patch net-next 01/12] mlxsw: spectrum_buffer: Reduce scope of shared buffer struct

From: Ido Schimmel The shared buffer structure ('mlxsw_sp_sb') doesn't need to be accessible to anyone, but the shared buffer code located at spectrum_buffers.c Make this apparent and reduce its scope by defining it there. Signed-off-by: Ido Schimmel

[patch net-next 00/12] mlxsw: Preparations for restructuring

From: Jiri Pirko This patchset doesn't introduce any functional changes and merely meant to make the code base more receptive for upcoming restructuring. The first six patches mainly shuffle code in order to reduce the scope of structs that shouldn't be defined in the main

[patch net-next 07/12] mlxsw: spectrum_switchdev: Remove redundant check

From: Ido Schimmel Since commit 97c242902c20 ("switchdev: Execute bridge ndos only for bridge ports") switchdev code checks that port is bridged, so no need to perform the same check in the driver. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

From: Doug Ledford Date: Tue, 16 May 2017 13:20:44 -0400 > Anyway, we're just talking out what happened, when what we really need > to focus on is moving forward.  Again, your thoughts on marking SMC > EXPERIMENTAL until it's fixed up and unfreezing the API in case we need >

[patch iproute2 v2 repost 2/3] tc: actions: add helpers to parse and print control actions

From: Jiri Pirko Each tc action is terminated by a control action. Each action parses and prints then intividually. Introduce set of helpers and allow to share this code. Signed-off-by: Jiri Pirko --- tc/m_bpf.c| 8 ++-- tc/m_connmark.c | 4

[patch iproute2 v2 repost 1/3] tc_filter: add support for chain index

From: Jiri Pirko Allow user to put filter to a specific chain identified by index. Signed-off-by: Jiri Pirko --- include/linux/rtnetlink.h | 1 + tc/tc_filter.c| 87 +++ 2 files changed, 73

[patch iproute2 v2 repost 3/3] tc/actions: introduce support for goto chain action

From: Jiri Pirko Allow user to set control action "goto" with filter chain index as a parameter. Signed-off-by: Jiri Pirko --- include/linux/pkt_cls.h | 16 +++- man/man8/tc-ife.8 | 2 +- man/man8/tc-pedit.8 | 2 +-

[patch net-next v3 07/10] net: sched: push chain dump to a separate function

From: Jiri Pirko Since there will be multiple chains to dump, push chain dumping code to a separate function. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 95 + 1 file changed, 52 insertions(+),

[patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

From: Jiri Pirko Call the helper from the function rather than to always adjust the return value of the function. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_api.c

[patch net-next v3 08/10] net: sched: introduce multichain support for filters

From: Jiri Pirko Instead of having only one filter per block, introduce a list of chains for every block. Create chain 0 by default. UAPI is extended so the user can specify which chain he wants to change. If the new attribute is not specified, chain 0 is used. That allows to

[patch net-next v3 09/10] net: sched: push tp down to action init

From: Jiri Pirko Tp pointer will be needed by the next patch in order to get the chain. Signed-off-by: Jiri Pirko --- include/net/act_api.h | 12 ++-- net/sched/act_api.c | 15 --- net/sched/cls_api.c | 9 + 3 files

[patch net-next v3 06/10] net: sched: introduce helpers to work with filter chains

From: Jiri Pirko Introduce struct tcf_chain object and set of helpers around it. Wraps up insertion, deletion and search in the filter chain. Signed-off-by: Jiri Pirko --- include/net/sch_generic.h | 7 ++- net/sched/cls_api.c | 148

[patch net-next v3 04/10] net: sched: replace nprio by a bool to make the function more readable

From: Jiri Pirko The use of "nprio" variable in tc_ctl_tfilter is a bit cryptic and makes a reader wonder what is going on for a while. So help him to understand this priority allocation dance a litte bit better. Signed-off-by: Jiri Pirko ---

[patch net-next v3 03/10] net: sched: rename tcf_destroy_chain helper

From: Jiri Pirko Make the name consistent with the rest of the helpers around. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index

[patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c

From: Jiri Pirko Move tc_classify function to cls_api.c where it belongs, rename it to fit the namespace. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h| 9 + include/net/pkt_sched.h | 3 --- net/core/dev.c | 5 +++--

[patch net-next v3 10/10] net: sched: add termination action to allow goto chain

From: Jiri Pirko Introduce new type of termination action called "goto_chain". This allows user to specify a chain to be processed. This action type is then processed as a return value in tcf_classify loop in similar way as "reclassify" is, only it does not reset to the first

[patch net-next v3 02/10] net: sched: introduce tcf block infractructure

From: Jiri Pirko Currently, the filter chains are direcly put into the private structures of qdiscs. In order to be able to have multiple chains per qdisc and to allow filter chains sharing among qdiscs, there is a need for common object that would hold the chains. This

[patch net-next v3 00/10] net: sched: introduce multichain support for filters

From: Jiri Pirko Currently, each classful qdisc holds one chain of filters. This chain is traversed and each filter could be matched on, which may lead to execution of list of actions. One of such action could be "reclassify", which would "reset" the processing of the filter

Re: Advice on user space application integration with tc

On Mon, May 15, 2017 at 1:33 PM, Morgan Yang wrote: > I tried on both stock CentOS 7.3 and Ubuntu 16.04 and tc-skbmod was not > support (I built tc from the latest versions of iproute2). For tc-pedit, > examples from man tc-pedit such as "pedit ex munge" were not

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

On Tue, 2017-05-16 at 12:49 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 12:42:43 -0400 > > > On Tue, 2017-05-16 at 12:29 -0400, David Miller wrote: > >> From: Doug Ledford > >> Date: Tue, 16 May 2017 11:57:04 -0400 > >>  >

Re: [PATCH net v2] net: x25: fix one potential use-after-free issue

From: linzhang Date: Tue, 16 May 2017 11:52:54 +0800 > return rc; > -out_dev: > +out_proc: > + x25_unregister_sysctl(); > +out_sysctl: > unregister_netdevice_notifier(_dev_notifier); > -out_sock: > +out_dev: > + dev_remove_pack(_packet_type); >

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

On Tue, 2017-05-16 at 12:41 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 12:36:01 -0400 > > > On Tue, 2017-05-16 at 18:30 +0200, Christoph Hellwig wrote: > >> On Tue, May 16, 2017 at 12:29:23PM -0400, David Miller wrote: > >> >  > >> > I can't

'iw events' stops receiving events after a while on 4.9 + hacks

I have been keeping an 'iw events' program running with a perl script gathering its output and post-processing it. This has been working for several years on 4.7 and earlier kernels, but when testing on 4.9 overnight, I notice that 'iw events' is not showing any input. 'strace' shows that it

Re: [PATCH net-next 0/9] nfp: LSO, checksum and XDP datapath updates

From: Jakub Kicinski Date: Mon, 15 May 2017 17:55:14 -0700 > This series introduces a number of refinements to standard features > like LSO and checksum offload. Three major features are support for > CHECKSUM_COMPLETE, refinement of TSO handling and another small

Re: [PATCH] ipmr: vrf: Find VIFs using the actual device

From: Thomas Winter Date: Tue, 16 May 2017 10:14:44 +1200 > The skb->dev that is passed into ip_mr_input is > the loX device for VRFs. When we lookup a vif > for this dev, none is found as we do not create > vifs for loopbacks. Instead lookup a vif for the >

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

From: Doug Ledford Date: Tue, 16 May 2017 12:42:43 -0400 > On Tue, 2017-05-16 at 12:29 -0400, David Miller wrote: >> From: Doug Ledford >> Date: Tue, 16 May 2017 11:57:04 -0400 >> >> > Regardless though, I'm rather purturbed about this entire thing. >>

Re: [PATCH net] tcp: eliminate negative reordering in tcp_clean_rtx_queue

From: Soheil Hassas Yeganeh Date: Mon, 15 May 2017 17:05:47 -0400 > From: Soheil Hassas Yeganeh > > tcp_ack() can call tcp_fragment() which may dededuct the > value tp->fackets_out when MSS changes. When prior_fackets > is larger than tp->fackets_out,

Re: [PATCH 1/2] net-next: stmmac: add adjust_link function

On 05/15/2017 04:41 AM, Corentin Labbe wrote: > My dwmac-sun8i serie will add some if (has_sun8i) to > stmmac_adjust_link() > Since the current stmmac_adjust_link() alreaady have lots of if > (has_gmac/gmac4), > It is now better to create an adjust_link() function for each dwmac. Is it really,

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

On Tue, 2017-05-16 at 12:29 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 11:57:04 -0400 > > > Regardless though, I'm rather purturbed about this entire thing. >  If > > you are right that because this got into 4.11, it's now a done > deal, > >

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

From: Doug Ledford Date: Tue, 16 May 2017 12:36:01 -0400 > On Tue, 2017-05-16 at 18:30 +0200, Christoph Hellwig wrote: >> On Tue, May 16, 2017 at 12:29:23PM -0400, David Miller wrote: >> > >> > I can't push back on people with silly coding style and small >> > semantic >> >

Re: [PATCH 1/2] net-next: stmmac: add adjust_link function

From: Corentin Labbe Date: Mon, 15 May 2017 13:41:39 +0200 > My dwmac-sun8i serie will add some if (has_sun8i) to > stmmac_adjust_link() > Since the current stmmac_adjust_link() alreaady have lots of if > (has_gmac/gmac4), > It is now better to create an adjust_link()

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On Sat, 13 May 2017 19:29:57 -0600 David Ahern wrote: > On 5/4/17 2:43 PM, Phil Sutter wrote: > > So in summary, given that very little change happens to iproute2's > > internal libnetlink, I don't see much urge to make it use libmnl as > > backend. In my opinion it just adds

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

On Tue, 2017-05-16 at 18:30 +0200, Christoph Hellwig wrote: > On Tue, May 16, 2017 at 12:29:23PM -0400, David Miller wrote: > > > > I can't push back on people with silly coding style and small > > semantic > > issues forever.  And I think I made a serious effort to keep the > > patches getting

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

On Tue, May 16, 2017 at 12:33:08PM -0400, David Miller wrote: > That doesn't cover things that don't directly touch the RDMA code or > infiniband infrastructure. > > There should have been RDMA people on netdev who saw this thing and > cried wolf, and they would have had about an entire year, and

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

From: Christoph Hellwig Date: Tue, 16 May 2017 18:30:41 +0200 > On Tue, May 16, 2017 at 12:29:23PM -0400, David Miller wrote: >> I can't push back on people with silly coding style and small semantic >> issues forever. And I think I made a serious effort to keep the >> patches

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

On Tue, May 16, 2017 at 12:29:23PM -0400, David Miller wrote: > I can't push back on people with silly coding style and small semantic > issues forever. And I think I made a serious effort to keep the > patches getting posted over and over again to make sure they got more > exposure. You can

[PATCH net-next v2 3/7] sk_buff: remove support for csum_bad in sk_buff

This bit was introduced with commit 5a21232983aa ("net: Support for csum_bad in skbuff") to reduce the stack workload when processing RX packets carrying a wrong Internet Checksum. Up to now, only one driver and GRO core are setting it. Suggested-by: Tom Herbert

[PATCH net-next v2 1/7] skbuff: add stub to help computing crc32c on SCTP packets

sctp_compute_checksum requires crc32c symbol (provided by libcrc32c), so it can't be used in net core. Like it has been done previously with other symbols (e.g. ipv6_dst_lookup), introduce a stub struct skb_checksum_ops to allow computation of crc32c checksum in net core after sctp.ko (and thus

[PATCH net-next v2 7/7] sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY}

Add FCoE to the list of protocols that can set CHECKSUM_UNNECESSARY; add a note to CHECKSUM_COMPLETE section to specify that it does not apply to SCTP and FCoE protocols. Suggested-by: Tom Herbert Signed-off-by: Davide Caratti Acked-by: Tom Herbert

[PATCH net-next v2 4/7] net: use skb->csum_not_inet to identify packets needing crc32c

skb->csum_not_inet carries the indication on which algorithm is needed to compute checksum on skb in the transmit path, when skb->ip_summed is equal to CHECKSUM_PARTIAL. If skb carries a SCTP packet and crc32c hasn't been yet written in L4 header, skb->csum_not_inet is assigned to 1; otherwise,

[PATCH] net: phy: Remove residual magic from PHY drivers

commit fa8cddaf903c ("net phylib: Remove unnecessary condition check in phy") removed the only place where the PHY flag PHY_HAS_MAGICANEG was checked. But it left the flag being set in the drivers. Remove the flag. Signed-off-by: Andrew Lunn --- drivers/net/phy/broadcom.c | 30

[PATCH net-next v2 6/7] openvswitch: more accurate checksumming in queue_userspace_packet()

if skb carries an SCTP packet and ip_summed is CHECKSUM_PARTIAL, it needs CRC32c in place of Internet Checksum: use skb_csum_hwoffload_help to avoid corrupting such packets while queueing them towards userspace. Signed-off-by: Davide Caratti --- net/openvswitch/datapath.c |

[PATCH net-next v2 2/7] net: introduce skb_crc32c_csum_help

skb_crc32c_csum_help is like skb_checksum_help, but it is designed for checksumming SCTP packets using crc32c (see RFC3309), provided that libcrc32c.ko has been loaded before. In case libcrc32c is not loaded, invoking skb_crc32c_csum_help on a skb results in one the following printouts:

[PATCH net-next v2 5/7] net: more accurate checksumming in validate_xmit_skb()

skb_csum_hwoffload_help() uses netdev features and skb->csum_not_inet to determine if skb needs software computation of Internet Checksum or crc32c (or nothing, if this computation can be done by the hardware). Use it in place of skb_checksum_help() in validate_xmit_skb() to avoid corruption of

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

From: Doug Ledford Date: Tue, 16 May 2017 11:57:04 -0400 > Regardless though, I'm rather purturbed about this entire thing.  If > you are right that because this got into 4.11, it's now a done deal, > then the fact that this went through 4 review cycles on netdev@ that, > as

[PATCH net-next v2 0/7] fix CRC32c in the forwarding path

Current kernel allows offloading CRC32c computation when SCTP packets are generated, setting skb->ip_summed to CHECKSUM_PARTIAL, if the underlying device features have NETIF_F_SCTP_CRC set. However, after these packets are forwarded, they may land on a device where CRC32c offloading is not

Re: linux-next: Tree for May 16 (net/core)

On 05/15/17 18:21, Stephen Rothwell wrote: > Hi all, > > Changes since 20170515: > on i386 or x86_64: when CONFIG_INET is not enabled: ../net/core/sock.c: In function 'skb_orphan_partial': ../net/core/sock.c:1810:2: error: implicit declaration of function 'skb_is_tcp_pure_ack'

Re: [patch net-next v2 00/10] net: sched: introduce multichain support for filters

Tue, May 16, 2017 at 06:20:21PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 15 May 2017 10:38:47 +0200 > >> This patchset contains two major patches: >> 8/10 - This patch introduces the support for having multiple >>chains of filters. >> 10/10 - This

Re: [PATCH] net: ethernet: broadcom: bnxt: remove dead code

Hi Michael, Quoting Michael Chan : On Mon, May 15, 2017 at 3:28 PM, Gustavo A. R. Silva wrote: Local variable _sh_ is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards.

Re: [PATCH v3] bridge: netlink: check vlan_default_pvid range

On 5/16/17 11:48 AM, Tobias Jungel wrote: Currently it is allowed to set the default pvid of a bridge to a value above VLAN_VID_MASK (0xfff). This patch adds a check to br_validate and returns -EINVAL in case the pvid is out of bounds. Reproduce by calling: [root@test ~]# ip l a type bridge

Re: [patch net-next v2 00/10] net: sched: introduce multichain support for filters

From: Jiri Pirko Date: Mon, 15 May 2017 10:38:47 +0200 > This patchset contains two major patches: > 8/10 - This patch introduces the support for having multiple >chains of filters. > 10/10 - This patch adds new control action to allow going to specified chain > > The

Re: [ISSUE: sky2 - rx error] Link stops working under heavy traffic load connected to a mv88e6176

Also, check that in sky2_rx_add(), le->length is set to 4K. The value of le->length is set to 1520. Rafa Ah. You probably need to change sky2_get_rx_data_size() as well, to add in the extra 8 bytes. Andrew If I add the extra 8 byte in the function sky2_get_rx_data_size(), the

[PATCH net-next] cxgb4: add new T5 pci device id

Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h index a323185..9232bec 100644 ---

Re: [ISSUE: sky2 - rx error] Link stops working under heavy traffic load connected to a mv88e6176

> >Also, check that in sky2_rx_add(), le->length is set to 4K. > > > > The value of le->length is set to 1520. > Rafa Ah. You probably need to change sky2_get_rx_data_size() as well, to add in the extra 8 bytes. Andrew

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

Hi Linus, I've added you to this thread.  A quick synopsis: Dave sent you the net/smc driver for 4.11.  Even though it lives in net/smc, it is, for the most part, a net<->rdma translator and so it is as much an RDMA driver as anything else.  And upon review, the rdma community does not believe

[PATCH net-next] cxgb4: keep carrier off after registering netdev

From: Surendra Mobiya Mark carrier off after registering netdev to ensure that vlan device picks up the correct state of the carrier Signed-off-by: Surendra Mobiya Signed-off-by: Ganesh Goudar ---

Re: [PATCH] net: socket: mark socket protocol handler structs as const

From: linzhang Date: Mon, 15 May 2017 10:26:47 +0800 > Signed-off-by: linzhang Applied.

Re: [PATCH net-next,v2] tools: hv: Add clean up for included files in Ubuntu net config

From: Haiyang Zhang Date: Fri, 12 May 2017 12:14:11 -0700 > From: Haiyang Zhang > > The clean up function is updated to cover duplicate config info in > files included by "source" key word in Ubuntu network config. > > Signed-off-by:

Re: [PATCH v2 net-next] bnxt: add dma mapping attributes

From: Shannon Nelson Date: Tue, 9 May 2017 18:30:12 -0700 > On the SPARC platform we need to use the DMA_ATTR_WEAK_ORDERING attribute > in our Rx path dma mapping in order to get the expected performance out > of the receive path. Adding it to the Tx path has little

Re: [ISSUE: sky2 - rx error] Link stops working under heavy traffic load connected to a mv88e6176

On Tue, May 16, 2017 at 03:09:17PM +0200, Rafa Corvillo wrote: Adding 8 bytes (sky2->netdev->mtu + ETH_HLEN + VLAN_HLEN + 8 (EDSA_HLEN)) does not fix the error, because the interface keep having a maximum length of 1518 bytes (sky2->netdev->mtu + ETH_HLEN + VLAN_HLEN). Did you check the value

[PATCH net-next] cxgb4: reduce resource allocation in kdump kernel

When is_kdump_kernel() is true, reduce memory footprint of cxgb4 by using a single "Queue Set". Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH v2 net-next 00/12] drivers: net: xgene: Add ethtool stats and bug fixes

From: Iyappan Subramanian Date: Wed, 10 May 2017 13:44:58 -0700 > This patch set, > > - adds ethtool extended statistics support > - addresses errata workarounds > - fixes bugs related to statistics > > Signed-off-by: Iyappan Subramanian >

Re: [PATCH] neighbour: update neigh timestamps iff update is effective

On Mon, May 15, 2017 at 2:40 PM, Ihar Hrachyshka wrote: > It's a common practice to send gratuitous ARPs after moving an > IP address to another device to speed up healing of a service. To > fulfill service availability constraints, the timing of network peers > updating

Re: [PATCH v2] neighbour: update neigh timestamps iff update is effective

It's a common practice to send gratuitous ARPs after moving an IP address to another device to speed up healing of a service. To fulfill service availability constraints, the timing of network peers updating their caches to point to a new location of an IP address can be particularly important.

[Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

Blast from the past. 10 years back Wei Dong submitted the patch found (amongst several places) here: http://lists.openwall.net/netdev/2007/01/30/20 Problem: I have a firewall rule that DNATs ipv6 traffic from a destination address to ::1. The route lookup gives me the Main table & forwards that

Re: [PATCH] rt2x00: improve calling conventions for register accessors

From: Johannes Berg Date: Tue, 16 May 2017 13:58:56 +0200 > On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote: >> >> In rt2x00 driver we use poor convention in other kind of registers >> accessors like bbp, mac, eeprom. I dislike to changing only rfcsr >>

[PATCH net-next] cxgb4: update latest firmware version supported

Change t4fw_version.h to update latest firmware version number to 1.16.43.0. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4fw_version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH iproute2] ip: add support for more MPLS labels

On 5/16/17 1:32 AM, Simon Horman wrote: >> diff --git a/lib/mpls_pton.c b/lib/mpls_pton.c >> index bd448cfcf14a..6d2e6a69436a 100644 >> --- a/lib/mpls_pton.c >> +++ b/lib/mpls_pton.c >> @@ -7,12 +7,13 @@ >> #include "utils.h" >> >> >> -static int mpls_pton1(const char *name, struct mpls_label

Re: cxgb4 is broken in v4.12-rc1

Hi Logan, The latest firmware available is 1.16.43.0 kindly update your firmware and give a try, 1.16.29.4 have no support for autoneg. Thanks Ganesh From: Logan Gunthorpe Sent: Tuesday, May 16, 2017 7:20 AM To: Ganesh GR Cc: David S. Miller; Stephen Bates; SWise

Re: [PATCH] rt2x00: improve calling conventions for register accessors

On Tue, May 16, 2017 at 4:23 PM, Stanislaw Gruszka wrote: > On Tue, May 16, 2017 at 01:55:17PM +0200, Stanislaw Gruszka wrote: >> On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: >> > From: Stanislaw Gruszka >> > Date: Mon, 15 May 2017

<    1   2   3   >