Re: [PATCH net-next] cxgb4: reduce resource allocation in kdump kernel

2017-05-17 Thread David Miller
From: Ganesh Goudar Date: Tue, 16 May 2017 21:17:42 +0530 > When is_kdump_kernel() is true, reduce memory footprint of > cxgb4 by using a single "Queue Set". > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] cxgb4: keep carrier off after registering netdev

2017-05-17 Thread David Miller
From: Ganesh Goudar Date: Tue, 16 May 2017 21:26:25 +0530 > From: Surendra Mobiya > > Mark carrier off after registering netdev to ensure that vlan device > picks up the correct state of the carrier > > Signed-off-by: Surendra Mobiya > Signed-off-by: Ganesh Goudar This doesn't work. At the

Re: [PATCH v2] neighbour: update neigh timestamps iff update is effective

2017-05-17 Thread David Miller
From: Ihar Hrachyshka Date: Tue, 16 May 2017 08:44:24 -0700 > It's a common practice to send gratuitous ARPs after moving an > IP address to another device to speed up healing of a service. To > fulfill service availability constraints, the timing of network peers > updating their caches to point

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2017-05-17 Thread David Miller
From: Michael Ulmer Date: Tue, 16 May 2017 15:37:39 + > Blast from the past. 10 years back Wei Dong submitted the patch found > (amongst several places) here: > http://lists.openwall.net/netdev/2007/01/30/20 > > Problem: > I have a firewall rule that DNATs ipv6 traffic from a destination ad

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-17 Thread Edward Cree
On 17/05/17 15:00, Edward Cree wrote: > OTOH the 'track known 1s as well' might work in a nice generic way > and cover all bases, I'll have to experiment a bit with that. > > -Ed So I did some experiments (in Python, script follows) and found that indeed this does appear to work, at least for a

[PATCH net-next 8/8] powerpc/85xx/kmcent2: use hdlc busmode for UCC1

2017-05-17 Thread Holger Brunck
Signed-off-by: Holger Brunck --- arch/powerpc/boot/dts/fsl/kmcent2.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/fsl/kmcent2.dts b/arch/powerpc/boot/dts/fsl/kmcent2.dts index 47afa438602e..5922c1ea0e96 100644 --- a/arch/powerpc/boot/dts/fsl/kmce

[PATCH net-next 1/8] net/wan/fsl_ucc_hdlc: cleanup debug traces

2017-05-17 Thread Holger Brunck
Some of the tracing seems to be remaining traces for basic driver development. They can be removed now, as they cause noisy printouts. Signed-off-by: Holger Brunck Cc: Zhao Qiang --- drivers/net/wan/fsl_ucc_hdlc.c | 33 - 1 file changed, 33 deletions(-) diff --g

[PATCH net-next 5/8] net/wan/fsl_ucc_hdlc: call qe_setbrg only for loopback mode

2017-05-17 Thread Holger Brunck
We can't assume that we are always in loopback mode if rx and tx clock have the same clock source. If we want to use HDLC busmode we also have the same clock source but we are not in loopback mode. So move the setting of the baudrate generator after the check for property for the loopback mode. Si

[PATCH net-next 4/8] net/wan/fsl_ucc_hdlc: fix incorrect memory allocation

2017-05-17 Thread Holger Brunck
We need space for the struct qe_bd and not for a pointer to this struct. Signed-off-by: Holger Brunck Cc: Zhao Qiang --- drivers/net/wan/fsl_ucc_hdlc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.

[PATCH net-next 2/8] net/wan/fsl_ucc_hdlc: fix unitialized variable warnings

2017-05-17 Thread Holger Brunck
This fixes the following compiler warnings: drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_poll': warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized] skb->mac_header = skb->data - skb->head; and drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_probe': d

[PATCH net-next 3/8] net/wan/fsl_ucc_hdlc: fix wrong indentation

2017-05-17 Thread Holger Brunck
Signed-off-by: Holger Brunck Cc: Zhao Qiang --- drivers/net/wan/fsl_ucc_hdlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 6ef6d719545d..1a60897767d9 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/dr

[PATCH net-next 7/8] net/wan/fsl_ucc_hdlc: add hdlc-bus support

2017-05-17 Thread Holger Brunck
This adds support for hdlc-bus mode to the fsl_ucc_hdlc driver. This can be enabled with the "fsl,hdlc-bus" property in the DTS node of the corresponding ucc. This aligns the configuration of the UPSMR and GUMR registers to what is done in our ucc_hdlc driver (that only support hdlc-bus mode) and

[PATCH net-next 6/8] fsl/qe: add bit description for SYNL register for GUMR

2017-05-17 Thread Holger Brunck
Add the bitmask for the two bit SYNL register according to the QUICK Engine Reference Manual. Signed-off-by: Holger Brunck Cc: Zhao Qiang --- include/soc/fsl/qe/qe.h | 4 1 file changed, 4 insertions(+) diff --git a/include/soc/fsl/qe/qe.h b/include/soc/fsl/qe/qe.h index 0cd4c11479b1..226

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-17 Thread Ben Greear
On 05/17/2017 06:30 AM, Johannes Berg wrote: On Wed, 2017-05-17 at 12:08 +0200, Bastian Bittorf wrote: * Ben Greear [17.05.2017 11:51]: I have been keeping an 'iw events' program running with a perl script gathering its output and post-processing it. This has been working for several years on

Re: [net-next] net: remove duplicate add_device_randomness() call

2017-05-17 Thread David Miller
From: Zhang Shengju Date: Wed, 17 May 2017 17:23:26 +0800 > Since register_netdevice() already call add_device_randomness() and > dev_set_mac_address() will call it after mac address change. > It's not necessary to call at device UP. > > Signed-off-by: Zhang Shengju __dev_open() can (at least

[PATCH net] bonding: fix accounting of active ports in 3ad

2017-05-17 Thread Jarod Wilson
As of 7bb11dc9f59d and 0622cab0341c, bond slaves in a 3ad bond are not removed from the aggregator when they are down, and the active slave count is NOT equal to number of ports in the aggregator, but rather the number of ports in the aggregator that are still enabled. The sysfs spew for bonding_sh

Re: [PATCH net 5/5] qede: Split PF/VF ndos.

2017-05-17 Thread David Miller
From: "Mintz, Yuval" Date: Wed, 17 May 2017 06:16:46 + > Looking at my alternatives for solving this, I can't see any 'good' > options - it seems mightily unorthodox to modify net_device_ops, > I.e., add/remove an NDO function-pointer based on some device > property, and having multiple ops d

Re: [PATCH] net: always include tcp.h in sock.c

2017-05-17 Thread Eric Dumazet
On Wed, 2017-05-17 at 10:47 +0200, Arnd Bergmann wrote: > kernelci reports a build regression in the latest 4.12 snapshots > in configurations without TCP: > > net/core/sock.c: In function 'skb_orphan_partial': > net/core/sock.c:1810:6: error: implicit declaration of function > 'skb_is_tcp_pure_a

[PATCH v2 03/10] rt2x00: convert rt2x00_rf_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00_rf_read() to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \ drivers/net/wireless/ralink/rt2x0

[PATCH v2 02/10] rt2x00: convert rt2800_rfcsr_read return type

2017-05-17 Thread Arnd Bergmann
With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high stack usage (with a private patch set I have to turn on this warning, which I intend to get into the next kernel release): wireless/ralink/rt2x00/rt2800lib.c: In function 'rt2800_bw_filter_calibration': wireless/ralink/rt2x00/

[PATCH v2 10/10] rt2x00: convert rt2x00_desc_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00_desc_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \ -i 's:\(\<_rt2x00_desc_read\>(.*, .*\

[PATCH v2 01/10] rt2x00: change function pointers for register accessors

2017-05-17 Thread Arnd Bergmann
This prepares the driver for changing all the 'read' register accessors to return the value instead of passing it by reference. Since a lot of them are used in callbacks, this takes care of the callbacks first, adding a couple of helpers that will be removed again one at a time. Signed-off-by: Arn

[PATCH v2 08/10] rt2x00: convert rt2x00_eeprom_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00_eeprom_read() to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \ -i 's:= _\(rt2x00_eeprom_read\):=

[PATCH v2 05/10] rt2x00: convert rt2x00usb_register_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00usb_register_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \ -i 's:\(\(.*, .*\), &\(.*\));:

[PATCH v2 04/10] rt2x00: convert rt2x00mmio_register_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00mmio_register_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(rt2x00mmio_register_read(.*, .*\), &\(.*\));:\2 = \1);:' \ -i 's:

[PATCH v2 06/10] rt2x00: convert rt2800_register_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2800_register_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(rt2800_register_read(.*, .*\), &\(.*\));:\2 = \1);:' \ 's:\(rt2800

[PATCH v2 07/10] rt2x00: convert rt2*_bbp_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change *_bbp_read() to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \ -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:'

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

2017-05-17 Thread Alexander Duyck
On Tue, May 16, 2017 at 11:38 AM, Casey Leedom wrote: > | From: Ding Tianhong > | Sent: Wednesday, May 10, 2017 6:15 PM > | > | Hi Casey: > | > | Will you continue to work on this solution or send a new version patches? > > I won't be able to work on this any time soon given several other urgent

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-17 Thread Arnd Bergmann
On Wed, May 17, 2017 at 2:17 PM, Tom Psyborg wrote: > > > On 16 May 2017 at 16:31, Jes Sorensen wrote: >> >> >> True - if the automatic conversion works without automatic intervention, I >> am less worried about it. Personally I would still focus on converting one >> function at a time to reduce

[PATCH v2 09/10] rt2x00: convert rt2800_eeprom_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2800_eeprom_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\3 = \1);:' drivers/net/wireless/ralink/rt2x

[PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-17 Thread Arnd Bergmann
I've managed to split up my long patch into a series of reasonble steps now. The first two are required to fix a regression from commit 41977e86c984 ("rt2x00: add support for MT7620"), the rest are just cleanups to have a consistent state across all the register access functions. Arnd

[PATCH net,stable] qmi_wwan: add another Lenovo EM74xx device ID

2017-05-17 Thread Bjørn Mork
In their infinite wisdom, and never ending quest for end user frustration, Lenovo has decided to use a new USB device ID for the wwan modules in their 2017 laptops. The actual hardware is still the Sierra Wireless EM7455 or EM7430, depending on region. Signed-off-by: Bjørn Mork --- drivers/net/

[PATCH net] sctp: do not inherit ipv6_{mc|ac|fl}_list from parent

2017-05-17 Thread Eric Dumazet
From: Eric Dumazet SCTP needs fixes similar to 83eaddab4378 ("ipv6/dccp: do not inherit ipv6_mc_list from parent"), otherwise bad things can happen. Signed-off-by: Eric Dumazet Reported-by: Andrey Konovalov Tested-by: Andrey Konovalov --- net/sctp/ipv6.c |3 +++ 1 file changed, 3 inserti

Re: [PATCH v3 net-next 4/7] net: add new control message for incoming HW-timestamped packets

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar wrote: > Add SOF_TIMESTAMPING_OPT_PKTINFO option to request a new control message > for incoming packets with hardware timestamps. It contains the index of > the real interface which received the packet and the length of the > packet at layer 2. >

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-17 Thread Edward Cree
On 16/05/17 23:53, Alexei Starovoitov wrote: > following this line of thinking it feels that it should be possible > to get rid of 'aux_off' and 'aux_off_align' and simplify the code. > I mean we can always do > dst_reg->min_align = min(dst_reg->min_align, src_reg->min_align); > > and don't use 'of

Re: [PATCH net-next] cxgb4: update latest firmware version supported

2017-05-17 Thread Ganesh GR
Ok, I will send the patch to net. Thanks From: David Miller Sent: Wednesday, May 17, 2017 1:23 AM To: Ganesh GR Cc: netdev@vger.kernel.org; Nirranjan Kirubaharan; Indranil Choudhury Subject: Re: [PATCH net-next] cxgb4: update latest firmware version supported   From: Ganesh Goudar Date: Tu

Re: [PATCH v3 net-next 5/7] net: don't make false software transmit timestamps

2017-05-17 Thread Willem de Bruijn
On Wed, May 17, 2017 at 6:27 AM, Miroslav Lichvar wrote: > On Tue, May 16, 2017 at 06:34:38PM -0400, Willem de Bruijn wrote: >> On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar >> wrote: >> > If software timestamping is enabled by the SO_TIMESTAMP(NS) option >> > when a message without timestam

Re: [PATCH net-next 15/15] tcp: switch TCP TS option (RFC 7323) to 1ms clock

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > TCP Timestamps option is defined in RFC 7323 > > Traditionally on linux, it has been tied to the internal > 'jiffies' variable, because it had been a cheap and good enough > generator. > > For TCP flows on the Internet, 1 ms resolution would b

Re: [PATCH net-next 12/15] tcp_westwood: use tcp_jiffies32 instead of tcp_time_stamp

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > This CC does not need 1 ms tcp_time_stamp and can use > the jiffy based 'timestamp'. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > net/ipv4/tcp_westwood.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletion

Re: [PATCH net-next 11/15] tcp: use tcp_jiffies32 in __tcp_oow_rate_limited()

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > This place wants to use tcp_jiffies32, this is good enough. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > net/ipv4/tcp_input.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/ipv4

Re: [PATCH net-next 14/15] tcp: replace misc tcp_time_stamp to tcp_jiffies32

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > After this patch, all uses of tcp_time_stamp will require > a change when we introduce 1 ms and/or 1 us TCP TS option. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > net/ipv4/tcp.c | 2 +- > net/ipv4/tcp

Re: [PATCH net-next 13/15] tcp_lp: cache tcp_time_stamp

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > tcp_time_stamp will become slightly more expensive soon, > cache its value. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > net/ipv4/tcp_lp.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff

Re: [PATCH net-next 09/15] tcp: use tcp_jiffies32 to feed probe_timestamp

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > Use tcp_jiffies32 instead of tcp_time_stamp, since > tcp_time_stamp will soon be only used for TCP TS option. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > net/ipv4/tcp_output.c | 6 +++--- > net/ipv4/tcp_timer.c

Re: [PATCH net-next 10/15] tcp: uses jiffies_32 to feed tp->chrono_start

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > tcp_time_stamp will no longer be tied to jiffies. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > net/ipv4/tcp.c| 2 +- > net/ipv4/tcp_output.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >

Re: [PATCH net-next 08/15] tcp: use tcp_jiffies32 for rcv_tstamp and lrcvtime

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > Use tcp_jiffies32 instead of tcp_time_stamp, since > tcp_time_stamp will soon be only used for TCP TS option. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > include/net/tcp.h| 4 ++-- > net/ipv4/tcp_input.

Re: [PATCH net-next 07/15] tcp: bic,cubic: use tcp_jiffies32 instead of tcp_time_stamp

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > Use tcp_jiffies32 instead of tcp_time_stamp, since > tcp_time_stamp will soon be only used for TCP TS option. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > net/ipv4/tcp_bic.c | 6 +++--- > net/ipv4/tcp_cubic.c

Re: [PATCH net-next 06/15] tcp_bbr: use tcp_jiffies32 instead of tcp_time_stamp

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > Use tcp_jiffies32 instead of tcp_time_stamp, since > tcp_time_stamp will soon be only used for TCP TS option. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > net/ipv4/tcp_bbr.c | 12 ++-- > 1 file changed,

Re: [PATCH net-next 05/15] tcp: use tcp_jiffies32 to feed tp->snd_cwnd_stamp

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > Use tcp_jiffies32 instead of tcp_time_stamp to feed > tp->snd_cwnd_stamp. > > tcp_time_stamp will soon be a litle bit more expensive > than simply reading 'jiffies'. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- >

Re: [PATCH net-next 04/15] tcp: use tcp_jiffies32 to feed tp->lsndtime

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > Use tcp_jiffies32 instead of tcp_time_stamp to feed > tp->lsndtime. > > tcp_time_stamp will soon be a litle bit more expensive > than simply reading 'jiffies'. > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > includ

Re: [PATCH net-next 03/15] dccp: do not use tcp_time_stamp

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > Use our own macro instead of abusing tcp_time_stamp > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh > --- > net/dccp/ccids/ccid2.c | 8 > net/dccp/ccids/ccid2.h | 2 +- > 2 files changed, 5 insertions(+), 5 deleti

Re: [PATCH net-next 02/15] tcp: introduce tcp_jiffies32

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > We abuse tcp_time_stamp for two different cases : > > 1) base to generate TCP Timestamp options (RFC 7323) > > 2) A 32bit version of jiffies since some TCP fields >are 32bit wide to save memory. > > Since we want in the future to have 1ms

Re: [PATCH net-next 01/15] tcp: use tp->tcp_mstamp in output path

2017-05-17 Thread Soheil Hassas Yeganeh
On Tue, May 16, 2017 at 5:00 PM, Eric Dumazet wrote: > Idea is to later convert tp->tcp_mstamp to a full u64 counter > using usec resolution, so that we can later have fine > grained TCP TS clock (RFC 7323), regardless of HZ value. > > We try to refresh tp->tcp_mstamp only when necessary. > > Sign

Re: [PATCH] hdlcdrv: fix divide error bug if bitrate is 0

2017-05-17 Thread Firo Yang
On Wed, May 17, 2017 at 02:59:39PM +0200, walter harms wrote: > > >Am 17.05.2017 14:35, schrieb Firo Yang: >> The divisor s->par.bitrate will always be 0 until initialized by >> ndo_open() and hdlcdrv_open(). >> >> In order to fix this divide zero error, check whether the netdevice >> was opened b

[no subject]

2017-05-17 Thread J Walker

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-17 Thread Johannes Berg
On Wed, 2017-05-17 at 12:08 +0200, Bastian Bittorf wrote: > * Ben Greear [17.05.2017 11:51]: > > I have been keeping an 'iw events' program running with a perl > > script gathering its > > output and post-processing it.  This has been working for several > > years on 4.7 and earlier > > kernels, b

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Johannes Berg
On Wed, 2017-05-17 at 15:21 +0200, Pali Rohár wrote: > On Wednesday 17 May 2017 15:04:50 Johannes Berg wrote: > > On Wed, 2017-05-17 at 14:53 +0200, Pali Rohár wrote: > > > > > > In fact, why should the *driver* care either? IOW - why should > > > > "request_firmware_prefer_user()" even exist? > >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Pali Rohár
On Wednesday 17 May 2017 15:04:50 Johannes Berg wrote: > On Wed, 2017-05-17 at 14:53 +0200, Pali Rohár wrote: > > > > In fact, why should the *driver* care either? IOW - why should > > > "request_firmware_prefer_user()" even exist? > > > > There are default/example NVS data, which are stored in /

Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()

2017-05-17 Thread Johannes Berg
On Thu, 2017-05-04 at 13:13 +, Kalle Valo wrote: > > > > This code intentionally checked if TX status was requested, and > > > if not then it doesn't go to the effort of building it. > > > > > > > What I'm finding puzzling is the fact that the only caller of > > ieee80211_led_tx() is ieee802

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Johannes Berg
On Wed, 2017-05-17 at 14:53 +0200, Pali Rohár wrote: > > In fact, why should the *driver* care either? IOW - why should > > "request_firmware_prefer_user()" even exist? > > There are default/example NVS data, which are stored in /lib/firmware > and installed by linux-firmware package. [...] Oh,

Re: [PATCH] hdlcdrv: fix divide error bug if bitrate is 0

2017-05-17 Thread walter harms
Am 17.05.2017 14:35, schrieb Firo Yang: > The divisor s->par.bitrate will always be 0 until initialized by > ndo_open() and hdlcdrv_open(). > > In order to fix this divide zero error, check whether the netdevice > was opened by ndo_open() before performing divide. > > Reported-by: Dmitry Vyukov

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-17 Thread Jiri Pirko
Wed, May 17, 2017 at 02:47:47PM CEST, j...@mojatatu.com wrote: >On 17-05-17 01:47 AM, Jiri Pirko wrote: >> Wed, May 17, 2017 at 12:38:08AM CEST, xiyou.wangc...@gmail.com wrote: > >[..] >> > >> > tcf_auto_major_prio()? >> >> That makes no sense. prio is passed from user in upper 2 bytes (god >> kn

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Pali Rohár
On Wednesday 17 May 2017 14:06:06 Johannes Berg wrote: > On Tue, 2017-05-16 at 01:13 +0200, Luis R. Rodriguez wrote: > > > > Now for N900 case there is a similar scenario > > > > alhtough it has additional requirement to go to user-space due to > > > > need to use a proprietary library to obtain th

[PATCH net] udp: make *udp*_queue_rcv_skb() functions static

2017-05-17 Thread Paolo Abeni
Since the udp memory accounting refactor, we don't need any more to export the *udp*_queue_rcv_skb(). Make them static and fix a couple of sparse warnings: net/ipv4/udp.c:1615:5: warning: symbol 'udp_queue_rcv_skb' was not declared. Should it be static? net/ipv6/udp.c:572:5: warning: symbol 'udpv6

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 01:47 AM, Jiri Pirko wrote: Wed, May 17, 2017 at 12:38:08AM CEST, xiyou.wangc...@gmail.com wrote: [..] tcf_auto_major_prio()? That makes no sense. prio is passed from user in upper 2 bytes (god knows why but that is how it is). I am not sure it is any god's decision ;-> Unless

Re: [patch net-next v4 06/10] net: sched: introduce helpers to work with filter chains

2017-05-17 Thread Jiri Pirko
Wed, May 17, 2017 at 02:39:05PM CEST, j...@mojatatu.com wrote: >On 17-05-17 08:25 AM, Jiri Pirko wrote: >> Wed, May 17, 2017 at 02:18:00PM CEST, j...@mojatatu.com wrote: >> > On 17-05-17 05:07 AM, Jiri Pirko wrote: >> > > From: Jiri Pirko >> > > >> > > Introduce struct tcf_chain object and set of

Re: [patch net-next v4 06/10] net: sched: introduce helpers to work with filter chains

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 08:25 AM, Jiri Pirko wrote: Wed, May 17, 2017 at 02:18:00PM CEST, j...@mojatatu.com wrote: On 17-05-17 05:07 AM, Jiri Pirko wrote: From: Jiri Pirko Introduce struct tcf_chain object and set of helpers around it. Wraps up insertion, deletion and search in the filter chain. Signed-

[PATCH] hdlcdrv: fix divide error bug if bitrate is 0

2017-05-17 Thread Firo Yang
The divisor s->par.bitrate will always be 0 until initialized by ndo_open() and hdlcdrv_open(). In order to fix this divide zero error, check whether the netdevice was opened by ndo_open() before performing divide. Reported-by: Dmitry Vyukov Signed-off-by: Firo Yang --- drivers/net/hamradio/hd

Re: [patch net-next v4 10/10] net: sched: add termination action to allow goto chain

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:08 AM, Jiri Pirko wrote: From: Jiri Pirko Introduce new type of termination action called "goto_chain". This allows user to specify a chain to be processed. This action type is then processed as a return value in tcf_classify loop in similar way as "reclassify" is, only it does n

Re: [patch net-next v4 09/10] net: sched: push tp down to action init

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:08 AM, Jiri Pirko wrote: From: Jiri Pirko Tp pointer will be needed by the next patch in order to get the chain. Signed-off-by: Jiri Pirko Acked-by: Jamal Hadi Salim cheers, jamal

Re: [patch net-next v4 08/10] net: sched: introduce multichain support for filters

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:08 AM, Jiri Pirko wrote: From: Jiri Pirko Instead of having only one filter per block, introduce a list of chains for every block. Create chain 0 by default. UAPI is extended so the user can specify which chain he wants to change. If the new attribute is not specified, chain 0 is

Re: [patch net-next v4 06/10] net: sched: introduce helpers to work with filter chains

2017-05-17 Thread Jiri Pirko
Wed, May 17, 2017 at 02:18:00PM CEST, j...@mojatatu.com wrote: >On 17-05-17 05:07 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Introduce struct tcf_chain object and set of helpers around it. Wraps up >> insertion, deletion and search in the filter chain. >> >> Signed-off-by: Jiri Pirko >> --

Re: [patch net-next v4 07/10] net: sched: push chain dump to a separate function

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:08 AM, Jiri Pirko wrote: From: Jiri Pirko Since there will be multiple chains to dump, push chain dumping code to a separate function. Signed-off-by: Jiri Pirko Acked-by: Jamal Hadi Salim cheers, jamal

Re: [patch net-next v4 06/10] net: sched: introduce helpers to work with filter chains

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:07 AM, Jiri Pirko wrote: From: Jiri Pirko Introduce struct tcf_chain object and set of helpers around it. Wraps up insertion, deletion and search in the filter chain. Signed-off-by: Jiri Pirko --- [..] + +static void +tcf_chain_filter_chain_ptr_set(struct tcf_chain *chain, +

Re: [patch net-next v4 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:07 AM, Jiri Pirko wrote: From: Jiri Pirko Call the helper from the function rather than to always adjust the return value of the function. Signed-off-by: Jiri Pirko Acked-by: Jamal Hadi Salim cheers, jamal

Re: [patch net-next v4 04/10] net: sched: replace nprio by a bool to make the function more readable

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:07 AM, Jiri Pirko wrote: From: Jiri Pirko The use of "nprio" variable in tc_ctl_tfilter is a bit cryptic and makes a reader wonder what is going on for a while. So help him to understand this priority allocation dance a litte bit better. Signed-off-by: Jiri Pirko Acked-by: Ja

Re: [patch net-next v4 03/10] net: sched: rename tcf_destroy_chain helper

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:07 AM, Jiri Pirko wrote: From: Jiri Pirko Make the name consistent with the rest of the helpers around. Signed-off-by: Jiri Pirko Acked-by: Jamal Hadi Salim cheers, jamal

Re: [patch net-next v4 02/10] net: sched: introduce tcf block infractructure

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:07 AM, Jiri Pirko wrote: From: Jiri Pirko Currently, the filter chains are direcly put into the private structures of qdiscs. In order to be able to have multiple chains per qdisc and to allow filter chains sharing among qdiscs, there is a need for common object that would hold t

Re: [patch net-next v4 01/10] net: sched: move tc_classify function to cls_api.c

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 05:07 AM, Jiri Pirko wrote: From: Jiri Pirko Move tc_classify function to cls_api.c where it belongs, rename it to fit the namespace. Signed-off-by: Jiri Pirko Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Johannes Berg
On Tue, 2017-05-16 at 01:13 +0200, Luis R. Rodriguez wrote: > > > Now for N900 case there is a similar scenario > > > alhtough it has additional requirement to go to user-space due to > > > need to use a proprietary library to obtain the NVS calibration > > > data. My thought: Why should firmware_c

Re: [PATCH v5 16/17] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

2017-05-17 Thread Stefan Wahren
Hi Greg, Am 10.05.2017 um 10:53 schrieb Stefan Wahren: > Instead of returning the requested baudrate, we better return the > actual one because it isn't always the same. > > Signed-off-by: Stefan Wahren > Acked-by: Rob Herring > --- > drivers/tty/serdev/serdev-ttyport.c | 2 +- > 1 file changed

RE: Donation Award

2017-05-17 Thread Mayrhofer Family
Good Day, My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. We await your earliest response and God Bless you. Friedrich And Annand Mayrhofer. --- This email has been checked f

RE: [PATCH net-next 9/9] nfp: eliminate an if statement in calculation of completed frames

2017-05-17 Thread David Laight
From: Jakub Kicinski > Sent: 16 May 2017 01:55 > Given that our rings are always a power of 2, we can simplify the > calculation of number of completed TX descriptors by using masking > instead of if statement based on whether the index have wrapped > or not. > > Signed-off-by: Jakub Kicinski > -

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

2017-05-17 Thread Baxter, Jim
From: Oliver Neukum (oneu...@suse.com) Sent: Wed, 17 May 2017 09:44:20 +0200 > Am Dienstag, den 16.05.2017, 20:24 +0200 schrieb Bjørn Mork: >> >> I must say that I don't like the additional complexity added here. If >> there are memory issues and you can reduce the buffer size to >> USB_CDC_NCM_

[PATCH net-next] net: make struct net_device::tx_queue_len unsigned int

2017-05-17 Thread Alexey Dobriyan
4 billion packet queue is something unthinkable so use 32-bit value for now. Space savings on x86_64: add/remove: 0/0 grow/shrink: 3/70 up/down: 16/-131 (-115) function old new delta change_tx_queue_len 94

Re: [PATCH v3 net-next 5/7] net: don't make false software transmit timestamps

2017-05-17 Thread Miroslav Lichvar
On Tue, May 16, 2017 at 06:34:38PM -0400, Willem de Bruijn wrote: > On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar wrote: > > If software timestamping is enabled by the SO_TIMESTAMP(NS) option > > when a message without timestamp is already waiting in the queue, the > > __sock_recv_timestamp()

NETIF_N_NTUPLE - should it control flow classification?

2017-05-17 Thread Mintz, Yuval
Code-reading a bit, and I'm not sure of the exact definition of said bit; Couldn't really deduce from the comment "N-tuple filters supported" what falls under its jurisdiction and failed to find any other documentation. I understand RFS acceleration is going to be disabled for an interface when th

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-17 Thread Bastian Bittorf
* Ben Greear [17.05.2017 11:51]: > I have been keeping an 'iw events' program running with a perl script > gathering its > output and post-processing it. This has been working for several years on > 4.7 and earlier > kernels, but when testing on 4.9 overnight, I notice that 'iw events' is not

[net-next] net: remove duplicate add_device_randomness() call

2017-05-17 Thread Zhang Shengju
Since register_netdevice() already call add_device_randomness() and dev_set_mac_address() will call it after mac address change. It's not necessary to call at device UP. Signed-off-by: Zhang Shengju --- net/core/dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/dev.c b/net/core/d

Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

2017-05-17 Thread Anoob Soman
On 17/05/17 09:19, Greg KH wrote: Why is this a non-upstream patch? What commit in Linus's tree fixed this? Why not just backport that? thanks, greg k-h Agreed, I think it is sensible to backport 52bd2d62ce67 "net: better skb->sender_cpu and skb->napi_id cohabitation" to 4.4, rather than

Re: [PATCH] udp: make function udp_skb_dtor_locked static

2017-05-17 Thread Paolo Abeni
On Wed, 2017-05-17 at 09:50 +0100, Colin King wrote: > From: Colin Ian King > > Function udp_skb_dtor_locked does not need to be in global scope > so make it static to fix sparse warning: > > net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not > declared. Should it be static? > > Fixe

[patch net-next v4 07/10] net: sched: push chain dump to a separate function

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko Since there will be multiple chains to dump, push chain dumping code to a separate function. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 95 + 1 file changed, 52 insertions(+), 43 deletions(-) diff --git a/net/sched/

[patch net-next v4 09/10] net: sched: push tp down to action init

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko Tp pointer will be needed by the next patch in order to get the chain. Signed-off-by: Jiri Pirko --- include/net/act_api.h | 12 ++-- net/sched/act_api.c | 15 --- net/sched/cls_api.c | 9 + 3 files changed, 19 insertions(+), 17 deletions(-) d

[patch net-next v4 10/10] net: sched: add termination action to allow goto chain

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko Introduce new type of termination action called "goto_chain". This allows user to specify a chain to be processed. This action type is then processed as a return value in tcf_classify loop in similar way as "reclassify" is, only it does not reset to the first filter in chain but

[patch net-next v4 08/10] net: sched: introduce multichain support for filters

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko Instead of having only one filter per block, introduce a list of chains for every block. Create chain 0 by default. UAPI is extended so the user can specify which chain he wants to change. If the new attribute is not specified, chain 0 is used. That allows to maintain backward co

[patch net-next v4 06/10] net: sched: introduce helpers to work with filter chains

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko Introduce struct tcf_chain object and set of helpers around it. Wraps up insertion, deletion and search in the filter chain. Signed-off-by: Jiri Pirko --- include/net/sch_generic.h | 7 ++- net/sched/cls_api.c | 148 +- 2 fil

[patch net-next v4 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko Call the helper from the function rather than to always adjust the return value of the function. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index bf2e59c..6

[patch net-next v4 04/10] net: sched: replace nprio by a bool to make the function more readable

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko The use of "nprio" variable in tc_ctl_tfilter is a bit cryptic and makes a reader wonder what is going on for a while. So help him to understand this priority allocation dance a litte bit better. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 13 +++-- 1 file chan

[patch net-next v4 00/10] net: sched: introduce multichain support for filters

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko Currently, each classful qdisc holds one chain of filters. This chain is traversed and each filter could be matched on, which may lead to execution of list of actions. One of such action could be "reclassify", which would "reset" the processing of the filter chain. So this filte

[patch net-next v4 03/10] net: sched: rename tcf_destroy_chain helper

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko Make the name consistent with the rest of the helpers around. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index d30116f..c02b03e 100644 --- a/net/sched/cls

[patch net-next v4 02/10] net: sched: introduce tcf block infractructure

2017-05-17 Thread Jiri Pirko
From: Jiri Pirko Currently, the filter chains are direcly put into the private structures of qdiscs. In order to be able to have multiple chains per qdisc and to allow filter chains sharing among qdiscs, there is a need for common object that would hold the chains. This introduces such object and

<    1   2   3   >