This reserved area should be eight bytes in length instead of four.
As a result, the return codes in the REQUEST_MAP_RSP descriptors
were not being properly handled.
Signed-off-by: Thomas Falcon
---
drivers/net/ethernet/ibm/ibmvnic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
This patch set fixes the error-handling of long-term-mapped buffers
during adapter initialization and reset. The first patch fixes a bug
in an incorrectly defined descriptor that was keeping the return
codes from the VIO server from being properly checked. The second patch
fixes and cleans up the e
The patch stores the return code of the REQUEST_MAP_RSP sub-CRQ command
in the private data structure, where it can be later checked during
device open or a reset.
In the case of a reset, the mapping request to the vNIC Server may fail,
especially in the case of a partition migration. The driver a
From: Nathan Fontenot
Date: Wed, 21 Jun 2017 14:48:06 -0500
> On 06/21/2017 02:39 PM, David Miller wrote:
>> From: Nathan Fontenot
>> Date: Tue, 20 Jun 2017 17:21:54 -0400
>>
>>> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)
>>
>> I'm incredibly curious where you got the
Hi Ethan,
Quoting Ethan Zhao :
Gustavo,
The return value of ret_val seems used to check if the access to PHY/NVM
got its semaphore, generally speaking, it is needed for every PHY
access of this driver.
Reviewed-by: Ethan Zhao
Thank you very much for the clarification.
On Wed, Jun 21
On 06/21/2017 02:39 PM, David Miller wrote:
> From: Nathan Fontenot
> Date: Tue, 20 Jun 2017 17:21:54 -0400
>
>> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)
>
> I'm incredibly curious where you got the idea to put the Fixes: tag
> at the beginning of the commit message.
On 06/21/2017 09:24 PM, Marcelo Ricardo Leitner wrote:
On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote:
This function compiles to 147 bytes of machine code. 13 callsites.
I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
SCTP events are not happening on e
Simon it looks like Or has some more questions about how these
representers will work and operate.
So I'm going to mark this series as "deferred" in patchwork while
you two sort out that conversation.
Thank you.
From: Nathan Fontenot
Date: Tue, 20 Jun 2017 17:21:54 -0400
> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)
I'm incredibly curious where you got the idea to put the Fixes: tag
at the beginning of the commit message.
Have you seen anyone else submitting patches on netdev d
Hi Daniel,
Good news. Got the CALL to work.
[ 145.670882] test_bpf: Summary: 316 PASSED, 0 FAILED, [287/308 JIT'ed]
Awesome. Do you think with this implementation, the patch could get
accepted? If you think so, then I will send the patch in couple of
days after some refactoring, if not, then do
From: Michal Kalderon
Date: Wed, 21 Jun 2017 16:22:42 +0300
> This patch series makes a few more infrastructure changes towards adding
> iWARP support. Hopefully this is the last infrastructure change
> prior to the iWARP RFC.
>
> Patch #1-3 take care of taking all the common iWARP/RoCE code out
On 06/16/2017 11:10 AM, Christoph Hellwig wrote:
Hi all,
for a while we have a generic implementation of the dma mapping routines
that call into per-arch or per-device operations. But right now there
still are various bits in the interfaces where don't clearly operate
on these ops. This seri
From: Joe Perches
Date: Wed, 21 Jun 2017 12:19:10 -0700
> On Wed, 2017-06-21 at 18:28 +0200, Denys Vlasenko wrote:
>> This function compiles to 147 bytes of machine code. 13 callsites.
>>
>> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
>> SCTP events are not happeni
On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote:
> This function compiles to 147 bytes of machine code. 13 callsites.
>
> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
> SCTP events are not happening on every packet.
> They are ASSOC_CHANGE, PEER_ADDR_CH
On Wed, 2017-06-21 at 18:28 +0200, Denys Vlasenko wrote:
> This function compiles to 147 bytes of machine code. 13 callsites.
>
> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
> SCTP events are not happening on every packet.
> They are ASSOC_CHANGE, PEER_ADDR_CHANGE, R
From: Daniel Borkmann
Date: Wed, 21 Jun 2017 20:16:11 +0200
> In order to be able to retrieve the attached programs from cls_bpf
> and act_bpf, we need to expose the prog ids via netlink so that
> an application can later on get an fd based on the id through the
> BPF_PROG_GET_FD_BY_ID command, a
From: Shannon Nelson
Date: Wed, 21 Jun 2017 09:09:54 -0700
> Add the get_settings callback so that both the ldmvsw and sunvnet
> drivers will give a little more information when asked for its
> basic settings. These aren't necessarily very useful, but they
> make some users happier. Also, a sid
From: Shannon Nelson
Date: Wed, 21 Jun 2017 09:09:53 -0700
> In the ethtool -i output print the vio version and the remote-mac
> of the ldom that the vif device is serving as this vif info is
> not exposed elsewhere. The remote-mac address is most useful for
> tracking which client ldom is being
This is way too much churn.
Especially renaming the structure members.
Just a blanket "I fixed a dozen of so checkpatch warnings" bundled
into a single huge patch like this will not be applied, sorry.
On 06/21/2017 08:23 PM, Alexander Duyck wrote:
On Wed, Jun 21, 2017 at 10:54 AM, John Fastabend
wrote:
On 06/21/2017 10:27 AM, Daniel Borkmann wrote:
[...]
drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_m
Michael J Dilmore wrote:
>The function below contains a BUG_ON where no active slave is detected. The
>patch
>converts this to a WARN_ON to avoid crashing the kernel.
>
>Signed-off-by: Michael J Dilmore
>---
> drivers/net/bonding/bond_options.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
On Sun, Jun 18, 2017 at 11:53 PM, Ding Tianhong wrote:
> From: Casey Leedom
>
> cxgb4 Ethernet driver now queries PCIe configuration space to determine
> if it can send TLPs to it with the Relaxed Ordering Attribute set.
>
> Signed-off-by: Casey Leedom
> Signed-off-by: Ding Tianhong
> ---
> dr
On Wed, Jun 21, 2017 at 10:54 AM, John Fastabend
wrote:
> On 06/21/2017 10:27 AM, Daniel Borkmann wrote:
>> Fill the bpf_prog with the id just like we do in other XDP enabled
>> drivers.
>>
>> Signed-off-by: Daniel Borkmann
>> Cc: Martin KaFai Lau
>> Cc: Alexander Duyck
>> ---
>> drivers/net/e
In order to be able to retrieve the attached programs from cls_bpf
and act_bpf, we need to expose the prog ids via netlink so that
an application can later on get an fd based on the id through the
BPF_PROG_GET_FD_BY_ID command, and dump related prog info via
BPF_OBJ_GET_INFO_BY_FD command for bpf(2
This fix coding style issues detected by running checkpatch.pl -f
option on files under net/hsr.
Signed-off-by: Murali Karicheri
---
- applies to net-next/master
- Test logs at http://pastebin.ubuntu.com/24917637/
net/hsr/hsr_device.c | 49 +
net/hsr/hsr_forward.c | 72
On 06/19/2017 03:18 PM, Joe Perches wrote:
Joe Perches (5):
rtlwifi: Use temporary ops variable to reduce code size
rtlwifi: Use temporary variable btc_ops for rtlpriv->btcoexist.btc_ops
rtlwifi: Add and use convenience macro rtl_btc
realtek: btcoexist: Make the rtl_btc_ops struct con
In the ethtool -i output print the vio version and the remote-mac
of the ldom that the vif device is serving as this vif info is
not exposed elsewhere. The remote-mac address is most useful for
tracking which client ldom is being served by the vif.
Orabug: 26316362
Signed-off-by: Shannon Nelson
Hi!
> > > Or not, having an RTC set in the past is actually quite common. I'd find
> > > it weird to have a new device boot and be set to a date in the future.
> >
> > ...but still better than board stuck in the past, no?
> >
> > > Also note that the threshold or offset thing may seem like a goo
The function below contains a BUG_ON where no active slave is detected. The
patch
converts this to a WARN_ON to avoid crashing the kernel.
Signed-off-by: Michael J Dilmore
---
drivers/net/bonding/bond_options.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bond
Add the get_settings callback so that both the ldmvsw and sunvnet
drivers will give a little more information when asked for its
basic settings. These aren't necessarily very useful, but they
make some users happier. Also, a side effect is that the speed
attribute in /sys/class/net/ is now readab
When sending a cache report on mroute6_sk, mroute6 will emit a
"pending queue full" warning for every error value returned by
sock_queue_rcv_skb().
This warning can be misleading, for example on the EPERM error value
that sk_filter() can return.
Restricting this warning to only ENOMEM or ENOBUFS s
When sending a cache report on mroute_sk, mroute will emit a
"pending queue full" warning for every error value returned by
sock_queue_rcv_skb().
This warning can be misleading, for example on the EPERM error value
that sk_filter() can return.
Restricting this warning to only ENOMEM or ENOBUFS see
On 06/21/2017 10:27 AM, Daniel Borkmann wrote:
> Fill the bpf_prog with the id just like we do in other XDP enabled
> drivers.
>
> Signed-off-by: Daniel Borkmann
> Cc: Martin KaFai Lau
> Cc: Alexander Duyck
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +
> 1 file changed, 1 insertio
On Wed, Jun 21, 2017 at 3:09 PM, Andrey Konovalov wrote:
> On Wed, Jun 21, 2017 at 2:08 PM, Andrey Konovalov
> wrote:
>> Hi,
>>
>> I've got the following error report while fuzzing the kernel with syzkaller.
>>
>> On commit 9705596d08ac87c18aee32cc97f2783b7d14624e (4.12-rc6+).
>>
>> It might be
The first patch gets some driver-specific information available for
use by the LDom management utilities through the drvinfo service: the
lowlevel vio version into firmware-version field, and, most importantly,
the remote-mac address into the bus-info field.
When creating the LDoms and their netwo
Fill the bpf_prog with the id just like we do in other XDP enabled
drivers.
Signed-off-by: Daniel Borkmann
Cc: Martin KaFai Lau
Cc: Alexander Duyck
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
b
On Wed, Jun 21, 2017 at 12:51 PM, Lawrence Brakmo wrote:
>
> On 6/20/17, 2:25 PM, "Craig Gallek" wrote:
>
> On Mon, Jun 19, 2017 at 11:00 PM, Lawrence Brakmo wrote:
> > Added support for calling a subset of socket setsockopts from
> > BPF_PROG_TYPE_SOCK_OPS programs. The code was dup
This function compiles to 147 bytes of machine code. 13 callsites.
I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
SCTP events are not happening on every packet.
They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such.
Does not look performance critical.
Signed-o
On Wed, Jun 21, 2017 at 06:28:09PM +0200, Denys Vlasenko wrote:
> This function compiles to 147 bytes of machine code. 13 callsites.
>
> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
> SCTP events are not happening on every packet.
> They are ASSOC_CHANGE, PEER_ADDR_CH
On 6/20/17, 2:25 PM, "Craig Gallek" wrote:
On Mon, Jun 19, 2017 at 11:00 PM, Lawrence Brakmo wrote:
> Added support for calling a subset of socket setsockopts from
> BPF_PROG_TYPE_SOCK_OPS programs. The code was duplicated rather
> than making the changes to call the socket sets
From: Jeff Kirsher
Date: Tue, 20 Jun 2017 18:17:47 -0700
> This series contains updates to i40e and i40evf only.
Pulled, thanks Jeff.
...
> Björn adds additional XDP support for i40e, by adding pass and drop actions
> and XDP_TX action support.
So nice to see this.
From: Hayes Wang
Date: Wed, 21 Jun 2017 11:25:18 +0800
> Replace VLAN_HLEN and CRC_SIZE with ETH_FCS_LEN.
>
> Signed-off-by: Hayes Wang
Applied.
From: Yuval Mintz
Date: Wed, 21 Jun 2017 08:26:34 +0300
> From: Chad Dupuis
>
> When CONFIG_QED_RDMA isn't defined, we'd hit the following:
>
> /include/linux/qed/qede_rdma.h:84:19:
> warning: ‘qede_rdma_dev_add’ used but never defined [enabled by default]
> static inline int qede_rdma_dev_
On Wed, 21 Jun 2017 16:04:43 +0300
Gal Pressman wrote:
> Hi All,
>
> Currently, drivers can only tell whether the link is up/down through
> ETHTOOL_GLINK callback, but no additional information is given in case
> of link down/failure.
>
> This series provides an infrastructure to ethtool that a
> > > - /*
> > > - * For response or local service set_timeout request,
> > > - * there is no need to use netlink_dump_start.
> > > - */
> > > - if (!(nlh->nlmsg_flags & NLM_F_REQUEST) ||
> > > - (index == RDMA_NL_LS && op == RDMA_NL_LS_OP_SET_TIMEOUT)) {
> > > - cb.skb = skb;
> > >
Caesar Wang wrote:
> This patch uses WARN level is not printed by default.
>
> In some cases, some boards have always met the unused log be printed as
> follows.
> ...
> [23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp:
> cannot find cfp by band 2& channel=13 freq=0
> [23378.633684]
Shawn Lin wrote:
> debugfs_remove already check mwifiex_dfs_dir, so remove it.
>
> Signed-off-by: Shawn Lin
Patch applied to wireless-drivers-next.git, thanks.
7c26029f87a3 mwifiex: debugfs: remove redunant check of mwifiex_dfs_dir
--
https://patchwork.kernel.org/patch/9788425/
https://wir
On Wed, 21 Jun 2017 11:14:22 -0400
Roman Mashak wrote:
> Signed-off-by: Roman Mashak
Applied
From: Julien Gomes
Date: Tue, 20 Jun 2017 13:54:14 -0700
> Currently, all ipmr/ip6mr cache reports are sent through the
> mroute/mroute6 socket only.
> This forces the use of a single socket for mroute programming, cache
> reports and, regarding ipmr, IGMP messages without Router Alert option
> r
On Mon, 19 Jun 2017 15:52:25 -0400
Roman Mashak wrote:
> Signed-off-by: Roman Mashak
Applied
On Wed, 21 Jun 2017 16:04:44 +0300
Gal Pressman wrote:
> +
> +enum {
> + ETHTOOL_LINK_VENDOR_SPECIFIC = -1, /* Vendor specific issue provided in
> vendor_reason */
> + ETHTOOL_LINK_NO_ISSUE, /* No issue observed with link */
> + ETHTOOL_LINK_REASON_UNKNOWN, /* Unknown reason */
> +
On Wed, Jun 21, 2017 at 05:42:11PM +0300, Leon Romanovsky wrote:
> On Wed, Jun 21, 2017 at 09:28:12AM -0500, Steve Wise wrote:
> > > From: Leon Romanovsky
> > >
> > > This patch implements the query interface to get all
> > > ports data for the specific device.
> > >
> > > Signed-off-by: Leon Roma
From: Arnd Bergmann
Date: Tue, 20 Jun 2017 22:11:21 +0200
> Changing from a memcpy to per-member comparison left the
> size variable unused:
>
> net/ipv4/tcp_ipv4.c: In function 'tcp_md5_do_lookup':
> net/ipv4/tcp_ipv4.c:910:15: error: unused variable 'size'
> [-Werror=unused-variable]
>
> Thi
On Wed, Jun 21, 2017 at 09:05:17AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Provide ability to convert from device name to ib_device for the
> IB/core users.
FWIW, as a general comment, we really need to start using some kind of
device index like netdev does instead of the name.
On 06/21/2017 04:26 PM, Shubham Bansal wrote:
[...]
So ultimately, we call helper_function which takes u64 as arguments
only. I know its asking a lot, but can you please confirm this asap? I
would like to start implementing it.
Yes, that is correct. I think it would be the better, more generic
On Wed, Jun 21, 2017 at 09:05:22AM +0300, Leon Romanovsky wrote:
> RDMA_NL_IWCM,
> RDMA_NL_RSVD,
> RDMA_NL_LS, /* RDMA Local Services */
> + /*
> + * RDMA_NL_I40IW not in use and it was added here by mistake,
> + * but we need to keep it anyway, because it is UAP
This function compiles to 147 bytes of machine code. 13 callsites.
I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
SCTP events are not happening on every packet.
They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such.
Does not look performance critical.
Signed-o
> -Original Message-
> From: Steffen Klassert [mailto:steffen.klass...@secunet.com]
> Sent: Wednesday, June 21, 2017 2:38 PM
> To: Yossi Kuperman
> Cc: netdev@vger.kernel.org; Herbert Xu ;
> Yevgeny Kliteynik ; Boris Pismenny
> ; Ilan Tayari
> Subject: Re: [PATCH net 1/2] xfrm6: Fix IPv
On Wed, 2017-06-21 at 11:41 -0400, David Miller wrote:
> From: Paolo Abeni
> Date: Wed, 21 Jun 2017 10:24:40 +0200
>
> > On UDP packets processing, if the BH is the bottle-neck, it
> > always sees a cache miss while updating rmem_alloc; try to
> > avoid it prefetching the value as soon as we have
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com]
> Sent: Wednesday, June 21, 2017 11:12 AM
> To: Leon Romanovsky
> Cc: Doug Ledford ; linux-r...@vger.kernel.org; Tung,
> Chien Tin ; Steve Wise
> ; Stephen Hemminger
> ; Jiri Pirko ; Ariel Almog
> ; Linux Netdev ; Leon
> Romanovsky
From: Serhey Popovych
Date: Wed, 21 Jun 2017 12:35:12 +0300
>
>>
>>> From: Serhey Popovych
>>> Date: Fri, 16 Jun 2017 15:10:03 +0300
>>>
Now with commit 9c7dafb (net: Allow to create links with
given ifindex) support registration of network devices
with specific ifindex is added
From: Paolo Abeni
Date: Wed, 21 Jun 2017 10:24:40 +0200
> On UDP packets processing, if the BH is the bottle-neck, it
> always sees a cache miss while updating rmem_alloc; try to
> avoid it prefetching the value as soon as we have the socket
> available.
>
> Performances under flood with multipl
From: Paolo Abeni
Date: Wed, 21 Jun 2017 11:45:31 +0200
> for connected socket, the incoming_cpu field in the sock struct
> is not going to change frequently, but we are setting it
> unconditionally for each packet.
>
> Since sk_incoming_cpu and sk_flags share the same cacheline,
> and the latte
From: David Herrmann
Date: Wed, 21 Jun 2017 10:47:15 +0200
> This adds the new getsockopt(2) option SO_PEERGROUPS on SOL_SOCKET to
> retrieve the auxiliary groups of the remote peer.
...
Looks good, applied, thanks.
Signed-off-by: Roman Mashak
---
man/man8/tc-u32.8 | 11 +++
1 file changed, 11 insertions(+)
diff --git a/man/man8/tc-u32.8 b/man/man8/tc-u32.8
index 691f53c..e9475a9 100644
--- a/man/man8/tc-u32.8
+++ b/man/man8/tc-u32.8
@@ -29,6 +29,10 @@ u32 \- universal 32bit traffic control filter
On Wed, Jun 21, 2017 at 09:09:27AM -0500, Steve Wise wrote:
> > From: Leon Romanovsky
> >
> > Provide ability to convert from device name to ib_device for the
> > IB/core users.
> >
> > Signed-off-by: Leon Romanovsky
> > ---
> > drivers/infiniband/core/core_priv.h | 1 +
> > drivers/infiniband/c
On Wed, Jun 21, 2017 at 09:18:25AM -0500, Steve Wise wrote:
> > From: Leon Romanovsky
> >
> > RDMA_NL_LS protocol is actually is not dump anything,
>
> nit: "is not" -> "does not"
>
> > but sets data and it should be handled by doit callback.
> >
> > This patch actually converts RDMA_NL_LS to doi
On Wed, Jun 21, 2017 at 09:28:12AM -0500, Steve Wise wrote:
> > From: Leon Romanovsky
> >
> > This patch implements the query interface to get all
> > ports data for the specific device.
> >
> > Signed-off-by: Leon Romanovsky
>
> The fill_port/dev_info is just filling in names and indexes. Shoul
On 2017/6/21 21:40, Kalle Valo wrote:
Jia-Ju Bai writes:
On 06/21/2017 02:11 PM, Kalle Valo wrote:
David Miller writes:
From: Jia-Ju Bai
Date: Mon, 19 Jun 2017 10:48:53 +0800
The driver may sleep under a spin lock, and the function call path is:
netxen_nic_pci_mem_access_direct (acquire
> From: Leon Romanovsky
>
> The port capability mask is exposed to user space via sysfs interface,
> while device capabilities are available for verbs only.
>
> This patch provides those capabilities through netlink interface.
>
> Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
> From: Leon Romanovsky
>
> Provide ability to get specific to device and port information.
>
> Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
> From: Leon Romanovsky
>
> This patch implements the query interface to get all
> ports data for the specific device.
>
> Signed-off-by: Leon Romanovsky
The fill_port/dev_info is just filling in names and indexes. Shouldn't it have
all kinds of goodies about the port/dev? Will this be enhan
> From: Leon Romanovsky
>
> Provide ability to query specific device.
>
> Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
Hi Daniel,
>
> So my question would be, why can't the JIT imitate something
> similar to what we do in the interpreter as well? So looking
> at the disasm of what gcc compiles for the interpreter when it's
> doing the above call could help as well in going forward. Not
> sure if that answers your
> From: Leon Romanovsky
>
> This patch adds the ability to return all available devices
> together with their properties.
>
> Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
> From: Leon Romanovsky
>
> Add nldev init and exit flows to the RDMA/core.
>
> Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
Hello, important charity foundation proposal to discuss with you, if you are
interested please reply urgently for details.
with love,
CELINE
> From: Leon Romanovsky
>
> Introduce new defines to rdma_netlink.h, so the RDMA configuration tool
> will be able to communicate with RDMA subsystem by using the shared defines.
>
> The addition of new client (NLDEV) revealed the fact that we exposed by
> mistake the RDMA_NL_I40IW define which
> From: Leon Romanovsky
>
> Add Mellanox to the copyright header.
>
> Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
> From: Leon Romanovsky
>
> RDMA_NL_LS protocol is actually is not dump anything,
nit: "is not" -> "does not"
> but sets data and it should be handled by doit callback.
>
> This patch actually converts RDMA_NL_LS to doit callback, while
> preserving IWCM and RDMA_CM flows through netlink_dump
> From: Leon Romanovsky
>
> Introduce intermediate variable to store access to fields
> of cb_table.
>
> Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
> From: Leon Romanovsky
>
> The .doit callback is used by netlink core to differentiate
> between get and set operations. Common convention is to use
> that call for command operations like (SET, ADD, e.t.c.) and/or
> access without NLF_M_DUMP flag.
>
> This commit adds proper declaration and im
> From: Leon Romanovsky
>
> Provide ability to convert from device name to ib_device for the
> IB/core users.
>
> Signed-off-by: Leon Romanovsky
> ---
> drivers/infiniband/core/core_priv.h | 1 +
> drivers/infiniband/core/device.c| 3 +--
> 2 files changed, 2 insertions(+), 2 deletions(-)
> From: Leon Romanovsky
>
> The coming nldev needs iterate over all IB devices in the system
> and in order do not expose the ib_devices list outside the devices.c,
> it is necessary to provide function iterator.
nit: "needs iterate over" -> "needs to iterate over..."
nit: "order do" -> "order t
> From: Leon Romanovsky
>
> The RDMA netlink client infrastructure was removed and made
> obsolete the old name (ibnl_client_cbs). This patch renames
> to the more appropriate name (rdma_nl_cbs).
>
> Signed-off-by: Leon Romanovsky
Looks good.
Reviewed-by: Steve Wise
> From: Leon Romanovsky
>
> Make ibnl_chk_listeners function to be one line by removing
> unneeded comparison.
>
> Rename that function to be complaint to other functions in RDMA netlink.
>
> Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
> From: Leon Romanovsky
>
> The pointer to netlink header was not used in the ibnl_multicast
> function, so let's remove it and simplify the function
> signature.
>
> Signed-off-by: Leon Romanovsky
Looks good.
Reviewed-by: Steve Wise
> +static int mlx5e_get_link_down_reason(struct net_device *netdev,
> + struct ethtool_link_down_reason *ldr)
> +{
> + struct mlx5e_priv *priv = netdev_priv(netdev);
> + u16 monitor_opcode;
> + int err;
> +
> + if (!netif_running(netdev)) {
> +
From: yuan linyu
when CONFIG_IP_MULTIPLE_TABLES defined,
if id == RT_TABLE_LOCAL and !net->ipv4.fib_has_custom_rules,
fib_new_table() call itself to get RT_TABLE_MAIN table,
but if RT_TABLE_MAIN table not exist at this point,
this function will become deadloop.
the solution is move RT_TABLE_MAIN
> From: Leon Romanovsky
>
> Netlink message header is not needed for unicast reply, hence remove it.
>
> Signed-off-by: Leon Romanovsky
Looks good.
Reviewed-by: Steve Wise
> From: Leon Romanovsky
>
> Reuse standard macros to cancel the netlink message
> in case of error.
>
> Signed-off-by: Leon Romanovsky
Looks good.
Reviewed-by: Steve Wise
> From: Leon Romanovsky
>
> Add ability to provide flags to control RDMA netlink callbacks
> and convert addr.c and sa_query.c to be first users of such
> infrastructure. It allows to move their CAP_NET_ADMIN checks
> into netlink core.
>
> Signed-off-by: Leon Romanovsky
Looks fine.
Reviewed-
> +enum {
> + ETHTOOL_LINK_VENDOR_SPECIFIC = -1, /* Vendor specific issue provided in
> vendor_reason */
> + ETHTOOL_LINK_NO_ISSUE, /* No issue observed with link */
> + ETHTOOL_LINK_REASON_UNKNOWN, /* Unknown reason */
I think OTHER would be better that UNKNOWN.
> + ETHTOOL_LIN
On 21/06/17 14:54, Sergey Matyukevich wrote:
>> The return value ret is unitialized and garbage is being returned
>> for the three different error conditions when setting up the PCIe
>> BARs. Fix this by initializing ret to -ENOMEM to indicate that
>> the BARs failed to be setup correctly.
>>
>> D
> The return value ret is unitialized and garbage is being returned
> for the three different error conditions when setting up the PCIe
> BARs. Fix this by initializing ret to -ENOMEM to indicate that
> the BARs failed to be setup correctly.
>
> Detected by CoverityScan, CID#1437563 ("Unitialized
> A stray semicolon was introduced by bbfcd1e8e1677b (qed*: Set rdma
> generic functions prefix), remove it.
Hi Mark,
Thanks, but I've already sent the same
http://marc.info/?l=linux-netdev&m=149802281509733&w=2
Thanks,
Yuval
From: yuan linyu
Date: Wed, 21 Jun 2017 20:04:40 +0800
> From: yuan linyu
>
> in my commit b952f4dff2751252db073c27c0f8a16a416a2ddc,
> - *(u8 *)skb_put(skb_out, 1) = (u8)(accm >> 24); \
> + skb_put(skb_out, (u8)(accm >> 24)); \
> it should skb_put_u8()
>
> Fixes: b952f4dff275 ("ne
Jia-Ju Bai writes:
> On 06/21/2017 02:11 PM, Kalle Valo wrote:
>> David Miller writes:
>>
>>> From: Jia-Ju Bai
>>> Date: Mon, 19 Jun 2017 10:48:53 +0800
>>>
The driver may sleep under a spin lock, and the function call path is:
netxen_nic_pci_mem_access_direct (acquire the lock by spin
> drivers/net/ph/marvell.c
> marvell_set_loopback(struct phy_device *dev, bool enable)
> {
> /* do some device specific setting */
>
>
> return genphy_loopback(dev, enable);
> }
>
> I don't know if this makes sense or not?
Nope, you want something in phy.c like this. N
Hi Kalle,
On Wed, 21 Jun 2017 16:29:29 +0300 Kalle Valo wrote:
>
> Thanks, the fix looks good to me. I guess there's nothing I can do at
> the moment and Linus needs to fix this when he pulls from Dave (or
> Bjorn, whichever is the last)?
Right.
--
Cheers,
Stephen Rothwell
101 - 200 of 259 matches
Mail list logo
