Re: [PATCH v3] datapath: Avoid using stack larger than 1024.

2017-06-29 Thread Tonghao Zhang
Thanks for your works. I send v3 for net-next and add "Acked-by". If it is applied, I will backport it to d...@openvswitch.org. On Fri, Jun 30, 2017 at 1:45 AM, Pravin Shelar wrote: > On Wed, Jun 28, 2017 at 6:38 PM, Tonghao Zhang > wrote: >> When

Re: [PATCH RFC 0/2] kproxy: Kernel Proxy

2017-06-29 Thread Willy Tarreau
On Thu, Jun 29, 2017 at 04:43:28PM -0700, Tom Herbert wrote: > On Thu, Jun 29, 2017 at 1:58 PM, Willy Tarreau wrote: > > On Thu, Jun 29, 2017 at 01:40:26PM -0700, Tom Herbert wrote: > >> > In fact that's not much what I observe in field. In practice, large > >> > data streams are

Re: [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support (fwd)

2017-06-29 Thread Julia Lawall
Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support Hi Atul, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Atul-Gupta/cxgb4-Add-PTP-Hardware-Clock-PHC-support/20170629-200758 ::

[PATCH net-next 09/11] sctp: remove the typedef sctp_data_chunk_t

2017-06-29 Thread Xin Long
This patch is to remove the typedef sctp_data_chunk_t, and replace with struct sctp_data_chunk in the places where it's using this typedef. Signed-off-by: Xin Long --- include/linux/sctp.h | 4 ++-- include/net/sctp/constants.h | 2 +- include/net/sctp/sm.h

[PATCH net-next 08/11] sctp: remove the typedef sctp_datahdr_t

2017-06-29 Thread Xin Long
This patch is to remove the typedef sctp_datahdr_t, and replace with struct sctp_datahdr in the places where it's using this typedef. It is also to use izeof(variable) instead of sizeof(type). Signed-off-by: Xin Long --- include/linux/sctp.h| 6 +++---

[PATCH net-next 11/11] sctp: remove the typedef sctp_init_chunk_t

2017-06-29 Thread Xin Long
This patch is to remove the typedef sctp_init_chunk_t, and replace with struct sctp_init_chunk in the places where it's using this typedef. Signed-off-by: Xin Long --- include/linux/sctp.h | 6 +++--- include/net/sctp/command.h | 4 ++-- include/net/sctp/structs.h

[PATCH net-next 10/11] sctp: remove the typedef sctp_inithdr_t

2017-06-29 Thread Xin Long
This patch is to remove the typedef sctp_inithdr_t, and replace with struct sctp_inithdr in the places where it's using this typedef. Signed-off-by: Xin Long --- include/linux/sctp.h| 6 +++--- net/netfilter/nf_conntrack_proto_sctp.c | 4 ++--

[PATCH net-next 06/11] sctp: remove the typedef sctp_param_t

2017-06-29 Thread Xin Long
This patch is to remove the typedef sctp_param_t, and replace with struct sctp_paramhdr in the places where it's using this typedef. It is also to remove the useless declaration sctp_addip_addr_config and fix the lack of params for some other functions' declaration. Signed-off-by: Xin Long

[PATCH net-next 05/11] sctp: remove the typedef sctp_paramhdr_t

2017-06-29 Thread Xin Long
This patch is to remove the typedef sctp_paramhdr_t, and replace with struct sctp_paramhdr in the places where it's using this typedef. It is also to fix some indents and use sizeof(variable) instead of sizeof(type). Signed-off-by: Xin Long --- include/linux/sctp.h

[PATCH net-next 07/11] sctp: remove the typedef sctp_param_action_t

2017-06-29 Thread Xin Long
Remove this typedef, there is even no places using it. Signed-off-by: Xin Long --- include/linux/sctp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/sctp.h b/include/linux/sctp.h index 5eecc0f..d5c0dda 100644 ---

[PATCH net-next 01/11] sctp: remove the typedef sctp_sctphdr_t

2017-06-29 Thread Xin Long
This patch is to remove the typedef sctp_sctphdr_t, and replace with struct sctphdr in the places where it's using this typedef. It is also to fix some indents and use sizeof(variable) instead of sizeof(type). Signed-off-by: Xin Long --- include/linux/sctp.h

[PATCH net-next 04/11] sctp: remove the typedef sctp_cid_action_t

2017-06-29 Thread Xin Long
Remove this typedef, there is even no places using it. Signed-off-by: Xin Long --- include/linux/sctp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/sctp.h b/include/linux/sctp.h index 6d7b884..ffdccb4 100644 ---

[PATCH net-next 03/11] sctp: remove the typedef sctp_cid_t

2017-06-29 Thread Xin Long
This patch is to remove the typedef sctp_cid_t, and replace with struct sctp_cid in the places where it's using this typedef. Signed-off-by: Xin Long --- include/linux/sctp.h | 4 ++-- include/net/sctp/auth.h | 6 -- include/net/sctp/constants.h | 4 ++--

[PATCH net-next 02/11] sctp: remove the typedef sctp_chunkhdr_t

2017-06-29 Thread Xin Long
This patch is to remove the typedef sctp_chunkhdr_t, and replace with struct sctp_chunkhdr in the places where it's using this typedef. It is also to fix some indents and use sizeof(variable) instead of sizeof(type)., especially in sctp_new. Signed-off-by: Xin Long ---

[PATCH net-next 00/11] sctp: remove typedefs from structures part 1

2017-06-29 Thread Xin Long
As we know, typedef is suggested not to use in kernel, even checkpatch.pl also gives warnings about it. Now sctp is using it for many structures. All this kind of typedef's using should be removed. As the 1st part, this patchset is to remove it for 11 basic structures in linux/sctp.h. It is also

[PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

2017-06-29 Thread Mikulas Patocka
The __vmalloc function has a parameter gfp_mask with the allocation flags, however it doesn't fully respect the GFP_NOIO and GFP_NOFS flags. The pages are allocated with the specified gfp flags, but the pagetables are always allocated with GFP_KERNEL. This allocation can cause unexpected recursion

Re: kernel (master) build failure w. !CONFIG_NET_RX_BUSY_POLL

2017-06-29 Thread Mike Galbraith
On Thu, 2017-06-29 at 15:35 -0400, David Miller wrote: > From: Mike Galbraith > Date: Wed, 28 Jun 2017 10:01:00 +0200 > > > Greetings network wizards, > > > > The latest RT explicitly disables CONFIG_NET_RX_BUSY_POLL, thus > > uncovering $subject.  Below is what I did about it. >

Re: [PATCH] mm: convert three more cases to kvmalloc

2017-06-29 Thread Mikulas Patocka
On Thu, 29 Jun 2017, Michal Hocko wrote: > On Wed 28-06-17 23:24:10, Mikulas Patocka wrote: > [...] > > From: Mikulas Patocka > > > > The patch a7c3e901 ("mm: introduce kv[mz]alloc helpers") converted a lot > > of kernel code to kvmalloc. This patch converts three more

Re: RFC: bring UP 'lo' by default after creating new netns

2017-06-29 Thread Eric W. Biederman
"Mahesh Bandewar (महेश बंडेवार)" writes: > Creation of new network namespace is almost always followed up by > bringing up the loopback device. > > ip netns add foo > ip -netns foo link set lo up > > I'm not sure if there are any consequences of bringing the

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-29 Thread Scott Branden
Hi Rob, On 17-06-29 03:40 PM, Rob Herring wrote: On Tue, Jun 27, 2017 at 12:10 AM, Scott Branden wrote: Hi Rob/Florian, Thanks for input but still don't see any need for SoC specific compatible stings. IP revision specific yes. On 17-06-22 06:04 PM, Florian

linux-next: manual merge of the net-next tree with Linus' tree

2017-06-29 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/rocker/rocker_ofdpa.c between commit: acb4b7df48b5 ("rocker: move dereference before free") from Linus' tree and commit: 00fc0c51e35b ("rocker: Change world_ops API and implementation to be

Re: [PATCH RFC 0/2] kproxy: Kernel Proxy

2017-06-29 Thread Thomas Graf
On 29 June 2017 at 16:21, Tom Herbert wrote: > I think the main part of that discussion was around stream parser > which is needed for message delineation. For a 1:1 proxy, KCM is > probably overkill (the whole KCM data path and lock becomes > superfluous). Also, there's no

[PATCH net-next v3] datapath: Avoid using stack larger than 1024.

2017-06-29 Thread nickcooper-zhangtonghao
From: Tonghao Zhang When compiling OvS-master on 4.4.0-81 kernel, there is a warning: CC [M] /root/ovs/datapath/linux/datapath.o /root/ovs/datapath/linux/datapath.c: In function 'ovs_flow_cmd_set': /root/ovs/datapath/linux/datapath.c:1221:1: warning:

Re: [PATCH RFC 25/26] tile: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
On Thu, Jun 29, 2017 at 05:10:41PM -0700, Linus Torvalds wrote: > On Thu, Jun 29, 2017 at 5:06 PM, Linus Torvalds > wrote: > > > > Please don't make this one commit fopr every architecture. > > > > Once something gets removed, it gets removed. There's no point in >

Re: [PATCH RFC 25/26] tile: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
On Thu, Jun 29, 2017 at 05:09:56PM -0700, Paul E. McKenney wrote: > On Thu, Jun 29, 2017 at 05:06:16PM -0700, Linus Torvalds wrote: > > On Thu, Jun 29, 2017 at 5:01 PM, Paul E. McKenney > > wrote: > > > There is no agreed-upon definition of spin_unlock_wait()'s

[PATCH RFC 05/26] exit: Replace spin_unlock_wait() with lock/unlock pair

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in do_exit() with spin_lock() followed immediately by spin_unlock(). This should be safe

[PATCH RFC 17/26] metag: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 10/26] arc: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 02/26] task_work: Replace spin_unlock_wait() with lock/unlock pair

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in task_work_run() with spin_lock() followed immediately by spin_unlock(). This should be

[PATCH RFC 16/26] m32r: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 25/26] tile: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 03/26] sched: Replace spin_unlock_wait() with lock/unlock pair

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in do_task_dead() with spin_lock() followed immediately by spin_unlock(). This should be

Re: [PATCH RFC 25/26] tile: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Linus Torvalds
On Thu, Jun 29, 2017 at 5:06 PM, Linus Torvalds wrote: > > Please don't make this one commit fopr every architecture. > > Once something gets removed, it gets removed. There's no point in > "remove it from architecture X". If there are no more users, we're > done

Re: [PATCH RFC 25/26] tile: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
On Thu, Jun 29, 2017 at 05:06:16PM -0700, Linus Torvalds wrote: > On Thu, Jun 29, 2017 at 5:01 PM, Paul E. McKenney > wrote: > > There is no agreed-upon definition of spin_unlock_wait()'s semantics, > > and it appears that all callers could do just as well with a

[PATCH RFC 04/26] completion: Replace spin_unlock_wait() with lock/unlock pair

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in completion_done() with spin_lock() followed immediately by spin_unlock(). This should

[PATCH RFC 18/26] mips: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 13/26] blackfin: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 07/26] drivers/ata: Replace spin_unlock_wait() with lock/unlock pair

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore eliminates the spin_unlock_wait() call and associated else-clause and hoists the then-clause's lock and unlock out of the "if"

Re: [PATCH RFC 25/26] tile: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Linus Torvalds
On Thu, Jun 29, 2017 at 5:01 PM, Paul E. McKenney wrote: > There is no agreed-upon definition of spin_unlock_wait()'s semantics, > and it appears that all callers could do just as well with a lock/unlock > pair. This commit therefore removes the underlying

[PATCH RFC 15/26] ia64: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 14/26] hexagon: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 12/26] arm64: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 19/26] mn10300: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 22/26] s390: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 21/26] powerpc: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() calls in nf_conntrack_lock() and nf_conntrack_all_lock() with spin_lock() followed immediately

[PATCH RFC 24/26] sparc: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 23/26] sh: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 26/26] xtensa: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 20/26] parisc: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 09/26] alpha: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 06/26] ipc: Replace spin_unlock_wait() with lock/unlock pair

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in exit_sem() with spin_lock() followed immediately by spin_unlock(). This should be safe

[PATCH RFC 11/26] arm: Remove spin_unlock_wait() arch-specific definitions

2017-06-29 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait(). Signed-off-by: Paul E. McKenney

[PATCH RFC 0/26] Remove spin_unlock_wait()

2017-06-29 Thread Paul E. McKenney
Hello! There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This series therefore removes spin_unlock_wait() and changes its users to instead use a lock/unlock pair. The commits are as follows, in

RFC: bring UP 'lo' by default after creating new netns

2017-06-29 Thread महेश बंडेवार
Creation of new network namespace is almost always followed up by bringing up the loopback device. ip netns add foo ip -netns foo link set lo up I'm not sure if there are any consequences of bringing the device UP at the creation of network-namespace. thanks, --mahesh.. diff

Re: [PATCH RFC 0/2] kproxy: Kernel Proxy

2017-06-29 Thread Tom Herbert
On Thu, Jun 29, 2017 at 1:58 PM, Willy Tarreau wrote: > On Thu, Jun 29, 2017 at 01:40:26PM -0700, Tom Herbert wrote: >> > In fact that's not much what I observe in field. In practice, large >> > data streams are cheaply relayed using splice(), I could achieve >> > 60 Gbps of HTTP

Re: [PATCH RFC 0/2] kproxy: Kernel Proxy

2017-06-29 Thread Tom Herbert
On Thu, Jun 29, 2017 at 3:04 PM, Thomas Graf wrote: > Hi Tom > > On 29 June 2017 at 11:27, Tom Herbert wrote: >> This is raw, minimally tested, and error hanlding needs work. Posting >> as RFC to get feedback on the design... >> >> Sidecar proxies are

Re: CAN-FD Transceiver Limitations

2017-06-29 Thread Franklin S Cooper Jr
On 06/29/2017 05:36 PM, Kurt Van Dijck wrote: mcan@0 { ... fixed-transceiver { max-canfd-speed = <2000> }; ... }; > > Since when would a transceiver support different speeds for CAN & CANFD? When I say CAN I'm referring to CAN 2.0

[PATCH 03/29] netfilter: dup: resolve warnings about missing prototypes

2017-06-29 Thread Pablo Neira Ayuso
From: stephen hemminger Missing include file causes: net/netfilter/nf_dup_netdev.c:26:6: warning: no previous prototype for ‘nf_fwd_netdev_egress’ [-Wmissing-prototypes] net/netfilter/nf_dup_netdev.c:40:6: warning: no previous prototype for ‘nf_dup_netdev_egress’

Re: [PATCH] sctp: Add peeloff-flags socket option

2017-06-29 Thread Al Viro
On Thu, Jun 29, 2017 at 02:13:40PM -0400, Neil Horman wrote: > diff --git a/fs/file.c b/fs/file.c > index 1c2972e..a4521da 100644 > --- a/fs/file.c > +++ b/fs/file.c > @@ -807,6 +807,7 @@ void set_close_on_exec(unsigned int fd, int flag) > __clear_close_on_exec(fd, fdt); >

[PATCH 01/29] netfilter: ctnetlink: delete extra spaces

2017-06-29 Thread Pablo Neira Ayuso
From: linzhang This patch cleans up extra spaces. Signed-off-by: linzhang Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_conntrack_netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 04/29] netfilter: nft_rt: make local functions static

2017-06-29 Thread Pablo Neira Ayuso
From: stephen hemminger Resolves warnings: net/netfilter/nft_rt.c:26:6: warning: no previous prototype for ‘nft_rt_get_eval’ [-Wmissing-prototypes] net/netfilter/nft_rt.c:75:5: warning: no previous prototype for ‘nft_rt_get_init’ [-Wmissing-prototypes]

Re: [PATCH net-next v3 0/9] introduce flower offload capabilities

2017-06-29 Thread Jakub Kicinski
On Thu, 29 Jun 2017 22:08:10 +0200, Simon Horman wrote: > Hi, > > this series adds flower offload to the NFP driver. It builds on recent > work to add representor and a skeleton flower app - now the app does what > its name says. > > In general the approach taken is to allow some flows within >

[PATCH 18/29] netfilter: nft_set_hash: add lookup variant for fixed size hashtable

2017-06-29 Thread Pablo Neira Ayuso
This patch provides a faster variant of the lookup function for 2 and 4 byte keys. Optimizing the one byte case is not worth, as the set backend selection will always select the bitmap set type for such case. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_set_hash.c

[PATCH 07/29] netfilter: conntrack: add nf_ct_iterate_destroy

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal sledgehammer to be used on module unload (to remove affected conntracks from all namespaces). It will also flag all unconfirmed conntracks as dying, i.e. they will not be committed to main table. Signed-off-by: Florian Westphal

[PATCH 08/29] netfilter: conntrack: restart iteration on resize

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal We could some conntracks when a resize occurs in parallel. Avoid this by sampling generation seqcnt and doing a restart if needed. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso ---

[PATCH 05/29] netfilter: conntrack: rename nf_ct_iterate_cleanup

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal There are several places where we needlesly call nf_ct_iterate_cleanup, we should instead iterate the full table at module unload time. This is a leftover from back when the conntrack table got duplicated per net namespace. So rename nf_ct_iterate_cleanup

[PATCH 16/29] netfilter: nf_tables: allow large allocations for new sets

2017-06-29 Thread Pablo Neira Ayuso
The new fixed size hashtable backend implementation may result in a large array of buckets that would spew splats from mm. Update this code to fall back on vmalloc in case the memory allocation order is too costly. Signed-off-by: Pablo Neira Ayuso ---

[PATCH 00/29] Netfilter updates for net-next

2017-06-29 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter updates for your net-next tree. This batch contains connection tracking updates for the cleanup iteration path, patches from Florian Westphal: X) Skip unconfirmed conntracks in nf_ct_iterate_cleanup_net(), just set dying bit to let the CPU

[PATCH 17/29] netfilter: nft_set_hash: add non-resizable hashtable implementation

2017-06-29 Thread Pablo Neira Ayuso
This patch adds a simple non-resizable hashtable implementation. If the user specifies the set size, then this new faster hashtable flavour is selected. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_set_hash.c | 210 +-- 1

[PATCH 12/29] netfilter: nft_set_hash: use nft_rhash prefix for resizable set backend

2017-06-29 Thread Pablo Neira Ayuso
This patch prepares the introduction of a non-resizable hashtable implementation that is significantly faster. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_set_hash.c | 212 +-- 1 file changed, 106 insertions(+), 106

[PATCH 14/29] netfilter: nf_tables: pass set description to ->privsize

2017-06-29 Thread Pablo Neira Ayuso
The new non-resizable hashtable variant needs this to calculate the size of the bucket array. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 3 ++- net/netfilter/nf_tables_api.c | 2 +- net/netfilter/nft_set_bitmap.c| 3 ++-

[PATCH 20/29] netfilter: cttimeout: use nf_ct_iterate_cleanup_net to unlink timeout objs

2017-06-29 Thread Pablo Neira Ayuso
From: Liping Zhang Similar to nf_conntrack_helper, we can use nf_ct_iterare_cleanup_net to remove these copy & paste code. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink_cttimeout.c | 39

[PATCH 15/29] netfilter: nft_set_hash: add nft_hash_buckets()

2017-06-29 Thread Pablo Neira Ayuso
Add nft_hash_buckets() helper function to calculate the number of hashtable buckets based on the elements. This function can be reused from the follow up patch to add non-resizable hashtables. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_set_hash.c | 7 ++- 1

[PATCH 19/29] netfilter: nf_ct_helper: use nf_ct_iterate_destroy to unlink helper objs

2017-06-29 Thread Pablo Neira Ayuso
From: Liping Zhang When we unlink the helper objects, we will iterate the nf_conntrack_hash, iterate the unconfirmed list, handle the hash resize situation, etc. Actually this logic is same as the nf_ct_iterate_destroy, so we can use it to remove these copy & paste code.

[PATCH 13/29] netfilter: nf_tables: select set backend flavour depending on description

2017-06-29 Thread Pablo Neira Ayuso
This patch adds the infrastructure to support several implementations of the same set type. This selection will be based on the set description and the features available for this set. This allow us to select set backend implementation that will result in better performance numbers.

[PATCH 26/29] netfilter: use nf_conntrack_helpers_register when possible

2017-06-29 Thread Pablo Neira Ayuso
From: Liping Zhang amanda_helper, nf_conntrack_helper_ras and nf_conntrack_helper_q931 are all arrays, so we can use nf_conntrack_helpers_register to register the ct helper, this will help us to eliminate some "goto errX" statements. Also introduce h323_helper_init/exit

[PATCH 06/29] netfilter: conntrack: don't call iter for non-confirmed conntracks

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal nf_ct_iterate_cleanup_net currently calls iter() callback also for conntracks on the unconfirmed list, but this is unsafe. Acesses to nf_conn are fine, but some users access the extension area in the iter() callback, but that does only work reliably for

[PATCH 23/29] netns: add and use net_ns_barrier

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal Quoting Joe Stringer: If a user loads nf_conntrack_ftp, sends FTP traffic through a network namespace, destroys that namespace then unloads the FTP helper module, then the kernel will crash. Events that lead to the crash: 1. conntrack is created with

[PATCH 09/29] netfilter: nat: destroy nat mappings on module exit path only

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal We don't need pernetns cleanup anymore. If the netns is being destroyed, conntrack netns exit will kill all entries in this namespace, and neither conntrack hash table nor bysource hash are per namespace. For the rmmod case, we have to make sure we remove

[PATCH 24/29] netfilter: ebt: Use new helper ebt_invalid_target to check target

2017-06-29 Thread Pablo Neira Ayuso
From: Gao Feng Use the new helper function ebt_invalid_target instead of the old macro INVALID_TARGET and other duplicated codes to enhance the readability. Signed-off-by: Gao Feng Signed-off-by: Pablo Neira Ayuso ---

[PATCH 25/29] netfilter, kbuild: use canonical method to specify objs.

2017-06-29 Thread Pablo Neira Ayuso
From: Jike Song Should use ":=" instead of "+=". Signed-off-by: Jike Song Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Makefile | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 29/29] netfilter: nfnetlink: extended ACK reporting

2017-06-29 Thread Pablo Neira Ayuso
Pass down struct netlink_ext_ack as parameter to all of our nfnetlink subsystem callbacks, so we can work on follow up patches to provide finer grain error reporting using the new infrastructure that 2d4bc93368f5 ("netlink: extended ACK reporting") provides. No functional change, just pass down

[PATCH 28/29] netfilter: nf_tables: reduce chain type table size

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal text data bss dechex filename old: 151590 2240 1152 154982 25d66 net/netfilter/nf_tables_api.o new: 151666 2240 416 154322 25ad2 net/netfilter/nf_tables_api.o Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira

[PATCH 22/29] netfilter: move table iteration out of netns exit paths

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal We only need to iterate & remove in case of module removal; for netns destruction all conntracks will be removed anyway. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso ---

[PATCH 21/29] netfilter: ipt_CLUSTERIP: do not hold dev

2017-06-29 Thread Pablo Neira Ayuso
From: Xin Long It's a terrible thing to hold dev in iptables target. When the dev is being removed, unregister_netdevice has to wait for the dev to become free. dmesg will keep logging the err: kernel:unregister_netdevice: waiting for veth0_in to become free. \ Usage

[PATCH 27/29] netfilter: conntrack: use NFPROTO_MAX to size array

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal We don't support anything larger than NFPROTO_MAX, so we can shrink this a bit: text data dec hex filename old: 8259 1096 9355 248b net/netfilter/nf_conntrack_proto.o new: 8259 624 8883 22b3 net/netfilter/nf_conntrack_proto.o Signed-off-by:

[PATCH 11/29] netfilter: nf_tables: no size estimation if number of set elements is unknown

2017-06-29 Thread Pablo Neira Ayuso
This size estimation is ignored by the existing set backend selection logic, since this estimation structure is stack allocated, set this to ~0 to make it easier to catch bugs in future changes. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_set_hash.c | 17

[PATCH 02/29] netfilter: ipt_CLUSTERIP: switch to nf_register_net_hook

2017-06-29 Thread Pablo Neira Ayuso
From: Florian Westphal one of the last remaining users of the old api, hopefully followup commit can remove it soon. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/ipt_CLUSTERIP.c | 14

[PATCH 10/29] netfilter: nft_set_hash: unnecessary forward declaration

2017-06-29 Thread Pablo Neira Ayuso
Replace struct rhashtable_params forward declaration by the structure definition itself. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_set_hash.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/net/netfilter/nft_set_hash.c

Re: CAN-FD Transceiver Limitations

2017-06-29 Thread Kurt Van Dijck
> >> > >> mcan@0 { > >>... > >>fixed-transceiver { > >> max-canfd-speed = <2000> > >>}; > >>... > >> }; Since when would a transceiver support different speeds for CAN & CANFD? No transceivers were available, but they are now. I see no datalink problem applying 2MBit for

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-29 Thread Rob Herring
On Tue, Jun 27, 2017 at 12:10 AM, Scott Branden wrote: > Hi Rob/Florian, > > Thanks for input but still don't see any need for SoC specific > compatible stings. IP revision specific yes. > > > On 17-06-22 06:04 PM, Florian Fainelli wrote: >> >> On 06/22/2017 05:42 PM,

Re: [PATCH net-next v4 04/16] bpf: Sample bpf program to set SYN/SYN-ACK RTOs

2017-06-29 Thread Lawrence Brakmo
On 6/29/17, 12:39 PM, "netdev-ow...@vger.kernel.org on behalf of Jesper Dangaard Brouer" wrote: On Wed, 28 Jun 2017 10:31:12 -0700 Lawrence Brakmo wrote: > +++ b/samples/bpf/tcp_synrto_kern.c >

Re: [PATCH RFC 0/2] kproxy: Kernel Proxy

2017-06-29 Thread Thomas Graf
Hi Tom On 29 June 2017 at 11:27, Tom Herbert wrote: > This is raw, minimally tested, and error hanlding needs work. Posting > as RFC to get feedback on the design... > > Sidecar proxies are becoming quite popular on server as a means to > perform layer 7 processing on

RE: [net-next v2 6/6] ixgbe: Add malicious driver detection support

2017-06-29 Thread Tantilov, Emil S
>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Thursday, June 29, 2017 11:28 AM >To: gerlitz...@gmail.com >Cc: Tantilov, Emil S ; Kirsher, Jeffrey T >; Greenwalt, Paul ;

Re: [PATCH RFC 0/2] kproxy: Kernel Proxy

2017-06-29 Thread Willy Tarreau
On Thu, Jun 29, 2017 at 01:40:26PM -0700, Tom Herbert wrote: > > In fact that's not much what I observe in field. In practice, large > > data streams are cheaply relayed using splice(), I could achieve > > 60 Gbps of HTTP forwarding via HAProxy on a 4-core xeon 2 years ago. > > And when you use

Re: [PATCH RFC 0/2] kproxy: Kernel Proxy

2017-06-29 Thread Tom Herbert
Hi Willy, Thanks for the comments! > In fact that's not much what I observe in field. In practice, large > data streams are cheaply relayed using splice(), I could achieve > 60 Gbps of HTTP forwarding via HAProxy on a 4-core xeon 2 years ago. > And when you use SSL, the cost of the copy to/from

[GIT] Networking

2017-06-29 Thread David Miller
1) Need to access netdev->num_rx_queues behind an accessor in netvsc driver otherwise the build breaks with some configs, from Arnd Bergmann. 2) Add dummy xfrm_dev_event() so that build doesn't fail when CONFIG_XFRM_OFFLOAD is not set. From Hangbin Liu. 3) Don't OOPS when

Re: BUG: Dentry ffff9f795a08fe60{i=af565f,n=lo} still in use (1) [unmount of proc proc]

2017-06-29 Thread Andrei Vagin
On Thu, Jun 29, 2017 at 12:06 PM, Eric W. Biederman wrote: > Andrei Vagin writes: > >> Hello, >> >> We run CRIU tests on linus' tree and today we found this issue. >> >> CRIU tests are the set of small programs to check checkpoint/restore >> of different

Re: [PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix

2017-06-29 Thread David Miller
From: Andrew Lunn Date: Thu, 29 Jun 2017 20:22:16 +0200 Is less broken a sufficient criteria for acceptance? Sometimes, it depends upon the situation. If you are continuing to resolve those issues, I'll wait and watch for future respins then.

  1   2   3   >