Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-12 Thread Casey Leedom
| From: Ding Tianhong | Sent: Wednesday, July 12, 2017 6:18 PM | | If no other more suggestion, I will send a new version and remove the | enable_pcie_relaxed_ordering(), thanks.  :) Sounds good to me. (And sorry for forgetting to justify that last message. I hate

Re: [PATCH net-next v1 0/3] Flow Based GTP Tunneling

2017-07-12 Thread Joe Stringer
On 12 July 2017 at 17:44, Jiannan Ouyang wrote: > This patch series augmented the existing GTP module to support flow > based GTP tunneling and modified the openvswitch datapath to support the > GTP vport type. > > A flow based GTP net device enables that, > 1) on the RX path, the

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-12 Thread Ding Tianhong
On 2017/7/13 8:52, Casey Leedom wrote: > Sorry again for the delay. This time at least partially caused by a > Chelsio-internal Customer Support request to simply disable Relaxed Ordering > entirely due to the performance issues with our 100Gb/s product and > relatively recent Intel Root

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-12 Thread Casey Leedom
  Sorry again for the delay.  This time at least partially caused by a Chelsio-internal Customer Support request to simply disable Relaxed Ordering entirely due to the performance issues with our 100Gb/s product and relatively recent Intel Root Complexes. Our Customer Support people are tired

[PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

2017-07-12 Thread Jiannan Ouyang
If flow-based encap/decap is enabled, a separate code path is created for both packet RX and TX. PDP contexts are not used in flow-based mode since all metadata is maintained in metadata_dst: - for RX, pdp lookup and ms check are bypassed, while metadata_dst is constructed and attached to the

[PATCH net-next v1 2/3] gtp: Support creating flow-based gtp net_device

2017-07-12 Thread Jiannan Ouyang
Add the gtp_create_flow_based_dev() interface to create flow-based gtp net_device, which sets gtp->collect_md. Under flow-based mode, UDP sockets are created and maintained in kernel. Signed-off-by: Jiannan Ouyang --- drivers/net/gtp.c | 213

[PATCH net-next v1 3/3] openvswitch: Add GPRS Tunnel Protocol (GTP) vport support

2017-07-12 Thread Jiannan Ouyang
Add OVS_VPORT_TYPE_GTP type and vport-gtp support. Signed-off-by: Jiannan Ouyang --- include/uapi/linux/openvswitch.h | 1 + net/openvswitch/Kconfig | 10 +++ net/openvswitch/Makefile | 1 + net/openvswitch/vport-gtp.c | 144

[PATCH net-next v1 0/3] Flow Based GTP Tunneling

2017-07-12 Thread Jiannan Ouyang
This patch series augmented the existing GTP module to support flow based GTP tunneling and modified the openvswitch datapath to support the GTP vport type. A flow based GTP net device enables that, 1) on the RX path, the outer (IP/UDP/GTP) header information could to be stored in the

[GIT] Networking

2017-07-12 Thread David Miller
Nothing super serious in here except perhaps the brcmfmac fix. 1) Fix 64-bit division in mlx5 IPSEC offload support, from Ilan Tayari and Arnd Bergmann. 2) Fix race in statistics gathering in bnxt_en driver, from Michael Chan. 3) Can't use a mutex in RCU reader protected section on tap

[Patch net] netpoll: shut up a kernel warning on refcount

2017-07-12 Thread Cong Wang
When we convert atomic_t to refcount_t, a new kernel warning on "increment on 0" is introduced in the netpoll code, zap_completion_queue(). In fact for this special case, we know the refcount is 0 and we just have to set it to 1 to satisfy the following dev_kfree_skb_any(), so we can just use

Re: netconsole refcount warning

2017-07-12 Thread Cong Wang
On Wed, Jul 12, 2017 at 3:30 PM, Cong Wang wrote: > On Sun, Jul 9, 2017 at 4:57 PM, Dave Jones wrote: >> The new refcount debugging code spews this twice during boot on my router.. >> >> >> refcount_t: increment on 0; use-after-free. >>

Re: netconsole refcount warning

2017-07-12 Thread Cong Wang
On Sun, Jul 9, 2017 at 4:57 PM, Dave Jones wrote: > The new refcount debugging code spews this twice during boot on my router.. > > > refcount_t: increment on 0; use-after-free. > [ cut here ] > WARNING: CPU: 1 PID: 17 at lib/refcount.c:152

Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID

2017-07-12 Thread Florian Westphal
Richard Weinberger wrote: > Am 01.07.2017 um 12:35 schrieb Florian Westphal: > > The compare on removal is not needed afaics, and its also not used when > > doing lookup to begin with, so we can just recompute it? > > Isn't this a way too much overhead? I don't think so. This

Re: [iovisor-dev] [PATCH v3 net-next 02/12] bpf/verifier: rework value tracking

2017-07-12 Thread Nadav Amit
Edward Cree wrote: > On 07/07/17 18:45, Nadav Amit wrote: >> For me changes such as: >> >>> if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE) >>> - dst_reg->min_value -= min_val; >>> + dst_reg->min_value -= max_val; >> >> are purely

Re: [PATCH] net: stmmac: revert "support future possible different internal phy mode"

2017-07-12 Thread David Miller
From: Corentin Labbe Date: Wed, 12 Jul 2017 09:32:34 +0200 > Since internal phy-mode is reserved for non-xMII protocol we cannot use > it with dwmac-sun8i. > Furthermore, all DT patchs which comes with this patch were cleaned, so > the current state is broken. > This

Re: [PATCH net] sfc: don't read beyond unicast address list

2017-07-12 Thread David Miller
From: Bert Kenward Date: Wed, 12 Jul 2017 17:19:41 +0100 > If we have more than 32 unicast MAC addresses assigned to an interface > we will read beyond the end of the address table in the driver when > adding filters. The next 256 entries store multicast addresses, so we

Re: [PATCH net 0/2] minor net kernel-doc fixes

2017-07-12 Thread David Miller
From: Stephen Hemminger Date: Wed, 12 Jul 2017 09:29:05 -0700 > Fix a couple of small errors in kernel-doc for networking Series applied, thanks Stephen.

Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n

2017-07-12 Thread David Miller
From: Dave Hansen Date: Wed, 12 Jul 2017 14:09:25 -0700 > > From: Dave Hansen > > I'm seeing warnings on kernel configurations where CONFIG_PM is > disabled. It happens in 4.12, at least: > >

Re: [PATCH] smsc911x: Add check for ioremap_nocache() return code

2017-07-12 Thread David Miller
From: Alexey Khoroshilov Date: Wed, 12 Jul 2017 23:58:56 +0300 > There is no check for return code of smsc911x_drv_probe() > in smsc911x_drv_probe(). The patch adds one. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey

Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID

2017-07-12 Thread Richard Weinberger
Florian, Am 01.07.2017 um 12:35 schrieb Florian Westphal: >>> Perhaps we can place that in a new extension (its not needed in any >>> fastpath ops)? >> >> To get rid of the infoleak we have to re-introduce the id field in struct >> nf_conn >> and struct nf_conntrack_expect. > > Why will this

Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n

2017-07-12 Thread Fabio Estevam
On Wed, Jul 12, 2017 at 6:09 PM, Dave Hansen wrote: > > From: Dave Hansen > > I'm seeing warnings on kernel configurations where CONFIG_PM is > disabled. It happens in 4.12, at least: > > drivers/ethernet/intel/igb/igb_main.c:7988:13:

[PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n

2017-07-12 Thread Dave Hansen
From: Dave Hansen I'm seeing warnings on kernel configurations where CONFIG_PM is disabled. It happens in 4.12, at least: drivers/ethernet/intel/igb/igb_main.c:7988:13: warning: 'igb_deliver_wake_packet' defined but not used [-Wunused-function] This is because

Re: [PATCH 1/1] bridge: mdb: fix leak on complete_info ptr on fail path

2017-07-12 Thread Eduardo Valentin
On Tue, Jul 11, 2017 at 08:02:33PM -0700, David Miller wrote: > From: Eduardo Valentin > Date: Tue, 11 Jul 2017 14:55:12 -0700 > > > We currently get the following kmemleak report: > > unreferenced object 0x8800039d9820 (size 32): > > comm "softirq", pid 0, jiffies

RFC7510 MPLS-over-UDP support in iproute2

2017-07-12 Thread Blake Willis
Greetings, I noticed that MPLS-over-IP & MPLS-over-UDP support have recently been committed to the kernel, & that MPLS-over-IP support was commited to iproute2 last week. Please consider this a humble request for RFC7510 MPLS-over-UDP (UDP port 6635) support in iproute2. Perhaps I'm missing

[PATCH] smsc911x: Add check for ioremap_nocache() return code

2017-07-12 Thread Alexey Khoroshilov
There is no check for return code of smsc911x_drv_probe() in smsc911x_drv_probe(). The patch adds one. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/smsc/smsc911x.c | 5 + 1 file changed, 5

Re: [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions

2017-07-12 Thread Michael Chan
On Wed, Jul 12, 2017 at 1:04 AM, Benjamin Gaignard wrote: > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > rely on 32bits variables and that will make rtc break in y2038/2016. > Stop using those two functions to safer 64bits ones. > >

Re: [iovisor-dev] [PATCH v3 net-next 02/12] bpf/verifier: rework value tracking

2017-07-12 Thread Edward Cree
On 07/07/17 18:45, Nadav Amit wrote: > For me changes such as: > >> if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE) >> -dst_reg->min_value -= min_val; >> +dst_reg->min_value -= max_val; > > are purely cryptic. What happened here? Was there a

Re: [PATCH v1 net-next 4/5] drop_monitor: let drop stat support net ns

2017-07-12 Thread kbuild test robot
Hi martin, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/martinbj2008-gmail-com/drop_monitor-import-netnamespace-framework/20170712-205015 coccinelle warnings: (new ones prefixed by >>) >> net/core/drop_monitor.c:555:36-37: Unneed

[PATCH] drop_monitor: fix semicolon.cocci warnings

2017-07-12 Thread kbuild test robot
net/core/drop_monitor.c:555:36-37: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: d5bf05101a5c ("drop_monitor: let drop stat support net ns") CC: martin Zhang Signed-off-by: Fengguang Wu

Re: [PATCH v3 net-next 3/4] tls: kernel TLS support

2017-07-12 Thread Dave Watson
On 07/12/17 09:20 AM, Steffen Klassert wrote: > On Tue, Jul 11, 2017 at 11:53:11AM -0700, Dave Watson wrote: > > On 07/11/17 08:29 AM, Steffen Klassert wrote: > > > Sorry for replying to old mail... > > > > +int tls_set_sw_offload(struct sock *sk, struct tls_context *ctx) > > > > +{ > > > > > >

Re: [iproute PATCH] ip netns: Make sure netns name is sane

2017-07-12 Thread Phil Sutter
On Wed, Jul 12, 2017 at 09:38:34AM -0700, Stephen Hemminger wrote: > On Mon, 10 Jul 2017 13:19:12 +0200 > Phil Sutter wrote: > > > +static bool is_basename(const char *name) > > +{ > > + char *name_dup = strdup(name); > > + bool rc = true; > > + > > + if (!name_dup) > > +

Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread Cong Wang
On Wed, Jul 12, 2017 at 10:08 AM, 张军伟(基础平台部) wrote: > about skb->sk > it is used as supplementary when skb->dev is empty,such as netlink message。 > > + if (skb->dev) > + net = dev_net(skb->dev); > + else if (skb->sk) > +

Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread Cong Wang
On Wed, Jul 12, 2017 at 6:37 AM, Neil Horman wrote: > On Wed, Jul 12, 2017 at 06:40:49PM +0800, martinbj2...@gmail.com wrote: >> The dropwatch is a very useful tool to diagnose network problem, >> which give us greate help. >> Dropwatch could not work under container(net

Re: [iproute PATCH] ip netns: Make sure netns name is sane

2017-07-12 Thread Stephen Hemminger
On Mon, 10 Jul 2017 13:19:12 +0200 Phil Sutter wrote: > +static bool is_basename(const char *name) > +{ > + char *name_dup = strdup(name); > + bool rc = true; > + > + if (!name_dup) > + return false; > + > + if (strcmp(basename(name_dup), name)) > +

[RFC 3/3] net: macb: Use sram for rx buffers

2017-07-12 Thread Alexander Dahl
The default way for the driver is to use system memory for RX/TX DMA buffers and rings. For the AT91SAM9G20 this is SDRAM which is connected through the EBI bus, together with other memories like NAND-Flash or external SRAM. If a memory access to external SRAM using the NWAIT signal takes too

[RFC 1/3] net: macb: Add register descriptions

2017-07-12 Thread Alexander Dahl
Analog to the already present long register names for GEM, add those for MACB. Taken from the AT91SAM9G20 complete datasheet. Signed-off-by: Alexander Dahl --- drivers/net/ethernet/cadence/macb.h | 66 ++--- 1 file changed, 33 insertions(+), 33

[RFC 0/3] net: macb: Use SRAM on SoC for RX rings and buffers

2017-07-12 Thread Alexander Dahl
Hei hei, this is a small patch series for a problem we encoutered with a board based on an AT91SAM9G20 SoC. I talked about it a few days ago on the #armlinux IRC channel with Alexandre Belloni and Florian Fainelli. The current state of those patches is 'prove of concept', but if this is useful

[RFC 2/3] net: macb: Add buffer descriptor names

2017-07-12 Thread Alexander Dahl
Documentation of the EMAC buffer descriptor bitfields. Taken from the AT91SAM9G20 complete datasheet. Signed-off-by: Alexander Dahl --- drivers/net/ethernet/cadence/macb.h | 50 ++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git

[PATCH net 1/2] socket: add documentation for missing elements

2017-07-12 Thread Stephen Hemminger
Fill in missing kernel-doc for missing elements in struct sock. Signed-off-by: Stephen Hemminger --- include/net/sock.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/net/sock.h b/include/net/sock.h index 8c85791fc196..f69c8c2782df 100644 ---

[PATCH net 2/2] datagram: fix kernel-doc comments

2017-07-12 Thread Stephen Hemminger
An underscore in the kernel-doc comment section has special meaning and mis-use generates an errors. ./net/core/datagram.c:207: ERROR: Unknown target name: "msg". ./net/core/datagram.c:379: ERROR: Unknown target name: "msg". ./net/core/datagram.c:816: ERROR: Unknown target name: "t".

[PATCH net 0/2] minor net kernel-doc fixes

2017-07-12 Thread Stephen Hemminger
Fix a couple of small errors in kernel-doc for networking Stephen Hemminger (2): socket: add documentation for missing elements datagram: fix kernel-doc comments include/net/sock.h | 3 +++ net/core/datagram.c | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) -- 2.11.0

[PATCH net] sfc: don't read beyond unicast address list

2017-07-12 Thread Bert Kenward
If we have more than 32 unicast MAC addresses assigned to an interface we will read beyond the end of the address table in the driver when adding filters. The next 256 entries store multicast addresses, so we will end up attempting to insert duplicate filters, which is mostly harmless. If we add

Re: [PATCH net 20/20] net/hinic: Add ethtool and stats

2017-07-12 Thread Andrew Lunn
On Wed, Jul 12, 2017 at 10:17:26PM +0800, Aviad Krawczyk wrote: Hi Avaid > + > +static void hinic_tx_timeout(struct net_device *netdev) > +{ > + struct hinic_dev *nic_dev = netdev_priv(netdev); > + > + netif_err(nic_dev, drv, netdev, "Tx timeout\n"); > +} > + > +#ifdef

Re: [PATCH net 02/20] nic/hinic: Initialize hw device components

2017-07-12 Thread Andrew Lunn
> +/** > + * get_dev_cap - get device capabilities > + * @hwdev: the NIC HW device to get capabilities for > + * > + * Return 0 - Success, negative - Failure > + **/ > +static int get_dev_cap(struct hinic_hwdev *hwdev) > +{ > + struct hinic_pfhwdev *pfhwdev; > + struct hinic_hwif *hwif =

Re: [PATCH net 01/20] net/hinic: Initialize hw interface

2017-07-12 Thread Andrew Lunn
> + > +#define HINIC_DRV_NAME "HiNIC" > +#define HINIC_DRV_VERSION"1.0" Hi Aviad Please don't add a driver version. There was a discussion about this recently, how pointless it is. > +/** > + * hinic_init_hwdev - Initialize the NIC HW > + * @hwdev: the NIC HW device that is

Re: [PATCH V2] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()

2017-07-12 Thread David Miller
From: Arend van Spriel Date: Wed, 12 Jul 2017 13:49:23 +0200 > On 7/7/2017 10:09 PM, Arend van Spriel wrote: >> The lower level nl80211 code in cfg80211 ensures that "len" is between >> 25 and NL80211_ATTR_FRAME (2304). We subtract DOT11_MGMT_HDR_LEN (24) >> from

Re: [PATCH net] net: hns: Bugfix for Tx timeout handling in hns driver

2017-07-12 Thread David Miller
From: Lin Yun Sheng Date: Wed, 12 Jul 2017 19:09:59 +0800 > When hns port type is not debug mode, netif_tx_disable is called > when there is a tx timeout, which requires system reboot to return > to normal state. This patch fix this problem by resetting the net > dev. >

Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread David Miller
You must provide a proper "[PATCH vx net-next 0/N]" header posting with a patch series, which describes at a high level what the patch series on a whole is doing, how it is doing it, and why it is doing it that way. Second, net-next is closed: http://vger.kernel.org/~davem/net-next.html

Re: [PATCH net] nfp: freeing the wrong variable

2017-07-12 Thread David Miller
From: Dan Carpenter Date: Wed, 12 Jul 2017 10:42:06 +0300 > We accidentally free a NULL pointer and leak the pointer we want to > free. Also you can tell from the label name what was intended. :) > > Fixes: abfcdc1de9bf ("nfp: add a stats handler for flower

Re: [PATCH net] net: ipmr: ipmr_get_table() returns NULL

2017-07-12 Thread David Miller
From: Dan Carpenter Date: Wed, 12 Jul 2017 10:56:47 +0300 > The ipmr_get_table() function doesn't return error pointers it returns > NULL on error. > > Fixes: 4f75ba6982bc ("net: ipmr: Add ipmr_rtm_getroute") > Signed-off-by: Dan Carpenter

Re: [patch net 0/4] mlxsw: spectrum: Various fixes

2017-07-12 Thread David Miller
From: Jiri Pirko Date: Wed, 12 Jul 2017 09:12:51 +0200 > First patch adds a missing rollback in error path. Second patch prevents > a use-after-free during IPv4 route replace. Last two patches fix warnings > from static checkers. Series applied, thanks.

Re: [PATCH net 00/20] Huawei HiNIC Ethernet Driver

2017-07-12 Thread David Miller
The net-next tree is closed: http://vger.kernel.org/~davem/net-next.html Please resubmit this when the net-next tree is open again. Thank you.

Re: [PATCH net-next 3/4] net-next: mediatek: add support for MediaTek MT7622 SoC

2017-07-12 Thread Andrew Lunn
Hi Sean > static void mtk_phy_link_adjust(struct net_device *dev) > { > struct mtk_mac *mac = netdev_priv(dev); > @@ -269,6 +311,7 @@ static int mtk_phy_connect(struct net_device *dev) > if (!np) > return -ENODEV; > > + mac->ge_mode = 0; > switch

Re: [PATCH net-next 2/4] net-next: mediatek: add platform data to adapt into various hardware

2017-07-12 Thread Andrew Lunn
> +static int mtk_clk_enable(struct mtk_eth *eth) > +{ > + int clk, ret; > + > + for (clk = 0; clk < MTK_CLK_MAX ; clk++) { > + if (eth->clks[clk]) { > + ret = clk_prepare_enable(eth->clks[clk]); > + if (ret) > +

[PATCH net 05/20] net/hinic: Add management messages

2017-07-12 Thread Aviad Krawczyk
Add the management messages for sending to api cmd and add the asynchronous event handler for the completion of the messages. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 35 ++

[PATCH net 01/20] net/hinic: Initialize hw interface

2017-07-12 Thread Aviad Krawczyk
Initialize hw interface as part of the nic initialization for accessing hw. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- Documentation/networking/hinic.txt | 125 drivers/net/ethernet/Kconfig

[PATCH net 00/20] Huawei HiNIC Ethernet Driver

2017-07-12 Thread Aviad Krawczyk
The patch-set contains the support of the HiNIC Ethernet driver for hinic family of PCIE Network interface cards. The Huawei's PCIE HiNIC card is a new ethernet card and hence there was a need of a new driver. The current driver is meant to be used for the Physical Function and there would

[PATCH net 04/20] net/hinic: Initialize api cmd hw

2017-07-12 Thread Aviad Krawczyk
Update the hardware about api cmd resources and initialize api cmd hw. Signed-off-by: Aviad Krawczyk Sigend-off-by: Zhaochen --- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 174 -

[PATCH net 07/20] net/hinic: Add aeqs

2017-07-12 Thread Aviad Krawczyk
Handle aeq elements that are accumulated on the aeq by calling the registered handler for the specific event. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/hinic_hw_csr.h | 49 +++

[PATCH net 11/20] net/hinic: Add wq

2017-07-12 Thread Aviad Krawczyk
Create work queues for use by the queue pairs for Tx and Rx operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- drivers/net/ethernet/huawei/hinic/hinic_hw_io.c | 65 ++-

[PATCH net 10/20] net/hinic: Add logical Txq and Rxq

2017-07-12 Thread Aviad Krawczyk
Create the logical queues of the nic. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/Makefile | 5 +- drivers/net/ethernet/huawei/hinic/hinic_dev.h| 5 +

[PATCH net 08/20] net/hinic: Add port management commands

2017-07-12 Thread Aviad Krawczyk
Add the port management commands that are sent as management messages. The port management commands are used for netdev operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/Makefile | 4

[PATCH net 09/20] net/hinic: Add Rx mode and link event handler

2017-07-12 Thread Aviad Krawczyk
Add port management message for setting Rx mode in the card, used for rx_mode netdev operation. The link event handler is used for getting a notification about the link state. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen ---

[PATCH net 13/20] net/hinic: Set qp context

2017-07-12 Thread Aviad Krawczyk
Update the nic about the resources of the queue pairs. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/Makefile | 5 +- drivers/net/ethernet/huawei/hinic/hinic_common.c | 55 ++

[PATCH net 15/20] net/hinic: Add ceqs

2017-07-12 Thread Aviad Krawczyk
Initialize the completion event queues and handle ceq events by calling the registered handlers. Used for the completion event of cmdq commands. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen ---

[PATCH net 14/20] net/hinic: Initialize cmdq

2017-07-12 Thread Aviad Krawczyk
Create the work queues for cmdq and update the nic about the cmdq contexts. cmdq commands are used for updating the nic about the qp contexts. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen ---

[PATCH net 12/20] net/hinic: Add qp resources

2017-07-12 Thread Aviad Krawczyk
Create the resources for queue pair operations: doorbell area, consumer index address and producer index address. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +-

[PATCH net 17/20] net/hinic: Add cmdq completion handler

2017-07-12 Thread Aviad Krawczyk
Add cmdq completion handler for getting a notification about the completion of cmdq commands. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 284 +-

[PATCH net 20/20] net/hinic: Add ethtool and stats

2017-07-12 Thread Aviad Krawczyk
Add ethtool operations and statistics operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- MAINTAINERS| 7 + drivers/net/ethernet/huawei/hinic/hinic_dev.h | 3 +

[PATCH net 18/20] net/hinic: Add Rx handler

2017-07-12 Thread Aviad Krawczyk
Set the io resources in the nic and handle rx events by qp operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_csr.h | 1 +

[PATCH net 16/20] net/hinic: Add cmdq commands

2017-07-12 Thread Aviad Krawczyk
Add cmdq commands for setting queue pair contexts in the nic. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/hinic_common.c | 25 ++ drivers/net/ethernet/huawei/hinic/hinic_common.h | 15 ++

[PATCH net 19/20] net/hinic: Add Tx operation

2017-07-12 Thread Aviad Krawczyk
Add transmit operation for sending data by qp operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 46 +++

[PATCH net 03/20] net/hinic: Initialize api cmd resources

2017-07-12 Thread Aviad Krawczyk
Initialize api cmd resources as part of the management initialization. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c |

[PATCH net 06/20] net/hinic: Add api cmd commands

2017-07-12 Thread Aviad Krawczyk
Add the api cmd commands for sending management messages to the nic. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 329 -

[PATCH net 02/20] nic/hinic: Initialize hw device components

2017-07-12 Thread Aviad Krawczyk
Initialize hw device by calling the initialization functions of aeqs and management channel. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhaochen --- drivers/net/ethernet/huawei/hinic/Makefile| 3 +-

Re: [Intel-wired-lan] [PATCH 6/6] [next-queue]net: i40e: Add support to set max bandwidth rates for TCs offloaded via tc/mqprio

2017-07-12 Thread kbuild test robot
Hi Amritha, [auto build test ERROR on jkirsher-next-queue/dev-queue] [cannot apply to v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: Lots of new warnings with gcc-7.1.1

2017-07-12 Thread Arnd Bergmann
On Wed, Jul 12, 2017 at 3:10 PM, Greg Kroah-Hartman wrote: > On Tue, Jul 11, 2017 at 03:35:15PM -0700, Linus Torvalds wrote: >> [ Very random list of maintainers and mailing lists, at least >> partially by number of warnings generated by gcc-7.1.1 that is then >>

RE: [PATCH] net: broadcom: bnx2x: make a couple of const arrays static

2017-07-12 Thread Mintz, Yuval
> Don't populate various tables on the stack but make them static const. > Makes the object code smaller by nearly 200 bytes: > > Before: >text data bss dec hex filename > 113468 11200 0 124668 1e6fc bnx2x_ethtool.o > > After: >text data

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-12 Thread Andrew Lunn
> So would it be possible to add a "quick" bugfix patch (maybe this patch > or another one removing the clk disable) so this fix can be backported > to stable? Otherwise our board is only working with another > "out-of-tree" patch (which I want to avoid)... Hi Richard It is a clear regression,

Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread Neil Horman
On Wed, Jul 12, 2017 at 06:40:49PM +0800, martinbj2...@gmail.com wrote: > From: martin Zhang > > This is a serial patch for drop monitor, in order to support net namespace. > > Import two struct to support net ns: > > 1. struct per_ns_dm_cb: > Just like its

Re: Lots of new warnings with gcc-7.1.1

2017-07-12 Thread Arnd Bergmann
On Wed, Jul 12, 2017 at 5:41 AM, Linus Torvalds wrote: > > We also have about a bazillion > > warning: ‘*’ in boolean context, suggest ‘&&’ instead > > warnings in drivers/ata/libata-core.c, all due to a single macro that > uses a pattern that gcc-7.1.1 doesn't

Re: Lots of new warnings with gcc-7.1.1

2017-07-12 Thread Greg Kroah-Hartman
On Tue, Jul 11, 2017 at 03:35:15PM -0700, Linus Torvalds wrote: > [ Very random list of maintainers and mailing lists, at least > partially by number of warnings generated by gcc-7.1.1 that is then > correlated with the get_maintainers script ] > > So I upgraded one of my boxes to F26, which

Re: [iproute PATCH] ip netns: Make sure netns name is sane

2017-07-12 Thread Phil Sutter
On Mon, Jul 10, 2017 at 08:17:02AM -0700, Stephen Hemminger wrote: > On Mon, 10 Jul 2017 13:19:12 +0200 > Phil Sutter wrote: > > > +static bool is_basename(const char *name) > > +{ > > + char *name_dup = strdup(name); > > + bool rc = true; > > + > > + if (!name_dup) > > +

Re: Lots of new warnings with gcc-7.1.1

2017-07-12 Thread Mauro Carvalho Chehab
Em Tue, 11 Jul 2017 15:35:15 -0700 Linus Torvalds escreveu: > [ Very random list of maintainers and mailing lists, at least > partially by number of warnings generated by gcc-7.1.1 that is then > correlated with the get_maintainers script ] Under drivers/media, I

Re: [PATCH V2] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()

2017-07-12 Thread Arend van Spriel
On 7/7/2017 10:09 PM, Arend van Spriel wrote: The lower level nl80211 code in cfg80211 ensures that "len" is between 25 and NL80211_ATTR_FRAME (2304). We subtract DOT11_MGMT_HDR_LEN (24) from "len" so thats's max of 2280. However, the action_frame->data[] buffer is only

Re: [PATCH net-next RFC 05/12] net: dsa: Add support for learning FDB through notification

2017-07-12 Thread Nikolay Aleksandrov
On 12/07/17 14:23, Arkadi Sharshevsky wrote: > > > On 07/11/2017 06:05 PM, Nikolay Aleksandrov wrote: >> On 11/07/17 13:26, Arkadi Sharshevsky wrote: >>> >>> >>> On 07/10/2017 11:59 PM, Vivien Didelot wrote: Hi Arkadi, Arkadi Sharshevsky writes: >>>

Re: [PATCH net-next RFC 05/12] net: dsa: Add support for learning FDB through notification

2017-07-12 Thread Arkadi Sharshevsky
On 07/11/2017 06:05 PM, Nikolay Aleksandrov wrote: > On 11/07/17 13:26, Arkadi Sharshevsky wrote: >> >> >> On 07/10/2017 11:59 PM, Vivien Didelot wrote: >>> Hi Arkadi, >>> >>> Arkadi Sharshevsky writes: >>> >> +err = dsa_port_fdb_add(p->dp,

Re: [RFC PATCH 03/12] xdp: add bpf_redirect helper function

2017-07-12 Thread Saeed Mahameed
On 7/11/2017 10:38 PM, Jesper Dangaard Brouer wrote: On Tue, 11 Jul 2017 11:38:33 -0700 John Fastabend wrote: On 07/11/2017 07:09 AM, Andy Gospodarek wrote: On Mon, Jul 10, 2017 at 1:23 PM, John Fastabend wrote: On 07/09/2017 06:37 AM,

[PATCH v1 net-next 4/5] drop_monitor: let drop stat support net ns

2017-07-12 Thread martinbj2008
From: martin Zhang move the detail drop stat to per net ns. A net ns has its per cpu stat. keep the work under per cpu to send netlink alter message. all the net ns share a work under a CPU, the work will be scheduled by any ns, and will send message in all

[PATCH v1 net-next 3/5] drop_monitor: let hw_stats_list support net ns

2017-07-12 Thread martinbj2008
From: martin Zhang hw_stats_list is used to record NAPI state for net device. Every net device belongs to one net ns. so every net ns has a list head to record them. Signed-off-by: martin Zhang --- net/core/drop_monitor.c |

[PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread martinbj2008
From: martin Zhang This is a serial patch for drop monitor, in order to support net namespace. Import two struct to support net ns: 1. struct per_ns_dm_cb: Just like its name, it is used in per net ns. In this patch it is empty, but in following patch,

[PATCH v1 net-next 2/5] drop_monitor: let dm trace state support ns

2017-07-12 Thread martinbj2008
From: martin Zhang Every net ns has its own trace_state, and use a ref to control trace state of whole kernel. trace_state in struct per_ns_dm_cb: Just like the previous trace state, record the trace state for every net ns. Possible values are ON/OFF.

[PATCH v1 net-next 5/5] drop_monitor: increase version when ns support is ready

2017-07-12 Thread martinbj2008
From: martin Zhang 1. increase DM netlink version from 2 to 3, as it now support net ns. 2. netns ok become ture. Signed-off-by: martin Zhang --- net/core/drop_monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH net] net: hns: Bugfix for Tx timeout handling in hns driver

2017-07-12 Thread Lin Yun Sheng
When hns port type is not debug mode, netif_tx_disable is called when there is a tx timeout, which requires system reboot to return to normal state. This patch fix this problem by resetting the net dev. Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support")

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-12 Thread Ding Tianhong
On 2017/7/11 8:01, Casey Leedom wrote: > > Hey Alexander, > > Okay, I understand your point regarding the "most likely scenario" being > TLPs directed upstream to the Root Complex. But I'd still like to make sure > that we have an agreed upon API/methodology for doing Peer-to-Peer with >

Re: [PATCH 1/1] mlx4_en: remove unnecessary returned value check

2017-07-12 Thread Leon Romanovsky
On Wed, Jul 12, 2017 at 11:36:48AM +0300, Yuval Shaia wrote: > On Wed, Jul 12, 2017 at 02:44:33AM -0400, Zhu Yanjun wrote: > > The function __mlx4_zone_remove_one_entry always returns zero. So > > it is not necessary to check it. > > > > Cc: Joe Jin > > Cc: Junxiao Bi

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-12 Thread Richard Leitner
On 07/07/2017 04:00 PM, Andrew Lunn wrote: >> Ok. I'm fine with moving the phy-reset-gpios binding into the PHY. >> But one question still remains: Who should then trigger the "hard >> reset" of the PHY? > > Hi Richard > > I think i see a few whys to do this, but first i need to check >

Re: [PATCH 1/1] mlx4_en: remove unnecessary returned value check

2017-07-12 Thread Yuval Shaia
On Wed, Jul 12, 2017 at 02:44:33AM -0400, Zhu Yanjun wrote: > The function __mlx4_zone_remove_one_entry always returns zero. So > it is not necessary to check it. > > Cc: Joe Jin > Cc: Junxiao Bi > Signed-off-by: Zhu Yanjun >

[PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions

2017-07-12 Thread Benjamin Gaignard
rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016. Stop using those two functions to safer 64bits ones. Signed-off-by: Benjamin Gaignard CC: Michael Chan

Re: [PATCH net] net: ipmr: ipmr_get_table() returns NULL

2017-07-12 Thread Nikolay Aleksandrov
On 12/07/17 10:56, Dan Carpenter wrote: > The ipmr_get_table() function doesn't return error pointers it returns > NULL on error. > > Fixes: 4f75ba6982bc ("net: ipmr: Add ipmr_rtm_getroute") > Signed-off-by: Dan Carpenter > > diff --git a/net/ipv4/ipmr.c

  1   2   >