Re: [PATCH 1/3] ipv4: initialize fib_trie prior to register_netdev_notifier call.

Where are patches #2 and #3?

Re: [PATCH net] ipv6: avoid overflow of offset in ip6_find_1stfragopt

From: Sabrina Dubroca Date: Wed, 19 Jul 2017 22:28:55 +0200 > In some cases, offset can overflow and can cause an infinite loop in > ip6_find_1stfragopt(). Make it unsigned int to prevent the overflow, and > cap it at IPV6_MAXPLEN, since packets larger than that should be

Re: [PATCH] net: tehuti: don't process data if it has not been copied from userspace

From: Colin King Date: Wed, 19 Jul 2017 18:46:59 +0100 > From: Colin Ian King > > The array data is only populated with valid information from userspace > if cmd != SIOCDEVPRIVATE, other cases the array contains garbage on > the stack. The

[PATCH v2 1/1] iroute2: Add support for GRE ignore-df knob

From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. The workaround is to handle IPv4 payloads opaquely, ignoring the DF bit.

[PATCH] net: bonding: Fix transmit load balancing in balance-alb mode

balance-alb mode used to have transmit dynamic load balancing feature enabled by default. However, transmit dynamic load balancing no longer works in balance-alb after commit 8b426dc54cf4 ("bonding: remove hardcoded value"). Both balance-tlb and balance-alb use the function bond_do_alb_xmit() to

Re: [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X

From: Martin Hundebøll Date: Wed, 19 Jul 2017 08:17:02 +0200 > Commit f39908d3b1c45 ('net: dsa: mv88e6xxx: Set the CMODE for mv88e6390 > ports 9 & 10') added support for setting the CMODE for the 6390X family, > but only enabled it for 9290 and 6390 - and left out 6390X. > > Fix

Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

From: "Jianming.qiao" Date: Wed, 19 Jul 2017 01:18:40 +0100 > Signed-off-by: Jianming.qiao Supporting both deprecated .ndo_get_stats and 64-bit .ndo_get_stats64 at the same time makes no sense. .ndo_get_stats will never be called if .ndo_get_stats64

Re: [PATCH net-next 0/8] netvsc: lockdep and related fixes

From: Stephen Hemminger Date: Wed, 19 Jul 2017 11:53:11 -0700 > These fix sparse and lockdep warnings from netvsc driver. > Targeting these at net-next since no actual related failures > have been observed in non-debug kernels. Series applied, thanks Stephen.

Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

On Tue, Jul 18, 2017 at 4:33 PM, Girish Moodalbail wrote: > This patch adds changelink rtnl operation support for geneve devices > and the code changes involve: > > - add geneve_quiesce() which quiesces the geneve device data path > for both TX and RX. This

Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

On 7/19/17 4:51 PM, David Miller wrote: From: Girish Moodalbail Date: Tue, 18 Jul 2017 16:33:06 -0700 +static inline bool geneve_dst_addr_equal(struct ip_tunnel_info *a, ... +static inline void geneve_quiesce(struct geneve_dev *geneve, ... +static inline

Re: commit 16ecba59 breaks 82574L under heavy load.

On 2017/07/19 10:19, Lennart Sorensen wrote: > On Tue, Jul 18, 2017 at 04:14:35PM -0700, Benjamin Poirier wrote: > > Thanks for the detailed analysis. > > > > Refering to the original discussion around this patch series, it seemed like > > the IMS bit for a condition had to be set for the Other

Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

From: Girish Moodalbail Date: Tue, 18 Jul 2017 16:33:06 -0700 > +static inline bool geneve_dst_addr_equal(struct ip_tunnel_info *a, ... > +static inline void geneve_quiesce(struct geneve_dev *geneve, ... > +static inline void geneve_unquiesce(struct geneve_dev

Re: [PATCH net-next 0/3] net: make dev_close void

From: Stephen Hemminger Date: Tue, 18 Jul 2017 15:59:24 -0700 > Noticed while working on other changes. Why is dev_close() > returning int, it should be void. Should also change > ndo_close to be void, but that requires more work and someone > with more coccinelle

[PATCH 0/4] can: Add new binding to limit bit rate used

Add a new generic binding that CAN drivers can use to specify the max arbitration and data bit rate supported by a transceiver. This is useful since in some instances the maximum speeds may be limited by the transceiver used. However, transceivers may not provide a means to determine this

[PATCH 1/4] can: dev: Add support for limiting configured bitrate

Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to discover these limitations at runtime. Therefore, add support

[PATCH 4/4] can: m_can: Add call to of_transceiver_is_fixed

Add call to new generic functions that provides support via a binding to limit the arbitration rate and/or data rate imposed by the physical transceiver connected to the MCAN peripheral. Signed-off-by: Franklin S Cooper Jr --- drivers/net/can/m_can/m_can.c | 2 ++ 1 file

[PATCH 3/4] can: m_can: Update documentation to mention new fixed transceiver binding

Add information regarding fixed transceiver binding. This is especially important for MCAN since the IP allows CAN FD mode to run significantly faster than what most transceivers are capable of. Signed-off-by: Franklin S Cooper Jr ---

[PATCH 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

Add documentation to describe usage of the new fixed transceiver binding. This new binding is applicable for any CAN device therefore it exist as its own document. Signed-off-by: Franklin S Cooper Jr --- .../bindings/net/can/fixed-transceiver.txt | 31

Re: [PATCH] liquidio: lio_main: remove unnecessary static in setup_io_queues()

From: "Gustavo A. R. Silva" Date: Tue, 18 Jul 2017 15:53:48 -0500 > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit

Re: [PATCH] wireless: airo: remove unnecessary static in writerids()

From: "Gustavo A. R. Silva" Date: Tue, 18 Jul 2017 15:37:11 -0500 > Remove unnecessary static on local function pointer _writer_. > Such pointer is initialized before being used, on every > execution path throughout the function. The static has no > benefit and, removing

Re: [PATCH] net: tulip: remove useless code in tulip_init_one()

From: "Gustavo A. R. Silva" Date: Tue, 18 Jul 2017 15:43:33 -0500 > Remove useless local variable multiport_cnt and the code related. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] rtlwifi: remove useless code

From: "Gustavo A. R. Silva" Date: Tue, 18 Jul 2017 15:41:06 -0500 > Remove useless local variables last_read_point and last_txw_point and > the code related. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()

From: "Gustavo A. R. Silva" Date: Tue, 18 Jul 2017 15:45:29 -0500 > Remove unnecessary static on local variable fw_dump_ops. > Such variable is initialized before being used, on every > execution path throughout the function. The static has no > benefit and, removing it

Re: [PATCH] liquidio: lio_vf_main: remove unnecessary static in setup_io_queues()

From: "Gustavo A. R. Silva" Date: Tue, 18 Jul 2017 15:50:15 -0500 > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit

Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx()

From: "Gustavo A. R. Silva" Date: Tue, 18 Jul 2017 15:48:06 -0500 > Remove useless local variable _condition_ and the code related. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH net-next] net: dsa: unexport dsa_is_port_initialized

From: Vivien Didelot Date: Tue, 18 Jul 2017 16:23:56 -0400 > The dsa_is_port_initialized helper is only used by dsa_switch_resume and > dsa_switch_suspend, if CONFIG_PM_SLEEP is enabled. Make it static to > dsa.c. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next] net/packet: remove unused PGV_FROM_VMALLOC definition.

From: Rami Rosen Date: Tue, 18 Jul 2017 22:23:30 +0300 > This patch removes the definition of PGV_FROM_VMALLOC from af_packet.c. > The PGV_FROM_VMALLOC definition was already removed by > commit 441c793a5650 ("net: cleanup unused macros in net directory"), > and its usage

Re: [PATCH v1 1/1] dt-binding: ptp: Add SoC compatibility strings for dte ptp clock

From: Arun Parameswaran Date: Tue, 18 Jul 2017 10:14:16 -0700 > Hi David, > > On 17-07-10 06:44 AM, Rob Herring wrote: >> On Thu, Jul 06, 2017 at 10:37:57AM -0700, Arun Parameswaran wrote: >>> Add SoC specific compatibility strings to the Broadcom DTE >>> based

Re: [Resend, PATCH v1] ISDN: eicon: switch to use native bitmaps

From: Andy Shevchenko Date: Tue, 18 Jul 2017 18:49:26 +0300 > Two arrays are clearly bit maps, so, make that explicit by converting to > bitmap API and remove custom helpers. > > Note sig_ind() uses out of boundary bit to (looks like) protect against >

Re: [PATCH net-next] sfc: Add ethtool -m support for QSFP modules

From: Martin Habets Date: Tue, 18 Jul 2017 16:43:19 +0100 > This also adds support for non-QSFP modules attached to QSFP. > > Signed-off-by: Martin Habets Applied, thanks!

Re: [PATCH net-next] tcp: adjust tail loss probe timeout

From: Yuchung Cheng Date: Wed, 19 Jul 2017 15:41:26 -0700 > This patch adjusts the timeout formula to schedule the TCP loss probe > (TLP). The previous formula uses 2*SRTT or 1.5*RTT + DelayACKMax if > only one packet is in flight. It keeps a lower bound of 10 msec which > is

Re: [PATCH V2 net-next 12/21] net-next/hinic: Add qp resources

From: Aviad Krawczyk Date: Wed, 19 Jul 2017 17:19:10 +0800 > diff --git a/drivers/net/ethernet/huawei/hinic/Makefile > b/drivers/net/ethernet/huawei/hinic/Makefile > index 519382b..24728f0 100644 > --- a/drivers/net/ethernet/huawei/hinic/Makefile > +++

[PATCH 1/3] can: m_can: Make hclk optional

Hclk is the MCAN's interface clock. However, for OMAP based devices such as DRA7 SoC family the interface clock is handled by hwmod. Therefore, this interface clock is managed by hwmod driver via pm_runtime_get and pm_runtime_put calls. Therefore, this interface clock isn't defined in DT and thus

[PATCH 3/3] can: m_can: Add PM Runtime

Add support for PM Runtime which is the new way to handle managing clocks. However, to avoid breaking SoCs not using PM_RUNTIME leave the old clk management approach in place. PM_RUNTIME is required by OMAP based devices to handle clock management. Therefore, this allows future Texas Instruments

[PATCH 2/3] can: m_can: Update documentation to indicate that hclk may be optional

Update the documentation to reflect that hclk is now an optional clock. Signed-off-by: Franklin S Cooper Jr --- Documentation/devicetree/bindings/net/can/m_can.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 0/3] can: m_can: Add PM Runtime Support

Add PM runtime support to the MCAN driver. To support devices that don't use PM runtime leave the original clk calls in the driver. Perhaps in the future when it makes sense we can remove these non pm runtime clk calls. Franklin S Cooper Jr (3): can: m_can: Make hclk optional can: m_can:

Re: [PATCH 1/3] ipv4: initialize fib_trie prior to register_netdev_notifier call.

Mahesh Bandewar writes: > From: Mahesh Bandewar > > Net stack initialization currently initializes fib-trie after the > first call to netdevice_notifier() call. In fact fib_trie initialization > needs to happen before first rtnl_register(). It does not

[PATCH net-next] tcp: adjust tail loss probe timeout

This patch adjusts the timeout formula to schedule the TCP loss probe (TLP). The previous formula uses 2*SRTT or 1.5*RTT + DelayACKMax if only one packet is in flight. It keeps a lower bound of 10 msec which is too large for short RTT connections (e.g. within a data-center). The new formula =

[PATCH 1/3] ipv4: initialize fib_trie prior to register_netdev_notifier call.

From: Mahesh Bandewar Net stack initialization currently initializes fib-trie after the first call to netdevice_notifier() call. In fact fib_trie initialization needs to happen before first rtnl_register(). It does not cause any problem since there are no devices UP at this

Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

Hi Andrew, On Tue, Jul 18, 2017 at 10:32 AM, Andrew Lunn wrote: > http://elixir.free-electrons.com/linux/latest/source/include/linux/gpio/consumer.h#L345 > static inline void gpiod_set_value_cansleep(struct gpio_desc *desc, int value) > { > /* GPIO can never have been

[PATCH v2] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane)

v2: reword commit message ip netns keeps track of created namespaces with bind mounts named /var/run/netns/. No input sanitization is done, allowing creation and deletion of files relatives to /var/run/netns or, if the path is non existent or invalid, allows to create "untracked" namespaces

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Aviad Krawczyk : [...] > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > new file mode 100644 > index 000..fbc9de4 > --- /dev/null > +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c [...] >

Re: [PATCH 1/2] net: phy: at803x: Fix RGMII RX and TX clock delays setup

On 07/19/2017 02:29 PM, Mason wrote: > On 19/07/2017 21:30, Florian Fainelli wrote: >> On 07/19/2017 12:24 PM, Grygorii Strashko wrote: >>> Hi >>> >>> On 07/19/2017 10:31 AM, Marc Gonzalez wrote: The current code supports enabling RGMII RX and TX clock delays. The unstated assumption is

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

On 07/19/2017 02:15 PM, Mason wrote: > On 19/07/2017 20:30, Florian Fainelli wrote: >> On 07/19/2017 10:36 AM, Mason wrote: >>> On 19/07/2017 19:17, Måns Rullgård wrote: >>> Marc Gonzalez writes: > According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 > ("Documentation:

Re: [PATCH 1/2] net: phy: at803x: Fix RGMII RX and TX clock delays setup

On 19/07/2017 21:30, Florian Fainelli wrote: > On 07/19/2017 12:24 PM, Grygorii Strashko wrote: >> Hi >> >> On 07/19/2017 10:31 AM, Marc Gonzalez wrote: >>> The current code supports enabling RGMII RX and TX clock delays. >>> The unstated assumption is that these settings are disabled by >>>

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

On 19/07/2017 20:30, Florian Fainelli wrote: > On 07/19/2017 10:36 AM, Mason wrote: >> On 19/07/2017 19:17, Måns Rullgård wrote: >> >>> Marc Gonzalez writes: >>> According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 ("Documentation: devicetree: clarify usage of the RGMII

Re: [PATCH] NET: dwmac: Make dwmac reset unconditional

From: Eugeniy Paltsev Date: Tue, 18 Jul 2017 17:07:15 +0300 > Unconditional reset dwmac before HW init if reset controller is present. > > In existing implementation we reset dwmac only after second module > probing: > (module load -> unload -> load again [reset

Re: [PATCH v2 2/2] openvswitch: Optimize operations for OvS flow_stats.

From: Tonghao Zhang Date: Mon, 17 Jul 2017 23:28:06 -0700 > When calling the flow_free() to free the flow, we call many times > (cpu_possible_mask, eg. 128 as default) cpumask_next(). That will > take up our CPU usage if we call the flow_free() frequently. > When we put

Re: [PATCH v2 1/2] openvswitch: Optimize updating for OvS flow_stats.

From: Tonghao Zhang Date: Mon, 17 Jul 2017 23:28:05 -0700 > In the ovs_flow_stats_update(), we only use the node > var to alloc flow_stats struct. But this is not a > common case, it is unnecessary to call the numa_node_id() > everytime. This patch is not a bugfix, but

Re: [PATCH] wireless: wext: terminate ifr name coming from userspace

From: "Levin, Alexander (Sasha Levin)" Date: Tue, 18 Jul 2017 04:23:16 + > ifr name is assumed to be a valid string by the kernel, but nothing > was forcing username to pass a valid string. > > In turn, this would cause panics as we tried to access the string >

[PATCH] net: Zero terminate ifr_name in dev_ifname().

The ifr.ifr_name is passed around and assumed to be NULL terminated. Signed-off-by: David S. Miller --- net/core/dev_ioctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c index 7657ad6bc13d..06b147d7d9e2 100644 ---

[PATCH net] ipv6: avoid overflow of offset in ip6_find_1stfragopt

In some cases, offset can overflow and can cause an infinite loop in ip6_find_1stfragopt(). Make it unsigned int to prevent the overflow, and cap it at IPV6_MAXPLEN, since packets larger than that should be invalid. This problem has been here since before the beginning of git history.

Re: [PATCH v2 net-next 0/3] liquidio: avoid vm low memory crashes

From: Felix Manlunas Date: Mon, 17 Jul 2017 17:49:20 -0700 > From: Rick Farrington > > This patchset addresses issues brought about by low memory conditions > in a VM. These conditions were not seen when the driver was exercised >

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

Hi Arkadi, I am testing your patch series the behavior changes suspiciously: # brctl show br0 bridge name bridge id STP enabled interfaces br0 8000.f6d5ef06ccdd no lan0 lan1

Re: [PATCH net-next] liquidio: support new firmware statistic fw_err_pki

From: Felix Manlunas Date: Mon, 17 Jul 2017 13:33:14 -0700 > From: Rick Farrington > > Added support for new firmware statistic 'tx_err_pki'. > > Signed-off-by: Rick Farrington > Signed-off-by: Derek

Re: [PATCH 1/2] net: phy: at803x: Fix RGMII RX and TX clock delays setup

On 07/19/2017 02:30 PM, Florian Fainelli wrote: On 07/19/2017 12:24 PM, Grygorii Strashko wrote: Hi On 07/19/2017 10:31 AM, Marc Gonzalez wrote: The current code supports enabling RGMII RX and TX clock delays. The unstated assumption is that these settings are disabled by default at reset,

ATENCIÓN;

ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Re: A buggy behavior for Linux TCP Reno and HTCP

On Tue, Jul 18, 2017 at 2:36 PM, Wei Sun wrote: > Hi there, > > We find a buggy behavior when using Linux TCP Reno and HTCP in low > bandwidth or highly congested network environments. > > In a simple word, their undo functions may mistakenly double the cwnd, > leading to a

Re: [PATCH 1/2] net: phy: at803x: Fix RGMII RX and TX clock delays setup

On 07/19/2017 12:24 PM, Grygorii Strashko wrote: > Hi > > On 07/19/2017 10:31 AM, Marc Gonzalez wrote: >> The current code supports enabling RGMII RX and TX clock delays. >> The unstated assumption is that these settings are disabled by >> default at reset, which is not the case. >> >> RX clock

Re: [PATCH 1/2] net: phy: at803x: Fix RGMII RX and TX clock delays setup

Hi On 07/19/2017 10:31 AM, Marc Gonzalez wrote: > The current code supports enabling RGMII RX and TX clock delays. > The unstated assumption is that these settings are disabled by > default at reset, which is not the case. > > RX clock delay is enabled at reset. And TX clock delay "survives" >

[PATCH v3] ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg()

Each time we get disconencted from AP we get flooded with messages like: ... ath10k_pci :03:00.0: no channel configured; ignoring frame(s)! ath10k_warn: 155 callbacks suppressed ... Use ath10k_dbg() here too Signed-off-by: Gabriel Craciunescu ---

RE: [PATCH net-next 3/8] netvsc: change order of steps in setting queues

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, July 19, 2017 2:53 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > Cc: de...@linuxdriverproject.org;

[PATCH net-next 7/8] netvsc: save pointer to parent netvsc_device in channel table

Keep back pointer in the per-channel data structure to avoid any possible RCU related issues when napi poll is called but netvsc_device is in RCU limbo. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 1 + drivers/net/hyperv/netvsc.c | 3 ++- 2

[PATCH net-next 1/8] netvsc: force link update after MTU change

If two MTU changes are in less than update interval (2 seconds), then the netvsc network device may get stuck with no carrier. The netvsc driver debounces link status events which is fine for unsolicited updates, but blocks getting the update after down/up from MTU reinitialization.

[PATCH net-next 2/8] netvsc: add some rtnl_dereference annotations

In a couple places RTNL is held, and the netvsc_device pointer is acquired without annotation. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 5 +++-- drivers/net/hyperv/netvsc_drv.c | 7 --- 2 files changed, 7 insertions(+), 5 deletions(-)

[PATCH net-next 6/8] netvsc: need rcu_derefence when accessing internal device info

The netvsc_device structure should be accessed by rcu_dereference in the send path. Change arguments to netvsc_send() to make this easier to do correctly. Remove no longer needed hv_device_to_netvsc_device. Signed-off-by: Stephen Hemminger ---

[PATCH net-next 5/8] netvsc: use ERR_PTR to avoid dereference issues

The rndis_filter_device_add function is called both in probe context and RTNL context,and creates the netvsc_device inner structure. It is easier to get the RTNL lock annotation correct if it returns the object directly, rather than implicitly by updating network device private data.

[PATCH net-next 4/8] netvsc: change logic for change mtu and set_queues

Use device detach/attach to ensure that no packets are handed to device during state changes. Call rndis_filter_open/close directly as part of later VF related changes. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 1 +

[PATCH net-next 8/8] netvsc: add rtnl annotations in rndis

The rndis functions are used when changing device state. Therefore the references from network device to internal state are protected by RTNL mutex. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 6 -- drivers/net/hyperv/netvsc.c | 6

[PATCH net-next 0/8] netvsc: lockdep and related fixes

These fix sparse and lockdep warnings from netvsc driver. Targeting these at net-next since no actual related failures have been observed in non-debug kernels. Stephen Hemminger (8): netvsc: force link update after MTU change netvsc: add some rtnl_dereference annotations netvsc: change

[PATCH net-next 3/8] netvsc: change order of steps in setting queues

This fixes the error unwind logic for incorrect number of queues. If netif_set_real_num_XX_queues failed then rndis_filter_device_add would have been called twice. Since input arguments are already ranged checked this is a hypothetical only problem, not possible in actual code. Signed-off-by:

Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()

On 07/19/2017 11:24 AM, Gabriel Craciunescu wrote: To make it consistent, maybe rename the patch title starting with ath10k: > From: Gabriel Craciunescu > > Each time we get disconencted from AP we get flooded with messages like: > > ... > ath10k_pci

Re: out-of-bounds access with virtio-net

On 7/19/17 12:23 PM, Cong Wang wrote: > On Wed, Jul 19, 2017 at 9:59 AM, David Ahern wrote: >> Changing the mac address on a virtio-net based nic is triggering an >> out-of-bounds access. Nothing fancy with the command: >> >> ip li set dev eth2 addr 01:02:34:56:78:9a >> >>

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

On 07/19/2017 10:36 AM, Mason wrote: > On 19/07/2017 19:17, Måns Rullgård wrote: > >> Marc Gonzalez writes: >> >>> According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 >>> ("Documentation: devicetree: clarify usage of the RGMII phy-modes") >>> there are 4 RGMII phy-modes to handle: >>>

[PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()

From: Gabriel Craciunescu Each time we get disconencted from AP we get flooded with messages like: ... ath10k_pci :03:00.0: no channel configured; ignoring frame(s)! ath10k_warn: 155 callbacks suppressed ... Use

Re: out-of-bounds access with virtio-net

On Wed, Jul 19, 2017 at 9:59 AM, David Ahern wrote: > Changing the mac address on a virtio-net based nic is triggering an > out-of-bounds access. Nothing fancy with the command: > > ip li set dev eth2 addr 01:02:34:56:78:9a > > virtnet_set_mac_address is calling kmemdup for

Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()

On 19.07.2017 18:26, Joe Perches wrote: On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote: Each time we get disconencted from AP we get flooded with messages like: ... ath10k_pci :03:00.0: no channel configured; ignoring frame(s)!

Re: [PATCH 1/2] net: phy: at803x: Fix RGMII RX and TX clock delays setup

On 07/19/2017 10:31 AM, Marc Gonzalez wrote: The current code supports enabling RGMII RX and TX clock delays. The unstated assumption is that these settings are disabled by default at reset, which is not the case. RX clock delay is enabled at reset. And TX clock delay "survives" across SW

[PATCH] net: tehuti: don't process data if it has not been copied from userspace

From: Colin Ian King The array data is only populated with valid information from userspace if cmd != SIOCDEVPRIVATE, other cases the array contains garbage on the stack. The subsequent switch statement acts on a subcommand in data[0] which could be any garbage value if

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

On 19/07/2017 19:17, Måns Rullgård wrote: > Marc Gonzalez writes: > >> According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 >> ("Documentation: devicetree: clarify usage of the RGMII phy-modes") >> there are 4 RGMII phy-modes to handle: >> >> "rgmii" (RX and TX delays are added by the

[PATCH net] Revert "rtnetlink: Do not generate notifications for CHANGEADDR event"

This reverts commit cd8966e75ed3c6b41a37047a904617bc44fa481f. The duplicate CHANGEADDR event message is sent regardless of link status whereas the setlink changes only generate a notification when the link is up. Not sending a notification when the link is down breaks dhcpcd which only processes

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

Marc Gonzalez writes: > According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 > ("Documentation: devicetree: clarify usage of the RGMII phy-modes") > there are 4 RGMII phy-modes to handle: > > "rgmii" (RX and TX delays are added by the MAC when required) >

RE: [net-next v3 1/5] ixgbe: Ensure MAC filter was added before setting MACVLAN

> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Wednesday, July 19, 2017 3:55 AM > Subject: Re: [net-next v3 1/5] ixgbe: Ensure MAC filter was added before > setting > MACVLAN > > On Tue, 2017-07-18 at 18:23 -0700, Jeff Kirsher wrote: > > This patch adds a

out-of-bounds access with virtio-net

Changing the mac address on a virtio-net based nic is triggering an out-of-bounds access. Nothing fancy with the command: ip li set dev eth2 addr 01:02:34:56:78:9a virtnet_set_mac_address is calling kmemdup for sizeof sockaddr, yet only ETH_ALEN + sizeof(sa_family_t) bytes were malloc'ed. Full

Re: [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X

Martin Hundebøll writes: > Commit f39908d3b1c45 ('net: dsa: mv88e6xxx: Set the CMODE for mv88e6390 > ports 9 & 10') added support for setting the CMODE for the 6390X family, > but only enabled it for 9290 and 6390 - and left out 6390X. > > Fix support for setting the CMODE on

Re: [patch net-next 14/17] mlxsw: spectrum_router: Add support for IPv6 routes addition / deletion

On Wed, Jul 19, 2017 at 10:36:52AM -0600, David Ahern wrote: > >> 2. How are routes with devices unrelated to ports owned by this driver > >> handled? > > > > They are handled just like any other route, but they don't have a valid > > RIF (for directly connected routes) or an adjacency group (for

Re: [patch net-next 14/17] mlxsw: spectrum_router: Add support for IPv6 routes addition / deletion

On 7/19/17 10:30 AM, Ido Schimmel wrote: >> rif == 0 means the dst device is not related to a port owned by this >> driver? > > Yes. > >> >> >> A lot to process so I am sure I missed the answer to these: >> >> 1. How do you handle host routes for local addresses? IPv6 inserts the >> host and

Re: [patch net-next 16/17] mlxsw: spectrum_router: Abort on source-specific routes

On Wed, Jul 19, 2017 at 10:16:19AM -0600, David Ahern wrote: > On 7/19/17 1:02 AM, Jiri Pirko wrote: > > From: Ido Schimmel > > > > Without resorting to ACLs, the device performs route lookup solely based > > on the destination IP address. > > > > In case source-specific

Re: [patch net-next 14/17] mlxsw: spectrum_router: Add support for IPv6 routes addition / deletion

On Wed, Jul 19, 2017 at 10:14:54AM -0600, David Ahern wrote: > On 7/19/17 1:02 AM, Jiri Pirko wrote: > > @@ -2094,6 +2106,40 @@ mlxsw_sp_fib_entry_should_offload(const struct > > mlxsw_sp_fib_entry *fib_entry) > > } > > } > > > > +static void > > +mlxsw_sp_fib6_entry_offload_set(struct

Re: [patch net-next 11/17] ipv6: fib: Allow non-FIB users to take reference on route

On 7/19/17 10:17 AM, Ido Schimmel wrote: > I did exactly that in the beginning, but it didn't sit right with me for > the exact reason you mentioned - it can be a PITA to debug. > > If we use rt6i_ref for something other than FIB references, then it > breaks existing code that relies on rt6i_ref

Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()

On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote: > Each time we get disconencted from AP we get flooded with messages > like: > > ... > ath10k_pci :03:00.0: no channel configured; ignoring frame(s)! > > ath10k_warn: 155 callbacks suppressed

Re: [patch net-next 10/17] ipv6: fib: Add offload indication to routes

On Wed, Jul 19, 2017 at 09:53:28AM -0600, David Ahern wrote: > On 7/19/17 9:49 AM, Ido Schimmel wrote: > > On Wed, Jul 19, 2017 at 09:27:30AM -0600, David Ahern wrote: > >> On 7/19/17 1:02 AM, Jiri Pirko wrote: > >>> Allow user space applications to see which routes are offloaded and > >>> which

Re: [patch net-next 11/17] ipv6: fib: Allow non-FIB users to take reference on route

On Wed, Jul 19, 2017 at 09:49:37AM -0600, David Ahern wrote: > On 7/19/17 1:02 AM, Jiri Pirko wrote: > > From: Ido Schimmel > > > > Listeners of the FIB notification chain are expected to be able to take > > and release a reference on notified IPv6 routes. This is needed in

Re: [patch net-next 16/17] mlxsw: spectrum_router: Abort on source-specific routes

On 7/19/17 1:02 AM, Jiri Pirko wrote: > From: Ido Schimmel > > Without resorting to ACLs, the device performs route lookup solely based > on the destination IP address. > > In case source-specific routing is needed, an error is returned and the > abort mechanism is

Re: [patch net-next 14/17] mlxsw: spectrum_router: Add support for IPv6 routes addition / deletion

On 7/19/17 1:02 AM, Jiri Pirko wrote: > @@ -2094,6 +2106,40 @@ mlxsw_sp_fib_entry_should_offload(const struct > mlxsw_sp_fib_entry *fib_entry) > } > } > > +static void > +mlxsw_sp_fib6_entry_offload_set(struct mlxsw_sp_fib_entry *fib_entry) > +{ > + struct mlxsw_sp_fib6_entry

[PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

The patchset moves the DSA driver into learning static FDB entries via the switchdev notification chain rather then by using bridge bypass SELF flag. The DSA drivers cannot sync the software bridge with hardware learned entries and use the switchdev's implementation of bypass FDB dumping.

[PATCH net-next v2 08/13] net: dsa: Remove support for bypass bridge port attributes/vlan set

The bridge port attributes/vlan for DSA devices should be set only from bridge code. Furthermore, The vlans are synced totally with the bridge so there is no need for special dump support. Signed-off-by: Arkadi Sharshevsky --- include/net/dsa.h | 4

[PATCH net-next v2 02/13] net: dsa: Remove prepare phase for FDB

The prepare phase for FDB add is unneeded because most of DSA devices can have failures during bus transactions (SPI, I2C, etc.), thus, the prepare phase cannot guarantee success of the commit stage. The support for learning FDB through notification chain, which will be introduced in the

[PATCH net-next v2 07/13] net: dsa: Remove support for vlan dump from DSA's drivers

This is done as a preparation before removing support for vlan dump from DSA core. The vlans are synced with the bridge and thus there is no need for special dump operation support. Signed-off-by: Arkadi Sharshevsky --- drivers/net/dsa/b53/b53_common.c | 44

[PATCH net-next v2 04/13] net: dsa: Add support for learning FDB through notification

Add support for learning FDB through notification. The driver defers the hardware update via ordered work queue. In case of a successful FDB add a notification is sent back to bridge. In case of hw FDB del failure the static FDB will be deleted from the bridge, thus, the interface is moved to

  1   2   >