[GIT] Networking

2017-07-31 Thread David Miller
1) Handle notifier registry failures properly in tun/tap driver, from Tonghao Zhang. 2) Fix bpf verifier handling of subtraction bounds and add a testcase for this, from Edward Cree. 3) Increase reset timeout in ftgmac100 driver, from Ben Herrenschmidt. 4) Fix use after free in

Re: [PATCH net] samples/bpf: fix bpf tunnel cleanup

2017-07-31 Thread David Miller
From: William Tu Date: Mon, 31 Jul 2017 14:40:50 -0700 > test_tunnel_bpf.sh fails to remove the vxlan11 tunnel device, causing the > next geneve tunnelling test case fails. In addition, the geneve reserved bit > in tcbpf2_kern.c should be zero, according to the RFC. > >

Re: [PATCH net] udp6: fix jumbogram reception

2017-07-31 Thread David Miller
From: Paolo Abeni Date: Mon, 31 Jul 2017 16:52:36 +0200 > Since commit 67a51780aebb ("ipv6: udp: leverage scratch area > helpers") udp6_recvmsg() read the skb len from the scratch area, > to avoid a cache miss. > But the UDP6 rx path support RFC 2675 UDPv6 jumbograms, and

Re: [PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

2017-07-31 Thread David Miller
From: gfree.w...@vip.163.com Date: Mon, 31 Jul 2017 18:07:38 +0800 > From: Gao Feng > > The PPTP set the pptp_sock_destruct as the sock's sk_destruct, it would > trigger this bug when __sk_free is invoked in atomic context, because of > the call path

Re: [patch net-next 09/20] net: sched: convert actions array into rcu list

2017-07-31 Thread Jiri Pirko
Mon, Jul 31, 2017 at 11:07:13PM CEST, xiyou.wangc...@gmail.com wrote: >On Fri, Jul 28, 2017 at 7:40 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently the actions are stored in array with array size. To traverse >> this array in fastpath, tcf_tree_lock

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-07-31 Thread Jiri Pirko
Mon, Jul 31, 2017 at 10:37:21PM CEST, xiyou.wangc...@gmail.com wrote: >On Fri, Jul 28, 2017 at 7:40 AM, Jiri Pirko wrote: >> +static inline int >> +tcf_exts_exec(struct sk_buff *skb, struct tcf_exts *exts, >> + struct tcf_result *res) >> +{ >> +#ifdef

Re: [PATCH net-next v12 0/4] net sched actions: improve dump performance

2017-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2017 08:06:42 -0400 Jamal Hadi Salim wrote: > On 17-07-30 10:28 PM, David Miller wrote: > > > > Series applied, thanks. > > > > Thanks David. > > Attaching the iproute2 patch. I will submit an official one with > man page changes later. Stephen - you take

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2017 17:40:50 -0700 Amritha Nambiar wrote: The concept is fine, bu t the code looks different than the rest which is never a good sign. > + if ((argc > 0) && (matches(*argv, "tc") == 0)) { Extra () are unnecessary in

Re: TCP fast retransmit issues

2017-07-31 Thread Neal Cardwell
On Fri, Jul 28, 2017 at 6:54 PM, Neal Cardwell wrote: > On Wed, Jul 26, 2017 at 3:02 PM, Neal Cardwell wrote: >> On Wed, Jul 26, 2017 at 2:38 PM, Neal Cardwell wrote: >>> Yeah, it looks like I can reproduce this issue with (1)

[PATCH net-next 09/10] net: ipv4: Support for sockets bound to enslaved device

2017-07-31 Thread David Ahern
Add support for sockets bound to a network interface enslaved to an L3 Master device (e.g, VRF). Currently for VRF, skb->dev points to the VRF device meaning socket lookups only consider this device index. The real ingress device index is saved to IPCB(skb)->iif and the VRF driver marks the skb

[PATCH net-next 07/10] net: ipv6: Convert raw sockets to sk_lookup

2017-07-31 Thread David Ahern
Convert __raw_v6_lookup to use the new sk_lookup struct Signed-off-by: David Ahern --- include/net/rawv6.h | 3 +-- net/ipv4/raw_diag.c | 15 ++- net/ipv6/raw.c | 41 +++-- 3 files changed, 34 insertions(+), 25

[PATCH net-next 04/10] net: ipv4: Convert raw sockets to sk_lookup

2017-07-31 Thread David Ahern
Convert __raw_v4_lookup to use the new sk_lookup struct Signed-off-by: David Ahern --- include/net/raw.h | 3 +-- net/ipv4/raw.c | 72 ++--- net/ipv4/raw_diag.c | 15 +++ 3 files changed, 58 insertions(+), 32

[PATCH net-next 10/10] net: ipv6: Support for sockets bound to enslaved device

2017-07-31 Thread David Ahern
Add support for sockets bound to a network interface enslaved to an L3 Master device (e.g, VRF). Currently for VRF, skb->dev points to the VRF device meaning socket lookups only consider this device index. The real ingress device index is saved to IP6CB(skb)->iif and the VRF driver marks the skb

[PATCH net-next 00/10] net: l3mdev: Support for sockets bound to enslaved device

2017-07-31 Thread David Ahern
A missing piece to the VRF puzzle is the ability to bind sockets to devices enslaved to a VRF. This patch set adds the enslaved device index, sdif, to IPv4 and IPv6 socket lookups. The end result for users is the following scope options for services: 1. "global" services - sockets not bound to

[PATCH net-next 06/10] net: ipv6: Convert inet socket lookups to new struct

2017-07-31 Thread David Ahern
Convert the various inet6_lookup functions to use the new sk_lookup struct. Signed-off-by: David Ahern --- include/net/inet6_hashtables.h | 39 +++- net/dccp/ipv6.c | 22 net/ipv4/inet_diag.c| 19 ++

[PATCH net-next 03/10] net: ipv4: Convert inet socket lookups to new struct

2017-07-31 Thread David Ahern
Convert the various inet_lookup functions to use the new sk_lookup struct. Signed-off-by: David Ahern --- include/net/inet_hashtables.h | 57 ++ net/dccp/ipv4.c | 19 +--- net/ipv4/inet_diag.c|

[PATCH net-next 08/10] net: Add sdif to sk_lookup

2017-07-31 Thread David Ahern
Add a second device index, sdif, to the socket lookup struct. sdif will be the device index for devices enslaved to an l3mdev. It allows the lookups to consider the enslaved device as well as the L3 master device when searching for a socket. Signed-off-by: David Ahern ---

[PATCH net-next 02/10] net: ipv4: Convert udp socket lookups to new struct

2017-07-31 Thread David Ahern
Convert udp4_lib_lookup and __udp4_lib_lookup to use the new sk_lookup struct. Signed-off-by: David Ahern --- include/net/udp.h | 6 +- net/ipv4/netfilter/nf_socket_ipv4.c | 11 ++- net/ipv4/udp.c | 170

[PATCH net-next 01/10] net: Add sk_lookup struct and helper

2017-07-31 Thread David Ahern
Consolidate the socket lookup args into a struct. Add helper that compares sk_bound_dev_if for a socket to the lookup parameters. Signed-off-by: David Ahern --- include/net/sock.h | 38 ++ 1 file changed, 38 insertions(+) diff --git

[PATCH net-next 05/10] net: ipv6: Convert udp socket lookups to new struct

2017-07-31 Thread David Ahern
Convert udp6_lib_lookup and __udp6_lib_lookup to use the new sk_lookup struct. Signed-off-by: David Ahern --- include/net/udp.h | 12 +-- net/ipv4/udp_diag.c | 33 --- net/ipv6/netfilter/nf_socket_ipv6.c | 11 ++- net/ipv6/udp.c

Re: [PATCH V3 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission

2017-07-31 Thread Neal Cardwell
On Mon, Jul 31, 2017 at 11:49 AM, Neal Cardwell wrote: > On Sun, Jul 30, 2017 at 11:29 PM, maowenan wrote: >> [Mao Wenan]please refer to the attachment, test.pkt is packetdrill script. >> In test.pcap, packet number 17 is the TLP probe, packet number

[PATCH net 2/3] tcp: enable xmit timer fix by having TLP use time when RTO should fire

2017-07-31 Thread Neal Cardwell
Have tcp_schedule_loss_probe() base the TLP scheduling decision based on when the RTO *should* fire. This is to enable the upcoming xmit timer fix in this series, where tcp_schedule_loss_probe() cannot assume that the last timer installed was an RTO timer (because we are no longer doing the "rearm

[PATCH net 1/3] tcp: introduce tcp_rto_delta_us() helper for xmit timer fix

2017-07-31 Thread Neal Cardwell
Pure refactor. This helper will be required in the xmit timer fix later in the patch series. (Because the TLP logic will want to make this calculation.) Fixes: 6ba8a3b19e76 ("tcp: Tail loss probe (TLP)") Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng

[PATCH net 0/3] tcp: fix xmit timer rearming to avoid stalls

2017-07-31 Thread Neal Cardwell
This patch series is a bug fix for a TCP loss recovery performance bug reported independently in recent netdev threads: (i) July 26, 2017: netdev thread "TCP fast retransmit issues" (ii) July 26, 2017: netdev thread: "[PATCH V2 net-next] TLP: Don't reschedule PTO when there's one

[PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-07-31 Thread Neal Cardwell
Fix a TCP loss recovery performance bug raised recently on the netdev list, in two threads: (i) July 26, 2017: netdev thread "TCP fast retransmit issues" (ii) July 26, 2017: netdev thread: "[PATCH V2 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission"

Re: [RFC net-next] net ipv6: convert fib6_table rwlock to a percpu lock

2017-07-31 Thread Shaohua Li
On Mon, Jul 31, 2017 at 04:10:07PM -0700, Stephen Hemminger wrote: > On Mon, 31 Jul 2017 10:18:57 -0700 > Shaohua Li wrote: > > > From: Shaohua Li > > > > In a syn flooding test, the fib6_table rwlock is a significant > > bottleneck. While converting the rwlock to

Re: [PATCH net] ipv6: set fc_protocol with 0 when rtm_protocol is RTPROT_REDIRECT

2017-07-31 Thread Xin Long
On Tue, Aug 1, 2017 at 2:01 PM, David Ahern wrote: > On 7/31/17 7:40 PM, Xin Long wrote: >> To respect the old code more, setting RTPROT_RA only when >> it's with the flag (ADDRCONF | DEFAULT | ROUTEINFO), >> shouldn't it be: > > Look at rtm_fill_info: > > if

Re: [PATCH V2 net-next 0/2] liquidio: Add support for managing liquidio adapter

2017-07-31 Thread Felix Manlunas
On Mon, Jul 31, 2017 at 05:59:37PM -0700, David Miller wrote: > From: Simon Horman > Date: Sun, 30 Jul 2017 22:21:04 +0200 > > > On Fri, Jul 28, 2017 at 11:17:07PM -0700, Felix Manlunas wrote: > >> From: Veerasenareddy Burru > >> >

Re: [PATCH net] ipv6: set fc_protocol with 0 when rtm_protocol is RTPROT_REDIRECT

2017-07-31 Thread David Ahern
On 7/31/17 7:40 PM, Xin Long wrote: > To respect the old code more, setting RTPROT_RA only when > it's with the flag (ADDRCONF | DEFAULT | ROUTEINFO), > shouldn't it be: Look at rtm_fill_info: if (rt->rt6i_flags & (RTF_DEFAULT | RTF_ROUTEINFO)) rtm->rtm_protocol =

Re: [PATCH net-next 2/2] liquidio: Add support to create management interface

2017-07-31 Thread Felix Manlunas
On Tue, Jul 18, 2017 at 11:58:27AM -0700, Jakub Kicinski wrote: > On Mon, 17 Jul 2017 12:52:17 -0700, Felix Manlunas wrote: > > From: VSR Burru > > > > This patch adds support to create a virtual ethernet interface to > > communicate with Linux on LiquidIO

Re: [PATCH net] ipv6: set fc_protocol with 0 when rtm_protocol is RTPROT_REDIRECT

2017-07-31 Thread Xin Long
On Tue, Aug 1, 2017 at 12:12 PM, David Ahern wrote: > On 7/30/17 9:31 PM, Xin Long wrote: >>> Did you look at removing this hunk from rt6_fill_node: >>> >>> if (rt->rt6i_flags & RTF_DYNAMIC) >>> rtm->rtm_protocol = RTPROT_REDIRECT; >>> else if

[PATCH v6 net-next] net: systemport: Support 64bit statistics

2017-07-31 Thread Jianming.qiao
When using Broadcom Systemport device in 32bit Platform, ifconfig can only report up to 4G tx,rx status, which will be wrapped to 0 when the number of incoming or outgoing packets exceeds 4G, only taking around 2 hours in busy network environment (such as streaming). Therefore, it makes hard for

Re: [PATCH net] Revert "net: bcmgenet: Remove init parameter from bcmgenet_mii_config"

2017-07-31 Thread David Miller
From: Florian Fainelli Date: Mon, 31 Jul 2017 11:05:32 -0700 > This reverts commit 28b45910ccda ("net: bcmgenet: Remove init parameter > from bcmgenet_mii_config") because in the process of moving from > dev_info() to dev_info_once() we essentially lost the helpful printed

Re: [PATCH net-next] ipv6: Avoid going through ->sk_net to access the netns

2017-07-31 Thread David Miller
From: Jakub Sitnicki Date: Mon, 31 Jul 2017 10:09:41 +0200 > There is no need to go through sk->sk_net to access the net namespace > and its sysctl variables because we allocate the sock and initialize > sk_net just a few lines earlier in the same routine. > > Signed-off-by:

Re: [PATCH net-next 0/7] More Marvell PHY refactoring and cleanup

2017-07-31 Thread David Miller
From: Andrew Lunn Date: Sun, 30 Jul 2017 22:41:43 +0200 > Consolidate more duplicated code into helpers, make use of core > helpers, move code into a helper for later adding functionality to add > marvell PHYs, etc. Series applied.

Re: [PATCH V2 net-next 0/2] liquidio: Add support for managing liquidio adapter

2017-07-31 Thread David Miller
From: Simon Horman Date: Sun, 30 Jul 2017 22:21:04 +0200 > On Fri, Jul 28, 2017 at 11:17:07PM -0700, Felix Manlunas wrote: >> From: Veerasenareddy Burru >> >> The LiquidIO adapter has processor cores that can run Linux. This patch >>

Re: [PATCH] mv643xx_eth: fix of_irq_to_resource() error check

2017-07-31 Thread David Miller
From: Sergei Shtylyov Date: Sat, 29 Jul 2017 22:18:41 +0300 > of_irq_to_resource() has recently been fixed to return negative error #'s > along with 0 in case of failure, however the Marvell MV643xx Ethernet > driver still only regards 0 as invalid IRQ --

Re: [PATCH] net-next: stmmac: dwmac-sun8i: fix of_table.cocci warnings

2017-07-31 Thread David Miller
From: Julia Lawall Date: Sat, 29 Jul 2017 17:54:10 +0200 (CEST) > Make sure (of/i2c/platform)_device_id tables are NULL terminated > > Generated by: scripts/coccinelle/misc/of_table.cocci > > Fixes: d5dbe1976d52 ("net-next: stmmac: dwmac-sun8i: choose internal PHY via >

Re: [PATCH net-next] net: bcmgenet: Add dependency on HAS_IOMEM && OF

2017-07-31 Thread David Miller
From: Florian Fainelli Date: Mon, 31 Jul 2017 17:53:07 -0700 > The driver needs CONFIG_HAS_IOMEM and OF to be functional, but we still > let it build with COMPILE_TEST. This fixes the unmet dependency after > selecting MDIO_BCM_UNIMAC in commit mentioned below: > >

[PATCH net-next] net: bcmgenet: Add dependency on HAS_IOMEM && OF

2017-07-31 Thread Florian Fainelli
The driver needs CONFIG_HAS_IOMEM and OF to be functional, but we still let it build with COMPILE_TEST. This fixes the unmet dependency after selecting MDIO_BCM_UNIMAC in commit mentioned below: warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies

Re: [PATCH net v3] MAINTAINERS: Add more files to the PHY LIBRARY section

2017-07-31 Thread David Miller
From: Florian Fainelli Date: Mon, 31 Jul 2017 09:47:50 -0700 > Include missing files that are provided by, used, or directly maintained > within the PHY LIBRARY, this include uapi header, header files used by > Device Tree code etc. > > Signed-off-by: Florian Fainelli

Re: [PATCH net] ipv4: fib: Fix NULL pointer deref during fib_sync_down_dev()

2017-07-31 Thread David Miller
From: Ido Schimmel Date: Fri, 28 Jul 2017 23:27:44 +0300 > Michał reported a NULL pointer deref during fib_sync_down_dev() when > unregistering a netdevice. The problem is that we don't check for > 'in_dev' being NULL, which can happen in very specific cases. > > Usually

[PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-07-31 Thread Amritha Nambiar
The Mirred/redirect action is extended to accept a traffic class on the device in addition to the device's ifindex. Usage: mirred Example: # tc qdisc add dev eth0 ingress # tc filter add dev eth0 protocol ip parent : prio 1 flower\ dst_ip 192.168.1.1/32 ip_proto udp dst_port 22\

[PATCH 4/6] [net-next]net: i40e: Admin queue definitions for cloud filters

2017-07-31 Thread Amritha Nambiar
Add new admin queue definitions and extended fields for cloud filter support. Define big buffer for extended general fields in Add/Remove Cloud filters command. Signed-off-by: Amritha Nambiar Signed-off-by: Kiran Patil Signed-off-by: Store Laura

[PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier

2017-07-31 Thread Amritha Nambiar
This patch enables tc-flower based hardware offloads. tc/flower filter provided by the kernel is configured as driver specific cloud filter. The patch implements functions and admin queue commands needed to support cloud filters in the driver and adds cloud filters to configure these tc-flower

[PATCH 3/6] [net-next]net: i40e: Extend set switch config command to accept cloud filter mode

2017-07-31 Thread Amritha Nambiar
Add definitions for L4 filters and switch modes based on cloud filters modes and extend the set switch config command to include the additional cloud filter mode. Signed-off-by: Amritha Nambiar Signed-off-by: Kiran Patil ---

[PATCH 2/6] [net-next]net: i40e: Maintain a mapping of TCs with the VSI seids

2017-07-31 Thread Amritha Nambiar
Add mapping of TCs with the seids of the channel VSIs. TC0 will be mapped to the main VSI seid and all other TCs are mapped to the seid of the channel VSI. Signed-off-by: Amritha Nambiar --- drivers/net/ethernet/intel/i40e/i40e.h |1 +

[PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

2017-07-31 Thread Amritha Nambiar
The Mirred/redirect action is extended to forward to a traffic class on the device. The traffic class index needs to be provided in addition to the device's ifindex. Example: # tc filter add dev eth0 protocol ip parent : prio 1 flower\ dst_ip 192.168.1.1/32 ip_proto udp dst_port 22\

[PATCH 5/6] [net-next]net: i40e: Clean up of cloud filters

2017-07-31 Thread Amritha Nambiar
Introduce the cloud filter datastructure and cleanup of cloud filters associated with the device. Signed-off-by: Amritha Nambiar --- drivers/net/ethernet/intel/i40e/i40e.h | 11 +++ drivers/net/ethernet/intel/i40e/i40e_main.c | 27

[PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier

2017-07-31 Thread Amritha Nambiar
This patch series enables configuring cloud filters in i40e using the tc/flower classifier. The only tc-filter action supported is to redirect packets to a traffic class on the same device. The tc/mirred:redirect action is extended to accept a traffic class to achieve this. The cloud filters are

Re: [PATCH net-next 1/7] net: phy: mdio-bcm-unimac: factor busy polling loop

2017-07-31 Thread Florian Fainelli
On 07/31/2017 05:28 PM, kbuild test robot wrote: > Hi Florian, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-bcmgenet-utilize-MDIO-unimac-driver/20170801-075847 > config: xtensa-allmodconfig (attached as .config) >

Re: [PATCH net-next 1/7] net: phy: mdio-bcm-unimac: factor busy polling loop

2017-07-31 Thread kbuild test robot
Hi Florian, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-bcmgenet-utilize-MDIO-unimac-driver/20170801-075847 config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-07-31 Thread David Miller
From: Florian Fainelli Date: Fri, 28 Jul 2017 11:58:36 -0700 > Marc reported that he was not getting the PHY library adjust_link() > callback function to run when calling phy_stop() + phy_disconnect() > which does not indeed happen because we set the state machine to >

[net-next:master 345/358] warning: (NET_DSA_BCM_SF2 && ..) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && ..)

2017-07-31 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 6a95befc8d0346d6cb3b4646c761e8b42e66a4df commit: 9a4e79697009ddd0d1af52053c830f6e60e1c771 [345/358] net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver config:

Re: [PATCH] hysdn: fix to a race condition in put_log_buffer

2017-07-31 Thread David Miller
From: Anton Volkov Date: Fri, 28 Jul 2017 17:53:51 +0300 > The synchronization type that was used earlier to guard the loop that > deletes unused log buffers may have lead to a situation that prevents > any thread from going through the loop. > > The patch deletes previously

Re: [PATCH net-next 1/2] tcp: extract the function to compute delivery rate

2017-07-31 Thread David Miller
From: Wei Wang Date: Fri, 28 Jul 2017 10:28:20 -0700 > From: Wei Wang > > Refactor the code to extract the function to compute delivery rate. > This function will be used in later commit. > > Signed-off-by: Wei Wang > Acked-by: Yuchung

Re: [PATCH net-next 2/2] tcp: add related fields into SCM_TIMESTAMPING_OPT_STATS

2017-07-31 Thread David Miller
From: Wei Wang Date: Fri, 28 Jul 2017 10:28:21 -0700 > From: Wei Wang > > Add the following stats into SCM_TIMESTAMPING_OPT_STATS control msg: > TCP_NLA_PACING_RATE > TCP_NLA_DELIVERY_RATE > TCP_NLA_SND_CWND > TCP_NLA_REORDERING >

Re: [PATCH net] ipv6: set fc_protocol with 0 when rtm_protocol is RTPROT_REDIRECT

2017-07-31 Thread David Ahern
On 7/30/17 9:31 PM, Xin Long wrote: >> Did you look at removing this hunk from rt6_fill_node: >> >> if (rt->rt6i_flags & RTF_DYNAMIC) >> rtm->rtm_protocol = RTPROT_REDIRECT; >> else if (rt->rt6i_flags & RTF_ADDRCONF) { >> if (rt->rt6i_flags &

Re: Long stalls creating a new netns after a netns with a SMB client exits

2017-07-31 Thread David Ahern
On 7/31/17 4:01 PM, Cong Wang wrote: >>> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c >>> index 3a19ea28339f..37db087b6c97 100644 >>> --- a/net/ipv4/tcp_ipv4.c >>> +++ b/net/ipv4/tcp_ipv4.c >>> @@ -1855,7 +1855,7 @@ void inet_sk_rx_dst_set(struct sock *sk, const >>> struct sk_buff *skb)

[PATCH net-next v2 0/3] netvsc: transparent SR-IOV VF support

2017-07-31 Thread Stephen Hemminger
This patch set changes how SR-IOV Virtual Function devices are managed in the Hyper-V network driver. It was part of earlier bundle, but is now updated. Background In Hyper-V SR-IOV can be enabled (and disabled) by changing guest settings on host. When SR-IOV is enabled a matching PCI device is

[PATCH net-next v2 1/3] netvsc: transparent VF management

2017-07-31 Thread Stephen Hemminger
This patch implements transparent fail over from synthetic NIC to SR-IOV virtual function NIC in Hyper-V environment. It is a better alternative to using bonding as is done now. Instead, the receive and transmit fail over is done internally inside the driver. Using bonding driver has lots of

[PATCH net-next v2 3/3] netvsc: remove bonding setup script

2017-07-31 Thread Stephen Hemminger
No longer needed, now all managed by transparent VF logic. Signed-off-by: Stephen Hemminger --- tools/hv/bondvf.sh | 255 - 1 file changed, 255 deletions(-) delete mode 100755 tools/hv/bondvf.sh diff --git

[PATCH net-next v2 2/3] netvsc: add documentation

2017-07-31 Thread Stephen Hemminger
Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger --- Documentation/networking/netvsc.txt | 63 + MAINTAINERS | 1 + 2 files changed, 64 insertions(+)

Re: [PATCH net-next v12 0/4] net sched actions: improve dump performance

2017-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2017 08:06:42 -0400 Jamal Hadi Salim wrote: > On 17-07-30 10:28 PM, David Miller wrote: > > > > Series applied, thanks. > > > > Thanks David. > > Attaching the iproute2 patch. I will submit an official one with > man page changes later. Stephen - you take

Re: [PATCH net-next 4/4] pci-hyperv: do not sleep in compose_msi_msg

2017-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2017 16:37:12 -0700 Stephen Hemminger wrote: > The setup of MSI with Hyper-V host was sleeping with locks held. > This error is reported when doing SR-IOV hotplug with kernel built with > lockdep. > > BUG: sleeping function called from invalid

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-31 Thread David Miller
From: David Ahern Date: Mon, 31 Jul 2017 17:34:09 -0600 > On 7/31/17 5:22 PM, David Miller wrote: >> From: Hangbin Liu >> Date: Fri, 28 Jul 2017 00:25:36 +0800 >> >>> After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib >>> result

[PATCH net-next 4/4] pci-hyperv: do not sleep in compose_msi_msg

2017-07-31 Thread Stephen Hemminger
The setup of MSI with Hyper-V host was sleeping with locks held. This error is reported when doing SR-IOV hotplug with kernel built with lockdep. BUG: sleeping function called from invalid context at kernel/sched/completion.c:93 in_atomic(): 1, irqs_disabled(): 1, pid: 1405, name: ip

[PATCH net-next 1/4] netvsc: transparent VF management

2017-07-31 Thread Stephen Hemminger
This patch implements transparent fail over from synthetic NIC to SR-IOV virtual function NIC in Hyper-V environment. It is a better alternative to using bonding as is done now. Instead, the receive and transmit fail over is done internally inside the driver. Using bonding driver has lots of

[PATCH net-next 3/4] netvsc: remove bonding setup script

2017-07-31 Thread Stephen Hemminger
No longer needed, now all managed by transparent VF logic. Signed-off-by: Stephen Hemminger --- tools/hv/bondvf.sh | 255 - 1 file changed, 255 deletions(-) delete mode 100755 tools/hv/bondvf.sh diff --git

[PATCH net-next 0/4] netvsc: transparent SR-IOV VF support

2017-07-31 Thread Stephen Hemminger
This patch set changes how SR-IOV Virtual Function devices are managed in the Hyper-V network driver. It was part of earlier bundle, but is now updated. Background In Hyper-V SR-IOV can be enabled (and disabled) by changing guest settings on host. When SR-IOV is enabled a matching PCI device is

[PATCH net-next 2/4] netvsc: add documentation

2017-07-31 Thread Stephen Hemminger
Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger --- Documentation/networking/netvsc.txt | 63 + MAINTAINERS | 1 + 2 files changed, 64 insertions(+)

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-31 Thread David Ahern
On 7/31/17 5:22 PM, David Miller wrote: > From: Hangbin Liu > Date: Fri, 28 Jul 2017 00:25:36 +0800 > >> After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib >> result when requested"). When we get a prohibit ertry, we will return >> -EACCES directly

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-31 Thread David Miller
From: Hangbin Liu Date: Fri, 28 Jul 2017 00:25:36 +0800 > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > result when requested"). When we get a prohibit ertry, we will return > -EACCES directly instead of dump route info. > > Fix it by remove the

Re: [PATCH v2] net: phy: Log only PHY state transitions

2017-07-31 Thread David Miller
From: Marc Gonzalez Date: Fri, 28 Jul 2017 13:18:30 +0200 > In the current code, old and new PHY states are always logged. > From now on, log only PHY state transitions. > > Signed-off-by: Marc Gonzalez Applied to net-next,

Re: [RFC net-next] net ipv6: convert fib6_table rwlock to a percpu lock

2017-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2017 10:18:57 -0700 Shaohua Li wrote: > From: Shaohua Li > > In a syn flooding test, the fib6_table rwlock is a significant > bottleneck. While converting the rwlock to rcu sounds straighforward, > but is very challenging if it's possible. A percpu

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

2017-07-31 Thread kbuild test robot
Hi Rafał, [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v4.13-rc3 next-20170731] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/firmware

Re: [PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

2017-07-31 Thread Shaohua Li
On Mon, Jul 31, 2017 at 03:35:02PM -0700, Cong Wang wrote: > On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > > static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff > > *skb, > > __be32 flowlabel, bool autolabel, >

Re: [PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

2017-07-31 Thread Cong Wang
On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff *skb, > __be32 flowlabel, bool autolabel, > - struct flowi6 *fl6) > +

[PATCH net-next 01/11] net: dsa: make EEE ops optional

2017-07-31 Thread Vivien Didelot
Even though EEE implies the port's PHY and MAC of both ends, a switch may not need to do anything to configure the port's MAC. This makes it impossible for the DSA layer to distinguish e.g. this case from a disabled EEE when a driver returns 0 from the get EEE operation. For this reason, make

[PATCH net-next 11/11] net: dsa: rename switch EEE ops

2017-07-31 Thread Vivien Didelot
To avoid confusion with the PHY EEE settings, rename the .set_eee and .get_eee ops to respectively .set_mac_eee and .get_mac_eee. Signed-off-by: Vivien Didelot --- drivers/net/dsa/bcm_sf2.c | 12 ++-- drivers/net/dsa/qca8k.c | 4 ++--

[PATCH net-next 03/11] net: dsa: qca8k: enable EEE once

2017-07-31 Thread Vivien Didelot
If EEE is queried enabled, qca8k_set_eee calls qca8k_eee_enable_set twice (because it is already called in qca8k_eee_init). Fix that. Signed-off-by: Vivien Didelot --- drivers/net/dsa/qca8k.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH net-next 00/11] net: dsa: rework EEE support

2017-07-31 Thread Vivien Didelot
EEE implies configuring the port's PHY and MAC of both ends of the wire. The current EEE support in DSA mixes PHY and MAC configuration, which is bad because PHYs must be configured through a proper PHY driver. The DSA switch operations for EEE are only meant for configuring the port's MAC, which

[PATCH net-next 07/11] net: dsa: mv88e6xxx: call phy_init_eee

2017-07-31 Thread Vivien Didelot
It is safer to init the EEE before the DSA layer call phy_ethtool_set_eee, as sf2 and qca8k are doing. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH net-next 09/11] net: dsa: remove PHY device argument from .set_eee

2017-07-31 Thread Vivien Didelot
The DSA switch operations for EEE are only meant to configure a port's MAC EEE settings. The port's PHY EEE settings are accessed by the DSA layer and must be made available via a proper PHY driver. In order to reduce this confusion, remove the phy_device argument from the .set_eee operation.

[PATCH net-next 08/11] net: dsa: call phy_init_eee in DSA layer

2017-07-31 Thread Vivien Didelot
All DSA drivers are calling phy_init_eee if eee_enabled is true. Move up this statement in the DSA layer to simplify the DSA drivers. qca8k does not require to cache the ethtool_eee structures from now on. Signed-off-by: Vivien Didelot ---

[PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support

2017-07-31 Thread Vivien Didelot
The PHY's EEE settings are already accessed by the DSA layer through the Marvell PHY driver and there is nothing to be done for switch's MACs. Remove all EEE support from the mv88e6xxx driver. Signed-off-by: Vivien Didelot ---

[PATCH net-next 02/11] net: dsa: qca8k: fix EEE init

2017-07-31 Thread Vivien Didelot
The qca8k obviously copied code from the sf2 driver as how to set EEE: if (e->eee_enabled) { p->eee_enabled = qca8k_eee_init(ds, port, phydev); if (!p->eee_enabled) ret = -EOPNOTSUPP; } But it did not use the same logic for the EEE init routine, which is

[PATCH net-next 04/11] net: dsa: qca8k: do not cache unneeded EEE fields

2017-07-31 Thread Vivien Didelot
The qca8k driver is currently caching a bitfield of the supported member of a ethtool_eee private structure, which is unused. Only the eee_enabled field of the private ethtool_eee copy is updated, thus using p->advertised and p->lp_advertised is also erroneous. Remove the usage of these private

[PATCH net-next 05/11] net: dsa: qca8k: remove qca8k_get_eee

2017-07-31 Thread Vivien Didelot
phy_ethtool_get_eee is already called by the DSA layer, thus remove the duplicated call in the qca8k driver. qca8k_get_eee becomes unnecessary. Signed-off-by: Vivien Didelot --- drivers/net/dsa/qca8k.c | 17 - 1 file changed, 17 deletions(-)

[PATCH net-next 06/11] net: dsa: bcm_sf2: remove unneeded supported flags

2017-07-31 Thread Vivien Didelot
The SF2 driver is masking the supported bitfield of its private copy of the ports' ethtool_eee structures. It is used nowhere, thus remove it. Signed-off-by: Vivien Didelot --- drivers/net/dsa/bcm_sf2.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH V4 net 1/2] net: remove unnecessary rotation

2017-07-31 Thread Shaohua Li
From: Shaohua Li According to David Miller, the rotation doesn't really help avoid security problem, so delte it. Suggested-by: David Miller Signed-off-by: Shaohua Li --- include/net/ipv6.h | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-07-31 Thread Shaohua Li
From: Shaohua Li Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690,

[PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

2017-07-31 Thread Shaohua Li
From: Shaohua Li Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690,

Re: [PATCH v3 net-next 1/4] tcp: ULP infrastructure

2017-07-31 Thread Dave Watson
On 07/29/17 01:12 PM, Tom Herbert wrote: > On Wed, Jun 14, 2017 at 11:37 AM, Dave Watson wrote: > > Add the infrustructure for attaching Upper Layer Protocols (ULPs) over TCP > > sockets. Based on a similar infrastructure in tcp_cong. The idea is that > > any > > ULP can add

Re: Long stalls creating a new netns after a netns with a SMB client exits

2017-07-31 Thread Cong Wang
On Mon, Jul 31, 2017 at 9:22 AM, Rolf Neugebauer wrote: > On Fri, Jul 28, 2017 at 8:16 PM, David Ahern wrote: >> On 7/28/17 12:58 PM, Rolf Neugebauer wrote: > I can readily reproduce this on 4.9.39, 4.11.12 and another user > repro-ed it on

Re: Kernel TLS in 4.13-rc1

2017-07-31 Thread Dave Watson
On 07/30/17 11:14 PM, David Oberhollenzer wrote: > On 07/24/2017 11:10 PM, Dave Watson wrote: > > On 07/23/17 09:39 PM, David Oberhollenzer wrote: > >> After fixing the benchmark/test tool that the patch description > >> linked to (https://github.com/Mellanox/tls-af_ktls_tool) to make > >> sure

Re: [patch net-next 0/8] mlxsw: Various small fixes

2017-07-31 Thread David Miller
From: Jiri Pirko Date: Mon, 31 Jul 2017 09:27:22 +0200 > This patch series is to contribute several fixes for nits that I noticed while > working on mlxsw. The changes range from typo fixes to local improvements of > the code and have little in common besides being small in

Re: [PATCH net-next 0/7] net: bcmgenet: utilize MDIO unimac driver

2017-07-31 Thread David Miller
From: Florian Fainelli Date: Mon, 31 Jul 2017 12:04:21 -0700 > Hi all, > > This patch series migrates the Broadcom GENET driver to use the > mdio-bcm-unimac > driver. This MDIO HW is the same as the one GENET internally embedds, yet for > historical reasons the two

[PATCH net] samples/bpf: fix bpf tunnel cleanup

2017-07-31 Thread William Tu
test_tunnel_bpf.sh fails to remove the vxlan11 tunnel device, causing the next geneve tunnelling test case fails. In addition, the geneve reserved bit in tcbpf2_kern.c should be zero, according to the RFC. Signed-off-by: William Tu --- samples/bpf/tcbpf2_kern.c | 4

Re: [RFC net-next 0/6] tcp: remove prequeue and header prediction

2017-07-31 Thread David Miller
From: Eric Dumazet Date: Mon, 31 Jul 2017 13:22:22 -0700 > On Mon, Jul 31, 2017 at 1:04 PM, Yuchung Cheng wrote: >> by the time these devices use 4.12 kernels they are likely powerful >> enough to make header prediction irrelevant... > > Also note that

  1   2   3   >