[PATCH net V3] openvswitch: fix skb_panic due to the incorrect actions attrlen

2017-08-15 Thread Liping Zhang
From: Liping Zhang For sw_flow_actions, the actions_len only represents the kernel part's size, and when we dump the actions to the userspace, we will do the convertions, so it's true size may become bigger than the actions_len. But unfortunately, for

[PATCH v3] openvswitch: enable NSH support

2017-08-15 Thread Yi Yang
v2->v3 - Change OVS_KEY_ATTR_NSH to nested key to handle length-fixed attributes and length-variable attriubte more flexibly. - Remove struct ovs_action_push_nsh completely - Add code to handle nested attribute for SET_MASKED - Change PUSH_NSH to use the nested OVS_KEY_ATTR_NSH to

Re: [PATCH net repost] nfp: do not update MTU from BH in flower app

2017-08-15 Thread Simon Horman
On Tue, Aug 15, 2017 at 09:03:58PM -0700, David Miller wrote: > From: David Miller > Date: Tue, 15 Aug 2017 17:52:40 -0700 (PDT) > > > From: Simon Horman > > Date: Tue, 15 Aug 2017 08:13:48 +0200 > > > >> Could you pull net into net-next? I'd

[net-next PATCH 08/10] bpf: sockmap sample program

2017-08-15 Thread John Fastabend
This program binds a program to a cgroup and then matches hard coded IP addresses and adds these to a sockmap. This will receive messages from the backend and send them to the client. client:X <---> frontend:1 client:X <---> backend:10001 To keep things simple this is only designed for

Re: [PATCH v4 iproute2 1/7] rdma: Add basic infrastructure for RDMA tool

2017-08-15 Thread Leon Romanovsky
On Tue, Aug 15, 2017 at 04:54:16PM -0700, Stephen Hemminger wrote: > On Tue, 15 Aug 2017 16:00:14 +0300 > Leon Romanovsky wrote: > > > RDMA devices are cross-functional devices from one side, > > but very tailored for the specific markets from another. > > > > Such diversity

[net-next PATCH 05/10] bpf: export bpf_prog_inc_not_zero

2017-08-15 Thread John Fastabend
bpf_prog_inc_not_zero will be used by upcoming sockmap patches this patch simply exports it so we can pull it in. Signed-off-by: John Fastabend --- include/linux/bpf.h |7 +++ kernel/bpf/syscall.c |3 ++- 2 files changed, 9 insertions(+), 1 deletion(-)

[net-next PATCH 02/10] net: add sendmsg_locked and sendpage_locked to af_inet6

2017-08-15 Thread John Fastabend
To complete the sendmsg_locked and sendpage_locked implementation add the hooks for af_inet6 as well. Signed-off-by: John Fastabend --- net/ipv6/af_inet6.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index

[net-next PATCH 03/10] net: fixes for skb_send_sock

2017-08-15 Thread John Fastabend
A couple fixes to new skb_send_sock infrastructure. However, no users currently exist for this code (adding user in next handful of patches) so it should not be possible to trigger a panic with existing in-kernel code. Fixes: 306b13eb3cf9 ("proto_ops: Add locked held versions of sendmsg and

[net-next PATCH 01/10] net: early init support for strparser

2017-08-15 Thread John Fastabend
It is useful to allow strparser to init sockets before the read_sock callback has been established. Signed-off-by: John Fastabend --- net/strparser/strparser.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/net/strparser/strparser.c

[net-next PATCH 00/10] BPF: sockmap and sk redirect support

2017-08-15 Thread John Fastabend
This series implements a sockmap and socket redirect helper for BPF using a model similar to XDP netdev redirect. A sockmap is a BPF map type that holds references to sock structs. Then with a new sk redirect bpf helper BPF programs can use the map to redirect skbs between sockets,

Re: [PATCH 1/2] mpls: add handlers

2017-08-15 Thread Roopa Prabhu
On Tue, Aug 15, 2017 at 2:37 AM, David Lamparter wrote: [snip] > I think the reverse is the better option, removing the vpls device > information and just going with the route table. My approach to this > would be to add a new netlink route attribute "RTA_VPLS" which >

[PATCH] bpf: Update sysctl documentation to list all supported architectures

2017-08-15 Thread Michael Ellerman
The sysctl documentation states that the JIT is only available on x86_64, which is no longer correct. Update the list to include all architectures that enable HAVE_CBPF_JIT or HAVE_EBPF_JIT under some configuration. Signed-off-by: Michael Ellerman ---

Re: [PATCH] qdisc: add tracepoint qdisc:qdisc_dequeue for dequeued SKBs

2017-08-15 Thread Jesper Dangaard Brouer
On Tue, 15 Aug 2017 20:31:44 -0600 David Ahern wrote: > On 8/15/17 1:11 PM, Jesper Dangaard Brouer wrote: > > diff --git a/include/trace/events/qdisc.h b/include/trace/events/qdisc.h > > new file mode 100644 > > index ..60d0d8bd336d > > --- /dev/null > > +++

Re: Possible race in c4.ko

2017-08-15 Thread Carsten Paeth
Hello Anton, Thanks for reviewing the code. This would be right, if the c4 could rise an interrupt at this moment ... After a reset with c4_reset(), the card will not generate an interrupt, until firmware has been loaded and the SEND_INIT message has been sent. c4_load_firmware() ->

[PATCH] net: 3c509: constify pnp_device_id

2017-08-15 Thread Arvind Yadav
pnp_device_id are not supposed to change at runtime. All functions working with pnp_device_id provided by work with const pnp_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/3com/3c509.c | 2 +- 1 file changed,

Re: [PATCH net] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

2017-08-15 Thread Roopa Prabhu
On Tue, Aug 15, 2017 at 7:56 PM, David Ahern wrote: > On 8/15/17 8:50 PM, Roopa Prabhu wrote: >> diff --git a/net/ipv4/route.c b/net/ipv4/route.c >> index 7effa62..49a018f 100644 >> --- a/net/ipv4/route.c >> +++ b/net/ipv4/route.c >> @@ -2763,14 +2763,21 @@ static int

Re: [PATCH net-next 2/3 v4] net: arp: Add support for raw IP device

2017-08-15 Thread Marcel Holtmann
Hi Subash, > Define the raw IP type. This is needed for raw IP net devices > like rmnet. > > Signed-off-by: Subash Abhinov Kasiviswanathan > --- > include/uapi/linux/if_arp.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/if_arp.h

Re: Something hitting my total number of connections to the server

2017-08-15 Thread Akshat Kakkar
On Mon, Aug 14, 2017 at 2:37 PM, Akshat Kakkar wrote: > I have centos 7.3 (Kernel 3.10) running on a server with 128GB RAM and > 2 x 10 Core Xeon Processor. > I have hosted a webserver on it and enabled ssh for remote maintenance. > Previously it was running on Centos 6.3.

Re: [PATCH net-next 3/3 v4] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-15 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Tue, 15 Aug 2017 22:15:53 -0600 > +static int rmnet_unregister_real_device(struct net_device *dev) > +{ > + int config_id = RMNET_LOCAL_LOGICAL_ENDPOINT; > + struct rmnet_logical_ep_conf_s *epconfig_l; > + struct

[PATCH net-next 2/3 v4] net: arp: Add support for raw IP device

2017-08-15 Thread Subash Abhinov Kasiviswanathan
Define the raw IP type. This is needed for raw IP net devices like rmnet. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_arp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_arp.h b/include/uapi/linux/if_arp.h index

[PATCH net-next 1/3 v4] net: ether: Add support for multiplexing and aggregation type

2017-08-15 Thread Subash Abhinov Kasiviswanathan
Define the multiplexing and aggregation (MAP) ether type 0xDA1A. This is needed for receiving data in the MAP protocol like RMNET. This is not an officially registered ID. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_ether.h | 4 +++- 1 file

[PATCH net-next 3/3 v4] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-15 Thread Subash Abhinov Kasiviswanathan
RmNet driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded module. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a single

[PATCH net-next 0/3 v4] Add support for rmnet driver

2017-08-15 Thread Subash Abhinov Kasiviswanathan
-- v1: Same as the RFC patch with some minor fixes for issues reported by kbuild test robot. v1->v2: Change datatypes and remove config IOCTL as mentioned by David. Also fix checkpatch issues and remove some unused code. v2->v3: Move location to drivers/net and rename to rmnet. Change the

Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet

2017-08-15 Thread Jason Wang
On 2017年08月16日 11:59, Michael S. Tsirkin wrote: On Wed, Aug 16, 2017 at 11:57:51AM +0800, Jason Wang wrote: On 2017年08月16日 11:55, Michael S. Tsirkin wrote: On Tue, Aug 15, 2017 at 08:45:20PM -0700, Eric Dumazet wrote: On Fri, 2017-08-11 at 19:41 +0800, Jason Wang wrote: We use

Re: [PATCH net-next 0/4] liquidio: adding support for ethtool --set-channels feature

2017-08-15 Thread David Miller
From: Felix Manlunas Date: Tue, 15 Aug 2017 12:45:15 -0700 > From: Intiyaz Basha > > Code reorganization is required for adding ethtool --set-channels feature. > First three patches are for code reorganization. The last patch is for >

Re: [PATCH net repost] nfp: do not update MTU from BH in flower app

2017-08-15 Thread David Miller
From: David Miller Date: Tue, 15 Aug 2017 17:52:40 -0700 (PDT) > From: Simon Horman > Date: Tue, 15 Aug 2017 08:13:48 +0200 > >> Could you pull net into net-next? I'd like to send up a follow-up >> for net-next to allow processing of the MTU. >

Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet

2017-08-15 Thread Michael S. Tsirkin
On Wed, Aug 16, 2017 at 11:57:51AM +0800, Jason Wang wrote: > > > On 2017年08月16日 11:55, Michael S. Tsirkin wrote: > > On Tue, Aug 15, 2017 at 08:45:20PM -0700, Eric Dumazet wrote: > > > On Fri, 2017-08-11 at 19:41 +0800, Jason Wang wrote: > > > > We use tun_alloc_skb() which calls

Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet

2017-08-15 Thread Jason Wang
On 2017年08月16日 11:55, Michael S. Tsirkin wrote: On Tue, Aug 15, 2017 at 08:45:20PM -0700, Eric Dumazet wrote: On Fri, 2017-08-11 at 19:41 +0800, Jason Wang wrote: We use tun_alloc_skb() which calls sock_alloc_send_pskb() to allocate skb in the past. This socket based method is not suitable

Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet

2017-08-15 Thread Jason Wang
empty) Modules linked in: CPU: 0 PID: 3982 Comm: syz-executor0 Not tainted 4.13.0-rc5-next-20170815+ #3 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 task: 880069f265c0 task.stack: 880067688000 RIP: 0010:__read_once_size include/linux/compiler.h:276 [inline] RIP

Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet

2017-08-15 Thread Michael S. Tsirkin
; > Well well well. > > You do realize that tun_build_skb() is not thread safe ? The issue is alloc frag, isn't it? I guess for now we can limit this to XDP mode only, and just allocate full pages in that mode. > general protection fault: [#1] SMP KASAN > Dumping ftrace buf

Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-15 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 01:02:05PM +0800, Jason Wang wrote: > > > On 2017年08月15日 00:01, Michael S. Tsirkin wrote: > > On Sat, Aug 12, 2017 at 10:48:49AM +0800, Jason Wang wrote: > > > > > > On 2017年08月12日 07:12, Jakub Kicinski wrote: > > > > On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote:

Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet

2017-08-15 Thread Eric Dumazet
; What's more important, this makes it possible to implement XDP for tap > before creating skbs. Well well well. You do realize that tun_build_skb() is not thread safe ? general protection fault: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 0 PID:

RE: [patch net-next 0/3] net/sched: Improve getting objects by indexes

2017-08-15 Thread Chris Mi
Hi David, Thanks for your suggestion. If needed, I could send the review request again without so long CC: list. I surely will avoid such mistake in the future. Thanks, Chris > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, August 16, 2017

Re: [PATCH net V2] openvswitch: fix skb_panic due to the incorrect actions attrlen

2017-08-15 Thread Pravin Shelar
On Tue, Aug 15, 2017 at 6:44 PM, Liping Zhang wrote: > 2017-08-16 7:35 GMT+08:00 Pravin Shelar : > [...] >>> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c >>> index e4610676299b..f849ef52853f 100644 >>> --- a/net/openvswitch/actions.c >>>

Re: [patch net-next 0/3] net/sched: Improve getting objects by indexes

2017-08-15 Thread David Miller
The CC: list you used for these postings was way too large. Seriously, netdev by itself or with one or two _specific_ developers added would have been more than sufficient. If you are automating things using the MAINTAINERS file, always look over the result by hand and ask yourself "Do I really

Re: [GIT] Networking

2017-08-15 Thread David Miller
From: Linus Torvalds Date: Tue, 15 Aug 2017 19:21:16 -0700 > On Tue, Aug 15, 2017 at 5:52 PM, David Miller wrote: >> >> dingtianhong (4): >> PCI: Disable PCIe Relaxed Ordering if unsupported >> PCI: Disable Relaxed Ordering for

Re: [PATCH net] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

2017-08-15 Thread David Ahern
On 8/15/17 8:50 PM, Roopa Prabhu wrote: > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > index 7effa62..49a018f 100644 > --- a/net/ipv4/route.c > +++ b/net/ipv4/route.c > @@ -2763,14 +2763,21 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, > struct nlmsghdr *nlh, > if

[PATCH net] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

2017-08-15 Thread Roopa Prabhu
From: Roopa Prabhu Syzkaller hit 'general protection fault in fib_dump_info' bug on commit 4.13-rc5.. Guilty file: net/ipv4/fib_semantics.c kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN

Re: [PATCH] qdisc: add tracepoint qdisc:qdisc_dequeue for dequeued SKBs

2017-08-15 Thread David Ahern
On 8/15/17 1:11 PM, Jesper Dangaard Brouer wrote: > diff --git a/include/trace/events/qdisc.h b/include/trace/events/qdisc.h > new file mode 100644 > index ..60d0d8bd336d > --- /dev/null > +++ b/include/trace/events/qdisc.h > @@ -0,0 +1,50 @@ > +#undef TRACE_SYSTEM > +#define

Re: [GIT] Networking

2017-08-15 Thread Linus Torvalds
On Tue, Aug 15, 2017 at 5:52 PM, David Miller wrote: > > dingtianhong (4): > PCI: Disable PCIe Relaxed Ordering if unsupported > PCI: Disable Relaxed Ordering for some Intel processors > PCI: Disable Relaxed Ordering Attributes for AMD A1100 > PCI: fix

Re: https://www.spinics.net/lists/kernel/ non work

2017-08-15 Thread Rick
> Forbidden > > You don't have permission to access /lists/kernel/ on this server. > Apache/2.4.6 (CentOS) Server at www.spinics.net Port 443 I'm moving soon so I was working on DNS and replaced an IP address that I shouldn't have. Should be working now.

Re: [PATCH net V2] openvswitch: fix skb_panic due to the incorrect actions attrlen

2017-08-15 Thread Liping Zhang
2017-08-16 7:35 GMT+08:00 Pravin Shelar : [...] >> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c >> index e4610676299b..f849ef52853f 100644 >> --- a/net/openvswitch/actions.c >> +++ b/net/openvswitch/actions.c >> @@ -921,6 +921,7 @@ static int

[PATCH] net: igmp: Use ingress interface rather than vrf device

2017-08-15 Thread David Ahern
Anuradha reported that statically added groups for interfaces enslaved to a VRF device were not persisting. The problem is that igmp queries and reports need to use the data in the in_dev for the real ingress device rather than the VRF device. Update igmp_rcv accordingly. Fixes: e58e41596811

Re: [PATCH net repost] nfp: do not update MTU from BH in flower app

2017-08-15 Thread David Miller
From: Simon Horman Date: Tue, 15 Aug 2017 08:13:48 +0200 > Could you pull net into net-next? I'd like to send up a follow-up > for net-next to allow processing of the MTU. Once Linus takes the pull request I just sent to him, I will do this.

[GIT] Networking

2017-08-15 Thread David Miller
1) Fix TCP checksum offload handling in iwlwifi driver, from Emmanuel Grumbach. 2) In ksz DSA tagging code, free SKB if skb_put_padto() fails. From Vivien Didelot. 3) Fix two regressions with bonding on wireless, from Andreas Born. 4) Fix build when busypoll is disabled, from Daniel

Re: [patch] netlink.7: srcfix Change buffer size in example code about reading netlink message.

2017-08-15 Thread Michael Kerrisk (man-pages)
On 11/14/2016 11:36 PM, Rick Jones wrote: >> Lets change the example so others don't propagate the problem further. >> >> Signed-off-by David Wilder >> >> --- man7/netlink.7.orig 2016-11-14 13:30:36.522101156 -0800 >> +++ man7/netlink.7 2016-11-14 13:30:51.002086354 -0800

Re: [patch] netlink.7: srcfix Change buffer size in example code about reading netlink message.

2017-08-15 Thread Michael Kerrisk (man-pages)
On 11/14/2016 11:20 PM, dwilder wrote: > The example code in netlink(7) (for reading netlink message) suggests > using > a 4k read buffer with recvmsg. This can cause truncated messages on > systems > using a page size is >4096. Please see: > linux/include/linux/netlink.h (in the kernel

Re: [PATCH net] bpf: fix bpf_trace_printk on 32 bit archs

2017-08-15 Thread David Miller
From: Daniel Borkmann Date: Wed, 16 Aug 2017 01:45:33 +0200 > James reported that on MIPS32 bpf_trace_printk() is currently > broken while MIPS64 works fine: > > bpf_trace_printk() uses conditional operators to attempt to > pass different types to __trace_printk()

Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-15 Thread David Miller
From: Bjorn Helgaas Date: Tue, 15 Aug 2017 12:03:31 -0500 > On Tue, Aug 15, 2017 at 11:24:48PM +0800, Ding Tianhong wrote: >> Eric report a oops when booting the system after applying >> the commit a99b646afa8a ("PCI: Disable PCIe Relaxed..."): >> ... > >> It looks like the

Re: [PATCH ] dt-bindings: net: ravb : Add support for r8a7745 SoC

2017-08-15 Thread David Miller
From: Biju Das <biju@bp.renesas.com> Date: Tue, 15 Aug 2017 15:40:20 +0100 > Add a new compatible string for the RZ/G1E (R8A7745) SoC. > > Signed-off-by: Biju Das <biju@bp.renesas.com> > --- > This patch is tested against linux-next tag next-20170815 > as well as net-next. Applied.

Re: [PATCH net-next 0/4] inet: make RTM_GETROUTE work without rtnl

2017-08-15 Thread David Miller
From: Florian Westphal Date: Tue, 15 Aug 2017 16:34:40 +0200 > ipv4 getroute doesn't assume rtnl lock is held anymore, also make > this true for ipv6, then switch both to DOIT_UNLOCKED. Series applied, thanks Florian.

https://www.spinics.net/lists/kernel/ non work

2017-08-15 Thread Алексей Болдырев
Forbidden You don't have permission to access /lists/kernel/ on this server. Apache/2.4.6 (CentOS) Server at www.spinics.net Port 443

Re: [PATCH net] sfc: don't try and read ef10 data on non-ef10 NIC

2017-08-15 Thread David Miller
From: Bert Kenward Date: Tue, 15 Aug 2017 14:55:32 +0100 > The MAC stats command takes a port ID, which doesn't exist on > pre-ef10 NICs (5000- and 6000- series). This is extracted from the > NIC specific data; we misinterpret this as the ef10 data structure, > causing

Re: [PATCH net-next] dsa: fix flow disector null pointer

2017-08-15 Thread David Miller
From: Craig Gallek Date: Tue, 15 Aug 2017 09:43:40 -0400 > From: Craig Gallek > > A recent change to fix up DSA device behavior made the assumption that > all skbs passing through the flow disector will be associated with a > device. This does not

Re: [PATCH] net_sched: reset pointers to tcf blocks in classful qdiscs' destructors

2017-08-15 Thread David Miller
From: Konstantin Khlebnikov Date: Tue, 15 Aug 2017 16:35:21 +0300 > Traffic filters could keep direct pointers to classes in classful qdisc, > thus qdisc destruction first removes all filters before freeing classes. > Class destruction methods also tries to free

Re: [PATCH] net_sched: remove warning from qdisc_hash_add

2017-08-15 Thread David Miller
From: Konstantin Khlebnikov Date: Tue, 15 Aug 2017 16:39:05 +0300 > It was added in commit e57a784d8cae ("pkt_sched: set root qdisc > before change() in attach_default_qdiscs()") to hide duplicates > from "tc qdisc show" for incative deivices. > > After 59cc1f61f

Re: [PATCH] net_sched/sfq: update hierarchical backlog when drop packet

2017-08-15 Thread David Miller
From: Konstantin Khlebnikov Date: Tue, 15 Aug 2017 16:37:04 +0300 > When sfq_enqueue() drops head packet or packet from another queue it > have to update backlog at upper qdiscs too. > > Signed-off-by: Konstantin Khlebnikov > Fixes:

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-15 Thread Tom Herbert
On Tue, Aug 15, 2017 at 3:42 PM, Shaohua Li wrote: > On Tue, Aug 15, 2017 at 07:08:31AM -0700, Tom Herbert wrote: >> On Mon, Aug 14, 2017 at 7:52 PM, Shaohua Li wrote: >> > On Fri, Aug 11, 2017 at 06:00:20PM -0700, Tom Herbert wrote: >> >> On Thu, Aug 10, 2017

Re: [PATCH net] ipv4: fix NULL dereference in free_fib_info_rcu()

2017-08-15 Thread David Miller
From: Eric Dumazet Date: Tue, 15 Aug 2017 05:26:17 -0700 > From: Eric Dumazet > > If fi->fib_metrics could not be allocated in fib_create_info() > we attempt to dereference a NULL pointer in free_fib_info_rcu() : > > m = fi->fib_metrics; >

Re: [PATCH] net: Fix a typo in comment about sock flags.

2017-08-15 Thread David Miller
From: Tonghao Zhang Date: Tue, 15 Aug 2017 04:28:54 -0700 > Signed-off-by: Tonghao Zhang Applied.

Re: [PATCH net] ipv6: fix NULL dereference in ip6_route_dev_notify()

2017-08-15 Thread David Miller
From: Eric Dumazet Date: Tue, 15 Aug 2017 04:09:51 -0700 > From: Eric Dumazet > > Based on a syzkaller report [1], I found that a per cpu allocation > failure in snmp6_alloc_dev() would then lead to NULL dereference in > ip6_route_dev_notify(). > >

Re: [patch net-next] mlxsw: spectrum_router: Use correct config option

2017-08-15 Thread David Miller
From: Jiri Pirko Date: Tue, 15 Aug 2017 09:10:33 +0200 > From: Ido Schimmel > > I made an embarrassing mistake and used 'IPV6' instead of 'CONFIG_IPV6' > around the function that updates the kernel about IPv6 neighbours > activity. This can be a problem

Re: [patch net-next] ipv6: fib: Provide offload indication using nexthop flags

2017-08-15 Thread David Miller
From: Jiri Pirko Date: Tue, 15 Aug 2017 09:09:49 +0200 > From: Ido Schimmel > > IPv6 routes currently lack nexthop flags as in IPv4. This has several > implications. > > In the forwarding path, it requires us to check the carrier state of the > nexthop

Re: [PATCH v4 iproute2 1/7] rdma: Add basic infrastructure for RDMA tool

2017-08-15 Thread Stephen Hemminger
On Tue, 15 Aug 2017 16:00:14 +0300 Leon Romanovsky wrote: > RDMA devices are cross-functional devices from one side, > but very tailored for the specific markets from another. > > Such diversity caused to spread of RDMA related configuration > across various tools, e.g.

linux-next: manual merge of the pci tree with the net tree

2017-08-15 Thread Stephen Rothwell
Hi Bjorn, Today's linux-next merge of the pci tree got a conflict in: drivers/pci/probe.c between commit: a99b646afa8a ("PCI: Disable PCIe Relaxed Ordering if unsupported") from the net tree and commit: 62ce94a7a5a5 ("PCI: Mark Broadcom HT2100 Root Port Extended Tags as broken") from

Re: [PATCH 2/2] mlx5: remove unnecessary pci_set_drvdata()

2017-08-15 Thread David Miller
From: Zhu Yanjun Date: Tue, 15 Aug 2017 02:33:06 -0400 > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not necessary to manually clear the > device driver data to NULL. > > Cc: Joe Jin > Cc:

Re: [PATCH 1/2] mlx4: remove unnecessary pci_set_drvdata()

2017-08-15 Thread David Miller
From: Zhu Yanjun Date: Tue, 15 Aug 2017 02:33:05 -0400 > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not necessary to manually clear the > device driver data to NULL. > > Cc: Joe Jin > Cc:

Re: [PATCH iproute2 net-next v2 0/3] Add support for SRv6 local segment processing

2017-08-15 Thread Stephen Hemminger
On Wed, 9 Aug 2017 17:33:23 +0200 David Lebrun wrote: > This patch series adds support and documentation for the seg6local > lightweight tunnel, enabling to perform operations to SR-enabled packets > based on their active segment. > > v2: use a table for action names

[PATCH net] bpf: fix bpf_trace_printk on 32 bit archs

2017-08-15 Thread Daniel Borkmann
James reported that on MIPS32 bpf_trace_printk() is currently broken while MIPS64 works fine: bpf_trace_printk() uses conditional operators to attempt to pass different types to __trace_printk() depending on the format operators. This doesn't work as intended on 32-bit architectures where

Re: [PATCH net V2] openvswitch: fix skb_panic due to the incorrect actions attrlen

2017-08-15 Thread Pravin Shelar
On Tue, Aug 15, 2017 at 4:29 AM, Liping Zhang wrote: > From: Liping Zhang > > For sw_flow_actions, the actions_len only represents the kernel part's > size, and when we dump the actions to the userspace, we will do the > convertions, so it's true size may

Re: [PATCH v3 net-next] bpf/verifier: track liveness for pruning

2017-08-15 Thread David Miller
From: Daniel Borkmann Date: Wed, 16 Aug 2017 00:12:58 +0200 > On 08/15/2017 09:34 PM, Edward Cree wrote: >> State of a register doesn't matter if it wasn't read in reaching an >> exit; >> a write screens off all reads downstream of it from all >> explored_states >>

[PATCH net-next] liquidio: update VF's netdev->max_mtu if there's a change in PF's MTU

2017-08-15 Thread Felix Manlunas
From: Veerasenareddy Burru A VF's MTU is capped at the parent PF's MTU. So if there's a change in the PF's MTU, then update the VF's netdev->max_mtu. Also remove duplicate log messages for MTU change. Signed-off-by: Veerasenareddy Burru

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-15 Thread Shaohua Li
On Tue, Aug 15, 2017 at 07:08:31AM -0700, Tom Herbert wrote: > On Mon, Aug 14, 2017 at 7:52 PM, Shaohua Li wrote: > > On Fri, Aug 11, 2017 at 06:00:20PM -0700, Tom Herbert wrote: > >> On Thu, Aug 10, 2017 at 12:13 PM, Shaohua Li wrote: > >> > On Thu, Aug 10,

[PATCH net] xfrm: Clear sk_dst_cache when applying per-socket policy.

2017-08-15 Thread Jonathan Basseri
If an IPv6 socket has a valid dst cache, then xfrm_lookup_route will get skipped. However, the cache is not invalidated when applying policy to a socket (i.e. IPV6_XFRM_POLICY). The result is that new policies are sometimes ignored on those sockets. This can be demonstrated like so, 1. Create

[PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-15 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It uses VMBus ringbuffer as the transportation layer. With hv_sock, applications between the host (Windows 10, Windows Server 2016 or newer) and the guest can talk with each other using

[PATCH net-next 2/3] vsock: fix vsock_dequeue/enqueue_accept race

2017-08-15 Thread Dexuan Cui
With the current code, when vsock_dequeue_accept() is removing a sock from the list, nothing prevents vsock_enqueue_accept() from adding a new sock into the list concurrently. We should add a lock to protect the list. Signed-off-by: Dexuan Cui Cc: Andy King

[PATCH net-next 1/3] VMCI: only load on VMware hypervisor

2017-08-15 Thread Dexuan Cui
Without the patch, vmw_vsock_vmci_transport.ko and vmw_vmci.ko can automatically load when an application creates an AF_VSOCK socket. This is the expected good behavior on VMware hypervisor, but as we are going to add hv_sock.ko (i.e. Hyper-V transport for AF_VSOCK), we should make sure

Re: [PATCH v3 net-next] bpf/verifier: track liveness for pruning

2017-08-15 Thread Daniel Borkmann
On 08/15/2017 09:34 PM, Edward Cree wrote: State of a register doesn't matter if it wasn't read in reaching an exit; a write screens off all reads downstream of it from all explored_states upstream of it. This allows us to prune many more branches; here are some processed insn counts for

Re: 100% CPU load when generating traffic to destination network that nexthop is not reachable

2017-08-15 Thread Julian Anastasov
Hello, On Wed, 16 Aug 2017, Julian Anastasov wrote: > I thought about this, it is possible in > neigh_event_send: > > if (neigh->used != now) > neigh->used = now; > else if (neigh->nud_state == NUD_INCOMPLETE && >

[PATCH net-next 0/3] add Hyper-V transport for Virtual Sockets

2017-08-15 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It uses VMBus ringbuffer as the transportation layer. PATCH 01 and 02 are for VMCI and the common infrastructure vsock. PATCH 03 implements the necessary support in Linux guest by

Re: 100% CPU load when generating traffic to destination network that nexthop is not reachable

2017-08-15 Thread Paweł Staszewski
Also after adding this patch: [ 3843.036247] NEIGH: BUG, double timer add, state is 1 [ 3843.036253] CPU: 24 PID: 0 Comm: swapper/24 Not tainted 4.13.0-rc5-next-20170815 #2 [ 3843.036254] Call Trace: [ 3843.036255] [ 3843.036263] dump_stack+0x4d/0x63 [ 3843.036267] neigh_add_timer+0x36

Re: 100% CPU load when generating traffic to destination network that nexthop is not reachable

2017-08-15 Thread Julian Anastasov
Hello, On Tue, 15 Aug 2017, Eric Dumazet wrote: > On Tue, 2017-08-15 at 22:45 +0300, Julian Anastasov wrote: > > Hello, > > > > On Tue, 15 Aug 2017, Eric Dumazet wrote: > > > > > Please try this : > > > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > > > index > > >

Re: 100% CPU load when generating traffic to destination network that nexthop is not reachable

2017-08-15 Thread Eric Dumazet
On Tue, 2017-08-15 at 22:45 +0300, Julian Anastasov wrote: > Hello, > > On Tue, 15 Aug 2017, Eric Dumazet wrote: > > > Please try this : > > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > > index > >

Re: 100% CPU load when generating traffic to destination network that nexthop is not reachable

2017-08-15 Thread Paweł Staszewski
Hi Patch applied but no change still 100% CPU perf below: 1.99% 0.00% ksoftirqd/1 [kernel.vmlinux] [k] run_ksoftirqd | ---run_ksoftirqd | --1.99%--__softirqentry_text_start |

Re: 100% CPU load when generating traffic to destination network that nexthop is not reachable

2017-08-15 Thread Julian Anastasov
Hello, On Tue, 15 Aug 2017, Eric Dumazet wrote: > Please try this : > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > index > 16a1a4c4eb57fa1147f230916e2e62e18ef89562..95e0d7702029b583de8229e3c3eb923f6395b072 > 100644 > --- a/net/core/neighbour.c > +++

Re: [PATCH net-next 0/4] various sizeof cleanups

2017-08-15 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 10:29:15AM -0700, Stephen Hemminger wrote: > Noticed some places that were using sizeof as an operator. > This is legal C but is not the convention used in the kernel. > > Stephen Hemminger (4): > tun/tap: use paren's with sizeof > virtio: put paren around sizeof >

[PATCH net-next 3/4] liquidio: moved octeon_setup_interrupt to lio_core.c

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha Moving common octeon_setup_interrupt to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas ---

[PATCH net-next 4/4] liquidio: added support for ethtool --set-channels feature

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha adding support for ethtool --set-channels feature Signed-off-by: Intiyaz Basha Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas ---

[PATCH net-next 2/4] liquidio: moved liquidio_legacy_intr_handler to lio_core.c

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha Moving liquidio_legacy_intr_handler to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas ---

[PATCH net-next 1/4] liquidio: moved liquidio_msix_intr_handler to lio_core.c

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha Moving common liquidio_msix_intr_handler to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas ---

[PATCH net-next 0/4] liquidio: adding support for ethtool --set-channels feature

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha Code reorganization is required for adding ethtool --set-channels feature. First three patches are for code reorganization. The last patch is for adding this feature. Intiyaz Basha (4): liquidio: moved liquidio_msix_intr_handler to lio_core.c

Re: [net-next 11/12] igbvf: convert msleep to mdelay in atomic context

2017-08-15 Thread Greg Edwards
On Mon, Aug 14, 2017 at 10:17:31AM +, David Laight wrote: > From: Jeff Kirsher >> Sent: 09 August 2017 22:48 >> From: Greg Edwards >> >> This fixes a "scheduling while atomic" splat seen with >> CONFIG_DEBUG_ATOMIC_SLEEP enabled. >> >> Signed-off-by: Greg Edwards

[PATCH v3 net-next] bpf/verifier: track liveness for pruning

2017-08-15 Thread Edward Cree
State of a register doesn't matter if it wasn't read in reaching an exit; a write screens off all reads downstream of it from all explored_states upstream of it. This allows us to prune many more branches; here are some processed insn counts for some Cilium programs: Program

[PATCH] qdisc: add tracepoint qdisc:qdisc_dequeue for dequeued SKBs

2017-08-15 Thread Jesper Dangaard Brouer
The main purpose of this tracepoint is to monitor bulk dequeue in the network qdisc layer, as it cannot be deducted from the existing qdisc stats. The txq_state can be used for determining the reason for zero packet dequeues, see enum netdev_queue_state_t. Notice all packets doesn't necessary

Re: 100% CPU load when generating traffic to destination network that nexthop is not reachable

2017-08-15 Thread Eric Dumazet
On Tue, 2017-08-15 at 19:42 +0200, Paweł Staszewski wrote: > # To display the perf.data header info, please use > --header/--header-only options. > # > # > # Total Lost Samples: 0 > # > # Samples: 2M of event 'cycles' > # Event count (approx.): 1585571545969 > # > # Children Self Command

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

2017-08-15 Thread Paolo Abeni
On Tue, 2017-08-15 at 12:45 -0400, Willem de Bruijn wrote: > On Tue, Aug 15, 2017 at 11:40 AM, Paolo Abeni wrote: > > For the record, I thought something like the following (uncomplete, > > does not even compile): > > --- > > diff --git a/include/linux/socket.h

Re: [PATCH net-next 4/4] mlx4: sizeof style usage

2017-08-15 Thread Leon Romanovsky
On Tue, Aug 15, 2017 at 10:29:19AM -0700, Stephen Hemminger wrote: > The kernel coding style is to treat sizeof as a function > (ie. with parenthesis) not as an operator. > > Also use kcalloc and kmalloc_array > > Signed-off-by: Stephen Hemminger > --- >

Re: [PATCH v2 net-next] bpf/verifier: track liveness for pruning

2017-08-15 Thread Edward Cree
On 15/08/17 17:33, Daniel Borkmann wrote: > On 08/15/2017 03:53 PM, Edward Cree wrote: >> State of a register doesn't matter if it wasn't read in reaching an exit; >> a write screens off all reads downstream of it from all explored_states >> upstream of it. >> This allows us to prune many more

Re: [PATCH 1/2] mlx4: remove unnecessary pci_set_drvdata()

2017-08-15 Thread Leon Romanovsky
On Tue, Aug 15, 2017 at 11:21:49AM -0600, Jason Gunthorpe wrote: > On Tue, Aug 15, 2017 at 10:13:36AM +0300, Leon Romanovsky wrote: > > On Tue, Aug 15, 2017 at 02:33:05AM -0400, Zhu Yanjun wrote: > > > The driver core clears the driver data to NULL after device_release > > > or on probe failure.

Re: [PATCH net-next 00/12] s390/net: updates for 4.14

2017-08-15 Thread David Miller
From: Julian Wiedmann Date: Tue, 15 Aug 2017 17:02:38 +0200 > a mixed bag of minor fixes, cleanups and refactors for net-next. Please apply. Series applied, thanks.

  1   2   3   >