Re: [PATCH net-next] net: bcmgenet: Do not return from void function

2017-08-29 Thread David Miller
From: Florian Fainelli Date: Tue, 29 Aug 2017 21:48:51 -0700 > A stray return was added in the macro bcmgenet_##name##_writel where it > should not, drop it. > > Reported-by: kbuild test robot > Fixes: 69d2ea9c7989 ("net: bcmgenet: Use correct I/O

Re: [PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-29 Thread David Miller
From: Samuel Mendoza-Jonas Date: Wed, 30 Aug 2017 14:37:21 +1000 > On Mon, 2017-08-28 at 16:50 -0700, David Miller wrote: >> From: Samuel Mendoza-Jonas >> Date: Mon, 28 Aug 2017 16:18:40 +1000 >> >> > This series (mainly patch 2) adds VLAN

Re: Fwd: DA850-evm MAC Address is random

2017-08-29 Thread Sekhar Nori
On Wednesday 30 August 2017 06:19 AM, Adam Ford wrote: > On Tue, Aug 29, 2017 at 10:20 AM, Adam Ford wrote: >> On Tue, Aug 29, 2017 at 10:16 AM, Sekhar Nori wrote: >>> On Tuesday 29 August 2017 05:32 PM, Adam Ford wrote: On Tue, Aug 29, 2017 at 6:42 AM,

Re: [PATCH net-next 0/4] nsh: headers, GSO

2017-08-29 Thread Yang, Yi
On Wed, Aug 30, 2017 at 06:17:07AM +0800, David Miller wrote: > From: Jiri Benc > Date: Mon, 28 Aug 2017 21:43:20 +0200 > > > This adds header structs and helpers for NSH together with GSO support. > > > > Note there is no code in this patchset that actually manipulates the

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi, On Tuesday 29 August 2017 06:42 PM, Antoine Tenart wrote: > Hi Kishon, > > On Tue, Aug 29, 2017 at 05:55:06PM +0530, Kishon Vijay Abraham I wrote: >> On Tuesday 29 August 2017 04:53 PM, Antoine Tenart wrote: >>> On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: On

[net-next:master 427/429] arch/sh/include/asm/io.h:30:43: warning: 'return' with a value, in function returning void

2017-08-29 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: eaa72dc47488d599439cd0fd0f8c4f1bcb3906bb commit: 69d2ea9c798983c4a7157278ec84ff969d1cd8e8 [427/429] net: bcmgenet: Use correct I/O accessors config: sh-allmodconfig (attached as .config) compiler:

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi Antoine, On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > On the CP110 unit, which can be found on various Marvell platforms such > as the 7k and 8k (currently), a comphy (common PHYs) hardware block can > be found. This block provides a number of PHYs which can be used in > various

[PATCH net-next] net: bcmgenet: Do not return from void function

2017-08-29 Thread Florian Fainelli
A stray return was added in the macro bcmgenet_##name##_writel where it should not, drop it. Reported-by: kbuild test robot Fixes: 69d2ea9c7989 ("net: bcmgenet: Use correct I/O accessors") Signed-off-by: Florian Fainelli ---

[PATCH net-next 3/3 v11] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-29 Thread Subash Abhinov Kasiviswanathan
RmNet driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded module. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a single

[PATCH net-next 2/3 v11] net: arp: Add support for raw IP device

2017-08-29 Thread Subash Abhinov Kasiviswanathan
Define the raw IP type. This is needed for raw IP net devices like rmnet. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_arp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_arp.h b/include/uapi/linux/if_arp.h index

[PATCH net-next 0/3 v11] Add support for rmnet driver

2017-08-29 Thread Subash Abhinov Kasiviswanathan
This patch series adds support for the rmnet driver which is required to support recent chipsets using Qualcomm Technologies, Inc. modems. The data from hardware follows the multiplexing and aggregation protocol (MAP). This driver can be used to register onto any physical network device in IP

[PATCH net-next 1/3 v11] net: ether: Add support for multiplexing and aggregation type

2017-08-29 Thread Subash Abhinov Kasiviswanathan
Define the Qualcomm multiplexing and aggregation (MAP) ether type 0x00F9. This is needed for receiving data in the MAP protocol like RMNET. This is not an officially registered ID. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_ether.h | 3 +++

Re: [PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-29 Thread Samuel Mendoza-Jonas
On Mon, 2017-08-28 at 16:50 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Mon, 28 Aug 2017 16:18:40 +1000 > > > This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. > > A fair amount of code already exists in the NCSI stack for

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-29 Thread Alexei Starovoitov
On Tue, Aug 29, 2017 at 09:38:16PM -0600, David Ahern wrote: > On 8/29/17 8:58 PM, Alexei Starovoitov wrote: > > On Tue, Aug 29, 2017 at 07:03:43PM -0600, David Ahern wrote: > >> On 8/28/17 10:11 PM, Alexei Starovoitov wrote: > >>> > >>> Agree on the above, but you're mixing semantics of the new

Re: multi-queue over IFF_NO_QUEUE "virtual" devices

2017-08-29 Thread Florian Fainelli
Le 08/07/17 à 15:26, Florian Fainelli a écrit : > Hi, > > Most DSA supported Broadcom switches have multiple queues per ports > (usually 8) and each of these queues can be configured with different > pause, drop, hysteresis thresholds and so on in order to make use of the > switch's internal

[net-next:master 427/429] drivers/net/ethernet/broadcom/genet/bcmgenet.h:687:10: note: in expansion of macro '__raw_writel'

2017-08-29 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: eaa72dc47488d599439cd0fd0f8c4f1bcb3906bb commit: 69d2ea9c798983c4a7157278ec84ff969d1cd8e8 [427/429] net: bcmgenet: Use correct I/O accessors config: blackfin-allyesconfig (attached as .config) compiler:

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-29 Thread David Ahern
On 8/29/17 8:58 PM, Alexei Starovoitov wrote: > On Tue, Aug 29, 2017 at 07:03:43PM -0600, David Ahern wrote: >> On 8/28/17 10:11 PM, Alexei Starovoitov wrote: >>> >>> Agree on the above, but you're mixing semantics of the new recurse >>> flag and implementation of it. Ex: we don't have to copy

Re: [PATCH net-next] ipv6: Use rt6i_idev index for echo replies to a local address

2017-08-29 Thread Eric Dumazet
On Mon, 2017-08-28 at 13:53 -0700, David Ahern wrote: > Tariq repored local pings to linklocal address is failing: > $ ifconfig ens8 > ens8: flags=4163 mtu 1500 > inet 11.141.16.6 netmask 255.255.0.0 broadcast 11.141.255.255 > inet6

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Willem de Bruijn
On Tue, Aug 29, 2017 at 9:45 PM, Jason Wang wrote: > > > On 2017年08月30日 03:35, Willem de Bruijn wrote: >> >> On Fri, Aug 25, 2017 at 9:03 PM, Willem de Bruijn >> wrote: >>> >>> On Fri, Aug 25, 2017 at 7:32 PM, Michael S. Tsirkin

Re: [PATCH v2 net-next 2/6] udp: Constify skb argument in lookup functions

2017-08-29 Thread Tom Herbert
On Tue, Aug 29, 2017 at 5:58 PM, David Miller wrote: > From: Tom Herbert > Date: Tue, 29 Aug 2017 16:27:07 -0700 > >> For UDP socket lookup functions, and associateed functions that take an >> skbuf as argument, declare the skb argument as constant. >>

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-29 Thread Alexei Starovoitov
On Tue, Aug 29, 2017 at 07:03:43PM -0600, David Ahern wrote: > On 8/28/17 10:11 PM, Alexei Starovoitov wrote: > > > > Agree on the above, but you're mixing semantics of the new recurse > > flag and implementation of it. Ex: we don't have to copy this flag > > from prog->attr into cgroup. So this

RE: Question about ip_defrag

2017-08-29 Thread liujian (CE)
Best Regards, liujian > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Florian Westphal > Sent: Tuesday, August 29, 2017 9:47 PM > To: liujian (CE) > Cc: Florian Westphal; Jesper Dangaard Brouer; netdev@vger.kernel.org; >

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Jason Wang
On 2017年08月30日 03:35, Willem de Bruijn wrote: On Fri, Aug 25, 2017 at 9:03 PM, Willem de Bruijn wrote: On Fri, Aug 25, 2017 at 7:32 PM, Michael S. Tsirkin wrote: On Fri, Aug 25, 2017 at 06:44:36PM -0400, Willem de Bruijn wrote: We don't

Re: [PATCH net] sch_hhf: fix null pointer dereference on init failure

2017-08-29 Thread Cong Wang
On Tue, Aug 29, 2017 at 12:02 PM, Nikolay Aleksandrov wrote: > First I did it with the check in the for () conditional, but this is more > visible and explicit. Let me know if you'd like the shorter version. :-) Or, if you want to make the patch size smaller, just

Re: [PATCH net-next 0/3 v10] Add support for rmnet driver

2017-08-29 Thread Subash Abhinov Kasiviswanathan
On 2017-08-29 19:12, David Miller wrote: Sigh, I had to revert. You only allow RMNET to take on the values 'y' and 'n'. You must allow for it to be 'm' and modular as well. Hi David I'll fix this now. Sorry about the cover letter. I'll explain it better in subsequent submission. --

Re: [PATCH net-next 0/3 v10] Add support for rmnet driver

2017-08-29 Thread David Miller
Sigh, I had to revert. You only allow RMNET to take on the values 'y' and 'n'. You must allow for it to be 'm' and modular as well.

Re: [PATCH net-next 0/3 v10] Add support for rmnet driver

2017-08-29 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Tue, 29 Aug 2017 18:47:55 -0600 > I have updated the locking scheme as follows - Series applied, but this is not how you write a header posting for a patch set. This posting is where you say at a high level what the patch

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-29 Thread David Ahern
On 8/28/17 10:11 PM, Alexei Starovoitov wrote: > > Agree on the above, but you're mixing semantics of the new recurse > flag and implementation of it. Ex: we don't have to copy this flag > from prog->attr into cgroup. So this reset or non-reset discussion > only makes sense in the context of your

Re: [PATCH v2 net-next 3/6] flow_dissector: Add protocol specific flow dissection offload

2017-08-29 Thread David Miller
From: Tom Herbert Date: Tue, 29 Aug 2017 16:27:08 -0700 > +#define GOTO_BY_RESULT(ret) do { \ > + switch (ret) { \ > + case FLOW_DISSECT_RET_OUT_GOOD: \ > + goto

Re: [PATCH v2 net-next 2/6] udp: Constify skb argument in lookup functions

2017-08-29 Thread David Miller
From: Tom Herbert Date: Tue, 29 Aug 2017 16:27:07 -0700 > For UDP socket lookup functions, and associateed functions that take an > skbuf as argument, declare the skb argument as constant. > > One caveat is that reuseport_select_sock can be called from the UDP > lookup

[PATCH net-next 3/3 v10] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-29 Thread Subash Abhinov Kasiviswanathan
RmNet driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded module. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a single

[PATCH net-next 0/3 v10] Add support for rmnet driver

2017-08-29 Thread Subash Abhinov Kasiviswanathan
Hi David I have updated the locking scheme as follows - The shared resource which needs to be protected is realdev->rx_handler_data. For the writer path, this is using rtnl_lock(). The writer paths are rmnet_newlink(), rmnet_dellink() and rmnet_force_unassociate_device(). These paths are

[PATCH net-next 1/3 v10] net: ether: Add support for multiplexing and aggregation type

2017-08-29 Thread Subash Abhinov Kasiviswanathan
Define the Qualcomm multiplexing and aggregation (MAP) ether type 0x00F9. This is needed for receiving data in the MAP protocol like RMNET. This is not an officially registered ID. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_ether.h | 3 +++

[PATCH net-next 2/3 v10] net: arp: Add support for raw IP device

2017-08-29 Thread Subash Abhinov Kasiviswanathan
Define the raw IP type. This is needed for raw IP net devices like rmnet. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_arp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_arp.h b/include/uapi/linux/if_arp.h index

Re: Fwd: DA850-evm MAC Address is random

2017-08-29 Thread Adam Ford
>>>> >>>> Nope, just applying the patch and booting the with the new dtb should >>>> result in the random mac address going away. >>> >>> Unfortunately, I am not seeing any change with the patch (at least >>> with Kernel 4.12.9 from stable)

Re: [RESEND PATCH] Allow passing tid or pid in SCM_CREDENTIALS without CAP_SYS_ADMIN

2017-08-29 Thread Eric W. Biederman
"prakash.sangappa" writes: > On 08/29/2017 04:02 PM, David Miller wrote: >> From: Prakash Sangappa >> Date: Mon, 28 Aug 2017 17:12:20 -0700 >> >>> Currently passing tid(gettid(2)) of a thread in struct ucred in >>> SCM_CREDENTIALS

Re: [RESEND PATCH] Allow passing tid or pid in SCM_CREDENTIALS without CAP_SYS_ADMIN

2017-08-29 Thread prakash.sangappa
On 08/29/2017 04:02 PM, David Miller wrote: From: Prakash Sangappa Date: Mon, 28 Aug 2017 17:12:20 -0700 Currently passing tid(gettid(2)) of a thread in struct ucred in SCM_CREDENTIALS message requires CAP_SYS_ADMIN capability otherwise it fails with EPERM

[PATCH v2 net-next 2/6] udp: Constify skb argument in lookup functions

2017-08-29 Thread Tom Herbert
For UDP socket lookup functions, and associateed functions that take an skbuf as argument, declare the skb argument as constant. One caveat is that reuseport_select_sock can be called from the UDP lookup functions with an skb argument. This function temporarily modifies the skbuff data pointer

[PATCH v2 net-next 4/6] udp: flow dissector offload

2017-08-29 Thread Tom Herbert
Add support to perform UDP specific flow dissection. This is primarily intended for dissecting encapsulated packets in UDP encapsulation. This patch adds a flow_dissect offload for UDP4 and UDP6. The backend function performs a socket lookup and calls the flow_dissect function if a socket is

[PATCH v2 net-next 6/6] vxlan: support flow dissect

2017-08-29 Thread Tom Herbert
Populate offload flow_dissect callback appropriately for VXLAN and VXLAN-GPE. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c

[PATCH v2 net-next 5/6] fou: Support flow dissection

2017-08-29 Thread Tom Herbert
Populate offload flow_dissect callabck appropriately for fou and gue. Signed-off-by: Tom Herbert --- net/ipv4/fou.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index

[PATCH v2 net-next 3/6] flow_dissector: Add protocol specific flow dissection offload

2017-08-29 Thread Tom Herbert
Add offload capability for performing protocol specific flow dissection (either by EtherType or IP protocol). Specifically: - Add flow_dissect to offload callbacks - Move flow_dissect_ret enum to flow_dissector.h, cleanup names and add a couple of values - Create GOTO_BY_RESULT macro to use in

[PATCH v2 net-next 1/6] flow_dissector: Move ETH_P_TEB processing to main switch

2017-08-29 Thread Tom Herbert
Support for processing TEB is currently in GRE flow dissection as a special case. This can be moved to be a case the main proto switch in __skb_flow_dissect. Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 44 +++- 1 file

[PATCH v2 net-next 0/6] flow_dissector: Protocol specific flow dissector offload

2017-08-29 Thread Tom Herbert
This patch set adds a new offload type to perform flow dissection for specific protocols (either by EtherType or by IP protocol). This is primary useful to crack open UDP encapsulations (like VXLAN, GUE) for the purposes of parsing the encapsulated packet. Items in this patch set: - Constify skb

Re: [PATCH net-next] neigh: increase queue_len_bytes to match wmem_default

2017-08-29 Thread Eric Dumazet
On Tue, 2017-08-29 at 15:16 -0700, Eric Dumazet wrote: > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c > index > 568ccfd6dd371d88136ffabe5cfcc36f099786b6..7616cd76f6f6a62f395da897baef2c66c0098193 > 100644 > --- a/net/ipv4/tcp_input.c > +++ b/net/ipv4/tcp_input.c > @@ -6086,9 +6086,9 @@

Re: [PATCH net-next] neigh: increase queue_len_bytes to match wmem_default

2017-08-29 Thread David Miller
From: Eric Dumazet Date: Tue, 29 Aug 2017 16:15:28 -0700 > On Tue, 2017-08-29 at 15:16 -0700, Eric Dumazet wrote: >> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c >> index >> 568ccfd6dd371d88136ffabe5cfcc36f099786b6..7616cd76f6f6a62f395da897baef2c66c0098193 >>

Re: [PATCH] drivers: net: xgene: Correct probe sequence handling

2017-08-29 Thread David Miller
From: Iyappan Subramanian Date: Tue, 29 Aug 2017 15:43:12 -0700 > From: Quan Nguyen > > The phy is connected at early stage of probe but not properly > disconnected if error occurs. This patch fixes the issue. > > Also changing the return type of

Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread Nikolay Aleksandrov
On 30.08.2017 02:06, David Miller wrote: > > I expect that you will resubmit all of these similar fixes as a patch > series after you have sorted everything out. > > Correct? > Yes, I will. There are a few more places that need fixing, I'll resubmit them all as a set.

Re: [PATCH net-next] neigh: increase queue_len_bytes to match wmem_default

2017-08-29 Thread David Miller
From: Eric Dumazet Date: Tue, 29 Aug 2017 15:16:01 -0700 > From: Eric Dumazet > > Florian reported UDP xmit drops that could be root caused to the > too small neigh limit. > > Current limit is 64 KB, meaning that even a single UDP socket would hit

Re: [PATCH net-next v2] net: bcmgenet: Use correct I/O accessors

2017-08-29 Thread David Miller
From: Florian Fainelli Date: Tue, 29 Aug 2017 12:25:31 -0700 > The GENET driver currently uses __raw_{read,write}l which means > native I/O endian. This works correctly for an ARM LE kernel (default) > but fails miserably on an ARM BE (BE8) kernel where registers are kept >

Re: [PATCH] net: remove dmaengine.h inclusion from netdevice.h

2017-08-29 Thread David Miller
From: Dave Jiang Date: Tue, 29 Aug 2017 13:17:51 -0700 > Since the removal of NET_DMA, dmaengine.h header file shouldn't be needed > by netdevice.h anymore. > > Signed-off-by: Dave Jiang Applied to net-next, but it would have been really great for

Re: [PATCH V2 net-next] liquidio: show NIC's U-Boot version in a dev_info() message

2017-08-29 Thread David Miller
From: Felix Manlunas Date: Tue, 29 Aug 2017 12:19:57 -0700 > From: Weilin Chang > > Signed-off-by: Weilin Chang > Signed-off-by: Felix Manlunas > --- > Patch Change Log: > V1 -> V2: >

Re: [PATCH net] nfp: double free on error in probe

2017-08-29 Thread David Miller
From: Dan Carpenter Date: Tue, 29 Aug 2017 22:15:16 +0300 > Both the nfp_net_pf_app_start() and the nfp_net_pci_probe() functions > call nfp_net_pf_app_stop_ctrl(pf) so there is a double free. The free > should be done from the probe function because it's allocated

Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread David Miller
I expect that you will resubmit all of these similar fixes as a patch series after you have sorted everything out. Correct?

Re: [PATCH] net: dsa: make some structures const

2017-08-29 Thread David Miller
From: Bhumika Goyal Date: Tue, 29 Aug 2017 22:17:52 +0530 > Make these const as they are not modified anywhere. > > Signed-off-by: Bhumika Goyal Applied.

Re: [PATCH ] net: frag: print frag_mem_limit value in sockstat proc file

2017-08-29 Thread David Miller
From: Date: Tue, 29 Aug 2017 21:05:34 +0800 > From: liujian > > From 6d7b857d5( net: use lib/percpu_counter API for fragmentation mem > accounting), > frag_mem_limit and sum_frag_mem_limit have different value if there are > multiple NIC RX CPU. >

Re: [RESEND PATCH] Allow passing tid or pid in SCM_CREDENTIALS without CAP_SYS_ADMIN

2017-08-29 Thread David Miller
From: Prakash Sangappa Date: Mon, 28 Aug 2017 17:12:20 -0700 > Currently passing tid(gettid(2)) of a thread in struct ucred in > SCM_CREDENTIALS message requires CAP_SYS_ADMIN capability otherwise > it fails with EPERM error. Some applications deal with thread id >

Re: [PATCH net-next v3 2/2] tcp_diag: report TCP MD5 signing keys and addresses

2017-08-29 Thread Eric Dumazet
On Tue, 2017-08-29 at 15:29 -0700, Ivan Delalande wrote: > Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to > processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is > not possible to retrieve these from the kernel once they have been > configured on

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Willem de Bruijn
On Tue, Aug 29, 2017 at 4:40 PM, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2017 at 03:53:08PM -0400, Willem de Bruijn wrote: >> On Tue, Aug 29, 2017 at 3:42 PM, Michael S. Tsirkin wrote: >> > On Tue, Aug 29, 2017 at 03:35:38PM -0400, Willem de Bruijn wrote: >>

[PATCH] drivers: net: xgene: Correct probe sequence handling

2017-08-29 Thread Iyappan Subramanian
From: Quan Nguyen The phy is connected at early stage of probe but not properly disconnected if error occurs. This patch fixes the issue. Also changing the return type of xgene_enet_check_phy_handle(), since this function always returns success. Signed-off-by: Quan Nguyen

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Willem de Bruijn
On Tue, Aug 29, 2017 at 5:13 PM, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2017 at 05:02:29PM -0400, Willem de Bruijn wrote: >> + virtio-dev >> >> On Tue, Aug 29, 2017 at 4:38 PM, Michael S. Tsirkin wrote: >> > On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem

Re: [PATCH net-next v3 1/2] inet_diag: allow protocols to provide additional data

2017-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2017 15:29:53 -0700 Ivan Delalande wrote: > @@ -452,13 +466,14 @@ int inet_diag_dump_one_icsk(struct inet_hashinfo > *hashinfo, > struct net *net = sock_net(in_skb->sk); > struct sk_buff *rep; > struct sock *sk; > + bool net_admin =

Re: [PATCH net-next 0/6] flow_dissector: Protocol specific flow dissector offload

2017-08-29 Thread David Miller
Please add proper signoffs to your patches. Thanks.

Re: [PATCH net-next] ipv6: Use rt6i_idev index for echo replies to a local address

2017-08-29 Thread David Miller
From: David Ahern Date: Mon, 28 Aug 2017 13:53:34 -0700 > Tariq repored local pings to linklocal address is failing: > $ ifconfig ens8 > ens8: flags=4163 mtu 1500 > inet 11.141.16.6 netmask 255.255.0.0 broadcast 11.141.255.255 >

Re: [PATCH net-next v1] amd-xgbe: Interrupt summary bits are h/w version dependent

2017-08-29 Thread David Miller
From: Tom Lendacky Date: Mon, 28 Aug 2017 15:29:34 -0500 > There is a difference in the bit position of the normal interrupt summary > enable (NIE) and abnormal interrupt summary enable (AIE) between revisions > of the hardware. For older revisions the NIE and AIE bits

[PATCH net-next v3 0/2] report TCP MD5 signing keys and addresses

2017-08-29 Thread Ivan Delalande
Allow userspace to retrieve MD5 signature keys and addresses configured on TCP sockets through inet_diag. Thank you Eric Dumazet for the useful explanations and feedback. v3: - rename inet_diag_*md5sig in tcp_diag.c to tcp_diag_* for consistency, - don't lock the socket

[PATCH net-next v3 2/2] tcp_diag: report TCP MD5 signing keys and addresses

2017-08-29 Thread Ivan Delalande
Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is not possible to retrieve these from the kernel once they have been configured on sockets. Signed-off-by: Ivan Delalande ---

[PATCH net-next v3 1/2] inet_diag: allow protocols to provide additional data

2017-08-29 Thread Ivan Delalande
Extend inet_diag_handler to allow individual protocols to report additional data on INET_DIAG_INFO through idiag_get_aux. The size can be dynamic and is computed by idiag_get_aux_size. Signed-off-by: Ivan Delalande --- include/linux/inet_diag.h | 7 +++

Re: Permissions for eBPF objects

2017-08-29 Thread Mickaël Salaün
On 29/08/2017 03:44, Chenbo Feng wrote: > On Mon, Aug 28, 2017 at 6:15 PM, Alexei Starovoitov > wrote: >> On Mon, Aug 28, 2017 at 05:47:19PM -0700, Chenbo Feng wrote: >>> On Fri, Aug 25, 2017 at 6:03 PM, Alexei Starovoitov >>> wrote:

Re: [PATCH net-next 0/4] nsh: headers, GSO

2017-08-29 Thread David Miller
From: Jiri Benc Date: Mon, 28 Aug 2017 21:43:20 +0200 > This adds header structs and helpers for NSH together with GSO support. > > Note there is no code in this patchset that actually manipulates the NSH > headers. That was sent to netdev by Yi Yang ("[PATCH net-next v6 0/3]

[PATCH net-next] neigh: increase queue_len_bytes to match wmem_default

2017-08-29 Thread Eric Dumazet
From: Eric Dumazet Florian reported UDP xmit drops that could be root caused to the too small neigh limit. Current limit is 64 KB, meaning that even a single UDP socket would hit it, since its default sk_sndbuf comes from net.core.wmem_default (~212992 bytes on 64bit

Re: [PATCH net-next 0/3] tc: act_ife: handle IEEE IFE ethertype as default

2017-08-29 Thread David Miller
From: Alexander Aring Date: Mon, 28 Aug 2017 15:03:12 -0400 > this patch series will introduce the IFE ethertype which is registered by > IEEE. If the netlink act_ife type netlink attribute is not given it will > use this value by default now. > At least it will introduce

Re: [PATCH net-next] Documentation: networking: Add blurb about patches in patchwork

2017-08-29 Thread David Miller
From: Florian Fainelli Date: Tue, 29 Aug 2017 15:07:51 -0700 > Explain that the patch queue in patchwork should not be touched by patch > submitters. > > Signed-off-by: Florian Fainelli Applied.

Re: [PATCH net-next 0/4] Endian fixes for SYSTEMPORT/SF2/MDIO

2017-08-29 Thread David Miller
From: Florian Fainelli Date: Tue, 29 Aug 2017 15:08:00 -0700 > On 08/29/2017 02:52 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Tue, 29 Aug 2017 14:45:30 -0700 >> >>> On 08/29/2017 02:42 PM, David Miller wrote: From: Florian

Re: [PATCH net v2 0/6] net:ethernet:aquantia: Atlantic driver Update 2017-08-23

2017-08-29 Thread David Miller
From: Pavel Belous Date: Mon, 28 Aug 2017 21:52:07 +0300 > From: Pavel Belous > > This series contains updates for aQuantia Atlantic driver. > > It has bugfixes and some improvements. > > Changes in v2: > - "MCP state change" fix removed

Re: [PATCH] packet: Don't write vnet header beyond end of buffer

2017-08-29 Thread David Miller
From: Benjamin Poirier Date: Mon, 28 Aug 2017 14:29:41 -0400 > ... which may happen with certain values of tp_reserve and maclen. > > Fixes: 58d19b19cd99 ("packet: vnet_hdr support for tpacket_rcv") > Signed-off-by: Benjamin Poirier > Cc: Willem de Bruijn

Re: [PATCH net v1 1/1] tipc: permit bond slave as bearer

2017-08-29 Thread David Miller
From: Parthasarathy Bhuvaragan Date: Mon, 28 Aug 2017 17:57:02 +0200 > For a bond slave device as a tipc bearer, the dev represents the bond > interface and orig_dev represents the slave in tipc_l2_rcv_msg(). > Since we decode the tipc_ptr from bonding

Re: [PATCH net-next 0/4] Endian fixes for SYSTEMPORT/SF2/MDIO

2017-08-29 Thread Florian Fainelli
On 08/29/2017 02:52 PM, David Miller wrote: > From: Florian Fainelli > Date: Tue, 29 Aug 2017 14:45:30 -0700 > >> On 08/29/2017 02:42 PM, David Miller wrote: >>> From: Florian Fainelli >>> Date: Tue, 29 Aug 2017 11:39:41 -0700 >>> While trying an

[PATCH net-next] Documentation: networking: Add blurb about patches in patchwork

2017-08-29 Thread Florian Fainelli
Explain that the patch queue in patchwork should not be touched by patch submitters. Signed-off-by: Florian Fainelli --- Documentation/networking/netdev-FAQ.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/networking/netdev-FAQ.txt

Re: [PATCH net-next 0/4] mlx4 misc patches

2017-08-29 Thread David Miller
From: Tariq Toukan Date: Mon, 28 Aug 2017 16:38:19 +0300 > This patchset contains misc patches from the team > to the mlx4 Core and Eth drivers. > > Patch 1 by Eran replaces large static allocations by dynamic ones. > Patch 2 by Leon makes an explicit conversion and solves

Re: [PATCH v2 net-next 0/8] bpf: Add option to set mark and priority in cgroup sock programs

2017-08-29 Thread David Miller
From: David Ahern Date: Fri, 25 Aug 2017 12:05:33 -0700 > Add option to set mark and priority in addition to bound device for newly > created sockets. Also, allow the bpf programs to use the get_current_uid_gid > helper meaning socket marks, priority and device can be set base

Re: [PATCH net-next 0/4] Endian fixes for SYSTEMPORT/SF2/MDIO

2017-08-29 Thread David Miller
From: Florian Fainelli Date: Tue, 29 Aug 2017 14:45:30 -0700 > On 08/29/2017 02:42 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Tue, 29 Aug 2017 11:39:41 -0700 >> >>> While trying an ARM BE kernel for kinks, the 3 drivers below started

Re: [PATCH net-next v3] bridge: fdb add and delete tracepoints

2017-08-29 Thread David Miller
From: Roopa Prabhu Date: Tue, 29 Aug 2017 13:16:57 -0700 > From: Roopa Prabhu > > A few useful tracepoints to trace bridge forwarding > database updates. > > Signed-off-by: Roopa Prabhu > --- > v2: address

Re: [PATCH net-next 0/4] Endian fixes for SYSTEMPORT/SF2/MDIO

2017-08-29 Thread Florian Fainelli
On 08/29/2017 02:42 PM, David Miller wrote: > From: Florian Fainelli > Date: Tue, 29 Aug 2017 11:39:41 -0700 > >> While trying an ARM BE kernel for kinks, the 3 drivers below started not >> working and the reasons why became pretty obvious because the register space >>

Re: [PATCH net-next 0/4] Endian fixes for SYSTEMPORT/SF2/MDIO

2017-08-29 Thread David Miller
From: Florian Fainelli Date: Tue, 29 Aug 2017 11:39:41 -0700 > While trying an ARM BE kernel for kinks, the 3 drivers below started not > working and the reasons why became pretty obvious because the register space > remains LE (hardwired), except for Broadcom MIPS where it

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-29 Thread Ondrej Zary
On Tuesday 29 August 2017 01:42:08 David Miller wrote: > From: Greg Kroah-Hartman > Date: Sun, 27 Aug 2017 17:03:30 +0200 > > > The IRDA code has long been obsolete and broken. So, to keep people > > from trying to use it, and to prevent people from having to maintain

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-29 Thread Florian Fainelli
On 08/29/2017 02:15 PM, Pavel Machek wrote: > On Tue 2017-08-29 14:26:04, Andrew Lunn wrote: >>> But the MDIO emaulation code is from their driver, after lots of >>> deletions. >> >> Is this driver supposed to run on lots of different OSs? That would >> explain why they ignored the Linux MDIO and

Re: mlxsw and rtnl lock

2017-08-29 Thread Arkadi Sharshevsky
On 08/29/2017 11:04 PM, David Ahern wrote: > On 8/29/17 12:10 AM, Arkadi Sharshevsky wrote: >> >> >> On 08/28/2017 09:00 PM, David Ahern wrote: >>> On 8/26/17 11:04 AM, Ido Schimmel wrote: Regarding the silent abort, that's intentional. You can look at the same code in v4.9 - when the

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-29 Thread Pavel Machek
On Tue 2017-08-29 14:26:04, Andrew Lunn wrote: > > But the MDIO emaulation code is from their driver, after lots of > > deletions. > > Is this driver supposed to run on lots of different OSs? That would > explain why they ignored the Linux MDIO and PHY layers. It did not look particulary

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2017 at 05:02:29PM -0400, Willem de Bruijn wrote: > + virtio-dev > > On Tue, Aug 29, 2017 at 4:38 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem de Bruijn wrote: > >> On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Willem de Bruijn
+ virtio-dev On Tue, Aug 29, 2017 at 4:38 PM, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem de Bruijn wrote: >> On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin wrote: >> > On Tue, Aug 29, 2017 at 04:07:59PM -0400, Willem de

[PATCH net-next v2 2/4] net: dsa: bcm_sf2: Use correct I/O accessors

2017-08-29 Thread Florian Fainelli
The Starfigther 2 driver currently uses __raw_{read,write}l which means native I/O endian. This works correctly for an ARM LE kernel (default) but fails miserably on an ARM BE (BE8) kernel where registers are kept little endian, so replace uses with {read,write}l_relaxed here which is what we want

[PATCH net-next v2 0/4] Endian fixes for SYSTEMPORT/SF2/MDIO

2017-08-29 Thread Florian Fainelli
Hi David, While trying an ARM BE kernel for kinks, the 3 drivers below started not working and the reasons why became pretty obvious because the register space remains LE (hardwired), except for Broadcom MIPS where it follows the CPU's native endian (let's call that a feature). Thanks! Changes

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2017 at 03:53:08PM -0400, Willem de Bruijn wrote: > On Tue, Aug 29, 2017 at 3:42 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2017 at 03:35:38PM -0400, Willem de Bruijn wrote: > >> By the way, I have had an unrelated patch outstanding for a while > >> to have

[PATCH net-next v2 1/4] net: systemport: Use correct I/O accessors

2017-08-29 Thread Florian Fainelli
The SYSTEMPORT driver currently uses __raw_{read,write}l which means native I/O endian. This works correctly for an ARM LE kernel (default) but fails miserably on an ARM BE (BE8) kernel where registers are kept little endian, so replace uses with {read,write}l_relaxed here which is what we want

[PATCH net-next v2 3/4] net: systemport: Set correct RSB endian bits based on host

2017-08-29 Thread Florian Fainelli
RSB_SWAP0 needs to match the host CPU endian, and it needs to be set for LE and clear for BE. RSB_SWAP1 must always be cleared for SYSTEMPORT Lite. With these settings, we have the Receive Status Block always match the host endian and we do not need to perform any conversion. Since there is not

[PATCH net-next v2 4/4] net: phy: mdio-bcm-unimac: Use correct I/O accessors

2017-08-29 Thread Florian Fainelli
The driver currently uses __raw_{read,write}l which works for all platforms supported: Broadcom MIPS LE/BE (native endian), ARM LE (native endian) but not ARM BE (registers are still LE). Switch to using the proper accessors for all platforms and explain why Broadcom MIPS BE is special here, in

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem de Bruijn wrote: > On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2017 at 04:07:59PM -0400, Willem de Bruijn wrote: > >> From: Willem de Bruijn > >> > >> Implement a mechanism to

Re: [PATCH net-next v3] bridge: fdb add and delete tracepoints

2017-08-29 Thread Nikolay Aleksandrov
On 29/08/17 23:16, Roopa Prabhu wrote: > From: Roopa Prabhu > > A few useful tracepoints to trace bridge forwarding > database updates. > > Signed-off-by: Roopa Prabhu > --- > v2: address comments from florian > v3: remove stray character

Re: [PATCH] Documentation: fix little inconsistencies

2017-08-29 Thread Pavel Machek
On Tue 2017-08-29 13:09:45, Jonathan Corbet wrote: > On Tue, 29 Aug 2017 09:50:57 -0700 > "Darrick J. Wong" wrote: > > > > Anything wrong here? It is fixing extra '+' in the ascii art... > > > > There's nothing incorrect here, I merely thought it odd to send a fix > >

  1   2   3   >