net/ipv4: divide error in __tcp_select_window

Hi: This bug seems still can be triggered by the attached PoC on latest Ubuntu1604 (4.4.0-94-generic) divide error: [#1] SMP KASAN Modules linked in: CPU: 0 PID: 14933 Comm: syz-executor0 Not tainted 4.9.45 #1

[PATCH] bnx2x: drop packets where gso_size is too big for hardware

If a bnx2x card is passed a GSO packet with a gso_size larger than ~9700 bytes, it will cause a firmware error that will bring the card down: bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert! bnx2x: [bnx2x_mc_assert:720(enP24p1s0f0)]XSTORM_ASSERT_LIST_INDEX 0x2 bnx2x:

[PATCH] net: dccp: Add handling of IPV6_PKTOPTIONS to dccp_v6_do_rcv()

Add handling of IPV6_PKTOPTIONS to dccp_v6_do_rcv() in net/dccp/ipv6.c, similar to the handling in net/ipv6/tcp_ipv6.c Signed-off-by: Andrii Vladyka --- diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c index 1b58eac..35c2edb 100644 --- a/net/dccp/ipv6.c +++ b/net/dccp/ipv6.c @@

Re: [PATCH] net: dccp: Add handling of IPV6_PKTOPTIONS to dccp_v6_do_rcv()

I'll fix and re-send. Thanks. On 8/31/2017 8:16 AM, David Miller wrote: From: Andrii Vladyka Date: Wed, 30 Aug 2017 09:04:35 +0300 + if (opt_skb) Trailing whitespace. @@ -653,6 +647,36 @@ static int dccp_v6_do_rcv(struct sock *sk, struct

[PATCH net-next] bridge: add tracepoint in br_fdb_update

From: Roopa Prabhu This extends bridge fdb table tracepoints to also cover learned fdb entries in the br_fdb_update path. Note that unlike other tracepoints I have moved this to when the fdb is modified because this is in the datapath and can generate a lot of noise in

Re: [PATCH] net: dccp: Add handling of IPV6_PKTOPTIONS to dccp_v6_do_rcv()

From: Andrii Vladyka Date: Wed, 30 Aug 2017 09:04:35 +0300 > + if (opt_skb) Trailing whitespace. > @@ -653,6 +647,36 @@ static int dccp_v6_do_rcv(struct sock *sk, struct > sk_buff *skb) > __kfree_skb(opt_skb); > kfree_skb(skb);

Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

From: Saeed Mahameed Date: Thu, 31 Aug 2017 02:04:06 +0300 > The following changes provide GRE tunnel offloads for mlx5 ethernet netdevice > driver. > > For more details please see tag log message below. > Please pull and let me know if there's any problem. > > Note: this

Re: [PATCH net-next] liquidio: fix crash in presence of zeroed-out base address regs

From: Felix Manlunas Date: Wed, 30 Aug 2017 16:19:53 -0700 > From: Rick Farrington > > Fix crash in linux PF driver when BARs have been cleared/de-programmed; > fail early init (prior to mapping BARs) if the BAR0 or > BAR1 registers are

Re: [PATCH net-next] devlink: Maintain consistency in mac field name

From: David Ahern Date: Wed, 30 Aug 2017 17:07:30 -0700 > IPv4 name uses "destination ip" as does the IPv6 patch set. > Make the mac field consistent. > > Signed-off-by: David Ahern Applied, thanks.

Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R. Silva --- This issue was reported

Re: [GIT] Networking

David Miller writes: > From: Kalle Valo > Date: Wed, 30 Aug 2017 20:31:31 +0300 > >> AFAICS the bug was introduced by 9df86e2e702c6 back in 2010. If the bug >> has been there for 7 years so waiting for a few more weeks should not >> hurt. > > As a

Re: [PATCH] rtlwifi: rtl8723be: fix duplicated code for different branches

On 08/30/2017 12:04 PM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. Addresses-Coverity-ID: 1248728 Signed-off-by: Gustavo A. R. Silva According to Realtek, this change is OK. Acked-by: Larry Finger

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

On Wed, 2017-08-30 at 21:10 -0700, Kees Cook wrote: > On Wed, Aug 30, 2017 at 9:01 PM, Kees Cook wrote: > > On Wed, Aug 30, 2017 at 8:12 PM, Mike Galbraith wrote: > >> On Wed, 2017-08-30 at 19:27 -0700, Kees Cook wrote: > >> > >>> Interesting! Can you try

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

On Tue, Aug 29, 2017 at 11:32:58PM +0200, Ondrej Zary wrote: > On Tuesday 29 August 2017 01:42:08 David Miller wrote: > > From: Greg Kroah-Hartman > > Date: Sun, 27 Aug 2017 17:03:30 +0200 > > > > > The IRDA code has long been obsolete and broken. So, to keep people >

Re: [PATCH net-next v4 2/2] tcp_diag: report TCP MD5 signing keys and addresses

On Wed, 2017-08-30 at 18:33 -0700, Ivan Delalande wrote: > Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to > processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is > not possible to retrieve these from the kernel once they have been > configured on

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

On Wed, Aug 30, 2017 at 9:01 PM, Kees Cook wrote: > On Wed, Aug 30, 2017 at 8:12 PM, Mike Galbraith wrote: >> On Wed, 2017-08-30 at 19:27 -0700, Kees Cook wrote: >> >>> Interesting! Can you try with 633547973ffc3 ("net: convert >>> sk_buff.users from

Re: [net-next PATCHv6 0/2] net: ethernet: Socionext Netsec

On August 30, 2017 3:24:17 AM PDT, Jassi Brar wrote: >Hello, > >The OGMA/Netsec controller is used in latest SoC from >Socionext/Fujitsu. > >I am refreshing the patchset by basically using official name of the IP >from 'OGMA' to 'Netsec'. And the company is renamed too,

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

On Wed, Aug 30, 2017 at 8:12 PM, Mike Galbraith wrote: > On Wed, 2017-08-30 at 19:27 -0700, Kees Cook wrote: > >> Interesting! Can you try with 633547973ffc3 ("net: convert >> sk_buff.users from atomic_t to refcount_t") reverted? I'll see if >> running haveged will help me trigger

Re: [PATCH net-next] net/ncsi: Define {add,kill}_vid callbacks for !CONFIG_NET_NCSI

On August 30, 2017 8:38:46 PM PDT, Samuel Mendoza-Jonas wrote: >Patch "net/ncsi: Configure VLAN tag filter" defined two new callback >functions in include/net/ncsi.h, but neglected the !CONFIG_NET_NCSI >case. This can cause a build error if these are referenced elsewhere

linux-next: manual merge of the tip tree with the net-next tree

Hi all, Today's linux-next merge of the tip tree got a conflict in: drivers/net/ethernet/cavium/liquidio/lio_main.c between commit: d1d97ee6e3a8 ("liquidio: moved liquidio_napi_drv_callback to lio_core.c") from the net-next tree and commit: 966a967116e6 ("smp: Avoid using two cache

[PATCH net-next] net/ncsi: Define {add,kill}_vid callbacks for !CONFIG_NET_NCSI

Patch "net/ncsi: Configure VLAN tag filter" defined two new callback functions in include/net/ncsi.h, but neglected the !CONFIG_NET_NCSI case. This can cause a build error if these are referenced elsewhere without NCSI enabled, for example in ftgmac100: >>> ERROR: "ncsi_vlan_rx_kill_vid"

Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for Socionext Netsec

On Wed, Aug 30, 2017 at 8:49 PM, Andrew Lunn wrote: > On Wed, Aug 30, 2017 at 03:55:52PM +0530, Jassi Brar wrote: >> This patch adds documentation for Device-Tree bindings for the >> Socionext NetSec Controller driver. >> >> Signed-off-by: Jassi Brar

Re: [PATCH][next] bpf: test_maps: fix typo "conenct" -> "connext"

On Wed, 2017-08-30 at 12:47 +0100, Colin King wrote: > From: Colin Ian King connext->connect typo in patch subject > Trivial fix to typo in printf error message > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH net] Revert "net: phy: Correctly process PHY_HALTED in phy_stop_machine()"

From: Florian Fainelli Date: Wed, 30 Aug 2017 17:49:29 -0700 > This reverts commit 7ad813f208533cebfcc32d3d7474dc1677d1b09a ("net: phy: > Correctly process PHY_HALTED in phy_stop_machine()") because it is > creating the possibility for a NULL pointer dereference. > > David

Re: DSA mv88e6xxx RX frame errors and TCP/IP RX failure

> >/* Report late collisions as a frame error. */ > > if (status & (BD_ENET_RX_NO | BD_ENET_RX_CL)) > > ndev->stats.rx_frame_errors++; > > > > I don't see anywhere else frame errors are counted, but it would be > >

[PATCH net-next v4 2/2] tcp_diag: report TCP MD5 signing keys and addresses

Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is not possible to retrieve these from the kernel once they have been configured on sockets. Signed-off-by: Ivan Delalande ---

[PATCH net-next v4 1/2] inet_diag: allow protocols to provide additional data

Extend inet_diag_handler to allow individual protocols to report additional data on INET_DIAG_INFO through idiag_get_aux. The size can be dynamic and is computed by idiag_get_aux_size. Signed-off-by: Ivan Delalande --- include/linux/inet_diag.h | 7 +++

[PATCH net-next v4 0/2] report TCP MD5 signing keys and addresses

Allow userspace to retrieve MD5 signature keys and addresses configured on TCP sockets through inet_diag. Thanks to Eric Dumazet and Stephen Hemminger for their useful explanations and feedback. v4: - add new struct tcp_diag_md5sig to report the data instead of tcp_md5sig to avoid wasting

RE: [patch net-next v2 0/3] net/sched: Improve getting objects by indexes

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, August 31, 2017 5:39 AM > To: Chris Mi > Cc: netdev@vger.kernel.org; j...@mojatatu.com; > xiyou.wangc...@gmail.com; j...@resnulli.us; mawil...@microsoft.com > Subject: Re:

RE: [patch net-next v2 3/3] net/sched: Change act_api and act_xxx modules to use IDR

> -Original Message- > From: Jamal Hadi Salim [mailto:j...@mojatatu.com] > Sent: Wednesday, August 30, 2017 8:11 PM > To: Chris Mi ; netdev@vger.kernel.org > Cc: xiyou.wangc...@gmail.com; j...@resnulli.us; da...@davemloft.net; > mawil...@microsoft.com > Subject: Re:

[PATCH net] Revert "net: phy: Correctly process PHY_HALTED in phy_stop_machine()"

This reverts commit 7ad813f208533cebfcc32d3d7474dc1677d1b09a ("net: phy: Correctly process PHY_HALTED in phy_stop_machine()") because it is creating the possibility for a NULL pointer dereference. David Daney provide the following call trace and diagram of events: When ndo_stop() is called we

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

On 08/30/2017 05:13 PM, David Daney wrote: > On 07/31/2017 05:28 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Fri, 28 Jul 2017 11:58:36 -0700 >> >>> Marc reported that he was not getting the PHY library adjust_link() >>> callback function to run when calling

Re: DSA mv88e6xxx RX frame errors and TCP/IP RX failure

On Wed, Aug 30, 2017 at 8:22 PM, Tim Harvey wrote: > On Wed, Aug 30, 2017 at 3:06 PM, Andrew Lunn wrote: >> On Wed, Aug 30, 2017 at 12:53:56PM -0700, Tim Harvey wrote: >>> Greetings, >>> >>> I'm seeing RX frame errors when using the mv88e6xxx DSA driver on

Re: multi-queue over IFF_NO_QUEUE "virtual" devices

On 08/30/2017 04:37 PM, Cong Wang wrote: > On Tue, Aug 29, 2017 at 8:49 PM, Florian Fainelli > wrote: >> Le 08/07/17 à 15:26, Florian Fainelli a écrit : >>> Hi, >>> >>> Most DSA supported Broadcom switches have multiple queues per ports >>> (usually 8) and each of these

[RFC net-next 6/8] net: dsa: Expose dsa_slave_dev_check and dsa_slave_dev_port_num

Expose two helper functions: * one to verify if a net_device is a DSA slave network device * one to obtain the physical port number associated with a DSA slave network device Signed-off-by: Florian Fainelli --- include/net/dsa.h | 15 +++ net/dsa/slave.c |

[RFC net-next 7/8] net: dsa: tag_brcm: Indicate to master netdevice port + queue

We need to tell the DSA master network device doing the actual transmission what the desired switch port and queue number is for it to resolve that to the internal transmit queue it is mapped to. Signed-off-by: Florian Fainelli --- net/dsa/tag_brcm.c | 5 + 1 file

[RFC net-next 8/8] net: systemport: Establish DSA network device queue mapping

Establish a queue mapping between the DSA slave network device queues created, and the transmit queue that SYSTEMPORT manages. We need to configure the SYSTEMPORT transmit queue with the switch port number and switch port queue number in order for the switch and SYSTEMPORT hardware to utilize the

[RFC net-next 5/8] net: dsa: bcm_sf2: Fix number of CFP entries for BCM7278

BCM7278 has only 128 entries while BCM7445 has the full 256 entries set, fix that. Fixes: 7318166cacad ("net: dsa: bcm_sf2: Add support for ethtool::rxnfc") Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 4 drivers/net/dsa/bcm_sf2.h | 1 +

[RFC net-next 4/8] net: dsa: bcm_sf2: Configure IMP port TC2QOS mapping

Even though TC2QOS mapping is for switch egress queues, we need to configure it correclty in order for the Broadcom tag ingress (CPU -> switch) queue selection to work correctly since there is a 1:1 mapping between switch egress queues and ingress queues. Signed-off-by: Florian Fainelli

[RFC net-next 3/8] net: dsa: bcm_sf2: Advertise number of egress queues

The switch supports 8 egress queues per port, so indicate that such that net/dsa/slave.c::dsa_slave_create can allocate the right number of TX queues. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[RFC net-next 2/8] net: dsa: tag_brcm: Set output queue from skb queue mapping

We originally used skb->priority but that was not quite correct as this bitfield needs to contain the egress switch queue we intend to send this SKB to. Signed-off-by: Florian Fainelli --- net/dsa/tag_brcm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[RFC net-next 1/8] net: dsa: Allow switch drivers to indicate number of RX/TX queues

Let switch drivers indicate how many RX and TX queues they support. Some switches, such as Broadcom Starfighter 2 are resigned with 8 egress queues. Future changes will allow us to leverage the queue mapping and direct the transmission towards a particular queue. Signed-off-by: Florian Fainelli

[RFC net-next 0/8] net: dsa: Multi-queue awareness

This patch series is sent as reference, especially because the last patch is trying not to be creating too many layer violations, but clearly there are a little bit being created here anyways. Essentially what I am trying to achieve is that you have a stacked device which is multi-queue aware,

Re: DSA mv88e6xxx RX frame errors and TCP/IP RX failure

On Wed, Aug 30, 2017 at 3:06 PM, Andrew Lunn wrote: > On Wed, Aug 30, 2017 at 12:53:56PM -0700, Tim Harvey wrote: >> Greetings, >> >> I'm seeing RX frame errors when using the mv88e6xxx DSA driver on >> 4.13-rc7. The board I'm using is a GW5904 [1] which has an IMX6 FEC >> MAC

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

On 08/30/2017 05:13 PM, David Daney wrote: > On 07/31/2017 05:28 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Fri, 28 Jul 2017 11:58:36 -0700 >> >>> Marc reported that he was not getting the PHY library adjust_link() >>> callback function to run when calling

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

And of course I mess up my pretty picture, see below. On 08/30/2017 05:13 PM, David Daney wrote: On 07/31/2017 05:28 PM, David Miller wrote: From: Florian Fainelli Date: Fri, 28 Jul 2017 11:58:36 -0700 Marc reported that he was not getting the PHY library adjust_link()

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

On 07/31/2017 05:28 PM, David Miller wrote: From: Florian Fainelli Date: Fri, 28 Jul 2017 11:58:36 -0700 Marc reported that he was not getting the PHY library adjust_link() callback function to run when calling phy_stop() + phy_disconnect() which does not indeed happen

[PATCH net-next] devlink: Maintain consistency in mac field name

IPv4 name uses "destination ip" as does the IPv6 patch set. Make the mac field consistent. Signed-off-by: David Ahern --- net/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index

Re: [pull request][net 00/11] Mellanox, mlx5 fixes 2017-08-30

From: Saeed Mahameed Date: Thu, 31 Aug 2017 01:20:59 +0300 > This series contains some misc fixes to the mlx5 driver. > > Please pull and let me know if there's any problem. Series applied, thanks.

Re: multi-queue over IFF_NO_QUEUE "virtual" devices

On Tue, Aug 29, 2017 at 8:49 PM, Florian Fainelli wrote: > Le 08/07/17 à 15:26, Florian Fainelli a écrit : >> Hi, >> >> Most DSA supported Broadcom switches have multiple queues per ports >> (usually 8) and each of these queues can be configured with different >> pause,

[PATCH net-next] liquidio: fix crash in presence of zeroed-out base address regs

From: Rick Farrington Fix crash in linux PF driver when BARs have been cleared/de-programmed; fail early init (prior to mapping BARs) if the BAR0 or BAR1 registers are zero. This situation can arise when the PF is added to a VM (PCI pass-through), then a PF FLR is

Re: [Patch net-next] net_sched: add reverse binding for tc class

On Wed, Aug 30, 2017 at 3:45 PM, Daniel Borkmann wrote: > On 08/31/2017 12:22 AM, Daniel Borkmann wrote: >> >> The prog->res.classid is the default one, but can be overridden >> later depending on the specified program. cls_bpf_classify() does >> after prog return

Re: [PATCH net-next] hv_netvsc: Fix typos in the document of UDP hashing

From: Haiyang Zhang Date: Wed, 30 Aug 2017 13:37:22 -0700 > From: Haiyang Zhang > > There are two typos in the document, netvsc.txt, > regarding UDP hashing level. This patch fixes them. > > Signed-off-by: Haiyang Zhang

[net-next 2/3] net/mlx5e: Support TSO and TX checksum offloads for GRE tunnels

From: Gal Pressman Add TX offloads support for GRE tunneled packets by reporting the needed netdev features. Signed-off-by: Gal Pressman Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed ---

[net-next 3/3] net/mlx5e: Support RSS for GRE tunneled packets

From: Gal Pressman Introduce a new flow table and indirect TIRs which are used to hash the inner packet headers of GRE tunneled packets. When a GRE tunneled packet is received, the TTC flow table will match the new IPv4/6->GRE rules which will forward it to the inner TTC

[pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

Hi Dave, Tthe following changes provide GRE tunnel offloads for mlx5 ethernet netdevice driver. For more details please see tag log message below. Please pull and let me know if there's any problem. Note: this series doesn't conflict with the ongoing net mlx5 submission. Thanks, Saeed. ---

[net-next 1/3] net/mlx5e: Use IP version matching to classify IP traffic

From: Gal Pressman This change adds the ability for flow steering to classify IPv4/6 packets with MPLS tag (Ethertype 0x8847 and 0x8848) as standard IP packets and hit IPv4/6 classification steering rules. Since IP packets with MPLS tag header have MPLS ethertype, they missed

Re: [PATCH net] net: dsa: bcm_sf2: Fix number of CFP entries for BCM7278

From: Florian Fainelli Date: Wed, 30 Aug 2017 12:39:33 -0700 > BCM7278 has only 128 entries while BCM7445 has the full 256 entries set, > fix that. > > Fixes: 7318166cacad ("net: dsa: bcm_sf2: Add support for ethtool::rxnfc") > Signed-off-by: Florian Fainelli

Re: [PATCH net-next] xen-netfront: be more drop monitor friendly

From: Eric Dumazet Date: Wed, 30 Aug 2017 10:32:58 -0700 > From: Eric Dumazet > > xennet_start_xmit() might copy skb with inappropriate layout > into a fresh one. > > Old skb is freed, and at this point it is not a drop, but > a consume. New skb

Re: [PATCH net] kcm: do not attach PF_KCM sockets to avoid deadlock

From: Eric Dumazet Date: Wed, 30 Aug 2017 09:29:31 -0700 > From: Eric Dumazet > > syzkaller had no problem to trigger a deadlock, attaching a KCM socket > to another one (or itself). (original syzkaller report was a very > confusing lockdep splat

Re: [Patch net-next] net_sched: add reverse binding for tc class

On 08/31/2017 12:22 AM, Daniel Borkmann wrote: On 08/31/2017 12:01 AM, Cong Wang wrote: On Wed, Aug 30, 2017 at 2:48 PM, Daniel Borkmann wrote: On 08/30/2017 11:30 PM, Cong Wang wrote: [...] Note, we still can NOT totally get rid of those class lookup in ->enqueue()

Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

From: Colin King Date: Wed, 30 Aug 2017 18:15:25 +0100 > From: Colin Ian King > > Trivial fix to typos in printf error messages: > "conenct" -> "connect" > "listeen" -> "listen" > > thanks to Daniel Borkmann for spotting one of these

Re: [PATCH][next] qed: fix spelling mistake: "calescing" -> "coalescing"

From: Colin King Date: Wed, 30 Aug 2017 12:40:12 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in DP_NOTICE message > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH net-next] net: hns3: Fixes the wrong IS_ERR check on the returned phydev value

From: Salil Mehta Date: Wed, 30 Aug 2017 12:06:03 +0100 > This patch removes the wrong check being done for the phy device being > returned by the mdiobus_get_phy() function. This function never returns > the error pointers. > > Fixes: 256727da7395 ("net: hns3: Add MDIO

Re: [PATCH net 0/9] net/sched: init failure fixes

From: Jamal Hadi Salim Date: Wed, 30 Aug 2017 08:15:37 -0400 > On 17-08-30 05:48 AM, Nikolay Aleksandrov wrote: >> Hi all, >> I went over all qdiscs' init, destroy and reset callbacks and found >> the >> issues fixed in each patch. Mostly they are null pointer dereferences >>

Re: [Patch net-next] net_sched: add reverse binding for tc class

On 08/31/2017 12:01 AM, Cong Wang wrote: On Wed, Aug 30, 2017 at 2:48 PM, Daniel Borkmann wrote: On 08/30/2017 11:30 PM, Cong Wang wrote: [...] Note, we still can NOT totally get rid of those class lookup in ->enqueue() because cgroup and flow filters have no way to

[net 03/11] net/mlx5: Fix arm SRQ command for ISSI version 0

From: Noa Osherovich Support for ISSI version 0 was recently broken as the arm_srq_cmd command, which is used only for ISSI version 0, was given the opcode for ISSI version 1 instead of ISSI version 0. Change arm_srq_cmd to use the correct command opcode for ISSI version 0.

[net 02/11] net/mlx5e: Fix DCB_CAP_ATTR_DCBX capability for DCBNL getcap.

From: Huy Nguyen Current code doesn't report DCB_CAP_DCBX_HOST capability when query through getcap. User space lldptool expects capability to have HOST mode set when it wants to configure DCBX CEE mode. In absence of HOST mode capability, lldptool fails to switch to CEE mode.

[net 09/11] net/mlx5: E-Switch, Unload the representors in the correct order

From: Shahar Klein When changing from switchdev to legacy mode, all the representor port devices (uplink nic and reps) are cleaned up. Part of this cleaning process is removing the neigh entries and the hash table containing them. However, a representor neigh entry might be

[pull request][net 00/11] Mellanox, mlx5 fixes 2017-08-30

Hi Dave, This series contains some misc fixes to the mlx5 driver. Please pull and let me know if there's any problem. For -stable: Kernels >= 4.12 net/mlx5e: Fix CQ moderation mode not set properly net/mlx5e: Don't override user RSS upon set channels Kernels >= 4.11

[net 06/11] net/mlx5e: Fix dangling page pointer on DMA mapping error

From: Eran Ben Elisha Function mlx5e_dealloc_rx_wqe is using page pointer value as an indication to valid DMA mapping. In case that the mapping failed, we released the page but kept the dangling pointer. Store the page pointer only after the DMA mapping passed to avoid

[net 08/11] net/mlx5e: Properly resolve TC offloaded ipv6 vxlan tunnel source address

From: Paul Blakey Currently if vxlan tunnel ipv6 src isn't supplied the driver fails to resolve it as part of the route lookup. The resulting encap header is left with a zeroed out ipv6 src address so the packets are sent with this src ip. Use an appropriate route lookup API

[net 11/11] net/mlx5e: Fix CQ moderation mode not set properly

From: Tal Gilboa cq_period_mode assignment was mistakenly removed so it was always set to "0", which is EQE based moderation, regardless of the device CAPs and requested value in ethtool. Fixes: 6a9764efb255 ("net/mlx5e: Isolate open_channels from priv->params")

[net 05/11] net/mlx5: Remove the flag MLX5_INTERFACE_STATE_SHUTDOWN

From: Huy Nguyen MLX5_INTERFACE_STATE_SHUTDOWN is not used in the code. Fixes: 5fc7197d3a25 ("net/mlx5: Add pci shutdown callback") Signed-off-by: Huy Nguyen Reviewed-by: Daniel Jurgens Signed-off-by: Saeed Mahameed

[net 10/11] net/mlx5e: Fix inline header size for small packets

From: Moshe Shemesh Fix inline header size, make sure it is not greater than skb len. This bug effects small packets, for example L2 packets with size < 18. Fixes: ae76715d153e ("net/mlx5e: Check the minimum inline header mode before xmit") Signed-off-by: Moshe Shemesh

[net 07/11] net/mlx5e: Don't override user RSS upon set channels

From: Inbar Karmy Currently, increasing the number of combined channels is changing the RSS spread to use the new created channels. Prevent the RSS spread change in case the user explicitly declare it, to avoid overriding user configuration. Tested: when RSS default: #

[net 04/11] net/mlx5: Skip mlx5_unload_one if mlx5_load_one fails

From: Huy Nguyen There is an issue where the firmware fails during mlx5_load_one, the health_care timer detects the issue and schedules a health_care call. Then the mlx5_load_one detects the issue, cleans up and quits. Then the health_care starts and calls mlx5_unload_one to

[net 01/11] net/mlx5e: Check for qos capability in dcbnl_initialize

From: Huy Nguyen qos capability is the master capability bit that determines if the DCBX is supported for the PCI function. If this bit is off, driver cannot run any dcbx code. Fixes: e207b7e99176 ("net/mlx5e: ConnectX-4 firmware support for DCBX") Signed-off-by: Huy Nguyen

Re: [PATCH] net: bcm63xx_enet: make bcm_enetsw_ethtool_ops const

From: Bhumika Goyal Date: Wed, 30 Aug 2017 14:55:08 +0530 > Make this const as it is never modified. > > Signed-off-by: Bhumika Goyal Applied to net-next.

Re: [PATCH v2] ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200"

From: Ahmed Abdelsalam Date: Wed, 30 Aug 2017 10:50:37 +0200 > IPv6 packet may carry more than one extension header, and IPv6 nodes must > accept and attempt to process extension headers in any order and occurring > any number of times in the same packet. Hence, there should

Re: [PATCH net-next v4 00/13] net: mvpp2: comphy configuration

From: Antoine Tenart Date: Wed, 30 Aug 2017 10:29:11 +0200 > This series, following up the one one the GoP/MAC configuration, aims at > stopping to depend on the firmware/bootloader configuration when using > the PPv2 engine. With this series the PPv2 driver

Re: DSA mv88e6xxx RX frame errors and TCP/IP RX failure

On Wed, Aug 30, 2017 at 12:53:56PM -0700, Tim Harvey wrote: > Greetings, > > I'm seeing RX frame errors when using the mv88e6xxx DSA driver on > 4.13-rc7. The board I'm using is a GW5904 [1] which has an IMX6 FEC > MAC (eth0) connected via RGMII to a MV88E6176 with its downstream > P0/P1/P2/P3 to

Re: [Patch net-next] net_sched: add reverse binding for tc class

On Wed, Aug 30, 2017 at 2:48 PM, Daniel Borkmann wrote: > On 08/30/2017 11:30 PM, Cong Wang wrote: > [...] >> >> Note, we still can NOT totally get rid of those class lookup in >> ->enqueue() because cgroup and flow filters have no way to determine >> the classid at setup

Re: [PATCH] DSA support for Micrel KSZ8895

> The KSZ8795 driver will be submitted after Labor Day (9/4) if > testing reveals no problem. The KSZ8895 driver will be submitted > right after that. You should have no problem using the driver right > away. Hi Tristram Release early, release often. It stops people wasting time Also, we

Re: [PATCH net-next] dp83640: don't hold spinlock while calling netif_rx_ni

From: Stefan Sørensen Date: Wed, 30 Aug 2017 08:58:47 +0200 > We should not hold a spinlock while pushing the skb into the networking > stack, so move the call to netif_rx_ni out of the critical region to where > we have dropped the spinlock. > > Signed-off-by:

Re: [Patch net-next] net_sched: add reverse binding for tc class

On 08/30/2017 11:30 PM, Cong Wang wrote: [...] Note, we still can NOT totally get rid of those class lookup in ->enqueue() because cgroup and flow filters have no way to determine the classid at setup time, they still have to go through dynamic lookup. [...] --- include/net/sch_generic.h |

Re: [PATCH net-next] net: cpsw: Don't handle SIOC[GS]HWTSTAMP when CPTS is disabled

From: Stefan Sørensen Date: Wed, 30 Aug 2017 08:50:55 +0200 > There is no reason to handle SIOC[GS]HWTSTAMP and return -EOPNOTSUPP when > CPTS is disabled, so just pass them on to the phy. This will allow PTP > timestamping on a capable phy by disabling CPTS. >

Re: [PATCH net-next 3/3 v11] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

Subash, keep in mind that since I applied your v11 patches already you will need to send me relative fixes and changes at this point, rather than resubmit the series. Thank you. Thanks for the heads up David. Will do. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is

Re: [patch net-next v2 0/3] net/sched: Improve getting objects by indexes

From: Chris Mi Date: Wed, 30 Aug 2017 02:31:56 -0400 > Using current TC code, it is very slow to insert a lot of rules. > > In order to improve the rules update rate in TC, > we introduced the following two changes: > 1) changed cls_flower to use IDR to manage the

Re: [PATCH net 9/9] sch_tbf: fix two null pointer dereferences on init failure

On 30/08/17 20:37, Cong Wang wrote: > On Wed, Aug 30, 2017 at 2:49 AM, Nikolay Aleksandrov > wrote: >> Reproduce: >> $ sysctl net.core.default_qdisc=tbf >> $ ip l set ethX up > > I once upon a time had a patch to disallow those qdisc's > to be default. Probably I

Re: [PATCH net 6/9] sch_fq_codel: avoid double free on init failure

On 30/08/17 20:36, Cong Wang wrote: > On Wed, Aug 30, 2017 at 2:49 AM, Nikolay Aleksandrov > wrote: >> It is very unlikely to happen but the backlogs memory allocation >> could fail and will free q->flows, but then ->destroy() will free >> q->flows too. For

Re: [PATCH net 0/9] net/sched: init failure fixes

On 30/08/17 15:15, Jamal Hadi Salim wrote: > On 17-08-30 05:48 AM, Nikolay Aleksandrov wrote: >> Hi all, >> I went over all qdiscs' init, destroy and reset callbacks and found the >> issues fixed in each patch. Mostly they are null pointer dereferences due >> to uninitialized timer (qdisc

RE: [PATCH] DSA support for Micrel KSZ8895

> On Mon 2017-08-28 16:09:27, Andrew Lunn wrote: > > > I may be confused here, but AFAICT: > > > > > > 1) Yes, it has standard layout when accessed over MDIO. > > > > > > Section 4.8 of the datasheet says: > > > > All the registers defined in this section can be also accessed > > via the

[Patch net-next] net_sched: add reverse binding for tc class

TC filters when used as classifiers are bound to TC classes. However, there is a hidden difference when adding them in different orders: 1. If we add tc classes before its filters, everything is fine. Logically, the classes exist before we specify their ID's in filters, it is easy to bind

Re: [PATCH net-next 3/3 v11] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

From: Subash Abhinov Kasiviswanathan Date: Wed, 30 Aug 2017 15:19:19 -0600 > Sure, I'll implement this. Let me know if you have more comments. Subash, keep in mind that since I applied your v11 patches already you will need to send me relative fixes and changes at this

Re: [PATCH net-next 3/3 v11] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

General comment; other drivers that do similar things (macvlan, ipvlan) use the term "port" to refer to what I think you're calling a "rmnet_real_dev_info". Maybe that's a shorter or less confusing term. Could be renamed later too, if you wanted to do so. Hi Dan I'll rename it to rmnet_port.

[PATCH net-next] hv_netvsc: Fix typos in the document of UDP hashing

From: Haiyang Zhang There are two typos in the document, netvsc.txt, regarding UDP hashing level. This patch fixes them. Signed-off-by: Haiyang Zhang --- Documentation/networking/netvsc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 10:13 PM, Shuah Khan wrote: On 08/30/2017 12:47 PM, Daniel Borkmann wrote: On 08/30/2017 07:15 PM, Colin King wrote: From: Colin Ian King Trivial fix to typos in printf error messages: "conenct" -> "connect" "listeen" -> "listen" thanks to Daniel

Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 12:47 PM, Daniel Borkmann wrote: > On 08/30/2017 07:15 PM, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to typos in printf error messages: >> "conenct" -> "connect" >> "listeen" -> "listen" >> >> thanks to Daniel Borkmann for spotting one of

DSA mv88e6xxx RX frame errors and TCP/IP RX failure

Greetings, I'm seeing RX frame errors when using the mv88e6xxx DSA driver on 4.13-rc7. The board I'm using is a GW5904 [1] which has an IMX6 FEC MAC (eth0) connected via RGMII to a MV88E6176 with its downstream P0/P1/P2/P3 to front panel RJ45's (lan1-lan4). What I see is the following: - bring

  1   2   3   >