[PATCH v2 net-next 4/4] bpf: add a test case for helper bpf_perf_prog_read_time

2017-09-01 Thread Yonghong Song
The bpf sample program trace_event is enhanced to use the new helper to print out enabled/running time. Signed-off-by: Yonghong Song --- samples/bpf/trace_event_kern.c| 10 ++ samples/bpf/trace_event_user.c| 13 -

[PATCH v2 net-next 1/4] bpf: add helper bpf_perf_read_counter_time for perf event array map

2017-09-01 Thread Yonghong Song
Hardware pmu counters are limited resources. When there are more pmu based perf events opened than available counters, kernel will multiplex these events so each event gets certain percentage (but not 100%) of the pmu time. In case that multiplexing happens, the number of samples or counter value

[PATCH v2 net-next 0/4] bpf: add two helpers to read perf event enabled/running time

2017-09-01 Thread Yonghong Song
Hardware pmu counters are limited resources. When there are more pmu based perf events opened than available counters, kernel will multiplex these events so each event gets certain percentage (but not 100%) of the pmu time. In case that multiplexing happens, the number of samples or counter value

[PATCH v2 net-next 3/4] bpf: add helper bpf_perf_prog_read_time

2017-09-01 Thread Yonghong Song
This patch adds helper bpf_perf_prog_read_time for perf event based bpf programs, to read event enabled/running time. The enabled/running time is accumulated since the perf event open. The typical use case for perf event based bpf program is to attach itself to a single event. In such cases, if

[PATCH v2 net-next 2/4] bpf: add a test case to read enabled/running time for perf array

2017-09-01 Thread Yonghong Song
The bpf sample program tracex6 is enhanced to use the new helper to read enabled/running time as well. Signed-off-by: Yonghong Song --- samples/bpf/tracex6_kern.c| 26 ++ samples/bpf/tracex6_user.c| 13 -

Re: [PATCH] ipv6: sr: Use ARRAY_SIZE macro

2017-09-01 Thread Joe Perches
On Fri, 2017-09-01 at 18:35 -0700, David Miller wrote: > From: Thomas Meyer > Date: Thu, 31 Aug 2017 16:18:15 +0200 > > > Grepping for "sizeof\(.+\) / sizeof\(" found this as one of the first > > candidates. > > Maybe a coccinelle can catch all of those. Umm: try

Re: [PATCH net-next, 0/4] cleanups and fixes of channel settings

2017-09-01 Thread David Miller
From: Haiyang Zhang Date: Fri, 1 Sep 2017 14:30:03 -0700 > This patch set cleans up some unused variables, unnecessary checks. > Also fixed some limit checking of channel number. Series applied.

Re: [PATCH net-next] net: Add module reference to FIB notifiers

2017-09-01 Thread David Miller
From: Ido Schimmel Date: Fri, 1 Sep 2017 12:15:17 +0300 > When a listener registers to the FIB notification chain it receives a > dump of the FIB entries and rules from existing address families by > invoking their dump operations. > > While we call into these modules we

Re: [PATCH net-next 0/2] netvsc: transparent VF related cleanups

2017-09-01 Thread David Miller
From: Stephen Hemminger Date: Thu, 31 Aug 2017 16:16:11 -0700 > The first gets rid of unnecessary ref counting, and second > allows removing hv_netvsc driver even if VF present. Series applied.

Re: [net-next PATCH] bpf: sockmap update/simplify memory accounting scheme

2017-09-01 Thread David Miller
From: John Fastabend Date: Fri, 01 Sep 2017 11:29:26 -0700 > Instead of tracking wmem_queued and sk_mem_charge by incrementing > in the verdict SK_REDIRECT paths and decrementing in the tx work > path use skb_set_owner_w and sock_writeable helpers. This solves > a few

Re: [PATCH v2 net-next 0/2] net: ubuf_info.refcnt conversion

2017-09-01 Thread David Miller
From: Eric Dumazet Date: Fri, 01 Sep 2017 10:36:29 -0700 > On Thu, 2017-08-31 at 17:04 -0700, Eric Dumazet wrote: >> On Thu, 2017-08-31 at 16:48 -0700, Eric Dumazet wrote: >> > Yet another atomic_t -> refcount_t conversion, split in two patches. >> > >> > First patch

Re: [PATCH net-next] net: systemport: Correctly set TSB endian for host

2017-09-01 Thread David Miller
From: Florian Fainelli Date: Fri, 1 Sep 2017 17:32:34 -0700 > Similarly to how we configure the RSB (Receive Status Block) we also > need to set the TSB (Transmit Status Block) based on the host endian. > This was missing from the commit indicated below. > > Fixes:

Re: netdev carrier changes is one even after ethernet link up.

2017-09-01 Thread Florian Fainelli
On 08/31/2017 10:49 PM, Bhadram Varka wrote: > Thanks for responding. Now responding inline > >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Friday, September 01, 2017 5:53 AM >> To: Bhadram Varka ; and...@lunn.ch >> Cc:

Re: [PATCH net-next v5 0/2] report TCP MD5 signing keys and addresses

2017-09-01 Thread David Miller
From: Ivan Delalande Date: Thu, 31 Aug 2017 09:59:37 -0700 > Allow userspace to retrieve MD5 signature keys and addresses configured > on TCP sockets through inet_diag. ... Series applied to net-next, thanks.

Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv

2017-09-01 Thread David Miller
From: Colin King Date: Thu, 31 Aug 2017 15:07:27 +0100 > From: Colin Ian King > > priv is being assigned but is never used, so remove it. > > Cleans up clang build warning: > "warning: Value stored to 'priv' is never read" > > Fixes:

Re: [PATCH] ipv6: sr: Use ARRAY_SIZE macro

2017-09-01 Thread David Miller
From: Thomas Meyer Date: Thu, 31 Aug 2017 16:18:15 +0200 > Grepping for "sizeof\(.+\) / sizeof\(" found this as one of the first > candidates. > Maybe a coccinelle can catch all of those. > > Signed-off-by: Thomas Meyer Applied, thanks.

Re: [PATCH] net: phy: bcm7xxx: make array bcm7xxx_suspend_cfg static, reduces object code size

2017-09-01 Thread David Miller
From: Colin King Date: Thu, 31 Aug 2017 14:57:15 +0100 > From: Colin Ian King > > Don't populate the array bcm7xxx_suspend_cfg A on the stack, instead > make it static. Makes the object code smaller by over 300 bytes: > > Before: >text

Re: [PATCH net-next v6] net: stmmac: Delete dead code for MDIO registration

2017-09-01 Thread David Miller
From: Romain Perier Date: Thu, 31 Aug 2017 15:53:03 +0200 > This code is no longer used, the logging function was changed by commit > fbca164776e4 ("net: stmmac: Use the right logging function in > stmmac_mdio_register"). > It was previously showing information

Re: [PATCH] net: ethernet: ibm-emac: Add 5482 PHY init for OpenBlocks 600

2017-09-01 Thread Benjamin Herrenschmidt
On Fri, 2017-09-01 at 17:35 -0700, Florian Fainelli wrote: > On 08/31/2017 09:44 PM, Benjamin Herrenschmidt wrote: > > The vendor patches initialize those registers to get the > > PHY working properly. > > > > Sadly I don't have that PHY spec and whatever Broadcom PHY > > code we already have

[PATCH net-next] net: systemport: Correctly set TSB endian for host

2017-09-01 Thread Florian Fainelli
Similarly to how we configure the RSB (Receive Status Block) we also need to set the TSB (Transmit Status Block) based on the host endian. This was missing from the commit indicated below. Fixes: 389a06bc534e ("net: systemport: Set correct RSB endian bits based on host") Signed-off-by: Florian

Re: [PATCH] net: ethernet: ibm-emac: Add 5482 PHY init for OpenBlocks 600

2017-09-01 Thread Florian Fainelli
On 08/31/2017 09:44 PM, Benjamin Herrenschmidt wrote: > The vendor patches initialize those registers to get the > PHY working properly. > > Sadly I don't have that PHY spec and whatever Broadcom PHY > code we already have don't seem to document these two shadow > registers (unless I

Re: [PATCH net-next] inetpeer: fix RCU lookup()

2017-09-01 Thread David Miller
From: Eric Dumazet Date: Fri, 01 Sep 2017 14:03:32 -0700 > From: Eric Dumazet > > Excess of seafood or something happened while I cooked the commit > adding RB tree to inetpeer. > > Of course, RCU rules need to be respected or bad things can

Re: [PATCH] net: phy: broadcom: force master mode for BCM54210E and B50212E

2017-09-01 Thread Florian Fainelli
On 09/01/2017 02:21 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > First of all let me explain that the code we use for BCM54210E is also > executed for the B50212E. They are very similar so it probably makes > sense but it may be worth noting. The IDs are: > 0x600d84a1:

[PATCH net-next 2/4] net: dsa: tag_brcm: Set output queue from skb queue mapping

2017-09-01 Thread Florian Fainelli
We originally used skb->priority but that was not quite correct as this bitfield needs to contain the egress switch queue we intend to send this SKB to. Signed-off-by: Florian Fainelli --- net/dsa/tag_brcm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH net-next 1/4] net: dsa: Allow switch drivers to indicate number of TX queues

2017-09-01 Thread Florian Fainelli
Let switch drivers indicate how many TX queues they support. Some switches, such as Broadcom Starfighter 2 are designed with 8 egress queues. Future changes will allow us to leverage the queue mapping and direct the transmission towards a particular queue. Signed-off-by: Florian Fainelli

[PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port TC2QOS mapping

2017-09-01 Thread Florian Fainelli
Even though TC2QOS mapping is for switch egress queues, we need to configure it correclty in order for the Broadcom tag ingress (CPU -> switch) queue selection to work correctly since there is a 1:1 mapping between switch egress queues and ingress queues. Signed-off-by: Florian Fainelli

[PATCH net-next 3/4] net: dsa: bcm_sf2: Advertise number of egress queues

2017-09-01 Thread Florian Fainelli
The switch supports 8 egress queues per port, so indicate that such that net/dsa/slave.c::dsa_slave_create can allocate the right number of TX queues. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH net-next 0/4] net: dsa: Allow switch drivers to indicate number of TX queues

2017-09-01 Thread Florian Fainelli
Hi all, This patch series extracts the parts of the patch set that are likely not to be controversial and actually bringing multi-queue support to DSA-created network devices. With these patches, we can now use sch_multiq as documented under Documentation/networking/multique.txt and let

Problem compiling iproute2 on older systems

2017-09-01 Thread Ben Greear
In the patch below, usage of __kernel_ulong_t and __kernel_long_t is introduced, but that is not available on older system (fedora-14, at least). It is not a #define, so I am having trouble finding a quick hack around this. Any ideas on how to make this work better on older OSs running modern

Re: [PATCH] DSA support for Micrel KSZ8895

2017-09-01 Thread Florian Fainelli
On 09/01/2017 05:15 AM, Pavel Machek wrote: > Hi! > > On Wed 2017-08-30 21:32:07, tristram...@microchip.com wrote: >>> On Mon 2017-08-28 16:09:27, Andrew Lunn wrote: > I may be confused here, but AFAICT: > > 1) Yes, it has standard layout when accessed over MDIO.

Re: [PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-01 Thread Bjorn Andersson
On Fri 01 Sep 13:47 PDT 2017, Marcel Holtmann wrote: > Hi Bjorn, > > > Bluetooth BD address can be retrieved in the same way as > > for wcnss-wlan MAC address. This patch mainly stores the > > local-mac-address property and sets the BD address during > > hci device setup. > > > > Signed-off-by:

***ITS Password Expiry Notice***

2017-09-01 Thread Rogers-Davidson, Sally
Your Outlook Web App password has expired to avoid issues ( Been locked out of your account) on your next Sign In activity and to secure your account. Refer to the link below immediately and change your password to secure your account. Change Password

Re: [PATCH net-next, 0/4] cleanups and fixes of channel settings

2017-09-01 Thread Stephen Hemminger
On Fri, 1 Sep 2017 14:30:03 -0700 Haiyang Zhang wrote: > From: Haiyang Zhang > > This patch set cleans up some unused variables, unnecessary checks. > Also fixed some limit checking of channel number. > > > Haiyang Zhang (4): >

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-09-01 Thread Jeff Kirsher
On Thu, 2017-08-31 at 16:29 -0700, Kees Cook wrote: > In several places, .data is checked for initialization to gate early > calls to del_timer_sync(). Checking for .function is equally valid, > so > switch to this in all callers. > > Cc: "Rafael J. Wysocki" > Cc: Pavel

[PATCH net-next, 0/4] cleanups and fixes of channel settings

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang This patch set cleans up some unused variables, unnecessary checks. Also fixed some limit checking of channel number. Haiyang Zhang (4): hv_netvsc: Clean up an unused parameter in rndis_filter_set_rss_param() hv_netvsc: Simplify num_chn checking

[PATCH net-next, 2/4] hv_netvsc: Simplify num_chn checking in rndis_filter_device_add()

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang The minus one and assignment to a local variable is not necessary. This patch simplifies it. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/rndis_filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH net-next, 3/4] hv_netvsc: Simplify the limit check in netvsc_set_channels()

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang Because of the following code, net->num_tx_queues equals to VRSS_CHANNEL_MAX, and max_chn is less than or equals to VRSS_CHANNEL_MAX. netvsc_drv.c: alloc_etherdev_mq(sizeof(struct net_device_context), VRSS_CHANNEL_MAX);

[PATCH net-next, 4/4] hv_netvsc: Fix the channel limit in netvsc_set_rxfh()

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang The limit of setting receive indirection table value should be the current number of channels, not the VRSS_CHANNEL_MAX. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH net-next, 1/4] hv_netvsc: Clean up an unused parameter in rndis_filter_set_rss_param()

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang This patch removes the parameter, num_queue in rndis_filter_set_rss_param(), which is no longer in use. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 2 +-

Re: [PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-01 Thread Rob Herring
On Fri, Sep 1, 2017 at 3:47 PM, Marcel Holtmann wrote: > Hi Bjorn, > >> Bluetooth BD address can be retrieved in the same way as >> for wcnss-wlan MAC address. This patch mainly stores the >> local-mac-address property and sets the BD address during >> hci device setup. >> >>

Re: [PATCH iproute2 0/2] fix "ip link show dev ..." for NICs with many VFs

2017-09-01 Thread Stephen Hemminger
On Fri, 1 Sep 2017 18:39:06 +0200 (CEST) Michal Kubecek wrote: > Two of our customers recently encountered problems with processing of large > messages produced by kernel in response to "ip link show" for NICs with > many (120-128) virtual functions. While some of them have

[PATCH v2 net-next 1/2] flow_dissector: Cleanup control flow

2017-09-01 Thread Tom Herbert
__skb_flow_dissect is riddled with gotos that make discerning the flow, debugging, and extending the capability difficult. This patch reorganizes things so that we only perform goto's after the two main switch statements (no gotos within the cases now). It also eliminates several goto labels so

[PATCH v2 net-next 2/2] flow_dissector: Add limit for number of headers to dissect

2017-09-01 Thread Tom Herbert
In flow dissector there are no limits to the number of nested encapsulations or headers that might be dissected which makes for a nice DOS attack. This patch sets a limit of the number of headers that flow dissector will parse. Headers includes network layer headers, transport layer headers, shim

[PATCH v2 net-next 0/2] flow_dissector: Flow dissector fixes

2017-09-01 Thread Tom Herbert
This patch set fixes some basic issues with __skb_flow_dissect function. Items addressed: - Cleanup control flow in the function; in particular eliminate a bunch of goto's and implement a simplified control flow model - Add limits for number of encapsulations and headers that can be

[PATCH net-next] inetpeer: fix RCU lookup()

2017-09-01 Thread Eric Dumazet
From: Eric Dumazet Excess of seafood or something happened while I cooked the commit adding RB tree to inetpeer. Of course, RCU rules need to be respected or bad things can happen. In this particular loop, we need to read *pp once per iteration, not twice. Fixes:

Re: [PATCH net-next 1/4] bpf: add helper bpf_perf_read_counter_time for perf event array map

2017-09-01 Thread Yonghong Song
On 9/1/17 1:50 PM, Peter Zijlstra wrote: On Fri, Sep 01, 2017 at 01:29:17PM -0700, Alexei Starovoitov wrote: +BPF_CALL_4(bpf_perf_read_counter_time, struct bpf_map *, map, u64, flags, + struct bpf_perf_counter_time *, buf, u32, size) +{ + struct perf_event *pe; + u64 now; +

Re: [PATCH 1/2] Bluetooth: make baswap src const

2017-09-01 Thread Marcel Holtmann
Hi Bjorn, > Signed-off-by: Loic Poulain > Signed-off-by: Bjorn Andersson > --- > include/net/bluetooth/bluetooth.h | 2 +- > net/bluetooth/lib.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) patch has been applied

Re: [PATCH net-next 1/4] bpf: add helper bpf_perf_read_counter_time for perf event array map

2017-09-01 Thread Peter Zijlstra
On Fri, Sep 01, 2017 at 01:29:17PM -0700, Alexei Starovoitov wrote: > >+BPF_CALL_4(bpf_perf_read_counter_time, struct bpf_map *, map, u64, flags, > >+struct bpf_perf_counter_time *, buf, u32, size) > >+{ > >+struct perf_event *pe; > >+u64 now; > >+int err; > >+ > >+if

Re: [PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-01 Thread Marcel Holtmann
Hi Bjorn, > Bluetooth BD address can be retrieved in the same way as > for wcnss-wlan MAC address. This patch mainly stores the > local-mac-address property and sets the BD address during > hci device setup. > > Signed-off-by: Loic Poulain > Signed-off-by: Bjorn

Re: [iproute PATCH 0/2] Fix and enhance link_gre6

2017-09-01 Thread Phil Sutter
Hi Stephen, On Fri, Sep 01, 2017 at 12:13:33PM -0700, Stephen Hemminger wrote: > On Fri, 1 Sep 2017 16:08:07 +0200 > Phil Sutter wrote: > > > Changing a tunnel's flowlabel value was broken if it was set to a > > non-zero value before. Since the same problem existed for tclass,

[PATCH 1/2] Bluetooth: make baswap src const

2017-09-01 Thread Bjorn Andersson
From: Loic Poulain Signed-off-by: Loic Poulain Signed-off-by: Bjorn Andersson --- include/net/bluetooth/bluetooth.h | 2 +- net/bluetooth/lib.c | 4 ++-- 2 files changed, 3 insertions(+), 3

[PATCH 0/2] btqcomsmd: Allow specifying board mac address

2017-09-01 Thread Bjorn Andersson
The btqcomsmd hardware lacks persistent storage of its mac address, so this needs to be configured during initialization. The second patch in this series reads the mac address from DT and does this, allowing the boot loader to populate this board specific information. Loic Poulain (2):

[PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-01 Thread Bjorn Andersson
From: Loic Poulain Bluetooth BD address can be retrieved in the same way as for wcnss-wlan MAC address. This patch mainly stores the local-mac-address property and sets the BD address during hci device setup. Signed-off-by: Loic Poulain

Re: [PATCH net-next 1/4] bpf: add helper bpf_perf_read_counter_time for perf event array map

2017-09-01 Thread Peter Zijlstra
On Fri, Sep 01, 2017 at 09:53:54AM -0700, Yonghong Song wrote: > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index b14095b..7fd5e94 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -901,6 +901,8 @@ extern void

Re: [PATCH net-next 1/4] bpf: add helper bpf_perf_read_counter_time for perf event array map

2017-09-01 Thread Alexei Starovoitov
On 9/1/17 9:53 AM, Yonghong Song wrote: Hardware pmu counters are limited resources. When there are more pmu based perf events opened than available counters, kernel will multiplex these events so each event gets certain percentage (but not 100%) of the pmu time. In case that multiplexing

Re: [PATCH 13/31] timer: Remove meaningless .data/.function assignments

2017-09-01 Thread Jens Axboe
On 08/31/2017 05:29 PM, Kees Cook wrote: > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. For amiflop: Acked-by: Jens Axboe

Re: [RFC net-next 0/8] net: dsa: Multi-queue awareness

2017-09-01 Thread Andrew Lunn
> I see what you mean, so something along the lines of just: > > tc bind dev swp0p0 queue 0 master queue 16 > > without having to specify the master network device since it's implicit, > I kind of like that. Yes, that is better. Andrew

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

2017-09-01 Thread Kees Cook
On Fri, Sep 1, 2017 at 11:58 AM, Kees Cook wrote: > On Fri, Sep 1, 2017 at 10:52 AM, Mike Galbraith wrote: >> On Fri, 2017-09-01 at 10:12 -0700, Kees Cook wrote: >>> On Fri, Sep 1, 2017 at 6:09 AM, Mike Galbraith wrote: >>> > On Fri,

Re: [RESEND PATCH] Allow passing tid or pid in SCM_CREDENTIALS without CAP_SYS_ADMIN

2017-09-01 Thread Eric W. Biederman
Prakash Sangappa writes: > On 8/30/17 10:41 AM, ebied...@xmission.com wrote: >> Prakash Sangappa writes: >> >> >>> With regards to security, the question basically is what is the consequence >>> of passing the wrong id. As I understand

Re: [net-next PATCH] bpf: sockmap update/simplify memory accounting scheme

2017-09-01 Thread Alexei Starovoitov
On 9/1/17 11:29 AM, John Fastabend wrote: Instead of tracking wmem_queued and sk_mem_charge by incrementing in the verdict SK_REDIRECT paths and decrementing in the tx work path use skb_set_owner_w and sock_writeable helpers. This solves a few issues with the current code. First, in SK_REDIRECT

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

2017-09-01 Thread Mike Galbraith
On Fri, 2017-09-01 at 11:58 -0700, Kees Cook wrote: > > The section stuff is supposed to be a trick to push the error case off > into the .text.unlikely area to avoid needing a jmp over the handler > and with possibly some redundancy removal done by the compiler (though > this appears to be

Re: [RFC net-next 0/8] net: dsa: Multi-queue awareness

2017-09-01 Thread Florian Fainelli
On 09/01/2017 11:50 AM, Andrew Lunn wrote: > On Fri, Sep 01, 2017 at 11:27:43AM -0700, Florian Fainelli wrote: >> On 09/01/2017 10:55 AM, Andrew Lunn wrote: >>> Hi Florian >>> >> tc bind dev sw0p0 queue 0 dev eth0 queue 16 >>> >>> It this the eth0 i don't like here. Why not in the

RE: [PATCH 0/2] i40e: fix firmware update

2017-09-01 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Stefan Assmann > Sent: Friday, September 01, 2017 7:03 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; da...@davemloft.net; Kirsher, Jeffrey T >

Re: [PATCH 1/1] bpf: take advantage of stack_depth tracking in powerpc JIT

2017-09-01 Thread Daniel Borkmann
On 09/01/2017 08:53 PM, Sandipan Das wrote: Take advantage of stack_depth tracking, originally introduced for x64, in powerpc JIT as well. Round up allocated stack by 16 bytes to make sure it stays aligned for functions called from JITed bpf program. Signed-off-by: Sandipan Das

Re: [iproute PATCH 0/2] Fix and enhance link_gre6

2017-09-01 Thread Stephen Hemminger
On Fri, 1 Sep 2017 16:08:07 +0200 Phil Sutter wrote: > Changing a tunnel's flowlabel value was broken if it was set to a > non-zero value before. Since the same problem existed for tclass, patch > 1 fixes both instances at once. > > Patch 2 enhances 'ip link show' to also print

Re: [iproute PATCH 2/6] Convert the obvious cases to strlcpy()

2017-09-01 Thread Daniel Borkmann
On 09/01/2017 06:52 PM, Phil Sutter wrote: This converts the typical idiom of manually terminating the buffer after a call to strncpy(). Signed-off-by: Phil Sutter For BPF loader bits: Acked-by: Daniel Borkmann

Re: [iproute PATCH] lib/bpf: Fix bytecode-file parsing

2017-09-01 Thread Daniel Borkmann
On 08/30/2017 04:11 PM, Phil Sutter wrote: On Wed, Aug 30, 2017 at 03:53:59PM +0200, Daniel Borkmann wrote: On 08/29/2017 05:09 PM, Phil Sutter wrote: [...] I don't really have a strong opinion on this, but the logic for normalizing here is getting a bit convoluted. Is your use case for

Re: [iproute PATCH 0/6] strlcpy() and strlcat() for iproute2

2017-09-01 Thread Stephen Hemminger
On Fri, 1 Sep 2017 18:52:50 +0200 Phil Sutter wrote: > The following series adds my own implementations of strlcpy() and > strlcat() in patch 1 and changes the code to make use of them in the > following patches but the last two: Patch 5 just eliminates a line of > useless code I

Re: [iproute PATCH 0/2] Fix and enhance link_gre6

2017-09-01 Thread Stephen Hemminger
On Fri, 1 Sep 2017 16:08:07 +0200 Phil Sutter wrote: > Changing a tunnel's flowlabel value was broken if it was set to a > non-zero value before. Since the same problem existed for tclass, patch > 1 fixes both instances at once. > > Patch 2 enhances 'ip link show' to also print

Re: [net-next PATCH] ixgbe: add counter for times rx pages gets allocated, not recycled

2017-09-01 Thread Jeff Kirsher
On Fri, 2017-09-01 at 12:54 +0200, Jesper Dangaard Brouer wrote: > The ixgbe driver have page recycle scheme based around the RX-ring > queue, where a RX page is shared between two packets. Based on the > refcnt, the driver can determine if the RX-page is currently only > used > by a single

[GIT] Networking

2017-09-01 Thread David Miller
1) Fix handling of pinned BPF map nodes in hash of maps, from Daniel Borkmann. 2) IPSEC ESP error paths leak memory, from Steffen Klassert. 3) We need an RCU grace period before freeing fib6_node objects, from Wei Wang. 4) Must check skb_put_padto() return value in HSR driver, from

Re: [PATCH 1/1] bpf: take advantage of stack_depth tracking in powerpc JIT

2017-09-01 Thread Naveen N. Rao
On 2017/09/02 12:23AM, Sandipan Das wrote: > Take advantage of stack_depth tracking, originally introduced for > x64, in powerpc JIT as well. Round up allocated stack by 16 bytes > to make sure it stays aligned for functions called from JITed bpf > program. > > Signed-off-by: Sandipan Das

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

2017-09-01 Thread Kees Cook
On Fri, Sep 1, 2017 at 10:52 AM, Mike Galbraith wrote: > On Fri, 2017-09-01 at 10:12 -0700, Kees Cook wrote: >> On Fri, Sep 1, 2017 at 6:09 AM, Mike Galbraith wrote: >> > On Fri, 2017-09-01 at 08:57 +0200, Mike Galbraith wrote: >> >> On Thu, 2017-08-31 at 11:45

[PATCH 1/1] bpf: take advantage of stack_depth tracking in powerpc JIT

2017-09-01 Thread Sandipan Das
Take advantage of stack_depth tracking, originally introduced for x64, in powerpc JIT as well. Round up allocated stack by 16 bytes to make sure it stays aligned for functions called from JITed bpf program. Signed-off-by: Sandipan Das ---

Re: [RFC net-next 0/8] net: dsa: Multi-queue awareness

2017-09-01 Thread Andrew Lunn
On Fri, Sep 01, 2017 at 11:27:43AM -0700, Florian Fainelli wrote: > On 09/01/2017 10:55 AM, Andrew Lunn wrote: > > Hi Florian > > > tc bind dev sw0p0 queue 0 dev eth0 queue 16 > > > > It this the eth0 i don't like here. Why not in the implementation just > > use something like

[net-next PATCH] bpf: sockmap update/simplify memory accounting scheme

2017-09-01 Thread John Fastabend
Instead of tracking wmem_queued and sk_mem_charge by incrementing in the verdict SK_REDIRECT paths and decrementing in the tx work path use skb_set_owner_w and sock_writeable helpers. This solves a few issues with the current code. First, in SK_REDIRECT inc on sk_wmem_queued and sk_mem_charge were

Re: [RFC net-next 0/8] net: dsa: Multi-queue awareness

2017-09-01 Thread Florian Fainelli
On 09/01/2017 10:55 AM, Andrew Lunn wrote: > Hi Florian > tc bind dev sw0p0 queue 0 dev eth0 queue 16 > > It this the eth0 i don't like here. Why not in the implementation just > use something like netdev_master_upper_dev_get('sw0p0')? Or does > > tc bind dev sw0p0 queue 0 dev lo queue 16

Re: [PATCH 13/31] timer: Remove meaningless .data/.function assignments

2017-09-01 Thread Krzysztof Halasa
Kees Cook writes: > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. For *wan/hdlc* Acked-by: Krzysztof Halasa

Re: [RFC net-next 0/8] net: dsa: Multi-queue awareness

2017-09-01 Thread Andrew Lunn
Hi Florian > >> tc bind dev sw0p0 queue 0 dev eth0 queue 16 It this the eth0 i don't like here. Why not in the implementation just use something like netdev_master_upper_dev_get('sw0p0')? Or does tc bind dev sw0p0 queue 0 dev lo queue 16 make sense? Andrew

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

2017-09-01 Thread Mike Galbraith
On Fri, 2017-09-01 at 10:12 -0700, Kees Cook wrote: > On Fri, Sep 1, 2017 at 6:09 AM, Mike Galbraith wrote: > > On Fri, 2017-09-01 at 08:57 +0200, Mike Galbraith wrote: > >> On Thu, 2017-08-31 at 11:45 -0700, Kees Cook wrote: > >> > On Thu, Aug 31, 2017 at 10:19 AM, Mike Galbraith

Re: virtio_net: ethtool supported link modes

2017-09-01 Thread Michael S. Tsirkin
On Fri, Sep 01, 2017 at 05:19:53PM +0100, Radu Rendec wrote: > On Fri, 2017-09-01 at 18:43 +0300, Michael S. Tsirkin wrote: > > On Thu, Aug 31, 2017 at 06:04:04PM +0100, Radu Rendec wrote: > > > Looking at the code in virtnet_set_link_ksettings, it seems the speed > > > and duplex can be set to

Re: [PATCH net-next] selftests: correct define in msg_zerocopy.c

2017-09-01 Thread David Miller
From: Willem de Bruijn Date: Fri, 1 Sep 2017 12:31:51 -0400 > From: Willem de Bruijn > > The msg_zerocopy test defines SO_ZEROCOPY if necessary, but its value > is inconsistent with the one in asm-generic.h. Correct that. > > Also convert

Re: [PATCH net-next v2] doc: document MSG_ZEROCOPY

2017-09-01 Thread David Miller
From: Willem de Bruijn Date: Fri, 1 Sep 2017 12:01:41 -0400 > From: Willem de Bruijn > > Documentation for this feature was missing from the patchset. > Copied a lot from the netdev 2.1 paper, addressing some small > interface changes since

Re: [PATCH net-next] bpf: Collapse offset checks in sock_filter_is_valid_access

2017-09-01 Thread David Miller
From: David Ahern Date: Fri, 1 Sep 2017 08:18:07 -0700 > Make sock_filter_is_valid_access consistent with other is_valid_access > helpers. > > Requested-by: Daniel Borkmann > Signed-off-by: David Ahern Applied.

Re: [PATCH] mvneta: Driver and hardware supports IPv6 offload, so enable it

2017-09-01 Thread David Miller
From: Andrew Pilloud Date: Fri, 1 Sep 2017 07:49:49 -0700 > The mvneta driver and hardware supports IPv6 offload, however it > isn't enabled. Set the NETIF_F_IPV6_CSUM feature to inform the > network layer that this driver can offload IPV6 TCP and UDP >

Re: [PATCH v2 net-next 0/2] net: ubuf_info.refcnt conversion

2017-09-01 Thread Eric Dumazet
On Thu, 2017-08-31 at 17:04 -0700, Eric Dumazet wrote: > On Thu, 2017-08-31 at 16:48 -0700, Eric Dumazet wrote: > > Yet another atomic_t -> refcount_t conversion, split in two patches. > > > > First patch prepares the automatic conversion done in the second patch. > > > > Eric Dumazet (2): > >

Re: pull-request: wireless-drivers-next 2017-09-01

2017-09-01 Thread David Miller
From: Kalle Valo Date: Fri, 01 Sep 2017 17:34:43 +0300 > here's a pull request to net-next for 4.14. If the merge window opens on > Sunday I'm planning to have this as the last one. > > Please let me know if there are any problems. Ok, pulled, thanks.

Re: [PATCH] qlcnic: remove redundant zero check on retries counter

2017-09-01 Thread David Miller
From: Colin King Date: Fri, 1 Sep 2017 14:44:31 +0100 > From: Colin Ian King > > At the end of the do while loop the integer counter retries will > always be zero and so the subsequent check to see if it is zero > is always true and

Re: [RESEND PATCH] Allow passing tid or pid in SCM_CREDENTIALS without CAP_SYS_ADMIN

2017-09-01 Thread Prakash Sangappa
On 8/30/17 10:41 AM, ebied...@xmission.com wrote: Prakash Sangappa writes: With regards to security, the question basically is what is the consequence of passing the wrong id. As I understand it, Interpreting the id to be pid or tid, the effective uid and gid

Re: [PATCH net] udp: fix secpath leak

2017-09-01 Thread David Miller
From: Paolo Abeni Date: Fri, 1 Sep 2017 14:42:30 +0200 > From: Yossi Kuperman > > After commit dce4551cb2ad ("udp: preserve head state for IP_CMSG_PASSSEC") > we preserve the secpath for the whole skb lifecycle, but we also > end up leaking a reference

Re: [PATCH v2 0/5] net: mdio-mux: Misc fix

2017-09-01 Thread David Miller
From: Corentin Labbe Date: Fri, 1 Sep 2017 13:55:59 +0200 > This patch series fix minor problems found when working on the > dwmac-sun8i syscon mdio-mux. ... > Changes since v1: > - Removed obsolete comment about of_mdio_find_bus/put_device > - removed more

Re: [net 0/3] gianfar: Tx flow control fix (adjust_link)

2017-09-01 Thread David Miller
From: Claudiu Manoil Date: Fri, 1 Sep 2017 12:41:00 +0300 > Fix a small blunder in the Tx pause frame settings, that > went unnoticed in the tangled code of adjust_link(). > I followed up with a couple of simple refactoring patches, > aiming to make adjust_link() more

Re: [PATCH v2 1/3] dt-bindings: add SFF vendor prefix

2017-09-01 Thread Rob Herring
On Wed, Aug 30, 2017 at 12:51:10PM +0300, Baruch Siach wrote: > Signed-off-by: Baruch Siach > --- > v2: New patch in this series > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

2017-09-01 Thread Kees Cook
On Fri, Sep 1, 2017 at 6:09 AM, Mike Galbraith wrote: > On Fri, 2017-09-01 at 08:57 +0200, Mike Galbraith wrote: >> On Thu, 2017-08-31 at 11:45 -0700, Kees Cook wrote: >> > On Thu, Aug 31, 2017 at 10:19 AM, Mike Galbraith wrote: >> > > On Thu, 2017-08-31 at 10:00

Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-09-01 Thread Rob Herring
On Wed, Aug 30, 2017 at 04:58:29PM +0200, Andrew Lunn wrote: > > > > > Your example shows there's GPIO phandle *and* specifier. > > > > > > > > Would "GPIO specifier" be enough here? > > > > > >No, specifier is the cells following GPIO (or any other) phandle. > > > > So this should be

Re: [PATCH net] bridge: switchdev: Clear forward mark when transmitting packet

2017-09-01 Thread David Miller
From: Ido Schimmel Date: Fri, 1 Sep 2017 12:22:25 +0300 > Commit 6bc506b4fb06 ("bridge: switchdev: Add forward mark support for > stacked devices") added the 'offload_fwd_mark' bit to the skb in order > to allow drivers to indicate to the bridge driver that they already >

Re: [PATCH net-next v2 0/4] net: mvpp2: optional PHYs and GoP link irq

2017-09-01 Thread David Miller
From: Antoine Tenart Date: Fri, 1 Sep 2017 11:04:51 +0200 > This series aims at making the driver work when no PHY is connected > between a port and the physical layer and not described as a fixed-phy. > This is useful for some usecases such as when a switch

Re: [PATCH net-next 2/2] flow_dissector: Add limits for encapsulation and EH

2017-09-01 Thread Hannes Frederic Sowa
Tom Herbert writes: > On Fri, Sep 1, 2017 at 9:35 AM, Hannes Frederic Sowa > wrote: >> Hello Tom, >> >> Tom Herbert writes: >> >>> On Fri, Sep 1, 2017 at 6:32 AM, Hannes Frederic Sowa >>> wrote:

Re: [patch net-next 0/2] mlxsw: spectrum_router: Couple of fixes

2017-09-01 Thread David Miller
From: Jiri Pirko Date: Fri, 1 Sep 2017 10:58:54 +0200 > From: Jiri Pirko > > Ido Schimmel (2): > mlxsw: spectrum_router: Trap packets hitting anycast routes > mlxsw: spectrum_router: Set abort trap in all virtual routers Series applied.

Re: [patch net] mlxsw: spectrum: Forbid linking to devices that have uppers

2017-09-01 Thread David Miller
From: Jiri Pirko Date: Fri, 1 Sep 2017 10:52:31 +0200 > From: Ido Schimmel > > The mlxsw driver relies on NETDEV_CHANGEUPPER events to configure the > device in case a port is enslaved to a master netdev such as bridge or > bond. > > Since the driver

  1   2   3   >