Re: [PATCH] Documentation: networking: fix ASCII art in switchdev.txt

2017-09-16 Thread Andrew Lunn
On Sat, Sep 16, 2017 at 01:10:06PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix ASCII art in Documentation/networking/switchdev.txt: > > Change non-ASCII "spaces" to ASCII spaces. > > Change 2 erroneous '+' characters in ASCII art to '-' (at the '*' >

Re: [PATCH] Documentation: networking: fix ASCII art in switchdev.txt

2017-09-16 Thread Pavel Machek
On Sat 2017-09-16 13:10:06, Randy Dunlap wrote: > From: Randy Dunlap > > Fix ASCII art in Documentation/networking/switchdev.txt: > > Change non-ASCII "spaces" to ASCII spaces. > > Change 2 erroneous '+' characters in ASCII art to '-' (at the '*' > characters below): >

[PATCH] Documentation: networking: fix ASCII art in switchdev.txt

2017-09-16 Thread Randy Dunlap
From: Randy Dunlap Fix ASCII art in Documentation/networking/switchdev.txt: Change non-ASCII "spaces" to ASCII spaces. Change 2 erroneous '+' characters in ASCII art to '-' (at the '*' characters below): line 32: +--++++-*--++---+

Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Randy Dunlap
On 09/16/17 11:18, Andreas Schwab wrote: > On Sep 16 2017, Pavel Machek wrote: > >> diff --git a/Documentation/networking/switchdev.txt >> b/Documentation/networking/switchdev.txt >> index 5e40e1f..6309e90 100644 >> --- a/Documentation/networking/switchdev.txt >> +++

Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Pavel Machek
On Sat 2017-09-16 20:18:15, Andreas Schwab wrote: > On Sep 16 2017, Pavel Machek wrote: > > > diff --git a/Documentation/networking/switchdev.txt > > b/Documentation/networking/switchdev.txt > > index 5e40e1f..6309e90 100644 > > --- a/Documentation/networking/switchdev.txt > > +++

Re: Use after free in __dst_destroy_metrics_generic

2017-09-16 Thread Cong Wang
On Sat, Sep 16, 2017 at 5:40 AM, Julian Anastasov wrote: > > Hello, > > On Fri, 15 Sep 2017, Subash Abhinov Kasiviswanathan wrote: > >> > May be I'm missing some posting but I don't see if >> > the patch was tested successfully. >> > >> Hi Julian >> >> I've had this patch

Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Andreas Schwab
On Sep 16 2017, Pavel Machek wrote: > diff --git a/Documentation/networking/switchdev.txt > b/Documentation/networking/switchdev.txt > index 5e40e1f..6309e90 100644 > --- a/Documentation/networking/switchdev.txt > +++ b/Documentation/networking/switchdev.txt > @@ -29,7 +29,7 @@

Re: Use after free in __dst_destroy_metrics_generic

2017-09-16 Thread Cong Wang
On Fri, Sep 15, 2017 at 2:00 PM, Eric Dumazet wrote: > > Hi Cong > > I believe your patch makes a lot of sense, please submit it formally ? > I have been waiting for Subash's testing, since I myself never even run it.

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

2017-09-16 Thread Larry Finger
On 09/16/2017 06:27 AM, Zwindl wrote: Hi, I've done the test, and the weird thing happened. The kernel buit with this config file https://ptpb.pw/HF1g which is from https://aur.archlinux.org/packages/linux-git/  can run properly, the wifi can connect, despite which version it is, but, with

Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Andrew Lunn
On Sat, Sep 16, 2017 at 06:22:17PM +0200, Pavel Machek wrote: > > Fix ascii-art. > > Signed-off-by: Pavel Machek > > --- > > Resent, because I did not get DaveM's address right. > > diff --git a/Documentation/networking/switchdev.txt > b/Documentation/networking/switchdev.txt

[GIT] Networking

2017-09-16 Thread David Miller
1) Fix hotplug deadlock in hv_netvsc, from Stephen Hemminger. 2) Fix double-free in rmnet driver, from Dan Carpenter. 3) INET connection socket layer can double put request sockets, fix from Eric Dumazet. 4) Don't match collect metadata-mode tunnels if the device is down, from Haishuang

Re: [patch net] mlxsw: spectrum_router: Only handle IPv4 and IPv6 events

2017-09-16 Thread David Miller
From: Jiri Pirko Date: Fri, 15 Sep 2017 15:31:07 +0200 > From: Ido Schimmel > > The driver doesn't support events from address families other than IPv4 > and IPv6, so ignore them. Otherwise, we risk queueing a work item before > it's initialized. > >

[PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Pavel Machek
Fix ascii-art. Signed-off-by: Pavel Machek --- Resent, because I did not get DaveM's address right. diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index 5e40e1f..6309e90 100644 --- a/Documentation/networking/switchdev.txt +++

Re: [PATCH] Documentation: link in networking docs

2017-09-16 Thread David Miller
From: Pavel Machek Date: Sat, 16 Sep 2017 16:28:02 +0200 > Fix link in filter.txt. > > Acked-by: Pavel Machek Applied, thanks Pavel.

Re: [PATCH net] tcp: fix data delivery rate

2017-09-16 Thread David Miller
From: Eric Dumazet Date: Fri, 15 Sep 2017 16:47:42 -0700 > From: Eric Dumazet > > Now skb->mstamp_skb is updated later, we also need to call > tcp_rate_skb_sent() after the update is done. > > Fixes: 8c72c65b426b ("tcp: update skb->skb_mstamp more

[PATCH net] driver: e1000: fix race condition between e1000_down() and e1000_watchdog

2017-09-16 Thread Vincenzo Maffione
This patch fixes a race condition that can result into the interface being up and carrier on, but with transmits disabled in the hardware. The bug may show up by repeatedly IFF_DOWN+IFF_UP the interface, which allows e1000_watchdog() interleave with e1000_down(). CPU x

[PATCH] mwifiex: make const arrays static to shink object code size

2017-09-16 Thread Colin King
From: Colin Ian King Don't populate const arrays on the stack, instead make them static Makes the object code smaller by nearly 300 bytes: Before: textdata bss dec hex filename 69260 16149 576 85985 14fe1 cfg80211.o After: text

[PATCH] Documentation: link in networking docs

2017-09-16 Thread Pavel Machek
Fix link in filter.txt. Acked-by: Pavel Machek diff --git a/Documentation/networking/filter.txt b/Documentation/networking/filter.txt index e5e33ba..789b74d 100644 --- a/Documentation/networking/filter.txt +++ b/Documentation/networking/filter.txt @@ -45,7 +45,7 @@ in many more

[PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-16 Thread Vincent Bernat
Currently, when an interface is released from a bridge via ioctl(), we get a RTM_DELLINK event through netlink: Deleted 2: dummy0: mtu 1500 master bridge0 state UNKNOWN link/ether 6e:23:c2:54:3a:b3 Userspace has to interpret that as a removal from the bridge,

RE: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Joe Perches > Sent: Saturday, September 16, 2017 06:18 > To: Ying Xue ; Thomas Meyer > ; Jon Maloy ; >

Re: Use after free in __dst_destroy_metrics_generic

2017-09-16 Thread Julian Anastasov
Hello, On Fri, 15 Sep 2017, Subash Abhinov Kasiviswanathan wrote: > > May be I'm missing some posting but I don't see if > > the patch was tested successfully. > > > Hi Julian > > I've had this patch being tested for the last 3-4 days in our regression rack > and I haven't seen

[PATCH net] net/sched: cls_matchall: fix crash when used with classful qdisc

2017-09-16 Thread Davide Caratti
this script, edited from Linux Advanced Routing and Traffic Control guide tc q a dev en0 root handle 1: htb default a tc c a dev en0 parent 1: classid 1:1 htb rate 6mbit burst 15k tc c a dev en0 parent 1:1 classid 1:a htb rate 5mbit ceil 6mbit burst 15k tc c a dev en0 parent 1:1 classid 1:b htb

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Joe Perches
On Sat, 2017-09-16 at 18:10 +0800, Ying Xue wrote: > On 09/16/2017 05:58 PM, Joe Perches wrote: > > On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote: > > > On 09/16/2017 05:26 PM, Joe Perches wrote: > > > > On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: > > > > > On 09/16/2017 03:50 PM,

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Ying Xue
On 09/16/2017 05:58 PM, Joe Perches wrote: > On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote: >> On 09/16/2017 05:26 PM, Joe Perches wrote: >>> On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: On 09/16/2017 03:50 PM, Thomas Meyer wrote: > Use common library function rather than

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Joe Perches
On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote: > On 09/16/2017 05:26 PM, Joe Perches wrote: > > On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: > > > On 09/16/2017 03:50 PM, Thomas Meyer wrote: > > > > Use common library function rather than explicitly coding > > > > some variant of it

Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket

2017-09-16 Thread Thomas Gleixner
On Fri, 8 Sep 2017, Eric Dumazet wrote: > On Fri, 2017-09-08 at 11:55 -0700, Eduardo Valentin wrote: > > Hello, > > > > On Fri, Sep 08, 2017 at 10:26:45AM -0700, David Miller wrote: > > > From: David Woodhouse > > > Date: Fri, 08 Sep 2017 18:23:22 +0100 > > > > > > > I

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Ying Xue
On 09/16/2017 05:26 PM, Joe Perches wrote: > On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: >> On 09/16/2017 03:50 PM, Thomas Meyer wrote: >>> Use common library function rather than explicitly coding >>> some variant of it yourself. >>> >>> Signed-off-by: Thomas Meyer >> >>

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Joe Perches
On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: > On 09/16/2017 03:50 PM, Thomas Meyer wrote: > > Use common library function rather than explicitly coding > > some variant of it yourself. > > > > Signed-off-by: Thomas Meyer > > Acked-by: Ying Xue

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Ying Xue
On 09/16/2017 03:50 PM, Thomas Meyer wrote: > Use common library function rather than explicitly coding > some variant of it yourself. > > Signed-off-by: Thomas Meyer Acked-by: Ying Xue > --- > net/tipc/name_table.c | 30 +++---

[PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Thomas Meyer
Use common library function rather than explicitly coding some variant of it yourself. Signed-off-by: Thomas Meyer --- net/tipc/name_table.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) V2: Coding style diff --git

Re: [Outreachy kernel] [PATCH] Staging: irda: Use !x instead of NULL comparison

2017-09-16 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > Test for NULL as !x where functions that return NULL on failure > are used. Done using the following semantic patch by coccinelle. > > @ is_null @ > expression E; > statement S; > @@ > > E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| >

[PATCH] Staging: irda: Use !x instead of NULL comparison

2017-09-16 Thread Srishti Sharma
Test for NULL as !x where functions that return NULL on failure are used. Done using the following semantic patch by coccinelle. @ is_null @ expression E; statement S; @@ E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); ( if(!E)

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-16 Thread Florian Fainelli
On September 15, 2017 5:38:42 PM PDT, ros...@gmail.com wrote: >I have not. Unfortunately I own no gigabit hardware to test this on. >The MIPS CPU runs at 300MHz on my unit. > bgmac is used on Gigabit capable hardware, like Northstar and Northstar Plus, and others too, so unless you can get