Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match

2017-10-03 Thread Shmulik Ladkani
Hi David, On Tue, 03 Oct 2017 14:54:18 -0700 (PDT) David Miller wrote: > I don't see any inconsistency. When you insert using NLM_F_EXCL the > insertion fails if any existing rule matches or overlaps in any way > with the keys in the new rule. Please note that current

Re: [PATCH net-next 1/2] tcp: uniform the set up of sockets after successful connection

2017-10-03 Thread Wei Wang
On Tue, Oct 3, 2017 at 9:28 PM, David Miller wrote: > From: Wei Wang > Date: Mon, 2 Oct 2017 10:01:35 -0700 > >> @@ -456,6 +456,19 @@ void tcp_init_sock(struct sock *sk) >> } >> EXPORT_SYMBOL(tcp_init_sock); >> >> +void tcp_init_transfer(struct sock

[PATCH net-next v4 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu ---

[PATCH net-next v4 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but

[PATCH net-next v4 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge/br_device.c

[PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing

Re: [v2] cdc-ether: divorce initialisation with a filter reset and a generic method

2017-10-03 Thread Vignesh R
On Tuesday 03 October 2017 10:29 PM, David Miller wrote: > From: Vignesh R > Date: Tue, 3 Oct 2017 13:39:18 +0530 > >> Hi Dave, >> >> On Monday 22 May 2017 06:20 PM, Oliver Neukum wrote: >>> Some devices need their multicast filter reset but others are crashed by >>> that.

[PATCH net-next 2/7] net: Add extack to ndo_add_slave

2017-10-03 Thread David Ahern
Pass extack to do_set_master and down to ndo_add_slave Signed-off-by: David Ahern --- drivers/net/bonding/bond_main.c| 5 +++-- drivers/net/bonding/bond_options.c | 2 +- drivers/net/team/team.c| 3 ++- drivers/net/vrf.c | 3 ++-

[PATCH net-next 1/7] net: Add extack to netdev_notifier_info

2017-10-03 Thread David Ahern
Add netlink_ext_ack to netdev_notifier_info to allow notifier handlers to return errors to userspace. Clean up the initialization in dev.c such that extack is easily added in subsequent patches where relevant. Specifically, remove the init call in call_netdevice_notifiers_info and have callers

[PATCH net-next 5/7] net: bonding: Add extack messages for some enslave failures

2017-10-03 Thread David Ahern
A number of bond_enslave errors are logged using the netdev_err API. Return those messages to userspace via the extack facility. Signed-off-by: David Ahern --- drivers/net/bonding/bond_main.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH net-next 4/7] net: vrf: Add extack messages for enslave errors

2017-10-03 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/vrf.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 77d0655a0250..0b54f553228e 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -772,8 +772,11

[PATCH net-next 3/7] net: Add extack to upper device linking

2017-10-03 Thread David Ahern
Add extack arg to netdev_upper_dev_link and netdev_master_upper_dev_link Signed-off-by: David Ahern --- drivers/net/bonding/bond_main.c| 7 --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 2 +- drivers/net/hyperv/netvsc_drv.c

[PATCH net-next 0/7] net: Plumb extack error reporting to enslavements

2017-10-03 Thread David Ahern
Another round of extending extack error reporting, this time for enslavements through ndo_add_slave and notifiers. David Ahern (7): net: Add extack to netdev_notifier_info net: Add extack to ndo_add_slave net: Add extack to upper device linking net: vrf: Add extack messages for enslave

[PATCH net-next 7/7] mlxsw: spectrum: Add extack messages for enslave failures

2017-10-03 Thread David Ahern
mlxsw fails device enslavement for a number of reasons. Use the extack facility to return an error message to the user stating why the enslave is failing. Messages are prefixed with "spectrum" so users know it is a constraint imposed by the hardware driver. For example: $ ip li add br0.11

[PATCH net-next 6/7] net: bridge: Pass extack to down to netdev_master_upper_dev_link

2017-10-03 Thread David Ahern
Pass extack arg to br_add_if. Add messages for a couple of failures and pass arg to netdev_master_upper_dev_link. Signed-off-by: David Ahern --- net/bridge/br_device.c | 2 +- net/bridge/br_if.c | 15 +++ net/bridge/br_ioctl.c | 2 +-

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-03 Thread Toshiaki Makita
On 2017/10/04 1:42, Ido Schimmel wrote: > On Tue, Oct 03, 2017 at 12:25:08PM -0400, Vivien Didelot wrote: >> Andrew Lunn writes: >> The vlan will be effective only when vlan_filtering is enabled. When vlan_filtering is disabled, vlan information is still kept in the

Re: [PATCH 5/5] VSOCK: add tools/vsock/vsock_diag_test

2017-10-03 Thread David Miller
From: Stefan Hajnoczi Date: Tue, 3 Oct 2017 11:39:43 -0400 > MAINTAINERS | 1 + > tools/vsock/Makefile | 9 + > tools/vsock/control.h | 13 + > tools/vsock/timeout.h | 14 + > tools/vsock/control.c | 219

Re: [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-03 Thread Roopa Prabhu
On Tue, Oct 3, 2017 at 11:29 AM, Stephen Hemminger wrote: > On Tue, 3 Oct 2017 11:21:14 -0700 > Roopa Prabhu wrote: > >> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c >> index 48fb174..7a50dc5 100644 >> ---

Re: [PATCH 4/5] VSOCK: add sock_diag interface

2017-10-03 Thread David Miller
From: Stefan Hajnoczi Date: Tue, 3 Oct 2017 11:39:42 -0400 > +static int sk_diag_fill(struct sock *sk, struct sk_buff *skb, > + u32 portid, u32 seq, u32 flags) > +{ > + struct nlmsghdr *nlh; > + struct vsock_diag_msg *rep; > + struct

Re: [PATCH 2/5] VSOCK: export __vsock_in_bound/connected_table()

2017-10-03 Thread David Miller
From: Stefan Hajnoczi Date: Tue, 3 Oct 2017 11:39:40 -0400 > @@ -250,15 +250,17 @@ static struct sock > *__vsock_find_connected_socket(struct sockaddr_vm *src, > return NULL; > } > > -static bool __vsock_in_bound_table(struct vsock_sock *vsk) > +bool

Re: [PATCH] fsl/fman: remove of_node

2017-10-03 Thread David Miller
From: Madalin-cristian Bucur Date: Tue, 3 Oct 2017 08:49:31 + > My patch removes the of_node that was set to a device that was not an > of_device, preventing duplicated probing of both the real of_device > and the "fake" one created through this assignment. > > I

[PATCH net-next v3 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing

[PATCH net-next v3 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but

[PATCH net-next v3 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge/br_device.c

[PATCH net-next v3 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu ---

Re: [PATCH net-next] cxgb4: add new T6 pci device id's

2017-10-03 Thread David Miller
From: Ganesh Goudar Date: Tue, 3 Oct 2017 11:10:53 +0530 > Add 0x6085 T6 device id. > > Signed-off-by: Ganesh Goudar Applied, thank you.

Re: [PATCH RESEND net 0/9] Fixes, cleanup and modernization for some legacy ethernet NIC drivers

2017-10-03 Thread David Miller
From: Finn Thain Date: Mon, 2 Oct 2017 21:07:17 -0400 (EDT) > This patch series fixes some logging bugs and adds some missing message > severity levels. > > There are also cleanup patches for dead code and some Kconfig cruft. > > Custom debug message logging is

Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match

2017-10-03 Thread David Ahern
On 10/3/17 8:58 PM, Eyal Birger wrote: > Hi David, > > On Wed, Oct 4, 2017 at 12:54 AM, David Miller wrote: >> From: Shmulik Ladkani >> Date: Sat, 30 Sep 2017 11:59:09 +0300 >> >>> This leads to inconsistencies, depending on order of operations, e.g.: >> >>

Re: [PATCH net-next v2 0/3] tools: add bpftool

2017-10-03 Thread David Miller
From: Jakub Kicinski Date: Mon, 2 Oct 2017 16:11:27 -0700 > Hi! > > This set adds bpftool to the tools/ directory. The first > patch renames tools/net to tools/bpf, the second one adds > the new code, while the third adds simple documentation. > > v2: > -

Re: [PATCH net-next 1/2] tcp: uniform the set up of sockets after successful connection

2017-10-03 Thread David Miller
From: Wei Wang Date: Mon, 2 Oct 2017 10:01:35 -0700 > @@ -456,6 +456,19 @@ void tcp_init_sock(struct sock *sk) > } > EXPORT_SYMBOL(tcp_init_sock); > > +void tcp_init_transfer(struct sock *sk, int bpf_op) > +{ > + struct inet_connection_sock *icsk = inet_csk(sk); > + >

Re: [PATCH net-next v2 0/2] libbpf: support more map options

2017-10-03 Thread David Miller
From: Craig Gallek Date: Mon, 2 Oct 2017 12:41:27 -0400 > From: Craig Gallek > > The functional change to this series is the ability to use flags when > creating maps from object files loaded by libbpf. In order to do this, > the first patch updates

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-03 Thread David Miller
From: Santosh Shilimkar Date: Tue, 3 Oct 2017 17:42:39 -0700 > Hi Dave, > > On 10/2/2017 1:30 PM, Santosh Shilimkar wrote: >> On 10/1/2017 10:56 PM, David Miller wrote: >>> From: David Miller > [...] > >>> >>> Actually, reverted, this breaks

Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match

2017-10-03 Thread Eyal Birger
Hi David, On Wed, Oct 4, 2017 at 12:54 AM, David Miller wrote: > From: Shmulik Ladkani > Date: Sat, 30 Sep 2017 11:59:09 +0300 > >> This leads to inconsistencies, depending on order of operations, e.g.: > > I don't see any inconsistency. When you insert

Re: [next-queue PATCH v3 2/4] net/sched: Fix accessing invalid dev_queue

2017-10-03 Thread Eric Dumazet
On Tue, 2017-10-03 at 16:44 -0700, Vinicius Costa Gomes wrote: > From: Jesus Sanchez-Palencia > > In qdisc_alloc() the dev_queue pointer was used without any checks being > performed. If qdisc_create() gets a null dev_queue pointer, it just > passes it along to

Re: [RFC] bpf: remove global verifier state

2017-10-03 Thread Alexei Starovoitov
On Tue, Oct 03, 2017 at 08:24:06PM -0700, Eric Dumazet wrote: > On Tue, 2017-10-03 at 19:52 -0700, Alexei Starovoitov wrote: > > > yep. looks great. > > Please test it and submit officially :) > > The commit aafe6ae9cee3 ("bpf: dynamically allocate digest scratch buffer") > > fixed the other case

Re: [RFC] bpf: remove global verifier state

2017-10-03 Thread Eric Dumazet
On Tue, 2017-10-03 at 19:52 -0700, Alexei Starovoitov wrote: > yep. looks great. > Please test it and submit officially :) > The commit aafe6ae9cee3 ("bpf: dynamically allocate digest scratch buffer") > fixed the other case where we were relying on the above mutex. > The only other spot to be

Re: [RFC] bpf: remove global verifier state

2017-10-03 Thread Alexei Starovoitov
On Tue, Oct 03, 2017 at 05:20:25PM -0700, Jakub Kicinski wrote: > The only global state protected by the verifier lock is > the verifier log. Move that log to struct bpf_verifier_env > and allow verification of multiple programs in parallel. > > Signed-off-by: Jakub Kicinski

[net-next:master 146/148] htmldocs: net/core/dev.c:1306: warning: No description found for parameter 'name'

2017-10-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 26873308b21654b6e0785b9f9e2c5414d37a4c4c commit: 6c5570016b972d9b1f0f6c2dca9cc0422b1f92bf [146/148] net: core: decouple ifalias get/set from rtnl lock reproduce: make htmldocs All warnings (new ones

Re: [PATCH net] RDS: IB: Initialize max_items based on underlying device attributes

2017-10-03 Thread Santosh Shilimkar
Hi Avinash, On 10/3/2017 5:50 PM, Avinash Repaka wrote: Use max_1m_mrs/max_8k_mrs while setting max_items, as the former variables are set based on the underlying device attricutes. s/attricutes/attributes Signed-off-by: Avinash Repaka --- net/rds/ib_rdma.c | 4

[PATCH net] RDS: IB: Initialize max_items based on underlying device attributes

2017-10-03 Thread Avinash Repaka
Use max_1m_mrs/max_8k_mrs while setting max_items, as the former variables are set based on the underlying device attricutes. Signed-off-by: Avinash Repaka --- net/rds/ib_rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rds/ib_rdma.c

Re: [PATCH net-next v2 0/3] tools: add bpftool

2017-10-03 Thread Jakub Kicinski
On Tue, 3 Oct 2017 17:19:42 -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 02, 2017 at 04:11:27PM -0700, Jakub Kicinski escreveu: > > Hi! > > > > This set adds bpftool to the tools/ directory. The first > > patch renames tools/net to tools/bpf, the second one adds > > the new code, while

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-03 Thread Santosh Shilimkar
Hi Dave, On 10/2/2017 1:30 PM, Santosh Shilimkar wrote: On 10/1/2017 10:56 PM, David Miller wrote: From: David Miller [...] Actually, reverted, this breaks the build. net/rds/rdma_transport.c:38:10: fatal error: ib.h: No such file or directory   #include "ib.h"

[next-queue PATCH v4 2/4] net/sched: Fix accessing invalid dev_queue

2017-10-03 Thread Vinicius Costa Gomes
From: Jesus Sanchez-Palencia In qdisc_alloc() the dev_queue pointer was used without any checks being performed. If qdisc_create() gets a null dev_queue pointer, it just passes it along to qdisc_alloc(), leading to a crash. That happens if a root qdisc

[next-queue PATCH v4 3/4] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-10-03 Thread Vinicius Costa Gomes
This queueing discipline implements the shaper algorithm defined by the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. It's primary usage is to apply some bandwidth reservation to user defined traffic classes, which are mapped to different queues via the mqprio qdisc. Initially, it only

[next-queue PATCH v4 0/4] TSN: Add qdisc based config interface for CBS

2017-10-03 Thread Vinicius Costa Gomes
Hi, Changes since v3: - None, only a clean patchset without old patches; Changes since v2: - squashed the patch introducing the userspace API into the patch implementing CBS; Changes since v1: - Solved the mqprio dependency; - Fixed a mqprio bug, that caused the inner qdisc to have a

[next-queue PATCH v4 4/4] igb: Add support for CBS offload

2017-10-03 Thread Vinicius Costa Gomes
From: Andre Guedes This patch adds support for Credit-Based Shaper (CBS) qdisc offload from Traffic Control system. This support enable us to leverage the Forwarding and Queuing for Time-Sensitive Streams (FQTSS) features from Intel i210 Ethernet Controller. FQTSS is the

[next-queue PATCH v4 1/4] mqprio: Implement select_queue class_ops

2017-10-03 Thread Vinicius Costa Gomes
From: Jesus Sanchez-Palencia When replacing a child qdisc from mqprio, tc_modify_qdisc() must fetch the netdev_queue pointer that the current child qdisc is associated with before creating the new qdisc. Currently, when using mqprio as root qdisc, the kernel

[RFC] bpf: remove global verifier state

2017-10-03 Thread Jakub Kicinski
The only global state protected by the verifier lock is the verifier log. Move that log to struct bpf_verifier_env and allow verification of multiple programs in parallel. Signed-off-by: Jakub Kicinski --- Like this? :) Compile-tested, I'm rebasing things and will

Re: [next-queue PATCH v2 3/5] net/sched: Introduce the user API for the CBS shaper

2017-10-03 Thread Vinicius Costa Gomes
Vinicius Costa Gomes writes: > Export the API necessary for configuring the CBS shaper (implemented > in the next patch) via the tc tool. > > Signed-off-by: Vinicius Costa Gomes > --- I forgot to clean old patches from my tree. Does sending a

[next-queue PATCH v2 4/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-10-03 Thread Vinicius Costa Gomes
This queueing discipline implements the shaper algorithm defined by the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. It's primary usage is to apply some bandwidth reservation to user defined traffic classes, which are mapped to different queues via the mqprio qdisc. Initially, it only

[next-queue PATCH v3 0/4] TSN: Add qdisc based config interface for CBS

2017-10-03 Thread Vinicius Costa Gomes
Hi, Changes since v2: - squashed the patch introducing the userspace API into the patch implementing CBS; Changes since v1: - Solved the mqprio dependency; - Fixed a mqprio bug, that caused the inner qdisc to have a wrong dev_queue associated with it; Changes from the RFC: - Fixed

[next-queue PATCH v2 3/5] net/sched: Introduce the user API for the CBS shaper

2017-10-03 Thread Vinicius Costa Gomes
Export the API necessary for configuring the CBS shaper (implemented in the next patch) via the tc tool. Signed-off-by: Vinicius Costa Gomes --- include/uapi/linux/pkt_sched.h | 17 + 1 file changed, 17 insertions(+) diff --git

[next-queue PATCH v3 2/4] net/sched: Fix accessing invalid dev_queue

2017-10-03 Thread Vinicius Costa Gomes
From: Jesus Sanchez-Palencia In qdisc_alloc() the dev_queue pointer was used without any checks being performed. If qdisc_create() gets a null dev_queue pointer, it just passes it along to qdisc_alloc(), leading to a crash. That happens if a root qdisc

[next-queue PATCH v2 5/5] igb: Add support for CBS offload

2017-10-03 Thread Vinicius Costa Gomes
From: Andre Guedes This patch adds support for Credit-Based Shaper (CBS) qdisc offload from Traffic Control system. This support enable us to leverage the Forwarding and Queuing for Time-Sensitive Streams (FQTSS) features from Intel i210 Ethernet Controller. FQTSS is the

[next-queue PATCH v3 3/4] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-10-03 Thread Vinicius Costa Gomes
This queueing discipline implements the shaper algorithm defined by the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. It's primary usage is to apply some bandwidth reservation to user defined traffic classes, which are mapped to different queues via the mqprio qdisc. Initially, it only

[next-queue PATCH v3 1/4] mqprio: Implement select_queue class_ops

2017-10-03 Thread Vinicius Costa Gomes
From: Jesus Sanchez-Palencia When replacing a child qdisc from mqprio, tc_modify_qdisc() must fetch the netdev_queue pointer that the current child qdisc is associated with before creating the new qdisc. Currently, when using mqprio as root qdisc, the kernel

[next-queue PATCH v3 4/4] igb: Add support for CBS offload

2017-10-03 Thread Vinicius Costa Gomes
From: Andre Guedes This patch adds support for Credit-Based Shaper (CBS) qdisc offload from Traffic Control system. This support enable us to leverage the Forwarding and Queuing for Time-Sensitive Streams (FQTSS) features from Intel i210 Ethernet Controller. FQTSS is the

Re: [PATCH net-next v2 00/10] Introduce SCTP Stream Schedulers

2017-10-03 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 3 Oct 2017 19:20:07 -0300 > This patchset introduces the SCTP Stream Schedulers are defined by > https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 > > It provides 3 schedulers at the moment: FCFS, Priority and Round

Re: [net-next 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2017-10-03

2017-10-03 Thread David Miller
From: Jeff Kirsher Date: Tue, 3 Oct 2017 09:31:29 -0700 > This series contains updates to fm10k only. Pulled, thanks Jeff.

Re: [PATCH net] bpf: fix bpf_tail_call() x64 JIT

2017-10-03 Thread David Miller
From: Alexei Starovoitov Date: Tue, 3 Oct 2017 15:37:20 -0700 > - bpf prog_array just like all other types of bpf array accepts 32-bit index. > Clarify that in the comment. > - fix x64 JIT of bpf_tail_call which was incorrectly loading 8 instead of 4 > bytes > - tighten

Re: [PATCH net-next 0/3] A own subdirectory for shared TCP code

2017-10-03 Thread David Miller
From: Richard Sailer Date: Wed, 4 Oct 2017 00:22:10 +0200 > net/ipv4 currently contains around 100 source files containing the > IP implementation and lots of other functionality (UDP, TCP, xfrm, etc.) As someone who has to do backports regularly to -stable,

Re: [PATCH v3 net-next] net: core: decouple ifalias get/set from rtnl lock

2017-10-03 Thread David Miller
From: Florian Westphal Date: Mon, 2 Oct 2017 23:50:05 +0200 > Device alias can be set by either rtnetlink (rtnl is held) or sysfs. > > rtnetlink hold the rtnl mutex, sysfs acquires it for this purpose. > Add an extra mutex for it and use rcu to protect concurrent accesses. > >

Re: [PATCH net] bpf: fix bpf_tail_call() x64 JIT

2017-10-03 Thread Eric Dumazet
On Tue, 2017-10-03 at 15:37 -0700, Alexei Starovoitov wrote: > - bpf prog_array just like all other types of bpf array accepts 32-bit index. > Clarify that in the comment. > - fix x64 JIT of bpf_tail_call which was incorrectly loading 8 instead of 4 > bytes > - tighten corresponding check in

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-03 Thread Marcelo Ricardo Leitner
On Tue, Oct 03, 2017 at 07:33:08PM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Oct 03, 2017 at 10:25:22AM +0800, Jia-Ju Bai wrote: > > The SCTP program may sleep under a spinlock, and the function call path is: > > sctp_generate_t3_rtx_event (acquire the spinlock) > > sctp_do_sm > >

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-03 Thread Marcelo Ricardo Leitner
On Tue, Oct 03, 2017 at 01:26:43PM +0800, Herbert Xu wrote: > On Mon, Oct 02, 2017 at 09:18:24PM -0700, Andy Lutomirski wrote: > > > On Oct 2, 2017, at 7:25 PM, Jia-Ju Bai wrote: > > > > > > The SCTP program may sleep under a spinlock, and the function call path > > > is: >

Re: [PATCH net-next 0/3] A own subdirectory for shared TCP code

2017-10-03 Thread Eric Dumazet
On Wed, 2017-10-04 at 00:22 +0200, Richard Sailer wrote: > net/ipv4 currently contains around 100 source files containing the > IP implementation and lots of other functionality (UDP, TCP, xfrm, etc.) > > # 1/3 > To make the networking source tree more self documenting and well > structured 1/3

Re: [PATCH] net: stmmac: dwmac-rk: Add RK3128 GMAC support

2017-10-03 Thread David Miller
From: David Wu Date: Sat, 30 Sep 2017 17:47:23 +0800 > Add constants and callback functions for the dwmac on rk3128 soc. > As can be seen, the base structure is the same, only registers > and the bits in them moved slightly. > > Signed-off-by: David Wu

[PATCH net] bpf: fix bpf_tail_call() x64 JIT

2017-10-03 Thread Alexei Starovoitov
- bpf prog_array just like all other types of bpf array accepts 32-bit index. Clarify that in the comment. - fix x64 JIT of bpf_tail_call which was incorrectly loading 8 instead of 4 bytes - tighten corresponding check in the interpreter to stay consistent The JIT bug can be triggered after

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-03 Thread Marcelo Ricardo Leitner
On Tue, Oct 03, 2017 at 10:25:22AM +0800, Jia-Ju Bai wrote: > The SCTP program may sleep under a spinlock, and the function call path is: > sctp_generate_t3_rtx_event (acquire the spinlock) > sctp_do_sm > sctp_side_effects > sctp_cmd_interpreter > sctp_make_init_ack >

[PATCH net-next 1/3] net/ipv4: Move shared tcp code to own subdirectory

2017-10-03 Thread Richard Sailer
net/ipv4 contains around 100 source files containing the IP implementation and various other functionality (UDP, TCP, xfrm, etc.). 30 of them make up the TCP implementation. I think moving the TCP implementation to a own subdirectory makes the source tree more explorable and well structured.

[PATCH net-next 2/3] tcp: Move cc algorithms to own subdirectory

2017-10-03 Thread Richard Sailer
Essentially the TCP code files consist of two groups: * main code and some utilities (13 files) * pluggable Congestion Control Algorithms (17 files) Similar to the previous commit, this moves the Congestion control Algorithms to a own subdirecty and updates the Makefiles accordingly to make

[PATCH net-next 3/3] Move shared tcp code to net/ipv4v6shared

2017-10-03 Thread Richard Sailer
Currently a lot of Code shared between IPv4 and IPv6 resides in net/ipv4. As an attempt to make things more modular and encapsulated + the source tree more self documenting this commit: * introduces net/ipv4v6shared * moves the shared tcp code there * updates the makefiles accordingly *

[PATCH net-next 0/3] A own subdirectory for shared TCP code

2017-10-03 Thread Richard Sailer
net/ipv4 currently contains around 100 source files containing the IP implementation and lots of other functionality (UDP, TCP, xfrm, etc.) # 1/3 To make the networking source tree more self documenting and well structured 1/3 moves the 30 shared TCP source files to a own subdirectory of

[PATCH net-next v2 00/10] Introduce SCTP Stream Schedulers

2017-10-03 Thread Marcelo Ricardo Leitner
This patchset introduces the SCTP Stream Schedulers are defined by https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 It provides 3 schedulers at the moment: FCFS, Priority and Round Robin. The other 3, Round Robin per packet, Fair Capacity and Weighted Fair Capacity will be added later.

[PATCH net-next v2 10/10] sctp: introduce round robin stream scheduler

2017-10-03 Thread Marcelo Ricardo Leitner
This patch introduces RFC Draft ndata section 3.2 Priority Based Scheduler (SCTP_SS_RR). Works by maintaining a list of enqueued streams and tracking the last one used to send data. When the datamsg is done, it switches to the next stream. See-also:

[PATCH net-next v2 08/10] sctp: add sockopt to get/set stream scheduler parameters

2017-10-03 Thread Marcelo Ricardo Leitner
As defined per RFC Draft ndata Section 4.3.3, named as SCTP_STREAM_SCHEDULER_VALUE. See-also: https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- include/uapi/linux/sctp.h |

[PATCH net-next v2 03/10] sctp: factor out stream->in allocation

2017-10-03 Thread Marcelo Ricardo Leitner
There is 1 place allocating it and another reallocating. Move such procedures to a common function. v2: updated changelog Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/stream.c | 36

[PATCH net-next v2 06/10] sctp: introduce stream scheduler foundations

2017-10-03 Thread Marcelo Ricardo Leitner
This patch introduces the hooks necessary to do stream scheduling, as per RFC Draft ndata. It also introduces the first scheduler, which is what we do today but now factored out: first come first served (FCFS). With stream scheduling now we have to track which chunk was enqueued on which stream

[PATCH net-next v2 09/10] sctp: introduce priority based stream scheduler

2017-10-03 Thread Marcelo Ricardo Leitner
This patch introduces RFC Draft ndata section 3.4 Priority Based Scheduler (SCTP_SS_PRIO). It works by having a struct sctp_stream_priority for each priority configured. This struct is then enlisted on a queue ordered per priority if, and only if, there is a stream with data queued, so that

[PATCH net-next v2 02/10] sctp: factor out stream->out allocation

2017-10-03 Thread Marcelo Ricardo Leitner
There is 1 place allocating it and 2 other reallocating. Move such procedures to a common function. Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/stream.c | 52 1

[PATCH net-next v2 07/10] sctp: add sockopt to get/set stream scheduler

2017-10-03 Thread Marcelo Ricardo Leitner
As defined per RFC Draft ndata Section 4.3.2, named as SCTP_STREAM_SCHEDULER. See-also: https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- include/uapi/linux/sctp.h | 1 +

[PATCH net-next v2 04/10] sctp: introduce struct sctp_stream_out_ext

2017-10-03 Thread Marcelo Ricardo Leitner
With the stream schedulers, sctp_stream_out will become too big to be allocated by kmalloc and as we need to allocate with BH disabled, we cannot use __vmalloc in sctp_stream_init(). This patch moves out the stats from sctp_stream_out to sctp_stream_out_ext, which will be allocated only when the

[PATCH net-next v2 05/10] sctp: introduce sctp_chunk_stream_no

2017-10-03 Thread Marcelo Ricardo Leitner
Add a helper to fetch the stream number from a given chunk. Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- include/net/sctp/structs.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/sctp/structs.h

[PATCH net-next v2 01/10] sctp: silence warns on sctp_stream_init allocations

2017-10-03 Thread Marcelo Ricardo Leitner
As SCTP supports up to 65535 streams, that can lead to very large allocations in sctp_stream_init(). As Xin Long noticed, systems with small amounts of memory are more prone to not have enough memory and dump warnings on dmesg initiated by user actions. Thus, silence them. Also, if the

Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match

2017-10-03 Thread David Miller
From: Shmulik Ladkani Date: Sat, 30 Sep 2017 11:59:09 +0300 > This leads to inconsistencies, depending on order of operations, e.g.: I don't see any inconsistency. When you insert using NLM_F_EXCL the insertion fails if any existing rule matches or overlaps in any way with the

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-03 Thread Jakub Kicinski
On Tue, 3 Oct 2017 13:05:46 -0700, Matthias Kaehlcke wrote: > nfp_eth_set_bit_config() is marked as __always_inline to allow gcc to > identify the 'mask' parameter as known to be constant at compile time, > which is required to use the FIELD_GET() macro. > > The forced inlining does the trick

Re: [PATCH next] bonding: speed/duplex update at NETDEV_UP event

2017-10-03 Thread David Miller
From: Mahesh Bandewar Date: Wed, 27 Sep 2017 18:03:49 -0700 > From: Mahesh Bandewar > > Some NIC drivers don't have correct speed/duplex settings at the > time they send NETDEV_UP notification and that messes up the > bonding state. Especially 802.3ad

Re: [PATCH] rndis_host: support Novatel Verizon USB730L

2017-10-03 Thread David Miller
From: Bjørn Mork Date: Tue, 03 Oct 2017 16:01:15 +0200 > We can pretty much ignore the USB-IF and any specs, since that is what > the vendors appear to do. They provide device specific drivers for > Windows, so all they care about is that their device "works" with their > driver.

Re: [PATCH net v1 1/2] ARM: dts: imx: let's name the ptp interrupt for the fec ethernet driver

2017-10-03 Thread Andrew Lunn
On Tue, Oct 03, 2017 at 01:41:34PM -0700, Troy Kisky wrote: > On 10/2/2017 5:51 PM, Andrew Lunn wrote: > > On Mon, Oct 02, 2017 at 05:04:41PM -0700, Troy Kisky wrote: > >> imx7s/imx7d has the ptp interrupt newly added as well. > >> This will allow the ptp interrupt to have its own interrupt

Re: [PATCH] bridge: Fix format string for %ul

2017-10-03 Thread Stephen Hemminger
On Fri, 26 Aug 2016 23:10:28 -0400 Oleg Drokin wrote: > %ul would print an unsigned value and a letter l, > likely it was %lu that was meant to print the long int, > but in reality the values printed there are just regular signed > ints, so just dropping the l altogether. >

Re: [PATCH net v1 1/2] ARM: dts: imx: let's name the ptp interrupt for the fec ethernet driver

2017-10-03 Thread Troy Kisky
On 10/2/2017 5:51 PM, Andrew Lunn wrote: > On Mon, Oct 02, 2017 at 05:04:41PM -0700, Troy Kisky wrote: >> imx7s/imx7d has the ptp interrupt newly added as well. >> This will allow the ptp interrupt to have its own interrupt routine. >> >> Signed-off-by: Troy Kisky

Re: [PATCH net-next v2 0/3] tools: add bpftool

2017-10-03 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 02, 2017 at 04:11:27PM -0700, Jakub Kicinski escreveu: > Hi! > > This set adds bpftool to the tools/ directory. The first > patch renames tools/net to tools/bpf, the second one adds > the new code, while the third adds simple documentation. > > v2: > - report names, map ids, load

Re: [RFC 1/2] bpf: move instruction printing into a separate file

2017-10-03 Thread Alexei Starovoitov
On Tue, Oct 03, 2017 at 10:57:45AM -0700, Jakub Kicinski wrote: > Separate the instruction printing into a standalone source file. > This way sneaky code from tools/ can use it directly. > > Signed-off-by: Jakub Kicinski > --- > Like this? ... > +static void

Re: [PATCH net-next 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread kbuild test robot
Hi Roopa, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/bridge-neigh-msg-proxy-and-flood-suppression-support/20171003-124610 config: x86_64-randconfig-i0-10030107 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce

[PATCH] net: 8021q: skip packets if the vlan is down

2017-10-03 Thread Vishakha Narvekar
If the vlan is down, free the packet instead of proceeding with other processing, or counting it as received. If vlan interfaces are used as slaves for bonding, with arp monitoring for connectivity, if the rx counter is seen to be incrementing, then the bond device will not observe that the

[PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-03 Thread Matthias Kaehlcke
nfp_eth_set_bit_config() is marked as __always_inline to allow gcc to identify the 'mask' parameter as known to be constant at compile time, which is required to use the FIELD_GET() macro. The forced inlining does the trick for gcc, but for kernel builds with clang it results in undefined

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

2017-10-03 Thread Kalderon, Michal
From: Leon Romanovsky Sent: Tuesday, October 3, 2017 4:26 PM >On Tue, Oct 03, 2017 at 11:54:56AM +0300, Michal Kalderon wrote: >> For iWARP unaligned MPA flow, a slowpath event of flushing an >> MPA connection that entered an unaligned state is required. >> The flush ramrod is

Re: [RFC 1/2] bpf: move instruction printing into a separate file

2017-10-03 Thread Daniel Borkmann
On 10/03/2017 07:57 PM, Jakub Kicinski wrote: Separate the instruction printing into a standalone source file. This way sneaky code from tools/ can use it directly. Signed-off-by: Jakub Kicinski --- Like this? Looks good to me, yes.

Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-10-03 Thread Tom Herbert
On Tue, Oct 3, 2017 at 12:46 AM, Jiri Pirko wrote: > Fri, Sep 29, 2017 at 07:59:35PM CEST, t...@herbertland.com wrote: >>On Fri, Sep 29, 2017 at 10:42 AM, David Miller wrote: >>> From: Tom Herbert >>> Date: Fri, 29 Sep 2017 08:48:55

Re: [PATCH] net: phy: DP83822 initial driver submission

2017-10-03 Thread Florian Fainelli
On 10/03/2017 11:03 AM, Dan Murphy wrote: > Florian > > Thanks for the review > > On 10/03/2017 12:15 PM, Florian Fainelli wrote: >>> + } else { >>> + value &= ~DP83822_WOL_SECURE_ON; >>> + } >>> + >>> + value |= (DP83822_WOL_EN |

  1   2   3   >