[PATCH net-next 0/3] Fix mlx4 static checker warnings

Hi Dave, This patchset contains fixes for static checker warnings in the mlx4 Core and Eth drivers. Patch 1 fixes an actual bug discovered by the checker. Patches 2 and 3 fix the warnings without functional changes. Series generated against net-next commit: c49c777f9c87 qed: Delete redundant

Re: [pull request][for-next 0/9] Mellanox, mlx5 updates 2017-10-06

On Fri, 2017-10-06 at 16:37 -0700, Saeed Mahameed wrote: > The following changes since commit > e19b205be43d11bff638cad4487008c48d21c103: > > Linux 4.14-rc2 (2017-09-24 16:38:56 -0700) Thanks for keeping the base at rc2 like I requested. Pulled. -- Doug Ledford GPG

Re: [PATCH v2] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

On Mon, Oct 09, 2017 at 02:35:46PM +0200, Daniel Borkmann wrote: > On 10/09/2017 02:27 PM, Shmulik Ladkani wrote: > >From: Shmulik Ladkani > > > >Commit 2c16d6033264 ("netfilter: xt_bpf: support ebpf") introduced > >support for attaching an eBPF object by an fd, with

Re: [net-next V5 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

On 10/09/2017 03:31 PM, Daniel Borkmann wrote: On 10/06/2017 06:12 PM, Jesper Dangaard Brouer wrote: [...] +/* Pre-limit array size based on NR_CPUS, not final CPU check */ +if (cmap->map.max_entries > NR_CPUS) Nit: needs to be >= NR_CPUS. Scratch that comment, you bail out on

Re: [net-next V5 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

On 10/06/2017 06:12 PM, Jesper Dangaard Brouer wrote: [...] +static struct bpf_map *cpu_map_alloc(union bpf_attr *attr) +{ + struct bpf_cpu_map *cmap; + int err = -ENOMEM; err init here is basically not needed since overriden later anyway w/o being read, but ... + u64 cost;

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

On Wed, Oct 04, 2017 at 04:27:04PM -0700, Kees Cook wrote: > Subject: [PATCH 10/13] timer: Remove expires and data arguments from > DEFINE_TIMER > > Drop the arguments from the macro and adjust all callers with the > following script: > > perl -pi -e 's/DEFINE_TIMER\((.*), 0,

Re: [PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER

On Wed, Oct 04, 2017 at 04:27:03PM -0700, Kees Cook wrote: > Subject: [PATCH 09/13] timer: Remove users of expire and data arguments to > DEFINE_TIMER > > The expire and data arguments of DEFINE_TIMER are only used in two places > and are ignored by the code (malta-display.c only uses

[PATCH] thunderbolt: Initialize Thunderbolt bus earlier

The 0day kbuild robot reports following crash: BUG: unable to handle kernel NULL pointer dereference at 0004 IP: tb_property_find+0xe/0x41 *pde = Oops: [#1] CPU: 0 PID: 1 Comm: swapper Not tainted 4.14.0-rc1-00741-ge69b6c0 #412 Hardware name: QEMU Standard PC (i440FX

Re: [PATCH net-next] ipv6: avoid zeroing per cpu data again

On Mon, Oct 09, 2017 at 06:01:37AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > per cpu allocations are already zeroed, no need to clear them again. > > Fixes: d52d3997f843f ("ipv6: Create percpu rt6_info") > Signed-off-by: Eric Dumazet > Cc:

Re: [PATCH net-next] net: mvpp2: phylink support

On Mon, Oct 09, 2017 at 02:55:27PM +0200, Antoine Tenart wrote: > Hi Russell, > > On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > >

[PATCH net-next] ipv6: avoid zeroing per cpu data again

From: Eric Dumazet per cpu allocations are already zeroed, no need to clear them again. Fixes: d52d3997f843f ("ipv6: Create percpu rt6_info") Signed-off-by: Eric Dumazet Cc: Martin KaFai Lau Cc: Tejun Heo ---

[RFC net-next] ppp: allow usage in namespaces

Check for CAP_NET_ADMIN with ns_capable() instead of capable() to allow usage of ppp in user namespace other than the init one. Signed-off-by: Matteo Croce --- drivers/net/ppp/ppp_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next] net: mvpp2: phylink support

Hi Russell, On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > > > > +static int mvpp2_phylink_mac_link_state(struct net_device *dev, > >

[PATCH net] udp: fix bcast packet reception

The commit bc044e8db796 ("udp: perform source validation for mcast early demux") does not take into account that broadcast packets lands in the same code path and they need different checks for the source address - notably, zero source address are valid for bcast and invalid for mcast. As a

Re: [PATCH 2/4] ravb: Add optional PHY reset during system resume

On 10/09/2017 12:37 PM, Sergei Shtylyov wrote: If the optional "reset-gpios" property is specified in DT, the generic MDIO bus code takes care of resetting the PHY during device probe. However, the PHY may still have to be reset explicitly after system resume. This allows to restore Ethernet

Re: [PATCH v2] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

On 10/09/2017 02:27 PM, Shmulik Ladkani wrote: From: Shmulik Ladkani Commit 2c16d6033264 ("netfilter: xt_bpf: support ebpf") introduced support for attaching an eBPF object by an fd, with the 'bpf_mt_check_v1' ABI expecting the '.fd' to be specified upon each

Re: [PATCH v2] netlink: do not set cb_running if dump's start() errs

On Mon, 2017-10-09 at 14:14 +0200, Jason A. Donenfeld wrote: > It turns out that multiple places can call netlink_dump(), which > means > it's still possible to dereference partially initialized values in > dump() that were the result of a faulty returned start(). > > This fixes the issue by

[PATCH v2] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

From: Shmulik Ladkani Commit 2c16d6033264 ("netfilter: xt_bpf: support ebpf") introduced support for attaching an eBPF object by an fd, with the 'bpf_mt_check_v1' ABI expecting the '.fd' to be specified upon each IPT_SO_SET_REPLACE call. However this breaks subsequent

Re: [PATCH] netlink: do not set cb_running if dump's start() errs

Just decided to take another look: On Mon, 2017-10-09 at 13:58 +0200, Johannes Berg wrote: > On Mon, 2017-10-09 at 13:56 +0200, Jason A. Donenfeld wrote: > > > @@ -2266,16 +2266,17 @@ int __netlink_dump_start(struct sock *ssk, > > struct sk_buff *skb, > > cb->min_dump_alloc =

[PATCH v2] netlink: do not set cb_running if dump's start() errs

It turns out that multiple places can call netlink_dump(), which means it's still possible to dereference partially initialized values in dump() that were the result of a faulty returned start(). This fixes the issue by calling start() _before_ setting cb_running to true, so that there's no

Re: [PATCH] netlink: do not set cb_running if dump's start() errs

Hi Johannes, Yes, indeed, and I think that's actually a good thing. It means that the starts aren't ever called in parallel, which could be useful if drivers have any ordering requirements. The change doesn't negatively effect any existing drivers. I'll resubmit with a larger commit message

[PATCH] cdc_ether: flag the u-blox TOBY-L2 and SARA-U2 as wwan

The u-blox TOBY-L2 is a LTE Cat 4 module with HSPA+ and 2G fallback. This module allows switching to different USB profiles with the 'AT+UUSBCONF' command, and provides a ECM network interface when the 'AT+UUSBCONF=2' profile is selected. The u-blox SARA-U2 is a HSPA module with 2G fallback. The

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-09 2:32 GMT+09:00 Joe Perches : > On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote: >> The idea is simple; include necessary headers explicitly. > > Try that for kernel.h > > There's a reason aggregation of #includes is useful. > BTW, talking about , it is too

[PATCH v3 3/3] net: phy: Change error to EINVAL for invalid MAC

Change the return error code to EINVAL if the MAC address is not valid in the set_wol function. Signed-off-by: Dan Murphy --- v3 - No changes made v2 - There was no v1 on this patch this is new. drivers/net/phy/at803x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 2/3] net: phy: DP83822 initial driver submission

Add support for the TI DP83822 10/100Mbit ethernet phy. The DP83822 provides flexibility to connect to a MAC through a standard MII, RMII or RGMII interface. Datasheet: http://www.ti.com/product/DP83822I/datasheet Signed-off-by: Dan Murphy --- v3 - Fixed WoL indication bit

[PATCH v3 1/3] net: phy: Remove TI DP83822 from DP83848 driver

Removing the DP83822 device from the DP83848 to support the TI DP83822 dedicated driver that will initially support WoL settings. Signed-off-by: Dan Murphy --- v3 - No changes made v2 - There was no v1 on this patch this is new. drivers/net/phy/dp83848.c | 3 --- 1 file

Re: [PATCH] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

Hi Shmulik, On 10/09/2017 01:57 PM, Pablo Neira Ayuso wrote: On Mon, Oct 09, 2017 at 01:18:23PM +0200, Pablo Neira Ayuso wrote: On Fri, Oct 06, 2017 at 01:40:13PM -0400, Willem de Bruijn wrote: On Fri, Oct 6, 2017 at 12:02 PM, Shmulik Ladkani wrote: From: Shmulik Ladkani

Re: [PATCH] netlink: do not set cb_running if dump's start() errs

On Mon, 2017-10-09 at 13:56 +0200, Jason A. Donenfeld wrote: > @@ -2266,16 +2266,17 @@ int __netlink_dump_start(struct sock *ssk, > struct sk_buff *skb, > cb->min_dump_alloc = control->min_dump_alloc; > cb->skb = skb; > > + if (cb->start) { > + ret = cb->start(cb); >

Re: [PATCH] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

On Mon, Oct 09, 2017 at 01:18:23PM +0200, Pablo Neira Ayuso wrote: > On Fri, Oct 06, 2017 at 01:40:13PM -0400, Willem de Bruijn wrote: > > On Fri, Oct 6, 2017 at 12:02 PM, Shmulik Ladkani wrote: > > > From: Shmulik Ladkani > > > > > > Commit

[PATCH] netlink: do not set cb_running if dump's start() errs

It turns out that multiple places can call netlink_dump(), which means it's still possible to dereference partially initialized values in dump() that were the result of a faulty returned start(). This fixes the issue by calling start() _before_ setting cb_running to true, so that there's no

Re: [PATCH] netlink: do not set cb_running if dump's start() errs

Dave - this very likely should be queued up for stable. Jason

Re: netlink backwards compatibility in userspace tools

Hi Dave, That seems wise. Thanks for the advice. A more sophisticated way of approaching this would be for the kernel to also send a bitmap of which attributes are "critical" and only warn (or even error) of _those_ are not understood. But that seems needlessly complex, and so I think I'll go

Re: [PATCH] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

On Fri, Oct 06, 2017 at 01:40:13PM -0400, Willem de Bruijn wrote: > On Fri, Oct 6, 2017 at 12:02 PM, Shmulik Ladkani wrote: > > From: Shmulik Ladkani > > > > Commit 2c16d6033264 ("netfilter: xt_bpf: support ebpf") introduced > > support for attaching

Re: [PATCH v3] netfilter: SYNPROXY: fix process non tcp packet bug in {ipv4,ipv6}_synproxy_hook

On Fri, Oct 06, 2017 at 12:44:03AM +0800, Lin Zhang wrote: > In function {ipv4,ipv6}_synproxy_hook we expect a normal tcp packet, > but the real server maybe reply an icmp error packet related to the > exist tcp conntrack, so we will access wrong tcp data. > > For fix it, check for the protocol

Re: [patch net-next v2 1/5] net: bridge: Notify on bridge device mrouter state changes

On 09/10/17 12:15, Jiri Pirko wrote: > From: Yotam Gigi > > Add the SWITCHDEV_ATTR_ID_BRIDGE_MROUTER switchdev notification type, used > to indicate whether the bridge is or isn't mrouter. Notify when the bridge > changes its state, similarly to the already existing bridged

Re: [patch net-next v2 2/5] net: bridge: Export bridge multicast router state

On 9.10.2017 11:15, Jiri Pirko wrote: > From: Yotam Gigi > > Add an access function that, given a bridge netdevice, returns whether the > bridge device is currently an mrouter or not. The function uses the already > existing br_multicast_is_router function to check that. >

Re: [patch net-next v2 1/5] net: bridge: Notify on bridge device mrouter state changes

On 9.10.2017 11:15, Jiri Pirko wrote: > From: Yotam Gigi > > Add the SWITCHDEV_ATTR_ID_BRIDGE_MROUTER switchdev notification type, used > to indicate whether the bridge is or isn't mrouter. Notify when the bridge > changes its state, similarly to the already existing bridged

Re: [PATCH 41/47] netfilter: convert hook list to an array

On 09/10/2017 12:31 PM, Florian Westphal wrote: Tariq Toukan wrote: On 04/09/2017 1:42 AM, Pablo Neira Ayuso wrote: From: Aaron Conole This converts the storage and layout of netfilter hook entries from a linked list to an array. After this

[PATCH v3 net-next 05/12] qed: Add the source of a packet sent on an iWARP ll2 connection

When a packet is sent back to iWARP FW via the tx ll2 connection the FW needs to know the source of the packet. Whether it is OOO or unaligned MPA related. Since OOO is implemented entirely inside the ll2 code (and shared with iSCSI), packets are marked as IN_ORDER inside the ll2 code. For

[PATCH v3 net-next 09/12] qed: Add unaligned and packed packet processing

The fpdu data structure is preallocated per connection. Each connection stores the current status of the connection: either nothing pending, or there is a partial fpdu that is waiting for the rest of the fpdu (incomplete bytes != 0). The same structure is also used for splitting a packet when

[PATCH v3 net-next 10/12] qed: Add support for freeing two ll2 buffers for corner cases

When posting a packet on the ll2 tx, we can provide a cookie that will be returned upon tx completion. This cookie is the ll2 iwarp buffer which is then reposted to the rx ring. Part of the unaligned mpa flow is determining when a buffer can be reposted. Each buffer needs to be sent only once as a

[PATCH v3 net-next 11/12] qed: Add support for MPA header being split over two tcp packets

There is a special case where an MPA header is split over to tcp packets, in this case we need to wait for the next packet to get the fpdu length. We use the incomplete_bytes to mark this fpdu as a "special" one which requires updating the length with the next packet Signed-off-by: Michal

[PATCH v3 net-next 12/12] qed: Add iWARP support for fpdu spanned over more than two tcp packets

We continue to maintain a maximum of three buffers per fpdu, to ensure that there are enough buffers for additional unaligned mpa packets. To support this, if a fpdu is split over more than two tcp packets, we use an intermediate buffer to copy the data to the previous buffer, then we can release

[PATCH v3 net-next 08/12] qed: Add mpa buffer descriptors for storing and processing mpa fpdus

The mpa buff is a descriptor for iwarp ll2 buffers that contains additional information required for aligining fpdu's. In some cases, an additional packet will arrive which will complete the alignment of a fpdu, but we won't be able to post the fpdu due to insufficient place on the tx ring. In

[PATCH v3 net-next 07/12] qed: Add ll2 connection for processing unaligned MPA packets

This patch adds only the establishment and termination of the ll2 connection that handles unaligned MPA packets. Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 65

[PATCH v3 net-next 03/12] qed: Add ll2 option for dropping a tx packet

The option of sending a packet on the ll2 and dropping it exists in hardware and was not used until now, thus not exposed. The iWARP unaligned MPA flow requires this functionality for flushing the tx queue. Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior

[PATCH v3 net-next 06/12] qed: Add LL2 slowpath handling

For iWARP unaligned MPA flow, a slowpath event of flushing an MPA connection that entered an unaligned state is required. The flush ramrod is received on the ll2 queue, and a pre-registered callback function is called to handle the flush event. Signed-off-by: Michal Kalderon

[PATCH v3 net-next 04/12] qed: Fix initialization of ll2 offload feature

enable_ip_cksum, enable_l4_cksum, calc_ip_len were added in commit stated below but not passed through to FW. This was OK until now as it wasn't used, but is required for the iWARP unaligned flow Fixes:7c7973b2ae27 ("qed: LL2 to use packed information for tx") Signed-off-by: Michal Kalderon

[PATCH v3 net-next 01/12] qed: Add ll2 option to limit the number of bds per packet

iWARP uses 3 ll2 connections, the maximum number of bds is known during connection setup. This patch modifies the static array in the ll2_tx_packet descriptor to be a flexible array and significantlly reduces memory size. In addition, some redundant fields in the ll2_tx_packet were removed, which

[PATCH v3 net-next 02/12] qed: Add ll2 ability of opening a secondary queue

When more than one ll2 queue is opened ( that is not an OOO queue ) ll2 code does not have enough information to determine whether the queue is the main one or not, so a new field is added to the acquire input data to expose the control of determining whether the queue is the main queue or a

[PATCH v3 net-next 00/12] qed: Add iWARP support for unaligned MPA packets

This patch series adds support for handling unaligned MPA packets. (FPDUs split over more than one tcp packet). When FW detects a packet is unaligned it fowards the packet to the driver via a light l2 dedicated connection. The driver then stores this packet until the remainder of the packet is

Re: [PATCH 2/4] ravb: Add optional PHY reset during system resume

Hello! On 10/1/2017 7:34 PM, Florian Fainelli wrote: If the optional "reset-gpios" property is specified in DT, the generic MDIO bus code takes care of resetting the PHY during device probe. However, the PHY may still have to be reset explicitly after system resume. This allows to restore

Re: [PATCH 41/47] netfilter: convert hook list to an array

Tariq Toukan wrote: > On 04/09/2017 1:42 AM, Pablo Neira Ayuso wrote: > >From: Aaron Conole > > > >This converts the storage and layout of netfilter hook entries from a > >linked list to an array. After this commit, hook entries will be > >stored

Re: RIF/VRF overflow in spectrum and reporting errors back to user

Hi David, On Sun, Oct 08, 2017 at 02:10:33PM -0600, David Ahern wrote: > Jiri / Ido: > > I am looking at adding user messages for spectrum failures related to > RIF and VRF overflow coming from the inetaddr and inet6addr notifier > paths. The key is that if the notifiers fail the address add

RE: [PATCH v1 RFC 1/7] Replace license with GPL

From: tristram...@microchip.com > Sent: 06 October 2017 21:33 > Replace license with GPL. Don't you need permission from all the people who have updated the files in order to make this change? David

[patch net-next v2 2/5] net: bridge: Export bridge multicast router state

From: Yotam Gigi Add an access function that, given a bridge netdevice, returns whether the bridge device is currently an mrouter or not. The function uses the already existing br_multicast_is_router function to check that. This function is needed in order to allow ports

[patch net-next v2 0/5] mlxsw: Offload bridge device mrouter

From: Jiri Pirko Yotam says: Similarly to a bridged port, the bridge device itself can be configured by the user to be an mrouter port. In this case, all multicast traffic should be forwarded to it. Make the mlxsw Spectrum driver offload these directives to the Spectrum

[patch net-next v2 4/5] mlxsw: spectrum_switchdev: Add support for router port in SMID entries

From: Yotam Gigi In Spectrum, MDB entries point to MID entries, that indicate which ports a packet should be forwarded to. Add the support in creating MID entries that forward the packet to the Spectrum router port. This will be later used to handle the bridge mrouter port

[patch net-next v2 5/5] mlxsw: spectrum_switchdev: Support bridge mrouter notifications

From: Yotam Gigi Support the SWITCHDEV_ATTR_ID_BRIDGE_MROUTER port attribute switchdev notification. To do that, add the mrouter flag to struct mlxsw_sp_bridge_device, which indicates whether the bridge device was set to be mrouter port. This field is set when: - A new

RE: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

From: Kees Cook > Sent: 06 October 2017 20:40 ... > I'm in no rush for any specific change. There are about 900 call sites > I'm making my way through, about 2/3rd are pretty trivial, and the > less obvious is what I've started sending out now, since I expect some > will need some more careful

[patch net-next v2 1/5] net: bridge: Notify on bridge device mrouter state changes

From: Yotam Gigi Add the SWITCHDEV_ATTR_ID_BRIDGE_MROUTER switchdev notification type, used to indicate whether the bridge is or isn't mrouter. Notify when the bridge changes its state, similarly to the already existing bridged port mrouter notifications. The notification

[patch net-next v2 3/5] mlxsw: spectrum: router: Export the mlxsw_sp_router_port function

From: Yotam Gigi In Spectrum hardware, the router port is a virtual port that is the gateway to the routing mechanism. Hence, in order for a packet to be L3 forwarded, it must first be L2 forwarded to the router port inside the hardware. Further patches in this patchset are

RE: [net-next 14/15] i40e: ignore skb->xmit_more when deciding to set RS bit

From: Jeff Kirsher > Sent: 06 October 2017 18:57 > From: Jacob Keller > > Since commit 6a7fded776a7 ("i40e: Fix RS bit update in Tx path and > disable force WB workaround") we've tried to "optimize" setting the > RS bit based around skb->xmit_more. This same logic was

Re: [PATCH net] net: enable interface alias removal via rtnl

Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : > > > On 10/06/2017 08:18 PM, David Ahern wrote: >> On 10/5/17 4:19 AM, Nicolas Dichtel wrote: >>> IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of >>> the attribute is 1 ("\0"). However, to remove an alias, the attribute

Re: [PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver

Hello Tristram, in previous version I see that transit traffic (ping) goes to cpu, then from cpu back to destination port. I.e. it works but with cpu involving. Is this version supposed to work like that? Thank you, Maxim. 2017-10-06 23:33 GMT+03:00 : > From:

Re: [PATCH net-next v11] openvswitch: enable NSH support

On Tue, Oct 03, 2017 at 03:13:08AM +0800, Jiri Benc wrote: > On Fri, 29 Sep 2017 15:03:30 +0800, Yi Yang wrote: > > --- a/include/net/nsh.h > > +++ b/include/net/nsh.h > > @@ -304,4 +304,7 @@ static inline void nsh_set_flags_ttl_len(struct nshhdr > > *nsh, u8 flags, > >

Re: [PATCH net-next 0/7] nfp: extend match and action for flower offload

On Fri, Oct 06, 2017 at 08:34:59AM -0700, Tom Herbert wrote: > Simon, > > Maybe a bit off topic, but I had the impression netronome would > support BPF so that filters could be programmed for arbitrary > protocols and fields. Is that true? If so, what is the relationship > between that

pull-request: mac80211 2017-10-09

Hi Dave, The QCA folks found another netlink problem - we were missing validation of some attributes. It's not super problematic since one can only read a few bytes beyond the message (and that memory must exist), but here's the fix for it. I thought perhaps we can make nla_parse_nested()

[PATCH 1/4] xfrm: Fix deletion of offloaded SAs on failure.

When we off load a SA, it gets pushed to the NIC before we can add it. In case of a failure, we don't delete this SA from the NIC. Fix this by calling xfrm_dev_state_delete on failure. Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API") Reported-by: Shannon Nelson

pull request (net): ipsec 2017-10-09

1) Fix some error paths of the IPsec offloading API. 2) Fix a NULL pointer dereference when IPsec is used with vti. From Alexey Kodanev. 3) Don't call xfrm_policy_cache_flush under xfrm_state_lock, it triggers several locking warnings. From Artem Savkov. Please pull or let me know if

[PATCH 4/4] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock

From: Artem Savkov I might be wrong but it doesn't look like xfrm_state_lock is required for xfrm_policy_cache_flush and calling it under this lock triggers both "sleeping function called from invalid context" and "possible circular locking dependency detected" warnings on

[PATCH 3/4] vti: fix NULL dereference in xfrm_input()

From: Alexey Kodanev Can be reproduced with LTP tests: # icmp-uni-vti.sh -p ah -a sha256 -m tunnel -S fffe -k 1 -s 10 IPv4: RIP: 0010:xfrm_input+0x7f9/0x870 ... Call Trace: vti_input+0xaa/0x110 [ip_vti] ? skb_free_head+0x21/0x40 vti_rcv+0x33/0x40

[PATCH 2/4] xfrm: Fix negative device refcount on offload failure.

Reset the offload device at the xfrm_state if the device was not able to offload the state. Otherwise we drop the device refcount twice. Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API") Reported-by: Shannon Nelson Signed-off-by: Steffen Klassert

Re: [PATCH] mac80211: aead api to reduce redundancy

On Sun, 2017-10-08 at 01:43 -0400, Xiang Gao wrote: > > By the way, I'm still struggling on how to run unit tests. It might > take time for me to make it run on my machine. I can run it easily, so don't worry about it too much. Running it is of course much appreciated, but I don't really want to

[PATCH net-next 1/7] net: hns3: Cleanup for shifting true in hns3 driver

This patch fixes a shifting true in hclge_main module. Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

[PATCH net-next 0/7] A few cleanup for hns3 ethernet driver

This patchset contains a few cleanup for hns3 ethernet driver. No functional change intended. Yunsheng Lin (7): net: hns3: Cleanup for shifting true in hns3 driver net: hns3: Add hns3_get_handle macro in hns3 driver net: hns3: Cleanup indentation for Kconfig in the the hisilicon folder

[PATCH net-next 2/7] net: hns3: Add hns3_get_handle macro in hns3 driver

There are many places that will need to get the handle of netdev, so add a macro to get the handle of netdev. Signed-off-by: Yunsheng Lin --- .../ethernet/hisilicon/hns3/hns3pf/hns3_dcbnl.c| 18 -- .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 39

[PATCH net-next 7/7] net: hns3: Cleanup for non-static function in hns3 driver

This patch fixes the following warning from sparse: warning: symbol 'hns3_set_multicast_list' was not declared. Should it be static. hns3_set_multicast_list turns out to be not used, so delete it. Signed-off-by: Yunsheng Lin ---

[PATCH net-next 3/7] net: hns3: Cleanup indentation for Kconfig in the the hisilicon folder

This patch fixes a few indentation for Kconfig file in the hisilicon folder. Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/hisilicon/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/Kconfig

[PATCH net-next 6/7] net: hns3: Cleanup for endian issue in hns3 driver

This patch fixes a lot of endian issues detected by sparse. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 8 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 206

[PATCH net-next 5/7] net: hns3: Cleanup for struct that used to send cmd to firmware

The hclge_tm module has already added _cmd to the end of struct that used to send cmd to firmware. This will help us finding the endian issues. This patch adds the _cmd to the end of struct that used to send cmd to firmware in hclge_main module. Signed-off-by: Yunsheng Lin

[PATCH net-next 4/7] net: hns3: Consistently using GENMASK in hns3 driver

This patch uses GENMASK to generate bit mask whenever possible in hns3 driver. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 48 +++--- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 4 +- 2 files changed, 26

Re: [PATCH] net/core: Fix BUG to BUG_ON conditionals.

-conditionals/20171009-070451 config: x86_64-randconfig-s1-10091351 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): In file include

[PATCH net] ipv4: Fix traffic triggered IPsec connections.

A recent patch removed the dst_free() on the allocated dst_entry in ipv4_blackhole_route(). The dst_free() marked the dst_entry as dead and added it to the gc list. I.e. it was setup for a one time usage. As a result we may now have a blackhole route cached at a socket on some IPsec scenarios.

[PATCH net] ipv6: Fix traffic triggered IPsec connections.

A recent patch removed the dst_free() on the allocated dst_entry in ipv6_blackhole_route(). The dst_free() marked the dst_entry as dead and added it to the gc list. I.e. it was setup for a one time usage. As a result we may now have a blackhole route cached at a socket on some IPsec scenarios.

Re: [PATCH 10/12] net/mlx4: replace with

On Mon, Oct 09, 2017 at 02:56:56PM +0900, Masahiro Yamada wrote: > 2017-10-09 3:55 GMT+09:00 Leon Romanovsky : > > On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: > >> 2017-10-09 2:00 GMT+09:00 David Miller : > >> > From: Masahiro Yamada

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

On Mon, Oct 09, 2017 at 02:58:58PM +0900, Masahiro Yamada wrote: > 2017-10-09 3:52 GMT+09:00 Leon Romanovsky : > > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: > > > > <...> > >> > >> By splitting out the radix_tree_root definition, > >> we can reduce the

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

2017-10-09 3:52 GMT+09:00 Leon Romanovsky : > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: > > <...> >> >> By splitting out the radix_tree_root definition, >> we can reduce the header file dependency. >> >> Reducing the header dependency will help for

<    1   2   3