Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Jiri Pirko
Wed, Oct 18, 2017 at 03:22:03PM CEST, steven.l...@broadcom.com wrote: >On Wed, Oct 18, 2017 at 9:01 AM, Jiri Pirko wrote: >> Wed, Oct 18, 2017 at 02:39:42PM CEST, steven.l...@broadcom.com wrote: >>>On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote: You need to split the config option to

Re: [PATCH net 0/3] Fix for BPF devmap percpu allocation splat

2017-10-18 Thread Daniel Borkmann
On 10/18/2017 03:25 PM, Tejun Heo wrote: Hello, Daniel. (cc'ing Dennis) On Tue, Oct 17, 2017 at 04:55:51PM +0200, Daniel Borkmann wrote: The set fixes a splat in devmap percpu allocation when we alloc the flush bitmap. Patch 1 is a prerequisite for the fix in patch 2, patch 1 is rather small,

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Jiri Pirko
Wed, Oct 18, 2017 at 03:14:35PM CEST, steven.l...@broadcom.com wrote: >On Wed, Oct 18, 2017 at 8:58 AM, Jiri Pirko wrote: >> Wed, Oct 18, 2017 at 02:39:09PM CEST, steven.l...@broadcom.com wrote: >>>On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: Tue, Oct 17, 2017 at 10:44:23PM CEST, steve

Re: [PATCH net] sctp: add the missing sock_owned_by_user check in sctp_icmp_redirect

2017-10-18 Thread Marcelo Ricardo Leitner
On Wed, Oct 18, 2017 at 09:37:49PM +0800, Xin Long wrote: > Now sctp processes icmp redirect packet in sctp_icmp_redirect where > it calls sctp_transport_dst_check in which tp->dst can be released. > > The problem is before calling sctp_transport_dst_check, it doesn't > check sock_owned_by_user, w

Re: [PATCH net-next v6 1/5] bpf: Add file mode configuration into bpf maps

2017-10-18 Thread Daniel Borkmann
Hey Chenbo, there's still one thing I noticed later one; would have sent a follow-up, but as you need to respin anyway for the build issue, here's what is still missing uapi-wise: On 10/16/2017 09:11 PM, Chenbo Feng wrote: [...] +int bpf_get_file_flag(int flags) +{ + if ((flags & BPF_F_RD

[PATCH net] sctp: add the missing sock_owned_by_user check in sctp_icmp_redirect

2017-10-18 Thread Xin Long
Now sctp processes icmp redirect packet in sctp_icmp_redirect where it calls sctp_transport_dst_check in which tp->dst can be released. The problem is before calling sctp_transport_dst_check, it doesn't check sock_owned_by_user, which means tp->dst could be freed while a process is accessing it wi

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 9:01 AM, Jiri Pirko wrote: > Wed, Oct 18, 2017 at 02:39:42PM CEST, steven.l...@broadcom.com wrote: >>On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote: >>> >>> You need to split the config option to those that are per-port and to >>> those that are per-asic. For each famil

Re: [PATCH net] sock_diag: request _diag module only when the family or proto has been registered

2017-10-18 Thread Xin Long
On Wed, Oct 18, 2017 at 5:38 PM, kbuild test robot wrote: > Hi Xin, > > [auto build test ERROR on net/master] > > url: > https://github.com/0day-ci/linux/commits/Xin-Long/sock_diag-request-_diag-module-only-when-the-family-or-proto-has-been-registered/20171018-15243

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-18 Thread Sekhar Nori
Hi Marc, On Wednesday 18 October 2017 06:14 PM, Marc Kleine-Budde wrote: > On 09/21/2017 02:48 AM, Franklin S Cooper Jr wrote: >> >> >> On 09/20/2017 04:37 PM, Mario Hüttel wrote: >>> >>> >>> On 09/20/2017 10:19 PM, Franklin S Cooper Jr wrote: Hi Wenyou, On 09/17/2017 10:47 PM, Yang

Re: [PATCH net 0/3] Fix for BPF devmap percpu allocation splat

2017-10-18 Thread Tejun Heo
Hello, Daniel. (cc'ing Dennis) On Tue, Oct 17, 2017 at 04:55:51PM +0200, Daniel Borkmann wrote: > The set fixes a splat in devmap percpu allocation when we alloc > the flush bitmap. Patch 1 is a prerequisite for the fix in patch 2, > patch 1 is rather small, so if this could be routed via -net, f

Re: [PATCH net-next] tcp: fix tcp_xmit_retransmit_queue() after rbtree introduction

2017-10-18 Thread David Miller
From: Eric Dumazet Date: Mon, 16 Oct 2017 19:38:35 -0700 > From: Eric Dumazet > > I tried to hard avoiding a call to rb_first() (via tcp_rtx_queue_head) > in tcp_xmit_retransmit_queue(). But this was probably too bold. > > Quoting Yuchung : > > We might miss re-arming the RTO if tp->retransmi

Re: [PATCH net-next 0/4] bpf: move context info out of the verifier

2017-10-18 Thread David Miller
From: Jakub Kicinski Date: Mon, 16 Oct 2017 16:40:52 -0700 > Daniel pointed out during the review of my previous patchset that > the knowledge about context doesn't really belong directly in the > verifier. This patch set takes a bit of a drastic approach to > move the info out of there. I want

Re: [PATCH v2 net-next] tcp: Check daddr_cache before use in tracepoint

2017-10-18 Thread David Miller
From: David Ahern Date: Mon, 16 Oct 2017 15:32:07 -0700 > Running perf in one window to capture tcp_retransmit_skb tracepoint: > $ perf record -e tcp:tcp_retransmit_skb -a > > And causing a retransmission on an active TCP session (e.g., dropping > packets in the receiver, changing MTU on the

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 8:58 AM, Jiri Pirko wrote: > Wed, Oct 18, 2017 at 02:39:09PM CEST, steven.l...@broadcom.com wrote: >>On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: >>> Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: >>> Steve. As I originally requested, could you

Re: [PATCH] net: ipx: mark expected switch fall-through

2017-10-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 16 Oct 2017 16:53:16 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] ipv6: mark expected switch fall-throughs

2017-10-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 16 Oct 2017 16:36:52 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in some cases I placed the "fall through" comment > on its own line, which is what GCC is expecting t

Re: [PATCH net-next v6 0/5] bpf: security: New file mode and LSM hooks for eBPF object permission control

2017-10-18 Thread David Miller
From: David Miller Date: Wed, 18 Oct 2017 13:47:29 +0100 (WEST) > Series applied. I had to revert as this breaks the build: net/netfilter/xt_bpf.c: In function ‘__bpf_mt_check_path’: net/netfilter/xt_bpf.c:59:7: error: too few arguments to function ‘bpf_obj_get_user’ fd = bpf_obj_get_user(pa

Re: [PATCH net-next] tcp: Use pI6c in tcp tracepoint

2017-10-18 Thread David Miller
From: David Ahern Date: Mon, 16 Oct 2017 14:24:02 -0700 > The compact form for IPv6 addresses is more user friendly than the full > version. For example: >compact: 2001:db8:1::1 > full: 2001:0db8:0001:::::0004i > > Update the tcp tracepoint to show the compact form. >

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-18 Thread Paolo Abeni
On Tue, 2017-10-17 at 13:48 -0700, Wei Wang wrote: > On Tue, Oct 17, 2017 at 1:02 PM, Paolo Abeni wrote: > > Meanwhile others sockets may grab more references to (and use) the same > > aged-out dst. > > > > I don't think other sockets could grab more reference to this dst > because this dst shou

Re: [PATCH] decnet: af_decnet: mark expected switch fall-throughs

2017-10-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 16 Oct 2017 15:11:22 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Jiri Pirko
Wed, Oct 18, 2017 at 02:39:42PM CEST, steven.l...@broadcom.com wrote: >On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote: >> >> You need to split the config option to those that are per-port and to >> those that are per-asic. For each family, you have to use ither >> devlink_port of devlink handle

Re: [PATCH] ipv4: mark expected switch fall-throughs

2017-10-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 16 Oct 2017 15:48:55 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in some cases I placed the "fall through" comment > on its own line, which is what GCC is expecting t

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Jiri Pirko
Wed, Oct 18, 2017 at 02:39:09PM CEST, steven.l...@broadcom.com wrote: >On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: >> Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: >> Steve. As I originally requested, could you please split this to: >> 1) single patch adding config g

Re: [PATCH net-next v6 0/5] bpf: security: New file mode and LSM hooks for eBPF object permission control

2017-10-18 Thread David Miller
From: Chenbo Feng Date: Mon, 16 Oct 2017 12:11:30 -0700 > Much like files and sockets, eBPF objects are accessed, controlled, and > shared via a file descriptor (FD). Unlike files and sockets, the > existing mechanism for eBPF object access control is very limited. > Currently there are two optio

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-18 Thread Marc Kleine-Budde
On 09/21/2017 02:48 AM, Franklin S Cooper Jr wrote: > > > On 09/20/2017 04:37 PM, Mario Hüttel wrote: >> >> >> On 09/20/2017 10:19 PM, Franklin S Cooper Jr wrote: >>> Hi Wenyou, >>> >>> On 09/17/2017 10:47 PM, Yang, Wenyou wrote: On 2017/9/14 13:06, Sekhar Nori wrote: > On Thursday

Re: [PATCH v3 0/6] adapt DPAA drivers for DSA

2017-10-18 Thread David Miller
From: Madalin Bucur Date: Mon, 16 Oct 2017 21:36:04 +0300 > Junote Cai reported that he was not able to get a DSA setup involving the > DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node() > call in DSA setup. The initial attempt to fix this by adding of_node to the > pla

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote: > > You need to split the config option to those that are per-port and to > those that are per-asic. For each family, you have to use ither > devlink_port of devlink handle. Also, you need to split into those that are > permanent and to those who

Re: [PATCH 6/7] bnxt: Move generic devlink code to new file

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 3:33 AM, Jiri Pirko wrote: > Tue, Oct 17, 2017 at 10:44:28PM CEST, steven.l...@broadcom.com wrote: >>Moving generic devlink code (registration) out of VR-R code >>into new bnxt_devlink file. > > You can send this patch separatelly and let it be applied before the > patchset

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: > Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: > Steve. As I originally requested, could you please split this to: > 1) single patch adding config get/set commands, without any config attributes > 2) single patch per confi

Re: [PATCH net v2] bpf: disallow arithmetic operations on context pointer

2017-10-18 Thread David Miller
From: Jakub Kicinski Date: Mon, 16 Oct 2017 11:16:55 -0700 > Commit f1174f77b50c ("bpf/verifier: rework value tracking") > removed the crafty selection of which pointer types are > allowed to be modified. This is OK for most pointer types > since adjust_ptr_min_max_vals() will catch operations o

Re: [PATCH net-next] tools: bpftool: use more common tag format

2017-10-18 Thread David Miller
From: Jakub Kicinski Date: Mon, 16 Oct 2017 10:12:54 -0700 > Program tag is usually displayed as string of bytes without > any separators (e.g. as "aa5520b1090cfeb6" vs MAC addr-like > format bpftool uses currently: "aa:55:20:b1:09:0c:fe:b6"). > Make bptfool use the more common format both for di

Re: [PATCH] dql: make dql_init return void

2017-10-18 Thread Hiroaki SHIMODA
On Tue, 17 Oct 2017 17:16:52 -0700 Stephen Hemminger wrote: > dql_init always returned 0, and the only place that uses it > in network core code didn't care about the return value anyway. > > Signed-off-by: Stephen Hemminger Acked-by: Hiroaki SHIMODA

Re: [PATCH] wanxl: use m68k-linux-gnu-as if available

2017-10-18 Thread David Miller
From: Adam Borowski Date: Wed, 18 Oct 2017 13:33:26 +0200 > On Wed, Oct 18, 2017 at 12:08:12PM +0100, David Miller wrote: >> From: Adam Borowski >> Date: Fri, 13 Oct 2017 01:24:34 +0200 >> >> > This fixes build failure on Debian based systems: GNU as is the only m68k >> > assembler available in

[PATCH net-next 0/3] rxrpc: Add bits for kernel services

2017-10-18 Thread David Howells
s.git rxrpc-next-20171018 David --- David Howells (3): rxrpc: Support service upgrade from a kernel service rxrpc: Provide functions for allowing cleaner handling of signals rxrpc: Use MSG_WAITALL to tell sendmsg() to temporarily ignore signals Documentation/networking/rxrpc.txt |

[PATCH net-next 3/3] rxrpc: Use MSG_WAITALL to tell sendmsg() to temporarily ignore signals

2017-10-18 Thread David Howells
Make AF_RXRPC accept MSG_WAITALL as a flag to sendmsg() to tell it to ignore signals whilst loading up the message queue, provided progress is being made in emptying the queue at the other side. Progress is defined as the base of the transmit window having being advanced within 2 RTT periods. If

[PATCH net-next 1/3] rxrpc: Support service upgrade from a kernel service

2017-10-18 Thread David Howells
Provide support for a kernel service to make use of the service upgrade facility. This involves: (1) Pass an upgrade request flag to rxrpc_kernel_begin_call(). (2) Make rxrpc_kernel_recv_data() return the call's current service ID so that the caller can detect service upgrade and see what

[PATCH net-next 2/3] rxrpc: Provide functions for allowing cleaner handling of signals

2017-10-18 Thread David Howells
Provide a couple of functions to allow cleaner handling of signals in a kernel service. They are: (1) rxrpc_kernel_get_rtt() This allows the kernel service to find out the RTT time for a call, so as to better judge how large a timeout to employ. Note, though, that whilst this re

[PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-18 Thread Geert Uytterhoeven
If an Ethernet PHY is initialized before the interrupt controller it is connected to, a message like the following is printed: irq: no irq domain found for /interrupt-controller@e61c ! However, the actual error is ignored, leading to a non-functional (POLL) PHY interrupt later: Micre

[PATCH v7 00/10] net: stmmac: dwmac-sun8i: Handle integrated PHY

2017-10-18 Thread Corentin Labbe
Hello The current way to find if the PHY is internal is to compare DT phy-mode and emac_variant/internal_phy. But it will negate a possible future SoC where an external PHY use the same phy mode than the integrated one. This patchs series adds a new way to handle this problem via a mdio-mux. The

[PATCH v7 01/10] dt-bindings: net: Restore sun8i dwmac binding

2017-10-18 Thread Corentin Labbe
The original dwmac-sun8i DT bindings have some issue on how to handle integrated PHY and was reverted in last RC of 4.13. But now we have a solution so we need to get back that was reverted. This patch restore dt-bindings documentation about dwmac-sun8i This reverts commit 8aa33ec2f481 ("dt-bindin

[PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes

2017-10-18 Thread Corentin Labbe
The original dwmac-sun8i DT bindings have some issue on how to handle integrated PHY and was reverted in last RC of 4.13. But now we have a solution so we need to get back that was reverted. This patch restore arm DT about dwmac-sun8i This reverts commit fe45174b72ae ("arm: dts: sunxi: Revert EMAC

[PATCH v7 03/10] arm64: dts: allwinner: Restore EMAC changes

2017-10-18 Thread Corentin Labbe
The original dwmac-sun8i DT bindings have some issue on how to handle integrated PHY and was reverted in last RC of 4.13. But now we have a solution so we need to get back that was reverted. This patch restore arm64 DT about dwmac-sun8i This reverts commit 87e1f5e8bb4b ("arm64: dts: allwinner: Rev

[PATCH v7 07/10] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio

2017-10-18 Thread Corentin Labbe
stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Signed-off-by: Corentin Labbe --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 1 + 1 file changed, 1 inse

[PATCH v7 04/10] net: stmmac: sun8i: Restore the compatibles

2017-10-18 Thread Corentin Labbe
The original dwmac-sun8i DT bindings have some issue on how to handle integrated PHY and was reverted in last RC of 4.13. But now we have a solution so we need to get back that was reverted. This patch restore compatibles about dwmac-sun8i This reverts commit ad4540cc5aa3 ("net: stmmac: sun8i: Rem

[PATCH v7 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-18 Thread Corentin Labbe
This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe --- .../devicetree/bindings/net/dwmac-sun8i.txt| 139 +++-- 1 file changed, 127 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree

[PATCH v7 08/10] net: stmmac: snps,dwmac-mdio MDIOs are automatically registered

2017-10-18 Thread Corentin Labbe
stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Since these compatible is automatically registered, dwmac-sun8i compatible does not need to be in need_mdio_ids

[PATCH v7 09/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-10-18 Thread Corentin Labbe
The Allwinner H3 SoC have two distinct MDIO bus, only one could be active at the same time. The selection of the active MDIO bus are done via some bits in the EMAC register of the system controller. This patch implement this MDIO switch via a custom MDIO-mux. Signed-off-by: Corentin Labbe --- d

[PATCH v7 10/10] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes

2017-10-18 Thread Corentin Labbe
Each child node of an MDIO node is scanned as a PHY when calling of_mdiobus_register() givint the following result: [ 18.175379] mdio_bus stmmac-0: /soc/ethernet@1c3/mdio/mdio-mux has invalid PHY address [ 18.175408] mdio_bus stmmac-0: scan phy mdio-mux at address 0 [ 18.175450] mdio_bus

[PATCH v7 06/10] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-10-18 Thread Corentin Labbe
Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 33 +++-- 1 file changed, 27 ins

Re: [PATCH v2 net-next 0/5] mlxsw: spectrum_router: Add extack messages for RIF and VRF overflow

2017-10-18 Thread David Miller
From: David Ahern Date: Mon, 16 Oct 2017 09:36:49 -0700 > Currently, exceeding the number of VRF instances or the number of router > interfaces either fails with a non-intuitive EBUSY: > $ ip li set swp1s1.6 vrf vrf-1s1-6 up > RTNETLINK answers: Device or resource busy > > or fails silen

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

2017-10-18 Thread David Miller
From: Kees Cook Date: Mon, 16 Oct 2017 17:28:44 -0700 > This is the current set of outstanding networking patches to perform > conversions to the new timer interface (rebased to -next). This is not > all expected conversions, but it contains everything needed in networking > to eliminate init_tim

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

2017-10-18 Thread Johannes Berg
On Wed, 2017-10-18 at 13:31 +0200, Johannes Berg wrote: > On Wed, 2017-10-18 at 12:29 +0200, Johannes Berg wrote: > > > Anyway, the change here looks correct to me, so I'll apply it and then > > perhaps clean up more. I've only changed "u16 tid" to "u8 tid" since > > the valid range is 0-15 (in th

Re: [PATCH] wanxl: use m68k-linux-gnu-as if available

2017-10-18 Thread Adam Borowski
On Wed, Oct 18, 2017 at 12:08:12PM +0100, David Miller wrote: > From: Adam Borowski > Date: Fri, 13 Oct 2017 01:24:34 +0200 > > > This fixes build failure on Debian based systems: GNU as is the only m68k > > assembler available in the archive (package binutils-m68k-linux-gnu). > > > > Signed-off

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

2017-10-18 Thread Johannes Berg
On Wed, 2017-10-18 at 12:29 +0200, Johannes Berg wrote: > Anyway, the change here looks correct to me, so I'll apply it and then > perhaps clean up more. I've only changed "u16 tid" to "u8 tid" since > the valid range is 0-15 (in theory, in practice 0-7). Well, I guess I'm clearly wrong - it's cr

Re: [PATCH net-next v2 0/7] net: dsa: master and slave helpers

2017-10-18 Thread David Miller
From: Vivien Didelot Date: Mon, 16 Oct 2017 11:12:12 -0400 > This patch series adds a few helpers to DSA core for clarity and > readability but brings no functional changes. > > A dsa_slave_notify helper calls the DSA notifiers when (un)registering a > slave device. > > Most of the DSA slave co

Re: [PATCH] netlink: fix netlink_ack() extack race

2017-10-18 Thread David Miller
From: Johannes Berg Date: Mon, 16 Oct 2017 17:09:53 +0200 > From: Johannes Berg > > It seems that it's possible to toggle NETLINK_F_EXT_ACK > through setsockopt() while another thread/CPU is building > a message inside netlink_ack(), which could then trigger > the WARN_ON()s I added since if it

Re: [PATCH net] ibmvnic: Fix calculation of number of TX header descriptors

2017-10-18 Thread David Miller
From: Thomas Falcon Date: Mon, 16 Oct 2017 10:02:11 -0500 > This patch correctly sets the number of additional header descriptors > that will be sent in an indirect SCRQ entry. > > Signed-off-by: Thomas Falcon Applied.

Re: [PATCH] netlink: use NETLINK_CB(in_skb).sk instead of looking it up

2017-10-18 Thread David Miller
From: Johannes Berg Date: Mon, 16 Oct 2017 16:57:49 +0200 > From: Johannes Berg > > When netlink_ack() reports an allocation error to the sending > socket, there's no need to look up the sending socket since > it's available in the SKB's CB. Use that instead of going to > the trouble of looking

Re: [patch net] mlxsw: core: Fix possible deadlock

2017-10-18 Thread David Miller
From: Jiri Pirko Date: Mon, 16 Oct 2017 16:28:28 +0200 > From: Ido Schimmel > > When an EMAD is transmitted, a timeout work item is scheduled with a > delay of 200ms, so that another EMAD will be retried until a maximum of > five retries. > > In certain situations, it's possible for the functi

Re: [PATCH net-next v2 2/2] net: add skb_memcpy_to[from]_msg() to optimize skb code

2017-10-18 Thread David Miller
From: yuan linyu Date: Mon, 16 Oct 2017 20:11:13 +0800 > From: yuan linyu > > add these two wrappers in skbuff.h which is better named > than previous and only used for skb. > > Signed-off-by: yuan linyu Doing the skb_put() inside of the helper function makes code less intuitive. If someone

Re: [net-next V8 PATCH 0/5] New bpf cpumap type for XDP_REDIRECT

2017-10-18 Thread David Miller
From: Jesper Dangaard Brouer Date: Mon, 16 Oct 2017 12:19:23 +0200 > Introducing a new way to redirect XDP frames. Notice how no driver > changes are necessary given the design of XDP_REDIRECT. Series applied, thanks Jesper.

Re: [PATCH v3] net: ftgmac100: Request clock and set speed

2017-10-18 Thread David Miller
From: Joel Stanley Date: Fri, 13 Oct 2017 12:16:38 +0800 > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. This patch > configures a 100MHz clock if the system has a direct-attached > PHY, or 25MHz if the system is run

Re: [PATCH] wanxl: use m68k-linux-gnu-as if available

2017-10-18 Thread David Miller
From: Adam Borowski Date: Fri, 13 Oct 2017 01:24:34 +0200 > This fixes build failure on Debian based systems: GNU as is the only m68k > assembler available in the archive (package binutils-m68k-linux-gnu). > > Signed-off-by: Adam Borowski The Kconfig help text for the config option controlling

RE: [PATCH net-next 1/3] ibmvnic: Enable scatter-gather support

2017-10-18 Thread David Laight
From: Thomas Falcon > Sent: 17 October 2017 18:37 > This patch enables scatter gather support. Since there is no > HW/FW scatter-gather support at this time, the driver needs to > loop through each fragment and copy it to a contiguous, pre-mapped > buffer entry. ... > offset = index * adapter

[PATCH net-next 0/2] net: dsa: lan9303: Add fdb/mdb methods

2017-10-18 Thread Egil Hjelmeland
This series add support for accessing and managing the lan9303 ALR (Address Logic Resolution). The first patch add low level functions for accessing the ALR, along with port_fast_age and port_fdb_dump methods. The second patch add functions for managing ALR entires, along with remaining fdb/mdb

[PATCH net-next 1/2] net: dsa: lan9303: Add port_fast_age and port_fdb_dump methods

2017-10-18 Thread Egil Hjelmeland
Add DSA method port_fast_age as a step to STP support. Add low level functions for accessing the lan9303 ALR (Address Logic Resolution). Added DSA method port_fdb_dump Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 159 + drivers/net

[PATCH net-next 2/2] net: dsa: lan9303: Add fdb/mdb manipulation

2017-10-18 Thread Egil Hjelmeland
Add functions for managing the lan9303 ALR (Address Logic Resolution). Implement DSA methods: port_fdb_add, port_fdb_del, port_mdb_prepare, port_mdb_add and port_mdb_del. Since the lan9303 do not offer reading specific ALR entry, the driver caches all static entries - in a flat table. Signed-off

Re: [net-next V8 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

2017-10-18 Thread Yann Ylavic
On Wed, Oct 18, 2017 at 10:38 AM, Jesper Dangaard Brouer wrote: > > On Wed, 18 Oct 2017 09:45:59 +0200 Yann Ylavic wrote: > >> On Mon, Oct 16, 2017 at 12:19 PM, Jesper Dangaard Brouer >> wrote: >> > + >> > + /* Notice returns -EPERM on if map size is larger than memlock >> > limit */ >> >

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

2017-10-18 Thread Johannes Berg
Hi, [quoting your other email:] > This has been the least trivial timer conversion yet. Given the use of > RCU and other things I may not even know about, I'd love to get a close > look at this. I *think* this is correct, as it will re-lookup the tid > entries when firing the timer. I'm not real

Re: [PATCH net-next v2 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

2017-10-18 Thread Kunihiko Hayashi
On Sat, 14 Oct 2017 01:41:12 +0900 wrote: > 2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi : > > DT bindings for the AVE ethernet controller found on Socionext's > > UniPhier platforms. > > > > Signed-off-by: Kunihiko Hayashi > > Signed-off-by: Jassi Brar > > --- > > .../bindings/net/socionext,uni

Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-10-18 Thread Kunihiko Hayashi
On Mon, 16 Oct 2017 00:08:21 +0900 wrote: > 2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi : > > +static int ave_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *np = dev->of_node; > > + u32 ave_id; > > + struct ave_pr

Re: [PATCH] mac80211: use constant time comparison with keys

2017-10-18 Thread Johannes Berg
On Tue, 2017-10-17 at 20:32 +0200, Jason A. Donenfeld wrote: > Otherwise we risk leaking information via timing side channel. > Applied. johannes

Re: [RFC] sctp: suspicious rcu_read_lock() in sctp_packet_config()

2017-10-18 Thread Marcelo Ricardo Leitner
On Wed, Oct 18, 2017 at 01:33:46AM +0800, Xin Long wrote: > On Wed, Oct 18, 2017 at 1:27 AM, Marcelo Ricardo Leitner > wrote: > > On Tue, Oct 17, 2017 at 10:20:58AM -0700, Eric Dumazet wrote: > >> On Tue, Oct 17, 2017 at 10:01 AM, Marcelo Ricardo Leitner > >> wrote: > >> > On Tue, Oct 17, 2017 at

pull-request: wireless-drivers-next 2017-10-18

2017-10-18 Thread Kalle Valo
Hi Dave, this for 4.15 stream to net-next tree. Please let me know if there are any problems. Kalle The following changes since commit 3e747fa18202896b5be66b88478352d5880fb8eb: Merge ath-current from ath.git (2017-09-25 10:06:12 +0300) are available in the git repository at: git://git.ker

Re: [PATCH net] sock_diag: request _diag module only when the family or proto has been registered

2017-10-18 Thread kbuild test robot
Hi Xin, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Xin-Long/sock_diag-request-_diag-module-only-when-the-family-or-proto-has-been-registered/20171018-152434 config: x86_64-randconfig-a0-10181611 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3

Re: [PATCH net-next] net: sched: cls_u32: use hash_ptr() for tc_u_hash

2017-10-18 Thread Jiri Pirko
Wed, Oct 18, 2017 at 10:33:37AM CEST, a...@arndb.de wrote: >After the change to the tp hash, we now get a build warning >on 32-bit architectures: > >net/sched/cls_u32.c: In function 'tc_u_hash': >net/sched/cls_u32.c:338:17: error: cast from pointer to integer of different >size [-Werror=pointer-to

Re: [net-next V8 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

2017-10-18 Thread Jesper Dangaard Brouer
On Mon, 16 Oct 2017 12:19:28 +0200 Jesper Dangaard Brouer wrote: > +static struct bpf_map *cpu_map_alloc(union bpf_attr *attr) > +{ > + struct bpf_cpu_map *cmap; > + int err = -ENOMEM; Notice err is set to -ENOMEM. > + u64 cost; > + int ret; > + > + if (!capable(CAP_SYS_A

[PATCH net-next] net: sched: cls_u32: use hash_ptr() for tc_u_hash

2017-10-18 Thread Arnd Bergmann
After the change to the tp hash, we now get a build warning on 32-bit architectures: net/sched/cls_u32.c: In function 'tc_u_hash': net/sched/cls_u32.c:338:17: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] return hash_64((u64) tp->chain->block, U32_HASH_SHIF

Re: [PATCH net] sock_diag: request _diag module only when the family or proto has been registered

2017-10-18 Thread kbuild test robot
Hi Xin, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Xin-Long/sock_diag-request-_diag-module-only-when-the-family-or-proto-has-been-registered/20171018-152434 config: i386-randconfig-a0-201742 (attached as .config) compiler: gcc-5 (Debian 5.4.1-2) 5.4.1

Re: [PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver

2017-10-18 Thread Sergei Shtylyov
Hello! On 10/18/2017 10:14 AM, Or Gerlitz wrote: Commit 7091d8c '(net/sched: cls_flower: Add offload support using egress At least 12 digits are needed. Also on such a spot (e.g not on the Fixes line)? Yes. [...] MBR, Sergei

[PATCH net-next] tipc: checking for NULL instead of IS_ERR()

2017-10-18 Thread Dan Carpenter
The tipc_alloc_conn() function never returns NULL, it returns error pointers, so I have fixed the check. Fixes: 14c04493cb77 ("tipc: add ability to order and receive topology events in driver") Signed-off-by: Dan Carpenter diff --git a/net/tipc/server.c b/net/tipc/server.c index 713077536d0c..a

Re: [net-next V8 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

2017-10-18 Thread Yann Ylavic
On Mon, Oct 16, 2017 at 12:19 PM, Jesper Dangaard Brouer wrote: > + > + /* Notice returns -EPERM on if map size is larger than memlock limit > */ > + ret = bpf_map_precharge_memlock(cmap->map.pages); > + if (ret) { > + err = ret; > + goto free_cmap; >

Re: [PATCH 6/7] bnxt: Move generic devlink code to new file

2017-10-18 Thread Jiri Pirko
Tue, Oct 17, 2017 at 10:44:28PM CEST, steven.l...@broadcom.com wrote: >Moving generic devlink code (registration) out of VR-R code >into new bnxt_devlink file. You can send this patch separatelly and let it be applied before the patchset.

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Jiri Pirko
Tue, Oct 17, 2017 at 10:44:26PM CEST, steven.l...@broadcom.com wrote: >Extending DEVLINK_ATTR_PERM_CFG (permanent/NVRAM device configuration) >to include persistent configuration of device link settings: > >DEVLINK_ATTR_PERM_CFG_AUTONEG_PROTOCOL: Configure default autoneg >protocol; use enum devlin

[PATCH net-next v2 1/3] dt-bindings: net: sh_eth: add R-Car Gen[12] fallback compatibility strings

2017-10-18 Thread Simon Horman
Add fallback compatibility strings for R-Car Gen 1 and 2. In the case of Renesas R-Car hardware we know that there are generations of SoCs, f.e. Gen 1 and 2. But beyond that its not clear what the relationship between IP blocks might be. For example, I believe that r8a7790 is older than r8a7791 bu

[PATCH net-next v2 0/3] net: sh_eth: add R-Car Gen[12] fallback compatibility strings

2017-10-18 Thread Simon Horman
Add fallback compatibility strings for R-Car Gen 1 and 2. In the case of Renesas R-Car hardware we know that there are generations of SoCs, f.e. Gen 1 and 2. But beyond that its not clear what the relationship between IP blocks might be. For example, I believe that r8a7790 is older than r8a7791 bu

[PATCH net-next v2 2/3] net: sh_eth: rename name structures as rcar_gen[12]_*

2017-10-18 Thread Simon Horman
Rename structures describing R-Car SoCs as rcar_gen[12]_* rather than r8a77[79]x_*. This seems a little easier on the eyes. And will make things slightly cleaner in a follow-up patch that adds fallback-compatibility strings for these SoCs. Note that R-Car Gen2 and RZ/G1 have many compatible IP blo

[PATCH net-next v2 3/3] net: sh_eth: implement R-Car Gen[12] fallback compatibility strings

2017-10-18 Thread Simon Horman
Implement fallback compatibility strings for R-Car Gen 1 and 2. In the case of Renesas R-Car hardware we know that there are generations of SoCs, f.e. Gen 1 and 2. But beyond that its not clear what the relationship between IP blocks might be. For example, I believe that r8a7790 is older than r8a7

Re: [PATCH] vmxnet3: Use correct minimum MTU value

2017-10-18 Thread Andrew Lunn
On Tue, Oct 17, 2017 at 04:33:43PM +0200, Mohammed Gamal wrote: > Currently the vmxnet3 driver has a minimum MTU value of 60. Which > goes against the RFC791 spec which specifies it at 68. > > Setting MTU to values between 60 <= MTU <= 67 causes the network > interface to lose its IP, and it fails

Re: [PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver

2017-10-18 Thread Or Gerlitz
On Tue, Oct 17, 2017 at 2:29 PM, Sergei Shtylyov wrote: > Hello! > > On 10/16/2017 12:19 PM, Or Gerlitz wrote: > >> Commit 7091d8c '(net/sched: cls_flower: Add offload support using egress > > >At least 12 digits are needed. Also on such a spot (e.g not on the Fixes line)? > >> Hardware devi

Re: Bug with GRE tunnel and "ip xfrm" GRE match?

2017-10-18 Thread Harsh Jain
Also sdding netdev for more inputs. On Wed, Oct 18, 2017 at 12:13 PM, Harsh Jain wrote: > Hi keith, > > Its being a long time when I observed this issue. What I remember is , > The kernel patch which I shared was not compatible with latest kernel. > there after I switched to another project, Didn

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Jiri Pirko
Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: >Add support for permanent config parameter get/set commands. Used >for parameters held in NVRAM, persistent device configuration. >The config_get() and config_set() operations operate as expected, but >note that the driver imple

[PATCH v10 05/20] crypto: marvell/cesa: remove redundant backlog checks on EBUSY

2017-10-18 Thread Gilad Ben-Yossef
Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef Acked-by: Boris Brezillon --- drivers/crypto/marvell/cesa.c | 3 +-- drivers/crypto/marvell/c

[PATCH v10 00/20] simplify crypto wait for async op

2017-10-18 Thread Gilad Ben-Yossef
Many users of kernel async. crypto services have a pattern of starting an async. crypto op and than using a completion to wait for it to end. This patch set simplifies this common use case in two ways: First, by separating the return codes of the case where a request is queued to a backlog due to

[PATCH v10 09/20] crypto: move drbg to generic async completion

2017-10-18 Thread Gilad Ben-Yossef
DRBG is starting an async. crypto op and waiting for it complete. Move it over to generic code doing the same. The code now also passes CRYPTO_TFM_REQ_MAY_SLEEP flag indicating crypto request memory allocation may use GFP_KERNEL which should be perfectly fine as the code is obviously sleeping for

[PATCH v10 11/20] crypto: move testmgr to generic async completion

2017-10-18 Thread Gilad Ben-Yossef
testmgr is starting async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. This also provides a test of the generic crypto async. wait code. Signed-off-by: Gilad Ben-Yossef --- crypto/testmgr.c | 204 ++---

[PATCH v10 04/20] crypto: remove redundant backlog checks on EBUSY

2017-10-18 Thread Gilad Ben-Yossef
Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef --- crypto/ahash.c| 12 +++- crypto/cts.c | 6 ++ crypto/lrw.c

[PATCH v10 13/20] dm: move dm-verity to generic async completion

2017-10-18 Thread Gilad Ben-Yossef
dm-verity is starting async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. This also avoids a future potential data coruption bug created by the use of wait_for_completion_interruptible() without dealing correctly with an interrupt aborting the wait prio

[PATCH v10 14/20] cifs: move to generic async completion

2017-10-18 Thread Gilad Ben-Yossef
cifs starts an async. crypto op and waits for their completion. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Pavel Shilovsky --- fs/cifs/smb2ops.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-) diff --git a/fs/cif

[PATCH v10 17/20] crypto: talitos: move to generic async completion

2017-10-18 Thread Gilad Ben-Yossef
The talitos driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Tested-by: Christophe Leroy --- drivers/crypto/talitos.c | 38 +- 1 file changed, 5 insertions(+)

<    1   2   3   4   >