Re: v4.14-rc3/arm64 DABT exception in atomic_inc() / __skb_clone()

On Thu, Oct 19, 2017 at 8:13 PM, Wei Wei wrote: > Sry. Here it is. > > Unable to handle kernel paging request at virtual address 80005bfb81ed > Mem abort info: > Exception class = DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > Data abort info: >

net-next: del_timer_sync(): possible circular locking dependency detected

Hi, We run criu tests on net-next/master regularly, and today tests triggered this warning: v4.14-rc4-1168-g7a0947e [ 23.922640] == [ 23.922735] WARNING: possible circular locking dependency detected [ 23.922823] 4.14.0-rc4+ #1 Not

Re: [RFC PATCH 1/5] security: Add support for SCTP security hooks

On Tue, 17 Oct 2017, Richard Haines wrote: > The SCTP security hooks are explained in: > Documentation/security/LSM-sctp.txt > > Signed-off-by: Richard Haines > --- > Documentation/security/LSM-sctp.txt | 212 > >

Re: Get rid of RCU callbacks in TC filters?

On Wed, Oct 18, 2017 at 12:35 PM, Paul E. McKenney wrote: > On Wed, Oct 18, 2017 at 10:36:28AM -0700, Cong Wang wrote: >> Hi, all >> >> Recently, the RCU callbacks used in TC filters and TC actions keep >> drawing my attention, they introduce at least 4 race condition

Re: Get rid of RCU callbacks in TC filters?

On Thu, Oct 19, 2017 at 8:34 AM, John Fastabend wrote: > > My take on this would be to stay with the current RCU callbacks and try > to simplify the implementation. Falling back to sync operations seems > like a step backwards to me. I know update/delete of filters is

Re: v4.14-rc3/arm64 DABT exception in atomic_inc() / __skb_clone()

Sry. Here it is. Unable to handle kernel paging request at virtual address 80005bfb81ed Mem abort info: Exception class = DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 Data abort info: ISV = 0, ISS = 0x0033 CM = 0, WnR = 0 swapper pgtable: 4k pages, 48-bit VAs, pgd =

Re: [patch net v2 1/4] net/sched: Change tc_action refcnt and bindcnt to atomic

On Thu, Oct 19, 2017 at 7:21 AM, Jamal Hadi Salim wrote: > On 17-10-18 12:43 PM, Cong Wang wrote: >> >> On Tue, Oct 17, 2017 at 6:03 PM, Chris Mi wrote: -Original Message- > > >> >> You listed 3 problems, and you think they are 3

Re: v4.14-rc3/arm64 DABT exception in atomic_inc() / __skb_clone()

On Thu, Oct 19, 2017 at 7:16 PM, Wei Wei wrote: > Hi all, > > I have fuzzed v4.14-rc3 using syzkaller and found a bug similar to that one > [1]. > But the call trace isn’t the same. The atomic_inc() might handle a corrupted > skb_buff. > > The logs and config have been

Re: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down

Hi Alexei, Thanks for your review! On Thu, Oct 19, 2017 at 03:18:30PM -0700, Alexei Starovoitov wrote: > On Thu, Oct 19, 2017 at 03:52:49PM +0100, David Howells wrote: > > From: Chun-Yi Lee > > > > There are some bpf functions can be used to read kernel memory: > >

Re: RFC(v2): Audit Kernel Container IDs

On Thursday, October 19, 2017 7:11:33 PM EDT Aleksa Sarai wrote: > >>> The registration is a pseudo filesystem (proc, since PID tree already > >>> exists) write of a u8[16] UUID representing the container ID to a file > >>> representing a process that will become the first process in a new > >>>

v4.14-rc3/arm64 DABT exception in atomic_inc() / __skb_clone()

Hi all, I have fuzzed v4.14-rc3 using syzkaller and found a bug similar to that one [1]. But the call trace isn’t the same. The atomic_inc() might handle a corrupted skb_buff. The logs and config have been uploaded to my github repo [2]. [1] https://lkml.org/lkml/2017/10/2/216 [2]

Re: [PATCH] net/ethernet/sgi: Code cleanup

On 10/19/2017 08:27, David Miller wrote: > From: Joshua Kinard > Date: Tue, 17 Oct 2017 13:54:30 -0400 > >> From: Joshua Kinard >> >> The below patch attempts to clean up the code for the in-tree driver >> for IOC3 ethernet and serial console support,

RE: [Intel-wired-lan] [next-queue PATCH v9 6/6] igb: Add support for CBS offload

> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Vinicius Costa Gomes > Sent: Monday, October 16, 2017 6:01 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Cc: rodney.cummi...@ni.com; Guedes, Andre ; > j...@resnulli.us;

[PATCH net-next 0/2] Add mac loopback selftest support in hns3 driver

This patchset refactors the skb receiving and transmitting function before adding mac loopback selftest support in hns3 driver. Yunsheng Lin (2): net: hns3: Refactor the skb receiving and transmitting function net: hns3: Add mac loopback selftest support in hns3 driver

[PATCH net-next 1/2] net: hns3: Refactor the skb receiving and transmitting function

This patch refactors the skb receiving and transmitting functions and export them in order to support the ethtool's mac loopback selftest. Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 17 -

[PATCH net-next 2/2] net: hns3: Add mac loopback selftest support in hns3 driver

This patch adds mac loopback selftest support for ethtool cmd by checking if a transmitted packet can be received correctly when mac loopback is enabled. Signed-off-by: Yunsheng Lin --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 54

Re: [PATCH net-next v7 5/5] selinux: bpf: Add addtional check for bpf object file receive

On Wed, 18 Oct 2017, Chenbo Feng wrote: > From: Chenbo Feng > > Introduce a bpf object related check when sending and receiving files > through unix domain socket as well as binder. It checks if the receiving > process have privilege to read/write the bpf map or use the bpf

Re: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

On 10/19/2017 02:43 PM, Jiri Pirko wrote: > Thu, Oct 19, 2017 at 11:39:55PM CEST, j...@resnulli.us wrote: >> Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote: Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent config parameter. Defines number of MSI-X vectors

Re: [PATCH net-next v7 4/5] selinux: bpf: Add selinux check for eBPF syscall operations

On Wed, 18 Oct 2017, Chenbo Feng wrote: > From: Chenbo Feng > > Implement the actual checks introduced to eBPF related syscalls. This > implementation use the security field inside bpf object to store a sid that > identify the bpf object. And when processes try to access the

Re: [PATCH net-next v7 3/5] security: bpf: Add LSM hooks for bpf object related syscall

On Wed, 18 Oct 2017, Chenbo Feng wrote: > From: Chenbo Feng > > Introduce several LSM hooks for the syscalls that will allow the > userspace to access to eBPF object such as eBPF programs and eBPF maps. > The security check is aimed to enforce a per object security protection

Re: [PATCH net-next 0/8] tools: bpftool: add a "version" command, and fix several items

On Thu, Oct 19, 2017 at 03:46:18PM -0700, Jakub Kicinski wrote: > Quentin says: > > The first seven patches of this series bring several minor fixes to > bpftool. Please see individual commit logs for details. > > Last patch adds a "version" commands to bpftool, which is in fact the > version of

[PATCH] net: ethtool: remove error check for legacy setting transceiver type

Commit 9cab88726929605 ("net: ethtool: Add back transceiver type") restores the transceiver type to struct ethtool_link_settings and convert_link_ksettings_to_legacy_settings() but forgets to remove the error check for the same in convert_legacy_settings_to_link_ksettings(). This prevents older

Re: [PATCH] net: ethtool: remove error check for legacy setting transceiver type

On 10/19/2017 04:32 PM, Niklas Söderlund wrote: > Commit 9cab88726929605 ("net: ethtool: Add back transceiver type") > restores the transceiver type to struct ethtool_link_settings and > convert_link_ksettings_to_legacy_settings() but forgets to remove the > error check for the same in

Re: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down

On Thu, Oct 19, 2017 at 11:48:34PM +0100, David Howells wrote: > Alexei Starovoitov wrote: > > > > @@ -65,6 +65,11 @@ BPF_CALL_3(bpf_probe_read, void *, dst, u32, size, > > > const void *, unsafe_ptr) > > > { > > > int ret; > > > > > > + if

Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()

[CC-ing Linus because I quote him.] On Fri, 2017-10-20 at 00:28 +0200, Thomas Gleixner wrote: > Well, that does not explain why > > drivers->cs + i > > would be corrupted. That would require that this cs -> urb link points at > driver magically and then wreckages that driver data

Re: RFC(v2): Audit Kernel Container IDs

The registration is a pseudo filesystem (proc, since PID tree already exists) write of a u8[16] UUID representing the container ID to a file representing a process that will become the first process in a new container.  This write might place restrictions on mount namespaces required to define a

Re: RFC(v2): Audit Kernel Container IDs

The registration is a pseudo filesystem (proc, since PID tree already exists) write of a u8[16] UUID representing the container ID to a file representing a process that will become the first process in a new container. This write might place restrictions on mount namespaces required to define a

Instability of i40e driver on 4.9 kernel

Hi all, We have been running 4.9 kernels for several months on CentOS 7.3 and for few weeks on CentOS 7.4, and, after we replaced 10GbE cobber cards(X540-AT2 with ixgbe driver) with X710 10GbE SFP cards using i40e driver, we noticed sever instabilities on our servers. On several servers the

Re: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down

Alexei Starovoitov wrote: > > @@ -65,6 +65,11 @@ BPF_CALL_3(bpf_probe_read, void *, dst, u32, size, const > > void *, unsafe_ptr) > > { > > int ret; > > > > + if (kernel_is_locked_down("BPF")) { > > + memset(dst, 0, size); > > + return

[PATCH net-next 0/8] tools: bpftool: add a "version" command, and fix several items

Quentin says: The first seven patches of this series bring several minor fixes to bpftool. Please see individual commit logs for details. Last patch adds a "version" commands to bpftool, which is in fact the version of the kernel from which it was compiled. Quentin Monnet (8): tools:

[PATCH net-next 3/8] tools: bpftool: use err() instead of info() if there are too many insns

From: Quentin Monnet Make error messages and return codes more consistent. Specifically, replace the use of info() macro with err() when too many eBPF instructions are received to be dumped, given that bpftool returns with a non-null exit value in that case.

[PATCH net-next 4/8] tools: bpftool: add `bpftool prog help` as real command i.r.t exit code

From: Quentin Monnet Make error messages and return codes more consistent. Specifically, make `bpftool prog help` a real command, instead of printing usage by default for a non-recognized "help" command. Output is the same, but this makes bpftool return with a

[PATCH net-next 8/8] tools: bpftool: add a command to display bpftool version

From: Quentin Monnet This command can be used to print the version of the tool, which is in fact the version from Linux taken from usr/include/linux/version.h. Example usage: $ bpftool version bpftool v4.14.0 Signed-off-by: Quentin Monnet

[PATCH net-next 1/8] tools: bpftool: add pointer to file argument to print_hex()

From: Quentin Monnet Make print_hex() able to print to any file instead of standard output only, and rename it to fprint_hex(). The function can now be called with the info() macro, for example, without splitting the output between standard and error outputs.

[PATCH net-next 7/8] tools: bpftool: show that `opcodes` or `file FILE` should be exclusive

From: Quentin Monnet For the `bpftool prog dump { jited | xlated } ...` command, adding `opcodes` keyword (to request opcodes to be printed) will have no effect if `file FILE` (to write binary output to FILE) is provided. The manual page and the help message to be

[PATCH net-next 5/8] tools: bpftool: print only one error message on byte parsing failure

From: Quentin Monnet Make error messages more consistent. Specifically, when bpftool fails at parsing map key bytes, make it print a single error message to stderr and return from the function, instead of (always) printing a second error message afterwards.

[PATCH net-next 6/8] tools: bpftool: print all relevant byte opcodes for "load double word"

From: Quentin Monnet The eBPF instruction permitting to load double words (8 bytes) into a register need 8-byte long "immediate" field, and thus occupy twice the space of other instructions. bpftool was aware of this and would increment the instruction counter only

[PATCH net-next 2/8] tools: bpftool: fix return value when all eBPF programs have been shown

From: Quentin Monnet Change the program to have a more consistent return code. Specifically, do not make bpftool return an error code simply because it reaches the end of the list of the eBPF programs to show. Signed-off-by: Quentin Monnet

Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()

On Thu, 19 Oct 2017, Paul Bolle wrote: > On Thu, 2017-10-19 at 23:31 +0200, Thomas Gleixner wrote: > > bas_gigaset_exit() > > { > > for (i = 0; i < driver->minors; i++) { > > if (gigaset_shutdown(driver->cs + i) < 0) > > > > gigaset_shutdown(cs) > > { > >

Re: Problems with mvneta

Hi all. First of all I'm not familiar with kernel programming at all, so please excuse me, if I don't understand everything at the first glance. I did as you told me, and moved the mvneta folder from 4.10.10 to 4.13.7: rm -rf linux-4.13.7-gentoo/drivers/net/ethernet/marvell mv

[PATCH v3 net] dccp/tcp: fix ireq->opt races

From: Eric Dumazet syzkaller found another bug in DCCP/TCP stacks [1] For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix ireq->pktopts race"), we need to make sure we do not access ireq->opt unless we own the request sock. [1] BUG: KASAN: use-after-free in

Re: [PATCH net] net: bridge: fix returning of vlan range op errors

On Thu, Oct 19, 2017 at 10:17 AM, Nikolay Aleksandrov wrote: > When vlan tunnels were introduced, vlan range errors got silently > dropped and instead 0 was returned always. Restore the previous > behaviour and return errors to user-space. > > Fixes: efa5356b0d97

Re: [PATCH net] dccp/tcp: fix ireq->opt races

On Thu, Oct 19, 2017 at 3:07 PM, David Miller wrote: > From: Eric Dumazet > Date: Thu, 19 Oct 2017 07:45:09 -0700 > >> Can you send me this v2-net-dccp-tcp-fix-ireq--opt-races.patch file ? >> >> Here the patch applies fine. > > Sure, attached. > > I even

Re: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down

On Thu, Oct 19, 2017 at 03:52:49PM +0100, David Howells wrote: > From: Chun-Yi Lee > > There are some bpf functions can be used to read kernel memory: > bpf_probe_read, bpf_probe_write_user and bpf_trace_printk. These allow > private keys in kernel memory (e.g. the hibernation

Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()

On Thu, 2017-10-19 at 14:31 -0700, Kees Cook wrote: > What I did in many other non-trivial conversions was just add an > explicit pointer back, since that's operationally identical to what > struct timer_list was storing in its .data field. > > i.e. > > add: > > struct cardstate *cs; > > to

Re: [net PATCH] bpf: devmap fix arithmetic overflow in bitmap_size calculation

On Thu, Oct 19, 2017 at 09:03:52AM -0700, John Fastabend wrote: > An integer overflow is possible in dev_map_bitmap_size() when > calculating the BITS_TO_LONG logic which becomes, after macro > replacement, > > (((n) + (d) - 1)/ (d)) > > where 'n' is a __u32 and 'd' is (8 * sizeof(long)).

Re: [PATCH net-next v12] openvswitch: enable NSH support

On Thu, Oct 19, 2017 at 03:41:18PM +0200, Jiri Benc wrote: > On Thu, 19 Oct 2017 21:12:15 +0800, Yang, Yi wrote: > > flow_key in set_nsh is got from netlink message which is set by > > commit_nsh in user space, here is code. > > Isn't this the 'key' local variable that you're talking about, while

Re: [PATCH net] dccp/tcp: fix ireq->opt races

From: Eric Dumazet Date: Thu, 19 Oct 2017 07:45:09 -0700 > Can you send me this v2-net-dccp-tcp-fix-ireq--opt-races.patch file ? > > Here the patch applies fine. Sure, attached. I even just tried it again, same result: [davem@kkuri net]$ git am --signoff

[PATCH] net: smc_close: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I placed a "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva

[PATCH v2] net: rxrpc: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). Please, verify if the actual intention of the code is to

Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()

On Thu, 2017-10-19 at 23:31 +0200, Thomas Gleixner wrote: > bas_gigaset_exit() > { > for (i = 0; i < driver->minors; i++) { > if (gigaset_shutdown(driver->cs + i) < 0) > > gigaset_shutdown(cs) > { > mutex_lock(>mutex); < Explodes here > > So driver->cs + i

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Quoting David Howells : What is the reason? Visual separation. Thanks for clarifying. -- Gustavo A. R. Silva

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Gustavo A. R. Silva wrote: > > No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's > > there for a reason. > > > > What is the reason? Visual separation. David

Re: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

Thu, Oct 19, 2017 at 11:39:55PM CEST, j...@resnulli.us wrote: >Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote: >>> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent >>> config >>> parameter. Defines number of MSI-X vectors allocated per VF. >>> Value is permanent (stored

Re: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote: >> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent >> config >> parameter. Defines number of MSI-X vectors allocated per VF. >> Value is permanent (stored in NVRAM), so becomes the new default >> value for this device. >

Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()

On Thu, 19 Oct 2017, Paul Bolle wrote: > On Thu, 2017-10-19 at 23:03 +0200, Paul Bolle wrote: > > On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote: > > > In preparation for unconditionally passing the struct timer_list pointer > > > to > > > all timer callbacks, switch to using the new

Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()

On Thu, Oct 19, 2017 at 2:20 PM, Paul Bolle wrote: > On Thu, 2017-10-19 at 23:03 +0200, Paul Bolle wrote: >> On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote: >> > In preparation for unconditionally passing the struct timer_list pointer to >> > all timer callbacks, switch to

[PATCH] net: sched: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). Please, verify if the actual intention of the code is to

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Quoting David Howells : Gustavo A. R. Silva wrote: + /* fall through */ All new comments in rxrpc should begin with a capital letter; I'm switching to this as I modify the lines with comments on. Fix checkpatch or gcc or

Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()

On Thu, 2017-10-19 at 23:03 +0200, Paul Bolle wrote: > On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > > all timer callbacks, switch to using the new timer_setup() and from_timer() > > to pass the timer pointer

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Gustavo A. R. Silva wrote: > + /* fall through */ All new comments in rxrpc should begin with a capital letter; I'm switching to this as I modify the lines with comments on. Fix checkpatch or gcc or whatever takes -Wimplicit-fallthrough to stop being silly.

Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()

On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Acked-by: Paul Bolle For

Re: [PATCH net-next v3 2/2] ipv6: remove from fib tree aged out RTF_CACHE dst

On Thu, Oct 19, 2017 at 02:07:11PM +, Paolo Abeni wrote: > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store > dst cache") partially reverted the commit 1e2ea8ad37be ("ipv6: set > dst.obsolete when a cached route has expired"). > > As a result, RTF_CACHE dst referenced outside

Re: [PATCH net-next v3 1/2] ipv6: start fib6 gc on RTF_CACHE dst creation

On Thu, Oct 19, 2017 at 02:07:10PM +, Paolo Abeni wrote: > After the commit 2b760fcf5cfb ("ipv6: hook up exception table > to store dst cache"), the fib6 gc is not started after the > creation of a RTF_CACHE via a redirect or pmtu update, since > fib6_add() isn't invoked anymore for such dsts.

[PATCH v2] ethtool: Do not return error code if no changes were attempted.

From: Ben Greear This makes it easier to properly handle errors when calling this from scripts, etc. Old behaviour: $ ethtool -L eth3 combined 1 combined unmodified, ignoring no channel parameters changed, aborting current values: tx 0 rx 0 other 1 combined 1

[PATCH] ethtool: Do not return error code if no changes were attempted.

From: Ben Greear This makes it easier to properly handle errors when calling this from scripts, etc. Old behaviour: combined unmodified, ignoring no channel parameters changed, aborting current values: tx 0 rx 0 other 1 combined 1 [root@lf0313-6477 ethtool]# echo $? 1

Re: [PATCH 31/58] isdn/gigaset: Use kzalloc instead of open-coded field zeroing

On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote: > This replaces a kmalloc followed by a bunch of per-field zeroing with a > single kzalloc call, reducing the lines of code. Acked-by: Paul Bolle Thanks, Paul Bolle

Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

On Wed, Oct 18, 2017 at 03:18:55PM -0700, Jesus Sanchez-Palencia wrote: > This is great. Just out of curiosity, were you using vlans on your tests? No, just raw packets. VLAN tags could be added trivially (in the program), but that naturally avoids the kernel's VLAN code. > I might try to

Re: [PATCH net-next v2 6/6] bnxt: Add devlink support for config get/set

On Thu, Oct 19, 2017 at 3:35 PM, Jiri Pirko wrote: > Thu, Oct 19, 2017 at 09:17:10PM CEST, steven.l...@broadcom.com wrote: >>Implements get and set of configuration parameters using new devlink >>config get/set API. > > Please split this patch too. One to introduce the infra,

Re: [PATCH net-next v2 2/6] devlink: Adding SR-IOV enablement NVRAM config param

On Thu, Oct 19, 2017 at 3:33 PM, Jiri Pirko wrote: > Thu, Oct 19, 2017 at 09:17:06PM CEST, steven.l...@broadcom.com wrote: >>Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config >>parameter. If value is 1, SR-IOV is enabled. If value is 0, >>SR-IOV is disabled on this

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

On Wed, Oct 18, 2017 at 03:37:35PM -0700, Jesus Sanchez-Palencia wrote: > I also did some tests with when you don't set valid launch times, but here > using > your idea from above, so with the driver calculating a valid launch time (i.e. > current NIC time + X ns, varying X across tests) for

RE: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent > config > parameter. Defines number of MSI-X vectors allocated per VF. > Value is permanent (stored in NVRAM), so becomes the new default > value for this device. Sounds like you're having this enforce the same configuration for all

[PATCH] timer: Provide wrappers safe for use with LOCKDEP

Under LOCKDEP, the timer lock_class_key (set up in __setup_timer) needs to be tied to the caller's context, so an inline for timer_setup() won't work. We do, however, want to keep the inline version around for argument type checking, though, so this provides macro wrappers in the LOCKDEP case.

RE: [PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

> Subject: [PATCH net-next v2 1/6] devlink: Add permanent config parameter > get/set operations > > Add support for permanent config parameter get/set commands. Used > for parameters held in NVRAM, persistent device configuration. Given some of the attributes aren't Boolean, what about an API

Re: [PATCH net-next v3 2/2] ipv6: remove from fib tree aged out RTF_CACHE dst

On Thu, Oct 19, 2017 at 7:07 AM, Paolo Abeni wrote: > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store > dst cache") partially reverted the commit 1e2ea8ad37be ("ipv6: set > dst.obsolete when a cached route has expired"). > > As a result, RTF_CACHE dst

Re: [PATCH net-next 3/3] strparser: Generalize strparser

On 10/19/2017 12:51 PM, Tom Herbert wrote: > On Thu, Oct 19, 2017 at 10:42 AM, Eric Dumazet > wrote: > >> On Fri, 2017-07-28 at 16:22 -0700, Tom Herbert wrote: >>> Generalize strparser from more than just being used in conjunction >>> with read_sock. strparser will also

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

On 10/19/2017 09:54 PM, Mario Hüttel wrote: On 10/19/2017 08:35 PM, Oliver Hartkopp wrote: We already have this 'dsample-point' implemented in the ip tool: $ ip link set vcan0 type can help Usage: ip link set DEVICE type can [ bitrate BITRATE [ sample-point SAMPLE-POINT] ] | [ tq

Re: [PATCH net-next v3 1/2] ipv6: start fib6 gc on RTF_CACHE dst creation

On Thu, Oct 19, 2017 at 7:07 AM, Paolo Abeni wrote: > After the commit 2b760fcf5cfb ("ipv6: hook up exception table > to store dst cache"), the fib6 gc is not started after the > creation of a RTF_CACHE via a redirect or pmtu update, since > fib6_add() isn't invoked anymore for

Re: RFC(v2): Audit Kernel Container IDs

On 2017-10-12 15:45, Steve Grubb wrote: > On Thursday, October 12, 2017 10:14:00 AM EDT Richard Guy Briggs wrote: > > Containers are a userspace concept. The kernel knows nothing of them. > > > > The Linux audit system needs a way to be able to track the container > > provenance of events and

Re: [PATCH] igb: Fix TX map failure path

On Thu, Oct 19, 2017 at 12:07 PM, Jean-Philippe Brucker wrote: > When the driver cannot map a TX buffer, instead of rolling back > gracefully and retrying later, we currently get a panic: > > [ 159.885994] igb :00:00.0: TX DMA map failed > [ 159.886588] Unable

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

On 10/19/2017 08:35 PM, Oliver Hartkopp wrote: > Hi Marc, > > On 10/19/2017 01:26 PM, Marc Kleine-Budde wrote: >> On 10/19/2017 01:14 PM, Oliver Hartkopp wrote: >>> Since we have a netlink socket interface to configure sample >>> point, I >>> wonder if that should be extended to

Re: [PATCH net-next v2 6/6] bnxt: Add devlink support for config get/set

Thu, Oct 19, 2017 at 09:17:10PM CEST, steven.l...@broadcom.com wrote: >Implements get and set of configuration parameters using new devlink >config get/set API. Please split this patch too. One to introduce the infra, one per each config option.

Re: [PATCH net-next v2 2/6] devlink: Adding SR-IOV enablement NVRAM config param

Thu, Oct 19, 2017 at 09:17:06PM CEST, steven.l...@broadcom.com wrote: >Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config >parameter. If value is 1, SR-IOV is enabled. If value is 0, >SR-IOV is disabled on this device. Value is permanent (stored >in NVRAM), so becomes the new default

Re: [PATCH] wanxl: use m68k-linux-gnu-as if available

On Thu, Oct 19, 2017 at 07:25:17PM +0200, Krzysztof Halasa wrote: > David Miller writes: > > > We don't even know if whatever "as68k" is would be the same thing > > as GNU as and generate the same binaries. > > It's GNU as, likewise ld68k, though I have no idea if recent

[PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

Add support for permanent config parameter get/set commands. Used for parameters held in NVRAM, persistent device configuration. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/net/devlink.h| 3 +

[PATCH net-next v2 4/6] devlink: Adding max PF MSI-X vectors NVRAM config param

Adding DEVLINK_PERM_CONFIG_MAX_NUM_PF_MSIX_VECT permanent config parameter. Sets the maximum number of PF MSI-X (Message Signaled Interrupts) vectors. Value is permanent (stored in NVRAM), so becomes the new default value for this device. Signed-off-by: Steve Lin

[PATCH net-next v2 2/6] devlink: Adding SR-IOV enablement NVRAM config param

Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config parameter. If value is 1, SR-IOV is enabled. If value is 0, SR-IOV is disabled on this device. Value is permanent (stored in NVRAM), so becomes the new default value for this device. Signed-off-by: Steve Lin

[PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent config parameter. Defines number of MSI-X vectors allocated per VF. Value is permanent (stored in NVRAM), so becomes the new default value for this device. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek

[PATCH net-next v2 0/6] Adding permanent config get/set to devlink

Changes since v1, based on the excellent feedback received: * Implemented nested parameters correctly this time, I think. * Submitting config get/set infrastructure separately from the parameters themselves, and then submitting just the first four parameters as separate patches. Once this

[PATCH net-next v2 3/6] devlink: Adding num VFs per PF NVRAM config param

Adding DEVLINK_PERM_CONFIG_NUM_VF_PER_PF permanent config parameter, which sets the number of VFs per PF in SR-IOV mode. Value is permanent (stored in NVRAM), so becomes the new default value for this device. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek

[PATCH net-next v2 6/6] bnxt: Add devlink support for config get/set

Implements get and set of configuration parameters using new devlink config get/set API. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 245 +-

[PATCH] net: rxrpc: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). Please, verify if the actual intention of the code is to

[PATCH] igb: Fix TX map failure path

When the driver cannot map a TX buffer, instead of rolling back gracefully and retrying later, we currently get a panic: [ 159.885994] igb :00:00.0: TX DMA map failed [ 159.886588] Unable to handle kernel paging request at virtual address 0a08c7a8 ... [ 159.897031]

[PATCH net] soreuseport: fix initialization race

From: Craig Gallek Syzkaller stumbled upon a way to trigger WARNING: CPU: 1 PID: 13881 at net/core/sock_reuseport.c:41 reuseport_alloc+0x306/0x3b0 net/core/sock_reuseport.c:39 There are two initialization paths for the sock_reuseport structure in a socket: Through the udp/tcp

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

Hi Marc, On 10/19/2017 01:26 PM, Marc Kleine-Budde wrote: On 10/19/2017 01:14 PM, Oliver Hartkopp wrote: Since we have a netlink socket interface to configure sample point, I wonder if that should be extended to configure SSP too (or at least the offset part of SSP)? +1 too The struct

RE: [PATCH 4/7] devlink: Adding perm config of link settings

> On Thu, Oct 19, 2017 at 2:07 AM, Yuval Mintz > wrote: > >> +enum devlink_autoneg_protocol { > >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_BAM, > >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_CONSORTIUM, > >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY, > >> +

Kernel 3.0.35 RT - Kernel OOPS error on enet interrupt

Hi, I'm currently stuck with a Kernel OOPS errors which seems to happen when my system is under heavy load. The steps to reproduce the problem are unknown from me. The bug happens when accessing to the __wake_up_common at the following line:

[PATCH] net: rose: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). Please, verify if the actual intention of the code is to

[PATCH 2/2] net: netrom: refactor code in nr_add_node

Code refactoring in order to make the code easier to read and maintain. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). net/netrom/nr_route.c | 63 --- 1 file changed,

RE: [PATCH 2/7] devlink: Adding NPAR permanent config parameters

> >> DEVLINK_ATTR_PERM_CFG_NPAR_BW_RESERVATION_VALID: 1 to use > >> BW_RESERVATION setting, 0 to ignore. > >> > > ... > >> DEVLINK_ATTR_PERM_CFG_NPAR_BW_LIMIT_VALID: 1 to use BW_LIMIT > >> setting, 0 to ignore. > > > > While it probably ties to different fields in your NVM layout why would the >

  1   2   3   >