Re: [net-next] tcp: do tcp_mstamp_refresh before retransmits on TSQ handler

2017-10-21 Thread Eric Dumazet
On Sun, 2017-10-22 at 13:10 +0900, Koichiro Den wrote: > On Sat, 2017-10-21 at 20:52 -0700, Eric Dumazet wrote: > > On Sun, 2017-10-22 at 12:38 +0900, Koichiro Den wrote: > > > When retransmission on TSQ handler was introduced in the commit > > > f9616c35a0d7 ("tcp: implement TSQ for

[net] tcp: do tcp_mstamp_refresh before retransmits on TSQ handler

2017-10-21 Thread Koichiro Den
When retransmission on TSQ handler was introduced in the commit f9616c35a0d7 ("tcp: implement TSQ for retransmits"), the retransmitted skbs' timestamps were updated on the actual transmission. In the later commit 385e20706fac ("tcp: use tp->tcp_mstamp in output path"), it stops being done so. In

Re: [net-next] tcp: do tcp_mstamp_refresh before retransmits on TSQ handler

2017-10-21 Thread Koichiro Den
On Sat, 2017-10-21 at 20:52 -0700, Eric Dumazet wrote: > On Sun, 2017-10-22 at 12:38 +0900, Koichiro Den wrote: > > When retransmission on TSQ handler was introduced in the commit > > f9616c35a0d7 ("tcp: implement TSQ for retransmits"), the retransmitted > > skbs' timestamps were updated on the

RE: [PATCH 02/15] drivers, net, ethernet: convert mtk_eth.dma_refcnt from atomic_t to refcount_t

2017-10-21 Thread Sean Wang
On Fri, 2017-10-20 at 10:37 +, Reshetova, Elena wrote: > > On Fri, 2017-10-20 at 10:23 +0300, Elena Reshetova wrote: > > > atomic_t variables are currently used to implement reference > > > counters with the following properties: > > > - counter is initialized to 1 using atomic_set() > > > -

Re: [net-next] tcp: do tcp_mstamp_refresh before retransmits on TSQ handler

2017-10-21 Thread Eric Dumazet
On Sun, 2017-10-22 at 12:38 +0900, Koichiro Den wrote: > When retransmission on TSQ handler was introduced in the commit > f9616c35a0d7 ("tcp: implement TSQ for retransmits"), the retransmitted > skbs' timestamps were updated on the actual transmission. In the later > commit 385e20706fac ("tcp:

Re: [net-next] tcp: do tcp_mstamp_refresh before retransmits on TSQ handler

2017-10-21 Thread Eric Dumazet
On Sat, 2017-10-21 at 20:52 -0700, Eric Dumazet wrote: > Very nice catch, thanks a lot Koichiro. > > This IMO would target net tree, since it is a bug fix. > > Fixes: 385e20706fac ("tcp: use tp->tcp_mstamp in output path") Reviewed-by: Eric Dumazet

[net-next] tcp: do tcp_mstamp_refresh before retransmits on TSQ handler

2017-10-21 Thread Koichiro Den
When retransmission on TSQ handler was introduced in the commit f9616c35a0d7 ("tcp: implement TSQ for retransmits"), the retransmitted skbs' timestamps were updated on the actual transmission. In the later commit 385e20706fac ("tcp: use tp->tcp_mstamp in output path"), it stops being done so. In

[GIT] Networking

2017-10-21 Thread David Miller
A little more than usual this time around. Been travelling, so that is part of it. Anyways, here are the highlights: 1) Deal with memcontrol races wrt. listener dismantle, from Eric Dumazet. 2) Handle page allocation failures properly in nfp driver, from Jaku Kicinski. 3) Fix memory

Re: [PATCH] stmmac: Don't access tx_q->dirty_tx before netif_tx_lock

2017-10-21 Thread David Miller
From: Bernd Edlinger Date: Sat, 21 Oct 2017 06:51:30 + > This is the possible reason for different hard to reproduce > problems on my ARMv7-SMP test system. > > The symptoms are in recent kernels imprecise external aborts, > and in older kernels various kinds of

Re: [PATCH net] ipv6: flowlabel: do not leave opt->tot_len with garbage

2017-10-21 Thread David Miller
From: Eric Dumazet Date: Sat, 21 Oct 2017 12:26:23 -0700 > From: Eric Dumazet > > When syzkaller team brought us a C repro for the crash [1] that > had been reported many times in the past, I finally could find > the root cause. > > If FlowLabel

Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-21 Thread David Miller
From: Florian Fainelli Date: Sat, 21 Oct 2017 19:01:45 -0700 > Reviewed-by : Florian Fainelli > > I still can't make sure this is not a problem for multiple PHYs > hanging off the same bus, but like anything else, we'll deal with > problems later if

Re: [PATCH] net: smc_close: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Sat, 21 Oct 2017 20:21:00 -0500 > > Quoting David Miller : > >> From: "Gustavo A. R. Silva" >> Date: Thu, 19 Oct 2017 17:02:44 -0500 >> >>> @@ -360,7 +360,8 @@ static void

Re: [PATCH net-next 0/2] ibmvnic: Tunable parameter support

2017-10-21 Thread David Miller
From: John Allen Date: Fri, 20 Oct 2017 16:00:54 -0500 > This series implements support for changing tunable parameters such as the > mtu, number of tx/rx queues, and number of buffers per queue via ethtool > and ifconfig. These patches do not apply to net-next.

Re: [PATCH] textsearch: fix typos in library helpers

2017-10-21 Thread David Miller
From: Randy Dunlap Date: Fri, 20 Oct 2017 12:15:52 -0700 > From: Randy Dunlap > > Fix spellos (typos) in textsearch library helpers. > > Signed-off-by: Randy Dunlap Applied.

Re: [PATCH net-next 0/3] tun: timer cleanups

2017-10-21 Thread David Miller
From: Eric Dumazet Date: Fri, 20 Oct 2017 11:29:54 -0700 > While working on a syzkaller issue that might have been > fixed already by Cong Wang in commit 0ad646c81b21 > ("tun: call dev_get_valid_name() before register_netdevice()") > I made three small changes related to

Re: [PATCH net-next 0/5] bpf: add support for BASE_RTT

2017-10-21 Thread David Miller
From: Lawrence Brakmo Date: Fri, 20 Oct 2017 11:05:38 -0700 > This patch set adds the following functionality to socket_ops BPF > programs. > 1) Add bpf helper function bpf_getsocketops. Currently only supports >TCP_CONGESTION > 2) Add BPF_SOCKET_OPS_BASE_RTT op to get the

Re: [PATCH] net: af_unix: mark expected switch fall-through

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 20 Oct 2017 12:05:30 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] net: x25: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 20 Oct 2017 12:37:52 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH net-next] nfp: use struct fields for 8 bit-wide access

2017-10-21 Thread David Miller
From: Simon Horman Date: Fri, 20 Oct 2017 19:49:52 +0200 > From: Pieter Jansen van Vuuren > > Use direct access struct fields rather than PREP_FIELD() > macros to manipulate the jump ID and length, both of which > are exactly

Re: [PATCH] net: tipc: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 20 Oct 2017 12:01:26 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva This doesn't apply to

Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-21 Thread Florian Fainelli
On October 21, 2017 6:37:38 PM PDT, David Miller wrote: > >Second ping, this patch needs a review ASAP. > >Geert's hard-resetting PHY changes depend upon this change. Done, same concerns as before and we could all improve on trying to get this tested on a pure SW model (e.g

Re: [PATCH net] rxrpc: Don't release call mutex on error pointer

2017-10-21 Thread David Miller
From: David Howells Date: Fri, 20 Oct 2017 17:01:22 +0100 > Don't release call mutex at the end of rxrpc_kernel_begin_call() if the > call pointer actually holds an error value. > > Fixes: 540b1c48c37a ("rxrpc: Fix deadlock between call creation and > sendmsg/recvmsg") >

Re: [PATCH net-next 0/3] net: stmmac: Fix HW timestamping

2017-10-21 Thread David Miller
From: Jose Abreu Date: Fri, 20 Oct 2017 14:37:33 +0100 > Three fixes for HW timestamping feature, all of them for RX side. Series applied to 'net', thanks.

Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-21 Thread Florian Fainelli
On October 18, 2017 4:54:03 AM PDT, Geert Uytterhoeven wrote: >If an Ethernet PHY is initialized before the interrupt controller it is >connected to, a message like the following is printed: > >irq: no irq domain found for /interrupt-controller@e61c ! > >However,

Re: v4.14-rc3/arm64 DABT exception in atomic_inc() / __skb_clone()

2017-10-21 Thread Wei Wei
I have uploaded the VM core dump [1]. And I don’t know if these logs are helpful in the case of failing to get the C reproducer currently. [1] https://github.com/dotweiba/skb_clone_atomic_inc_bug/blob/master/vmcore.gz 2017/10/21 20:24:32 reproducing crash 'unable to handle kernel paging

Re: [PATCH net-next v2] geneve: Get rid of is_all_zero(), streamline is_tnl_info_zero()

2017-10-21 Thread David Miller
From: Stefano Brivio Date: Fri, 20 Oct 2017 13:31:36 +0200 > No need to re-invent memchr_inv() with !is_all_zero(). While at > it, replace conditional and return clauses with a single return > clause in is_tnl_info_zero(). > > Signed-off-by: Stefano Brivio

Re: [PATCH v3 net-next 0/2] net: dsa: lan9303: Add fdb/mdb methods

2017-10-21 Thread David Miller
From: Egil Hjelmeland Date: Fri, 20 Oct 2017 12:19:08 +0200 > This series add support for accessing and managing the lan9303 ALR > (Address Logic Resolution). > > The first patch add low level functions for accessing the ALR, along > with port_fast_age and

Re: [net-next 1/1] tipc: refactor tipc_sk_timeout() function

2017-10-21 Thread David Miller
From: Jon Maloy Date: Fri, 20 Oct 2017 11:21:32 +0200 > The function tipc_sk_timeout() is more complex than necessary, and > even seems to contain an undetected bug. At one of the occurences > where we renew the timer we just order it with (HZ / 20), instead > of (jiffies

Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-21 Thread David Miller
Second ping, this patch needs a review ASAP. Geert's hard-resetting PHY changes depend upon this change. Thank you.

[PATCH v2] net: smc_close: mark expected switch fall-through

2017-10-21 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I placed the "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva

Re: [PATCH 00/15] networking drivers refcount_t conversions

2017-10-21 Thread David Miller
From: Elena Reshetova Date: Fri, 20 Oct 2017 10:23:34 +0300 > Note: these are the last patches related to networking that perform > conversion of refcounters from atomic_t to refcount_t. > In contrast to the core network refcounter conversions that > were merged

Re: [PATCH] net: smc_close: mark expected switch fall-throughs

2017-10-21 Thread Gustavo A. R. Silva
Quoting David Miller : From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 17:02:44 -0500 @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct work_struct *work) case SMC_PEERCLOSEWAIT1: if

Re: [patch net 0/2] mlxsw: spectrum: Configure TTL of "inherit" for offloaded tunnels

2017-10-21 Thread David Miller
From: Jiri Pirko Date: Fri, 20 Oct 2017 09:16:14 +0200 > From: Jiri Pirko > > Petr says: > > Currently mlxsw only offloads tunnels that are configured with TTL of > "inherit" > (which is the default). However, Spectrum defaults to 255 and the driver >

Re: [PATCH net-next 0/2] Add mac loopback selftest support in hns3 driver

2017-10-21 Thread David Miller
From: Yunsheng Lin Date: Fri, 20 Oct 2017 10:19:20 +0800 > This patchset refactors the skb receiving and transmitting function > before adding mac loopback selftest support in hns3 driver. Series applied.

Re: [PATCH] net: ethtool: remove error check for legacy setting transceiver type

2017-10-21 Thread David Miller
From: Niklas Söderlund Date: Fri, 20 Oct 2017 01:32:08 +0200 > Commit 9cab88726929605 ("net: ethtool: Add back transceiver type") > restores the transceiver type to struct ethtool_link_settings and > convert_link_ksettings_to_legacy_settings() but forgets

[jkirsher/net-queue PATCH] i40e: Add programming descriptors to cleaned_count

2017-10-21 Thread Alexander Duyck
From: Alexander Duyck This patch updates the i40e driver to include programming descriptors in the cleaned_count. Without this change it becomes possible for us to leak memory as we don't trigger a large enough allocation when the time comes to allocate new buffers

Re: [PATCH net-next 0/8] tools: bpftool: add a "version" command, and fix several items

2017-10-21 Thread David Miller
From: Jakub Kicinski Date: Thu, 19 Oct 2017 15:46:18 -0700 > Quentin says: > > The first seven patches of this series bring several minor fixes to > bpftool. Please see individual commit logs for details. > > Last patch adds a "version" commands to bpftool, which

Re: [PATCH] net: smc_close: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 17:02:44 -0500 > @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct work_struct > *work) > case SMC_PEERCLOSEWAIT1: > if (rxflags->peer_done_writing) > sk->sk_state =

Re: [PATCH] net: sched: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 16:28:24 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH net] soreuseport: fix initialization race

2017-10-21 Thread David Miller
From: Craig Gallek Date: Thu, 19 Oct 2017 15:00:29 -0400 > From: Craig Gallek > > Syzkaller stumbled upon a way to trigger > WARNING: CPU: 1 PID: 13881 at net/core/sock_reuseport.c:41 > reuseport_alloc+0x306/0x3b0 net/core/sock_reuseport.c:39 > > There

Re: [PATCH] openvswitch: conntrack: mark expected switch fall-through

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 12:55:03 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I placed a "fall through" comment on > its own

Re: [PATCH] net: rose: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 13:03:51 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] net: netrom: nr_in: mark expected switch fall-through

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 12:43:08 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied to net-next.

Re: [PATCH net] sock: correct sk_wmem_queued accounting on efault in tcp zerocopy

2017-10-21 Thread David Miller
From: Willem de Bruijn Date: Thu, 19 Oct 2017 12:40:39 -0400 > From: Willem de Bruijn > > Syzkaller hits WARN_ON(sk->sk_wmem_queued) in sk_stream_kill_queues > after triggering an EFAULT in __zerocopy_sg_from_iter. > > On this error,

Re: [PATCH net] net: bridge: fix returning of vlan range op errors

2017-10-21 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 19 Oct 2017 20:17:32 +0300 > When vlan tunnels were introduced, vlan range errors got silently > dropped and instead 0 was returned always. Restore the previous > behaviour and return errors to user-space. > > Fixes: efa5356b0d97

[jkirsher/next-queue PATCH] i40e/i40evf: Revert "i40e/i40evf: bump tail only in multiples of 8"

2017-10-21 Thread Alexander Duyck
From: Alexander Duyck This reverts commit 11f29003d6376fb123b7c3779dba49bb56fb0815. I am reverting this as I am fairly certain this can result in a memory leak when combined with the current page recycling scheme. Specifically we end up attempting to allocate fewer

Re: [PATCH net-next 0/2] bridge: make setlink/dellink notifications more accurate

2017-10-21 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 19 Oct 2017 19:10:11 +0300 > Self-NAK > Dave, please ignore this set and apologies for the noise. OK

Re: [PATCH net 0/3] Two BPF fixes for range marking

2017-10-21 Thread David Miller
From: Daniel Borkmann Date: Sat, 21 Oct 2017 02:34:20 +0200 > The set contains two fixes for direct packet access range > markings and test cases for all direct packet access patterns > that the verifier matches on. > > They are targeted for net tree, note that once net

Re: [net PATCH] bpf: devmap fix arithmetic overflow in bitmap_size calculation

2017-10-21 Thread David Miller
From: John Fastabend Date: Thu, 19 Oct 2017 09:03:52 -0700 > An integer overflow is possible in dev_map_bitmap_size() when > calculating the BITS_TO_LONG logic which becomes, after macro > replacement, > > (((n) + (d) - 1)/ (d)) > > where 'n' is a __u32 and

Re: [RFC PATCH] net: realtek: r8169: implement set_link_ksettings()

2017-10-21 Thread Tobias Jakobi
Any comment on this one? I have been using this in my tree since submission. No issues to far. I guess I could also put a Fixes-tag? - Tobias Tobias Jakobi wrote: > Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially > implemented the new ethtool API, by replacing get_settings() > with

Re: [PATCH net-next 3/5] bpf: Add BPF_SOCKET_OPS_BASE_RTT support to tcp_nv

2017-10-21 Thread Alexei Starovoitov
On Fri, Oct 20, 2017 at 11:05:41AM -0700, Lawrence Brakmo wrote: > TCP_NV will try to get the base RTT from a socket_ops BPF program if one > is loaded. NV will then use the base RTT to bound its min RTT (its > notion of the base RTT). It uses the base RTT as an upper bound and 80% > of the base

[PATCH net] ipv6: flowlabel: do not leave opt->tot_len with garbage

2017-10-21 Thread Eric Dumazet
From: Eric Dumazet When syzkaller team brought us a C repro for the crash [1] that had been reported many times in the past, I finally could find the root cause. If FlowLabel info is merged by fl6_merge_options(), we leave part of the opt_space storage provided by

Re: [PATCH net 2/3] bpf: fix pattern matches for direct packet access

2017-10-21 Thread John Fastabend
On 10/20/2017 05:34 PM, Daniel Borkmann wrote: > Alexander had a test program with direct packet access, where > the access test was in the form of data + X > data_end. In an > unrelated change to the program LLVM decided to swap the branches > and emitted code for the test in form of data + X <=

Re: [PATCH net 3/3] bpf: add test cases to bpf selftests to cover all access tests

2017-10-21 Thread John Fastabend
On 10/20/2017 05:34 PM, Daniel Borkmann wrote: > Lets add test cases to cover really all possible direct packet > access tests for good/bad access cases so we keep tracking them. > > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov > ---

Re: [PATCH net 1/3] bpf: fix off by one for range markings with L{T,E} patterns

2017-10-21 Thread John Fastabend
On 10/20/2017 05:34 PM, Daniel Borkmann wrote: > During review I noticed that the current logic for direct packet > access marking in check_cond_jmp_op() has an off by one for the > upper right range border when marking in find_good_pkt_pointers() > with BPF_JLT and BPF_JLE. It's not really

Re: [PATCH net 0/3] Fix for BPF devmap percpu allocation splat

2017-10-21 Thread Tejun Heo
Hello, On Wed, Oct 18, 2017 at 04:45:08PM -0500, Dennis Zhou wrote: > I'm not sure I see the reason we can't match the minimum allocation size > with the unit size? It seems weird to arbitrate the maximum allocation > size given a lower bound on the unit size. idk, it can be weird for the

RE: [PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

2017-10-21 Thread Yuval Mintz
> On Thu, Oct 19, 2017 at 4:21 PM, Yuval Mintz > wrote: > >> Subject: [PATCH net-next v2 1/6] devlink: Add permanent config > parameter > >> get/set operations > >> > >> Add support for permanent config parameter get/set commands. Used > >> for parameters held in NVRAM,

RE: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

2017-10-21 Thread Yuval Mintz
> On Fri, Oct 20, 2017 at 10:10 AM, Jiri Pirko wrote: > > Fri, Oct 20, 2017 at 04:03:55PM CEST, steven.l...@broadcom.com wrote: > >>On Thu, Oct 19, 2017 at 5:39 PM, Jiri Pirko wrote: > >>> Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote: >

Re: [PATCH net 0/7] net: aquantia: Atlantic driver 10/2017 updates

2017-10-21 Thread David Miller
From: Igor Russkikh Date: Thu, 19 Oct 2017 18:23:52 +0300 > This patchset fixes various issues in driver, > improves parameters for better performance on 10Gbit link Series applied.

Re: [PATCH net-next] bnxt: Move generic devlink code to new file

2017-10-21 Thread David Miller
From: Steve Lin Date: Thu, 19 Oct 2017 10:45:56 -0400 > Moving generic devlink code (registration) out of VF-R code > into new bnxt_devlink file, in preparation for future work > to add additional devlink functionality to bnxt. > > Signed-off-by: Steve Lin

Re: [net-next 1/1] tipc: fix broken tipc_poll() function

2017-10-21 Thread David Miller
From: Jon Maloy Date: Thu, 19 Oct 2017 16:42:04 +0200 > In commit ae236fb208a6 ("tipc: receive group membership events via > member socket") we broke the tipc_poll() function by checking the > state of the receive queue before the call to poll_sock_wait(), while > relying

Re: [PATCH net 0/2] net: diag: fix a potential security issue

2017-10-21 Thread David Miller
From: Xin Long Date: Sat, 21 Oct 2017 17:45:09 +0800 > Let's just see if David could accept the patches if I will > remove the "security claim" from changelog, considering > it as an improvement of sock diag. > > David ? No I won't. See my other response. Use

Re: [PATCH net 0/2] net: diag: fix a potential security issue

2017-10-21 Thread David Miller
From: Xin Long Date: Sat, 21 Oct 2017 14:06:27 +0800 > Imagine a customer generates a sosreport on their system, and > with that, it loads sctp module. From then on, if their firewall > doesn't block incoming packets for sctp, they may be prone to some > remotely

Re: [PATCH v3 1/4] phylib: Add device reset GPIO support

2017-10-21 Thread Geert Uytterhoeven
On Sat, Oct 21, 2017 at 12:03 PM, Sergei Shtylyov wrote: > On 10/20/2017 9:11 PM, Florian Fainelli wrote: >>> From: Sergei Shtylyov >>> --- a/drivers/of/of_mdio.c >>> +++ b/drivers/of/of_mdio.c > > [...] >>> >>> @@ -55,10

[PATCH 2/2] slab, slub, slob: convert slab_flags_t to 32-bit

2017-10-21 Thread Alexey Dobriyan
struct kmem_cache::flags is "unsigned long" which is unnecessary on 64-bit as no flags are defined in the higher bits. Switch the field to 32-bit and save some space on x86_64 until such flags appear: add/remove: 0/0 grow/shrink: 0/107 up/down: 0/-657 (-657) function

Re: [PATCH v3 1/4] phylib: Add device reset GPIO support

2017-10-21 Thread Sergei Shtylyov
Hello! On 10/20/2017 9:11 PM, Florian Fainelli wrote: From: Sergei Shtylyov The PHY devices sometimes do have their reset signal (maybe even power supply?) tied to some GPIO and sometimes it also does happen that a boot loader does not leave it deasserted.

Re: [PATCH v5 net-next 01/12] iptunnel: Add common functions to get a tunnel route

2017-10-21 Thread kbuild test robot
Hi Tom, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/gtp-Additional-feature-support-Part-I/20171021-121328 config: arm-iop33x_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce

[PATCH 1/2] slab, slub, slob: add slab_flags_t

2017-10-21 Thread Alexey Dobriyan
Add sparse-checked slab_flags_t for struct kmem_cache::flags (SLAB_POISON, etc). SLAB is bloated temporarily by switching to "unsigned long", but only temporarily. Signed-off-by: Alexey Dobriyan --- fs/ecryptfs/main.c |2 - fs/xfs/kmem.h|2 -

Re: [PATCH net 0/2] net: diag: fix a potential security issue

2017-10-21 Thread Xin Long
On Sat, Oct 21, 2017 at 4:45 PM, Xin Long wrote: > On Sat, Oct 21, 2017 at 3:45 PM, Eric Dumazet wrote: >> On Sat, 2017-10-21 at 14:51 +0800, Xin Long wrote: >>> On Sat, Oct 21, 2017 at 2:18 PM, Eric Dumazet wrote: >>> > On Fri,

Re: [PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

2017-10-21 Thread Jiri Pirko
Fri, Oct 20, 2017 at 05:13:39PM CEST, steven.l...@broadcom.com wrote: >On Fri, Oct 20, 2017 at 10:39 AM, Jiri Pirko wrote: >> Thu, Oct 19, 2017 at 09:17:05PM CEST, steven.l...@broadcom.com wrote: >>>Add support for permanent config parameter get/set commands. Used >>>for

Soliciting

2017-10-21 Thread Kim Sharma
Present Blue sky Studio, is Soliciting for the Right to use Your Photo/Face and Personality as One of the Semi -Major Role/ Character in our Upcoming ANIMATED Stereoscope 3D Movie-The Story of Anubis All Reply to: blueskyentstud...@usa.com

Re: [PATCH net 0/2] net: diag: fix a potential security issue

2017-10-21 Thread Xin Long
On Sat, Oct 21, 2017 at 3:45 PM, Eric Dumazet wrote: > On Sat, 2017-10-21 at 14:51 +0800, Xin Long wrote: >> On Sat, Oct 21, 2017 at 2:18 PM, Eric Dumazet wrote: >> > On Fri, Oct 20, 2017 at 11:06 PM, Xin Long wrote: >> >> >> >>

Re: [PATCH net-next] selftests/bpf: fix broken build of test_maps

2017-10-21 Thread Daniel Borkmann
On 10/21/2017 08:25 AM, Alexei Starovoitov wrote: fix broken tests Fixes: e043325b3087 ("bpf: Add tests for eBPF file mode") Fixes: 6e71b04a8224 ("bpf: Add file mode configuration into bpf maps") Signed-off-by: Alexei Starovoitov --- Chenbo, this was very broken patch

Re: [PATCH net 0/2] net: diag: fix a potential security issue

2017-10-21 Thread Eric Dumazet
On Sat, 2017-10-21 at 14:51 +0800, Xin Long wrote: > On Sat, Oct 21, 2017 at 2:18 PM, Eric Dumazet wrote: > > On Fri, Oct 20, 2017 at 11:06 PM, Xin Long wrote: > >> > >> > >> On Sat, Oct 21, 2017 at 9:27 AM, David Miller wrote: >

[PATCH] stmmac: Don't access tx_q->dirty_tx before netif_tx_lock

2017-10-21 Thread Bernd Edlinger
This is the possible reason for different hard to reproduce problems on my ARMv7-SMP test system. The symptoms are in recent kernels imprecise external aborts, and in older kernels various kinds of network stalls and unexpected page allocation failures. My testing indicates that the trouble

Re: [PATCH net 0/2] net: diag: fix a potential security issue

2017-10-21 Thread Xin Long
On Sat, Oct 21, 2017 at 2:18 PM, Eric Dumazet wrote: > On Fri, Oct 20, 2017 at 11:06 PM, Xin Long wrote: >> >> >> On Sat, Oct 21, 2017 at 9:27 AM, David Miller wrote: >>> >>> From: Xin Long >>> Date: Thu, 19

[PATCH net-next] selftests/bpf: fix broken build of test_maps

2017-10-21 Thread Alexei Starovoitov
fix broken tests Fixes: e043325b3087 ("bpf: Add tests for eBPF file mode") Fixes: 6e71b04a8224 ("bpf: Add file mode configuration into bpf maps") Signed-off-by: Alexei Starovoitov --- Chenbo, this was very broken patch submission. Please make sure to actually compile your tests

Re: [PATCH net 0/2] net: diag: fix a potential security issue

2017-10-21 Thread Eric Dumazet
On Fri, Oct 20, 2017 at 11:06 PM, Xin Long wrote: > > > On Sat, Oct 21, 2017 at 9:27 AM, David Miller wrote: >> >> From: Xin Long >> Date: Thu, 19 Oct 2017 15:32:23 +0800 >> >> > This patch is to void the potential security issue